April 2014 - Wine-Commits - list.winehq.org

Hans Leidekker : msi/tests: Fix a couple of memory leaks (valgrind).
by Alexandre Julliard April 30, 2014

April 30, 2014

Module: wine Branch: master Commit: 4c8edb1b4c25cffeaa1573f431e9931c1fc87042 URL: http://source.winehq.org/git/wine.git/?a=commit;h=4c8edb1b4c25cffeaa1573f43… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Wed Apr 30 10:21:42 2014 +0200 msi/tests: Fix a couple of memory leaks (valgrind). --- dlls/msi/tests/action.c | 8 +++++--- dlls/msi/tests/automation.c | 8 +++++--- dlls/msi/tests/install.c | 8 +++++--- dlls/msi/tests/msi.c | 8 +++++--- dlls/msi/tests/package.c | 8 +++++--- 5 files changed, 25 insertions(+), 15 deletions(-) diff --git a/dlls/msi/tests/action.c b/dlls/msi/tests/action.c index 047854b..9f1651d 100644 --- a/dlls/msi/tests/action.c +++ b/dlls/msi/tests/action.c @@ -2255,20 +2255,22 @@ static void init_functionpointers(void) static BOOL is_process_limited(void) { SID_IDENTIFIER_AUTHORITY NtAuthority = {SECURITY_NT_AUTHORITY}; - PSID Group; + PSID Group = NULL; BOOL IsInGroup; HANDLE token; if (!pCheckTokenMembership || !pOpenProcessToken) return FALSE; if (!AllocateAndInitializeSid(&NtAuthority, 2, SECURITY_BUILTIN_DOMAIN_RID, - DOMAIN_ALIAS_RID_ADMINS, - 0, 0, 0, 0, 0, 0, &Group) || + DOMAIN_ALIAS_RID_ADMINS, 0, 0, 0, 0, 0, 0, &Group) || !pCheckTokenMembership(NULL, Group, &IsInGroup)) { trace("Could not check if the current user is an administrator\n"); + FreeSid(Group); return FALSE; } + FreeSid(Group); + if (!IsInGroup) { /* Only administrators have enough privileges for these tests */ diff --git a/dlls/msi/tests/automation.c b/dlls/msi/tests/automation.c index 242ec63..beed6fd 100644 --- a/dlls/msi/tests/automation.c +++ b/dlls/msi/tests/automation.c @@ -230,20 +230,22 @@ static void init_functionpointers(void) static BOOL is_process_limited(void) { SID_IDENTIFIER_AUTHORITY NtAuthority = {SECURITY_NT_AUTHORITY}; - PSID Group; + PSID Group = NULL; BOOL IsInGroup; HANDLE token; if (!pCheckTokenMembership || !pOpenProcessToken) return FALSE; if (!AllocateAndInitializeSid(&NtAuthority, 2, SECURITY_BUILTIN_DOMAIN_RID, - DOMAIN_ALIAS_RID_ADMINS, - 0, 0, 0, 0, 0, 0, &Group) || + DOMAIN_ALIAS_RID_ADMINS, 0, 0, 0, 0, 0, 0, &Group) || !pCheckTokenMembership(NULL, Group, &IsInGroup)) { trace("Could not check if the current user is an administrator\n"); + FreeSid(Group); return FALSE; } + FreeSid(Group); + if (!IsInGroup) { /* Only administrators have enough privileges for these tests */ diff --git a/dlls/msi/tests/install.c b/dlls/msi/tests/install.c index 603042a..2a9af85 100644 --- a/dlls/msi/tests/install.c +++ b/dlls/msi/tests/install.c @@ -2043,20 +2043,22 @@ static void init_functionpointers(void) static BOOL is_process_limited(void) { SID_IDENTIFIER_AUTHORITY NtAuthority = {SECURITY_NT_AUTHORITY}; - PSID Group; + PSID Group = NULL; BOOL IsInGroup; HANDLE token; if (!pCheckTokenMembership || !pOpenProcessToken) return FALSE; if (!AllocateAndInitializeSid(&NtAuthority, 2, SECURITY_BUILTIN_DOMAIN_RID, - DOMAIN_ALIAS_RID_ADMINS, - 0, 0, 0, 0, 0, 0, &Group) || + DOMAIN_ALIAS_RID_ADMINS, 0, 0, 0, 0, 0, 0, &Group) || !pCheckTokenMembership(NULL, Group, &IsInGroup)) { trace("Could not check if the current user is an administrator\n"); + FreeSid(Group); return FALSE; } + FreeSid(Group); + if (!IsInGroup) { /* Only administrators have enough privileges for these tests */ diff --git a/dlls/msi/tests/msi.c b/dlls/msi/tests/msi.c index 1d63df5..3897c24 100644 --- a/dlls/msi/tests/msi.c +++ b/dlls/msi/tests/msi.c @@ -175,20 +175,22 @@ static BOOL delete_pf(const char *rel_path, BOOL is_file) static BOOL is_process_limited(void) { SID_IDENTIFIER_AUTHORITY NtAuthority = {SECURITY_NT_AUTHORITY}; - PSID Group; + PSID Group = NULL; BOOL IsInGroup; HANDLE token; if (!pCheckTokenMembership || !pOpenProcessToken) return FALSE; if (!AllocateAndInitializeSid(&NtAuthority, 2, SECURITY_BUILTIN_DOMAIN_RID, - DOMAIN_ALIAS_RID_ADMINS, - 0, 0, 0, 0, 0, 0, &Group) || + DOMAIN_ALIAS_RID_ADMINS, 0, 0, 0, 0, 0, 0, &Group) || !pCheckTokenMembership(NULL, Group, &IsInGroup)) { trace("Could not check if the current user is an administrator\n"); + FreeSid(Group); return FALSE; } + FreeSid(Group); + if (!IsInGroup) { /* Only administrators have enough privileges for these tests */ diff --git a/dlls/msi/tests/package.c b/dlls/msi/tests/package.c index d5c37ea..a0c0455 100644 --- a/dlls/msi/tests/package.c +++ b/dlls/msi/tests/package.c @@ -88,20 +88,22 @@ static void init_functionpointers(void) static BOOL is_process_limited(void) { SID_IDENTIFIER_AUTHORITY NtAuthority = {SECURITY_NT_AUTHORITY}; - PSID Group; + PSID Group = NULL; BOOL IsInGroup; HANDLE token; if (!pCheckTokenMembership || !pOpenProcessToken) return FALSE; if (!AllocateAndInitializeSid(&NtAuthority, 2, SECURITY_BUILTIN_DOMAIN_RID, - DOMAIN_ALIAS_RID_ADMINS, - 0, 0, 0, 0, 0, 0, &Group) || + DOMAIN_ALIAS_RID_ADMINS, 0, 0, 0, 0, 0, 0, &Group) || !pCheckTokenMembership(NULL, Group, &IsInGroup)) { trace("Could not check if the current user is an administrator\n"); + FreeSid(Group); return FALSE; } + FreeSid(Group); + if (!IsInGroup) { if (!AllocateAndInitializeSid(&NtAuthority, 2,

1 0

Jacek Caban : vbscript: Allow property getters to take arguments.
by Alexandre Julliard April 30, 2014

April 30, 2014

Module: wine Branch: master Commit: 0f50cb323efb3ee3910421eaac26950b15653c35 URL: http://source.winehq.org/git/wine.git/?a=commit;h=0f50cb323efb3ee3910421eaa… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Apr 30 11:31:30 2014 +0200 vbscript: Allow property getters to take arguments. --- dlls/vbscript/parser.y | 4 ++-- dlls/vbscript/tests/lang.vbs | 27 +++++++++++++++++++++++++++ 2 files changed, 29 insertions(+), 2 deletions(-) diff --git a/dlls/vbscript/parser.y b/dlls/vbscript/parser.y index 6bd4907..c5d1c59 100644 --- a/dlls/vbscript/parser.y +++ b/dlls/vbscript/parser.y @@ -403,8 +403,8 @@ ClassBody | PropertyDecl tNL ClassBody { $$ = add_class_function(ctx, $3, $1); CHECK_ERROR; } PropertyDecl - : Storage_opt tPROPERTY tGET tIdentifier EmptyBrackets_opt tNL StatementsNl_opt tEND tPROPERTY - { $$ = new_function_decl(ctx, $4, FUNC_PROPGET, $1, NULL, $7); CHECK_ERROR; } + : Storage_opt tPROPERTY tGET tIdentifier ArgumentsDecl_opt tNL StatementsNl_opt tEND tPROPERTY + { $$ = new_function_decl(ctx, $4, FUNC_PROPGET, $1, $5, $7); CHECK_ERROR; } | Storage_opt tPROPERTY tLET tIdentifier '(' ArgumentDecl ')' tNL StatementsNl_opt tEND tPROPERTY { $$ = new_function_decl(ctx, $4, FUNC_PROPLET, $1, $6, $9); CHECK_ERROR; } | Storage_opt tPROPERTY tSET tIdentifier '(' ArgumentDecl ')' tNL StatementsNl_opt tEND tPROPERTY diff --git a/dlls/vbscript/tests/lang.vbs b/dlls/vbscript/tests/lang.vbs index d3e8318..c24ffa6 100644 --- a/dlls/vbscript/tests/lang.vbs +++ b/dlls/vbscript/tests/lang.vbs @@ -849,6 +849,10 @@ Class TestClass Call ok(getVT(publicProp2) = "VT_I2*", "getVT(publicProp2) = " & getVT(publicProp2)) Call ok(getVT(Me.publicProp2) = "VT_I2", "getVT(Me.publicProp2) = " & getVT(Me.publicProp2)) End Sub + + Property Get gsGetProp(x) + gsGetProp = x + End Property End Class Call testDisp(new testClass) @@ -916,6 +920,29 @@ Call ok(funcCalled = "terminate", "funcCalled = " & funcCalled) Call (New testclass).publicSub() Call (New testclass).publicSub +class PropTest + property get prop0() + prop0 = 1 + end property + + property get prop1(x) + prop1 = x+1 + end property + + property get prop2(x, y) + prop2 = x+y + end property +end class + +set obj = new PropTest + +call ok(obj.prop0 = 1, "obj.prop0 = " & obj.prop0) +call ok(obj.prop1(3) = 4, "obj.prop1(3) = " & obj.prop1(3)) +call ok(obj.prop2(3,4) = 7, "obj.prop2(3,4) = " & obj.prop2(3,4)) +call obj.prop0() +call obj.prop1(2) +call obj.prop2(3,4) + x = "following ':' is correct syntax" : x = "following ':' is correct syntax" :: : :: x = "also correct syntax"

1 0

Victor Martinez Calvo : dbghelp: Fix invalid assignment in symt_fill_sym_info.
by Alexandre Julliard April 30, 2014

April 30, 2014

Module: wine Branch: master Commit: 9eca0aa8a7d099fd4866d8f4764e39ab7be4cd83 URL: http://source.winehq.org/git/wine.git/?a=commit;h=9eca0aa8a7d099fd4866d8f47… Author: Victor Martinez Calvo <vmartinez(a)reactos.org> Date: Tue Apr 29 17:39:46 2014 +0200 dbghelp: Fix invalid assignment in symt_fill_sym_info. --- dlls/dbghelp/symbol.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/dbghelp/symbol.c b/dlls/dbghelp/symbol.c index a82d1df..3e7877a 100644 --- a/dlls/dbghelp/symbol.c +++ b/dlls/dbghelp/symbol.c @@ -696,8 +696,8 @@ static void symt_fill_sym_info(struct module_pair* pair, if (sym_info->MaxNameLen) { if (sym->tag != SymTagPublicSymbol || !(dbghelp_options & SYMOPT_UNDNAME) || - (sym_info->NameLen = UnDecorateSymbolName(name, sym_info->Name, - sym_info->MaxNameLen, UNDNAME_NAME_ONLY) == 0)) + ((sym_info->NameLen = UnDecorateSymbolName(name, sym_info->Name, + sym_info->MaxNameLen, UNDNAME_NAME_ONLY)) == 0)) { sym_info->NameLen = min(strlen(name), sym_info->MaxNameLen - 1); memcpy(sym_info->Name, name, sym_info->NameLen);

1 0

Hans Leidekker : wbemprox: Return selected properties only from IWbemClassObject::GetNames.
by Alexandre Julliard April 30, 2014

April 30, 2014

Module: wine Branch: master Commit: c9abb27d89b7a531c0a873264cc0ac3eb04ff624 URL: http://source.winehq.org/git/wine.git/?a=commit;h=c9abb27d89b7a531c0a873264… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Wed Apr 30 10:18:39 2014 +0200 wbemprox: Return selected properties only from IWbemClassObject::GetNames. --- dlls/wbemprox/query.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dlls/wbemprox/query.c b/dlls/wbemprox/query.c index fdfcc16..e4c4fcd 100644 --- a/dlls/wbemprox/query.c +++ b/dlls/wbemprox/query.c @@ -964,7 +964,7 @@ HRESULT get_properties( const struct view *view, LONG flags, SAFEARRAY **props ) SAFEARRAY *sa; BSTR str; LONG i; - UINT num_props = count_properties( view ); + UINT num_props = count_selected_properties( view ); if (!(sa = SafeArrayCreateVector( VT_BSTR, 0, num_props ))) return E_OUTOFMEMORY; @@ -973,6 +973,7 @@ HRESULT get_properties( const struct view *view, LONG flags, SAFEARRAY **props ) BOOL is_system; if (is_method( view->table, i )) continue; + if (!is_selected_prop( view, view->table->columns[i].name )) continue; is_system = is_system_prop( view->table->columns[i].name ); if ((flags & WBEM_FLAG_NONSYSTEM_ONLY) && is_system) continue;

1 0

Jacek Caban : vbscript: Added InvokeEx(DISPATCH_PROPERTYGET) implementation.
by Alexandre Julliard April 30, 2014

April 30, 2014

Module: wine Branch: master Commit: b4d30e92c91febe8658e8b5a18a34cd64570b38d URL: http://source.winehq.org/git/wine.git/?a=commit;h=b4d30e92c91febe8658e8b5a1… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Apr 30 11:31:56 2014 +0200 vbscript: Added InvokeEx(DISPATCH_PROPERTYGET) implementation. --- dlls/vbscript/tests/run.c | 36 +++++++++++++++++++++++++++++++++++- dlls/vbscript/vbdisp.c | 9 +++++++++ 2 files changed, 44 insertions(+), 1 deletion(-) diff --git a/dlls/vbscript/tests/run.c b/dlls/vbscript/tests/run.c index fe611ff..53ead45 100644 --- a/dlls/vbscript/tests/run.c +++ b/dlls/vbscript/tests/run.c @@ -244,7 +244,7 @@ static IServiceProvider caller_sp = { &ServiceProviderVtbl }; static void test_disp(IDispatch *disp) { - DISPID id, public_prop_id, public_prop2_id, public_func_id, public_sub_id, defvalget_id; + DISPID id, public_prop_id, public_prop2_id, public_func_id, public_sub_id, defvalget_id, gs_getter_id; DISPID named_args[5] = {DISPID_PROPERTYPUT}; VARIANT v, args[5]; DISPPARAMS dp = {args, named_args}; @@ -443,6 +443,40 @@ static void test_disp(IDispatch *disp) ok(hres == S_OK, "GetDispID(publicProp) failed: %08x\n", hres); ok(id == public_prop_id, "id = %d, expected %d\n", id, public_prop_id); + str = a2bstr("gsGetProp"); + hres = IDispatchEx_GetDispID(dispex, str, fdexNameCaseInsensitive, &gs_getter_id); + SysFreeString(str); + ok(hres == S_OK, "GetDispID(publicFunction) failed: %08x\n", hres); + ok(gs_getter_id != -1, "gs_getter_id = -1\n"); + + V_VT(args) = VT_BOOL; + V_BOOL(args) = VARIANT_TRUE; + dp.cNamedArgs = 0; + dp.cArgs = 1; + V_VT(&v) = VT_I8; + hres = IDispatchEx_InvokeEx(dispex, gs_getter_id, 0, DISPATCH_PROPERTYGET, &dp, &v, &ei, NULL); + ok(hres == S_OK, "InvokeEx failed: %08x\n", hres); + ok(V_VT(&v) == VT_BOOL && V_BOOL(&v), "V_VT(v) = %d\n", V_VT(&v)); + + hres = IDispatchEx_InvokeEx(dispex, gs_getter_id, 0, DISPATCH_PROPERTYGET, &dp, NULL, &ei, NULL); + ok(hres == S_OK, "InvokeEx failed: %08x\n", hres); + + V_VT(args) = VT_BOOL; + V_BOOL(args) = VARIANT_FALSE; + dp.cArgs = 1; + V_VT(&v) = VT_I8; + hres = IDispatchEx_InvokeEx(dispex, gs_getter_id, 0, DISPATCH_PROPERTYGET|DISPATCH_METHOD, &dp, &v, &ei, NULL); + ok(hres == S_OK, "InvokeEx failed: %08x\n", hres); + ok(V_VT(&v) == VT_BOOL && !V_BOOL(&v), "V_VT(v) = %d\n", V_VT(&v)); + + V_VT(args) = VT_BOOL; + V_BOOL(args) = VARIANT_TRUE; + V_VT(&v) = VT_I8; + dp.cArgs = 1; + hres = IDispatchEx_InvokeEx(dispex, gs_getter_id, 0, DISPATCH_METHOD, &dp, &v, &ei, NULL); + ok(hres == S_OK, "InvokeEx failed: %08x\n", hres); + ok(V_VT(&v) == VT_BOOL && V_BOOL(&v), "V_VT(v) = %d\n", V_VT(&v)); + IDispatchEx_Release(dispex); } diff --git a/dlls/vbscript/vbdisp.c b/dlls/vbscript/vbdisp.c index e8fb107..99f975a 100644 --- a/dlls/vbscript/vbdisp.c +++ b/dlls/vbscript/vbdisp.c @@ -391,6 +391,15 @@ static HRESULT WINAPI DispatchEx_InvokeEx(IDispatchEx *iface, DISPID id, LCID lc function_t *func; switch(wFlags) { + case DISPATCH_PROPERTYGET: + func = This->desc->funcs[id].entries[VBDISP_CALLGET]; + if(!func || (func->type != FUNC_PROPGET && func->type != FUNC_DEFGET)) { + WARN("no getter\n"); + return DISP_E_MEMBERNOTFOUND; + } + + return exec_script(This->desc->ctx, func, This, pdp, pvarRes); + case DISPATCH_METHOD: case DISPATCH_METHOD|DISPATCH_PROPERTYGET: func = This->desc->funcs[id].entries[VBDISP_CALLGET];

1 0

Victor Martinez Calvo : msvcrt: Avoid null dereference in TRACE in MSVCRT__wfreopen.
by Alexandre Julliard April 30, 2014

April 30, 2014

Module: wine Branch: master Commit: f6bb1a51a96fb550f9d5cc4f208364c11147c9e7 URL: http://source.winehq.org/git/wine.git/?a=commit;h=f6bb1a51a96fb550f9d5cc4f2… Author: Victor Martinez Calvo <vmartinez(a)reactos.org> Date: Tue Apr 29 17:43:26 2014 +0200 msvcrt: Avoid null dereference in TRACE in MSVCRT__wfreopen. --- dlls/msvcrt/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/msvcrt/file.c b/dlls/msvcrt/file.c index aff5a89..957cfaf 100644 --- a/dlls/msvcrt/file.c +++ b/dlls/msvcrt/file.c @@ -4040,7 +4040,7 @@ MSVCRT_FILE* CDECL MSVCRT__wfreopen(const MSVCRT_wchar_t *path, const MSVCRT_wch { int open_flags, stream_flags, fd; - TRACE(":path (%s) mode (%s) file (%p) fd (%d)\n", debugstr_w(path), debugstr_w(mode), file, file->_file); + TRACE(":path (%s) mode (%s) file (%p) fd (%d)\n", debugstr_w(path), debugstr_w(mode), file, file ? file->_file : -1); LOCK_FILES(); if (!file || ((fd = file->_file) < 0) || fd > MSVCRT_fdend)

1 0

Frédéric Delanoy : Assorted spelling/ grammar fixes.
by Alexandre Julliard April 30, 2014

April 30, 2014

Module: wine Branch: master Commit: 2e5cb7aac869fab43f76f267a77d72b3384c7d2d URL: http://source.winehq.org/git/wine.git/?a=commit;h=2e5cb7aac869fab43f76f267a… Author: Frédéric Delanoy <frederic.delanoy(a)gmail.com> Date: Wed Apr 30 15:42:10 2014 +0200 Assorted spelling/grammar fixes. --- dlls/comctl32/imagelist.c | 6 +++--- dlls/comdlg32/filedlg.c | 2 +- dlls/d3dx9_36/tests/math.c | 2 +- dlls/ddraw/device.c | 8 ++++---- dlls/dmime/segment.c | 2 +- dlls/gdi32/bitmap.c | 2 +- dlls/gphoto2.ds/gphoto2_main.c | 2 +- dlls/imm32/tests/imm32.c | 2 +- dlls/inetmib1/tests/main.c | 2 +- dlls/kernel32/tests/sync.c | 2 +- dlls/mstask/tests/task_scheduler.c | 2 +- dlls/ole32/compobj.c | 4 ++-- dlls/oleaut32/tests/safearray.c | 2 +- dlls/quartz/regsvr.c | 2 +- dlls/riched20/reader.c | 2 +- dlls/shell32/tests/shlfileop.c | 12 ++++++------ 16 files changed, 27 insertions(+), 27 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=2e5cb7aac869fab43f76f…

1 0

Piotr Caban : msvcrt: Handle seh exception rethrowing in catch_function_nested_handler.
by Alexandre Julliard April 30, 2014

April 30, 2014

Module: wine Branch: master Commit: b5b454c5046fffdfbdb0923b530f1afbadc5ff2c URL: http://source.winehq.org/git/wine.git/?a=commit;h=b5b454c5046fffdfbdb0923b5… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Wed Apr 30 13:50:25 2014 +0200 msvcrt: Handle seh exception rethrowing in catch_function_nested_handler. --- dlls/msvcrt/except_i386.c | 23 ++++++++++++++++------- 1 file changed, 16 insertions(+), 7 deletions(-) diff --git a/dlls/msvcrt/except_i386.c b/dlls/msvcrt/except_i386.c index 0481282..7f521cc 100644 --- a/dlls/msvcrt/except_i386.c +++ b/dlls/msvcrt/except_i386.c @@ -374,23 +374,28 @@ static DWORD catch_function_nested_handler( EXCEPTION_RECORD *rec, EXCEPTION_REG { PEXCEPTION_RECORD prev_rec = nested_frame->rec; if((rec->ExceptionInformation[1] == 0 && rec->ExceptionInformation[2] == 0) || - (rec->ExceptionInformation[1] == prev_rec->ExceptionInformation[1] && + (prev_rec->ExceptionCode == CXX_EXCEPTION && + rec->ExceptionInformation[1] == prev_rec->ExceptionInformation[1] && rec->ExceptionInformation[2] == prev_rec->ExceptionInformation[2])) { /* exception was rethrown */ - rec->ExceptionInformation[1] = prev_rec->ExceptionInformation[1]; - rec->ExceptionInformation[2] = prev_rec->ExceptionInformation[2]; - TRACE("detect rethrow: re-propagate: obj: %lx, type: %lx\n", - rec->ExceptionInformation[1], rec->ExceptionInformation[2]); + *rec = *prev_rec; + rec->ExceptionFlags &= ~EH_UNWINDING; + if(TRACE_ON(seh)) { + TRACE("detect rethrow: exception code: %x\n", rec->ExceptionCode); + if(rec->ExceptionCode == CXX_EXCEPTION) + TRACE("re-propage: obj: %lx, type: %lx\n", + rec->ExceptionInformation[1], rec->ExceptionInformation[2]); + } } - else if (nested_frame->prev_rec && + else if (nested_frame->prev_rec && nested_frame->prev_rec->ExceptionCode == CXX_EXCEPTION && nested_frame->prev_rec->ExceptionInformation[1] == prev_rec->ExceptionInformation[1] && nested_frame->prev_rec->ExceptionInformation[2] == prev_rec->ExceptionInformation[2]) { TRACE("detect threw new exception in catch block - not owning old(obj: %lx type: %lx)\n", prev_rec->ExceptionInformation[1], prev_rec->ExceptionInformation[2]); } - else { + else if (prev_rec->ExceptionCode == CXX_EXCEPTION) { /* new exception in exception handler, destroy old */ void *object = (void*)prev_rec->ExceptionInformation[1]; cxx_exception_type *info = (cxx_exception_type*) prev_rec->ExceptionInformation[2]; @@ -399,6 +404,10 @@ static DWORD catch_function_nested_handler( EXCEPTION_RECORD *rec, EXCEPTION_REG if(info && info->destructor) call_dtor( info->destructor, object ); } + else + { + TRACE("detect threw new exception in catch block\n"); + } } return cxx_frame_handler( rec, nested_frame->cxx_frame, context,

1 0

Hans Leidekker : wbemprox: Return selected properties only from IWbemClassObject::Next.
by Alexandre Julliard April 30, 2014

April 30, 2014

Module: wine Branch: master Commit: 8343aed4c299b691d76b2c6f3554cd98b6ee2ffd URL: http://source.winehq.org/git/wine.git/?a=commit;h=8343aed4c299b691d76b2c6f3… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Wed Apr 30 10:19:30 2014 +0200 wbemprox: Return selected properties only from IWbemClassObject::Next. --- dlls/wbemprox/class.c | 29 ++++++++++++++++++----------- dlls/wbemprox/query.c | 4 ++-- dlls/wbemprox/table.c | 25 ------------------------- dlls/wbemprox/wbemprox_private.h | 3 ++- 4 files changed, 22 insertions(+), 39 deletions(-) diff --git a/dlls/wbemprox/class.c b/dlls/wbemprox/class.c index 5a9e2e4..afb9f8c 100644 --- a/dlls/wbemprox/class.c +++ b/dlls/wbemprox/class.c @@ -511,23 +511,30 @@ static HRESULT WINAPI class_object_Next( CIMTYPE *pType, LONG *plFlavor ) { - struct class_object *co = impl_from_IWbemClassObject( iface ); - struct enum_class_object *ec = impl_from_IEnumWbemClassObject( co->iter ); - struct view *view = ec->query->view; - BSTR property; + struct class_object *obj = impl_from_IWbemClassObject( iface ); + struct enum_class_object *iter = impl_from_IEnumWbemClassObject( obj->iter ); + struct view *view = iter->query->view; + BSTR prop; HRESULT hr; + UINT i; TRACE("%p, %08x, %p, %p, %p, %p\n", iface, lFlags, strName, pVal, pType, plFlavor); - if (!(property = get_property_name( co->name, co->index_property ))) return WBEM_S_NO_MORE_DATA; - if ((hr = get_propval( view, co->index, property, pVal, pType, plFlavor ) != S_OK)) + for (i = obj->index_property; i < view->table->num_cols; i++) { - SysFreeString( property ); - return hr; + if (is_method( view->table, i )) continue; + if (!is_selected_prop( view, view->table->columns[i].name )) continue; + if (!(prop = SysAllocString( view->table->columns[i].name ))) return E_OUTOFMEMORY; + if ((hr = get_propval( view, obj->index, prop, pVal, pType, plFlavor )) != S_OK) + { + SysFreeString( prop ); + return hr; + } + obj->index_property = i + 1; + *strName = prop; + return S_OK; } - *strName = property; - co->index_property++; - return S_OK; + return WBEM_S_NO_MORE_DATA; } static HRESULT WINAPI class_object_EndEnumeration( diff --git a/dlls/wbemprox/query.c b/dlls/wbemprox/query.c index e4c4fcd..c97b52b 100644 --- a/dlls/wbemprox/query.c +++ b/dlls/wbemprox/query.c @@ -424,7 +424,7 @@ done: return hr; } -static BOOL is_selected_prop( const struct view *view, const WCHAR *name ) +BOOL is_selected_prop( const struct view *view, const WCHAR *name ) { const struct property *prop = view->proplist; @@ -563,7 +563,7 @@ done: return ret; } -static inline BOOL is_method( const struct table *table, UINT column ) +BOOL is_method( const struct table *table, UINT column ) { return table->columns[column].type & COL_FLAG_METHOD; } diff --git a/dlls/wbemprox/table.c b/dlls/wbemprox/table.c index bbd3f5e..7a5b1c1 100644 --- a/dlls/wbemprox/table.c +++ b/dlls/wbemprox/table.c @@ -406,28 +406,3 @@ BSTR get_method_name( const WCHAR *class, UINT index ) release_table( table ); return NULL; } - -BSTR get_property_name( const WCHAR *class, UINT index ) -{ - struct table *table; - UINT i, count = 0; - BSTR ret; - - if (!(table = grab_table( class ))) return NULL; - - for (i = 0; i < table->num_cols; i++) - { - if (!(table->columns[i].type & COL_FLAG_METHOD)) - { - if (index == count) - { - ret = SysAllocString( table->columns[i].name ); - release_table( table ); - return ret; - } - count++; - } - } - release_table( table ); - return NULL; -} diff --git a/dlls/wbemprox/wbemprox_private.h b/dlls/wbemprox/wbemprox_private.h index c047ac1..0eeb0c7 100644 --- a/dlls/wbemprox/wbemprox_private.h +++ b/dlls/wbemprox/wbemprox_private.h @@ -192,6 +192,7 @@ HRESULT get_column_index( const struct table *, const WCHAR *, UINT * ) DECLSPEC HRESULT get_value( const struct table *, UINT, UINT, LONGLONG * ) DECLSPEC_HIDDEN; BSTR get_value_bstr( const struct table *, UINT, UINT ) DECLSPEC_HIDDEN; HRESULT set_value( const struct table *, UINT, UINT, LONGLONG, CIMTYPE ) DECLSPEC_HIDDEN; +BOOL is_method( const struct table *, UINT ) DECLSPEC_HIDDEN; HRESULT get_method( const struct table *, const WCHAR *, class_method ** ) DECLSPEC_HIDDEN; HRESULT get_propval( const struct view *, UINT, const WCHAR *, VARIANT *, CIMTYPE *, LONG * ) DECLSPEC_HIDDEN; @@ -200,10 +201,10 @@ HRESULT to_longlong( VARIANT *, LONGLONG *, CIMTYPE * ) DECLSPEC_HIDDEN; SAFEARRAY *to_safearray( const struct array *, CIMTYPE ) DECLSPEC_HIDDEN; VARTYPE to_vartype( CIMTYPE ) DECLSPEC_HIDDEN; void destroy_array( struct array *, CIMTYPE ) DECLSPEC_HIDDEN; +BOOL is_selected_prop( const struct view *, const WCHAR * ) DECLSPEC_HIDDEN; HRESULT get_properties( const struct view *, LONG, SAFEARRAY ** ) DECLSPEC_HIDDEN; HRESULT get_object( const WCHAR *, IWbemClassObject ** ) DECLSPEC_HIDDEN; BSTR get_method_name( const WCHAR *, UINT ) DECLSPEC_HIDDEN; -BSTR get_property_name( const WCHAR *, UINT ) DECLSPEC_HIDDEN; void set_variant( VARTYPE, LONGLONG, void *, VARIANT * ) DECLSPEC_HIDDEN; HRESULT create_signature( const WCHAR *, const WCHAR *, enum param_direction, IWbemClassObject ** ) DECLSPEC_HIDDEN;

1 0

Hans Leidekker : wmiutils: Fix a memory leak (valgrind).
by Alexandre Julliard April 30, 2014

April 30, 2014

Module: wine Branch: master Commit: 582c5fde998096b4726407356fc8064ea4e382c9 URL: http://source.winehq.org/git/wine.git/?a=commit;h=582c5fde998096b4726407356… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Wed Apr 30 10:21:06 2014 +0200 wmiutils: Fix a memory leak (valgrind). --- dlls/wmiutils/path.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/dlls/wmiutils/path.c b/dlls/wmiutils/path.c index 647724f..b2b4945 100644 --- a/dlls/wmiutils/path.c +++ b/dlls/wmiutils/path.c @@ -313,8 +313,11 @@ static void init_path( struct path *path ) static void clear_path( struct path *path ) { + unsigned int i; + heap_free( path->text ); heap_free( path->server ); + for (i = 0; i < path->num_namespaces; i++) heap_free( path->namespaces[i] ); heap_free( path->namespaces ); heap_free( path->len_namespaces ); heap_free( path->class );

1 0