April 2014 - Wine-Commits - list.winehq.org

André Hentschel : dbghelp: Use boolean return value in boolean function.
by Alexandre Julliard April 29, 2014

April 29, 2014

Module: wine Branch: master Commit: 1986dabc3e159263422019fce60a2eaa006a4fc9 URL: http://source.winehq.org/git/wine.git/?a=commit;h=1986dabc3e159263422019fce… Author: André Hentschel <nerv(a)dawncrow.de> Date: Mon Apr 28 20:04:41 2014 +0200 dbghelp: Use boolean return value in boolean function. --- dlls/dbghelp/type.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/dbghelp/type.c b/dlls/dbghelp/type.c index 012af5f..c0ffaa0 100644 --- a/dlls/dbghelp/type.c +++ b/dlls/dbghelp/type.c @@ -693,7 +693,7 @@ BOOL symt_get_info(struct module* module, const struct symt* type, symt_get_tag_str(type->tag)); /* fall through */ case SymTagFunctionType: - return 0; + return FALSE; } break;

1 0

André Hentschel : winemenubuilder: Return FALSE on error when processing links and URLs.
by Alexandre Julliard April 29, 2014

April 29, 2014

Module: wine Branch: master Commit: aa831198c2664be0223e345e7c4be9307a3c3498 URL: http://source.winehq.org/git/wine.git/?a=commit;h=aa831198c2664be0223e345e7… Author: André Hentschel <nerv(a)dawncrow.de> Date: Mon Apr 28 20:10:23 2014 +0200 winemenubuilder: Return FALSE on error when processing links and URLs. --- programs/winemenubuilder/winemenubuilder.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/programs/winemenubuilder/winemenubuilder.c b/programs/winemenubuilder/winemenubuilder.c index ca58a4a..4675369 100644 --- a/programs/winemenubuilder/winemenubuilder.c +++ b/programs/winemenubuilder/winemenubuilder.c @@ -3216,14 +3216,14 @@ static BOOL Process_Link( LPCWSTR linkname, BOOL bWait ) if( !linkname[0] ) { WINE_ERR("link name missing\n"); - return TRUE; + return FALSE; } len=GetFullPathNameW( linkname, MAX_PATH, fullname, NULL ); if (len==0 || len>MAX_PATH) { WINE_ERR("couldn't get full path of link file\n"); - return TRUE; + return FALSE; } r = CoCreateInstance( &CLSID_ShellLink, NULL, CLSCTX_INPROC_SERVER, @@ -3231,14 +3231,14 @@ static BOOL Process_Link( LPCWSTR linkname, BOOL bWait ) if( FAILED( r ) ) { WINE_ERR("No IID_IShellLink\n"); - return TRUE; + return FALSE; } r = IShellLinkW_QueryInterface( sl, &IID_IPersistFile, (LPVOID*) &pf ); if( FAILED( r ) ) { WINE_ERR("No IID_IPersistFile\n"); - return TRUE; + return FALSE; } r = IPersistFile_Load( pf, fullname, STGM_READ ); @@ -3277,14 +3277,14 @@ static BOOL Process_URL( LPCWSTR urlname, BOOL bWait ) if( !urlname[0] ) { WINE_ERR("URL name missing\n"); - return TRUE; + return FALSE; } len=GetFullPathNameW( urlname, MAX_PATH, fullname, NULL ); if (len==0 || len>MAX_PATH) { WINE_ERR("couldn't get full path of URL file\n"); - return TRUE; + return FALSE; } r = CoCreateInstance( &CLSID_InternetShortcut, NULL, CLSCTX_INPROC_SERVER, @@ -3292,14 +3292,14 @@ static BOOL Process_URL( LPCWSTR urlname, BOOL bWait ) if( FAILED( r ) ) { WINE_ERR("No IID_IUniformResourceLocatorW\n"); - return TRUE; + return FALSE; } r = url->lpVtbl->QueryInterface( url, &IID_IPersistFile, (LPVOID*) &pf ); if( FAILED( r ) ) { WINE_ERR("No IID_IPersistFile\n"); - return TRUE; + return FALSE; } r = IPersistFile_Load( pf, fullname, STGM_READ ); if( SUCCEEDED( r ) )

1 0

Jacek Caban : jscript: Fixed uninitialized variable access in interp_end_finally.
by Alexandre Julliard April 29, 2014

April 29, 2014

Module: wine Branch: master Commit: 2d752d1a93235b15a902a0133d4b88d86cd19298 URL: http://source.winehq.org/git/wine.git/?a=commit;h=2d752d1a93235b15a902a0133… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Tue Apr 29 10:17:38 2014 +0200 jscript: Fixed uninitialized variable access in interp_end_finally. --- dlls/jscript/engine.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/dlls/jscript/engine.c b/dlls/jscript/engine.c index a84faec..942d10c 100644 --- a/dlls/jscript/engine.c +++ b/dlls/jscript/engine.c @@ -795,18 +795,17 @@ static HRESULT interp_end_finally(exec_ctx_t *ctx) TRACE("\n"); - assert(is_bool(stack_top(ctx))); - if(!get_bool(stack_top(ctx))) { - TRACE("passing exception\n"); + v = stack_pop(ctx); + assert(is_bool(v)); - jsval_release(v); - stack_popn(ctx, 1); + if(!get_bool(v)) { + TRACE("passing exception\n"); ctx->script->ei.val = stack_pop(ctx); return DISP_E_EXCEPTION; } - stack_popn(ctx, 2); + stack_pop(ctx); return S_OK; }

1 0

Andrew Eikum : user32: Only update listbox horizontal scroll info if WS_HSCROLL is set.
by Alexandre Julliard April 28, 2014

April 28, 2014

Module: wine Branch: master Commit: cb1242a8f286f00faece961616d613149166325a URL: http://source.winehq.org/git/wine.git/?a=commit;h=cb1242a8f286f00faece96161… Author: Andrew Eikum <aeikum(a)codeweavers.com> Date: Mon Apr 28 11:16:15 2014 -0500 user32: Only update listbox horizontal scroll info if WS_HSCROLL is set. --- dlls/user32/listbox.c | 20 +++++++++++--------- dlls/user32/tests/listbox.c | 42 ++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 53 insertions(+), 9 deletions(-) diff --git a/dlls/user32/listbox.c b/dlls/user32/listbox.c index d17797b..4853c3f 100644 --- a/dlls/user32/listbox.c +++ b/dlls/user32/listbox.c @@ -265,17 +265,14 @@ static void LISTBOX_UpdateScroll( LB_DESCR *descr ) if (descr->style & WS_VSCROLL) SetScrollInfo( descr->self, SB_VERT, &info, TRUE ); - if (descr->horz_extent) + if (descr->style & WS_HSCROLL) { - info.nMin = 0; - info.nMax = descr->horz_extent - 1; info.nPos = descr->horz_pos; info.nPage = descr->width; - info.fMask = SIF_RANGE | SIF_POS | SIF_PAGE; + info.fMask = SIF_POS | SIF_PAGE; if (descr->style & LBS_DISABLENOSCROLL) info.fMask |= SIF_DISABLENOSCROLL; - if (descr->style & WS_HSCROLL) - SetScrollInfo( descr->self, SB_HORZ, &info, TRUE ); + SetScrollInfo( descr->self, SB_HORZ, &info, TRUE ); } } } @@ -1241,14 +1238,19 @@ static LRESULT LISTBOX_SetHorizontalExtent( LB_DESCR *descr, INT extent ) { if (descr->style & LBS_MULTICOLUMN) return LB_OKAY; - if (extent <= 0) extent = 1; if (extent == descr->horz_extent) return LB_OKAY; TRACE("[%p]: new horz extent = %d\n", descr->self, extent ); descr->horz_extent = extent; + if (descr->style & WS_HSCROLL) { + SCROLLINFO info; + info.cbSize = sizeof(info); + info.nMin = 0; + info.nMax = descr->horz_extent ? descr->horz_extent - 1 : 0; + info.fMask = SIF_RANGE; + SetScrollInfo( descr->self, SB_HORZ, &info, TRUE ); + } if (descr->horz_pos > extent - descr->width) LISTBOX_SetHorizontalPos( descr, extent - descr->width ); - else - LISTBOX_UpdateScroll( descr ); return LB_OKAY; } diff --git a/dlls/user32/tests/listbox.c b/dlls/user32/tests/listbox.c index ebcb5e9..d99a82c 100644 --- a/dlls/user32/tests/listbox.c +++ b/dlls/user32/tests/listbox.c @@ -1621,6 +1621,8 @@ static void test_extents(void) { HWND listbox, parent; DWORD res; + SCROLLINFO sinfo; + BOOL br; parent = create_parent(); @@ -1629,11 +1631,25 @@ static void test_extents(void) res = SendMessageA(listbox, LB_GETHORIZONTALEXTENT, 0, 0); ok(res == 0, "Got wrong initial horizontal extent: %u\n", res); + sinfo.cbSize = sizeof(sinfo); + sinfo.fMask = SIF_RANGE; + br = GetScrollInfo(listbox, SB_HORZ, &sinfo); + ok(br == TRUE, "GetScrollInfo failed\n"); + ok(sinfo.nMin == 0, "got wrong min: %u\n", sinfo.nMin); + ok(sinfo.nMax == 100, "got wrong max: %u\n", sinfo.nMax); + SendMessageA(listbox, LB_SETHORIZONTALEXTENT, 64, 0); res = SendMessageA(listbox, LB_GETHORIZONTALEXTENT, 0, 0); ok(res == 64, "Got wrong horizontal extent: %u\n", res); + sinfo.cbSize = sizeof(sinfo); + sinfo.fMask = SIF_RANGE; + br = GetScrollInfo(listbox, SB_HORZ, &sinfo); + ok(br == TRUE, "GetScrollInfo failed\n"); + ok(sinfo.nMin == 0, "got wrong min: %u\n", sinfo.nMin); + ok(sinfo.nMax == 100, "got wrong max: %u\n", sinfo.nMax); + DestroyWindow(listbox); @@ -1642,11 +1658,37 @@ static void test_extents(void) res = SendMessageA(listbox, LB_GETHORIZONTALEXTENT, 0, 0); ok(res == 0, "Got wrong initial horizontal extent: %u\n", res); + sinfo.cbSize = sizeof(sinfo); + sinfo.fMask = SIF_RANGE; + br = GetScrollInfo(listbox, SB_HORZ, &sinfo); + ok(br == TRUE, "GetScrollInfo failed\n"); + ok(sinfo.nMin == 0, "got wrong min: %u\n", sinfo.nMin); + ok(sinfo.nMax == 100, "got wrong max: %u\n", sinfo.nMax); + SendMessageA(listbox, LB_SETHORIZONTALEXTENT, 64, 0); res = SendMessageA(listbox, LB_GETHORIZONTALEXTENT, 0, 0); ok(res == 64, "Got wrong horizontal extent: %u\n", res); + sinfo.cbSize = sizeof(sinfo); + sinfo.fMask = SIF_RANGE; + br = GetScrollInfo(listbox, SB_HORZ, &sinfo); + ok(br == TRUE, "GetScrollInfo failed\n"); + ok(sinfo.nMin == 0, "got wrong min: %u\n", sinfo.nMin); + ok(sinfo.nMax == 63, "got wrong max: %u\n", sinfo.nMax); + + SendMessageA(listbox, LB_SETHORIZONTALEXTENT, 0, 0); + + res = SendMessageA(listbox, LB_GETHORIZONTALEXTENT, 0, 0); + ok(res == 0, "Got wrong horizontal extent: %u\n", res); + + sinfo.cbSize = sizeof(sinfo); + sinfo.fMask = SIF_RANGE; + br = GetScrollInfo(listbox, SB_HORZ, &sinfo); + ok(br == TRUE, "GetScrollInfo failed\n"); + ok(sinfo.nMin == 0, "got wrong min: %u\n", sinfo.nMin); + ok(sinfo.nMax == 0, "got wrong max: %u\n", sinfo.nMax); + DestroyWindow(listbox); DestroyWindow(parent);

1 0

Piotr Caban : oleacc: Add AccessibleObjectFromWindow tests.
by Alexandre Julliard April 28, 2014

April 28, 2014

Module: wine Branch: master Commit: 41f5b15523cf6705e3e71d15e28239755038974c URL: http://source.winehq.org/git/wine.git/?a=commit;h=41f5b15523cf6705e3e71d15e… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Mon Apr 28 17:30:36 2014 +0200 oleacc: Add AccessibleObjectFromWindow tests. --- dlls/oleacc/tests/Makefile.in | 2 +- dlls/oleacc/tests/main.c | 70 +++++++++++++++++++++++++++++++++++++++++ 2 files changed, 71 insertions(+), 1 deletion(-) diff --git a/dlls/oleacc/tests/Makefile.in b/dlls/oleacc/tests/Makefile.in index 374f15d..2b0157d 100644 --- a/dlls/oleacc/tests/Makefile.in +++ b/dlls/oleacc/tests/Makefile.in @@ -1,5 +1,5 @@ TESTDLL = oleacc.dll -IMPORTS = ole32 oleacc +IMPORTS = ole32 oleacc user32 C_SRCS = \ main.c diff --git a/dlls/oleacc/tests/main.c b/dlls/oleacc/tests/main.c index e3daefe..c5c50b8 100644 --- a/dlls/oleacc/tests/main.c +++ b/dlls/oleacc/tests/main.c @@ -211,6 +211,69 @@ static void test_LresultFromObject(const char *name) ok(Object_ref == 1, "Object_ref = %d\n", Object_ref); } +static LRESULT WINAPI test_window_proc(HWND hwnd, UINT msg, WPARAM wparam, LPARAM lparam) +{ + switch(msg) { + case WM_GETOBJECT: + ok(wparam==0xffffffff || broken(wparam==0x8000), "wparam = %lx\n", wparam); + if(lparam == (DWORD)OBJID_CURSOR) + return E_UNEXPECTED; + if(lparam == (DWORD)OBJID_CLIENT) + return LresultFromObject(&IID_IUnknown, wparam, &Object); + + ok(0, "unexpected (%ld)\n", lparam); + return 0; + } + + return DefWindowProcA(hwnd, msg, wparam, lparam); +} + +static BOOL register_window_class(void) +{ + WNDCLASSA cls; + + memset(&cls, 0, sizeof(cls)); + cls.lpfnWndProc = test_window_proc; + cls.lpszClassName = "oleacc_test"; + cls.hInstance = GetModuleHandleA(NULL); + + return RegisterClassA(&cls); +} + +static void unregister_window_class(void) +{ + UnregisterClassA("oleacc_test", NULL); +} + +static void test_AccessibleObjectFromWindow(void) +{ + IUnknown *unk; + HRESULT hr; + HWND hwnd; + + hr = AccessibleObjectFromWindow(NULL, OBJID_CURSOR, &IID_IUnknown, NULL); + ok(hr == E_INVALIDARG, "got %x\n", hr); + + hr = AccessibleObjectFromWindow(NULL, OBJID_CURSOR, &IID_IUnknown, (void**)&unk); + todo_wine ok(hr == S_OK, "got %x\n", hr); + if(hr == S_OK) IUnknown_Release(unk); + + hwnd = CreateWindowA("oleacc_test", "test", WS_OVERLAPPEDWINDOW, + 0, 0, 0, 0, NULL, NULL, NULL, NULL); + ok(hwnd != NULL, "CreateWindow failed\n"); + + hr = AccessibleObjectFromWindow(hwnd, OBJID_CURSOR, &IID_IUnknown, (void**)&unk); + ok(hr == E_UNEXPECTED, "got %x\n", hr); + + ok(Object_ref == 1, "Object_ref = %d\n", Object_ref); + hr = AccessibleObjectFromWindow(hwnd, OBJID_CLIENT, &IID_IUnknown, (void**)&unk); + ok(hr == S_OK, "got %x\n", hr); + ok(Object_ref == 2, "Object_ref = %d\n", Object_ref); + IUnknown_Release(unk); + + DestroyWindow(hwnd); +} + START_TEST(main) { int argc; @@ -233,8 +296,15 @@ START_TEST(main) return; } + if(!register_window_class()) { + skip("can't register test window class\n"); + return; + } + test_getroletext(); test_LresultFromObject(argv[0]); + test_AccessibleObjectFromWindow(); + unregister_window_class(); CoUninitialize(); }

1 0

Jacek Caban : mshtml: Removed invalid nsAString_InitDepend from HTMLTable_put_bgColor and fixed error handling.
by Alexandre Julliard April 28, 2014

April 28, 2014

Module: wine Branch: master Commit: c49bb259505d2b1c52ce671bbb2fe4e82545777e URL: http://source.winehq.org/git/wine.git/?a=commit;h=c49bb259505d2b1c52ce671bb… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Mon Apr 28 12:40:08 2014 +0200 mshtml: Removed invalid nsAString_InitDepend from HTMLTable_put_bgColor and fixed error handling. --- dlls/mshtml/htmltable.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/dlls/mshtml/htmltable.c b/dlls/mshtml/htmltable.c index d711ed7..08a0bf0 100644 --- a/dlls/mshtml/htmltable.c +++ b/dlls/mshtml/htmltable.c @@ -251,11 +251,11 @@ static HRESULT WINAPI HTMLTable_put_bgColor(IHTMLTable *iface, VARIANT v) TRACE("(%p)->(%s)\n", This, debugstr_variant(&v)); - nsAString_InitDepend(&val, V_BSTR(&v)); - variant_to_nscolor(&v, &val); + if(!variant_to_nscolor(&v, &val)) + return S_OK; + nsres = nsIDOMHTMLTableElement_SetBgColor(This->nstable, &val); nsAString_Finish(&val); - if (NS_FAILED(nsres)){ ERR("Set BgColor(%s) failed!\n", debugstr_variant(&v)); return E_FAIL;

1 0

Nikolay Sivov : msxml3/tests: Fixed attributes map leak (Valgrind).
by Alexandre Julliard April 28, 2014

April 28, 2014

Module: wine Branch: master Commit: 3b16986a355c04c6aacc8b5a63a2499bb4c0176c URL: http://source.winehq.org/git/wine.git/?a=commit;h=3b16986a355c04c6aacc8b5a6… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Sat Apr 26 00:36:56 2014 +0400 msxml3/tests: Fixed attributes map leak (Valgrind). --- dlls/msxml3/tests/domdoc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/dlls/msxml3/tests/domdoc.c b/dlls/msxml3/tests/domdoc.c index d064d10..7a2f984 100644 --- a/dlls/msxml3/tests/domdoc.c +++ b/dlls/msxml3/tests/domdoc.c @@ -10522,6 +10522,7 @@ todo_wine EXPECT_HR(hr, S_OK); ok(did == DISPID_DOM_COLLECTION_BASE, "got 0x%08x\n", did); IDispatchEx_Release(dispex); + IXMLDOMNamedNodeMap_Release(map); hr = IXMLDOMDocument_selectNodes(doc, _bstr_("root/b"), &node_list); EXPECT_HR(hr, S_OK); @@ -10543,7 +10544,7 @@ todo_wine hr = IDispatchEx_GetDispID(dispex, _bstr_("1"), 0, &did); EXPECT_HR(hr, S_OK); ok(did == DISPID_DOM_COLLECTION_BASE+1, "got 0x%08x\n", did); - IDispatchEx_Release(dispex); + IXMLDOMNamedNodeMap_Release(map); did = -1; hr = IDispatchEx_GetDispID(dispex, _bstr_("item"), 0, &did); @@ -10636,7 +10637,7 @@ todo_wine ok(V_VT(&ret) == VT_EMPTY, "got %d\n", V_VT(&ret)); ok(broken(V_I4(&ret) == 1) || (V_I4(&ret) == 0), "got %d\n", V_I4(&ret)); - IXMLDOMNamedNodeMap_Release(map); + IDispatchEx_Release(dispex); IXMLDOMElement_Release(elem); /* IXMLDOMImplementation */

1 0

Jacek Caban : mshtml: Renamed nsIDOMHTMLSelectElement:: Remove to select_Remove to avoid conflict with nsIDOMElement.
by Alexandre Julliard April 28, 2014

April 28, 2014

Module: wine Branch: master Commit: 8b81af32ae0aedd72e9809050e759f579e727e24 URL: http://source.winehq.org/git/wine.git/?a=commit;h=8b81af32ae0aedd72e9809050… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Mon Apr 28 12:17:59 2014 +0200 mshtml: Renamed nsIDOMHTMLSelectElement::Remove to select_Remove to avoid conflict with nsIDOMElement. Spotted by Zhenbo Li. --- dlls/mshtml/nsiface.idl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/mshtml/nsiface.idl b/dlls/mshtml/nsiface.idl index c0959f5..9182c19 100644 --- a/dlls/mshtml/nsiface.idl +++ b/dlls/mshtml/nsiface.idl @@ -1791,7 +1791,7 @@ interface nsIDOMHTMLSelectElement : nsIDOMHTMLElement nsresult Item(uint32_t index, nsIDOMNode **_retval); nsresult NamedItem(const nsAString *name, nsIDOMNode **_retval); nsresult Add(nsIDOMHTMLElement *element, nsIVariant *before); - nsresult Remove(int32_t index); + nsresult select_Remove(int32_t index); nsresult GetSelectedIndex(int32_t *aSelectedIndex); nsresult SetSelectedIndex(int32_t aSelectedIndex); nsresult GetValue(nsAString *aValue);

1 0

Austin English : msxml3: Complain louder if libxslt was missing at compile time.
by Alexandre Julliard April 28, 2014

April 28, 2014

Module: wine Branch: master Commit: 980e9225d20ade10cd85c3edea518d78d021dd60 URL: http://source.winehq.org/git/wine.git/?a=commit;h=980e9225d20ade10cd85c3ede… Author: Austin English <austinenglish(a)gmail.com> Date: Fri Apr 25 17:37:08 2014 -0700 msxml3: Complain louder if libxslt was missing at compile time. --- dlls/msxml3/node.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/dlls/msxml3/node.c b/dlls/msxml3/node.c index b49f46c..47d3159 100644 --- a/dlls/msxml3/node.c +++ b/dlls/msxml3/node.c @@ -71,6 +71,8 @@ MAKE_FUNCPTR(xsltParseStylesheetDoc); MAKE_FUNCPTR(xsltQuoteUserParams); MAKE_FUNCPTR(xsltSaveResultTo); # undef MAKE_FUNCPTR +#else +WINE_DECLARE_DEBUG_CHANNEL(winediag); #endif static const IID IID_xmlnode = {0x4f2f4ba2,0xb822,0x11df,{0x8b,0x8a,0x68,0x50,0xdf,0xd7,0x20,0x85}}; @@ -1308,7 +1310,8 @@ HRESULT node_transform_node_params(const xmlnode *This, IXMLDOMNode *stylesheet, return hr; #else - FIXME("libxslt headers were not found at compile time\n"); + ERR_(winediag)("libxslt headers were not found at compile time. Expect problems.\n"); + return E_NOTIMPL; #endif }

1 0

Nikolay Sivov : msxml3: Fix XPath query result leak (Valgrind).
by Alexandre Julliard April 28, 2014

April 28, 2014

Module: wine Branch: master Commit: 98a9fbe79f72180f3095f8db4677e89946caa178 URL: http://source.winehq.org/git/wine.git/?a=commit;h=98a9fbe79f72180f3095f8db4… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Sat Apr 26 00:36:41 2014 +0400 msxml3: Fix XPath query result leak (Valgrind). --- dlls/msxml3/schema.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/dlls/msxml3/schema.c b/dlls/msxml3/schema.c index 8776de8..a4aa083 100644 --- a/dlls/msxml3/schema.c +++ b/dlls/msxml3/schema.c @@ -1058,8 +1058,6 @@ HRESULT cache_from_doc_ns(IXMLDOMSchemaCollection2 *iface, xmlnode *node) { int pos = 0, len = xmlXPathNodeSetGetLength(nodeset->nodesetval); - if (len == 0) return S_OK; - while (pos < len) { xmlNodePtr node = xmlXPathNodeSetItem(nodeset->nodesetval, pos);

1 0