October 2015 - Wine-Commits

Józef Kucia : d3d11/tests: Check that shaders implement d3d10 interfaces.
by Alexandre Julliard Oct. 6, 2015

Oct. 6, 2015

Module: wine Branch: master Commit: 43bbdac1f034cd4f057fbb6200c8ed129b38a292 URL: http://source.winehq.org/git/wine.git/?a=commit;h=43bbdac1f034cd4f057fbb620… Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Tue Oct 6 01:49:32 2015 +0200 d3d11/tests: Check that shaders implement d3d10 interfaces. Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> --- dlls/d3d11/tests/d3d11.c | 28 ++++++++++++++++++++++++++-- 1 file changed, 26 insertions(+), 2 deletions(-) diff --git a/dlls/d3d11/tests/d3d11.c b/dlls/d3d11/tests/d3d11.c index c58539e..1dee78b 100644 --- a/dlls/d3d11/tests/d3d11.c +++ b/dlls/d3d11/tests/d3d11.c @@ -1448,6 +1448,7 @@ static void test_create_shader(void) ID3D11GeometryShader *gs; ID3D11VertexShader *vs; ID3D11PixelShader *ps; + IUnknown *iface; unsigned int i; HRESULT hr; @@ -1481,6 +1482,7 @@ static void test_create_shader(void) expected_refcount = get_refcount((IUnknown *)device) + 1; hr = ID3D11Device_CreateVertexShader(device, vs_4_0, sizeof(vs_4_0), NULL, &vs); ok(SUCCEEDED(hr), "Failed to create SM4 vertex shader, hr %#x, feature level %#x.\n", hr, feature_level); + refcount = get_refcount((IUnknown *)device); ok(refcount >= expected_refcount, "Got unexpected refcount %u, expected >= %u.\n", refcount, expected_refcount); @@ -1492,12 +1494,20 @@ static void test_create_shader(void) ok(refcount == expected_refcount, "Got unexpected refcount %u, expected %u.\n", refcount, expected_refcount); ID3D11Device_Release(tmp); - ID3D11VertexShader_Release(vs); + + hr = ID3D11VertexShader_QueryInterface(vs, &IID_ID3D10VertexShader, (void **)&iface); + ok(SUCCEEDED(hr) || broken(hr == E_NOINTERFACE) /* Not available on all Windows versions. */, + "Vertex shader should implement ID3D10VertexShader.\n"); + if (SUCCEEDED(hr)) IUnknown_Release(iface); + + refcount = ID3D11VertexShader_Release(vs); + ok(!refcount, "Vertex shader has %u references left.\n", refcount); /* pixel shader */ expected_refcount = get_refcount((IUnknown *)device) + 1; hr = ID3D11Device_CreatePixelShader(device, ps_4_0, sizeof(ps_4_0), NULL, &ps); ok(SUCCEEDED(hr), "Failed to create SM4 vertex shader, hr %#x, feature level %#x.\n", hr, feature_level); + refcount = get_refcount((IUnknown *)device); ok(refcount >= expected_refcount, "Got unexpected refcount %u, expected >= %u.\n", refcount, expected_refcount); @@ -1509,12 +1519,20 @@ static void test_create_shader(void) ok(refcount == expected_refcount, "Got unexpected refcount %u, expected %u.\n", refcount, expected_refcount); ID3D11Device_Release(tmp); - ID3D11PixelShader_Release(ps); + + hr = ID3D11PixelShader_QueryInterface(ps, &IID_ID3D10PixelShader, (void **)&iface); + ok(SUCCEEDED(hr) || broken(hr == E_NOINTERFACE) /* Not available on all Windows versions. */, + "Pixel shader should implement ID3D10PixelShader.\n"); + if (SUCCEEDED(hr)) IUnknown_Release(iface); + + refcount = ID3D11PixelShader_Release(ps); + ok(!refcount, "Pixel shader has %u references left.\n", refcount); /* geometry shader */ expected_refcount = get_refcount((IUnknown *)device) + 1; hr = ID3D11Device_CreateGeometryShader(device, gs_4_0, sizeof(gs_4_0), NULL, &gs); ok(SUCCEEDED(hr), "Failed to create SM4 geometry shader, hr %#x.\n", hr); + refcount = get_refcount((IUnknown *)device); ok(refcount >= expected_refcount, "Got unexpected refcount %u, expected >= %u.\n", refcount, expected_refcount); @@ -1526,6 +1544,12 @@ static void test_create_shader(void) ok(refcount == expected_refcount, "Got unexpected refcount %u, expected %u.\n", refcount, expected_refcount); ID3D11Device_Release(tmp); + + hr = ID3D11GeometryShader_QueryInterface(gs, &IID_ID3D10GeometryShader, (void **)&iface); + ok(SUCCEEDED(hr) || broken(hr == E_NOINTERFACE) /* Not available on all Windows versions. */, + "Geometry shader should implement ID3D10GeometryShader.\n"); + if (SUCCEEDED(hr)) IUnknown_Release(iface); + refcount = ID3D11GeometryShader_Release(gs); ok(!refcount, "Geometry shader has %u references left.\n", refcount);

1 0

Andrew Eikum : xapofx1_2: Forward to xapofx1_5.
by Alexandre Julliard Oct. 6, 2015

Oct. 6, 2015

Module: wine Branch: master Commit: 01a5e00479c1360596369892092a1f6a9cd11458 URL: http://source.winehq.org/git/wine.git/?a=commit;h=01a5e00479c13605963698920… Author: Andrew Eikum <aeikum(a)codeweavers.com> Date: Mon Oct 5 11:33:42 2015 -0500 xapofx1_2: Forward to xapofx1_5. Signed-off-by: Andrew Eikum <aeikum(a)codeweavers.com> --- configure | 2 ++ configure.ac | 1 + dlls/xapofx1_2/Makefile.in | 4 ++++ dlls/xapofx1_2/main.c | 45 +++++++++++++++++++++++++++++++++++++++++++ dlls/xapofx1_2/xapofx1_2.spec | 1 + 5 files changed, 53 insertions(+) diff --git a/configure b/configure index 34edcce..9cd9ca3 100755 --- a/configure +++ b/configure @@ -1371,6 +1371,7 @@ enable_x3daudio1_5 enable_x3daudio1_6 enable_x3daudio1_7 enable_xapofx1_1 +enable_xapofx1_2 enable_xapofx1_3 enable_xapofx1_4 enable_xapofx1_5 @@ -17914,6 +17915,7 @@ wine_fn_config_dll x3daudio1_5 enable_x3daudio1_5 wine_fn_config_dll x3daudio1_6 enable_x3daudio1_6 wine_fn_config_dll x3daudio1_7 enable_x3daudio1_7 wine_fn_config_dll xapofx1_1 enable_xapofx1_1 +wine_fn_config_dll xapofx1_2 enable_xapofx1_2 wine_fn_config_dll xapofx1_3 enable_xapofx1_3 wine_fn_config_dll xapofx1_4 enable_xapofx1_4 wine_fn_config_dll xapofx1_5 enable_xapofx1_5 diff --git a/configure.ac b/configure.ac index d350ea6..62abe1b 100644 --- a/configure.ac +++ b/configure.ac @@ -3457,6 +3457,7 @@ WINE_CONFIG_DLL(x3daudio1_5) WINE_CONFIG_DLL(x3daudio1_6) WINE_CONFIG_DLL(x3daudio1_7) WINE_CONFIG_DLL(xapofx1_1) +WINE_CONFIG_DLL(xapofx1_2) WINE_CONFIG_DLL(xapofx1_3) WINE_CONFIG_DLL(xapofx1_4) WINE_CONFIG_DLL(xapofx1_5) diff --git a/dlls/xapofx1_2/Makefile.in b/dlls/xapofx1_2/Makefile.in new file mode 100644 index 0000000..fb76b12 --- /dev/null +++ b/dlls/xapofx1_2/Makefile.in @@ -0,0 +1,4 @@ +MODULE = xapofx1_2.dll + +C_SRCS = \ + main.c diff --git a/dlls/xapofx1_2/main.c b/dlls/xapofx1_2/main.c new file mode 100644 index 0000000..e873b58 --- /dev/null +++ b/dlls/xapofx1_2/main.c @@ -0,0 +1,45 @@ +/* + * Copyright 2015 Andrew Eikum for CodeWeavers + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA + */ + +#include "config.h" +#include <stdarg.h> + +#include "windef.h" +#include "winbase.h" +#include "wine/debug.h" + +WINE_DEFAULT_DEBUG_CHANNEL(xapofx); + +/***************************************************** + * DllMain + */ +BOOL WINAPI DllMain( HINSTANCE hinst, DWORD reason, LPVOID reserved ) +{ + TRACE("(%p, %d, %p)\n", hinst, reason, reserved); + + switch(reason) + { + case DLL_WINE_PREATTACH: + return FALSE; /* prefer native version */ + + case DLL_PROCESS_ATTACH: + DisableThreadLibraryCalls(hinst); + break; + } + return TRUE; +} diff --git a/dlls/xapofx1_2/xapofx1_2.spec b/dlls/xapofx1_2/xapofx1_2.spec new file mode 100644 index 0000000..bc17511 --- /dev/null +++ b/dlls/xapofx1_2/xapofx1_2.spec @@ -0,0 +1 @@ +@ cdecl CreateFX(ptr ptr) xapofx1_5.CreateFX

1 0

Ken Thomases : winemac: Queue an event to reassert the WinAPI window position before Cocoa adjusts its position for a display change.
by Alexandre Julliard Oct. 6, 2015

Oct. 6, 2015

Module: wine Branch: master Commit: 9372af77a546609b703070d60ef773d5ae7c2ddd URL: http://source.winehq.org/git/wine.git/?a=commit;h=9372af77a546609b703070d60… Author: Ken Thomases <ken(a)codeweavers.com> Date: Mon Oct 5 15:44:28 2015 -0500 winemac: Queue an event to reassert the WinAPI window position before Cocoa adjusts its position for a display change. When the display mode changes such that the screen height changes, we'd like our windows to keep their position relative to the top-left of the primary screen. That's how WinAPI's coordinate system works and we want the WinAPI position of the window to not change just because the display mode changed. Unfortunately that's not achievable in Cocoa. Cocoa keeps the window stationary relative to the screen it's on, not necessarily the primary screen, and it's sometimes relative to the bottom-left and sometimes the top-left of that screen. So, what we do instead is queue an event to get the back end to reassert the WinAPI position of the window. This is queued before Cocoa can adjust the Cocoa position of the window which would queue a WINDOW_FRAME_CHANGED to the back end and mess up the WinAPI position. The back end's reassertion of the WinAPI position won't be processed by the Cocoa thread until after Cocoa has adjusted the position and will thus override it. It will also discard any wrong WINDOW_FRAME_CHANGED that may have been queued. Signed-off-by: Ken Thomases <ken(a)codeweavers.com> --- dlls/winemac.drv/cocoa_window.m | 37 +++++++++++++++++++++++++++++++++++++ dlls/winemac.drv/event.c | 5 +++++ dlls/winemac.drv/macdrv.h | 1 + dlls/winemac.drv/macdrv_cocoa.h | 1 + dlls/winemac.drv/window.c | 24 ++++++++++++++++++------ 5 files changed, 62 insertions(+), 6 deletions(-) diff --git a/dlls/winemac.drv/cocoa_window.m b/dlls/winemac.drv/cocoa_window.m index 4ac03a7..35488b0 100644 --- a/dlls/winemac.drv/cocoa_window.m +++ b/dlls/winemac.drv/cocoa_window.m @@ -150,6 +150,11 @@ static inline NSUInteger adjusted_modifiers_for_option_behavior(NSUInteger modif } +(a)interface NSWindow (WineAccessPrivateMethods) + - (id) _displayChanged; +(a)end + + @interface WineContentView : NSView <NSTextInputClient> { NSMutableArray* glContexts; @@ -1593,6 +1598,38 @@ static inline NSUInteger adjusted_modifiers_for_option_behavior(NSUInteger modif return frameRect; } + // This private method of NSWindow is called as Cocoa reacts to the display + // configuration changing. Among other things, it adjusts the window's + // frame based on how the screen(s) changed size. That tells Wine that the + // window has been moved. We don't want that. Rather, we want to make + // sure that the WinAPI notion of the window position is maintained/ + // restored, possibly undoing or overriding Cocoa's adjustment. + // + // So, we queue a REASSERT_WINDOW_POSITION event to the back end before + // Cocoa has a chance to adjust the frame, thus preceding any resulting + // WINDOW_FRAME_CHANGED event that may get queued. The back end will + // reassert its notion of the position. That call won't get processed + // until after this method returns, so it will override whatever this + // method does to the window position. It will also discard any pending + // WINDOW_FRAME_CHANGED events. + // + // Unfortunately, the only way I've found to know when Cocoa is _about to_ + // adjust the window's position due to a display change is to hook into + // this private method. This private method has remained stable from 10.6 + // through 10.11. If it does change, the most likely thing is that it + // will be removed and no longer called and this fix will simply stop + // working. The only real danger would be if Apple changed the return type + // to a struct or floating-point type, which would change the calling + // convention. + - (id) _displayChanged + { + macdrv_event* event = macdrv_create_event(REASSERT_WINDOW_POSITION, self); + [queue postEvent:event]; + macdrv_release_event(event); + + return [super _displayChanged]; + } + - (BOOL) isExcludedFromWindowsMenu { return !([self collectionBehavior] & NSWindowCollectionBehaviorParticipatesInCycle); diff --git a/dlls/winemac.drv/event.c b/dlls/winemac.drv/event.c index 58b507c..785bc0a 100644 --- a/dlls/winemac.drv/event.c +++ b/dlls/winemac.drv/event.c @@ -45,6 +45,7 @@ static const char *dbgstr_event(int type) "MOUSE_MOVED_ABSOLUTE", "MOUSE_SCROLL", "QUERY_EVENT", + "REASSERT_WINDOW_POSITION", "RELEASE_CAPTURE", "STATUS_ITEM_MOUSE_BUTTON", "STATUS_ITEM_MOUSE_MOVE", @@ -115,6 +116,7 @@ static macdrv_event_mask get_event_mask(DWORD mask) if (mask & QS_SENDMESSAGE) { event_mask |= event_mask_for_type(QUERY_EVENT); + event_mask |= event_mask_for_type(REASSERT_WINDOW_POSITION); event_mask |= event_mask_for_type(RELEASE_CAPTURE); event_mask |= event_mask_for_type(WINDOW_BROUGHT_FORWARD); event_mask |= event_mask_for_type(WINDOW_CLOSE_REQUESTED); @@ -237,6 +239,9 @@ void macdrv_handle_event(const macdrv_event *event) case QUERY_EVENT: macdrv_query_event(hwnd, event); break; + case REASSERT_WINDOW_POSITION: + macdrv_reassert_window_position(hwnd); + break; case RELEASE_CAPTURE: macdrv_release_capture(hwnd, event); break; diff --git a/dlls/winemac.drv/macdrv.h b/dlls/winemac.drv/macdrv.h index a31d7e3..44b79ac 100644 --- a/dlls/winemac.drv/macdrv.h +++ b/dlls/winemac.drv/macdrv.h @@ -175,6 +175,7 @@ extern void macdrv_window_resize_ended(HWND hwnd) DECLSPEC_HIDDEN; extern void macdrv_window_restore_requested(HWND hwnd, const macdrv_event *event) DECLSPEC_HIDDEN; extern void macdrv_window_drag_begin(HWND hwnd) DECLSPEC_HIDDEN; extern void macdrv_window_drag_end(HWND hwnd) DECLSPEC_HIDDEN; +extern void macdrv_reassert_window_position(HWND hwnd) DECLSPEC_HIDDEN; extern BOOL query_resize_size(HWND hwnd, macdrv_query *query) DECLSPEC_HIDDEN; extern BOOL query_resize_start(HWND hwnd) DECLSPEC_HIDDEN; extern BOOL query_min_max_info(HWND hwnd) DECLSPEC_HIDDEN; diff --git a/dlls/winemac.drv/macdrv_cocoa.h b/dlls/winemac.drv/macdrv_cocoa.h index d5e3f46..2385097 100644 --- a/dlls/winemac.drv/macdrv_cocoa.h +++ b/dlls/winemac.drv/macdrv_cocoa.h @@ -195,6 +195,7 @@ enum { MOUSE_MOVED_ABSOLUTE, MOUSE_SCROLL, QUERY_EVENT, + REASSERT_WINDOW_POSITION, RELEASE_CAPTURE, STATUS_ITEM_MOUSE_BUTTON, STATUS_ITEM_MOUSE_MOVE, diff --git a/dlls/winemac.drv/window.c b/dlls/winemac.drv/window.c index 9d996ec..a48ac17 100644 --- a/dlls/winemac.drv/window.c +++ b/dlls/winemac.drv/window.c @@ -1682,12 +1682,7 @@ LRESULT CDECL macdrv_WindowMessage(HWND hwnd, UINT msg, WPARAM wp, LPARAM lp) macdrv_reset_device_metrics(); return 0; case WM_MACDRV_DISPLAYCHANGE: - if ((data = get_win_data(hwnd))) - { - if (data->cocoa_window && data->on_screen) - sync_window_position(data, SWP_NOZORDER | SWP_NOACTIVATE, NULL, NULL); - release_win_data(data); - } + macdrv_reassert_window_position(hwnd); SendMessageW(hwnd, WM_DISPLAYCHANGE, wp, lp); return 0; case WM_MACDRV_ACTIVATE_ON_FOLLOWING_FOCUS: @@ -2244,6 +2239,23 @@ void macdrv_window_drag_end(HWND hwnd) } +/*********************************************************************** + * macdrv_reassert_window_position + * + * Handler for REASSERT_WINDOW_POSITION events. + */ +void macdrv_reassert_window_position(HWND hwnd) +{ + struct macdrv_win_data *data = get_win_data(hwnd); + if (data) + { + if (data->cocoa_window && data->on_screen) + sync_window_position(data, SWP_NOZORDER | SWP_NOACTIVATE, NULL, NULL); + release_win_data(data); + } +} + + struct quit_info { HWND *wins; UINT capacity;

1 0

Hans Leidekker : msiexec: Fix parsing of basic UI level modifiers.
by Alexandre Julliard Oct. 6, 2015

Oct. 6, 2015

Module: wine Branch: master Commit: 171a4c4154d031f240616e76be80ba8041342185 URL: http://source.winehq.org/git/wine.git/?a=commit;h=171a4c4154d031f240616e76b… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Tue Oct 6 00:29:12 2015 +0200 msiexec: Fix parsing of basic UI level modifiers. Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> --- programs/msiexec/msiexec.c | 43 ++++++++++++++++++------------------------- 1 file changed, 18 insertions(+), 25 deletions(-) diff --git a/programs/msiexec/msiexec.c b/programs/msiexec/msiexec.c index cb0984d..bb5c931 100644 --- a/programs/msiexec/msiexec.c +++ b/programs/msiexec/msiexec.c @@ -886,10 +886,6 @@ int WINAPI WinMain(HINSTANCE hInstance, HINSTANCE hPrevInstance, LPSTR lpCmdLine { InstallUILevel = INSTALLUILEVEL_NONE; } - else if(msi_strequal(argvW[i]+2, "b")) - { - InstallUILevel = INSTALLUILEVEL_BASIC; - } else if(msi_strequal(argvW[i]+2, "r")) { InstallUILevel = INSTALLUILEVEL_REDUCED; @@ -902,28 +898,25 @@ int WINAPI WinMain(HINSTANCE hInstance, HINSTANCE hPrevInstance, LPSTR lpCmdLine { InstallUILevel = INSTALLUILEVEL_NONE|INSTALLUILEVEL_ENDDIALOG; } - else if(msi_strequal(argvW[i]+2, "b+")) - { - InstallUILevel = INSTALLUILEVEL_BASIC|INSTALLUILEVEL_ENDDIALOG; - } - else if(msi_strequal(argvW[i]+2, "b-")) - { - InstallUILevel = INSTALLUILEVEL_BASIC|INSTALLUILEVEL_PROGRESSONLY; - } - else if(msi_strequal(argvW[i]+2, "b+!")) - { - WINE_FIXME("Unhandled modifier: !\n"); - InstallUILevel = INSTALLUILEVEL_BASIC|INSTALLUILEVEL_ENDDIALOG|INSTALLUILEVEL_HIDECANCEL; - } - else if(msi_strequal(argvW[i]+2, "b-!")) - { - WINE_FIXME("Unhandled modifier: !\n"); - InstallUILevel = INSTALLUILEVEL_BASIC|INSTALLUILEVEL_PROGRESSONLY|INSTALLUILEVEL_HIDECANCEL; - } - else if(msi_strequal(argvW[i]+2, "b!")) + else if(msi_strprefix(argvW[i]+2, "b")) { - WINE_FIXME("Unhandled modifier: !\n"); - InstallUILevel = INSTALLUILEVEL_BASIC|INSTALLUILEVEL_HIDECANCEL; + const WCHAR *ptr = argvW[i] + 3; + + InstallUILevel = INSTALLUILEVEL_BASIC; + + while (*ptr) + { + if (msi_strprefix(ptr, "+")) + InstallUILevel |= INSTALLUILEVEL_ENDDIALOG; + if (msi_strprefix(ptr, "-")) + InstallUILevel |= INSTALLUILEVEL_PROGRESSONLY; + if (msi_strprefix(ptr, "!")) + { + WINE_FIXME("Unhandled modifier: !\n"); + InstallUILevel |= INSTALLUILEVEL_HIDECANCEL; + } + ptr++; + } } else {

1 0

Matteo Bruni : wined3d: Initialize unwritten texcoord varyings in the VS.
by Alexandre Julliard Oct. 6, 2015

Oct. 6, 2015

Module: wine Branch: master Commit: b90b61aa68c593b4ab5fa2e611018a551dddc0a2 URL: http://source.winehq.org/git/wine.git/?a=commit;h=b90b61aa68c593b4ab5fa2e61… Author: Matteo Bruni <mbruni(a)codeweavers.com> Date: Fri Oct 2 14:54:47 2015 +0200 wined3d: Initialize unwritten texcoord varyings in the VS. Signed-off-by: Matteo Bruni <mbruni(a)codeweavers.com> --- dlls/wined3d/glsl_shader.c | 31 ++++++++++++++++++++++--------- 1 file changed, 22 insertions(+), 9 deletions(-) diff --git a/dlls/wined3d/glsl_shader.c b/dlls/wined3d/glsl_shader.c index 9fd48c4..c85b334 100644 --- a/dlls/wined3d/glsl_shader.c +++ b/dlls/wined3d/glsl_shader.c @@ -4939,6 +4939,8 @@ static GLuint generate_param_reorder_function(struct shader_glsl_priv *priv, if (ps_major < 3) { + DWORD texcoords_written_mask[MAX_TEXTURES] = {0}; + if (!legacy_context) { declare_out_varying(gl_info, buffer, FALSE, "float ffp_varying_fogcoord;\n"); @@ -4975,15 +4977,11 @@ static GLuint generate_param_reorder_function(struct shader_glsl_priv *priv, } else if (shader_match_semantic(semantic_name, WINED3D_DECL_USAGE_TEXCOORD)) { - if (semantic_idx < 8) + if (semantic_idx < MAX_TEXTURES) { - if (!(gl_info->quirks & WINED3D_QUIRK_SET_TEXCOORD_W) || ps_major > 0) - write_mask |= WINED3DSP_WRITEMASK_3; - shader_addline(buffer, "gl_TexCoord[%u]%s = vs_out[%u]%s;\n", semantic_idx, reg_mask, output->register_idx, reg_mask); - if (!(write_mask & WINED3DSP_WRITEMASK_3)) - shader_addline(buffer, "gl_TexCoord[%u].w = 1.0;\n", semantic_idx); + texcoords_written_mask[semantic_idx] = write_mask; } } else if (shader_match_semantic(semantic_name, WINED3D_DECL_USAGE_PSIZE) && per_vertex_point_size) @@ -4998,7 +4996,22 @@ static GLuint generate_param_reorder_function(struct shader_glsl_priv *priv, output->register_idx, reg_mask[1]); } } - shader_addline(buffer, "}\n"); + + for (i = 0; i < MAX_TEXTURES; ++i) + { + if (ps && !(ps->reg_maps.texcoord & (1u << i))) + continue; + + if (texcoords_written_mask[i] != WINED3DSP_WRITEMASK_ALL) + { + if (gl_info->limits.glsl_varyings < wined3d_max_compat_varyings(gl_info) + && !texcoords_written_mask[i]) + continue; + + shader_glsl_write_mask_to_str(~texcoords_written_mask[i] & WINED3DSP_WRITEMASK_ALL, reg_mask); + shader_addline(buffer, "gl_TexCoord[%u]%s = vec4(0.0)%s;\n", i, reg_mask, reg_mask); + } + } } else { @@ -5034,10 +5047,10 @@ static GLuint generate_param_reorder_function(struct shader_glsl_priv *priv, /* Then, fix the pixel shader input */ handle_ps3_input(priv, gl_info, ps->u.ps.input_reg_map, &ps->input_signature, &ps->reg_maps, &vs->output_signature, &vs->reg_maps); - - shader_addline(buffer, "}\n"); } + shader_addline(buffer, "}\n"); + ret = GL_EXTCALL(glCreateShader(GL_VERTEX_SHADER)); checkGLcall("glCreateShader(GL_VERTEX_SHADER)"); shader_glsl_compile(gl_info, ret, buffer->buffer);

1 0

Stefan Dösinger : d3d9/tests: Port test_flip to d3d9.
by Alexandre Julliard Oct. 6, 2015

Oct. 6, 2015

Module: wine Branch: master Commit: 178d0030a2fa7a7b4ff393670b25719dec638429 URL: http://source.winehq.org/git/wine.git/?a=commit;h=178d0030a2fa7a7b4ff393670… Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Mon Oct 5 23:13:13 2015 +0200 d3d9/tests: Port test_flip to d3d9. Signed-off-by: Stefan Dösinger <stefan(a)codeweavers.com> --- dlls/d3d9/tests/visual.c | 107 +++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 107 insertions(+) diff --git a/dlls/d3d9/tests/visual.c b/dlls/d3d9/tests/visual.c index d49d3b2..a9b1ade 100644 --- a/dlls/d3d9/tests/visual.c +++ b/dlls/d3d9/tests/visual.c @@ -19796,6 +19796,112 @@ done: DestroyWindow(window); } +static void test_flip(void) +{ + IDirect3DDevice9 *device; + IDirect3D9 *d3d; + ULONG refcount; + HWND window; + HRESULT hr; + IDirect3DSurface9 *back_buffers[3], *test_surface; + unsigned int i; + D3DCOLOR color; + D3DPRESENT_PARAMETERS present_parameters = {0}; + + window = CreateWindowA("static", "d3d9_test", WS_OVERLAPPEDWINDOW, + 0, 0, 640, 480, NULL, NULL, NULL, NULL); + d3d = Direct3DCreate9(D3D_SDK_VERSION); + ok(!!d3d, "Failed to create a D3D object.\n"); + + present_parameters.BackBufferWidth = 640; + present_parameters.BackBufferHeight = 480; + present_parameters.BackBufferFormat = D3DFMT_A8R8G8B8; + present_parameters.SwapEffect = D3DSWAPEFFECT_DISCARD; + present_parameters.hDeviceWindow = window; + present_parameters.Windowed = TRUE; + present_parameters.BackBufferCount = 3; + present_parameters.Flags = D3DPRESENTFLAG_LOCKABLE_BACKBUFFER; + hr = IDirect3D9_CreateDevice(d3d, D3DADAPTER_DEFAULT, D3DDEVTYPE_HAL, + window, D3DCREATE_SOFTWARE_VERTEXPROCESSING, &present_parameters, &device); + if (!device) + { + skip("Failed to create a D3D device, skipping tests.\n"); + IDirect3D9_Release(d3d); + DestroyWindow(window); + return; + } + + for (i = 0; i < sizeof(back_buffers) / sizeof(*back_buffers); ++i) + { + hr = IDirect3DDevice9_GetBackBuffer(device, 0, i, D3DBACKBUFFER_TYPE_MONO, &back_buffers[i]); + ok(SUCCEEDED(hr), "Failed to get back buffer, hr %#x.\n", hr); + } + hr = IDirect3DDevice9_GetRenderTarget(device, 0, &test_surface); + ok(SUCCEEDED(hr), "Failed to get render target, hr %#x.\n", hr); + ok(test_surface == back_buffers[0], "Expected render target %p, got %p.\n", back_buffers[0], test_surface); + IDirect3DSurface9_Release(test_surface); + + hr = IDirect3DDevice9_SetRenderTarget(device, 0, back_buffers[2]); + ok(SUCCEEDED(hr), "Failed to set render target, hr %#x.\n", hr); + + hr = IDirect3DDevice9_ColorFill(device, back_buffers[0], NULL, 0xffff0000); + ok(SUCCEEDED(hr), "Failed to color fill, hr %#x.\n", hr); + hr = IDirect3DDevice9_ColorFill(device, back_buffers[1], NULL, 0xff00ff00); + ok(SUCCEEDED(hr), "Failed to color fill, hr %#x.\n", hr); + hr = IDirect3DDevice9_Clear(device, 0, NULL, D3DCLEAR_TARGET, 0xff0000ff, 0.0f, 0); + ok(SUCCEEDED(hr), "Failed to clear, hr %#x\n", hr); + + hr = IDirect3DDevice9_Present(device, NULL, NULL, NULL, NULL); + ok(SUCCEEDED(hr), "Failed to present, hr %#x.\n", hr); + + /* Render target is unmodified. */ + hr = IDirect3DDevice9_GetRenderTarget(device, 0, &test_surface); + ok(SUCCEEDED(hr), "Failed to get render target, hr %#x.\n", hr); + ok(test_surface == back_buffers[2], "Expected render target %p, got %p.\n", back_buffers[2], test_surface); + IDirect3DSurface9_Release(test_surface); + + /* Backbuffer surface pointers are unmodified */ + for (i = 0; i < sizeof(back_buffers) / sizeof(*back_buffers); ++i) + { + hr = IDirect3DDevice9_GetBackBuffer(device, 0, i, D3DBACKBUFFER_TYPE_MONO, &test_surface); + ok(SUCCEEDED(hr), "Failed to get back buffer, hr %#x.\n", hr); + ok(test_surface == back_buffers[i], "Expected back buffer %u = %p, got %p.\n", + i, back_buffers[i], test_surface); + IDirect3DSurface9_Release(test_surface); + } + + /* Contents were changed. */ + color = getPixelColorFromSurface(back_buffers[0], 1, 1); + todo_wine ok(color == 0xff00ff00, "Got unexpected color 0x%08x.\n", color); + color = getPixelColorFromSurface(back_buffers[1], 1, 1); + todo_wine ok(color == 0xff0000ff, "Got unexpected color 0x%08x.\n", color); + + hr = IDirect3DDevice9_Clear(device, 0, NULL, D3DCLEAR_TARGET, 0xff808080, 0.0f, 0); + ok(SUCCEEDED(hr), "Failed to clear, hr %#x\n", hr); + + hr = IDirect3DDevice9_Present(device, NULL, NULL, NULL, NULL); + ok(SUCCEEDED(hr), "Failed to present, hr %#x.\n", hr); + + color = getPixelColorFromSurface(back_buffers[0], 1, 1); + todo_wine ok(color == 0xff0000ff, "Got unexpected color 0x%08x.\n", color); + color = getPixelColorFromSurface(back_buffers[1], 1, 1); + todo_wine ok(color == 0xff808080, "Got unexpected color 0x%08x.\n", color); + + hr = IDirect3DDevice9_Present(device, NULL, NULL, NULL, NULL); + ok(SUCCEEDED(hr), "Failed to present, hr %#x.\n", hr); + + color = getPixelColorFromSurface(back_buffers[0], 1, 1); + todo_wine ok(color == 0xff808080, "Got unexpected color 0x%08x.\n", color); + + for (i = 0; i < sizeof(back_buffers) / sizeof(*back_buffers); ++i) + IDirect3DSurface9_Release(back_buffers[i]); + + refcount = IDirect3DDevice9_Release(device); + ok(!refcount, "Device has %u references left.\n", refcount); + IDirect3D9_Release(d3d); + DestroyWindow(window); +} + START_TEST(visual) { D3DADAPTER_IDENTIFIER9 identifier; @@ -19914,4 +20020,5 @@ START_TEST(visual) test_vertex_blending(); test_updatetexture(); test_depthbias(); + test_flip(); }

1 0

Stefan Dösinger : d3d8/tests: Port test_flip to d3d8.
by Alexandre Julliard Oct. 6, 2015

Oct. 6, 2015

Module: wine Branch: master Commit: c9c622f083b0d09908e775967b5b06eaaa1e3411 URL: http://source.winehq.org/git/wine.git/?a=commit;h=c9c622f083b0d09908e775967… Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Mon Oct 5 23:13:14 2015 +0200 d3d8/tests: Port test_flip to d3d8. Signed-off-by: Stefan Dösinger <stefan(a)codeweavers.com> --- dlls/d3d8/tests/visual.c | 145 +++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 145 insertions(+) diff --git a/dlls/d3d8/tests/visual.c b/dlls/d3d8/tests/visual.c index 41ef2f9..318d3ca 100644 --- a/dlls/d3d8/tests/visual.c +++ b/dlls/d3d8/tests/visual.c @@ -114,6 +114,38 @@ out: return ret; } +static D3DCOLOR get_surface_color(IDirect3DSurface8 *surface, UINT x, UINT y) +{ + DWORD color; + HRESULT hr; + D3DSURFACE_DESC desc; + RECT rectToLock = {x, y, x+1, y+1}; + D3DLOCKED_RECT lockedRect; + + hr = IDirect3DSurface8_GetDesc(surface, &desc); + ok(SUCCEEDED(hr), "Failed to get surface description, hr=%#x.\n", hr); + + hr = IDirect3DSurface8_LockRect(surface, &lockedRect, &rectToLock, D3DLOCK_READONLY); + ok(SUCCEEDED(hr), "Failed to lock surface, hr=%#x.\n", hr); + + switch(desc.Format) + { + case D3DFMT_A8R8G8B8: + color = ((D3DCOLOR *)lockedRect.pBits)[0]; + break; + + default: + trace("Error: unknown surface format: %u.\n", desc.Format); + color = 0xdeadbeef; + break; + } + + hr = IDirect3DSurface8_UnlockRect(surface); + ok(SUCCEEDED(hr), "Failed to unlock surface, hr=%#x.\n", hr); + + return color; +} + static IDirect3DDevice8 *create_device(IDirect3D8 *d3d, HWND device_window, HWND focus_window, BOOL windowed) { D3DPRESENT_PARAMETERS present_parameters = {0}; @@ -7885,6 +7917,118 @@ done: DestroyWindow(window); } +static void test_flip(void) +{ + IDirect3DDevice8 *device; + IDirect3D8 *d3d; + ULONG refcount; + HWND window; + HRESULT hr; + IDirect3DSurface8 *back_buffers[3], *test_surface; + unsigned int i; + D3DCOLOR color; + D3DPRESENT_PARAMETERS present_parameters = {0}; + + window = CreateWindowA("static", "d3d8_test", WS_OVERLAPPEDWINDOW, + 0, 0, 640, 480, NULL, NULL, NULL, NULL); + d3d = Direct3DCreate8(D3D_SDK_VERSION); + ok(!!d3d, "Failed to create a D3D object.\n"); + + present_parameters.BackBufferWidth = 640; + present_parameters.BackBufferHeight = 480; + present_parameters.BackBufferFormat = D3DFMT_A8R8G8B8; + present_parameters.SwapEffect = D3DSWAPEFFECT_DISCARD; + present_parameters.hDeviceWindow = window; + present_parameters.Windowed = TRUE; + present_parameters.BackBufferCount = 3; + present_parameters.Flags = D3DPRESENTFLAG_LOCKABLE_BACKBUFFER; + hr = IDirect3D8_CreateDevice(d3d, D3DADAPTER_DEFAULT, D3DDEVTYPE_HAL, + window, D3DCREATE_SOFTWARE_VERTEXPROCESSING, &present_parameters, &device); + if (!device) + { + skip("Failed to create a D3D device, skipping tests.\n"); + IDirect3D8_Release(d3d); + DestroyWindow(window); + return; + } + + for (i = 0; i < sizeof(back_buffers) / sizeof(*back_buffers); ++i) + { + hr = IDirect3DDevice8_GetBackBuffer(device, i, D3DBACKBUFFER_TYPE_MONO, &back_buffers[i]); + ok(SUCCEEDED(hr), "Failed to get back buffer, hr %#x.\n", hr); + } + hr = IDirect3DDevice8_GetRenderTarget(device, &test_surface); + ok(SUCCEEDED(hr), "Failed to get render target, hr %#x.\n", hr); + ok(test_surface == back_buffers[0], "Expected render target %p, got %p.\n", back_buffers[0], test_surface); + IDirect3DSurface8_Release(test_surface); + + + hr = IDirect3DDevice8_SetRenderTarget(device, back_buffers[0], NULL); + ok(SUCCEEDED(hr), "Failed to set render target, hr %#x.\n", hr); + hr = IDirect3DDevice8_Clear(device, 0, NULL, D3DCLEAR_TARGET, 0xffff0000, 0.0f, 0); + ok(SUCCEEDED(hr), "Failed to clear, hr %#x\n", hr); + + hr = IDirect3DDevice8_SetRenderTarget(device, back_buffers[1], NULL); + ok(SUCCEEDED(hr), "Failed to set render target, hr %#x.\n", hr); + hr = IDirect3DDevice8_Clear(device, 0, NULL, D3DCLEAR_TARGET, 0xff00ff00, 0.0f, 0); + ok(SUCCEEDED(hr), "Failed to clear, hr %#x\n", hr); + + hr = IDirect3DDevice8_SetRenderTarget(device, back_buffers[2], NULL); + ok(SUCCEEDED(hr), "Failed to set render target, hr %#x.\n", hr); + hr = IDirect3DDevice8_Clear(device, 0, NULL, D3DCLEAR_TARGET, 0xff0000ff, 0.0f, 0); + ok(SUCCEEDED(hr), "Failed to clear, hr %#x\n", hr); + + hr = IDirect3DDevice8_Present(device, NULL, NULL, NULL, NULL); + ok(SUCCEEDED(hr), "Failed to present, hr %#x.\n", hr); + + /* Render target is unmodified. */ + hr = IDirect3DDevice8_GetRenderTarget(device, &test_surface); + ok(SUCCEEDED(hr), "Failed to get render target, hr %#x.\n", hr); + ok(test_surface == back_buffers[2], "Expected render target %p, got %p.\n", back_buffers[2], test_surface); + IDirect3DSurface8_Release(test_surface); + + /* Backbuffer surface pointers are unmodified */ + for (i = 0; i < sizeof(back_buffers) / sizeof(*back_buffers); ++i) + { + hr = IDirect3DDevice8_GetBackBuffer(device, i, D3DBACKBUFFER_TYPE_MONO, &test_surface); + ok(SUCCEEDED(hr), "Failed to get back buffer, hr %#x.\n", hr); + ok(test_surface == back_buffers[i], "Expected back buffer %u = %p, got %p.\n", + i, back_buffers[i], test_surface); + IDirect3DSurface8_Release(test_surface); + } + + /* Contents were changed. */ + color = get_surface_color(back_buffers[0], 1, 1); + todo_wine ok(color == 0xff00ff00, "Got unexpected color 0x%08x.\n", color); + color = get_surface_color(back_buffers[1], 1, 1); + todo_wine ok(color == 0xff0000ff, "Got unexpected color 0x%08x.\n", color); + + hr = IDirect3DDevice8_Clear(device, 0, NULL, D3DCLEAR_TARGET, 0xff808080, 0.0f, 0); + ok(SUCCEEDED(hr), "Failed to clear, hr %#x\n", hr); + + hr = IDirect3DDevice8_Present(device, NULL, NULL, NULL, NULL); + ok(SUCCEEDED(hr), "Failed to present, hr %#x.\n", hr); + + color = get_surface_color(back_buffers[0], 1, 1); + todo_wine ok(color == 0xff0000ff, "Got unexpected color 0x%08x.\n", color); + color = get_surface_color(back_buffers[1], 1, 1); + todo_wine ok(color == 0xff808080, "Got unexpected color 0x%08x.\n", color); + + hr = IDirect3DDevice8_Present(device, NULL, NULL, NULL, NULL); + ok(SUCCEEDED(hr), "Failed to present, hr %#x.\n", hr); + + color = get_surface_color(back_buffers[0], 1, 1); + todo_wine ok(color == 0xff808080, "Got unexpected color 0x%08x.\n", color); + + for (i = 0; i < sizeof(back_buffers) / sizeof(*back_buffers); ++i) + IDirect3DSurface8_Release(back_buffers[i]); + + refcount = IDirect3DDevice8_Release(device); + ok(!refcount, "Device has %u references left.\n", refcount); + IDirect3D8_Release(d3d); + DestroyWindow(window); +} + START_TEST(visual) { D3DADAPTER_IDENTIFIER8 identifier; @@ -7946,4 +8090,5 @@ START_TEST(visual) test_texcoordindex(); test_vshader_input(); test_fixed_function_fvf(); + test_flip(); }

1 0

Józef Kucia : d3d10core/tests: Use 'd3d10core_test' as window name in test_scissor().
by Alexandre Julliard Oct. 6, 2015

Oct. 6, 2015

Module: wine Branch: master Commit: 5b0fb73c1b013a2bd76f1121e26ec847b662a3aa URL: http://source.winehq.org/git/wine.git/?a=commit;h=5b0fb73c1b013a2bd76f1121e… Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Tue Oct 6 01:49:23 2015 +0200 d3d10core/tests: Use 'd3d10core_test' as window name in test_scissor(). Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> --- dlls/d3d10core/tests/device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/d3d10core/tests/device.c b/dlls/d3d10core/tests/device.c index ec835ab..5dc3049 100644 --- a/dlls/d3d10core/tests/device.c +++ b/dlls/d3d10core/tests/device.c @@ -1520,7 +1520,7 @@ static void test_scissor(void) skip("Failed to create device, skipping tests.\n"); return; } - window = CreateWindowA("static", "d2d1_test", WS_OVERLAPPEDWINDOW | WS_VISIBLE, + window = CreateWindowA("static", "d3d10core_test", WS_OVERLAPPEDWINDOW | WS_VISIBLE, 0, 0, 640, 480, NULL, NULL, NULL, NULL); swapchain = create_swapchain(device, window, TRUE); hr = IDXGISwapChain_GetBuffer(swapchain, 0, &IID_ID3D10Texture2D, (void **)&backbuffer);

1 0

Alex Henrie : user32: Remove unused parameter istep from release_icon_frame.
by Alexandre Julliard Oct. 6, 2015

Oct. 6, 2015

Module: wine Branch: master Commit: be5015fb74531408cbd5347c6724ba03500820c1 URL: http://source.winehq.org/git/wine.git/?a=commit;h=be5015fb74531408cbd5347c6… Author: Alex Henrie <alexhenrie24(a)gmail.com> Date: Sun Oct 4 21:27:55 2015 -0600 user32: Remove unused parameter istep from release_icon_frame. Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> --- dlls/user32/cursoricon.c | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/dlls/user32/cursoricon.c b/dlls/user32/cursoricon.c index 5594909..b94a177 100644 --- a/dlls/user32/cursoricon.c +++ b/dlls/user32/cursoricon.c @@ -178,7 +178,7 @@ static struct cursoricon_frame *get_icon_frame( struct cursoricon_object *obj, i return &req_frame->frame; } -static void release_icon_frame( struct cursoricon_object *obj, int istep, struct cursoricon_frame *frame ) +static void release_icon_frame( struct cursoricon_object *obj, struct cursoricon_frame *frame ) { if (obj->is_ani) { @@ -220,7 +220,7 @@ static BOOL free_icon_handle( HICON handle ) if (frame->alpha) DeleteObject( frame->alpha ); if (frame->color) DeleteObject( frame->color ); DeleteObject( frame->mask ); - release_icon_frame( obj, 0, frame ); + release_icon_frame( obj, frame ); } else { @@ -476,7 +476,7 @@ BOOL get_icon_size( HICON handle, SIZE *size ) frame = get_icon_frame( info, 0 ); size->cx = frame->width; size->cy = frame->height; - release_icon_frame( info, 0, frame); + release_icon_frame( info, frame); release_user_handle_ptr( info ); return TRUE; } @@ -956,7 +956,7 @@ done: frame->color = color; frame->mask = mask; frame->alpha = alpha; - release_icon_frame( info, 0, frame ); + release_icon_frame( info, frame ); if (!IS_INTRESOURCE(resname)) { info->resname = HeapAlloc( GetProcessHeap(), 0, (strlenW(resname) + 1) * sizeof(WCHAR) ); @@ -1264,7 +1264,7 @@ static HCURSOR CURSORICON_CreateIconFromANI( const BYTE *bits, DWORD bits_size, frame->delay = frame_rates[i]; else frame->delay = ~0; - release_icon_frame( info, i, frame ); + release_icon_frame( info, frame ); } HeapFree( GetProcessHeap(), 0, frames ); @@ -1591,7 +1591,7 @@ HICON WINAPI CopyIcon( HICON hIcon ) } if (!(frameNew = get_icon_frame( ptrNew, 0 ))) { - release_icon_frame( ptrOld, 0, frameOld ); + release_icon_frame( ptrOld, frameOld ); release_user_handle_ptr( ptrOld ); SetLastError( ERROR_INVALID_CURSOR_HANDLE ); return 0; @@ -1602,8 +1602,8 @@ HICON WINAPI CopyIcon( HICON hIcon ) frameNew->mask = copy_bitmap( frameOld->mask ); frameNew->color = copy_bitmap( frameOld->color ); frameNew->alpha = copy_bitmap( frameOld->alpha ); - release_icon_frame( ptrOld, 0, frameOld ); - release_icon_frame( ptrNew, 0, frameNew ); + release_icon_frame( ptrOld, frameOld ); + release_icon_frame( ptrNew, frameNew ); release_user_handle_ptr( ptrNew ); } release_user_handle_ptr( ptrOld ); @@ -1975,7 +1975,7 @@ HCURSOR WINAPI GetCursorFrameInfo(HCURSOR hCursor, DWORD reserved, DWORD istep, *rate_jiffies = ptr->delay; else *rate_jiffies = frame->delay; - release_icon_frame( ptr, istep, frame ); + release_icon_frame( ptr, frame ); } } @@ -2077,7 +2077,7 @@ BOOL WINAPI GetIconInfoExW( HICON icon, ICONINFOEXW *info ) ret = FALSE; } module = ptr->module; - release_icon_frame( ptr, 0, frame ); + release_icon_frame( ptr, frame ); release_user_handle_ptr( ptr ); if (ret && module) GetModuleFileNameW( module, info->szModName, MAX_PATH ); return ret; @@ -2196,7 +2196,7 @@ HICON WINAPI CreateIconIndirect(PICONINFO iconinfo) frame->color = color; frame->mask = mask; frame->alpha = create_alpha_bitmap( iconinfo->hbmColor, mask, NULL, NULL ); - release_icon_frame( info, 0, frame ); + release_icon_frame( info, frame ); if (info->is_icon) { info->hotspot.x = width / 2; @@ -2264,7 +2264,7 @@ BOOL WINAPI DrawIconEx( HDC hdc, INT x0, INT y0, HICON hIcon, } if (!(hMemDC = CreateCompatibleDC( hdc ))) { - release_icon_frame( ptr, istep, frame ); + release_icon_frame( ptr, frame ); release_user_handle_ptr( ptr ); return FALSE; } @@ -2378,7 +2378,7 @@ done: if (hB_off) DeleteObject(hB_off); failed: DeleteDC( hMemDC ); - release_icon_frame( ptr, istep, frame ); + release_icon_frame( ptr, frame ); release_user_handle_ptr( ptr ); return result; }

1 0

Alex Henrie : user32: Move misplaced break statement.
by Alexandre Julliard Oct. 6, 2015

Oct. 6, 2015

Module: wine Branch: master Commit: d687512674d92d5075447feba075297fa141a344 URL: http://source.winehq.org/git/wine.git/?a=commit;h=d687512674d92d5075447feba… Author: Alex Henrie <alexhenrie24(a)gmail.com> Date: Sun Oct 4 21:27:54 2015 -0600 user32: Move misplaced break statement. Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> --- dlls/user32/spy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/user32/spy.c b/dlls/user32/spy.c index b370aea..c0acd82 100644 --- a/dlls/user32/spy.c +++ b/dlls/user32/spy.c @@ -2520,10 +2520,10 @@ static void SPY_DumpStructure(const SPY_INSTANCE *sp_e, BOOL enter) TRACE("NMHDR hwndFrom=%p idFrom=0x%08lx code=0x%08x\n", pnmh->hwndFrom, pnmh->idFrom, pnmh->code); } + break; default: if (sp_e->data_len > 0) SPY_DumpMem ("MSG lParam", (UINT *)sp_e->lParam, sp_e->data_len); - break; } }

1 0