December 2015 - Wine-Commits

Bruno Jesus : msacm32/tests: Add more acmStreamPrepareHeader tests.
by Alexandre Julliard Dec. 1, 2015

Dec. 1, 2015

Module: wine Branch: master Commit: 395b9c321b6788463d2e2f03b603600f8bb78454 URL: http://source.winehq.org/git/wine.git/?a=commit;h=395b9c321b6788463d2e2f03b… Author: Bruno Jesus <00cpxxx(a)gmail.com> Date: Fri Nov 27 21:10:04 2015 +0800 msacm32/tests: Add more acmStreamPrepareHeader tests. Signed-off-by: Bruno Jesus <00cpxxx(a)gmail.com> Signed-off-by: Andrew Eikum <aeikum(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/msacm32/tests/msacm.c | 30 +++++++++++++++++++++++++++++- 1 file changed, 29 insertions(+), 1 deletion(-) diff --git a/dlls/msacm32/tests/msacm.c b/dlls/msacm32/tests/msacm.c index bb4ccc5..812a1bb 100644 --- a/dlls/msacm32/tests/msacm.c +++ b/dlls/msacm32/tests/msacm.c @@ -586,6 +586,33 @@ static void test_prepareheader(void) memset(&hdr, 0, sizeof(hdr)); hdr.cbStruct = sizeof(hdr); hdr.pbSrc = input; + hdr.cbSrcLength = 0; /* invalid source length */ + hdr.pbDst = pcm; + hdr.cbDstLength = sizeof(pcm); + + mr = acmStreamPrepareHeader(has, &hdr, 0); +todo_wine + ok(mr == MMSYSERR_INVALPARAM, "expected 0x0b, got 0x%x\n", mr); + + hdr.cbSrcLength = src->wfx.nBlockAlign - 1; /* less than block align */ + mr = acmStreamPrepareHeader(has, &hdr, 0); +todo_wine + ok(mr == ACMERR_NOTPOSSIBLE, "expected 0x200, got 0x%x\n", mr); + + hdr.cbSrcLength = src->wfx.nBlockAlign; + mr = acmStreamPrepareHeader(has, &hdr, 1); /* invalid use of reserved parameter */ +todo_wine + ok(mr == MMSYSERR_INVALFLAG, "expected 0x0a, got 0x%x\n", mr); + + mr = acmStreamPrepareHeader(has, &hdr, 0); + ok(mr == MMSYSERR_NOERROR, "prepare failed: 0x%x\n", mr); + + mr = acmStreamUnprepareHeader(has, &hdr, 0); + ok(mr == MMSYSERR_NOERROR, "unprepare failed: 0x%x\n", mr); + + memset(&hdr, 0, sizeof(hdr)); + hdr.cbStruct = sizeof(hdr); + hdr.pbSrc = input; hdr.cbSrcLength = sizeof(input); hdr.pbDst = pcm; hdr.cbDstLength = sizeof(pcm); @@ -638,7 +665,8 @@ todo_wine ok(hdr.fdwStatus == ACMSTREAMHEADER_STATUSF_DONE, "header wasn't unprepared: 0x%x\n", hdr.fdwStatus); } else - ok(mr == MMSYSERR_INVALPARAM, "expected 11, got %d\n", mr); +todo_wine + ok(mr == MMSYSERR_INVALPARAM, "expected 0x0b, got 0x%x\n", mr); memset(&hdr, 0, sizeof(hdr)); hdr.cbStruct = sizeof(hdr);

1 0

Ken Thomases : winemac: Don' t post a WINDOW_BROUGHT_FORWARD event for a click on a window which is already frontmost in its level.
by Alexandre Julliard Dec. 1, 2015

Dec. 1, 2015

Module: wine Branch: master Commit: 5c992f965335ccb02a90ebcb10a881649cbab859 URL: http://source.winehq.org/git/wine.git/?a=commit;h=5c992f965335ccb02a90ebcb1… Author: Ken Thomases <ken(a)codeweavers.com> Date: Mon Nov 30 20:10:32 2015 -0600 winemac: Don't post a WINDOW_BROUGHT_FORWARD event for a click on a window which is already frontmost in its level. Commit 793ab7d45 fixed a bug where WINDOW_BROUGHT_FORWARD events weren't being posted when they should, but it caused a regression in Scribblenauts Unlimited. Every click caused a window ordering operation that generated messages and Scribblenauts would move the mouse cursor to the upper-left corner of the window in response. Signed-off-by: Ken Thomases <ken(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/winemac.drv/cocoa_app.m | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/dlls/winemac.drv/cocoa_app.m b/dlls/winemac.drv/cocoa_app.m index 3a80f1d..fb9edc2 100644 --- a/dlls/winemac.drv/cocoa_app.m +++ b/dlls/winemac.drv/cocoa_app.m @@ -1745,7 +1745,23 @@ static NSString* WineLocalizedString(unsigned int stringID) if (windowBroughtForward) { - [[windowBroughtForward ancestorWineWindow] postBroughtForwardEvent]; + WineWindow* ancestor = [windowBroughtForward ancestorWineWindow]; + NSInteger ancestorNumber = [ancestor windowNumber]; + NSInteger ancestorLevel = [ancestor level]; + + for (NSNumber* windowNumberObject in [NSWindow windowNumbersWithOptions:0]) + { + NSInteger windowNumber = [windowNumberObject integerValue]; + if (windowNumber == ancestorNumber) + break; + WineWindow* otherWindow = (WineWindow*)[NSApp windowWithWindowNumber:windowNumber]; + if ([otherWindow isKindOfClass:[WineWindow class]] && [otherWindow screen] && + [otherWindow level] <= ancestorLevel && otherWindow == [otherWindow ancestorWineWindow]) + { + [ancestor postBroughtForwardEvent]; + break; + } + } if (!process && ![windowBroughtForward isKeyWindow] && !windowBroughtForward.disabled && !windowBroughtForward.noActivate) [self windowGotFocus:windowBroughtForward]; }

1 0

Henri Verbeet : ddraw/tests: 64-bit ddraw doesn't support textures.
by Alexandre Julliard Dec. 1, 2015

Dec. 1, 2015

Module: wine Branch: master Commit: 2dca999e3393cb039d2aabebf7c83328925ab30e URL: http://source.winehq.org/git/wine.git/?a=commit;h=2dca999e3393cb039d2aabebf… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Tue Dec 1 11:25:43 2015 +0100 ddraw/tests: 64-bit ddraw doesn't support textures. Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ddraw/tests/ddraw7.c | 37 ++++++++++++++++++++++++++----------- 1 file changed, 26 insertions(+), 11 deletions(-) diff --git a/dlls/ddraw/tests/ddraw7.c b/dlls/ddraw/tests/ddraw7.c index 345550d..8ab0972 100644 --- a/dlls/ddraw/tests/ddraw7.c +++ b/dlls/ddraw/tests/ddraw7.c @@ -24,6 +24,7 @@ #include "d3d.h" static HRESULT (WINAPI *pDirectDrawCreateEx)(GUID *guid, void **ddraw, REFIID iid, IUnknown *outer_unknown); +static BOOL is_ddraw64 = sizeof(DWORD) != sizeof(DWORD *); static DEVMODEW registry_mode; struct vec2 @@ -4669,7 +4670,10 @@ static void test_texturemanage(void) ddsd.dwHeight = 4; hr = IDirectDraw7_CreateSurface(ddraw, &ddsd, &surface, NULL); - ok(hr == tests[i].hr, "Got unexpected, hr %#x, case %u.\n", hr, i); + if (tests[i].hr == DD_OK && is_ddraw64 && (tests[i].caps_in & DDSCAPS_TEXTURE)) + todo_wine ok(hr == E_NOINTERFACE, "Test %u: Got unexpected hr %#x.\n", i, hr); + else + ok(hr == tests[i].hr, "Test %u: Got unexpected hr %#x, expected %#x.\n", i, hr, tests[i].hr); if (FAILED(hr)) continue; @@ -6379,13 +6383,12 @@ static void test_set_surface_desc(void) } hr = IDirectDraw7_CreateSurface(ddraw, &ddsd, &surface, NULL); - ok(SUCCEEDED(hr) || hr == DDERR_NODIRECTDRAWHW, "Failed to create surface, hr %#x.\n", hr); + if (is_ddraw64 && (invalid_caps_tests[i].caps & DDSCAPS_TEXTURE)) + todo_wine ok(hr == E_NOINTERFACE, "Test %u: Got unexpected hr %#x.\n", i, hr); + else + ok(hr == DD_OK || hr == DDERR_NODIRECTDRAWHW, "Test %u: Got unexpected hr %#x.\n", i, hr); if (FAILED(hr)) - { - skip("Cannot create a %s surface, skipping vidmem SetSurfaceDesc test.\n", - invalid_caps_tests[i].name); - goto done; - } + continue; reset_ddsd(&ddsd); ddsd.dwFlags = DDSD_LPSURFACE; @@ -6410,7 +6413,6 @@ static void test_set_surface_desc(void) IDirectDrawSurface7_Release(surface); } -done: ref = IDirectDraw7_Release(ddraw); ok(ref == 0, "Ddraw object not properly released, refcount %u.\n", ref); DestroyWindow(window); @@ -7058,7 +7060,8 @@ static void test_private_data(void) hal_caps.dwSize = sizeof(hal_caps); hr = IDirectDraw7_GetCaps(ddraw, &hal_caps, NULL); ok(SUCCEEDED(hr), "Failed to get caps, hr %#x.\n", hr); - if ((hal_caps.ddsCaps.dwCaps & (DDSCAPS_TEXTURE | DDSCAPS_MIPMAP)) == (DDSCAPS_TEXTURE | DDSCAPS_MIPMAP)) + if ((hal_caps.ddsCaps.dwCaps & (DDSCAPS_TEXTURE | DDSCAPS_MIPMAP)) == (DDSCAPS_TEXTURE | DDSCAPS_MIPMAP) + && !is_ddraw64) { reset_ddsd(&surface_desc); surface_desc.dwFlags = DDSD_CAPS | DDSD_HEIGHT | DDSD_WIDTH | DDSD_MIPMAPCOUNT; @@ -7378,7 +7381,8 @@ static void test_mipmap_lock(void) hal_caps.dwSize = sizeof(hal_caps); hr = IDirectDraw7_GetCaps(ddraw, &hal_caps, NULL); ok(SUCCEEDED(hr), "Failed to get caps, hr %#x.\n", hr); - if ((hal_caps.ddsCaps.dwCaps & (DDSCAPS_TEXTURE | DDSCAPS_MIPMAP)) != (DDSCAPS_TEXTURE | DDSCAPS_MIPMAP)) + if ((hal_caps.ddsCaps.dwCaps & (DDSCAPS_TEXTURE | DDSCAPS_MIPMAP)) != (DDSCAPS_TEXTURE | DDSCAPS_MIPMAP) + || is_ddraw64) { skip("Mipmapped textures not supported, skipping mipmap lock test.\n"); IDirectDraw7_Release(ddraw); @@ -7442,7 +7446,8 @@ static void test_palette_complex(void) hal_caps.dwSize = sizeof(hal_caps); hr = IDirectDraw7_GetCaps(ddraw, &hal_caps, NULL); ok(SUCCEEDED(hr), "Failed to get caps, hr %#x.\n", hr); - if ((hal_caps.ddsCaps.dwCaps & (DDSCAPS_TEXTURE | DDSCAPS_MIPMAP)) != (DDSCAPS_TEXTURE | DDSCAPS_MIPMAP)) + if ((hal_caps.ddsCaps.dwCaps & (DDSCAPS_TEXTURE | DDSCAPS_MIPMAP)) != (DDSCAPS_TEXTURE | DDSCAPS_MIPMAP) + || is_ddraw64) { skip("Mipmapped textures not supported, skipping mipmap palette test.\n"); IDirectDraw7_Release(ddraw); @@ -8381,6 +8386,13 @@ static void test_resource_priority(void) surface_desc.ddsCaps.dwCaps = test_data[i].caps; surface_desc.ddsCaps.dwCaps2 = test_data[i].caps2; hr = IDirectDraw7_CreateSurface(ddraw, &surface_desc, &surface, NULL); + if (is_ddraw64 && (test_data[i].caps & DDSCAPS_TEXTURE)) + { + todo_wine ok(hr == E_NOINTERFACE, "Got unexpected hr %#x, type %s.\n", hr, test_data[i].name); + if (SUCCEEDED(hr)) + IDirectDrawSurface7_Release(surface); + continue; + } ok(SUCCEEDED(hr), "Failed to create surface, hr %#x, type %s.\n", hr, test_data[i].name); /* Priority == NULL segfaults. */ @@ -8411,6 +8423,9 @@ static void test_resource_priority(void) IDirectDrawSurface7_Release(surface); } + if (is_ddraw64) + goto done; + memset(&surface_desc, 0, sizeof(surface_desc)); surface_desc.dwSize = sizeof(surface_desc); surface_desc.dwFlags = DDSD_WIDTH | DDSD_HEIGHT | DDSD_CAPS | DDSD_MIPMAPCOUNT;

1 0

Stefan Dösinger : ddraw/tests: Test color keys on cube map surfaces.
by Alexandre Julliard Dec. 1, 2015

Dec. 1, 2015

Module: wine Branch: master Commit: 7e01f865ab092b4293800e7de7e2b57040f2db0d URL: http://source.winehq.org/git/wine.git/?a=commit;h=7e01f865ab092b4293800e7de… Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Mon Nov 30 21:06:29 2015 +0100 ddraw/tests: Test color keys on cube map surfaces. Signed-off-by: Stefan Dösinger <stefan(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ddraw/tests/ddraw7.c | 69 +++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 69 insertions(+) diff --git a/dlls/ddraw/tests/ddraw7.c b/dlls/ddraw/tests/ddraw7.c index 24e7fc8..345550d 100644 --- a/dlls/ddraw/tests/ddraw7.c +++ b/dlls/ddraw/tests/ddraw7.c @@ -1613,6 +1613,7 @@ static void test_ck_default(void) static void test_ck_complex(void) { IDirectDrawSurface7 *surface, *mipmap, *tmp; + D3DDEVICEDESC7 device_desc; DDSCAPS2 caps = {DDSCAPS_COMPLEX, 0, 0, {0}}; DDSURFACEDESC2 surface_desc; IDirect3DDevice7 *device; @@ -1632,6 +1633,8 @@ static void test_ck_complex(void) DestroyWindow(window); return; } + hr = IDirect3DDevice7_GetCaps(device, &device_desc); + ok(SUCCEEDED(hr), "Failed to get device caps, hr %#x.\n", hr); hr = IDirect3DDevice7_GetDirect3D(device, &d3d); ok(SUCCEEDED(hr), "Failed to get d3d interface, hr %#x.\n", hr); hr = IDirect3D7_QueryInterface(d3d, &IID_IDirectDraw7, (void **)&ddraw); @@ -1728,6 +1731,72 @@ static void test_ck_complex(void) refcount = IDirectDrawSurface7_Release(surface); ok(!refcount, "Got unexpected refcount %u.\n", refcount); + + if (!(device_desc.dpcTriCaps.dwTextureCaps & D3DPTEXTURECAPS_CUBEMAP)) + { + skip("Device does not support cubemaps.\n"); + goto cleanup; + } + memset(&surface_desc, 0, sizeof(surface_desc)); + surface_desc.dwSize = sizeof(surface_desc); + surface_desc.dwFlags = DDSD_CAPS | DDSD_WIDTH | DDSD_HEIGHT; + surface_desc.ddsCaps.dwCaps = DDSCAPS_TEXTURE | DDSCAPS_COMPLEX | DDSCAPS_MIPMAP; + surface_desc.ddsCaps.dwCaps2 = DDSCAPS2_CUBEMAP | DDSCAPS2_CUBEMAP_ALLFACES; + surface_desc.dwWidth = 128; + surface_desc.dwHeight = 128; + hr = IDirectDraw7_CreateSurface(ddraw, &surface_desc, &surface, NULL); + ok(SUCCEEDED(hr), "Failed to create surface, hr %#x.\n", hr); + + hr = IDirectDrawSurface7_GetColorKey(surface, DDCKEY_SRCBLT, &color_key); + ok(hr == DDERR_NOCOLORKEY, "Got unexpected hr %#x.\n", hr); + color_key.dwColorSpaceLowValue = 0x0000ff00; + color_key.dwColorSpaceHighValue = 0x0000ff00; + hr = IDirectDrawSurface7_SetColorKey(surface, DDCKEY_SRCBLT, &color_key); + ok(SUCCEEDED(hr), "Failed to set color key, hr %#x.\n", hr); + + caps.dwCaps2 = DDSCAPS2_CUBEMAP_NEGATIVEZ; + hr = IDirectDrawSurface7_GetAttachedSurface(surface, &caps, &mipmap); + ok(SUCCEEDED(hr), "Failed to get attached surface, i %u, hr %#x.\n", i, hr); + + hr = IDirectDrawSurface7_GetColorKey(mipmap, DDCKEY_SRCBLT, &color_key); + ok(hr == DDERR_NOCOLORKEY, "Got unexpected hr %#x.\n", hr); + color_key.dwColorSpaceLowValue = 0x000000ff; + color_key.dwColorSpaceHighValue = 0x000000ff; + hr = IDirectDrawSurface7_SetColorKey(mipmap, DDCKEY_SRCBLT, &color_key); + todo_wine ok(SUCCEEDED(hr), "Failed to set color key, hr %#x.\n", hr); + + color_key.dwColorSpaceLowValue = 0; + color_key.dwColorSpaceHighValue = 0; + hr = IDirectDrawSurface7_GetColorKey(mipmap, DDCKEY_SRCBLT, &color_key); + todo_wine ok(SUCCEEDED(hr), "Failed to get color key, hr %#x.\n", hr); + todo_wine ok(color_key.dwColorSpaceLowValue == 0x000000ff, "Got unexpected value 0x%08x.\n", + color_key.dwColorSpaceLowValue); + todo_wine ok(color_key.dwColorSpaceHighValue == 0x000000ff, "Got unexpected value 0x%08x.\n", + color_key.dwColorSpaceHighValue); + + IDirectDrawSurface_AddRef(mipmap); + for (i = 0; i < 7; ++i) + { + hr = IDirectDrawSurface7_GetAttachedSurface(mipmap, &caps, &tmp); + ok(SUCCEEDED(hr), "Failed to get attached surface, i %u, hr %#x.\n", i, hr); + hr = IDirectDrawSurface7_GetColorKey(tmp, DDCKEY_SRCBLT, &color_key); + ok(hr == DDERR_NOCOLORKEY, "Got unexpected hr %#x, i %u.\n", hr, i); + + color_key.dwColorSpaceLowValue = 0x000000ff; + color_key.dwColorSpaceHighValue = 0x000000ff; + hr = IDirectDrawSurface7_SetColorKey(tmp, DDCKEY_SRCBLT, &color_key); + ok(hr == DDERR_NOTONMIPMAPSUBLEVEL, "Got unexpected hr %#x, i %u.\n", hr, i); + + IDirectDrawSurface_Release(mipmap); + mipmap = tmp; + } + + IDirectDrawSurface7_Release(mipmap); + + refcount = IDirectDrawSurface7_Release(surface); + ok(!refcount, "Got unexpected refcount %u.\n", refcount); + +cleanup: IDirectDraw7_Release(ddraw); refcount = IDirect3DDevice7_Release(device); ok(!refcount, "Got unexpected refcount %u.\n", refcount);

1 0

Alexandre Julliard : winex11: Ignore EnterNotify events that are older than the last mouse wrap.
by Alexandre Julliard Dec. 1, 2015

Dec. 1, 2015

Module: wine Branch: master Commit: 49e1ba7d4ba31f2a16fa4527e8028fb876a7b026 URL: http://source.winehq.org/git/wine.git/?a=commit;h=49e1ba7d4ba31f2a16fa4527e… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Dec 1 17:42:38 2015 +0900 winex11: Ignore EnterNotify events that are older than the last mouse wrap. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/winex11.drv/mouse.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/dlls/winex11.drv/mouse.c b/dlls/winex11.drv/mouse.c index 356343d..63d202c 100644 --- a/dlls/winex11.drv/mouse.c +++ b/dlls/winex11.drv/mouse.c @@ -1621,6 +1621,11 @@ void X11DRV_EnterNotify( HWND hwnd, XEvent *xev ) input.u.mi.time = EVENT_x11_time_to_win32_time( event->time ); input.u.mi.dwExtraInfo = 0; + if (is_old_motion_event( event->serial )) + { + TRACE( "pos %d,%d old serial %lu, ignoring\n", input.u.mi.dx, input.u.mi.dy, event->serial ); + return; + } send_mouse_input( hwnd, event->window, event->state, &input ); }

1 0

Hugh McMaster : user32/tests: Add tests for VK_SPACE, Shift-Space and Ctrl-Space.
by Alexandre Julliard Dec. 1, 2015

Dec. 1, 2015

Module: wine Branch: master Commit: c87a78bc949c5b497e58364053d29e18c305d3ca URL: http://source.winehq.org/git/wine.git/?a=commit;h=c87a78bc949c5b497e5836405… Author: Hugh McMaster <hugh.mcmaster(a)outlook.com> Date: Tue Dec 1 21:38:01 2015 +1100 user32/tests: Add tests for VK_SPACE, Shift-Space and Ctrl-Space. Signed-off-by: Hugh McMaster <hugh.mcmaster(a)outlook.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/user32/tests/input.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/dlls/user32/tests/input.c b/dlls/user32/tests/input.c index d662d6f..0d7c6d6 100644 --- a/dlls/user32/tests/input.c +++ b/dlls/user32/tests/input.c @@ -1635,6 +1635,9 @@ static const struct tounicode_tests { 0, ctrl, '^', 1, {0x1e}}, { 0, ctrl, '_', 1, {0x1f}}, { 0, ctrl, '`', 0, {}}, + { VK_SPACE, 0, 0, 1, {' ',0}}, + { VK_SPACE, shift, 0, 1, {' ',0}}, + { VK_SPACE, ctrl, 0, 1, {' ',0}}, }; static void test_ToUnicode(void)

1 0

Ken Thomases : winemac: Remove a window from the NSWorkspace notification center when it' s deallocated.
by Alexandre Julliard Dec. 1, 2015

Dec. 1, 2015

Module: wine Branch: master Commit: ebcf8aadc54a12aa9359da109ea89608e417210c URL: http://source.winehq.org/git/wine.git/?a=commit;h=ebcf8aadc54a12aa9359da109… Author: Ken Thomases <ken(a)codeweavers.com> Date: Mon Nov 30 14:34:59 2015 -0600 winemac: Remove a window from the NSWorkspace notification center when it's deallocated. It was added as an observer in commit 3beec95a0. Failing to remove it caused the notification center to have a dangling pointer and caused crashes and hangs. Signed-off-by: Ken Thomases <ken(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/winemac.drv/cocoa_window.m | 1 + 1 file changed, 1 insertion(+) diff --git a/dlls/winemac.drv/cocoa_window.m b/dlls/winemac.drv/cocoa_window.m index 75f5605..bcc1cf5 100644 --- a/dlls/winemac.drv/cocoa_window.m +++ b/dlls/winemac.drv/cocoa_window.m @@ -777,6 +777,7 @@ static CVReturn WineDisplayLinkCallback(CVDisplayLinkRef displayLink, const CVTi - (void) dealloc { + [[[NSWorkspace sharedWorkspace] notificationCenter] removeObserver:self]; [[NSNotificationCenter defaultCenter] removeObserver:self]; [queue release]; [latentChildWindows release];

1 0