March 2015 - Wine-Commits - list.winehq.org

Andrey Gusev : d3dx9_36: Assorted spelling and typos fixes.
by Alexandre Julliard March 30, 2015

March 30, 2015

Module: wine Branch: master Commit: 07630a9eae94fc2d2a713c68a70652bfca6c1353 URL: http://source.winehq.org/git/wine.git/?a=commit;h=07630a9eae94fc2d2a713c68a… Author: Andrey Gusev <andrey.goosev(a)gmail.com> Date: Sun Mar 29 13:51:20 2015 +0300 d3dx9_36: Assorted spelling and typos fixes. --- dlls/d3dx9_36/mesh.c | 14 +++++++------- dlls/d3dx9_36/surface.c | 4 ++-- dlls/d3dx9_36/texture.c | 8 ++++---- dlls/d3dx9_36/volume.c | 2 +- dlls/d3dx9_36/xfile.c | 2 +- 5 files changed, 15 insertions(+), 15 deletions(-) diff --git a/dlls/d3dx9_36/mesh.c b/dlls/d3dx9_36/mesh.c index b1a1a76..746b479 100644 --- a/dlls/d3dx9_36/mesh.c +++ b/dlls/d3dx9_36/mesh.c @@ -3180,7 +3180,7 @@ static HRESULT parse_mesh(ID3DXFileData *filedata, struct mesh_data *mesh_data, ID3DXFileData *child = NULL; DWORD i; SIZE_T nb_children; - DWORD nb_skin_weigths_info = 0; + DWORD nb_skin_weights_info = 0; /* * template Mesh { @@ -3310,14 +3310,14 @@ static HRESULT parse_mesh(ID3DXFileData *filedata, struct mesh_data *mesh_data, goto end; } else if (IsEqualGUID(&type, &DXFILEOBJ_SkinWeights)) { if (!mesh_data->skin_info) { - WARN("Skin weigths found but skin mesh header not encountered yet\n"); + WARN("Skin weights found but skin mesh header not encountered yet\n"); hr = E_FAIL; goto end; } - hr = parse_skin_mesh_info(child, mesh_data, nb_skin_weigths_info); + hr = parse_skin_mesh_info(child, mesh_data, nb_skin_weights_info); if (FAILED(hr)) goto end; - nb_skin_weigths_info++; + nb_skin_weights_info++; } } if (FAILED(hr)) @@ -3327,9 +3327,9 @@ static HRESULT parse_mesh(ID3DXFileData *filedata, struct mesh_data *mesh_data, child = NULL; } - if (mesh_data->skin_info && (nb_skin_weigths_info != mesh_data->nb_bones)) { + if (mesh_data->skin_info && (nb_skin_weights_info != mesh_data->nb_bones)) { WARN("Mismatch between nb skin weights info %u encountered and nb bones %u from skin mesh header\n", - nb_skin_weigths_info, mesh_data->nb_bones); + nb_skin_weights_info, mesh_data->nb_bones); hr = E_FAIL; goto end; } @@ -7005,7 +7005,7 @@ HRESULT WINAPI D3DXWeldVertices(ID3DXMesh *mesh, DWORD flags, const D3DXWELDEPSI if (flags == 0) { - WARN("No flags is undefined. Using D3DXWELDEPSILONS_WELDPARTIALMATCHES instead.\n"); + WARN("No flags are undefined. Using D3DXWELDEPSILONS_WELDPARTIALMATCHES instead.\n"); flags = D3DXWELDEPSILONS_WELDPARTIALMATCHES; } diff --git a/dlls/d3dx9_36/surface.c b/dlls/d3dx9_36/surface.c index f187031..295ef63 100644 --- a/dlls/d3dx9_36/surface.c +++ b/dlls/d3dx9_36/surface.c @@ -1758,7 +1758,7 @@ HRESULT WINAPI D3DXLoadSurfaceFromMemory(IDirect3DSurface9 *dst_surface, D3DLOCKED_RECT lockrect; struct volume src_size, dst_size; - TRACE("(%p, %p, %s, %p, %#x, %u, %p, %s %#x, 0x%08x)\n", + TRACE("(%p, %p, %s, %p, %#x, %u, %p, %s, %#x, 0x%08x)\n", dst_surface, dst_palette, wine_dbgstr_rect(dst_rect), src_memory, src_format, src_pitch, src_palette, wine_dbgstr_rect(src_rect), filter, color_key); @@ -2006,7 +2006,7 @@ HRESULT WINAPI D3DXSaveSurfaceToFileInMemory(ID3DXBuffer **dst_buffer, D3DXIMAGE if (src_palette) { - FIXME("Saving surfaces with palettized pixel formats not implemented yet\n"); + FIXME("Saving surfaces with palettized pixel formats is not implemented yet\n"); return D3DERR_INVALIDCALL; } diff --git a/dlls/d3dx9_36/texture.c b/dlls/d3dx9_36/texture.c index de42307..38349e2 100644 --- a/dlls/d3dx9_36/texture.c +++ b/dlls/d3dx9_36/texture.c @@ -269,7 +269,7 @@ HRESULT WINAPI D3DXCheckTextureRequirements(struct IDirect3DDevice9 *device, UIN unsigned int channels; const struct pixel_format_desc *curfmt, *bestfmt = NULL; - TRACE("Requested format not supported, looking for a fallback.\n"); + TRACE("Requested format is not supported, looking for a fallback.\n"); if (!fmt) { @@ -661,7 +661,7 @@ HRESULT WINAPI D3DXCreateTextureFromFileInMemoryEx(struct IDirect3DDevice9 *devi if (imginfo.MipLevels < miplevels && (D3DFMT_DXT1 <= imginfo.Format && imginfo.Format <= D3DFMT_DXT5)) { - FIXME("Generation of mipmaps for compressed pixel formats is not implemented yet\n"); + FIXME("Generation of mipmaps for compressed pixel formats is not implemented yet.\n"); miplevels = imginfo.MipLevels; } if (imginfo.ResourceType == D3DRTYPE_VOLUMETEXTURE @@ -1219,7 +1219,7 @@ HRESULT WINAPI D3DXCreateVolumeTextureFromFileInMemoryEx(IDirect3DDevice9 *devic if (mip_levels > image_info.MipLevels) { - FIXME("Generation of mipmaps for volume textures is not implemented yet\n"); + FIXME("Generation of mipmaps for volume textures is not implemented yet.\n"); mip_levels = image_info.MipLevels; } @@ -1460,7 +1460,7 @@ HRESULT WINAPI D3DXCreateCubeTextureFromFileInMemoryEx(IDirect3DDevice9 *device, if (mip_levels > img_info.MipLevels && (D3DFMT_DXT1 <= img_info.Format && img_info.Format <= D3DFMT_DXT5)) { - FIXME("Generation of mipmaps for compressed pixel formats not supported yet\n"); + FIXME("Generation of mipmaps for compressed pixel formats is not supported yet.\n"); mip_levels = img_info.MipLevels; } diff --git a/dlls/d3dx9_36/volume.c b/dlls/d3dx9_36/volume.c index 52683da..fae8542 100644 --- a/dlls/d3dx9_36/volume.c +++ b/dlls/d3dx9_36/volume.c @@ -189,7 +189,7 @@ HRESULT WINAPI D3DXLoadVolumeFromMemory(IDirect3DVolume9 *dst_volume, if (((src_format_desc->type != FORMAT_ARGB) && (src_format_desc->type != FORMAT_INDEX)) || (dst_format_desc->type != FORMAT_ARGB)) { - FIXME("Pixel format conversion not implemented %#x -> %#x\n", + FIXME("Pixel format conversion is not implemented %#x -> %#x\n", src_format_desc->format, dst_format_desc->format); return E_NOTIMPL; } diff --git a/dlls/d3dx9_36/xfile.c b/dlls/d3dx9_36/xfile.c index 7386ec9..eda0d7e 100644 --- a/dlls/d3dx9_36/xfile.c +++ b/dlls/d3dx9_36/xfile.c @@ -331,7 +331,7 @@ static HRESULT d3dx9_file_data_create(IDirectXFileObject *dxfile_object, ID3DXFi } else { - FIXME("Don't known what to do with binary object\n"); + FIXME("Don't know what to do with binary object\n"); HeapFree(GetProcessHeap(), 0, object); return E_FAIL; }

1 0

Andrew Cook : kernel32/tests: Add tests for JOB_OBJECT_LIMIT_KILL_ON_JOB_CLOSE.
by Alexandre Julliard March 30, 2015

March 30, 2015

Module: wine Branch: master Commit: 3ca0282e5f189ffab0beafdb669b1f5088073a2b URL: http://source.winehq.org/git/wine.git/?a=commit;h=3ca0282e5f189ffab0beafdb6… Author: Andrew Cook <ariscop(a)gmail.com> Date: Sat Mar 28 13:24:30 2015 +1100 kernel32/tests: Add tests for JOB_OBJECT_LIMIT_KILL_ON_JOB_CLOSE. Cleanup and improvements by Sebastian Lackner. --- dlls/kernel32/tests/process.c | 37 +++++++++++++++++++++++++++++++++++++ 1 file changed, 37 insertions(+) diff --git a/dlls/kernel32/tests/process.c b/dlls/kernel32/tests/process.c index 7620410..27961f4 100644 --- a/dlls/kernel32/tests/process.c +++ b/dlls/kernel32/tests/process.c @@ -2375,6 +2375,42 @@ static void test_CompletionPort(void) CloseHandle(port); } +static void test_KillOnJobClose(void) +{ + JOBOBJECT_EXTENDED_LIMIT_INFORMATION limit_info; + PROCESS_INFORMATION pi; + DWORD dwret; + HANDLE job; + BOOL ret; + + job = pCreateJobObjectW(NULL, NULL); + ok(job != NULL, "CreateJobObject error %u\n", GetLastError()); + + limit_info.BasicLimitInformation.LimitFlags = JOB_OBJECT_LIMIT_KILL_ON_JOB_CLOSE; + ret = pSetInformationJobObject(job, JobObjectExtendedLimitInformation, &limit_info, sizeof(limit_info)); + if (!ret && GetLastError() == ERROR_INVALID_PARAMETER) + { + win_skip("Kill on job close limit not available\n"); + return; + } + ok(ret, "SetInformationJobObject error %u\n", GetLastError()); + + create_process("wait", &pi); + + ret = pAssignProcessToJobObject(job, pi.hProcess); + ok(ret, "AssignProcessToJobObject error %u\n", GetLastError()); + + CloseHandle(job); + + dwret = WaitForSingleObject(pi.hProcess, 1000); + todo_wine + ok(dwret == WAIT_OBJECT_0, "WaitForSingleObject returned %u\n", dwret); + if (dwret == WAIT_TIMEOUT) TerminateProcess(pi.hProcess, 0); + + CloseHandle(pi.hProcess); + CloseHandle(pi.hThread); +} + START_TEST(process) { BOOL b = init(); @@ -2438,4 +2474,5 @@ START_TEST(process) test_TerminateJobObject(); test_QueryInformationJobObject(); test_CompletionPort(); + test_KillOnJobClose(); }

1 0

Piotr Caban : ntdll: Improve parameter validation in RtlAddAce.
by Alexandre Julliard March 30, 2015

March 30, 2015

Module: wine Branch: master Commit: 966c5dffed3e8f089a0648e2e94d300620869bbc URL: http://source.winehq.org/git/wine.git/?a=commit;h=966c5dffed3e8f089a0648e2e… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Sat Mar 28 15:26:37 2015 +0100 ntdll: Improve parameter validation in RtlAddAce. --- dlls/advapi32/tests/security.c | 46 ++++++++++++++++++++++++++++++++++++++++++ dlls/ntdll/sec.c | 4 +++- 2 files changed, 49 insertions(+), 1 deletion(-) diff --git a/dlls/advapi32/tests/security.c b/dlls/advapi32/tests/security.c index 15c3b1d..0e9cf8c 100644 --- a/dlls/advapi32/tests/security.c +++ b/dlls/advapi32/tests/security.c @@ -5568,6 +5568,51 @@ static void test_AdjustTokenPrivileges(void) CloseHandle(token); } +static void test_AddAce(void) +{ + static SID const sidWorld = { SID_REVISION, 1, { SECURITY_WORLD_SID_AUTHORITY} , { SECURITY_WORLD_RID } }; + + char acl_buf[1024], ace_buf[256]; + ACCESS_ALLOWED_ACE *ace = (ACCESS_ALLOWED_ACE*)ace_buf; + PACL acl = (PACL)acl_buf; + BOOL ret; + + memset(ace, 0, sizeof(ace_buf)); + ace->Header.AceType = ACCESS_ALLOWED_ACE_TYPE; + ace->Header.AceSize = sizeof(ACCESS_ALLOWED_ACE)-sizeof(DWORD)+sizeof(SID); + memcpy(&ace->SidStart, &sidWorld, sizeof(sidWorld)); + + ret = InitializeAcl(acl, sizeof(acl_buf), ACL_REVISION2); + ok(ret, "InitializeAcl failed: %d\n", GetLastError()); + + ret = AddAce(acl, ACL_REVISION1, MAXDWORD, ace, ace->Header.AceSize); + ok(ret, "AddAce failed: %d\n", GetLastError()); + ret = AddAce(acl, ACL_REVISION2, MAXDWORD, ace, ace->Header.AceSize); + ok(ret, "AddAce failed: %d\n", GetLastError()); + ret = AddAce(acl, ACL_REVISION3, MAXDWORD, ace, ace->Header.AceSize); + ok(ret, "AddAce failed: %d\n", GetLastError()); + ok(acl->AclRevision == ACL_REVISION3, "acl->AclRevision = %d\n", acl->AclRevision); + ret = AddAce(acl, ACL_REVISION4, MAXDWORD, ace, ace->Header.AceSize); + ok(ret, "AddAce failed: %d\n", GetLastError()); + ok(acl->AclRevision == ACL_REVISION4, "acl->AclRevision = %d\n", acl->AclRevision); + ret = AddAce(acl, ACL_REVISION1, MAXDWORD, ace, ace->Header.AceSize); + ok(ret, "AddAce failed: %d\n", GetLastError()); + ok(acl->AclRevision == ACL_REVISION4, "acl->AclRevision = %d\n", acl->AclRevision); + ret = AddAce(acl, ACL_REVISION2, MAXDWORD, ace, ace->Header.AceSize); + ok(ret, "AddAce failed: %d\n", GetLastError()); + + ret = AddAce(acl, MIN_ACL_REVISION-1, MAXDWORD, ace, ace->Header.AceSize); + ok(ret, "AddAce failed: %d\n", GetLastError()); + /* next test succeededs but corrupts ACL */ + ret = AddAce(acl, MAX_ACL_REVISION+1, MAXDWORD, ace, ace->Header.AceSize); + ok(ret, "AddAce failed: %d\n", GetLastError()); + ok(acl->AclRevision == MAX_ACL_REVISION+1, "acl->AclRevision = %d\n", acl->AclRevision); + SetLastError(0xdeadbeef); + ret = AddAce(acl, ACL_REVISION1, MAXDWORD, ace, ace->Header.AceSize); + ok(!ret, "AddAce succeeded\n"); + ok(GetLastError() == ERROR_INVALID_PARAMETER, "GetLastError() = %d\n", GetLastError()); +} + START_TEST(security) { init(); @@ -5609,4 +5654,5 @@ START_TEST(security) test_TokenIntegrityLevel(); test_default_dacl_owner_sid(); test_AdjustTokenPrivileges(); + test_AddAce(); } diff --git a/dlls/ntdll/sec.c b/dlls/ntdll/sec.c index b733f77..0917780 100644 --- a/dlls/ntdll/sec.c +++ b/dlls/ntdll/sec.c @@ -1167,7 +1167,7 @@ NTSTATUS WINAPI RtlAddAce( PACE_HEADER ace,targetace; int nrofaces; - if (acl->AclRevision != ACL_REVISION) + if (!RtlValidAcl(acl)) return STATUS_INVALID_PARAMETER; if (!RtlFirstFreeAce(acl,&targetace)) return STATUS_INVALID_PARAMETER; @@ -1180,6 +1180,8 @@ NTSTATUS WINAPI RtlAddAce( return STATUS_INVALID_PARAMETER; memcpy(targetace,acestart,acelen); acl->AceCount+=nrofaces; + if (rev > acl->AclRevision) + acl->AclRevision = rev; return STATUS_SUCCESS; }

1 0

Hugh McMaster : attrib: Fix incorrect comment.
by Alexandre Julliard March 30, 2015

March 30, 2015

Module: wine Branch: master Commit: d4fb6257f5d88adb69f1bacd3f7d810a1d416eb3 URL: http://source.winehq.org/git/wine.git/?a=commit;h=d4fb6257f5d88adb69f1bacd3… Author: Hugh McMaster <hugh.mcmaster(a)outlook.com> Date: Mon Mar 30 22:58:17 2015 +1100 attrib: Fix incorrect comment. --- programs/attrib/attrib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/programs/attrib/attrib.c b/programs/attrib/attrib.c index 7e3b01e..0938cb8 100644 --- a/programs/attrib/attrib.c +++ b/programs/attrib/attrib.c @@ -64,7 +64,7 @@ static int __cdecl ATTRIB_wprintf(const WCHAR *format, ...) /* * Allocate buffer to use when writing to console * Note: Not freed - memory will be allocated once and released when - * xcopy ends + * attrib ends */ if (!output_bufW) output_bufW = HeapAlloc(GetProcessHeap(), 0,

1 0

Vincent Povirk : windowscodecs: Implement PngDecoder_Block_GetCount.
by Alexandre Julliard March 30, 2015

March 30, 2015

Module: wine Branch: master Commit: 43c97b871f2e60983ed07025428effed62ec795d URL: http://source.winehq.org/git/wine.git/?a=commit;h=43c97b871f2e60983ed070254… Author: Vincent Povirk <vincent(a)codeweavers.com> Date: Wed Mar 25 14:26:28 2015 -0500 windowscodecs: Implement PngDecoder_Block_GetCount. --- dlls/windowscodecs/pngformat.c | 80 +++++++++++++++++++++++++++++++++++-- dlls/windowscodecs/tests/metadata.c | 6 +-- 2 files changed, 79 insertions(+), 7 deletions(-) diff --git a/dlls/windowscodecs/pngformat.c b/dlls/windowscodecs/pngformat.c index 260330f..53a2122 100644 --- a/dlls/windowscodecs/pngformat.c +++ b/dlls/windowscodecs/pngformat.c @@ -292,6 +292,11 @@ static void user_warning_fn(png_structp png_ptr, png_const_charp warning_message } typedef struct { + ULARGE_INTEGER ofs, len; + IWICMetadataReader* reader; +} metadata_block_info; + +typedef struct { IWICBitmapDecoder IWICBitmapDecoder_iface; IWICBitmapFrameDecode IWICBitmapFrameDecode_iface; IWICMetadataBlockReader IWICMetadataBlockReader_iface; @@ -307,6 +312,8 @@ typedef struct { const WICPixelFormatGUID *format; BYTE *image_bits; CRITICAL_SECTION lock; /* must be held when png structures are accessed or initialized is set */ + ULONG metadata_count; + metadata_block_info* metadata_blocks; } PngDecoder; static inline PngDecoder *impl_from_IWICBitmapDecoder(IWICBitmapDecoder *iface) @@ -362,6 +369,7 @@ static ULONG WINAPI PngDecoder_Release(IWICBitmapDecoder *iface) { PngDecoder *This = impl_from_IWICBitmapDecoder(iface); ULONG ref = InterlockedDecrement(&This->ref); + ULONG i; TRACE("(%p) refcount=%u\n", iface, ref); @@ -373,6 +381,12 @@ static ULONG WINAPI PngDecoder_Release(IWICBitmapDecoder *iface) This->lock.DebugInfo->Spare[0] = 0; DeleteCriticalSection(&This->lock); HeapFree(GetProcessHeap(), 0, This->image_bits); + for (i=0; i<This->metadata_count; i++) + { + if (This->metadata_blocks[i].reader) + IWICMetadataReader_Release(This->metadata_blocks[i].reader); + } + HeapFree(GetProcessHeap(), 0, This->metadata_blocks); HeapFree(GetProcessHeap(), 0, This); } @@ -425,6 +439,10 @@ static HRESULT WINAPI PngDecoder_Initialize(IWICBitmapDecoder *iface, IStream *p png_uint_32 transparency; png_color_16p trans_values; jmp_buf jmpbuf; + BYTE chunk_type[4]; + ULONG chunk_size; + ULARGE_INTEGER chunk_start; + ULONG metadata_blocks_size = 0; TRACE("(%p,%p,%x)\n", iface, pIStream, cacheOptions); @@ -607,13 +625,60 @@ static HRESULT WINAPI PngDecoder_Initialize(IWICBitmapDecoder *iface, IStream *p ppng_read_end(This->png_ptr, This->end_info); + /* Find the metadata chunks in the file. */ + seek.QuadPart = 8; + hr = IStream_Seek(pIStream, seek, STREAM_SEEK_SET, &chunk_start); + if (FAILED(hr)) goto end; + + do + { + hr = read_png_chunk(pIStream, chunk_type, NULL, &chunk_size); + if (FAILED(hr)) goto end; + + if (chunk_type[0] >= 'a' && chunk_type[0] <= 'z' && + memcmp(chunk_type, "tRNS", 4) && memcmp(chunk_type, "pHYs", 4)) + { + /* This chunk is considered metadata. */ + if (This->metadata_count == metadata_blocks_size) + { + metadata_block_info* new_metadata_blocks; + ULONG new_metadata_blocks_size; + + new_metadata_blocks_size = 4 + metadata_blocks_size * 2; + new_metadata_blocks = HeapAlloc(GetProcessHeap(), 0, + new_metadata_blocks_size * sizeof(*new_metadata_blocks)); + + if (!new_metadata_blocks) + { + hr = E_OUTOFMEMORY; + goto end; + } + + memcpy(new_metadata_blocks, This->metadata_blocks, + This->metadata_count * sizeof(*new_metadata_blocks)); + + HeapFree(GetProcessHeap(), 0, This->metadata_blocks); + This->metadata_blocks = new_metadata_blocks; + metadata_blocks_size = new_metadata_blocks_size; + } + + This->metadata_blocks[This->metadata_count].ofs = chunk_start; + This->metadata_blocks[This->metadata_count].len.QuadPart = chunk_size + 12; + This->metadata_blocks[This->metadata_count].reader = NULL; + This->metadata_count++; + } + + seek.QuadPart = chunk_start.QuadPart + chunk_size + 12; /* skip data and CRC */ + hr = IStream_Seek(pIStream, seek, STREAM_SEEK_SET, &chunk_start); + if (FAILED(hr)) goto end; + } while (memcmp(chunk_type, "IEND", 4)); + This->stream = pIStream; IStream_AddRef(This->stream); This->initialized = TRUE; end: - LeaveCriticalSection(&This->lock); return hr; @@ -983,10 +1048,15 @@ static HRESULT WINAPI PngDecoder_Block_GetContainerFormat(IWICMetadataBlockReade static HRESULT WINAPI PngDecoder_Block_GetCount(IWICMetadataBlockReader *iface, UINT *pcCount) { - static int once; + PngDecoder *This = impl_from_IWICMetadataBlockReader(iface); + TRACE("%p,%p\n", iface, pcCount); - if (!once++) FIXME("stub\n"); - return E_NOTIMPL; + + if (!pcCount) return E_INVALIDARG; + + *pcCount = This->metadata_count; + + return S_OK; } static HRESULT WINAPI PngDecoder_Block_GetReaderByIndex(IWICMetadataBlockReader *iface, @@ -1042,6 +1112,8 @@ HRESULT PngDecoder_CreateInstance(REFIID iid, void** ppv) This->image_bits = NULL; InitializeCriticalSection(&This->lock); This->lock.DebugInfo->Spare[0] = (DWORD_PTR)(__FILE__ ": PngDecoder.lock"); + This->metadata_count = 0; + This->metadata_blocks = NULL; ret = IWICBitmapDecoder_QueryInterface(&This->IWICBitmapDecoder_iface, iid, ppv); IWICBitmapDecoder_Release(&This->IWICBitmapDecoder_iface); diff --git a/dlls/windowscodecs/tests/metadata.c b/dlls/windowscodecs/tests/metadata.c index 20fe54c..1a7587f 100644 --- a/dlls/windowscodecs/tests/metadata.c +++ b/dlls/windowscodecs/tests/metadata.c @@ -946,11 +946,11 @@ static void test_metadata_png(void) ok(IsEqualGUID(&containerformat, &GUID_ContainerFormatPng), "unexpected container format\n"); hr = IWICMetadataBlockReader_GetCount(blockreader, NULL); - todo_wine ok(hr == E_INVALIDARG, "GetCount failed, hr=%x\n", hr); + ok(hr == E_INVALIDARG, "GetCount failed, hr=%x\n", hr); hr = IWICMetadataBlockReader_GetCount(blockreader, &count); - todo_wine ok(hr == S_OK, "GetCount failed, hr=%x\n", hr); - todo_wine ok(count == 1, "unexpected count %d\n", count); + ok(hr == S_OK, "GetCount failed, hr=%x\n", hr); + ok(count == 1, "unexpected count %d\n", count); if (0) {

1 0

Jacek Caban : wmsdkidl.idl: Added IWMReaderAdvanced* declarations.
by Alexandre Julliard March 30, 2015

March 30, 2015

Module: wine Branch: master Commit: 292d7bdf0f1438ad91bb72bf7edc6e70338c03c1 URL: http://source.winehq.org/git/wine.git/?a=commit;h=292d7bdf0f1438ad91bb72bf7… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Fri Mar 27 17:57:37 2015 +0100 wmsdkidl.idl: Added IWMReaderAdvanced* declarations. --- include/wmsdkidl.idl | 293 +++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 293 insertions(+) diff --git a/include/wmsdkidl.idl b/include/wmsdkidl.idl index 1618f86..dc584fc 100644 --- a/include/wmsdkidl.idl +++ b/include/wmsdkidl.idl @@ -60,6 +60,29 @@ typedef struct _WMWriterStatisticsEx DWORD dwTotalSampleDropsInMultiplexer; } WM_WRITER_STATISTICS_EX; +typedef struct _WMReaderStatistics +{ + DWORD cbSize; + DWORD dwBandwidth; + DWORD cPacketsReceived; + DWORD cPacketsRecovered; + DWORD cPacketsLost; + WORD wQuality; +} WM_READER_STATISTICS; + +typedef struct _WMReaderClientInfo +{ + DWORD cbSize; + WCHAR *wszLang; + WCHAR *wszBrowserUserAgent; + WCHAR *wszBrowserWebPage; + QWORD qwReserved; + LPARAM *pReserved; + WCHAR *wszHostExe; + QWORD qwHostVersion; + WCHAR *wszPlayerUserAgent; +} WM_READER_CLIENTINFO; + typedef enum WMT_ATTR_DATATYPE { WMT_TYPE_DWORD = 0, @@ -143,6 +166,23 @@ typedef enum WMT_VERSION WMT_VER_9_0 = 0x00090000 } WMT_VERSION; +typedef enum WMT_PLAY_MODE +{ + WMT_PLAY_MODE_AUTOSELECT, + WMT_PLAY_MODE_LOCAL, + WMT_PLAY_MODE_DOWNLOAD, + WMT_PLAY_MODE_STREAMING +} WMT_PLAY_MODE; + +typedef enum tagWMT_OFFSET_FORMAT +{ + WMT_OFFSET_FORMAT_100NS, + WMT_OFFSET_FORMAT_FRAME_NUMBERS, + WMT_OFFSET_FORMAT_PLAYLIST_OFFSET, + WMT_OFFSET_FORMAT_TIMECODE, + WMT_OFFSET_FORMAT_100NS_APPROXIMATE +} WMT_OFFSET_FORMAT; + typedef LPCWSTR LPCWSTR_WMSDK_TYPE_SAFE; [ @@ -441,6 +481,259 @@ interface IWMReader : IUnknown [ object, + uuid(e5b7ca9a-0f1c-4f66-9002-74ec50d8b304), + pointer_default(unique), + local +] +interface IWMPlayerHook : IUnknown +{ + HRESULT PreDecode(); +} + +[ + object, + uuid(96406bea-2b2b-11d3-b36b-00c04f6108ff), + pointer_default(unique), + local +] +interface IWMReaderAdvanced : IUnknown +{ + HRESULT SetUserProvidedClock( + [in] BOOL fUserClock); + + HRESULT GetUserProvidedClock( + [out] BOOL *pfUserClock); + + HRESULT DeliverTime( + [in] QWORD cnsTime); + + HRESULT SetManualStreamSelection( + [in] BOOL fSelection); + + HRESULT GetManualStreamSelection( + [out] BOOL *pfSelection); + + HRESULT SetStreamsSelected( + [in] WORD cStreamCount, + [in] WORD *pwStreamNumbers, + [in] WMT_STREAM_SELECTION *pSelections); + + HRESULT GetStreamSelected( + [in] WORD wStreamNum, + [out] WMT_STREAM_SELECTION *pSelection); + + HRESULT SetReceiveSelectionCallbacks( + [in] BOOL fGetCallbacks); + + HRESULT GetReceiveSelectionCallbacks( + [out] BOOL *pfGetCallbacks); + + HRESULT SetReceiveStreamSamples( + [in] WORD wStreamNum, + [in] BOOL fReceiveStreamSamples); + + HRESULT GetReceiveStreamSamples( + [in] WORD wStreamNum, + [out] BOOL *pfReceiveStreamSamples); + + HRESULT SetAllocateForOutput( + [in] DWORD dwOutputNum, + [in] BOOL fAllocate); + + HRESULT GetAllocateForOutput( + [in] DWORD dwOutputNum, + [out] BOOL *pfAllocate); + + HRESULT SetAllocateForStream( + [in] WORD wStreamNum, + [in] BOOL fAllocate); + + HRESULT GetAllocateForStream( + [in] WORD dwSreamNum, + [out] BOOL *pfAllocate); + + HRESULT GetStatistics( + [in, out] WM_READER_STATISTICS *pStatistics); + + HRESULT SetClientInfo( + [in] WM_READER_CLIENTINFO *pClientInfo); + + HRESULT GetMaxOutputSampleSize( + [in] DWORD dwOutput, + [out] DWORD *pcbMax); + + HRESULT GetMaxStreamSampleSize( + [in] WORD wStream, + [out] DWORD *pcbMax); + + HRESULT NotifyLateDelivery( + QWORD cnsLateness); +} + +[ + object, + uuid(ae14a945-b90c-4d0d-9127-80d665f7d73e), + pointer_default(unique), + local +] +interface IWMReaderAdvanced2 : IWMReaderAdvanced +{ + HRESULT SetPlayMode( + [in] WMT_PLAY_MODE Mode); + + HRESULT GetPlayMode( + [out] WMT_PLAY_MODE *pMode); + + HRESULT GetBufferProgress( + [out] DWORD *pdwPercent, + [out] QWORD *pcnsBuffering); + + HRESULT GetDownloadProgress( + [out] DWORD *pdwPercent, + [out] QWORD *pqwBytesDownloaded, + [out] QWORD *pcnsDownload); + + HRESULT GetSaveAsProgress( + [out] DWORD *pdwPercent); + + HRESULT SaveFileAs( + [in] const WCHAR *pwszFilename); + + HRESULT GetProtocolName( + [out, size_is(*pcchProtocol)] WCHAR *pwszProtocol, + [in, out] DWORD *pcchProtocol); + + HRESULT StartAtMarker( + [in] WORD wMarkerIndex, + [in] QWORD cnsDuration, + [in] float fRate, + [in] void *pvContext); + + HRESULT GetOutputSetting( + [in] DWORD dwOutputNum, + [in] LPCWSTR pszName, + [out] WMT_ATTR_DATATYPE *pType, + [out, size_is(*pcbLength)] BYTE *pValue, + [in, out] WORD *pcbLength); + + HRESULT SetOutputSetting( + [in] DWORD dwOutputNum, + [in] LPCWSTR pszName, + [in] WMT_ATTR_DATATYPE Type, + [in, size_is(cbLength)] const BYTE *pValue, + [in] WORD cbLength); + + HRESULT Preroll( + [in] QWORD cnsStart, + [in] QWORD cnsDuration, + [in] float fRate); + + HRESULT SetLogClientID( + [in] BOOL fLogClientID); + + HRESULT GetLogClientID( + [out] BOOL *pfLogClientID); + + HRESULT StopBuffering(); + + HRESULT OpenStream( + [in] IStream *pStream, + [in] IWMReaderCallback *pCallback, + [in] void *pvContext); +} + +[ + object, + uuid(5dc0674b-f04B-4a4e-9f2a-b1afde2c8100), + pointer_default(unique), + local +] +interface IWMReaderAdvanced3 : IWMReaderAdvanced2 +{ + HRESULT StopNetStreaming(); + + HRESULT StartAtPosition( + [in] WORD wStreamNum, + [in] void *pvOffsetStart, + [in] void *pvDuration, + [in] WMT_OFFSET_FORMAT dwOffsetFormat, + [in] float fRate, + [in] void *pvContext); +} + +[ + object, + uuid(945a76a2-12ae-4d48-bd3c-cd1d90399b85), + pointer_default(unique), + local +] +interface IWMReaderAdvanced4 : IWMReaderAdvanced3 +{ + HRESULT GetLanguageCount( + [in] DWORD dwOutputNum, + [out] WORD *pwLanguageCount); + + HRESULT GetLanguage( + [in] DWORD dwOutputNum, + [in] WORD wLanguage, + [out, size_is(*pcchLanguageStringLength)] WCHAR *pwszLanguageString, + [in, out] WORD *pcchLanguageStringLength); + + HRESULT GetMaxSpeedFactor( + [out] double *pdblFactor); + + HRESULT IsUsingFastCache( + [out] BOOL *pfUsingFastCache); + + HRESULT AddLogParam( + [in] LPCWSTR wszNameSpace, + [in] LPCWSTR wszName, + [in] LPCWSTR wszValue); + + HRESULT SendLogParams(); + + HRESULT CanSaveFileAs( + [out] BOOL *pfCanSave); + + HRESULT CancelSaveFileAs(); + + HRESULT GetURL( + [out, size_is(*pcchURL)] WCHAR *pwszURL, + [in, out] DWORD *pcchURL); +} + +[ + object, + uuid(24c44db0-55d1-49ae-a5cc-f13815e36363), + pointer_default(unique), + local +] +interface IWMReaderAdvanced5 : IWMReaderAdvanced4 +{ + HRESULT SetPlayerHook( + [in] DWORD dwOutputNum, + [in] IWMPlayerHook *pHook); +} + +[ + object, + uuid(18a2e7f8-428f-4acd-8a00-e64639bc93de), + pointer_default(unique), + local +] +interface IWMReaderAdvanced6 : IWMReaderAdvanced5 +{ + HRESULT SetProtectStreamSamples( + [in, size_is(cbCertificate)] BYTE *pbCertificate, + [in] DWORD cbCertificate, + [in] DWORD dwCertificateType, + [in] DWORD dwFlags, + [out, size_is(*pcbInitializationVector)] BYTE *pbInitializationVector, + [in, out] DWORD *pcbInitializationVector); +} + +[ + object, uuid(9397f121-7705-4dc9-b049-98b698188414), pointer_default( unique ), local

1 0

Sebastian Lackner : kernel32/tests: Add tests for adding a terminated process to a job object.
by Alexandre Julliard March 30, 2015

March 30, 2015

Module: wine Branch: master Commit: ddd3d1689cc44fe925d26671b706bbe937260236 URL: http://source.winehq.org/git/wine.git/?a=commit;h=ddd3d1689cc44fe925d26671b… Author: Sebastian Lackner <sebastian(a)fds-team.de> Date: Sat Feb 28 06:34:24 2015 +0100 kernel32/tests: Add tests for adding a terminated process to a job object. --- dlls/kernel32/tests/process.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/dlls/kernel32/tests/process.c b/dlls/kernel32/tests/process.c index b8413f6..fd3ce7f 100644 --- a/dlls/kernel32/tests/process.c +++ b/dlls/kernel32/tests/process.c @@ -2245,6 +2245,23 @@ static void test_TerminateJobObject(void) CloseHandle(pi.hProcess); CloseHandle(pi.hThread); + + /* Test adding an already terminated process to a job object */ + create_process("exit", &pi); + + dwret = WaitForSingleObject(pi.hProcess, 1000); + ok(dwret == WAIT_OBJECT_0, "WaitForSingleObject returned %u\n", dwret); + + SetLastError(0xdeadbeef); + ret = pAssignProcessToJobObject(job, pi.hProcess); + todo_wine + ok(!ret, "AssignProcessToJobObject unexpectedly succeeded\n"); + todo_wine + expect_eq_d(ERROR_ACCESS_DENIED, GetLastError()); + + CloseHandle(pi.hProcess); + CloseHandle(pi.hThread); + CloseHandle(job); }

1 0

Andrew Cook : kernel32/tests: Add tests for JOB_OBJECT_LIMIT_BREAKAWAY_OK.
by Alexandre Julliard March 30, 2015

March 30, 2015

Module: wine Branch: master Commit: f0ef853d9df5d03a9cc3913436f1f87691006022 URL: http://source.winehq.org/git/wine.git/?a=commit;h=f0ef853d9df5d03a9cc391343… Author: Andrew Cook <ariscop(a)gmail.com> Date: Sat Mar 28 13:24:48 2015 +1100 kernel32/tests: Add tests for JOB_OBJECT_LIMIT_BREAKAWAY_OK. Cleanup and improvements by Sebastian Lackner. --- dlls/kernel32/tests/process.c | 92 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 92 insertions(+) diff --git a/dlls/kernel32/tests/process.c b/dlls/kernel32/tests/process.c index 27961f4..3395f0f 100644 --- a/dlls/kernel32/tests/process.c +++ b/dlls/kernel32/tests/process.c @@ -2411,8 +2411,97 @@ static void test_KillOnJobClose(void) CloseHandle(pi.hThread); } +static HANDLE test_AddSelfToJob(void) +{ + HANDLE job; + BOOL ret; + + job = pCreateJobObjectW(NULL, NULL); + ok(job != NULL, "CreateJobObject error %u\n", GetLastError()); + + ret = pAssignProcessToJobObject(job, GetCurrentProcess()); + ok(ret, "AssignProcessToJobObject error %u\n", GetLastError()); + + return job; +} + +static void test_BreakawayOk(HANDLE job) +{ + JOBOBJECT_EXTENDED_LIMIT_INFORMATION limit_info; + PROCESS_INFORMATION pi; + STARTUPINFOA si = {0}; + char buffer[MAX_PATH]; + BOOL ret, out; + DWORD dwret; + + if (!pIsProcessInJob) + { + win_skip("IsProcessInJob not available.\n"); + return; + } + + snprintf(buffer, MAX_PATH, "\"%s\" tests/process.c %s", selfname, "exit"); + + ret = CreateProcessA(NULL, buffer, NULL, NULL, FALSE, CREATE_BREAKAWAY_FROM_JOB, NULL, NULL, &si, &pi); + todo_wine + ok(!ret, "CreateProcessA expected failure\n"); + todo_wine + expect_eq_d(ERROR_ACCESS_DENIED, GetLastError()); + + if (ret) + { + TerminateProcess(pi.hProcess, 0); + + dwret = WaitForSingleObject(pi.hProcess, 1000); + ok(dwret == WAIT_OBJECT_0, "WaitForSingleObject returned %u\n", dwret); + + CloseHandle(pi.hProcess); + CloseHandle(pi.hThread); + } + + limit_info.BasicLimitInformation.LimitFlags = JOB_OBJECT_LIMIT_BREAKAWAY_OK; + ret = pSetInformationJobObject(job, JobObjectExtendedLimitInformation, &limit_info, sizeof(limit_info)); + ok(ret, "SetInformationJobObject error %u\n", GetLastError()); + + ret = CreateProcessA(NULL, buffer, NULL, NULL, FALSE, CREATE_BREAKAWAY_FROM_JOB, NULL, NULL, &si, &pi); + ok(ret, "CreateProcessA error %u\n", GetLastError()); + + ret = pIsProcessInJob(pi.hProcess, job, &out); + ok(ret, "IsProcessInJob error %u\n", GetLastError()); + ok(!out, "IsProcessInJob returned out=%u\n", out); + + dwret = WaitForSingleObject(pi.hProcess, 1000); + ok(dwret == WAIT_OBJECT_0, "WaitForSingleObject returned %u\n", dwret); + + CloseHandle(pi.hProcess); + CloseHandle(pi.hThread); + + limit_info.BasicLimitInformation.LimitFlags = JOB_OBJECT_LIMIT_SILENT_BREAKAWAY_OK; + ret = pSetInformationJobObject(job, JobObjectExtendedLimitInformation, &limit_info, sizeof(limit_info)); + ok(ret, "SetInformationJobObject error %u\n", GetLastError()); + + ret = CreateProcessA(NULL, buffer, NULL, NULL, FALSE, 0, NULL, NULL, &si, &pi); + ok(ret, "CreateProcess error %u\n", GetLastError()); + + ret = pIsProcessInJob(pi.hProcess, job, &out); + ok(ret, "IsProcessInJob error %u\n", GetLastError()); + ok(!out, "IsProcessInJob returned out=%u\n", out); + + dwret = WaitForSingleObject(pi.hProcess, 1000); + ok(dwret == WAIT_OBJECT_0, "WaitForSingleObject returned %u\n", dwret); + + CloseHandle(pi.hProcess); + CloseHandle(pi.hThread); + + /* unset breakaway ok */ + limit_info.BasicLimitInformation.LimitFlags = 0; + ret = pSetInformationJobObject(job, JobObjectExtendedLimitInformation, &limit_info, sizeof(limit_info)); + ok(ret, "SetInformationJobObject error %u\n", GetLastError()); +} + START_TEST(process) { + HANDLE job; BOOL b = init(); ok(b, "Basic init of CreateProcess test\n"); if (!b) return; @@ -2475,4 +2564,7 @@ START_TEST(process) test_QueryInformationJobObject(); test_CompletionPort(); test_KillOnJobClose(); + job = test_AddSelfToJob(); + test_BreakawayOk(job); + CloseHandle(job); }

1 0

Andrew Cook : kernel32/tests: Add tests for job object completion ports.
by Alexandre Julliard March 30, 2015

March 30, 2015

Module: wine Branch: master Commit: 6c2b0eb011488dc0b56fc4e264069e80966c625b URL: http://source.winehq.org/git/wine.git/?a=commit;h=6c2b0eb011488dc0b56fc4e26… Author: Andrew Cook <ariscop(a)gmail.com> Date: Sat Mar 28 13:24:12 2015 +1100 kernel32/tests: Add tests for job object completion ports. Cleanup and improvements by Sebastian Lackner. --- dlls/kernel32/tests/process.c | 66 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 66 insertions(+) diff --git a/dlls/kernel32/tests/process.c b/dlls/kernel32/tests/process.c index c420576..7620410 100644 --- a/dlls/kernel32/tests/process.c +++ b/dlls/kernel32/tests/process.c @@ -71,6 +71,8 @@ static BOOL (WINAPI *pAssignProcessToJobObject)(HANDLE job, HANDLE process); static BOOL (WINAPI *pIsProcessInJob)(HANDLE process, HANDLE job, PBOOL result); static BOOL (WINAPI *pTerminateJobObject)(HANDLE job, UINT exit_code); static BOOL (WINAPI *pQueryInformationJobObject)(HANDLE job, JOBOBJECTINFOCLASS class, LPVOID info, DWORD len, LPDWORD ret_len); +static BOOL (WINAPI *pSetInformationJobObject)(HANDLE job, JOBOBJECTINFOCLASS class, LPVOID info, DWORD len); +static HANDLE (WINAPI *pCreateIoCompletionPort)(HANDLE file, HANDLE existing_port, ULONG_PTR key, DWORD threads); /* ############################### */ static char base[MAX_PATH]; @@ -219,6 +221,8 @@ static BOOL init(void) pIsProcessInJob = (void *)GetProcAddress(hkernel32, "IsProcessInJob"); pTerminateJobObject = (void *)GetProcAddress(hkernel32, "TerminateJobObject"); pQueryInformationJobObject = (void *)GetProcAddress(hkernel32, "QueryInformationJobObject"); + pSetInformationJobObject = (void *)GetProcAddress(hkernel32, "SetInformationJobObject"); + pCreateIoCompletionPort = (void *)GetProcAddress(hkernel32, "CreateIoCompletionPort"); return TRUE; } @@ -2129,6 +2133,25 @@ static void test_DuplicateHandle(void) CloseHandle(out); } +#define test_completion(a, b, c, d, e) _test_completion(__LINE__, a, b, c, d, e) +static void _test_completion(int line, HANDLE port, DWORD ekey, ULONG_PTR evalue, ULONG_PTR eoverlapped, DWORD wait) +{ + LPOVERLAPPED overlapped; + ULONG_PTR value; + DWORD key; + BOOL ret; + + ret = GetQueuedCompletionStatus(port, &key, &value, &overlapped, wait); + + ok_(__FILE__, line)(ret, "GetQueuedCompletionStatus: %x\n", GetLastError()); + if (ret) + { + ok_(__FILE__, line)(key == ekey, "unexpected key %x\n", key); + ok_(__FILE__, line)(value == evalue, "unexpected value %p\n", (void *)value); + ok_(__FILE__, line)(overlapped == (LPOVERLAPPED)eoverlapped, "unexpected overlapped %p\n", overlapped); + } +} + #define create_process(cmd, pi) _create_process(__LINE__, cmd, pi) static void _create_process(int line, const char *command, LPPROCESS_INFORMATION pi) { @@ -2310,6 +2333,48 @@ static void test_QueryInformationJobObject(void) CloseHandle(job); } +static void test_CompletionPort(void) +{ + JOBOBJECT_ASSOCIATE_COMPLETION_PORT port_info; + PROCESS_INFORMATION pi; + HANDLE job, port; + DWORD dwret; + BOOL ret; + + job = pCreateJobObjectW(NULL, NULL); + ok(job != NULL, "CreateJobObject error %u\n", GetLastError()); + + port = pCreateIoCompletionPort(INVALID_HANDLE_VALUE, NULL, 0, 1); + ok(port != NULL, "CreateIoCompletionPort error %u\n", GetLastError()); + + port_info.CompletionKey = job; + port_info.CompletionPort = port; + ret = pSetInformationJobObject(job, JobObjectAssociateCompletionPortInformation, &port_info, sizeof(port_info)); + ok(ret, "SetInformationJobObject error %u\n", GetLastError()); + + create_process("wait", &pi); + + ret = pAssignProcessToJobObject(job, pi.hProcess); + ok(ret, "AssignProcessToJobObject error %u\n", GetLastError()); + + todo_wine + test_completion(port, JOB_OBJECT_MSG_NEW_PROCESS, (DWORD_PTR)job, pi.dwProcessId, 0); + + TerminateProcess(pi.hProcess, 0); + dwret = WaitForSingleObject(pi.hProcess, 1000); + ok(dwret == WAIT_OBJECT_0, "WaitForSingleObject returned %u\n", dwret); + + todo_wine + test_completion(port, JOB_OBJECT_MSG_EXIT_PROCESS, (DWORD_PTR)job, pi.dwProcessId, 0); + todo_wine + test_completion(port, JOB_OBJECT_MSG_ACTIVE_PROCESS_ZERO, (DWORD_PTR)job, 0, 100); + + CloseHandle(pi.hProcess); + CloseHandle(pi.hThread); + CloseHandle(job); + CloseHandle(port); +} + START_TEST(process) { BOOL b = init(); @@ -2372,4 +2437,5 @@ START_TEST(process) test_IsProcessInJob(); test_TerminateJobObject(); test_QueryInformationJobObject(); + test_CompletionPort(); }

1 0

Andrew Cook : kernel32/tests: Add tests for QueryInformationJobObject.
by Alexandre Julliard March 30, 2015

March 30, 2015

Module: wine Branch: master Commit: d4fd3c899e0a8c10f0cc7f96e021ce53bb8671d6 URL: http://source.winehq.org/git/wine.git/?a=commit;h=d4fd3c899e0a8c10f0cc7f96e… Author: Andrew Cook <ariscop(a)gmail.com> Date: Sat Mar 28 13:23:51 2015 +1100 kernel32/tests: Add tests for QueryInformationJobObject. Cleanup and improvements by Sebastian Lackner. --- dlls/kernel32/tests/process.c | 93 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 93 insertions(+) diff --git a/dlls/kernel32/tests/process.c b/dlls/kernel32/tests/process.c index 85de14a..c420576 100644 --- a/dlls/kernel32/tests/process.c +++ b/dlls/kernel32/tests/process.c @@ -70,6 +70,7 @@ static HANDLE (WINAPI *pCreateJobObjectW)(LPSECURITY_ATTRIBUTES sa, LPCWSTR name static BOOL (WINAPI *pAssignProcessToJobObject)(HANDLE job, HANDLE process); static BOOL (WINAPI *pIsProcessInJob)(HANDLE process, HANDLE job, PBOOL result); static BOOL (WINAPI *pTerminateJobObject)(HANDLE job, UINT exit_code); +static BOOL (WINAPI *pQueryInformationJobObject)(HANDLE job, JOBOBJECTINFOCLASS class, LPVOID info, DWORD len, LPDWORD ret_len); /* ############################### */ static char base[MAX_PATH]; @@ -217,6 +218,7 @@ static BOOL init(void) pAssignProcessToJobObject = (void *)GetProcAddress(hkernel32, "AssignProcessToJobObject"); pIsProcessInJob = (void *)GetProcAddress(hkernel32, "IsProcessInJob"); pTerminateJobObject = (void *)GetProcAddress(hkernel32, "TerminateJobObject"); + pQueryInformationJobObject = (void *)GetProcAddress(hkernel32, "QueryInformationJobObject"); return TRUE; } @@ -2223,6 +2225,91 @@ static void test_TerminateJobObject(void) CloseHandle(job); } +static void test_QueryInformationJobObject(void) +{ + char buf[FIELD_OFFSET(JOBOBJECT_BASIC_PROCESS_ID_LIST, ProcessIdList[5])]; + PJOBOBJECT_BASIC_PROCESS_ID_LIST pid_list = (JOBOBJECT_BASIC_PROCESS_ID_LIST *)buf; + DWORD dwret, ret_len; + PROCESS_INFORMATION pi[2]; + HANDLE job; + BOOL ret; + + job = pCreateJobObjectW(NULL, NULL); + ok(job != NULL, "CreateJobObject error %u\n", GetLastError()); + + /* Only active processes are returned */ + create_process("exit", &pi[0]); + ret = pAssignProcessToJobObject(job, pi[0].hProcess); + ok(ret, "AssignProcessToJobObject error %u\n", GetLastError()); + dwret = WaitForSingleObject(pi[0].hProcess, 1000); + ok(dwret == WAIT_OBJECT_0, "WaitForSingleObject returned %u\n", dwret); + + CloseHandle(pi[0].hProcess); + CloseHandle(pi[0].hThread); + + create_process("wait", &pi[0]); + ret = pAssignProcessToJobObject(job, pi[0].hProcess); + ok(ret, "AssignProcessToJobObject error %u\n", GetLastError()); + + create_process("wait", &pi[1]); + ret = pAssignProcessToJobObject(job, pi[1].hProcess); + ok(ret, "AssignProcessToJobObject error %u\n", GetLastError()); + + SetLastError(0xdeadbeef); + ret = QueryInformationJobObject(job, JobObjectBasicProcessIdList, pid_list, + FIELD_OFFSET(JOBOBJECT_BASIC_PROCESS_ID_LIST, ProcessIdList), &ret_len); + ok(!ret, "QueryInformationJobObject expected failure\n"); + todo_wine + expect_eq_d(ERROR_BAD_LENGTH, GetLastError()); + + SetLastError(0xdeadbeef); + memset(buf, 0, sizeof(buf)); + pid_list->NumberOfAssignedProcesses = 42; + pid_list->NumberOfProcessIdsInList = 42; + ret = QueryInformationJobObject(job, JobObjectBasicProcessIdList, pid_list, + FIELD_OFFSET(JOBOBJECT_BASIC_PROCESS_ID_LIST, ProcessIdList[1]), &ret_len); + ok(!ret, "QueryInformationJobObject expected failure\n"); + todo_wine + expect_eq_d(ERROR_MORE_DATA, GetLastError()); + if (ret) + { + expect_eq_d(42, pid_list->NumberOfAssignedProcesses); + expect_eq_d(42, pid_list->NumberOfProcessIdsInList); + } + + memset(buf, 0, sizeof(buf)); + ret = pQueryInformationJobObject(job, JobObjectBasicProcessIdList, pid_list, sizeof(buf), &ret_len); + todo_wine + ok(ret, "QueryInformationJobObject error %u\n", GetLastError()); + if(ret) + { + if (pid_list->NumberOfAssignedProcesses == 3) /* Win 8 */ + win_skip("Number of assigned processes broken on Win 8\n"); + else + { + ULONG_PTR *list = pid_list->ProcessIdList; + + ok(ret_len == FIELD_OFFSET(JOBOBJECT_BASIC_PROCESS_ID_LIST, ProcessIdList[2]), + "QueryInformationJobObject returned ret_len=%u\n", ret_len); + + expect_eq_d(2, pid_list->NumberOfAssignedProcesses); + expect_eq_d(2, pid_list->NumberOfProcessIdsInList); + expect_eq_d(pi[0].dwProcessId, list[0]); + expect_eq_d(pi[1].dwProcessId, list[1]); + } + } + + TerminateProcess(pi[0].hProcess, 0); + CloseHandle(pi[0].hProcess); + CloseHandle(pi[0].hThread); + + TerminateProcess(pi[1].hProcess, 0); + CloseHandle(pi[1].hProcess); + CloseHandle(pi[1].hThread); + + CloseHandle(job); +} + START_TEST(process) { BOOL b = init(); @@ -2242,6 +2329,11 @@ START_TEST(process) ok(0, "Child process not killed\n"); return; } + else if (!strcmp(myARGV[2], "exit")) + { + Sleep(100); + return; + } ok(0, "Unexpected command %s\n", myARGV[2]); return; @@ -2279,4 +2371,5 @@ START_TEST(process) test_IsProcessInJob(); test_TerminateJobObject(); + test_QueryInformationJobObject(); }

1 0