April 2015 - Wine-Commits - list.winehq.org

Francois Gouget : winedbg: Remove unneeded NONAMELESSXXX directives.
by Alexandre Julliard April 2, 2015

April 2, 2015

Module: wine Branch: master Commit: c4f791880145ba41d41690f887e7c700b23209af URL: http://source.winehq.org/git/wine.git/?a=commit;h=c4f791880145ba41d41690f88… Author: Francois Gouget <fgouget(a)free.fr> Date: Thu Apr 2 12:24:55 2015 +0200 winedbg: Remove unneeded NONAMELESSXXX directives. --- programs/winedbg/be_x86_64.c | 2 ++ programs/winedbg/debugger.h | 2 -- programs/winedbg/symbol.c | 3 --- programs/winedbg/tgt_module.c | 3 --- 4 files changed, 2 insertions(+), 8 deletions(-) diff --git a/programs/winedbg/be_x86_64.c b/programs/winedbg/be_x86_64.c index 029f9f1..17feb88 100644 --- a/programs/winedbg/be_x86_64.c +++ b/programs/winedbg/be_x86_64.c @@ -19,6 +19,8 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA */ +#define NONAMELESSUNION + #include "debugger.h" #include "wine/debug.h" diff --git a/programs/winedbg/debugger.h b/programs/winedbg/debugger.h index ba49f1e..e8a4d73 100644 --- a/programs/winedbg/debugger.h +++ b/programs/winedbg/debugger.h @@ -24,8 +24,6 @@ #include <assert.h> #include <stdarg.h> -#define NONAMELESSUNION -#define NONAMELESSSTRUCT #include "ntstatus.h" #define WIN32_NO_STATUS #define WIN32_LEAN_AND_MEAN diff --git a/programs/winedbg/symbol.c b/programs/winedbg/symbol.c index 3069d66..c43cba9 100644 --- a/programs/winedbg/symbol.c +++ b/programs/winedbg/symbol.c @@ -19,9 +19,6 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA */ -#define NONAMELESSUNION -#define NONAMELESSSTRUCT - #include "config.h" #include <stdlib.h> #include <stdio.h> diff --git a/programs/winedbg/tgt_module.c b/programs/winedbg/tgt_module.c index 44e3c9f..58c4282 100644 --- a/programs/winedbg/tgt_module.c +++ b/programs/winedbg/tgt_module.c @@ -18,9 +18,6 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA */ -#define NONAMELESSUNION -#define NONAMELESSSTRUCT - #include "config.h" #include <stdlib.h>

1 0

Andrew Eikum : wineoss.drv: Don' t skip over position updates of less than one fragment.
by Alexandre Julliard April 2, 2015

April 2, 2015

Module: wine Branch: master Commit: 932f392e08980cff3bf74dfdfd35fc10f10364fd URL: http://source.winehq.org/git/wine.git/?a=commit;h=932f392e08980cff3bf74dfdf… Author: Andrew Eikum <aeikum(a)codeweavers.com> Date: Wed Apr 1 12:20:41 2015 -0500 wineoss.drv: Don't skip over position updates of less than one fragment. --- dlls/wineoss.drv/mmdevdrv.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/dlls/wineoss.drv/mmdevdrv.c b/dlls/wineoss.drv/mmdevdrv.c index cbaf1b2..ccd5c86 100644 --- a/dlls/wineoss.drv/mmdevdrv.c +++ b/dlls/wineoss.drv/mmdevdrv.c @@ -1393,7 +1393,7 @@ static void oss_write_data(ACImpl *This) { ssize_t written_bytes; UINT32 written_frames, in_oss_frames, write_limit, max_period, write_offs_frames, new_frames; - size_t to_write_frames, to_write_bytes, advanced; + SIZE_T to_write_frames, to_write_bytes, advanced; audio_buf_info bi; BYTE *buf; @@ -1409,9 +1409,7 @@ static void oss_write_data(ACImpl *This) bi.bytes, This->oss_bufsize_bytes); This->oss_bufsize_bytes = bi.bytes; in_oss_frames = 0; - }else if(This->oss_bufsize_bytes - bi.bytes <= bi.fragsize) - in_oss_frames = 0; - else + }else in_oss_frames = (This->oss_bufsize_bytes - bi.bytes) / This->fmt->nBlockAlign; write_limit = 0; @@ -1433,6 +1431,8 @@ static void oss_write_data(ACImpl *This) This->lcl_offs_frames %= This->bufsize_frames; This->held_frames -= advanced; This->in_oss_frames = in_oss_frames; + TRACE("advanced by %lu, lcl_offs: %u, held: %u, in_oss: %u\n", + advanced, This->lcl_offs_frames, This->held_frames, This->in_oss_frames); if(This->held_frames == This->in_oss_frames) @@ -1448,7 +1448,9 @@ static void oss_write_data(ACImpl *This) to_write_frames = min(to_write_frames, write_limit); to_write_bytes = to_write_frames * This->fmt->nBlockAlign; - + TRACE("going to write %lu frames from %u (%lu of %u)\n", to_write_frames, + write_offs_frames, to_write_frames + write_offs_frames, + This->bufsize_frames); buf = This->local_buffer + write_offs_frames * This->fmt->nBlockAlign; @@ -1479,6 +1481,8 @@ static void oss_write_data(ACImpl *This) if(This->session->mute) silence_buffer(This, This->local_buffer, to_write_frames); + TRACE("wrapping to write %lu frames from beginning\n", to_write_frames); + written_bytes = write(This->fd, This->local_buffer, to_write_bytes); if(written_bytes < 0){ WARN("write failed: %d (%s)\n", errno, strerror(errno));

1 0

Andrew Cook : server: Implement job limit flags.
by Alexandre Julliard April 2, 2015

April 2, 2015

Module: wine Branch: master Commit: ecd41d1de7461b9601e61ee387b24a9610e22b96 URL: http://source.winehq.org/git/wine.git/?a=commit;h=ecd41d1de7461b9601e61ee38… Author: Andrew Cook <ariscop(a)gmail.com> Date: Thu Apr 2 20:40:15 2015 +1100 server: Implement job limit flags. --- dlls/kernel32/tests/process.c | 1 + dlls/ntdll/sync.c | 42 ++++++++++++++++++++++++++++++++++++++++-- include/wine/server_protocol.h | 19 ++++++++++++++++++- include/winnt.h | 4 ++++ server/process.c | 13 +++++++++++++ server/protocol.def | 7 +++++++ server/request.h | 5 +++++ server/trace.c | 9 +++++++++ 8 files changed, 97 insertions(+), 3 deletions(-) diff --git a/dlls/kernel32/tests/process.c b/dlls/kernel32/tests/process.c index fd47951..c991108 100644 --- a/dlls/kernel32/tests/process.c +++ b/dlls/kernel32/tests/process.c @@ -2387,6 +2387,7 @@ static void test_CompletionPort(void) port_info.CompletionKey = job; port_info.CompletionPort = port; ret = pSetInformationJobObject(job, JobObjectAssociateCompletionPortInformation, &port_info, sizeof(port_info)); + todo_wine ok(ret, "SetInformationJobObject error %u\n", GetLastError()); create_process("wait", &pi); diff --git a/dlls/ntdll/sync.c b/dlls/ntdll/sync.c index ce1a635..fff38c9 100644 --- a/dlls/ntdll/sync.c +++ b/dlls/ntdll/sync.c @@ -634,8 +634,46 @@ NTSTATUS WINAPI NtQueryInformationJobObject( HANDLE handle, JOBOBJECTINFOCLASS c */ NTSTATUS WINAPI NtSetInformationJobObject( HANDLE handle, JOBOBJECTINFOCLASS class, PVOID info, ULONG len ) { - FIXME( "stub: %p %u %p %u\n", handle, class, info, len ); - return STATUS_SUCCESS; + NTSTATUS status = STATUS_SUCCESS; + JOBOBJECT_BASIC_LIMIT_INFORMATION *basic_limit; + ULONG info_size = sizeof(JOBOBJECT_BASIC_LIMIT_INFORMATION); + DWORD limit_flags = JOB_OBJECT_BASIC_LIMIT_VALID_FLAGS; + + TRACE( "(%p, %u, %p, %u)\n", handle, class, info, len ); + + if (class >= MaxJobObjectInfoClass) + return STATUS_INVALID_PARAMETER; + + switch (class) + { + + case JobObjectExtendedLimitInformation: + info_size = sizeof(JOBOBJECT_EXTENDED_LIMIT_INFORMATION); + limit_flags = JOB_OBJECT_EXTENDED_LIMIT_VALID_FLAGS; + /* fallthrough */ + case JobObjectBasicLimitInformation: + if (len != info_size) + return STATUS_INVALID_PARAMETER; + + basic_limit = info; + if (basic_limit->LimitFlags & ~limit_flags) + return STATUS_INVALID_PARAMETER; + + SERVER_START_REQ( set_job_limits ) + { + req->handle = wine_server_obj_handle( handle ); + req->limit_flags = basic_limit->LimitFlags; + status = wine_server_call( req ); + } + SERVER_END_REQ; + break; + + default: + FIXME( "stub: %p %u %p %u\n", handle, class, info, len ); + return STATUS_NOT_IMPLEMENTED; + } + + return status; } /****************************************************************************** diff --git a/include/wine/server_protocol.h b/include/wine/server_protocol.h index 5a9f3ab..6e113e7 100644 --- a/include/wine/server_protocol.h +++ b/include/wine/server_protocol.h @@ -5127,6 +5127,20 @@ struct process_in_job_reply }; + +struct set_job_limits_request +{ + struct request_header __header; + obj_handle_t handle; + unsigned int limit_flags; + char __pad_20[4]; +}; +struct set_job_limits_reply +{ + struct reply_header __header; +}; + + enum request { REQ_new_process, @@ -5388,6 +5402,7 @@ enum request REQ_create_job, REQ_assign_job, REQ_process_in_job, + REQ_set_job_limits, REQ_NB_REQUESTS }; @@ -5654,6 +5669,7 @@ union generic_request struct create_job_request create_job_request; struct assign_job_request assign_job_request; struct process_in_job_request process_in_job_request; + struct set_job_limits_request set_job_limits_request; }; union generic_reply { @@ -5918,8 +5934,9 @@ union generic_reply struct create_job_reply create_job_reply; struct assign_job_reply assign_job_reply; struct process_in_job_reply process_in_job_reply; + struct set_job_limits_reply set_job_limits_reply; }; -#define SERVER_PROTOCOL_VERSION 463 +#define SERVER_PROTOCOL_VERSION 464 #endif /* __WINE_WINE_SERVER_PROTOCOL_H */ diff --git a/include/winnt.h b/include/winnt.h index 4b06b2c..c2aa50e 100644 --- a/include/winnt.h +++ b/include/winnt.h @@ -5610,6 +5610,10 @@ typedef struct _JOBOBJECT_EXTENDED_LIMIT_INFORMATION { #define JOB_OBJECT_LIMIT_KILL_ON_JOB_CLOSE 0x00002000 #define JOB_OBJECT_LIMIT_SUBSET_AFFINITY 0x00004000 +#define JOB_OBJECT_LIMIT_VALID_FLAGS 0x0007ffff +#define JOB_OBJECT_BASIC_LIMIT_VALID_FLAGS 0x000000ff +#define JOB_OBJECT_EXTENDED_LIMIT_VALID_FLAGS 0x00007fff + typedef enum _LOGICAL_PROCESSOR_RELATIONSHIP { RelationProcessorCore = 0, diff --git a/server/process.c b/server/process.c index 9534f90..84c6c82 100644 --- a/server/process.c +++ b/server/process.c @@ -146,6 +146,7 @@ struct job struct object obj; /* object header */ struct list process_list; /* list of all processes */ int num_processes; /* count of running processes */ + unsigned int limit_flags; /* limit flags */ }; static const struct object_ops job_ops = @@ -184,6 +185,7 @@ static struct job *create_job_object( struct directory *root, const struct unico SACL_SECURITY_INFORMATION ); list_init( &job->process_list ); job->num_processes = 0; + job->limit_flags = 0; } } return job; @@ -1506,3 +1508,14 @@ DECL_HANDLER(process_in_job) } release_object( process ); } + +/* update limits of the job object */ +DECL_HANDLER(set_job_limits) +{ + struct job *job = get_job_obj( current->process, req->handle, JOB_OBJECT_SET_ATTRIBUTES ); + + if (!job) return; + + job->limit_flags = req->limit_flags; + release_object( job ); +} diff --git a/server/protocol.def b/server/protocol.def index b85adca..35de6ff 100644 --- a/server/protocol.def +++ b/server/protocol.def @@ -3528,3 +3528,10 @@ enum coords_relative obj_handle_t job; /* handle to the job */ obj_handle_t process; /* handle to the process */ @END + + +/* Set limit flags on a job */ +(a)REQ(set_job_limits) + obj_handle_t handle; /* handle to the job */ + unsigned int limit_flags; /* new limit flags */ +(a)END diff --git a/server/request.h b/server/request.h index aef316a..d76ddea 100644 --- a/server/request.h +++ b/server/request.h @@ -365,6 +365,7 @@ DECL_HANDLER(set_suspend_context); DECL_HANDLER(create_job); DECL_HANDLER(assign_job); DECL_HANDLER(process_in_job); +DECL_HANDLER(set_job_limits); #ifdef WANT_REQUEST_HANDLERS @@ -630,6 +631,7 @@ static const req_handler req_handlers[REQ_NB_REQUESTS] = (req_handler)req_create_job, (req_handler)req_assign_job, (req_handler)req_process_in_job, + (req_handler)req_set_job_limits, }; C_ASSERT( sizeof(affinity_t) == 8 ); @@ -2221,6 +2223,9 @@ C_ASSERT( sizeof(struct assign_job_request) == 24 ); C_ASSERT( FIELD_OFFSET(struct process_in_job_request, job) == 12 ); C_ASSERT( FIELD_OFFSET(struct process_in_job_request, process) == 16 ); C_ASSERT( sizeof(struct process_in_job_request) == 24 ); +C_ASSERT( FIELD_OFFSET(struct set_job_limits_request, handle) == 12 ); +C_ASSERT( FIELD_OFFSET(struct set_job_limits_request, limit_flags) == 16 ); +C_ASSERT( sizeof(struct set_job_limits_request) == 24 ); #endif /* WANT_REQUEST_HANDLERS */ diff --git a/server/trace.c b/server/trace.c index cba15a3..3d8e349 100644 --- a/server/trace.c +++ b/server/trace.c @@ -4119,6 +4119,12 @@ static void dump_process_in_job_request( const struct process_in_job_request *re fprintf( stderr, ", process=%04x", req->process ); } +static void dump_set_job_limits_request( const struct set_job_limits_request *req ) +{ + fprintf( stderr, " handle=%04x", req->handle ); + fprintf( stderr, ", limit_flags=%08x", req->limit_flags ); +} + static const dump_func req_dumpers[REQ_NB_REQUESTS] = { (dump_func)dump_new_process_request, (dump_func)dump_get_new_process_info_request, @@ -4379,6 +4385,7 @@ static const dump_func req_dumpers[REQ_NB_REQUESTS] = { (dump_func)dump_create_job_request, (dump_func)dump_assign_job_request, (dump_func)dump_process_in_job_request, + (dump_func)dump_set_job_limits_request, }; static const dump_func reply_dumpers[REQ_NB_REQUESTS] = { @@ -4641,6 +4648,7 @@ static const dump_func reply_dumpers[REQ_NB_REQUESTS] = { (dump_func)dump_create_job_reply, NULL, NULL, + NULL, }; static const char * const req_names[REQ_NB_REQUESTS] = { @@ -4903,6 +4911,7 @@ static const char * const req_names[REQ_NB_REQUESTS] = { "create_job", "assign_job", "process_in_job", + "set_job_limits", }; static const struct

1 0

Alistair Leslie-Hughes : msctf: Always return FALSE in DllCanUnloadNow.
by Alexandre Julliard April 2, 2015

April 2, 2015

Module: wine Branch: master Commit: 46198a5fa669f617ec4b6acd85f77430584948b8 URL: http://source.winehq.org/git/wine.git/?a=commit;h=46198a5fa669f617ec4b6acd8… Author: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Date: Thu Apr 2 12:30:48 2015 +1100 msctf: Always return FALSE in DllCanUnloadNow. --- dlls/msctf/msctf.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/dlls/msctf/msctf.c b/dlls/msctf/msctf.c index 1ce3b8e..4ea6a0a 100644 --- a/dlls/msctf/msctf.c +++ b/dlls/msctf/msctf.c @@ -41,8 +41,6 @@ WINE_DEFAULT_DEBUG_CHANNEL(msctf); -static LONG MSCTF_refCount; - static HINSTANCE MSCTF_hinstance; typedef struct @@ -110,7 +108,6 @@ static void ClassFactory_Destructor(ClassFactory *This) { TRACE("Destroying class factory %p\n", This); HeapFree(GetProcessHeap(),0,This); - InterlockedDecrement(&MSCTF_refCount); } static HRESULT WINAPI ClassFactory_QueryInterface(IClassFactory *iface, REFIID riid, LPVOID *ppvOut) @@ -163,11 +160,6 @@ static HRESULT WINAPI ClassFactory_LockServer(IClassFactory *iface, BOOL fLock) TRACE("(%p)->(%x)\n", This, fLock); - if(fLock) - InterlockedIncrement(&MSCTF_refCount); - else - InterlockedDecrement(&MSCTF_refCount); - return S_OK; } @@ -190,7 +182,6 @@ static HRESULT ClassFactory_Constructor(LPFNCONSTRUCTOR ctor, LPVOID *ppvOut) This->ctor = ctor; *ppvOut = This; TRACE("Created class factory %p\n", This); - InterlockedIncrement(&MSCTF_refCount); return S_OK; } @@ -539,7 +530,7 @@ BOOL WINAPI DllMain(HINSTANCE hinst, DWORD fdwReason, LPVOID fImpLoad) */ HRESULT WINAPI DllCanUnloadNow(void) { - return MSCTF_refCount ? S_FALSE : S_OK; + return S_FALSE; } /***********************************************************************

1 0

Stefan Dösinger : wined3d: Pass a struct arbfp_blit_type to the blit shader generation functions.
by Alexandre Julliard April 2, 2015

April 2, 2015

Module: wine Branch: master Commit: ad50f872ae870b3c1ca8d31c90c307b4116aea84 URL: http://source.winehq.org/git/wine.git/?a=commit;h=ad50f872ae870b3c1ca8d31c9… Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Thu Apr 2 00:30:52 2015 +0200 wined3d: Pass a struct arbfp_blit_type to the blit shader generation functions. --- dlls/wined3d/arb_program_shader.c | 57 ++++++++++++++++++++------------------- 1 file changed, 30 insertions(+), 27 deletions(-) diff --git a/dlls/wined3d/arb_program_shader.c b/dlls/wined3d/arb_program_shader.c index 67c4c04..523fc62 100644 --- a/dlls/wined3d/arb_program_shader.c +++ b/dlls/wined3d/arb_program_shader.c @@ -6904,21 +6904,24 @@ static void arbfp_blit_free(struct wined3d_device *device) device->blit_priv = NULL; } -static BOOL gen_planar_yuv_read(struct wined3d_shader_buffer *buffer, enum complex_fixup fixup, - enum wined3d_gl_resource_type res_type, char *luminance) +static BOOL gen_planar_yuv_read(struct wined3d_shader_buffer *buffer, const struct arbfp_blit_type *type, + char *luminance) { char chroma; const char *tex, *texinstr; - if (fixup == COMPLEX_FIXUP_UYVY) { + if (type->fixup == COMPLEX_FIXUP_UYVY) + { chroma = 'x'; *luminance = 'w'; - } else { + } + else + { chroma = 'w'; *luminance = 'x'; } - switch(res_type) + switch (type->res_type) { case WINED3D_GL_RES_TYPE_TEX_2D: tex = "2D"; @@ -6950,7 +6953,7 @@ static BOOL gen_planar_yuv_read(struct wined3d_shader_buffer *buffer, enum compl * * So we have to get the sampling x position in non-normalized coordinates in integers */ - if (res_type != WINED3D_GL_RES_TYPE_TEX_RECT) + if (type->res_type != WINED3D_GL_RES_TYPE_TEX_RECT) { shader_addline(buffer, "MUL texcrd.xy, fragment.texcoord[0], size.x;\n"); shader_addline(buffer, "MOV texcrd.w, size.x;\n"); @@ -7005,14 +7008,14 @@ static BOOL gen_planar_yuv_read(struct wined3d_shader_buffer *buffer, enum compl return TRUE; } -static BOOL gen_yv12_read(struct wined3d_shader_buffer *buffer, - enum wined3d_gl_resource_type res_type, char *luminance) +static BOOL gen_yv12_read(struct wined3d_shader_buffer *buffer, const struct arbfp_blit_type *type, + char *luminance) { const char *tex; static const float yv12_coef[] = {2.0f / 3.0f, 1.0f / 6.0f, (2.0f / 3.0f) + (1.0f / 6.0f), 1.0f / 3.0f}; - switch (res_type) + switch (type->res_type) { case WINED3D_GL_RES_TYPE_TEX_2D: tex = "2D"; @@ -7079,7 +7082,7 @@ static BOOL gen_yv12_read(struct wined3d_shader_buffer *buffer, * Don't forget to clamp the y values in into the range, otherwise we'll get filtering * bleeding */ - if (res_type == WINED3D_GL_RES_TYPE_TEX_2D) + if (type->res_type == WINED3D_GL_RES_TYPE_TEX_2D) { shader_addline(buffer, "RCP chroma.w, size.y;\n"); @@ -7132,7 +7135,7 @@ static BOOL gen_yv12_read(struct wined3d_shader_buffer *buffer, /* The other chroma value is 1/6th of the texture lower, from 5/6th to 6/6th * No need to clamp because we're just reusing the already clamped value from above */ - if (res_type == WINED3D_GL_RES_TYPE_TEX_2D) + if (type->res_type == WINED3D_GL_RES_TYPE_TEX_2D) shader_addline(buffer, "ADD texcrd.y, texcrd.y, yv12_coef.y;\n"); else shader_addline(buffer, "MAD texcrd.y, size.y, coef.w, texcrd.y;\n"); @@ -7144,7 +7147,7 @@ static BOOL gen_yv12_read(struct wined3d_shader_buffer *buffer, * values due to filtering */ shader_addline(buffer, "MOV texcrd, fragment.texcoord[0];\n"); - if (res_type == WINED3D_GL_RES_TYPE_TEX_2D) + if (type->res_type == WINED3D_GL_RES_TYPE_TEX_2D) { /* Multiply the y coordinate by 2/3 and clamp it */ shader_addline(buffer, "MUL texcrd.y, texcrd.y, yv12_coef.x;\n"); @@ -7167,14 +7170,14 @@ static BOOL gen_yv12_read(struct wined3d_shader_buffer *buffer, return TRUE; } -static BOOL gen_nv12_read(struct wined3d_shader_buffer *buffer, enum wined3d_gl_resource_type res_type, +static BOOL gen_nv12_read(struct wined3d_shader_buffer *buffer, const struct arbfp_blit_type *type, char *luminance) { const char *tex; static const float nv12_coef[] = {2.0f / 3.0f, 1.0f / 3.0f, 1.0f, 1.0f}; - switch (res_type) + switch (type->res_type) { case WINED3D_GL_RES_TYPE_TEX_2D: tex = "2D"; @@ -7225,7 +7228,7 @@ static BOOL gen_nv12_read(struct wined3d_shader_buffer *buffer, enum wined3d_gl_ /* We only have half the number of chroma pixels. */ shader_addline(buffer, "MUL texcrd.x, texcrd.x, coef.y;\n"); - if (res_type == WINED3D_GL_RES_TYPE_TEX_2D) + if (type->res_type == WINED3D_GL_RES_TYPE_TEX_2D) { shader_addline(buffer, "RCP chroma.w, size.x;\n"); shader_addline(buffer, "RCP chroma.z, size.y;\n"); @@ -7274,7 +7277,7 @@ static BOOL gen_nv12_read(struct wined3d_shader_buffer *buffer, enum wined3d_gl_ shader_addline(buffer, "TEX temp, texcrd, texture[0], %s;\n", tex); shader_addline(buffer, "MOV chroma.y, temp.w;\n"); - if (res_type == WINED3D_GL_RES_TYPE_TEX_2D) + if (type->res_type == WINED3D_GL_RES_TYPE_TEX_2D) { /* Add 1/size.x */ shader_addline(buffer, "ADD texcrd.x, texcrd.x, chroma.w;\n"); @@ -7291,7 +7294,7 @@ static BOOL gen_nv12_read(struct wined3d_shader_buffer *buffer, enum wined3d_gl_ * Clamp the y coordinate to prevent the chroma values from bleeding into the sampled luminance * values due to filtering. */ shader_addline(buffer, "MOV texcrd, fragment.texcoord[0];\n"); - if (res_type == WINED3D_GL_RES_TYPE_TEX_2D) + if (type->res_type == WINED3D_GL_RES_TYPE_TEX_2D) { /* Multiply the y coordinate by 2/3 and clamp it */ shader_addline(buffer, "MUL texcrd.y, texcrd.y, nv12_coef.x;\n"); @@ -7316,7 +7319,7 @@ static BOOL gen_nv12_read(struct wined3d_shader_buffer *buffer, enum wined3d_gl_ /* Context activation is done by the caller. */ static GLuint gen_p8_shader(struct arbfp_blit_priv *priv, - const struct wined3d_gl_info *gl_info, enum wined3d_gl_resource_type res_type) + const struct wined3d_gl_info *gl_info, const struct arbfp_blit_type *type) { GLenum shader; struct wined3d_shader_buffer buffer; @@ -7344,7 +7347,7 @@ static GLuint gen_p8_shader(struct arbfp_blit_priv *priv, shader_addline(&buffer, "PARAM constants = { 0.996, 0.00195, 0, 0 };\n"); /* The alpha-component contains the palette index */ - if (res_type == WINED3D_GL_RES_TYPE_TEX_RECT) + if (type->res_type == WINED3D_GL_RES_TYPE_TEX_RECT) shader_addline(&buffer, "TEX index, fragment.texcoord[0], texture[0], RECT;\n"); else shader_addline(&buffer, "TEX index, fragment.texcoord[0], texture[0], 2D;\n"); @@ -7413,7 +7416,7 @@ static void upload_palette(const struct wined3d_texture *texture, struct wined3d /* Context activation is done by the caller. */ static GLuint gen_yuv_shader(struct arbfp_blit_priv *priv, const struct wined3d_gl_info *gl_info, - enum complex_fixup yuv_fixup, enum wined3d_gl_resource_type res_type) + const struct arbfp_blit_type *type) { GLenum shader; struct wined3d_shader_buffer buffer; @@ -7482,11 +7485,11 @@ static GLuint gen_yuv_shader(struct arbfp_blit_priv *priv, const struct wined3d_ shader_addline(&buffer, "PARAM yuv_coef = {1.403, 0.344, 0.714, 1.770};\n"); shader_addline(&buffer, "PARAM size = program.local[0];\n"); - switch (yuv_fixup) + switch (type->fixup) { case COMPLEX_FIXUP_UYVY: case COMPLEX_FIXUP_YUY2: - if (!gen_planar_yuv_read(&buffer, yuv_fixup, res_type, &luminance_component)) + if (!gen_planar_yuv_read(&buffer, type, &luminance_component)) { shader_buffer_free(&buffer); return 0; @@ -7494,7 +7497,7 @@ static GLuint gen_yuv_shader(struct arbfp_blit_priv *priv, const struct wined3d_ break; case COMPLEX_FIXUP_YV12: - if (!gen_yv12_read(&buffer, res_type, &luminance_component)) + if (!gen_yv12_read(&buffer, type, &luminance_component)) { shader_buffer_free(&buffer); return 0; @@ -7502,7 +7505,7 @@ static GLuint gen_yuv_shader(struct arbfp_blit_priv *priv, const struct wined3d_ break; case COMPLEX_FIXUP_NV12: - if (!gen_nv12_read(&buffer, res_type, &luminance_component)) + if (!gen_nv12_read(&buffer, type, &luminance_component)) { shader_buffer_free(&buffer); return 0; @@ -7510,7 +7513,7 @@ static GLuint gen_yuv_shader(struct arbfp_blit_priv *priv, const struct wined3d_ break; default: - FIXME("Unsupported YUV fixup %#x\n", yuv_fixup); + FIXME("Unsupported YUV fixup %#x\n", type->fixup); shader_buffer_free(&buffer); return 0; } @@ -7624,11 +7627,11 @@ static HRESULT arbfp_blit_set(void *blit_priv, struct wined3d_context *context, switch (fixup) { case COMPLEX_FIXUP_P8: - shader = gen_p8_shader(priv, gl_info, type.res_type); + shader = gen_p8_shader(priv, gl_info, &type); break; default: - shader = gen_yuv_shader(priv, gl_info, fixup, type.res_type); + shader = gen_yuv_shader(priv, gl_info, &type); break; }

1 0

Aric Stewart : winmm: sndPlaySound can play resource sounds.
by Alexandre Julliard April 2, 2015

April 2, 2015

Module: wine Branch: master Commit: 74471e857c44449a0236702b7cf8c607cf153a38 URL: http://source.winehq.org/git/wine.git/?a=commit;h=74471e857c44449a0236702b7… Author: Aric Stewart <aric(a)codeweavers.com> Date: Wed Apr 1 10:11:24 2015 -0500 winmm: sndPlaySound can play resource sounds. --- dlls/winmm/playsound.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/winmm/playsound.c b/dlls/winmm/playsound.c index 88a4c48..5d9aed0 100644 --- a/dlls/winmm/playsound.c +++ b/dlls/winmm/playsound.c @@ -566,7 +566,7 @@ BOOL WINAPI PlaySoundW(LPCWSTR pszSoundW, HMODULE hmod, DWORD fdwSound) */ BOOL WINAPI sndPlaySoundA(LPCSTR pszSoundA, UINT uFlags) { - uFlags &= SND_ALIAS_ID|SND_FILENAME|SND_ASYNC|SND_LOOP|SND_MEMORY|SND_NODEFAULT|SND_NOSTOP|SND_SYNC; + uFlags &= SND_RESOURCE|SND_ALIAS_ID|SND_FILENAME|SND_ASYNC|SND_LOOP|SND_MEMORY|SND_NODEFAULT|SND_NOSTOP|SND_SYNC; return MULTIMEDIA_PlaySound(pszSoundA, 0, uFlags, FALSE); } @@ -575,7 +575,7 @@ BOOL WINAPI sndPlaySoundA(LPCSTR pszSoundA, UINT uFlags) */ BOOL WINAPI sndPlaySoundW(LPCWSTR pszSound, UINT uFlags) { - uFlags &= SND_ALIAS_ID|SND_FILENAME|SND_ASYNC|SND_LOOP|SND_MEMORY|SND_NODEFAULT|SND_NOSTOP|SND_SYNC; + uFlags &= SND_RESOURCE|SND_ALIAS_ID|SND_FILENAME|SND_ASYNC|SND_LOOP|SND_MEMORY|SND_NODEFAULT|SND_NOSTOP|SND_SYNC; return MULTIMEDIA_PlaySound(pszSound, 0, uFlags, TRUE); }

1 0

Stefan Dösinger : wined3d: Use bitfields in struct arbfp_blit_type.
by Alexandre Julliard April 2, 2015

April 2, 2015

Module: wine Branch: master Commit: 6cf421399bbf9710ceb3aaf0bef7c1f2aa145689 URL: http://source.winehq.org/git/wine.git/?a=commit;h=6cf421399bbf9710ceb3aaf0b… Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Thu Apr 2 00:30:51 2015 +0200 wined3d: Use bitfields in struct arbfp_blit_type. --- dlls/wined3d/arb_program_shader.c | 52 ++++++++++++++++++--------------------- 1 file changed, 24 insertions(+), 28 deletions(-) diff --git a/dlls/wined3d/arb_program_shader.c b/dlls/wined3d/arb_program_shader.c index eed6cb3..67c4c04 100644 --- a/dlls/wined3d/arb_program_shader.c +++ b/dlls/wined3d/arb_program_shader.c @@ -6824,8 +6824,9 @@ const struct fragment_pipeline arbfp_fragment_pipeline = { struct arbfp_blit_type { - enum complex_fixup fixup; - GLenum textype; + enum complex_fixup fixup : 4; + enum wined3d_gl_resource_type res_type : 3; + DWORD padding : 25; }; struct arbfp_blit_desc @@ -6846,11 +6847,7 @@ static int arbfp_blit_type_compare(const void *key, const struct wine_rb_entry * const struct arbfp_blit_type *ka = key; const struct arbfp_blit_type *kb = &WINE_RB_ENTRY_VALUE(entry, const struct arbfp_blit_desc, entry)->type; - if (ka->fixup != kb->fixup) - return ka->fixup < kb->fixup ? -1 : 1; - if (ka->textype != kb->textype) - return ka->textype < kb->textype ? -1 : 1; - return 0; + return memcmp(ka, kb, sizeof(*ka)); } /* Context activation is done by the caller. */ @@ -7563,16 +7560,15 @@ static HRESULT arbfp_blit_set(void *blit_priv, struct wined3d_context *context, struct arbfp_blit_priv *priv = blit_priv; enum complex_fixup fixup; const struct wined3d_gl_info *gl_info = context->gl_info; - GLenum textype = surface->container->target; + GLenum gl_texture_type = surface->container->target; struct wine_rb_entry *entry; struct arbfp_blit_type type; struct arbfp_blit_desc *desc; - enum wined3d_gl_resource_type res_type; if (surface->container->flags & WINED3D_TEXTURE_CONVERTED) { - gl_info->gl_ops.gl.p_glEnable(textype); - checkGLcall("glEnable(textype)"); + gl_info->gl_ops.gl.p_glEnable(gl_texture_type); + checkGLcall("glEnable(gl_texture_type)"); return WINED3D_OK; } @@ -7581,41 +7577,42 @@ static HRESULT arbfp_blit_set(void *blit_priv, struct wined3d_context *context, TRACE("Fixup:\n"); dump_color_fixup_desc(surface->resource.format->color_fixup); /* Don't bother setting up a shader for unconverted formats */ - gl_info->gl_ops.gl.p_glEnable(textype); - checkGLcall("glEnable(textype)"); + gl_info->gl_ops.gl.p_glEnable(gl_texture_type); + checkGLcall("glEnable(gl_texture_type)"); return WINED3D_OK; } fixup = get_complex_fixup(surface->resource.format->color_fixup); - switch (textype) + switch (gl_texture_type) { case GL_TEXTURE_1D: - res_type = WINED3D_GL_RES_TYPE_TEX_1D; + type.res_type = WINED3D_GL_RES_TYPE_TEX_1D; break; case GL_TEXTURE_2D: - res_type = WINED3D_GL_RES_TYPE_TEX_2D; + type.res_type = WINED3D_GL_RES_TYPE_TEX_2D; break; case GL_TEXTURE_3D: - res_type = WINED3D_GL_RES_TYPE_TEX_3D; + type.res_type = WINED3D_GL_RES_TYPE_TEX_3D; break; case GL_TEXTURE_CUBE_MAP_ARB: - res_type = WINED3D_GL_RES_TYPE_TEX_CUBE; + type.res_type = WINED3D_GL_RES_TYPE_TEX_CUBE; break; case GL_TEXTURE_RECTANGLE_ARB: - res_type = WINED3D_GL_RES_TYPE_TEX_RECT; + type.res_type = WINED3D_GL_RES_TYPE_TEX_RECT; break; default: - ERR("Unexpected GL texture type %x.\n", textype); - res_type = WINED3D_GL_RES_TYPE_TEX_2D; + ERR("Unexpected GL texture type %x.\n", gl_texture_type); + type.res_type = WINED3D_GL_RES_TYPE_TEX_2D; } type.fixup = fixup; - type.textype = textype; + type.padding = 0; + entry = wine_rb_get(&priv->shaders, &type); if (entry) { @@ -7627,19 +7624,19 @@ static HRESULT arbfp_blit_set(void *blit_priv, struct wined3d_context *context, switch (fixup) { case COMPLEX_FIXUP_P8: - shader = gen_p8_shader(priv, gl_info, res_type); + shader = gen_p8_shader(priv, gl_info, type.res_type); break; default: - shader = gen_yuv_shader(priv, gl_info, fixup, res_type); + shader = gen_yuv_shader(priv, gl_info, fixup, type.res_type); break; } if (!shader) { FIXME("Unsupported complex fixup %#x, not setting a shader\n", fixup); - gl_info->gl_ops.gl.p_glEnable(textype); - checkGLcall("glEnable(textype)"); + gl_info->gl_ops.gl.p_glEnable(gl_texture_type); + checkGLcall("glEnable(gl_texture_type)"); return E_NOTIMPL; } @@ -7647,8 +7644,7 @@ static HRESULT arbfp_blit_set(void *blit_priv, struct wined3d_context *context, if (!desc) goto err_out; - desc->type.textype = textype; - desc->type.fixup = fixup; + desc->type = type; desc->shader = shader; if (wine_rb_put(&priv->shaders, &desc->type, &desc->entry) == -1) {

1 0

Nikolay Sivov : comctl32/tests: Fix couple of metrics tests that fail on some systems.
by Alexandre Julliard April 2, 2015

April 2, 2015

Module: wine Branch: master Commit: af30ffaa4351f115dc4b4fad0191901637a6f3fb URL: http://source.winehq.org/git/wine.git/?a=commit;h=af30ffaa4351f115dc4b4fad0… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Thu Apr 2 01:20:52 2015 +0300 comctl32/tests: Fix couple of metrics tests that fail on some systems. --- dlls/comctl32/tests/listview.c | 44 ++++++++++++++++++++++++++++++++++-------- 1 file changed, 36 insertions(+), 8 deletions(-) diff --git a/dlls/comctl32/tests/listview.c b/dlls/comctl32/tests/listview.c index 94c19f4..a165100 100644 --- a/dlls/comctl32/tests/listview.c +++ b/dlls/comctl32/tests/listview.c @@ -3915,7 +3915,6 @@ static void test_getitemrect(void) LVCOLUMNA col; INT order[2]; POINT pt; - HDC hdc; /* rectangle isn't empty for empty text items */ hwnd = create_listview_control(LVS_LIST); @@ -3929,9 +3928,9 @@ static void test_getitemrect(void) expect(TRUE, r); expect(0, rect.left); expect(0, rect.top); - hdc = GetDC(hwnd); - todo_wine expect(((GetDeviceCaps(hdc, LOGPIXELSX) + 15) / 16) * 16, rect.right); - ReleaseDC(hwnd, hdc); + /* estimate it as width / height ratio */ +todo_wine + ok((rect.right / rect.bottom) >= 5, "got right %d, bottom %d\n", rect.right, rect.bottom); DestroyWindow(hwnd); hwnd = create_listview_control(LVS_REPORT); @@ -4833,6 +4832,36 @@ static void test_getitemspacing(void) DestroyWindow(hwnd); } +static INT get_current_font_height(HWND listview) +{ + TEXTMETRICA tm; + HFONT hfont; + HWND hwnd; + HDC hdc; + + hwnd = (HWND)SendMessageA(listview, LVM_GETHEADER, 0, 0); + if (!hwnd) + hwnd = listview; + + hfont = (HFONT)SendMessageA(hwnd, WM_GETFONT, 0, 0); + if (!hfont) { + hdc = GetDC(hwnd); + GetTextMetricsA(hdc, &tm); + ReleaseDC(hwnd, hdc); + } + else { + HFONT oldfont; + + hdc = GetDC(0); + oldfont = SelectObject(hdc, hfont); + GetTextMetricsA(hdc, &tm); + SelectObject(hdc, oldfont); + ReleaseDC(0, hdc); + } + + return tm.tmHeight; +} + static void test_getcolumnwidth(void) { HWND hwnd; @@ -4840,7 +4869,7 @@ static void test_getcolumnwidth(void) DWORD_PTR style; LVCOLUMNA col; LVITEMA itema; - HDC hdc; + INT height; /* default column width */ hwnd = create_listview_control(LVS_ICON); @@ -4864,9 +4893,8 @@ static void test_getcolumnwidth(void) memset(&itema, 0, sizeof(itema)); SendMessageA(hwnd, LVM_INSERTITEMA, 0, (LPARAM)&itema); ret = SendMessageA(hwnd, LVM_GETCOLUMNWIDTH, 0, 0); - hdc = GetDC(hwnd); - todo_wine expect(((GetDeviceCaps(hdc, LOGPIXELSX) + 15) / 16) * 16, ret); - ReleaseDC(hwnd, hdc); + height = get_current_font_height(hwnd); + ok((ret / height) >= 6, "got width %d, height %d\n", ret, height); DestroyWindow(hwnd); }

1 0

Stefan Dösinger : wined3d: Pass a wined3d_ffp_texture_type enum to blit shader functions.
by Alexandre Julliard April 2, 2015

April 2, 2015

Module: wine Branch: master Commit: da7abd29b429fbc5ed6cc59b58ccc24b06907624 URL: http://source.winehq.org/git/wine.git/?a=commit;h=da7abd29b429fbc5ed6cc59b5… Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Thu Apr 2 00:30:50 2015 +0200 wined3d: Pass a wined3d_ffp_texture_type enum to blit shader functions. --- dlls/wined3d/arb_program_shader.c | 117 +++++++++++++++++++++++++++----------- 1 file changed, 85 insertions(+), 32 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=da7abd29b429fbc5ed6cc…

1 0

Stefan Dösinger : wined3d: Give tex_type and its values a better name.
by Alexandre Julliard April 2, 2015

April 2, 2015

Module: wine Branch: master Commit: 844c4efb4736dd3ee42369a2a6add2cc8162855a URL: http://source.winehq.org/git/wine.git/?a=commit;h=844c4efb4736dd3ee42369a2a… Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Thu Apr 2 00:30:49 2015 +0200 wined3d: Give tex_type and its values a better name. --- dlls/wined3d/arb_program_shader.c | 65 +++++++++++++++++++++++---------------- dlls/wined3d/glsl_shader.c | 55 +++++++++++++++++---------------- dlls/wined3d/shader.c | 2 +- dlls/wined3d/surface.c | 18 +++++------ dlls/wined3d/utils.c | 16 +++++----- dlls/wined3d/wined3d_private.h | 21 ++++++------- 6 files changed, 95 insertions(+), 82 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=844c4efb4736dd3ee4236…

1 0