April 2016 - Wine-Commits - list.winehq.org

Francois Gouget : mshtml/tests: A spelling fix for a dom ok() message.
by Alexandre Julliard April 26, 2016

April 26, 2016

Module: wine Branch: master Commit: ea12d857b45ed93631549ba521736d4f6f66ddb8 URL: http://source.winehq.org/git/wine.git/?a=commit;h=ea12d857b45ed93631549ba52… Author: Francois Gouget <fgouget(a)free.fr> Date: Sat Apr 23 07:48:57 2016 +0200 mshtml/tests: A spelling fix for a dom ok() message. Signed-off-by: Francois Gouget <fgouget(a)free.fr> Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mshtml/tests/dom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c index 9e8d8b5..7a39d34 100644 --- a/dlls/mshtml/tests/dom.c +++ b/dlls/mshtml/tests/dom.c @@ -5775,7 +5775,7 @@ static void test_location(IHTMLDocument2 *doc) SysFreeString(str); ref = IHTMLLocation_Release(location); - ok(!ref, "location chould be destroyed here\n"); + ok(!ref, "location should be destroyed here\n"); } static void test_plugins_col(IHTMLDocument2 *doc)

1 0

Stefan Dösinger : wined3d: Use wined3d_texture_prepare_location() in surface_load_ds_location().
by Alexandre Julliard April 26, 2016

April 26, 2016

Module: wine Branch: master Commit: 02a664c093bb27a28dd2b99e644cd590e54e0252 URL: http://source.winehq.org/git/wine.git/?a=commit;h=02a664c093bb27a28dd2b99e6… Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Mon Apr 25 17:19:34 2016 +0200 wined3d: Use wined3d_texture_prepare_location() in surface_load_ds_location(). Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wined3d/surface.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/dlls/wined3d/surface.c b/dlls/wined3d/surface.c index 88187e8..319e32a 100644 --- a/dlls/wined3d/surface.c +++ b/dlls/wined3d/surface.c @@ -2570,6 +2570,7 @@ void surface_modify_ds_location(struct wined3d_surface *surface, /* Context activation is done by the caller. */ static void surface_load_ds_location(struct wined3d_surface *surface, struct wined3d_context *context, DWORD location) { + unsigned int sub_resource_idx = surface_get_sub_resource_idx(surface); struct wined3d_texture *texture = surface->container; struct wined3d_device *device = texture->resource.device; const struct wined3d_gl_info *gl_info = context->gl_info; @@ -2580,7 +2581,7 @@ static void surface_load_ds_location(struct wined3d_surface *surface, struct win /* TODO: Make this work for modes other than FBO */ if (wined3d_settings.offscreen_rendering_mode != ORM_FBO) return; - if (!(surface_get_sub_resource(surface)->locations & location)) + if (!(texture->sub_resources[sub_resource_idx].locations & location)) { w = surface->ds_current_size.cx; h = surface->ds_current_size.cy; @@ -2599,7 +2600,7 @@ static void surface_load_ds_location(struct wined3d_surface *surface, struct win return; } - wined3d_surface_prepare(surface, context, location); + wined3d_texture_prepare_location(texture, sub_resource_idx, context, location); if (location == WINED3D_LOCATION_TEXTURE_RGB) {

1 0

Henri Verbeet : wined3d: Pas a wined3d_vec4 structure to shader_arb_load_constants_f().
by Alexandre Julliard April 26, 2016

April 26, 2016

Module: wine Branch: master Commit: 6d2f710d660de4ac6ed550363fcf37b50deb0af1 URL: http://source.winehq.org/git/wine.git/?a=commit;h=6d2f710d660de4ac6ed550363… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Mon Apr 25 17:19:33 2016 +0200 wined3d: Pas a wined3d_vec4 structure to shader_arb_load_constants_f(). Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wined3d/arb_program_shader.c | 91 +++++++++++++++++++++++---------------- dlls/wined3d/utils.c | 8 ++++ dlls/wined3d/wined3d_private.h | 3 +- 3 files changed, 65 insertions(+), 37 deletions(-) diff --git a/dlls/wined3d/arb_program_shader.c b/dlls/wined3d/arb_program_shader.c index fac97fe..a48773f 100644 --- a/dlls/wined3d/arb_program_shader.c +++ b/dlls/wined3d/arb_program_shader.c @@ -360,21 +360,20 @@ static unsigned int reserved_vs_const(const struct arb_vshader_private *shader_d * or GL_FRAGMENT_PROGRAM_ARB (for pixel shaders) */ /* Context activation is done by the caller. */ -static unsigned int shader_arb_load_constantsF(const struct wined3d_shader *shader, +static unsigned int shader_arb_load_constants_f(const struct wined3d_shader *shader, const struct wined3d_gl_info *gl_info, GLuint target_type, unsigned int max_constants, - const float *constants, char *dirty_consts) + const struct wined3d_vec4 *constants, char *dirty_consts) { struct wined3d_shader_lconst *lconst; - DWORD i, j; - unsigned int ret; + unsigned int ret, i, j; if (TRACE_ON(d3d_constants)) { - for(i = 0; i < max_constants; i++) { - if(!dirty_consts[i]) continue; - TRACE_(d3d_constants)("Loading constants %i: %f, %f, %f, %f\n", i, - constants[i * 4 + 0], constants[i * 4 + 1], - constants[i * 4 + 2], constants[i * 4 + 3]); + for (i = 0; i < max_constants; ++i) + { + if (!dirty_consts[i]) + continue; + TRACE_(d3d_constants)("Loading constant %u: %s.\n", i, debug_vec4(&constants[i])); } } @@ -387,26 +386,39 @@ static unsigned int shader_arb_load_constantsF(const struct wined3d_shader *shad /* ps 1.x supports only 8 constants, clamp only those. When switching between 1.x and higher * shaders, the first 8 constants are marked dirty for reload */ - for(; i < min(8, max_constants); i++) { - if(!dirty_consts[i]) continue; + for (; i < min(8, max_constants); ++i) + { + if (!dirty_consts[i]) + continue; dirty_consts[i] = 0; - j = 4 * i; - if (constants[j + 0] > 1.0f) lcl_const[0] = 1.0f; - else if (constants[j + 0] < -1.0f) lcl_const[0] = -1.0f; - else lcl_const[0] = constants[j + 0]; + if (constants[i].x > 1.0f) + lcl_const[0] = 1.0f; + else if (constants[i].x < -1.0f) + lcl_const[0] = -1.0f; + else + lcl_const[0] = constants[i].x; - if (constants[j + 1] > 1.0f) lcl_const[1] = 1.0f; - else if (constants[j + 1] < -1.0f) lcl_const[1] = -1.0f; - else lcl_const[1] = constants[j + 1]; + if (constants[i].y > 1.0f) + lcl_const[1] = 1.0f; + else if (constants[i].y < -1.0f) + lcl_const[1] = -1.0f; + else + lcl_const[1] = constants[i].y; - if (constants[j + 2] > 1.0f) lcl_const[2] = 1.0f; - else if (constants[j + 2] < -1.0f) lcl_const[2] = -1.0f; - else lcl_const[2] = constants[j + 2]; + if (constants[i].z > 1.0f) + lcl_const[2] = 1.0f; + else if (constants[i].z < -1.0f) + lcl_const[2] = -1.0f; + else + lcl_const[2] = constants[i].z; - if (constants[j + 3] > 1.0f) lcl_const[3] = 1.0f; - else if (constants[j + 3] < -1.0f) lcl_const[3] = -1.0f; - else lcl_const[3] = constants[j + 3]; + if (constants[i].w > 1.0f) + lcl_const[3] = 1.0f; + else if (constants[i].w < -1.0f) + lcl_const[3] = -1.0f; + else + lcl_const[3] = constants[i].w; GL_EXTCALL(glProgramEnvParameter4fvARB(target_type, i, lcl_const)); } @@ -427,23 +439,30 @@ static unsigned int shader_arb_load_constantsF(const struct wined3d_shader *shad * GL_EXTCALL(glProgramEnvParameters4fvEXT(target_type, i, max_constants, constants + (i * 4))); */ - for(; i < max_constants; i++) { - if(!dirty_consts[i]) continue; + for (; i < max_constants; ++i) + { + if (!dirty_consts[i]) + continue; /* Find the next block of dirty constants */ dirty_consts[i] = 0; j = i; - for(i++; (i < max_constants) && dirty_consts[i]; i++) { + for (++i; (i < max_constants) && dirty_consts[i]; ++i) + { dirty_consts[i] = 0; } - GL_EXTCALL(glProgramEnvParameters4fvEXT(target_type, j, i - j, constants + (j * 4))); + GL_EXTCALL(glProgramEnvParameters4fvEXT(target_type, j, i - j, &constants[j].x)); } - } else { - for(; i < max_constants; i++) { - if(dirty_consts[i]) { + } + else + { + for (; i < max_constants; ++i) + { + if (dirty_consts[i]) + { dirty_consts[i] = 0; - GL_EXTCALL(glProgramEnvParameter4fvARB(target_type, i, constants + (i * 4))); + GL_EXTCALL(glProgramEnvParameter4fvARB(target_type, i, &constants[i].x)); } } } @@ -675,8 +694,8 @@ static void shader_arb_load_constants_internal(struct shader_arb_priv *priv, const struct arb_vs_compiled_shader *gl_shader = priv->compiled_vprog; /* Load DirectX 9 float constants for vertex shader */ - priv->highest_dirty_vs_const = shader_arb_load_constantsF(vshader, gl_info, GL_VERTEX_PROGRAM_ARB, - priv->highest_dirty_vs_const, state->vs_consts_f, priv->vshader_const_dirty); + priv->highest_dirty_vs_const = shader_arb_load_constants_f(vshader, gl_info, GL_VERTEX_PROGRAM_ARB, + priv->highest_dirty_vs_const, (struct wined3d_vec4 *)state->vs_consts_f, priv->vshader_const_dirty); shader_arb_vs_local_constants(gl_shader, context, state); } @@ -687,8 +706,8 @@ static void shader_arb_load_constants_internal(struct shader_arb_priv *priv, UINT rt_height = state->fb->render_targets[0]->height; /* Load DirectX 9 float constants for pixel shader */ - priv->highest_dirty_ps_const = shader_arb_load_constantsF(pshader, gl_info, GL_FRAGMENT_PROGRAM_ARB, - priv->highest_dirty_ps_const, state->ps_consts_f, priv->pshader_const_dirty); + priv->highest_dirty_ps_const = shader_arb_load_constants_f(pshader, gl_info, GL_FRAGMENT_PROGRAM_ARB, + priv->highest_dirty_ps_const, (struct wined3d_vec4 *)state->ps_consts_f, priv->pshader_const_dirty); shader_arb_ps_local_constants(gl_shader, context, state, rt_height); if (context->constant_update_mask & WINED3D_SHADER_CONST_PS_NP2_FIXUP) diff --git a/dlls/wined3d/utils.c b/dlls/wined3d/utils.c index c7bf5bb..e2e3ec9 100644 --- a/dlls/wined3d/utils.c +++ b/dlls/wined3d/utils.c @@ -3365,6 +3365,14 @@ const char *debug_color(const struct wined3d_color *color) color->r, color->g, color->b, color->a); } +const char *debug_vec4(const struct wined3d_vec4 *v) +{ + if (!v) + return "(null)"; + return wine_dbg_sprintf("{%.8e, %.8e, %.8e, %.8e}", + v->x, v->y, v->z, v->w); +} + const char *debug_d3dformat(enum wined3d_format_id format_id) { switch (format_id) diff --git a/dlls/wined3d/wined3d_private.h b/dlls/wined3d/wined3d_private.h index 3cc7ece..9ce2281 100644 --- a/dlls/wined3d/wined3d_private.h +++ b/dlls/wined3d/wined3d_private.h @@ -3095,13 +3095,14 @@ const char *debug_d3dsamplerstate(enum wined3d_sampler_state state) DECLSPEC_HID const char *debug_d3dstate(DWORD state) DECLSPEC_HIDDEN; const char *debug_d3dtexturefiltertype(enum wined3d_texture_filter_type filter_type) DECLSPEC_HIDDEN; const char *debug_d3dtexturestate(enum wined3d_texture_stage_state state) DECLSPEC_HIDDEN; +const char *debug_d3dtop(enum wined3d_texture_op d3dtop) DECLSPEC_HIDDEN; const char *debug_d3dtstype(enum wined3d_transform_state tstype) DECLSPEC_HIDDEN; const char *debug_d3dpool(enum wined3d_pool pool) DECLSPEC_HIDDEN; const char *debug_fboattachment(GLenum attachment) DECLSPEC_HIDDEN; const char *debug_fbostatus(GLenum status) DECLSPEC_HIDDEN; const char *debug_glerror(GLenum error) DECLSPEC_HIDDEN; -const char *debug_d3dtop(enum wined3d_texture_op d3dtop) DECLSPEC_HIDDEN; const char *debug_shader_type(enum wined3d_shader_type shader_type) DECLSPEC_HIDDEN; +const char *debug_vec4(const struct wined3d_vec4 *v) DECLSPEC_HIDDEN; void dump_color_fixup_desc(struct color_fixup_desc fixup) DECLSPEC_HIDDEN; BOOL is_invalid_op(const struct wined3d_state *state, int stage,

1 0

Henri Verbeet : wined3d: Pass a wined3d_vec4 structure to shader_glsl_load_constants_f().
by Alexandre Julliard April 26, 2016

April 26, 2016

Module: wine Branch: master Commit: f33c79d38763dd4562f00357084c654a5c01c9f7 URL: http://source.winehq.org/git/wine.git/?a=commit;h=f33c79d38763dd4562f003570… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Mon Apr 25 17:19:32 2016 +0200 wined3d: Pass a wined3d_vec4 structure to shader_glsl_load_constants_f(). Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wined3d/glsl_shader.c | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/dlls/wined3d/glsl_shader.c b/dlls/wined3d/glsl_shader.c index db2322c..4fd24ba 100644 --- a/dlls/wined3d/glsl_shader.c +++ b/dlls/wined3d/glsl_shader.c @@ -700,20 +700,18 @@ static inline void walk_constant_heap_clamped(const struct wined3d_gl_info *gl_i } /* Context activation is done by the caller. */ -static void shader_glsl_load_constantsF(const struct wined3d_shader *shader, const struct wined3d_gl_info *gl_info, - const float *constants, const GLint *constant_locations, const struct constant_heap *heap, - unsigned char *stack, UINT version) +static void shader_glsl_load_constants_f(const struct wined3d_shader *shader, const struct wined3d_gl_info *gl_info, + const struct wined3d_vec4 *constants, const GLint *constant_locations, const struct constant_heap *heap, + unsigned char *stack, unsigned int version) { const struct wined3d_shader_lconst *lconst; /* 1.X pshaders have the constants clamped to [-1;1] implicitly. */ if (shader->reg_maps.shader_version.major == 1 && shader->reg_maps.shader_version.type == WINED3D_SHADER_TYPE_PIXEL) - walk_constant_heap_clamped(gl_info, (const struct wined3d_vec4 *)constants, - constant_locations, heap, stack, version); + walk_constant_heap_clamped(gl_info, constants, constant_locations, heap, stack, version); else - walk_constant_heap(gl_info, (const struct wined3d_vec4 *)constants, - constant_locations, heap, stack, version); + walk_constant_heap(gl_info, constants, constant_locations, heap, stack, version); if (!shader->load_local_constsF) { @@ -1333,7 +1331,7 @@ static void shader_glsl_load_constants(void *shader_priv, struct wined3d_context update_mask = context->constant_update_mask & prog->constant_update_mask; if (update_mask & WINED3D_SHADER_CONST_VS_F) - shader_glsl_load_constantsF(vshader, gl_info, state->vs_consts_f, + shader_glsl_load_constants_f(vshader, gl_info, (const struct wined3d_vec4 *)state->vs_consts_f, prog->vs.uniform_f_locations, &priv->vconst_heap, priv->stack, constant_version); if (update_mask & WINED3D_SHADER_CONST_VS_I) @@ -1406,7 +1404,7 @@ static void shader_glsl_load_constants(void *shader_priv, struct wined3d_context } if (update_mask & WINED3D_SHADER_CONST_PS_F) - shader_glsl_load_constantsF(pshader, gl_info, state->ps_consts_f, + shader_glsl_load_constants_f(pshader, gl_info, (const struct wined3d_vec4 *)state->ps_consts_f, prog->ps.uniform_f_locations, &priv->pconst_heap, priv->stack, constant_version); if (update_mask & WINED3D_SHADER_CONST_PS_I)

1 0

Henri Verbeet : wined3d: Pass a wined3d_vec4 structure to walk_constant_heap().
by Alexandre Julliard April 26, 2016

April 26, 2016

Module: wine Branch: master Commit: d7596b08ea62cb7d96298345d284f6c05fae07e8 URL: http://source.winehq.org/git/wine.git/?a=commit;h=d7596b08ea62cb7d96298345d… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Mon Apr 25 17:19:31 2016 +0200 wined3d: Pass a wined3d_vec4 structure to walk_constant_heap(). Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wined3d/glsl_shader.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/dlls/wined3d/glsl_shader.c b/dlls/wined3d/glsl_shader.c index d9f1108..db2322c 100644 --- a/dlls/wined3d/glsl_shader.c +++ b/dlls/wined3d/glsl_shader.c @@ -551,7 +551,7 @@ static void shader_glsl_load_samplers(const struct wined3d_gl_info *gl_info, } /* Context activation is done by the caller. */ -static inline void walk_constant_heap(const struct wined3d_gl_info *gl_info, const float *constants, +static inline void walk_constant_heap(const struct wined3d_gl_info *gl_info, const struct wined3d_vec4 *constants, const GLint *constant_locations, const struct constant_heap *heap, unsigned char *stack, DWORD version) { unsigned int start = ~0U, end = 0; @@ -620,7 +620,7 @@ static inline void walk_constant_heap(const struct wined3d_gl_info *gl_info, con } } if (start <= end) - GL_EXTCALL(glUniform4fv(constant_locations[start], end - start + 1, &constants[start * 4])); + GL_EXTCALL(glUniform4fv(constant_locations[start], end - start + 1, &constants[start].x)); checkGLcall("walk_constant_heap()"); } @@ -712,7 +712,8 @@ static void shader_glsl_load_constantsF(const struct wined3d_shader *shader, con walk_constant_heap_clamped(gl_info, (const struct wined3d_vec4 *)constants, constant_locations, heap, stack, version); else - walk_constant_heap(gl_info, constants, constant_locations, heap, stack, version); + walk_constant_heap(gl_info, (const struct wined3d_vec4 *)constants, + constant_locations, heap, stack, version); if (!shader->load_local_constsF) {

1 0

Henri Verbeet : wined3d: Clear the renderbuffer IDs on unload.
by Alexandre Julliard April 26, 2016

April 26, 2016

Module: wine Branch: master Commit: 364701db60981496aedf6af36bdbc118ca6b661e URL: http://source.winehq.org/git/wine.git/?a=commit;h=364701db60981496aedf6af36… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Mon Apr 25 17:19:28 2016 +0200 wined3d: Clear the renderbuffer IDs on unload. This got lost in commit feb86895b4f0b1a9b43a4e47f7169e27fd5e3e93. Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wined3d/texture.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/dlls/wined3d/texture.c b/dlls/wined3d/texture.c index eb0ad2f..c6f9f13 100644 --- a/dlls/wined3d/texture.c +++ b/dlls/wined3d/texture.c @@ -370,6 +370,7 @@ static void wined3d_texture_unload_gl_texture(struct wined3d_texture *texture) TRACE("Deleting multisample renderbuffer %u.\n", texture->rb_multisample); context_gl_resource_released(device, texture->rb_multisample, TRUE); gl_info->fbo_ops.glDeleteRenderbuffers(1, &texture->rb_multisample); + texture->rb_multisample = 0; } if (texture->rb_resolved) @@ -377,6 +378,7 @@ static void wined3d_texture_unload_gl_texture(struct wined3d_texture *texture) TRACE("Deleting resolved renderbuffer %u.\n", texture->rb_resolved); context_gl_resource_released(device, texture->rb_resolved, TRUE); gl_info->fbo_ops.glDeleteRenderbuffers(1, &texture->rb_resolved); + texture->rb_resolved = 0; } if (context) context_release(context);

1 0

Sebastian Lackner : server: Fix possible leak of root object in create_named_pipe handler.
by Alexandre Julliard April 26, 2016

April 26, 2016

Module: wine Branch: master Commit: 20651c7dfe74aad58d17e527438df350b1b1afac URL: http://source.winehq.org/git/wine.git/?a=commit;h=20651c7dfe74aad58d17e5274… Author: Sebastian Lackner <sebastian(a)fds-team.de> Date: Tue Apr 26 03:34:58 2016 +0200 server: Fix possible leak of root object in create_named_pipe handler. Signed-off-by: Sebastian Lackner <sebastian(a)fds-team.de> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- server/named_pipe.c | 1 + 1 file changed, 1 insertion(+) diff --git a/server/named_pipe.c b/server/named_pipe.c index f41c26e..0661c12 100644 --- a/server/named_pipe.c +++ b/server/named_pipe.c @@ -901,6 +901,7 @@ DECL_HANDLER(create_named_pipe) if (!req->sharing || (req->sharing & ~(FILE_SHARE_READ | FILE_SHARE_WRITE)) || (!(req->flags & NAMED_PIPE_MESSAGE_STREAM_WRITE) && (req->flags & NAMED_PIPE_MESSAGE_STREAM_READ))) { + if (root) release_object( root ); set_error( STATUS_INVALID_PARAMETER ); return; }

1 0

Sebastian Lackner : server: Add missing linebreak to a dump message.
by Alexandre Julliard April 26, 2016

April 26, 2016

Module: wine Branch: master Commit: 240d8ed7e96ccf140543cc5c24124c8c6f481a60 URL: http://source.winehq.org/git/wine.git/?a=commit;h=240d8ed7e96ccf140543cc5c2… Author: Sebastian Lackner <sebastian(a)fds-team.de> Date: Tue Apr 26 00:06:52 2016 +0200 server: Add missing linebreak to a dump message. Signed-off-by: Sebastian Lackner <sebastian(a)fds-team.de> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- server/completion.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/completion.c b/server/completion.c index 4069c0c..8b8983a 100644 --- a/server/completion.c +++ b/server/completion.c @@ -104,7 +104,7 @@ static void completion_dump( struct object *obj, int verbose ) struct completion *completion = (struct completion *) obj; assert( obj->ops == &completion_ops ); - fprintf( stderr, "Completion depth=%u", completion->depth ); + fprintf( stderr, "Completion depth=%u\n", completion->depth ); } static struct object_type *completion_get_type( struct object *obj )

1 0

Dmitry Timoshkov : shlwapi: Fix IStream::Read() return value for partial reads.
by Alexandre Julliard April 26, 2016

April 26, 2016

Module: wine Branch: master Commit: 860f5562c70520a0acfe0cec6261dc8e96bfc619 URL: http://source.winehq.org/git/wine.git/?a=commit;h=860f5562c70520a0acfe0cec6… Author: Dmitry Timoshkov <dmitry(a)baikal.ru> Date: Mon Apr 25 22:39:04 2016 +0200 shlwapi: Fix IStream::Read() return value for partial reads. Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> Signed-off-by: Sebastian Lackner <sebastian(a)fds-team.de> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/shlwapi/istream.c | 2 +- dlls/shlwapi/tests/istream.c | 15 ++++++++++++++- 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/dlls/shlwapi/istream.c b/dlls/shlwapi/istream.c index e641995..946d2c8 100644 --- a/dlls/shlwapi/istream.c +++ b/dlls/shlwapi/istream.c @@ -130,7 +130,7 @@ static HRESULT WINAPI IStream_fnRead(IStream *iface, void* pv, ULONG cb, ULONG* } if (pcbRead) *pcbRead = dwRead; - return S_OK; + return dwRead == cb ? S_OK : S_FALSE; } /************************************************************************** diff --git a/dlls/shlwapi/tests/istream.c b/dlls/shlwapi/tests/istream.c index 48a292a..c9cf62f 100644 --- a/dlls/shlwapi/tests/istream.c +++ b/dlls/shlwapi/tests/istream.c @@ -247,11 +247,24 @@ static void test_stream_read_write(IStream *stream, DWORD mode) } else { -todo_wine ok(ret == S_FALSE, "expected S_FALSE, got %#x (access %#x, written %u)\n", ret, mode, written); ok(count == 0, "expected 0, got %u\n", count); } + ret = stream->lpVtbl->Seek(stream, start, STREAM_SEEK_SET, NULL); + ok(ret == S_OK, "Seek error %#x\n", ret); + + count = 0xdeadbeaf; + ret = stream->lpVtbl->Read(stream, buf, 0, &count); + ok(ret == S_OK, "IStream_Read error %#x (access %#x, written %u)\n", ret, mode, written); + ok(count == 0, "expected 0, got %u\n", count); + + count = 0xdeadbeaf; + ret = stream->lpVtbl->Read(stream, buf, sizeof(buf), &count); + ok(ret == S_FALSE, "expected S_FALSE, got %#x (access %#x, written %u)\n", ret, mode, written); + ok(count == written, "expected %u, got %u\n", written, count); + if (count) + ok(buf[0] == 0x5e && buf[1] == 0xa7, "expected 5ea7, got %02x%02x\n", buf[0], buf[1]); } static void test_SHCreateStreamOnFileA(DWORD mode, DWORD stgm)

1 0

Nikolay Sivov : msvcrt: Fix calloc() prototype.
by Alexandre Julliard April 26, 2016

April 26, 2016

Module: wine Branch: master Commit: 21fd1d37293c112c1659f2f8fd4f90f240816c89 URL: http://source.winehq.org/git/wine.git/?a=commit;h=21fd1d37293c112c1659f2f8f… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Sun Apr 24 21:51:26 2016 +0300 msvcrt: Fix calloc() prototype. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/msvcrt/exit.c | 2 +- dlls/msvcrt/file.c | 4 ++-- dlls/msvcrt/heap.c | 4 ++-- dlls/msvcrt/tests/file.c | 4 ++-- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/dlls/msvcrt/exit.c b/dlls/msvcrt/exit.c index 0f1343d..610525d 100644 --- a/dlls/msvcrt/exit.c +++ b/dlls/msvcrt/exit.c @@ -273,7 +273,7 @@ MSVCRT__onexit_t CDECL MSVCRT__onexit(MSVCRT__onexit_t func) { MSVCRT__onexit_t *newtable; TRACE("expanding table\n"); - newtable = MSVCRT_calloc(sizeof(void *),MSVCRT_atexit_table_size + 32); + newtable = MSVCRT_calloc(MSVCRT_atexit_table_size + 32, sizeof(void *)); if (!newtable) { TRACE("failed!\n"); diff --git a/dlls/msvcrt/file.c b/dlls/msvcrt/file.c index 71e578d..c4f89b1 100644 --- a/dlls/msvcrt/file.c +++ b/dlls/msvcrt/file.c @@ -512,7 +512,7 @@ unsigned msvcrt_create_io_inherit_block(WORD *size, BYTE **block) last_fd++; *size = sizeof(unsigned) + (sizeof(char) + sizeof(HANDLE)) * last_fd; - *block = MSVCRT_calloc(*size, 1); + *block = MSVCRT_calloc(1, *size); if (!*block) { *size = 0; @@ -660,7 +660,7 @@ static BOOL msvcrt_alloc_buffer(MSVCRT_FILE* file) && MSVCRT__isatty(file->_file)) return FALSE; - file->_base = MSVCRT_calloc(MSVCRT_INTERNAL_BUFSIZ,1); + file->_base = MSVCRT_calloc(1, MSVCRT_INTERNAL_BUFSIZ); if(file->_base) { file->_bufsiz = MSVCRT_INTERNAL_BUFSIZ; file->_flag |= MSVCRT__IOMYBUF; diff --git a/dlls/msvcrt/heap.c b/dlls/msvcrt/heap.c index a908846..52a5287 100644 --- a/dlls/msvcrt/heap.c +++ b/dlls/msvcrt/heap.c @@ -392,9 +392,9 @@ size_t CDECL _aligned_msize(void *p, MSVCRT_size_t alignment, MSVCRT_size_t offs /********************************************************************* * calloc (MSVCRT.@) */ -void* CDECL MSVCRT_calloc(MSVCRT_size_t size, MSVCRT_size_t count) +void* CDECL MSVCRT_calloc(MSVCRT_size_t count, MSVCRT_size_t size) { - return msvcrt_heap_alloc(HEAP_ZERO_MEMORY, size*count); + return msvcrt_heap_alloc(HEAP_ZERO_MEMORY, count*size); } /********************************************************************* diff --git a/dlls/msvcrt/tests/file.c b/dlls/msvcrt/tests/file.c index dbb6cef..42ec34b 100644 --- a/dlls/msvcrt/tests/file.c +++ b/dlls/msvcrt/tests/file.c @@ -2262,8 +2262,8 @@ static void test_write_flush_size(FILE *file, int bufsize) fpos_t pos, pos2; fd = fileno(file); - inbuffer = calloc(bufsize + 1, 1); - outbuffer = calloc(bufsize + 1, 1); + inbuffer = calloc(1, bufsize + 1); + outbuffer = calloc(1, bufsize + 1); _snprintf(outbuffer, bufsize + 1, "0,1,2,3,4,5,6,7,8,9"); for (size = bufsize + 1; size >= bufsize - 1; size--) {

1 0