September 2016 - Wine-Commits

Alistair Leslie-Hughes : ws2_32: Accept shouldn' t fail when addrlen32 is NULL.
by Alexandre Julliard Sept. 8, 2016

Sept. 8, 2016

Module: wine Branch: master Commit: f9d40575740fba3e48c5ab2638e630b4a24f3126 URL: http://source.winehq.org/git/wine.git/?a=commit;h=f9d40575740fba3e48c5ab263… Author: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Date: Wed Sep 7 04:31:42 2016 +0000 ws2_32: Accept shouldn't fail when addrlen32 is NULL. Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Signed-off-by: Bruno Jesus <00cpxxx(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ws2_32/socket.c | 2 +- dlls/ws2_32/tests/sock.c | 15 ++++++++++++++- 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/dlls/ws2_32/socket.c b/dlls/ws2_32/socket.c index ccd50f8..f0dc04f 100644 --- a/dlls/ws2_32/socket.c +++ b/dlls/ws2_32/socket.c @@ -2653,7 +2653,7 @@ SOCKET WINAPI WS_accept(SOCKET s, struct WS_sockaddr *addr, int *addrlen32) SERVER_END_REQ; if (!status) { - if (addr && WS_getpeername(as, addr, addrlen32)) + if (addr && addrlen32 && WS_getpeername(as, addr, addrlen32)) { WS_closesocket(as); return SOCKET_ERROR; diff --git a/dlls/ws2_32/tests/sock.c b/dlls/ws2_32/tests/sock.c index 98ff7c7..be98691 100644 --- a/dlls/ws2_32/tests/sock.c +++ b/dlls/ws2_32/tests/sock.c @@ -4068,7 +4068,7 @@ static void test_accept(void) int ret; SOCKET server_socket, accepted = INVALID_SOCKET, connector; struct sockaddr_in address; - SOCKADDR_STORAGE ss; + SOCKADDR_STORAGE ss, ss_empty; int socklen; select_thread_params thread_params; HANDLE thread_handle = NULL; @@ -4199,6 +4199,19 @@ static void test_accept(void) ok(accepted != INVALID_SOCKET, "Failed to accept connection, %d\n", WSAGetLastError()); ok(socklen != sizeof(ss), "unexpected length\n"); ok(ss.ss_family, "family not set\n"); + closesocket(accepted); + closesocket(connector); + accepted = connector = INVALID_SOCKET; + + socklen = sizeof(address); + connector = setup_connector_socket(&address, socklen, FALSE); + if (connector == INVALID_SOCKET) goto done; + + memset(&ss, 0, sizeof(ss)); + memset(&ss_empty, 0, sizeof(ss_empty)); + accepted = accept(server_socket, (struct sockaddr *)&ss, NULL); + ok(accepted != INVALID_SOCKET, "Failed to accept connection, %d\n", WSAGetLastError()); + ok(!memcmp(&ss, &ss_empty, sizeof(ss)), "structure is different\n"); done: if (accepted != INVALID_SOCKET)

1 0

Sebastian Lackner : server: Do not store unix_pid in process_snapshot struct.
by Alexandre Julliard Sept. 7, 2016

Sept. 7, 2016

Module: wine Branch: master Commit: 7c06f1c218a2ecb1f2dda2cfb97b3a2c5b7f01e8 URL: http://source.winehq.org/git/wine.git/?a=commit;h=7c06f1c218a2ecb1f2dda2cfb… Author: Sebastian Lackner <sebastian(a)fds-team.de> Date: Wed Sep 7 12:51:39 2016 +0200 server: Do not store unix_pid in process_snapshot struct. Signed-off-by: Sebastian Lackner <sebastian(a)fds-team.de> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- server/process.c | 1 - server/process.h | 1 - 2 files changed, 2 deletions(-) diff --git a/server/process.c b/server/process.c index 48ada99..2f2d1ad 100644 --- a/server/process.c +++ b/server/process.c @@ -1067,7 +1067,6 @@ struct process_snapshot *process_snap( int *count ) ptr->count = process->obj.refcount; ptr->priority = process->priority; ptr->handles = get_handle_table_count(process); - ptr->unix_pid = process->unix_pid; grab_object( process ); ptr++; } diff --git a/server/process.h b/server/process.h index eaa4adb..4e6de69 100644 --- a/server/process.h +++ b/server/process.h @@ -104,7 +104,6 @@ struct process_snapshot int threads; /* number of threads */ int priority; /* priority class */ int handles; /* number of handles */ - int unix_pid; /* Unix pid */ }; #define CPU_FLAG(cpu) (1 << (cpu))

1 0

André Hentschel : kernel32/tests: Allow ERROR_ACCESS_DENIED for GetThreadContext.
by Alexandre Julliard Sept. 7, 2016

Sept. 7, 2016

Module: wine Branch: master Commit: 59504204c338f6555114d045575156e7cb4f6f76 URL: http://source.winehq.org/git/wine.git/?a=commit;h=59504204c338f6555114d0455… Author: André Hentschel <nerv(a)dawncrow.de> Date: Tue Sep 6 19:06:12 2016 +0200 kernel32/tests: Allow ERROR_ACCESS_DENIED for GetThreadContext. Signed-off-by: André Hentschel <nerv(a)dawncrow.de> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/kernel32/tests/thread.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/kernel32/tests/thread.c b/dlls/kernel32/tests/thread.c index ac09bb8..001128b 100644 --- a/dlls/kernel32/tests/thread.c +++ b/dlls/kernel32/tests/thread.c @@ -1083,10 +1083,10 @@ static void test_SetThreadContext(void) ctx.ContextFlags = CONTEXT_FULL; SetLastError(0xdeadbeef); ret = GetThreadContext( thread, &ctx ); - ok( (!ret && (GetLastError() == ERROR_GEN_FAILURE)) || + ok( (!ret && ((GetLastError() == ERROR_GEN_FAILURE) || (GetLastError() == ERROR_ACCESS_DENIED))) || (!ret && broken(GetLastError() == ERROR_INVALID_HANDLE)) || /* win2k */ broken(ret), /* 32bit application on NT 5.x 64bit */ - "got %d with %u (expected FALSE with ERROR_GEN_FAILURE)\n", + "got %d with %u (expected FALSE with ERROR_GEN_FAILURE or ERROR_ACCESS_DENIED)\n", ret, GetLastError() ); SetLastError(0xdeadbeef);

1 0

Aric Stewart : ntoskrnl.exe: Implement IoGetAttachedDevice and IoGetAttachedDeviceReference.
by Alexandre Julliard Sept. 7, 2016

Sept. 7, 2016

Module: wine Branch: master Commit: 562ce28d1bc1ae2f88165fa18e84a2089735992f URL: http://source.winehq.org/git/wine.git/?a=commit;h=562ce28d1bc1ae2f88165fa18… Author: Aric Stewart <aric(a)codeweavers.com> Date: Wed Sep 7 11:21:22 2016 +0200 ntoskrnl.exe: Implement IoGetAttachedDevice and IoGetAttachedDeviceReference. Signed-off-by: Aric Stewart <aric(a)codeweavers.com> Signed-off-by: Sebastian Lackner <sebastian(a)fds-team.de> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ntoskrnl.exe/ntoskrnl.c | 31 +++++++++++++++++++++++++++---- dlls/ntoskrnl.exe/ntoskrnl.exe.spec | 2 +- 2 files changed, 28 insertions(+), 5 deletions(-) diff --git a/dlls/ntoskrnl.exe/ntoskrnl.c b/dlls/ntoskrnl.exe/ntoskrnl.c index b671e81..91e08d9 100644 --- a/dlls/ntoskrnl.exe/ntoskrnl.c +++ b/dlls/ntoskrnl.exe/ntoskrnl.c @@ -1105,13 +1105,19 @@ NTSTATUS WINAPI IoGetDeviceObjectPointer( UNICODE_STRING *name, ACCESS_MASK acc /*********************************************************************** * IoGetAttachedDevice (NTOSKRNL.EXE.@) */ -PDEVICE_OBJECT WINAPI IoGetAttachedDevice( PDEVICE_OBJECT device ) +DEVICE_OBJECT* WINAPI IoGetAttachedDevice( DEVICE_OBJECT *device ) { - FIXME( "stub: %p\n", device ); + DEVICE_OBJECT *result = device; - return device; + TRACE( "(%p)\n", device ); + + while (result->AttachedDevice) + result = result->AttachedDevice; + + return result; } + /*********************************************************************** * IoGetDeviceProperty (NTOSKRNL.EXE.@) */ @@ -2121,6 +2127,12 @@ NTSTATUS WINAPI ObReferenceObjectByName( UNICODE_STRING *ObjectName, } +static void ObReferenceObject( void *obj ) +{ + TRACE( "(%p): stub\n", obj ); +} + + /*********************************************************************** * ObDereferenceObject (NTOSKRNL.EXE.@) */ @@ -2140,7 +2152,7 @@ void WINAPI __regs_ObfReferenceObject( void *obj ) void WINAPI ObfReferenceObject( void *obj ) #endif { - FIXME( "(%p): stub\n", obj ); + ObReferenceObject( obj ); } @@ -2159,6 +2171,17 @@ void WINAPI ObfDereferenceObject( void *obj ) /*********************************************************************** + * IoGetAttachedDeviceReference (NTOSKRNL.EXE.@) + */ +DEVICE_OBJECT* WINAPI IoGetAttachedDeviceReference( DEVICE_OBJECT *device ) +{ + DEVICE_OBJECT *result = IoGetAttachedDevice( device ); + ObReferenceObject( result ); + return result; +} + + +/*********************************************************************** * PsCreateSystemThread (NTOSKRNL.EXE.@) */ NTSTATUS WINAPI PsCreateSystemThread(PHANDLE ThreadHandle, ULONG DesiredAccess, diff --git a/dlls/ntoskrnl.exe/ntoskrnl.exe.spec b/dlls/ntoskrnl.exe/ntoskrnl.exe.spec index c94b902..c1b5749 100644 --- a/dlls/ntoskrnl.exe/ntoskrnl.exe.spec +++ b/dlls/ntoskrnl.exe/ntoskrnl.exe.spec @@ -374,7 +374,7 @@ @ stdcall IoFreeMdl(ptr) @ stub IoFreeWorkItem @ stdcall IoGetAttachedDevice(ptr) -@ stub IoGetAttachedDeviceReference +@ stdcall IoGetAttachedDeviceReference(ptr) @ stub IoGetBaseFileSystemDeviceObject @ stub IoGetBootDiskInformation @ stdcall IoGetConfigurationInformation()

1 0

Sebastian Lackner : vcomp: Implement _vcomp_reduction_{u, i}4 and add tests.
by Alexandre Julliard Sept. 7, 2016

Sept. 7, 2016

Module: wine Branch: master Commit: 96e0c994b232dcd1def407d006d488483252c152 URL: http://source.winehq.org/git/wine.git/?a=commit;h=96e0c994b232dcd1def407d00… Author: Sebastian Lackner <sebastian(a)fds-team.de> Date: Wed Sep 7 10:56:01 2016 +0200 vcomp: Implement _vcomp_reduction_{u,i}4 and add tests. Signed-off-by: Sebastian Lackner <sebastian(a)fds-team.de> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/vcomp/main.c | 30 ++++++++++++++ dlls/vcomp/tests/vcomp.c | 95 +++++++++++++++++++++++++++++++++++++++++++++ dlls/vcomp/vcomp.spec | 4 +- dlls/vcomp100/vcomp100.spec | 4 +- dlls/vcomp110/vcomp110.spec | 4 +- dlls/vcomp120/vcomp120.spec | 4 +- dlls/vcomp140/vcomp140.spec | 4 +- dlls/vcomp90/vcomp90.spec | 4 +- 8 files changed, 137 insertions(+), 12 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=96e0c994b232dcd1def40…

1 0

Andrey Gusev : api-ms-win-core-localization-obsolete-l1-2-0: Add dll.
by Alexandre Julliard Sept. 7, 2016

Sept. 7, 2016

Module: wine Branch: master Commit: 8888459330028784a35c9a224697bcd94a1208a9 URL: http://source.winehq.org/git/wine.git/?a=commit;h=8888459330028784a35c9a224… Author: Andrey Gusev <andrey.goosev(a)gmail.com> Date: Wed Sep 7 12:28:18 2016 +0300 api-ms-win-core-localization-obsolete-l1-2-0: Add dll. Signed-off-by: Andrey Gusev <andrey.goosev(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- configure | 2 ++ configure.ac | 1 + dlls/api-ms-win-core-localization-obsolete-l1-2-0/Makefile.in | 1 + .../api-ms-win-core-localization-obsolete-l1-2-0.spec | 10 ++++++++++ tools/make_specfiles | 1 + 5 files changed, 15 insertions(+) diff --git a/configure b/configure index 3ed4a60..1fde1d0 100755 --- a/configure +++ b/configure @@ -908,6 +908,7 @@ enable_api_ms_win_core_localization_l1_1_0 enable_api_ms_win_core_localization_l1_2_0 enable_api_ms_win_core_localization_l1_2_1 enable_api_ms_win_core_localization_obsolete_l1_1_0 +enable_api_ms_win_core_localization_obsolete_l1_2_0 enable_api_ms_win_core_localregistry_l1_1_0 enable_api_ms_win_core_memory_l1_1_0 enable_api_ms_win_core_memory_l1_1_1 @@ -17455,6 +17456,7 @@ wine_fn_config_dll api-ms-win-core-localization-l1-1-0 enable_api_ms_win_core_lo wine_fn_config_dll api-ms-win-core-localization-l1-2-0 enable_api_ms_win_core_localization_l1_2_0 wine_fn_config_dll api-ms-win-core-localization-l1-2-1 enable_api_ms_win_core_localization_l1_2_1 wine_fn_config_dll api-ms-win-core-localization-obsolete-l1-1-0 enable_api_ms_win_core_localization_obsolete_l1_1_0 +wine_fn_config_dll api-ms-win-core-localization-obsolete-l1-2-0 enable_api_ms_win_core_localization_obsolete_l1_2_0 wine_fn_config_dll api-ms-win-core-localregistry-l1-1-0 enable_api_ms_win_core_localregistry_l1_1_0 wine_fn_config_dll api-ms-win-core-memory-l1-1-0 enable_api_ms_win_core_memory_l1_1_0 wine_fn_config_dll api-ms-win-core-memory-l1-1-1 enable_api_ms_win_core_memory_l1_1_1 diff --git a/configure.ac b/configure.ac index 8d5116c..52b217e 100644 --- a/configure.ac +++ b/configure.ac @@ -2673,6 +2673,7 @@ WINE_CONFIG_DLL(api-ms-win-core-localization-l1-1-0) WINE_CONFIG_DLL(api-ms-win-core-localization-l1-2-0) WINE_CONFIG_DLL(api-ms-win-core-localization-l1-2-1) WINE_CONFIG_DLL(api-ms-win-core-localization-obsolete-l1-1-0) +WINE_CONFIG_DLL(api-ms-win-core-localization-obsolete-l1-2-0) WINE_CONFIG_DLL(api-ms-win-core-localregistry-l1-1-0) WINE_CONFIG_DLL(api-ms-win-core-memory-l1-1-0) WINE_CONFIG_DLL(api-ms-win-core-memory-l1-1-1) diff --git a/dlls/api-ms-win-core-localization-obsolete-l1-2-0/Makefile.in b/dlls/api-ms-win-core-localization-obsolete-l1-2-0/Makefile.in new file mode 100644 index 0000000..f393ad0 --- /dev/null +++ b/dlls/api-ms-win-core-localization-obsolete-l1-2-0/Makefile.in @@ -0,0 +1 @@ +MODULE = api-ms-win-core-localization-obsolete-l1-2-0.dll diff --git a/dlls/api-ms-win-core-localization-obsolete-l1-2-0/api-ms-win-core-localization-obsolete-l1-2-0.spec b/dlls/api-ms-win-core-localization-obsolete-l1-2-0/api-ms-win-core-localization-obsolete-l1-2-0.spec new file mode 100644 index 0000000..541dbc9 --- /dev/null +++ b/dlls/api-ms-win-core-localization-obsolete-l1-2-0/api-ms-win-core-localization-obsolete-l1-2-0.spec @@ -0,0 +1,10 @@ +@ stdcall CompareStringA(long long str long str long) kernel32.CompareStringA +@ stdcall EnumLanguageGroupLocalesW(ptr long long ptr) kernel32.EnumLanguageGroupLocalesW +@ stdcall EnumSystemLanguageGroupsW(ptr long ptr) kernel32.EnumSystemLanguageGroupsW +@ stdcall EnumUILanguagesW(ptr long long) kernel32.EnumUILanguagesW +@ stdcall GetNumberFormatW(long long wstr ptr ptr long) kernel32.GetNumberFormatW +@ stdcall GetStringTypeA(long long str long ptr) kernel32.GetStringTypeA +@ stdcall GetSystemDefaultLocaleName(ptr long) kernel32.GetSystemDefaultLocaleName +@ stdcall GetSystemDefaultUILanguage() kernel32.GetSystemDefaultUILanguage +@ stdcall GetUserDefaultUILanguage() kernel32.GetUserDefaultUILanguage +@ stdcall LCIDToLocaleName(long ptr long long) kernel32.LCIDToLocaleName diff --git a/tools/make_specfiles b/tools/make_specfiles index 57287ea..1b81db3 100755 --- a/tools/make_specfiles +++ b/tools/make_specfiles @@ -162,6 +162,7 @@ my @dll_groups = "api-ms-win-core-localization-l1-1-0", "api-ms-win-core-localization-l1-2-0", "api-ms-win-core-localization-obsolete-l1-1-0", + "api-ms-win-core-localization-obsolete-l1-2-0", "api-ms-win-core-memory-l1-1-0", "api-ms-win-core-memory-l1-1-1", "api-ms-win-core-memory-l1-1-2",

1 0

Nikolay Sivov : d3d11/tests: Extend GetDC() tests.
by Alexandre Julliard Sept. 7, 2016

Sept. 7, 2016

Module: wine Branch: master Commit: 9b264ab3c5be48933adc3e143e797e06dfb3ed75 URL: http://source.winehq.org/git/wine.git/?a=commit;h=9b264ab3c5be48933adc3e143… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Tue Sep 6 14:41:19 2016 +0300 d3d11/tests: Extend GetDC() tests. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/d3d11/tests/Makefile.in | 2 +- dlls/d3d11/tests/d3d11.c | 169 ++++++++++++++++++++++++++++++++++++++----- 2 files changed, 152 insertions(+), 19 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=9b264ab3c5be48933adc3…

1 0

Sebastian Lackner : vcomp: Implement _vcomp_reduction_{u, i}2 and add tests.
by Alexandre Julliard Sept. 7, 2016

Sept. 7, 2016

Module: wine Branch: master Commit: 86dea350eac15f7dd8a276d937e3c087a8f6bfc9 URL: http://source.winehq.org/git/wine.git/?a=commit;h=86dea350eac15f7dd8a276d93… Author: Sebastian Lackner <sebastian(a)fds-team.de> Date: Wed Sep 7 10:56:08 2016 +0200 vcomp: Implement _vcomp_reduction_{u,i}2 and add tests. Signed-off-by: Sebastian Lackner <sebastian(a)fds-team.de> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/vcomp/main.c | 30 +++++++++++++++++++++++++++ dlls/vcomp/tests/vcomp.c | 49 +++++++++++++++++++++++++++++++++++++++++++++ dlls/vcomp/vcomp.spec | 4 ++-- dlls/vcomp100/vcomp100.spec | 4 ++-- dlls/vcomp110/vcomp110.spec | 4 ++-- dlls/vcomp120/vcomp120.spec | 4 ++-- dlls/vcomp140/vcomp140.spec | 4 ++-- dlls/vcomp90/vcomp90.spec | 4 ++-- 8 files changed, 91 insertions(+), 12 deletions(-) diff --git a/dlls/vcomp/main.c b/dlls/vcomp/main.c index 53ad28a..a3a29db 100644 --- a/dlls/vcomp/main.c +++ b/dlls/vcomp/main.c @@ -516,6 +516,36 @@ void CDECL _vcomp_atomic_xor_i2(short *dest, short val) do old = *dest; while (interlocked_cmpxchg16(dest, old ^ val, old) != old); } +static void CDECL _vcomp_atomic_bool_and_i2(short *dest, short val) +{ + short old; + do old = *dest; while (interlocked_cmpxchg16(dest, old && val, old) != old); +} + +static void CDECL _vcomp_atomic_bool_or_i2(short *dest, short val) +{ + short old; + do old = *dest; while (interlocked_cmpxchg16(dest, old ? old : (val != 0), old) != old); +} + +void CDECL _vcomp_reduction_i2(unsigned int flags, short *dest, short val) +{ + static void (CDECL * const funcs[])(short *, short) = + { + _vcomp_atomic_add_i2, + _vcomp_atomic_add_i2, + _vcomp_atomic_mul_i2, + _vcomp_atomic_and_i2, + _vcomp_atomic_or_i2, + _vcomp_atomic_xor_i2, + _vcomp_atomic_bool_and_i2, + _vcomp_atomic_bool_or_i2, + }; + unsigned int op = (flags >> 8) & 0xf; + op = min(op, sizeof(funcs)/sizeof(funcs[0]) - 1); + funcs[op](dest, val); +} + void CDECL _vcomp_atomic_add_i4(int *dest, int val) { interlocked_xchg_add(dest, val); diff --git a/dlls/vcomp/tests/vcomp.c b/dlls/vcomp/tests/vcomp.c index dc84f98..5911601 100644 --- a/dlls/vcomp/tests/vcomp.c +++ b/dlls/vcomp/tests/vcomp.c @@ -103,7 +103,9 @@ static int (CDECL *p_vcomp_get_thread_num)(void); static void (CDECL *p_vcomp_leave_critsect)(CRITICAL_SECTION *critsect); static int (CDECL *p_vcomp_master_begin)(void); static void (CDECL *p_vcomp_master_end)(void); +static void (CDECL *p_vcomp_reduction_i2)(unsigned int flags, short *dest, short val); static void (CDECL *p_vcomp_reduction_i4)(unsigned int flags, int *dest, int val); +static void (CDECL *p_vcomp_reduction_u2)(unsigned int flags, unsigned short *dest, unsigned short val); static void (CDECL *p_vcomp_reduction_u4)(unsigned int flags, unsigned int *dest, unsigned int val); static void (CDECL *p_vcomp_sections_init)(int n); static int (CDECL *p_vcomp_sections_next)(void); @@ -346,7 +348,9 @@ static BOOL init_vcomp(void) VCOMP_GET_PROC(_vcomp_leave_critsect); VCOMP_GET_PROC(_vcomp_master_begin); VCOMP_GET_PROC(_vcomp_master_end); + VCOMP_GET_PROC(_vcomp_reduction_i2); VCOMP_GET_PROC(_vcomp_reduction_i4); + VCOMP_GET_PROC(_vcomp_reduction_u2); VCOMP_GET_PROC(_vcomp_reduction_u4); VCOMP_GET_PROC(_vcomp_sections_init); VCOMP_GET_PROC(_vcomp_sections_next); @@ -1883,6 +1887,50 @@ static void test_atomic_double(void) } } +static void test_reduction_integer16(void) +{ + struct + { + unsigned int flags; + short v1, v2, expected; + } + tests[] = + { + { 0x000, 0x1122, 0x7766, -0x7778 }, + { VCOMP_REDUCTION_FLAGS_ADD, 0x1122, 0x7766, -0x7778 }, + { VCOMP_REDUCTION_FLAGS_MUL, 0x1122, 0x7766, -0x5e74 }, + { VCOMP_REDUCTION_FLAGS_MUL, 0x1122, -0x7766, 0x5e74 }, + { VCOMP_REDUCTION_FLAGS_AND, 0x1122, 0x7766, 0x1122 }, + { VCOMP_REDUCTION_FLAGS_OR, 0x1122, 0x7766, 0x7766 }, + { VCOMP_REDUCTION_FLAGS_XOR, 0x1122, 0x7766, 0x6644 }, + { VCOMP_REDUCTION_FLAGS_BOOL_AND, 1, 2, 1 }, + { VCOMP_REDUCTION_FLAGS_BOOL_OR, 0, 2, 1 }, + { 0x800, 0, 2, 1 }, + { 0x900, 0, 2, 1 }, + { 0xa00, 0, 2, 1 }, + { 0xb00, 0, 2, 1 }, + { 0xc00, 0, 2, 1 }, + { 0xd00, 0, 2, 1 }, + { 0xe00, 0, 2, 1 }, + { 0xf00, 0, 2, 1 }, + }; + int i; + + for (i = 0; i < sizeof(tests)/sizeof(tests[0]); i++) + { + short val = tests[i].v1; + p_vcomp_reduction_i2(tests[i].flags, &val, tests[i].v2); + ok(val == tests[i].expected, "test %d: expected val == %d, got %d\n", i, tests[i].expected, val); + } + for (i = 0; i < sizeof(tests)/sizeof(tests[0]); i++) + { + unsigned short val = tests[i].v1; + p_vcomp_reduction_u2(tests[i].flags, &val, tests[i].v2); + ok(val == (unsigned short)tests[i].expected, + "test %d: expected val == %u, got %u\n", i, (unsigned short)tests[i].expected, val); + } +} + static void CDECL reduction_cb(int *a, int *b) { p_vcomp_reduction_i4(VCOMP_REDUCTION_FLAGS_ADD, a, 1); @@ -1989,6 +2037,7 @@ START_TEST(vcomp) test_atomic_integer64(); test_atomic_float(); test_atomic_double(); + test_reduction_integer16(); test_reduction_integer32(); release_vcomp(); diff --git a/dlls/vcomp/vcomp.spec b/dlls/vcomp/vcomp.spec index ddb35b8..85df49e 100644 --- a/dlls/vcomp/vcomp.spec +++ b/dlls/vcomp/vcomp.spec @@ -74,13 +74,13 @@ @ stub _vcomp_ordered_end @ stub _vcomp_ordered_loop_end @ stub _vcomp_reduction_i1 -@ stub _vcomp_reduction_i2 +@ cdecl _vcomp_reduction_i2(long ptr long) @ cdecl _vcomp_reduction_i4(long ptr long) @ stub _vcomp_reduction_i8 @ stub _vcomp_reduction_r4 @ stub _vcomp_reduction_r8 @ stub _vcomp_reduction_u1 -@ stub _vcomp_reduction_u2 +@ cdecl _vcomp_reduction_u2(long ptr long) _vcomp_reduction_i2 @ cdecl _vcomp_reduction_u4(long ptr long) _vcomp_reduction_i4 @ stub _vcomp_reduction_u8 @ cdecl _vcomp_sections_init(long) diff --git a/dlls/vcomp100/vcomp100.spec b/dlls/vcomp100/vcomp100.spec index 92f6a9d..49f5a1b 100644 --- a/dlls/vcomp100/vcomp100.spec +++ b/dlls/vcomp100/vcomp100.spec @@ -74,13 +74,13 @@ @ stub _vcomp_ordered_end @ stub _vcomp_ordered_loop_end @ stub _vcomp_reduction_i1 -@ stub _vcomp_reduction_i2 +@ cdecl _vcomp_reduction_i2(long ptr long) vcomp._vcomp_reduction_i2 @ cdecl _vcomp_reduction_i4(long ptr long) vcomp._vcomp_reduction_i4 @ stub _vcomp_reduction_i8 @ stub _vcomp_reduction_r4 @ stub _vcomp_reduction_r8 @ stub _vcomp_reduction_u1 -@ stub _vcomp_reduction_u2 +@ cdecl _vcomp_reduction_u2(long ptr long) vcomp._vcomp_reduction_u2 @ cdecl _vcomp_reduction_u4(long ptr long) vcomp._vcomp_reduction_u4 @ stub _vcomp_reduction_u8 @ cdecl _vcomp_sections_init(long) vcomp._vcomp_sections_init diff --git a/dlls/vcomp110/vcomp110.spec b/dlls/vcomp110/vcomp110.spec index cb2a21d..dd9537a 100644 --- a/dlls/vcomp110/vcomp110.spec +++ b/dlls/vcomp110/vcomp110.spec @@ -75,13 +75,13 @@ @ stub _vcomp_ordered_end @ stub _vcomp_ordered_loop_end @ stub _vcomp_reduction_i1 -@ stub _vcomp_reduction_i2 +@ cdecl _vcomp_reduction_i2(long ptr long) vcomp._vcomp_reduction_i2 @ cdecl _vcomp_reduction_i4(long ptr long) vcomp._vcomp_reduction_i4 @ stub _vcomp_reduction_i8 @ stub _vcomp_reduction_r4 @ stub _vcomp_reduction_r8 @ stub _vcomp_reduction_u1 -@ stub _vcomp_reduction_u2 +@ cdecl _vcomp_reduction_u2(long ptr long) vcomp._vcomp_reduction_u2 @ cdecl _vcomp_reduction_u4(long ptr long) vcomp._vcomp_reduction_u4 @ stub _vcomp_reduction_u8 @ cdecl _vcomp_sections_init(long) vcomp._vcomp_sections_init diff --git a/dlls/vcomp120/vcomp120.spec b/dlls/vcomp120/vcomp120.spec index cb2a21d..dd9537a 100644 --- a/dlls/vcomp120/vcomp120.spec +++ b/dlls/vcomp120/vcomp120.spec @@ -75,13 +75,13 @@ @ stub _vcomp_ordered_end @ stub _vcomp_ordered_loop_end @ stub _vcomp_reduction_i1 -@ stub _vcomp_reduction_i2 +@ cdecl _vcomp_reduction_i2(long ptr long) vcomp._vcomp_reduction_i2 @ cdecl _vcomp_reduction_i4(long ptr long) vcomp._vcomp_reduction_i4 @ stub _vcomp_reduction_i8 @ stub _vcomp_reduction_r4 @ stub _vcomp_reduction_r8 @ stub _vcomp_reduction_u1 -@ stub _vcomp_reduction_u2 +@ cdecl _vcomp_reduction_u2(long ptr long) vcomp._vcomp_reduction_u2 @ cdecl _vcomp_reduction_u4(long ptr long) vcomp._vcomp_reduction_u4 @ stub _vcomp_reduction_u8 @ cdecl _vcomp_sections_init(long) vcomp._vcomp_sections_init diff --git a/dlls/vcomp140/vcomp140.spec b/dlls/vcomp140/vcomp140.spec index cb2a21d..dd9537a 100644 --- a/dlls/vcomp140/vcomp140.spec +++ b/dlls/vcomp140/vcomp140.spec @@ -75,13 +75,13 @@ @ stub _vcomp_ordered_end @ stub _vcomp_ordered_loop_end @ stub _vcomp_reduction_i1 -@ stub _vcomp_reduction_i2 +@ cdecl _vcomp_reduction_i2(long ptr long) vcomp._vcomp_reduction_i2 @ cdecl _vcomp_reduction_i4(long ptr long) vcomp._vcomp_reduction_i4 @ stub _vcomp_reduction_i8 @ stub _vcomp_reduction_r4 @ stub _vcomp_reduction_r8 @ stub _vcomp_reduction_u1 -@ stub _vcomp_reduction_u2 +@ cdecl _vcomp_reduction_u2(long ptr long) vcomp._vcomp_reduction_u2 @ cdecl _vcomp_reduction_u4(long ptr long) vcomp._vcomp_reduction_u4 @ stub _vcomp_reduction_u8 @ cdecl _vcomp_sections_init(long) vcomp._vcomp_sections_init diff --git a/dlls/vcomp90/vcomp90.spec b/dlls/vcomp90/vcomp90.spec index 92f6a9d..49f5a1b 100644 --- a/dlls/vcomp90/vcomp90.spec +++ b/dlls/vcomp90/vcomp90.spec @@ -74,13 +74,13 @@ @ stub _vcomp_ordered_end @ stub _vcomp_ordered_loop_end @ stub _vcomp_reduction_i1 -@ stub _vcomp_reduction_i2 +@ cdecl _vcomp_reduction_i2(long ptr long) vcomp._vcomp_reduction_i2 @ cdecl _vcomp_reduction_i4(long ptr long) vcomp._vcomp_reduction_i4 @ stub _vcomp_reduction_i8 @ stub _vcomp_reduction_r4 @ stub _vcomp_reduction_r8 @ stub _vcomp_reduction_u1 -@ stub _vcomp_reduction_u2 +@ cdecl _vcomp_reduction_u2(long ptr long) vcomp._vcomp_reduction_u2 @ cdecl _vcomp_reduction_u4(long ptr long) vcomp._vcomp_reduction_u4 @ stub _vcomp_reduction_u8 @ cdecl _vcomp_sections_init(long) vcomp._vcomp_sections_init

1 0

Nikolay Sivov : dbghelp: Support CIE version 4 in parse_cie_details().
by Alexandre Julliard Sept. 7, 2016

Sept. 7, 2016

Module: wine Branch: master Commit: ab27cb48fc6bc0a11bff05f0be49b8befc3718e4 URL: http://source.winehq.org/git/wine.git/?a=commit;h=ab27cb48fc6bc0a11bff05f0b… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Wed Sep 7 01:43:27 2016 +0300 dbghelp: Support CIE version 4 in parse_cie_details(). Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/dbghelp/dwarf.c | 23 ++++++++++++++++------- 1 file changed, 16 insertions(+), 7 deletions(-) diff --git a/dlls/dbghelp/dwarf.c b/dlls/dbghelp/dwarf.c index dcbcf0a..3fd1920 100644 --- a/dlls/dbghelp/dwarf.c +++ b/dlls/dbghelp/dwarf.c @@ -2641,7 +2641,7 @@ static BOOL parse_cie_details(dwarf2_traverse_context_t* ctx, struct frame_info* /* parse the CIE first */ version = dwarf2_parse_byte(ctx); - if (version != 1 && version != 3) + if (version != 1 && version != 3 && version != 4) { FIXME("unknown CIE version %u at %p\n", version, ctx->data - 1); return FALSE; @@ -2649,12 +2649,21 @@ static BOOL parse_cie_details(dwarf2_traverse_context_t* ctx, struct frame_info* augmentation = (const char*)ctx->data; ctx->data += strlen(augmentation) + 1; - info->code_align = dwarf2_leb128_as_unsigned(ctx); - info->data_align = dwarf2_leb128_as_signed(ctx); - if (version == 1) - info->retaddr_reg = dwarf2_parse_byte(ctx); - else - info->retaddr_reg = dwarf2_leb128_as_unsigned(ctx); + switch (version) + { + case 4: + /* skip 'address_size' and 'segment_size' */ + ctx->data += 2; + /* fallthrough */ + case 1: + case 3: + info->code_align = dwarf2_leb128_as_unsigned(ctx); + info->data_align = dwarf2_leb128_as_signed(ctx); + info->retaddr_reg = version == 1 ? dwarf2_parse_byte(ctx) :dwarf2_leb128_as_unsigned(ctx); + break; + default: + ; + } info->state.cfa_rule = RULE_CFA_OFFSET; end = NULL;

1 0

Bruno Jesus : ws2_32: Debug the ioctl code name whenever possible.
by Alexandre Julliard Sept. 7, 2016

Sept. 7, 2016

Module: wine Branch: master Commit: 048964b40e1518c985e907d99ec606b4dd619444 URL: http://source.winehq.org/git/wine.git/?a=commit;h=048964b40e1518c985e907d99… Author: Bruno Jesus <00cpxxx(a)gmail.com> Date: Tue Sep 6 15:30:35 2016 -0300 ws2_32: Debug the ioctl code name whenever possible. Signed-off-by: Bruno Jesus <00cpxxx(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ws2_32/socket.c | 68 +++++++++++++++++++++++++++++++++++++++++++++------- 1 file changed, 59 insertions(+), 9 deletions(-) diff --git a/dlls/ws2_32/socket.c b/dlls/ws2_32/socket.c index 79ccfc2..ccd50f8 100644 --- a/dlls/ws2_32/socket.c +++ b/dlls/ws2_32/socket.c @@ -4393,11 +4393,61 @@ char* WINAPI WS_inet_ntoa(struct WS_in_addr in) return data->ntoa_buffer; } -static const char *debugstr_wsaioctl(DWORD ioctl) +static const char *debugstr_wsaioctl(DWORD code) { - const char *buf_type, *family; + const char *name = NULL, *buf_type, *family; - switch(ioctl & 0x18000000) +#define IOCTL_NAME(x) case x: name = #x; break + switch (code) + { + IOCTL_NAME(WS_FIONBIO); + IOCTL_NAME(WS_FIONREAD); + IOCTL_NAME(WS_SIOCATMARK); + /* IOCTL_NAME(WS_SIO_ACQUIRE_PORT_RESERVATION); */ + IOCTL_NAME(WS_SIO_ADDRESS_LIST_CHANGE); + IOCTL_NAME(WS_SIO_ADDRESS_LIST_QUERY); + IOCTL_NAME(WS_SIO_ASSOCIATE_HANDLE); + /* IOCTL_NAME(WS_SIO_ASSOCIATE_PORT_RESERVATION); + IOCTL_NAME(WS_SIO_BASE_HANDLE); + IOCTL_NAME(WS_SIO_BSP_HANDLE); + IOCTL_NAME(WS_SIO_BSP_HANDLE_SELECT); + IOCTL_NAME(WS_SIO_BSP_HANDLE_POLL); + IOCTL_NAME(WS_SIO_CHK_QOS); */ + IOCTL_NAME(WS_SIO_ENABLE_CIRCULAR_QUEUEING); + IOCTL_NAME(WS_SIO_FIND_ROUTE); + IOCTL_NAME(WS_SIO_FLUSH); + IOCTL_NAME(WS_SIO_GET_BROADCAST_ADDRESS); + IOCTL_NAME(WS_SIO_GET_EXTENSION_FUNCTION_POINTER); + IOCTL_NAME(WS_SIO_GET_GROUP_QOS); + IOCTL_NAME(WS_SIO_GET_INTERFACE_LIST); + /* IOCTL_NAME(WS_SIO_GET_INTERFACE_LIST_EX); */ + IOCTL_NAME(WS_SIO_GET_QOS); + /* IOCTL_NAME(WS_SIO_IDEAL_SEND_BACKLOG_CHANGE); + IOCTL_NAME(WS_SIO_IDEAL_SEND_BACKLOG_QUERY); */ + IOCTL_NAME(WS_SIO_KEEPALIVE_VALS); + IOCTL_NAME(WS_SIO_MULTIPOINT_LOOPBACK); + IOCTL_NAME(WS_SIO_MULTICAST_SCOPE); + /* IOCTL_NAME(WS_SIO_QUERY_RSS_SCALABILITY_INFO); + IOCTL_NAME(WS_SIO_QUERY_WFP_ALE_ENDPOINT_HANDLE); */ + IOCTL_NAME(WS_SIO_RCVALL); + IOCTL_NAME(WS_SIO_RCVALL_IGMPMCAST); + IOCTL_NAME(WS_SIO_RCVALL_MCAST); + /* IOCTL_NAME(WS_SIO_RELEASE_PORT_RESERVATION); */ + IOCTL_NAME(WS_SIO_ROUTING_INTERFACE_CHANGE); + IOCTL_NAME(WS_SIO_ROUTING_INTERFACE_QUERY); + IOCTL_NAME(WS_SIO_SET_COMPATIBILITY_MODE); + IOCTL_NAME(WS_SIO_SET_GROUP_QOS); + IOCTL_NAME(WS_SIO_SET_QOS); + IOCTL_NAME(WS_SIO_TRANSLATE_HANDLE); + IOCTL_NAME(WS_SIO_UDP_CONNRESET); + } +#undef IOCTL_NAME + + if (name) + return name + 3; + + /* If this is not a known code split its bits */ + switch(code & 0x18000000) { case WS_IOC_WS2: family = "IOC_WS2"; @@ -4410,12 +4460,12 @@ static const char *debugstr_wsaioctl(DWORD ioctl) break; default: /* WS_IOC_UNIX */ { - BYTE size = (ioctl >> 16) & WS_IOCPARM_MASK; - char x = (ioctl & 0xff00) >> 8; - BYTE y = ioctl & 0xff; + BYTE size = (code >> 16) & WS_IOCPARM_MASK; + char x = (code & 0xff00) >> 8; + BYTE y = code & 0xff; char args[14]; - switch (ioctl & (WS_IOC_VOID|WS_IOC_INOUT)) + switch (code & (WS_IOC_VOID|WS_IOC_INOUT)) { case WS_IOC_VOID: buf_type = "_IO"; @@ -4439,7 +4489,7 @@ static const char *debugstr_wsaioctl(DWORD ioctl) } /* We are different from WS_IOC_UNIX. */ - switch (ioctl & (WS_IOC_VOID|WS_IOC_INOUT)) + switch (code & (WS_IOC_VOID|WS_IOC_INOUT)) { case WS_IOC_VOID: buf_type = "_WSAIO"; @@ -4459,7 +4509,7 @@ static const char *debugstr_wsaioctl(DWORD ioctl) } return wine_dbg_sprintf("%s(%s, %d)", buf_type, family, - (USHORT)(ioctl & 0xffff)); + (USHORT)(code & 0xffff)); } /* do an ioctl call through the server */

1 0