November 2017 - Wine-Commits

Andrew Eikum : explorer: Don't leak PIDL.
by Alexandre Julliard Nov. 9, 2017

Nov. 9, 2017

Module: wine Branch: master Commit: a484bf495e83f873fee2aa1729769323684488bb URL: http://source.winehq.org/git/wine.git/?a=commit;h=a484bf495e83f873fee2aa172… Author: Andrew Eikum <aeikum(a)codeweavers.com> Date: Thu Nov 9 08:43:10 2017 -0600 explorer: Don't leak PIDL. Signed-off-by: Andrew Eikum <aeikum(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- programs/explorer/explorer.c | 1 + 1 file changed, 1 insertion(+) diff --git a/programs/explorer/explorer.c b/programs/explorer/explorer.c index cc3244d..5144e74 100644 --- a/programs/explorer/explorer.c +++ b/programs/explorer/explorer.c @@ -609,6 +609,7 @@ static IShellFolder* get_starting_shell_folder(parameters_struct* params) hres = IShellFolder_BindToObject(desktop,root_pidl,NULL, &IID_IShellFolder, (void**)&folder); + ILFree(root_pidl); if(FAILED(hres)) { return desktop;

1 0

Ziqing Hui : mlang: Fix font name of Chinese code pages.
by Alexandre Julliard Nov. 9, 2017

Nov. 9, 2017

Module: wine Branch: master Commit: 1f88a35a90ae2199ab14cab732f191982c5f2e24 URL: http://source.winehq.org/git/wine.git/?a=commit;h=1f88a35a90ae2199ab14cab73… Author: Ziqing Hui <zhui(a)codeweavers.com> Date: Thu Nov 9 21:17:35 2017 +0800 mlang: Fix font name of Chinese code pages. Signed-off-by: Ziqing Hui <zhui(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mlang/mlang.c | 4 ++-- dlls/mlang/tests/mlang.c | 2 -- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/dlls/mlang/mlang.c b/dlls/mlang/mlang.c index d9a167a..9c76c11 100644 --- a/dlls/mlang/mlang.c +++ b/dlls/mlang/mlang.c @@ -470,9 +470,9 @@ static const struct mlang_data { "Baltic",1257,sizeof(baltic_cp)/sizeof(baltic_cp[0]),baltic_cp, "Courier","Arial", sidAsciiLatin }, /* FIXME */ { "Chinese Simplified",936,sizeof(chinese_simplified_cp)/sizeof(chinese_simplified_cp[0]),chinese_simplified_cp, - "Courier","Arial", sidHan }, /* FIXME */ + "Simsun","Simsun", sidHan }, { "Chinese Traditional",950,sizeof(chinese_traditional_cp)/sizeof(chinese_traditional_cp[0]),chinese_traditional_cp, - "Courier","Arial", sidBopomofo }, /* FIXME */ + "MingLiu","New MingLiu", sidBopomofo }, { "Central European",1250,sizeof(central_european_cp)/sizeof(central_european_cp[0]),central_european_cp, "Courier","Arial", sidAsciiLatin }, /* FIXME */ { "Cyrillic",1251,sizeof(cyrillic_cp)/sizeof(cyrillic_cp[0]),cyrillic_cp, diff --git a/dlls/mlang/tests/mlang.c b/dlls/mlang/tests/mlang.c index 80dcd75..ffa422c 100644 --- a/dlls/mlang/tests/mlang.c +++ b/dlls/mlang/tests/mlang.c @@ -269,7 +269,6 @@ const static struct cpinfo_test_data iml2_cpinfo_data[] = {'S','i','m','s','u','n',0}, {'S','i','m','s','u','n',0}, 134 }, - FALSE, FALSE, FALSE, FALSE, FALSE, FALSE, FALSE, TRUE, TRUE }, /* 2. Chinese Simplified (GB2312-80) */ { @@ -341,7 +340,6 @@ const static struct cpinfo_test_data iml2_cpinfo_data[] = {'M','i','n','g','L','i','u',0}, {'N','e','w',' ','M','i','n','g','L','i','u',0}, 136 }, - FALSE, FALSE, FALSE, FALSE, FALSE, FALSE, FALSE, TRUE, TRUE }, /* 7. Chinese Traditional (CNS) */ {

1 0

Alex Henrie : d3dx9/tests: Provide 8 significant digits in matrix reference values.
by Alexandre Julliard Nov. 9, 2017

Nov. 9, 2017

Module: wine Branch: master Commit: 79b6035441981b5833b57e21114b80819d4eb0b4 URL: http://source.winehq.org/git/wine.git/?a=commit;h=79b6035441981b5833b57e211… Author: Alex Henrie <alexhenrie24(a)gmail.com> Date: Thu Nov 9 06:05:51 2017 -0700 d3dx9/tests: Provide 8 significant digits in matrix reference values. Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> Signed-off-by: Matteo Bruni <mbruni(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/d3dx9_36/tests/math.c | 130 ++++++++++++++++++++++----------------------- 1 file changed, 65 insertions(+), 65 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=79b6035441981b5833b57…

1 0

Lauri Kenttä : po: Update Finnish translation.
by Alexandre Julliard Nov. 9, 2017

Nov. 9, 2017

Module: wine Branch: master Commit: 0346738b717007ab275c449f931f498fae8ae2c8 URL: http://source.winehq.org/git/wine.git/?a=commit;h=0346738b717007ab275c449f9… Author: Lauri Kenttä <lauri.kentta(a)gmail.com> Date: Thu Nov 9 17:48:53 2017 +0200 po: Update Finnish translation. Signed-off-by: Lauri Kenttä <lauri.kentta(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- po/fi.po | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/po/fi.po b/po/fi.po index aaf7ee3..4ae368a 100644 --- a/po/fi.po +++ b/po/fi.po @@ -14869,10 +14869,8 @@ msgid "Expert" msgstr "Ekspertti" #: winemine.rc:72 -#, fuzzy -#| msgid "Result" msgid "Reset Results" -msgstr "Tulos" +msgstr "Poista tulokset" #: winemine.rc:78 msgid "Congratulations!"

1 0

Andrey Gusev : d3dx10: Add D3DX10PreprocessShaderFromMemory stub.
by Alexandre Julliard Nov. 9, 2017

Nov. 9, 2017

Module: wine Branch: master Commit: 010119085b4cee3d7edbad2c5a46d35daa95000d URL: http://source.winehq.org/git/wine.git/?a=commit;h=010119085b4cee3d7edbad2c5… Author: Andrey Gusev <andrey.goosev(a)gmail.com> Date: Thu Nov 9 16:25:05 2017 +0200 d3dx10: Add D3DX10PreprocessShaderFromMemory stub. Signed-off-by: Andrey Gusev <andrey.goosev(a)gmail.com> Signed-off-by: Matteo Bruni <mbruni(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/d3dx10_43/async.c | 11 +++++++++++ dlls/d3dx10_43/d3dx10_43.spec | 2 +- include/d3dx10async.h | 4 ++++ 3 files changed, 16 insertions(+), 1 deletion(-) diff --git a/dlls/d3dx10_43/async.c b/dlls/d3dx10_43/async.c index c638904..c910b4a 100644 --- a/dlls/d3dx10_43/async.c +++ b/dlls/d3dx10_43/async.c @@ -397,3 +397,14 @@ HRESULT WINAPI D3DX10CreateAsyncResourceLoaderW(HMODULE module, const WCHAR *res return S_OK; } + +HRESULT WINAPI D3DX10PreprocessShaderFromMemory(const char *data, SIZE_T data_size, const char *filename, + const D3D10_SHADER_MACRO *defines, ID3DInclude *include, ID3DX10ThreadPump *pump, ID3D10Blob **shader_text, + ID3D10Blob **errors, HRESULT *hresult) +{ + FIXME("data %s, data_size %lu, filename %s, defines %p, include %p, pump %p, shader_text %p, errors %p, " + "hresult %p stub!\n", + debugstr_a(data), data_size, debugstr_a(filename), defines, include, pump, shader_text, errors, hresult); + + return E_NOTIMPL; +} diff --git a/dlls/d3dx10_43/d3dx10_43.spec b/dlls/d3dx10_43/d3dx10_43.spec index 49a6d3a..a36220f 100644 --- a/dlls/d3dx10_43/d3dx10_43.spec +++ b/dlls/d3dx10_43/d3dx10_43.spec @@ -57,7 +57,7 @@ @ stub D3DX10LoadTextureFromTexture(ptr ptr ptr) @ stub D3DX10PreprocessShaderFromFileA(str ptr ptr ptr ptr ptr) @ stub D3DX10PreprocessShaderFromFileW(wstr ptr ptr ptr ptr ptr) -@ stub D3DX10PreprocessShaderFromMemory(str long str ptr ptr ptr ptr ptr) +@ stdcall D3DX10PreprocessShaderFromMemory(str long str ptr ptr ptr ptr ptr ptr) @ stub D3DX10PreprocessShaderFromResourceA(long str str ptr ptr ptr ptr ptr) @ stub D3DX10PreprocessShaderFromResourceW(long wstr wstr ptr ptr ptr ptr ptr) @ stub D3DX10SHProjectCubeMap(long ptr ptr ptr ptr) diff --git a/include/d3dx10async.h b/include/d3dx10async.h index 6663be4..c8204bc 100644 --- a/include/d3dx10async.h +++ b/include/d3dx10async.h @@ -54,6 +54,10 @@ HRESULT WINAPI D3DX10CreateEffectPoolFromMemory(const void *data, SIZE_T datasiz UINT fxflags, ID3D10Device *device, ID3DX10ThreadPump *pump, ID3D10EffectPool **effectpool, ID3D10Blob **errors, HRESULT *hresult); +HRESULT WINAPI D3DX10PreprocessShaderFromMemory(const char *data, SIZE_T data_size, const char *filename, + const D3D10_SHADER_MACRO *defines, ID3DInclude *include, ID3DX10ThreadPump *pump, ID3D10Blob **shader_text, + ID3D10Blob **errors, HRESULT *hresult); + HRESULT WINAPI D3DX10CreateAsyncFileLoaderW(const WCHAR *filename, ID3DX10DataLoader **loader); HRESULT WINAPI D3DX10CreateAsyncFileLoaderA(const char *filename, ID3DX10DataLoader **loader); HRESULT WINAPI D3DX10CreateAsyncMemoryLoader(const void *data, SIZE_T datasize, ID3DX10DataLoader **loader);

1 0

Ziqing Hui : mlang/tests: Add IMultiLanguage2_GetCodePageInfo tests.
by Alexandre Julliard Nov. 9, 2017

Nov. 9, 2017

Module: wine Branch: master Commit: 4d84d0bc2f2e3c9f2e07c62a499aa2c7de40a507 URL: http://source.winehq.org/git/wine.git/?a=commit;h=4d84d0bc2f2e3c9f2e07c62a4… Author: Ziqing Hui <zhui(a)codeweavers.com> Date: Thu Nov 9 21:17:23 2017 +0800 mlang/tests: Add IMultiLanguage2_GetCodePageInfo tests. Signed-off-by: Ziqing Hui <zhui(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mlang/tests/mlang.c | 208 +++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 208 insertions(+) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=4d84d0bc2f2e3c9f2e07c…

1 0

Alistair Leslie-Hughes : quartz: Output This in TRACE statements.
by Alexandre Julliard Nov. 9, 2017

Nov. 9, 2017

Module: wine Branch: master Commit: e317164f8fea0910626cb2010613caa9c9c08e47 URL: http://source.winehq.org/git/wine.git/?a=commit;h=e317164f8fea0910626cb2010… Author: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Date: Thu Nov 9 00:12:20 2017 +0000 quartz: Output This in TRACE statements. Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/quartz/filesource.c | 36 ++++++++++++++++++++---------------- 1 file changed, 20 insertions(+), 16 deletions(-) diff --git a/dlls/quartz/filesource.c b/dlls/quartz/filesource.c index 4154512..4290ac3 100644 --- a/dlls/quartz/filesource.c +++ b/dlls/quartz/filesource.c @@ -391,6 +391,8 @@ static IPin* WINAPI AsyncReader_GetPin(BaseFilter *iface, int pos) { AsyncReader *This = impl_from_BaseFilter(iface); + TRACE("%p->(%d)\n", This, pos); + if (pos >= 1 || !This->pOutputPin) return NULL; @@ -402,6 +404,8 @@ static LONG WINAPI AsyncReader_GetPinCount(BaseFilter *iface) { AsyncReader *This = impl_from_BaseFilter(iface); + TRACE("%p->()\n", This); + if (!This->pOutputPin) return 0; else @@ -447,7 +451,7 @@ static HRESULT WINAPI AsyncReader_QueryInterface(IBaseFilter * iface, REFIID rii { AsyncReader *This = impl_from_IBaseFilter(iface); - TRACE("(%s, %p)\n", qzdebugstr_guid(riid), ppv); + TRACE("%p->(%s, %p)\n", This, qzdebugstr_guid(riid), ppv); *ppv = NULL; @@ -482,7 +486,7 @@ static ULONG WINAPI AsyncReader_Release(IBaseFilter * iface) AsyncReader *This = impl_from_IBaseFilter(iface); ULONG refCount = InterlockedDecrement(&This->filter.refCount); - TRACE("(%p)->() Release from %d\n", This, refCount + 1); + TRACE("%p->() Release from %d\n", This, refCount + 1); if (!refCount) { @@ -514,7 +518,7 @@ static HRESULT WINAPI AsyncReader_Stop(IBaseFilter * iface) { AsyncReader *This = impl_from_IBaseFilter(iface); - TRACE("()\n"); + TRACE("%p->()\n", This); This->filter.state = State_Stopped; @@ -525,7 +529,7 @@ static HRESULT WINAPI AsyncReader_Pause(IBaseFilter * iface) { AsyncReader *This = impl_from_IBaseFilter(iface); - TRACE("()\n"); + TRACE("%p->()\n", This); This->filter.state = State_Paused; @@ -536,7 +540,7 @@ static HRESULT WINAPI AsyncReader_Run(IBaseFilter * iface, REFERENCE_TIME tStart { AsyncReader *This = impl_from_IBaseFilter(iface); - TRACE("(%s)\n", wine_dbgstr_longlong(tStart)); + TRACE("%p->(%s)\n", This, wine_dbgstr_longlong(tStart)); This->filter.state = State_Running; @@ -548,7 +552,7 @@ static HRESULT WINAPI AsyncReader_Run(IBaseFilter * iface, REFERENCE_TIME tStart static HRESULT WINAPI AsyncReader_FindPin(IBaseFilter * iface, LPCWSTR Id, IPin **ppPin) { AsyncReader *This = impl_from_IBaseFilter(iface); - TRACE("(%s, %p)\n", debugstr_w(Id), ppPin); + TRACE("%p->(%s, %p)\n", This, debugstr_w(Id), ppPin); if (!Id || !ppPin) return E_POINTER; @@ -611,7 +615,7 @@ static HRESULT WINAPI FileSource_Load(IFileSourceFilter * iface, LPCOLESTR pszFi IAsyncReader * pReader = NULL; AsyncReader *This = impl_from_IFileSourceFilter(iface); - TRACE("(%s, %p)\n", debugstr_w(pszFileName), pmt); + TRACE("%p->(%s, %p)\n", This, debugstr_w(pszFileName), pmt); if (!pszFileName) return E_POINTER; @@ -692,7 +696,7 @@ static HRESULT WINAPI FileSource_GetCurFile(IFileSourceFilter * iface, LPOLESTR { AsyncReader *This = impl_from_IFileSourceFilter(iface); - TRACE("(%p, %p)\n", ppszFileName, pmt); + TRACE("%p->(%p, %p)\n", This, ppszFileName, pmt); if (!ppszFileName) return E_POINTER; @@ -888,7 +892,7 @@ static HRESULT WINAPI FileAsyncReaderPin_AttemptConnection(BasePin * iface, IPin BaseOutputPin *This = impl_BaseOutputPin_from_BasePin(iface); HRESULT hr; - TRACE("(%p, %p)\n", pReceivePin, pmt); + TRACE("%p->(%p, %p)\n", This, pReceivePin, pmt); dump_AM_MEDIA_TYPE(pmt); /* FIXME: call queryacceptproc */ @@ -996,7 +1000,7 @@ static HRESULT WINAPI FileAsyncReader_RequestAllocator(IAsyncReader * iface, IMe HRESULT hr = S_OK; - TRACE("(%p, %p, %p)\n", pPreferred, pProps, ppActual); + TRACE("%p->(%p, %p, %p)\n", This, pPreferred, pProps, ppActual); if (!pProps->cbAlign || (pProps->cbAlign % DEF_ALIGNMENT) != 0) pProps->cbAlign = DEF_ALIGNMENT; @@ -1092,7 +1096,7 @@ static HRESULT WINAPI FileAsyncReader_Request(IAsyncReader * iface, IMediaSample FileAsyncReader *This = impl_from_IAsyncReader(iface); LPBYTE pBuffer = NULL; - TRACE("(%p, %lx)\n", pSample, dwUser); + TRACE("%p->(%p, %lx)\n", This, pSample, dwUser); if (!pSample) return E_POINTER; @@ -1170,7 +1174,7 @@ static HRESULT WINAPI FileAsyncReader_WaitForNext(IAsyncReader * iface, DWORD dw FileAsyncReader *This = impl_from_IAsyncReader(iface); DWORD buffer = ~0; - TRACE("(%u, %p, %p)\n", dwTimeout, ppSample, pdwUser); + TRACE("%p->(%u, %p, %p)\n", This, dwTimeout, ppSample, pdwUser); *ppSample = NULL; *pdwUser = 0; @@ -1335,7 +1339,7 @@ static HRESULT WINAPI FileAsyncReader_SyncRead(IAsyncReader * iface, LONGLONG ll HRESULT hr = S_OK; FileAsyncReader *This = impl_from_IAsyncReader(iface); - TRACE("(%s, %d, %p)\n", wine_dbgstr_longlong(llPosition), lLength, pBuffer); + TRACE("%p->(%s, %d, %p)\n", This, wine_dbgstr_longlong(llPosition), lLength, pBuffer); ZeroMemory(&ovl, sizeof(ovl)); @@ -1370,7 +1374,7 @@ static HRESULT WINAPI FileAsyncReader_Length(IAsyncReader * iface, LONGLONG * pT DWORD dwSizeHigh; FileAsyncReader *This = impl_from_IAsyncReader(iface); - TRACE("(%p, %p)\n", pTotal, pAvailable); + TRACE("%p->(%p, %p)\n", This, pTotal, pAvailable); if (((dwSizeLow = GetFileSize(This->hFile, &dwSizeHigh)) == -1) && (GetLastError() != NO_ERROR)) @@ -1387,7 +1391,7 @@ static HRESULT WINAPI FileAsyncReader_BeginFlush(IAsyncReader * iface) { FileAsyncReader *This = impl_from_IAsyncReader(iface); - TRACE("()\n"); + TRACE("%p->()\n", This); EnterCriticalSection(&This->csList); This->bFlushing = TRUE; @@ -1403,7 +1407,7 @@ static HRESULT WINAPI FileAsyncReader_EndFlush(IAsyncReader * iface) FileAsyncReader *This = impl_from_IAsyncReader(iface); int x; - TRACE("()\n"); + TRACE("%p->()\n", This); EnterCriticalSection(&This->csList); ResetEvent(This->handle_list[This->samples]);

1 0

Zebediah Figura : quartz/tests: Remove thread-counting tests.
by Alexandre Julliard Nov. 9, 2017

Nov. 9, 2017

Module: wine Branch: master Commit: 9a52a3e19545abfaab58c59deeac20b98d563c52 URL: http://source.winehq.org/git/wine.git/?a=commit;h=9a52a3e19545abfaab58c59de… Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Wed Nov 8 23:26:06 2017 -0600 quartz/tests: Remove thread-counting tests. Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/quartz/tests/avisplitter.c | 77 ++--------------------------------------- 1 file changed, 2 insertions(+), 75 deletions(-) diff --git a/dlls/quartz/tests/avisplitter.c b/dlls/quartz/tests/avisplitter.c index 78ca8b8..29782a9 100644 --- a/dlls/quartz/tests/avisplitter.c +++ b/dlls/quartz/tests/avisplitter.c @@ -25,38 +25,8 @@ #include "dshow.h" #include "tlhelp32.h" -static HANDLE (WINAPI *pCreateToolhelp32Snapshot)(DWORD, DWORD); -static BOOL (WINAPI *pThread32First)(HANDLE, LPTHREADENTRY32); -static BOOL (WINAPI *pThread32Next)(HANDLE, LPTHREADENTRY32); - static IUnknown *pAviSplitter = NULL; -static int count_threads(void) -{ - THREADENTRY32 te; - int threads; - HANDLE h; - - h = pCreateToolhelp32Snapshot(TH32CS_SNAPTHREAD, 0); - te.dwSize = sizeof(te); - - if (h == INVALID_HANDLE_VALUE) - return -1; - - pThread32First(h, &te); - if (te.th32OwnerProcessID == GetCurrentProcessId()) - threads = 1; - else - threads = 0; - - while (pThread32Next(h, &te)) - if (te.th32OwnerProcessID == GetCurrentProcessId()) - ++threads; - - CloseHandle(h); - return threads; -} - static BOOL create_avisplitter(void) { HRESULT hr; @@ -303,37 +273,19 @@ static void test_filesourcefilter(void) static const WCHAR wfile[] = {'t','e','s','t','.','a','v','i',0}; static const char afile[] = "test.avi"; -/* This test doesn't use the quartz filtergraph because it makes it impossible - * to be certain that a thread is really one owned by the avi splitter. - * A lot of the decoder filters will also have their own thread, and Windows' - * filtergraph has a separate thread for start/stop/seeking requests. - * By avoiding the filtergraph altogether and connecting streams directly to - * the null renderer I am sure that this is not the case here. - */ -static void test_threads(void) +static void test_filter_graph(void) { IFileSourceFilter *pfile = NULL; IBaseFilter *preader = NULL, *pavi = NULL; IEnumPins *enumpins = NULL; IPin *filepin = NULL, *avipin = NULL; HRESULT hr; - int baselevel, curlevel, expected; HANDLE file = NULL; PIN_DIRECTION dir = PINDIR_OUTPUT; char buffer[13]; DWORD readbytes; FILTER_STATE state; - /* We need another way of counting threads on NT4. Skip these tests (for now) */ - if (!pCreateToolhelp32Snapshot || !pThread32First || !pThread32Next) - { - win_skip("Needed thread functions are not available (NT4)\n"); - return; - } - - /* Before doing anything (the thread count at the start differs per OS) */ - baselevel = count_threads(); - file = CreateFileW(wfile, GENERIC_READ, FILE_SHARE_READ|FILE_SHARE_WRITE, NULL, OPEN_EXISTING, 0, NULL); if (file == INVALID_HANDLE_VALUE) @@ -409,20 +361,11 @@ static void test_threads(void) if (hr != S_OK) goto fail; - curlevel = count_threads(); - ok(curlevel == baselevel, - "The thread count should be %d not %d\n", baselevel, curlevel); - hr = IPin_Connect(filepin, avipin, NULL); ok(hr == S_OK, "Could not connect: %08x\n", hr); if (hr != S_OK) goto fail; - expected = 1 + baselevel; - curlevel = count_threads(); - ok(curlevel == expected, - "The thread count should be %d not %d\n", expected, curlevel); - IPin_Release(avipin); avipin = NULL; @@ -462,7 +405,6 @@ static void test_threads(void) break; } IBaseFilter_Run(pnull, 0); - ++expected; } IPin_Release(avipin); @@ -494,10 +436,6 @@ static void test_threads(void) IBaseFilter_Run(pavi, 0); IBaseFilter_GetState(pavi, INFINITE, &state); - curlevel = count_threads(); - ok(curlevel == expected, - "The thread count should be %d not %d\n", expected, curlevel); - IBaseFilter_Pause(pavi); IBaseFilter_Pause(preader); IBaseFilter_Stop(pavi); @@ -568,21 +506,10 @@ fail: IBaseFilter_Release(pavi); if (pfile) IFileSourceFilter_Release(pfile); - - curlevel = count_threads(); - todo_wine - ok(curlevel == baselevel, - "The thread count should be %d not %d\n", baselevel, curlevel); } START_TEST(avisplitter) { - HMODULE kernel32 = GetModuleHandleA("kernel32.dll"); - - pCreateToolhelp32Snapshot = (void*)GetProcAddress(kernel32, "CreateToolhelp32Snapshot"); - pThread32First = (void*)GetProcAddress(kernel32, "Thread32First"); - pThread32Next = (void*)GetProcAddress(kernel32, "Thread32Next"); - CoInitialize(NULL); if (!create_avisplitter()) @@ -594,7 +521,7 @@ START_TEST(avisplitter) test_query_interface(); test_basefilter(); test_filesourcefilter(); - test_threads(); + test_filter_graph(); release_avisplitter();

1 0

Vincent Povirk : tdh: Stub TdhLoadManifest.
by Alexandre Julliard Nov. 9, 2017

Nov. 9, 2017

Module: wine Branch: master Commit: a46411499e9151d03756d079e9f0e886825ce3bb URL: http://source.winehq.org/git/wine.git/?a=commit;h=a46411499e9151d03756d079e… Author: Vincent Povirk <vincent(a)codeweavers.com> Date: Wed Nov 8 16:11:02 2017 -0600 tdh: Stub TdhLoadManifest. Signed-off-by: Vincent Povirk <vincent(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/tdh/tdh.spec | 2 +- dlls/tdh/tdh_main.c | 9 +++++++++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/dlls/tdh/tdh.spec b/dlls/tdh/tdh.spec index 8702802..0e7c5a5 100644 --- a/dlls/tdh/tdh.spec +++ b/dlls/tdh/tdh.spec @@ -21,7 +21,7 @@ @ stub TdhGetPropertySize @ stub TdhGetWppMessage @ stub TdhGetWppProperty -@ stub TdhLoadManifest +@ stdcall TdhLoadManifest(wstr) @ stub TdhLoadManifestFromBinary @ stub TdhOpenDecodingHandle @ stub TdhQueryProviderFieldInformation diff --git a/dlls/tdh/tdh_main.c b/dlls/tdh/tdh_main.c index 5e10487..c1885f8 100644 --- a/dlls/tdh/tdh_main.c +++ b/dlls/tdh/tdh_main.c @@ -20,8 +20,11 @@ #include <stdarg.h> +#include "ntstatus.h" +#define WIN32_NO_STATUS #include "windef.h" #include "winbase.h" +#include "winternl.h" #include "wine/debug.h" WINE_DEFAULT_DEBUG_CHANNEL(tdh); @@ -41,3 +44,9 @@ BOOL WINAPI DllMain(HINSTANCE instance, DWORD reason, void *reserved) return TRUE; } + +ULONG WINAPI TdhLoadManifest(LPWSTR manifest) +{ + FIXME("(%s): stub\n", debugstr_w(manifest)); + return STATUS_SUCCESS; +}

1 0

Alistair Leslie-Hughes : quartz: Output This in TRACE statements.
by Alexandre Julliard Nov. 9, 2017

Nov. 9, 2017

Module: wine Branch: master Commit: c23bcce55215cfc5bfe98be34661ff8e86c58bf2 URL: http://source.winehq.org/git/wine.git/?a=commit;h=c23bcce55215cfc5bfe98be34… Author: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Date: Thu Nov 9 01:08:41 2017 +0000 quartz: Output This in TRACE statements. Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/quartz/parser.c | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/dlls/quartz/parser.c b/dlls/quartz/parser.c index bc6b34d..a2ff407 100644 --- a/dlls/quartz/parser.c +++ b/dlls/quartz/parser.c @@ -68,7 +68,7 @@ static IPin* WINAPI Parser_GetPin(BaseFilter *iface, int pos) { ParserImpl *This = impl_from_BaseFilter(iface); - TRACE("Asking for pos %x\n", pos); + TRACE("%p->(%x)\n", This, pos); /* Input pin also has a pin, hence the > and not >= */ if (pos > This->cStreams || pos < 0) @@ -82,6 +82,8 @@ static LONG WINAPI Parser_GetPinCount(BaseFilter *iface) { ParserImpl *This = impl_from_BaseFilter(iface); + TRACE("%p->()\n", This); + return This->cStreams; } @@ -222,7 +224,7 @@ HRESULT WINAPI Parser_GetClassID(IBaseFilter * iface, CLSID * pClsid) { ParserImpl *This = impl_from_IBaseFilter(iface); - TRACE("(%p)\n", pClsid); + TRACE("%p->(%p)\n", This, pClsid); *pClsid = This->filter.clsid; @@ -237,7 +239,7 @@ HRESULT WINAPI Parser_Stop(IBaseFilter * iface) PullPin *pin = impl_PullPin_from_IPin(This->ppPins[0]); ULONG i; - TRACE("()\n"); + TRACE("%p->()\n", This); EnterCriticalSection(&pin->thread_lock); @@ -275,7 +277,7 @@ HRESULT WINAPI Parser_Pause(IBaseFilter * iface) ParserImpl *This = impl_from_IBaseFilter(iface); PullPin *pin = impl_PullPin_from_IPin(This->ppPins[0]); - TRACE("()\n"); + TRACE("%p->()\n", This); EnterCriticalSection(&pin->thread_lock); EnterCriticalSection(&This->filter.csFilter); @@ -311,7 +313,7 @@ HRESULT WINAPI Parser_Run(IBaseFilter * iface, REFERENCE_TIME tStart) ULONG i; - TRACE("(%s)\n", wine_dbgstr_longlong(tStart)); + TRACE("%p->(%s)\n", This, wine_dbgstr_longlong(tStart)); EnterCriticalSection(&pin->thread_lock); EnterCriticalSection(&This->filter.csFilter); @@ -357,7 +359,7 @@ HRESULT WINAPI Parser_GetState(IBaseFilter * iface, DWORD dwMilliSecsTimeout, FI PullPin *pin = impl_PullPin_from_IPin(This->ppPins[0]); HRESULT hr = S_OK; - TRACE("(%d, %p)\n", dwMilliSecsTimeout, pState); + TRACE("%p->(%d, %p)\n", This, dwMilliSecsTimeout, pState); EnterCriticalSection(&pin->thread_lock); EnterCriticalSection(&This->filter.csFilter); @@ -378,7 +380,7 @@ HRESULT WINAPI Parser_SetSyncSource(IBaseFilter * iface, IReferenceClock *pClock ParserImpl *This = impl_from_IBaseFilter(iface); PullPin *pin = impl_PullPin_from_IPin(This->ppPins[0]); - TRACE("(%p)\n", pClock); + TRACE("%p->(%p)\n", This, pClock); EnterCriticalSection(&pin->thread_lock); BaseFilterImpl_SetSyncSource(iface,pClock); @@ -401,7 +403,8 @@ HRESULT WINAPI Parser_EnumPins(IBaseFilter * iface, IEnumPins **ppEnum) HRESULT WINAPI Parser_FindPin(IBaseFilter * iface, LPCWSTR Id, IPin **ppPin) { - FIXME("(%p)->(%s,%p)\n", iface, debugstr_w(Id), ppPin); + ParserImpl *This = impl_from_IBaseFilter(iface); + FIXME("(%p)->(%s,%p)\n", This, debugstr_w(Id), ppPin); /* FIXME: critical section */

1 0

Marcus Meissner : oleaut32/tests: Fixed 64-bit crash on tmarshal test.
by Alexandre Julliard Nov. 8, 2017

Nov. 8, 2017

Module: wine Branch: master Commit: 4f45fa0581df0c9fe2ca791e6a027aad3787f877 URL: http://source.winehq.org/git/wine.git/?a=commit;h=4f45fa0581df0c9fe2ca791e6… Author: Marcus Meissner <marcus(a)jet.franken.de> Date: Fri Nov 3 12:15:12 2017 +0100 oleaut32/tests: Fixed 64-bit crash on tmarshal test. Signed-off-by: Marcus Meissner <marcus(a)jet.franken.de> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/oleaut32/tests/tmarshal.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dlls/oleaut32/tests/tmarshal.c b/dlls/oleaut32/tests/tmarshal.c index d2b8dc9..67b8e22 100644 --- a/dlls/oleaut32/tests/tmarshal.c +++ b/dlls/oleaut32/tests/tmarshal.c @@ -2010,7 +2010,8 @@ static void test_external_connection(void) todo_wine ok(external_connections == 2, "external_connections = %d\n", external_connections); - ITestSecondDisp_Release(second); + if (hres == S_OK) + ITestSecondDisp_Release(second); todo_wine ok(external_connections == 2, "external_connections = %d\n", external_connections);

1 0

Alex Henrie : d3dx9/tests: Correct Fresnel reference term.
by Alexandre Julliard Nov. 8, 2017

Nov. 8, 2017

Module: wine Branch: master Commit: 4aef54759c9fabf3cbf247d62a4dc5524461a0b7 URL: http://source.winehq.org/git/wine.git/?a=commit;h=4aef54759c9fabf3cbf247d62… Author: Alex Henrie <alexhenrie24(a)gmail.com> Date: Fri Nov 3 19:10:31 2017 +0100 d3dx9/tests: Correct Fresnel reference term. Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> Signed-off-by: Matteo Bruni <mbruni(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/d3dx9_36/tests/math.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/d3dx9_36/tests/math.c b/dlls/d3dx9_36/tests/math.c index ff3b098..d8e1338 100644 --- a/dlls/d3dx9_36/tests/math.c +++ b/dlls/d3dx9_36/tests/math.c @@ -302,7 +302,7 @@ static void D3DXFresnelTest(void) BOOL equal; fresnel = D3DXFresnelTerm(0.5f, 1.5f); - equal = compare_float(fresnel, 8.91867056e-02f, 1); + equal = compare_float(fresnel, 8.91867128e-02f, 1); ok(equal, "Got unexpected Fresnel term %.8e.\n", fresnel); }

1 0

Alexandre Julliard : user32/tests: Avoid strlen in traces.
by Alexandre Julliard Nov. 8, 2017

Nov. 8, 2017

Module: wine Branch: master Commit: 92d2ebe662e3ed726bbe655e22d8bfc5115dfab3 URL: http://source.winehq.org/git/wine.git/?a=commit;h=92d2ebe662e3ed726bbe655e2… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Wed Nov 8 22:12:45 2017 +0100 user32/tests: Avoid strlen in traces. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/user32/tests/edit.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/dlls/user32/tests/edit.c b/dlls/user32/tests/edit.c index d842dce..0926a58 100644 --- a/dlls/user32/tests/edit.c +++ b/dlls/user32/tests/edit.c @@ -2877,7 +2877,7 @@ static void test_paste(void) SendMessageA(hEdit, WM_SETTEXT, 0, (LPARAM)""); r = SendMessageA(hEdit, WM_PASTE, 0, 0); len = SendMessageA(hEdit, WM_GETTEXTLENGTH, 0, 0); - ok(strlen(str) == len, "expected %d, got %d\n", strlen(str), len); + ok(strlen(str) == len, "got %d\n", len); /* Prepare clipboard data with multiline text */ hmem = GlobalAlloc(GMEM_MOVEABLE, 255); @@ -2900,13 +2900,13 @@ static void test_paste(void) SendMessageA(hEdit, WM_SETTEXT, 0, (LPARAM)""); r = SendMessageA(hEdit, WM_PASTE, 0, 0); len = SendMessageA(hEdit, WM_GETTEXTLENGTH, 0, 0); - ok(strlen("first line") == len, "expected %d, got %d\n", strlen("first line"), len); + ok(strlen("first line") == len, "got %d\n", len); /* Paste multiline text in multiline edit */ SendMessageA(hMultilineEdit, WM_SETTEXT, 0, (LPARAM)""); r = SendMessageA(hMultilineEdit, WM_PASTE, 0, 0); len = SendMessageA(hMultilineEdit, WM_GETTEXTLENGTH, 0, 0); - ok(strlen(str2) == len, "expected %d, got %d\n", strlen(str2), len); + ok(strlen(str2) == len, "got %d\n", len); /* Cleanup */ DestroyWindow(hEdit);

1 0

Aric Stewart : hidclass.sys: Handle opportunistic reads.
by Alexandre Julliard Nov. 8, 2017

Nov. 8, 2017

Module: wine Branch: master Commit: 97c925957cfaee0be915b1126cbd71fd3546bc4a URL: http://source.winehq.org/git/wine.git/?a=commit;h=97c925957cfaee0be915b1126… Author: Aric Stewart <aric(a)codeweavers.com> Date: Tue Nov 7 10:08:10 2017 -0600 hidclass.sys: Handle opportunistic reads. Signed-off-by: Aric Stewart <aric(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/hidclass.sys/device.c | 34 +++++++++++++++++++++++++++------- 1 file changed, 27 insertions(+), 7 deletions(-) diff --git a/dlls/hidclass.sys/device.c b/dlls/hidclass.sys/device.c index 40d458a..a5cbee9 100644 --- a/dlls/hidclass.sys/device.c +++ b/dlls/hidclass.sys/device.c @@ -316,7 +316,7 @@ static DWORD CALLBACK hid_device_thread(void *args) IoCompleteRequest(irp, IO_NO_INCREMENT ); - rc = WaitForSingleObject(ext->halt_event, ext->poll_interval); + rc = WaitForSingleObject(ext->halt_event, ext->poll_interval ? ext->poll_interval : DEFAULT_POLL_INTERVAL); if (rc == WAIT_OBJECT_0) break; @@ -546,9 +546,7 @@ NTSTATUS WINAPI HID_Device_ioctl(DEVICE_OBJECT *device, IRP *irp) break; } poll_interval = *(ULONG *)irp->AssociatedIrp.SystemBuffer; - if (poll_interval == 0) - FIXME("Handle opportunistic reads\n"); - else if (poll_interval <= MAX_POLL_INTERVAL_MSEC) + if (poll_interval <= MAX_POLL_INTERVAL_MSEC) { extension->poll_interval = poll_interval; irp->IoStatus.u.Status = STATUS_SUCCESS; @@ -668,6 +666,7 @@ NTSTATUS WINAPI HID_Device_read(DEVICE_OBJECT *device, IRP *irp) BASE_DEVICE_EXTENSION *ext = device->DeviceExtension; UINT buffer_size = RingBuffer_GetBufferSize(ext->ring_buffer); NTSTATUS rc = STATUS_SUCCESS; + IO_STACK_LOCATION *irpsp = IoGetCurrentIrpStackLocation(irp); int ptr = -1; packet = HeapAlloc(GetProcessHeap(), 0, buffer_size); @@ -691,9 +690,30 @@ NTSTATUS WINAPI HID_Device_read(DEVICE_OBJECT *device, IRP *irp) } else { - TRACE_(hid_report)("Queue irp\n"); - InsertTailList(&ext->irp_queue, &irp->Tail.Overlay.s.ListEntry); - rc = STATUS_PENDING; + BASE_DEVICE_EXTENSION *extension = device->DeviceExtension; + if (extension->poll_interval) + { + TRACE_(hid_report)("Queue irp\n"); + InsertTailList(&ext->irp_queue, &irp->Tail.Overlay.s.ListEntry); + rc = STATUS_PENDING; + } + else + { + HID_XFER_PACKET packet; + TRACE("No packet, but opportunistic reads enabled\n"); + packet.reportId = ((BYTE*)irp->AssociatedIrp.SystemBuffer)[0]; + packet.reportBuffer = &((BYTE*)irp->AssociatedIrp.SystemBuffer)[1]; + packet.reportBufferLen = irpsp->Parameters.Read.Length - 1; + rc = call_minidriver(IOCTL_HID_GET_INPUT_REPORT, device, NULL, 0, &packet, sizeof(packet)); + + if (rc == STATUS_SUCCESS) + { + ((BYTE*)irp->AssociatedIrp.SystemBuffer)[0] = packet.reportId; + irp->IoStatus.Information = packet.reportBufferLen + 1; + irp->IoStatus.u.Status = rc; + } + IoCompleteRequest(irp, IO_NO_INCREMENT); + } } HeapFree(GetProcessHeap(), 0, packet);

1 0

Hans Leidekker : include: Add missing BCRYPT_CHAIN_MODE definitions.
by Alexandre Julliard Nov. 8, 2017

Nov. 8, 2017

Module: wine Branch: master Commit: 63e3179c64ff3934ca75d717947642282e0ccce9 URL: http://source.winehq.org/git/wine.git/?a=commit;h=63e3179c64ff3934ca75d7179… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Wed Nov 8 16:25:51 2017 +0100 include: Add missing BCRYPT_CHAIN_MODE definitions. Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> Signed-off-by: Vijay Kiran Kamuju <infyquest(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- include/bcrypt.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/bcrypt.h b/include/bcrypt.h index c71b1e8..2555bf0 100644 --- a/include/bcrypt.h +++ b/include/bcrypt.h @@ -74,6 +74,9 @@ typedef LONG NTSTATUS; #define BCRYPT_CHAIN_MODE_NA (const WCHAR []){'C','h','a','i','n','i','n','g','M','o','d','e','N','/','A',0} #define BCRYPT_CHAIN_MODE_CBC (const WCHAR []){'C','h','a','i','n','i','n','g','M','o','d','e','C','B','C',0} #define BCRYPT_CHAIN_MODE_ECB (const WCHAR []){'C','h','a','i','n','i','n','g','M','o','d','e','E','C','B',0} +#define BCRYPT_CHAIN_MODE_CFB (const WCHAR []){'C','h','a','i','n','i','n','g','M','o','d','e','C','F','B',0} +#define BCRYPT_CHAIN_MODE_CCM (const WCHAR []){'C','h','a','i','n','i','n','g','M','o','d','e','C','C','M',0} +#define BCRYPT_CHAIN_MODE_GCM (const WCHAR []){'C','h','a','i','n','i','n','g','M','o','d','e','G','C','M',0} typedef struct _BCRYPT_ALGORITHM_IDENTIFIER {

1 0

Piotr Caban : vbscript: Don't return error on VBScript_SetScriptState( SCRIPTSTATE_DISCONNECTED) call.
by Alexandre Julliard Nov. 8, 2017

Nov. 8, 2017

Module: wine Branch: master Commit: a2438ce8109677a8e185342c343f55c1e558844c URL: http://source.winehq.org/git/wine.git/?a=commit;h=a2438ce8109677a8e185342c3… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Wed Nov 8 15:05:20 2017 +0100 vbscript: Don't return error on VBScript_SetScriptState(SCRIPTSTATE_DISCONNECTED) call. Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/vbscript/vbscript.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/dlls/vbscript/vbscript.c b/dlls/vbscript/vbscript.c index b594b07..645068e 100644 --- a/dlls/vbscript/vbscript.c +++ b/dlls/vbscript/vbscript.c @@ -351,6 +351,9 @@ static HRESULT WINAPI VBScript_SetScriptState(IActiveScript *iface, SCRIPTSTATE case SCRIPTSTATE_INITIALIZED: FIXME("unimplemented SCRIPTSTATE_INITIALIZED\n"); return S_OK; + case SCRIPTSTATE_DISCONNECTED: + FIXME("unimplemented SCRIPTSTATE_DISCONNECTED\n"); + return S_OK; default: FIXME("unimplemented state %d\n", ss); return E_NOTIMPL;

1 0

Huw Davies : rpcrt4: Don't free the argument if the freer was called, unless it's a simple ref.
by Alexandre Julliard Nov. 8, 2017

Nov. 8, 2017

Module: wine Branch: master Commit: b2667416c21e0e9e829169404be4c04b4c973139 URL: http://source.winehq.org/git/wine.git/?a=commit;h=b2667416c21e0e9e829169404… Author: Huw Davies <huw(a)codeweavers.com> Date: Wed Nov 8 11:19:56 2017 +0000 rpcrt4: Don't free the argument if the freer was called, unless it's a simple ref. In the simple reference case the freer will not see the top-level pointer, so we need to free that here. This fixes a double-free caused by commit 614afcefa33c727f31d566c3d7ee05d74afc363f. Signed-off-by: Huw Davies <huw(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/rpcrt4/ndr_stubless.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/dlls/rpcrt4/ndr_stubless.c b/dlls/rpcrt4/ndr_stubless.c index f65eaf5..f84c617 100644 --- a/dlls/rpcrt4/ndr_stubless.c +++ b/dlls/rpcrt4/ndr_stubless.c @@ -1137,6 +1137,11 @@ LONG_PTR __cdecl call_server_func(SERVER_ROUTINE func, unsigned char * args, uns } #endif +static inline BOOL param_needs_alloc( PARAM_ATTRIBUTES attr ) +{ + return attr.IsOut && !attr.IsIn && !attr.IsBasetype && !attr.IsByValue; +} + static LONG_PTR *stub_do_args(MIDL_STUB_MESSAGE *pStubMsg, PFORMAT_STRING pFormat, enum stubless_phase phase, unsigned short number_of_params) @@ -1172,20 +1177,14 @@ static LONG_PTR *stub_do_args(MIDL_STUB_MESSAGE *pStubMsg, { HeapFree(GetProcessHeap(), 0, *(void **)pArg); } - else if (params[i].attr.IsOut && - !params[i].attr.IsIn && - !params[i].attr.IsBasetype && - !params[i].attr.IsByValue) + else if (param_needs_alloc(params[i].attr) && + (!params[i].attr.MustFree || params[i].attr.IsSimpleRef)) { if (*pTypeFormat != RPC_FC_BIND_CONTEXT) pStubMsg->pfnFree(*(void **)pArg); } break; case STUBLESS_INITOUT: - if (!params[i].attr.IsIn && - params[i].attr.IsOut && - !params[i].attr.IsBasetype && - !params[i].attr.ServerAllocSize && - !params[i].attr.IsByValue) + if (param_needs_alloc(params[i].attr) && !params[i].attr.ServerAllocSize) { if (*pTypeFormat == RPC_FC_BIND_CONTEXT) {

1 0

Nikolay Sivov : msvcrt: Implement _memicmp_l().
by Alexandre Julliard Nov. 8, 2017

Nov. 8, 2017

Module: wine Branch: master Commit: d045a5ea29aada4182689cd80f4b57a694322b42 URL: http://source.winehq.org/git/wine.git/?a=commit;h=d045a5ea29aada4182689cd80… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Wed Nov 8 10:26:16 2017 +0100 msvcrt: Implement _memicmp_l(). Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- .../api-ms-win-crt-string-l1-1-0.spec | 2 +- dlls/msvcr100/msvcr100.spec | 4 +- dlls/msvcr100/tests/msvcr100.c | 87 +++++++++++++ dlls/msvcr110/msvcr110.spec | 4 +- dlls/msvcr120/msvcr120.spec | 4 +- dlls/msvcr120_app/msvcr120_app.spec | 2 +- dlls/msvcr70/msvcr70.spec | 2 +- dlls/msvcr71/msvcr71.spec | 2 +- dlls/msvcr80/msvcr80.spec | 4 +- dlls/msvcr90/msvcr90.spec | 4 +- dlls/msvcr90/tests/msvcr90.c | 69 +++++++++++ dlls/msvcrt/msvcrt.spec | 4 +- dlls/msvcrt/string.c | 34 ++++++ dlls/msvcrt/tests/string.c | 84 +++++++++++++ dlls/ucrtbase/tests/string.c | 134 ++++++++++++++++++++- dlls/ucrtbase/ucrtbase.spec | 4 +- 16 files changed, 425 insertions(+), 19 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=d045a5ea29aada4182689…

1 0

Nikolay Sivov : d3dx9: Implement D3DXFrameFind().
by Alexandre Julliard Nov. 8, 2017

Nov. 8, 2017

Module: wine Branch: master Commit: 6bae0a003e893072ab2b636d5b6c982d76b39f36 URL: http://source.winehq.org/git/wine.git/?a=commit;h=6bae0a003e893072ab2b636d5… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Mon Nov 6 13:31:10 2017 +0300 d3dx9: Implement D3DXFrameFind(). Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Matteo Bruni <mbruni(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/d3dx9_24/d3dx9_24.spec | 2 +- dlls/d3dx9_25/d3dx9_25.spec | 2 +- dlls/d3dx9_26/d3dx9_26.spec | 2 +- dlls/d3dx9_27/d3dx9_27.spec | 2 +- dlls/d3dx9_28/d3dx9_28.spec | 2 +- dlls/d3dx9_29/d3dx9_29.spec | 2 +- dlls/d3dx9_30/d3dx9_30.spec | 2 +- dlls/d3dx9_31/d3dx9_31.spec | 2 +- dlls/d3dx9_32/d3dx9_32.spec | 2 +- dlls/d3dx9_33/d3dx9_33.spec | 2 +- dlls/d3dx9_34/d3dx9_34.spec | 2 +- dlls/d3dx9_35/d3dx9_35.spec | 2 +- dlls/d3dx9_36/d3dx9_36.spec | 2 +- dlls/d3dx9_36/mesh.c | 80 +++++++++++++++++++++++++++++++++++++++++++++ dlls/d3dx9_36/tests/mesh.c | 76 ++++++++++++++++++++++++++++++++++++++++++ dlls/d3dx9_37/d3dx9_37.spec | 2 +- dlls/d3dx9_38/d3dx9_38.spec | 2 +- dlls/d3dx9_39/d3dx9_39.spec | 2 +- dlls/d3dx9_40/d3dx9_40.spec | 2 +- dlls/d3dx9_41/d3dx9_41.spec | 2 +- dlls/d3dx9_42/d3dx9_42.spec | 2 +- dlls/d3dx9_43/d3dx9_43.spec | 2 +- 22 files changed, 176 insertions(+), 20 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=6bae0a003e893072ab2b6…

1 0

Piotr Caban : vbscript: Don't leak IEnumVARIANT in interp_enumnext.
by Alexandre Julliard Nov. 8, 2017

Nov. 8, 2017

Module: wine Branch: master Commit: f595523413240b34862438565bd43fcf1d1aec92 URL: http://source.winehq.org/git/wine.git/?a=commit;h=f595523413240b34862438565… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Wed Nov 8 18:11:56 2017 +0100 vbscript: Don't leak IEnumVARIANT in interp_enumnext. Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/vbscript/interp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/vbscript/interp.c b/dlls/vbscript/interp.c index 2f414be..9ec3299 100644 --- a/dlls/vbscript/interp.c +++ b/dlls/vbscript/interp.c @@ -1203,7 +1203,7 @@ static HRESULT interp_enumnext(exec_ctx_t *ctx) if(do_continue) { ctx->instr++; }else { - stack_pop(ctx); + stack_popn(ctx, 1); instr_jmp(ctx, loop_end); } return S_OK;

1 0

Nikolay Sivov : gdiplus/metafile: Support linear gradient brushes in playback.
by Alexandre Julliard Nov. 8, 2017

Nov. 8, 2017

Module: wine Branch: master Commit: 394e15e39cda76984849c9582757c375fa06adbe URL: http://source.winehq.org/git/wine.git/?a=commit;h=394e15e39cda76984849c9582… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Wed Nov 8 13:12:44 2017 +0300 gdiplus/metafile: Support linear gradient brushes in playback. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Vincent Povirk <vincent(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/gdiplus/metafile.c | 110 +++++++++++++++++++++++++++++++++++++++++++----- 1 file changed, 99 insertions(+), 11 deletions(-) diff --git a/dlls/gdiplus/metafile.c b/dlls/gdiplus/metafile.c index d764412..77673a7 100644 --- a/dlls/gdiplus/metafile.c +++ b/dlls/gdiplus/metafile.c @@ -256,6 +256,26 @@ typedef struct EmfPlusTextureBrushData BYTE OptionalData[1]; } EmfPlusTextureBrushData; +typedef struct EmfPlusRectF +{ + float X; + float Y; + float Width; + float Height; +} EmfPlusRectF; + +typedef struct EmfPlusLinearGradientBrushData +{ + DWORD BrushDataFlags; + INT WrapMode; + EmfPlusRectF RectF; + EmfPlusARGB StartColor; + EmfPlusARGB EndColor; + DWORD Reserved1; + DWORD Reserved2; + BYTE OptionalData[1]; +} EmfPlusLinearGradientBrushData; + typedef struct EmfPlusBrush { DWORD Version; @@ -264,6 +284,7 @@ typedef struct EmfPlusBrush EmfPlusSolidBrushData solid; EmfPlusHatchBrushData hatch; EmfPlusTextureBrushData texture; + EmfPlusLinearGradientBrushData lineargradient; } BrushData; } EmfPlusBrush; @@ -372,14 +393,6 @@ typedef struct EmfPlusObject } ObjectData; } EmfPlusObject; -typedef struct EmfPlusRectF -{ - float X; - float Y; - float Width; - float Height; -} EmfPlusRectF; - typedef struct EmfPlusPointR7 { BYTE X; @@ -2011,7 +2024,10 @@ static GpStatus metafile_deserialize_brush(const BYTE *record_data, UINT data_si { static const UINT header_size = FIELD_OFFSET(EmfPlusBrush, BrushData); EmfPlusBrush *data = (EmfPlusBrush *)record_data; + EmfPlusTransformMatrix *transform = NULL; + DWORD brushflags; GpStatus status; + UINT offset; *brush = NULL; @@ -2035,11 +2051,9 @@ static GpStatus metafile_deserialize_brush(const BYTE *record_data, UINT data_si break; case BrushTypeTextureFill: { - UINT offset = header_size + FIELD_OFFSET(EmfPlusTextureBrushData, OptionalData); - EmfPlusTransformMatrix *transform = NULL; - DWORD brushflags; GpImage *image; + offset = header_size + FIELD_OFFSET(EmfPlusTextureBrushData, OptionalData); if (data_size <= offset) return InvalidParameter; @@ -2063,6 +2077,80 @@ static GpStatus metafile_deserialize_brush(const BYTE *record_data, UINT data_si GdipDisposeImage(image); break; } + case BrushTypeLinearGradient: + { + GpLineGradient *gradient = NULL; + GpPointF startpoint, endpoint; + UINT position_count = 0; + + offset = header_size + FIELD_OFFSET(EmfPlusLinearGradientBrushData, OptionalData); + if (data_size <= offset) + return InvalidParameter; + + brushflags = data->BrushData.lineargradient.BrushDataFlags; + if ((brushflags & BrushDataPresetColors) && (brushflags & (BrushDataBlendFactorsH | BrushDataBlendFactorsV))) + return InvalidParameter; + + if (brushflags & BrushDataTransform) + { + if (data_size <= offset + sizeof(EmfPlusTransformMatrix)) + return InvalidParameter; + transform = (EmfPlusTransformMatrix *)(record_data + offset); + offset += sizeof(EmfPlusTransformMatrix); + } + + if (brushflags & (BrushDataPresetColors | BrushDataBlendFactorsH | BrushDataBlendFactorsV)) + { + if (data_size <= offset + sizeof(DWORD)) /* Number of factors/preset colors. */ + return InvalidParameter; + position_count = *(DWORD *)(record_data + offset); + offset += sizeof(DWORD); + } + + if (brushflags & BrushDataPresetColors) + { + if (data_size != offset + position_count * (sizeof(float) + sizeof(EmfPlusARGB))) + return InvalidParameter; + } + else if (brushflags & BrushDataBlendFactorsH) + { + if (data_size != offset + position_count * 2 * sizeof(float)) + return InvalidParameter; + } + + startpoint.X = data->BrushData.lineargradient.RectF.X; + startpoint.Y = data->BrushData.lineargradient.RectF.Y; + endpoint.X = startpoint.X + data->BrushData.lineargradient.RectF.Width; + endpoint.Y = startpoint.Y + data->BrushData.lineargradient.RectF.Height; + + status = GdipCreateLineBrush(&startpoint, &endpoint, data->BrushData.lineargradient.StartColor, + data->BrushData.lineargradient.EndColor, data->BrushData.lineargradient.WrapMode, &gradient); + if (status == Ok) + { + if (transform) + status = GdipSetLineTransform(gradient, (const GpMatrix *)transform); + + if (status == Ok) + { + if (brushflags & BrushDataPresetColors) + status = GdipSetLinePresetBlend(gradient, (ARGB *)(record_data + offset + + position_count * sizeof(REAL)), (REAL *)(record_data + offset), position_count); + else if (brushflags & BrushDataBlendFactorsH) + status = GdipSetLineBlend(gradient, (REAL *)(record_data + offset + position_count * sizeof(REAL)), + (REAL *)(record_data + offset), position_count); + + if (brushflags & BrushDataIsGammaCorrected) + FIXME("BrushDataIsGammaCorrected is not handled.\n"); + } + } + + if (status == Ok) + *brush = (GpBrush *)gradient; + else + GdipDeleteBrush((GpBrush *)gradient); + + break; + } default: FIXME("brush type %u is not supported.\n", data->Type); return NotImplemented;

1 0

Hans Leidekker : advapi32: Fix QueryServiceConfig2 on Wow64.
by Alexandre Julliard Nov. 8, 2017

Nov. 8, 2017

Module: wine Branch: master Commit: 251c9ccff7077921a5ddd5b6616e104869d16501 URL: http://source.winehq.org/git/wine.git/?a=commit;h=251c9ccff7077921a5ddd5b66… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Tue Nov 7 14:10:41 2017 +0100 advapi32: Fix QueryServiceConfig2 on Wow64. Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/advapi32/service.c | 83 +++++++++++++++++++++++++++++++++++++++---------- include/wine/svcctl.idl | 6 ++++ programs/services/rpc.c | 37 ++++++++++++---------- 3 files changed, 94 insertions(+), 32 deletions(-) diff --git a/dlls/advapi32/service.c b/dlls/advapi32/service.c index 78491ae..3f2fb93 100644 --- a/dlls/advapi32/service.c +++ b/dlls/advapi32/service.c @@ -1543,6 +1543,8 @@ BOOL WINAPI QueryServiceConfig2A(SC_HANDLE hService, DWORD dwLevel, LPBYTE buffe BOOL ret; LPBYTE bufferW = NULL; + TRACE("%p %u %p %u %p\n", hService, dwLevel, buffer, size, needed); + if(buffer && size) bufferW = heap_alloc(size); @@ -1591,24 +1593,42 @@ cleanup: BOOL WINAPI QueryServiceConfig2W(SC_HANDLE hService, DWORD dwLevel, LPBYTE buffer, DWORD size, LPDWORD needed) { + BYTE *bufptr; DWORD err; - if(dwLevel!=SERVICE_CONFIG_DESCRIPTION && dwLevel!=SERVICE_CONFIG_PRESHUTDOWN_INFO) { + TRACE("%p %u %p %u %p\n", hService, dwLevel, buffer, size, needed); + + if (!buffer && size) + { + SetLastError(ERROR_INVALID_ADDRESS); + return FALSE; + } + + switch (dwLevel) + { + case SERVICE_CONFIG_DESCRIPTION: + if (!(bufptr = heap_alloc( size ))) return ERROR_OUTOFMEMORY; + break; + + case SERVICE_CONFIG_PRESHUTDOWN_INFO: + bufptr = buffer; + break; + + default: FIXME("Level %d not implemented\n", dwLevel); SetLastError(ERROR_INVALID_LEVEL); return FALSE; } - if(!buffer && size) { + if (!needed) + { SetLastError(ERROR_INVALID_ADDRESS); return FALSE; } - TRACE("%p 0x%d %p 0x%d %p\n", hService, dwLevel, buffer, size, needed); - __TRY { - err = svcctl_QueryServiceConfig2W(hService, dwLevel, buffer, size, needed); + err = svcctl_QueryServiceConfig2W(hService, dwLevel, bufptr, size, needed); } __EXCEPT(rpc_filter) { @@ -1616,22 +1636,53 @@ BOOL WINAPI QueryServiceConfig2W(SC_HANDLE hService, DWORD dwLevel, LPBYTE buffe } __ENDTRY - if (err != ERROR_SUCCESS) - { - SetLastError( err ); - return FALSE; - } - switch (dwLevel) { case SERVICE_CONFIG_DESCRIPTION: - if (buffer) + { + SERVICE_DESCRIPTIONW *desc = (SERVICE_DESCRIPTIONW *)buffer; + struct service_description *s = (struct service_description *)bufptr; + + if (err != ERROR_SUCCESS && err != ERROR_INSUFFICIENT_BUFFER) { - SERVICE_DESCRIPTIONW *descr = (SERVICE_DESCRIPTIONW *)buffer; - if (descr->lpDescription) /* make it an absolute pointer */ - descr->lpDescription = (WCHAR *)(buffer + (ULONG_PTR)descr->lpDescription); - break; + heap_free( bufptr ); + SetLastError( err ); + return FALSE; + } + + /* adjust for potentially larger SERVICE_DESCRIPTIONW structure */ + if (*needed == sizeof(*s)) *needed = sizeof(*desc); + else + *needed = *needed - FIELD_OFFSET(struct service_description, description) + sizeof(*desc); + + if (size < *needed) + { + heap_free( bufptr ); + SetLastError( ERROR_INSUFFICIENT_BUFFER ); + return FALSE; } + if (desc) + { + if (!s->size) desc->lpDescription = NULL; + else + { + desc->lpDescription = (WCHAR *)(desc + 1); + memcpy( desc->lpDescription, s->description, s->size ); + } + } + heap_free( bufptr ); + break; + } + case SERVICE_CONFIG_PRESHUTDOWN_INFO: + if (err != ERROR_SUCCESS) + { + SetLastError( err ); + return FALSE; + } + break; + + default: + break; } return TRUE; diff --git a/include/wine/svcctl.idl b/include/wine/svcctl.idl index 7c5df7d..c14cd6b 100644 --- a/include/wine/svcctl.idl +++ b/include/wine/svcctl.idl @@ -225,6 +225,12 @@ struct enum_service_status_process SERVICE_STATUS_PROCESS service_status_process; }; +struct service_description +{ + USHORT size; + WCHAR description[1]; +}; + typedef struct _SERVICE_RPC_REQUIRED_PRIVILEGES_INFO { DWORD cbRequiredPrivileges; [size_is(cbRequiredPrivileges)] BYTE *pRequiredPrivileges; diff --git a/programs/services/rpc.c b/programs/services/rpc.c index a1d3c9e..20c5a27 100644 --- a/programs/services/rpc.c +++ b/programs/services/rpc.c @@ -879,27 +879,32 @@ DWORD __cdecl svcctl_QueryServiceConfig2W( SC_RPC_HANDLE hService, DWORD level, switch (level) { case SERVICE_CONFIG_DESCRIPTION: - { - SERVICE_DESCRIPTIONW *descr = (SERVICE_DESCRIPTIONW *)buffer; + { + struct service_description *desc = (struct service_description *)buffer; + DWORD total_size = sizeof(*desc); + + service_lock(service->service_entry); + if (service->service_entry->description) + total_size += strlenW(service->service_entry->description) * sizeof(WCHAR); - service_lock(service->service_entry); - *needed = sizeof(*descr); + *needed = total_size; + if (size >= total_size) + { if (service->service_entry->description) - *needed += (strlenW(service->service_entry->description) + 1) * sizeof(WCHAR); - if (size >= *needed) { - if (service->service_entry->description) - { - /* store a buffer offset instead of a pointer */ - descr->lpDescription = (WCHAR *)((BYTE *)(descr + 1) - buffer); - strcpyW( (WCHAR *)(descr + 1), service->service_entry->description ); - } - else descr->lpDescription = NULL; + strcpyW( desc->description, service->service_entry->description ); + desc->size = total_size - FIELD_OFFSET(struct service_description, description); + } + else + { + desc->description[0] = 0; + desc->size = 0; } - else err = ERROR_INSUFFICIENT_BUFFER; - service_unlock(service->service_entry); } - break; + else err = ERROR_INSUFFICIENT_BUFFER; + service_unlock(service->service_entry); + } + break; case SERVICE_CONFIG_PRESHUTDOWN_INFO: service_lock(service->service_entry);

1 0

Hans Leidekker : advapi32: Fix EnumServicesStatusEx on Wow64.
by Alexandre Julliard Nov. 8, 2017

Nov. 8, 2017

Module: wine Branch: master Commit: 445996d31ba5818eb9fe4e41130349b6730284a1 URL: http://source.winehq.org/git/wine.git/?a=commit;h=445996d31ba5818eb9fe4e411… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Tue Nov 7 14:10:40 2017 +0100 advapi32: Fix EnumServicesStatusEx on Wow64. Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/advapi32/service.c | 82 +++++++++++++++++++++++++++++++++++++++++-------- include/wine/svcctl.idl | 7 +++++ programs/services/rpc.c | 16 +++++----- 3 files changed, 84 insertions(+), 21 deletions(-) diff --git a/dlls/advapi32/service.c b/dlls/advapi32/service.c index 79d0693..78491ae 100644 --- a/dlls/advapi32/service.c +++ b/dlls/advapi32/service.c @@ -1893,9 +1893,11 @@ EnumServicesStatusExW( SC_HANDLE hmngr, SC_ENUM_TYPE level, DWORD type, DWORD st LPBYTE buffer, DWORD size, LPDWORD needed, LPDWORD returned, LPDWORD resume_handle, LPCWSTR group ) { - DWORD err, i; - ENUM_SERVICE_STATUS_PROCESSW dummy_status; + DWORD err, i, offset, buflen, count, total_size = 0; ENUM_SERVICE_STATUS_PROCESSW *services = (ENUM_SERVICE_STATUS_PROCESSW *)buffer; + struct enum_service_status_process *entry; + const WCHAR *str; + BYTE *buf; TRACE("%p %u 0x%x 0x%x %p %u %p %p %p %s\n", hmngr, level, type, state, buffer, size, needed, returned, resume_handle, debugstr_w(group)); @@ -1910,18 +1912,24 @@ EnumServicesStatusExW( SC_HANDLE hmngr, SC_ENUM_TYPE level, DWORD type, DWORD st SetLastError( ERROR_INVALID_HANDLE ); return FALSE; } + if (!needed || !returned) + { + SetLastError( ERROR_INVALID_ADDRESS ); + return FALSE; + } - /* make sure we pass a valid buffer pointer */ - if (!services || size < sizeof(*services)) + /* make sure we pass a valid pointer */ + buflen = max( size, sizeof(*services) ); + if (!(buf = heap_alloc( buflen ))) { - buffer = (BYTE *)&dummy_status; - size = sizeof(dummy_status); + SetLastError( ERROR_NOT_ENOUGH_MEMORY ); + return FALSE; } __TRY { - err = svcctl_EnumServicesStatusExW( hmngr, SC_ENUM_PROCESS_INFO, type, state, buffer, size, needed, - returned, resume_handle, group ); + err = svcctl_EnumServicesStatusExW( hmngr, SC_ENUM_PROCESS_INFO, type, state, buf, buflen, needed, + &count, resume_handle, group ); } __EXCEPT(rpc_filter) { @@ -1929,20 +1937,68 @@ EnumServicesStatusExW( SC_HANDLE hmngr, SC_ENUM_TYPE level, DWORD type, DWORD st } __ENDTRY + *returned = 0; if (err != ERROR_SUCCESS) { + /* double the needed size to fit the potentially larger ENUM_SERVICE_STATUS_PROCESSW */ + if (err == ERROR_MORE_DATA) *needed *= 2; + heap_free( buf ); SetLastError( err ); return FALSE; } - for (i = 0; i < *returned; i++) + entry = (struct enum_service_status_process *)buf; + for (i = 0; i < count; i++) { - /* convert buffer offsets into pointers */ - services[i].lpServiceName = (WCHAR *)((char *)services + (DWORD_PTR)services[i].lpServiceName); - if (services[i].lpDisplayName) - services[i].lpDisplayName = (WCHAR *)((char *)services + (DWORD_PTR)services[i].lpDisplayName); + total_size += sizeof(*services); + if (entry->service_name) + { + str = (const WCHAR *)(buf + entry->service_name); + total_size += (strlenW( str ) + 1) * sizeof(WCHAR); + } + if (entry->display_name) + { + str = (const WCHAR *)(buf + entry->display_name); + total_size += (strlenW( str ) + 1) * sizeof(WCHAR); + } + entry++; } + if (total_size > size) + { + heap_free( buf ); + *needed = total_size; + SetLastError( ERROR_MORE_DATA ); + return FALSE; + } + + offset = count * sizeof(*services); + entry = (struct enum_service_status_process *)buf; + for (i = 0; i < count; i++) + { + DWORD str_size; + str = (const WCHAR *)(buf + entry->service_name); + str_size = (strlenW( str ) + 1) * sizeof(WCHAR); + services[i].lpServiceName = (WCHAR *)((char *)services + offset); + memcpy( services[i].lpServiceName, str, str_size ); + offset += str_size; + + if (!entry->display_name) services[i].lpDisplayName = NULL; + else + { + str = (const WCHAR *)(buf + entry->display_name); + str_size = (strlenW( str ) + 1) * sizeof(WCHAR); + services[i].lpDisplayName = (WCHAR *)((char *)services + offset); + memcpy( services[i].lpDisplayName, str, str_size ); + offset += str_size; + } + services[i].ServiceStatusProcess = entry->service_status_process; + entry++; + } + + heap_free( buf ); + *needed = 0; + *returned = count; return TRUE; } diff --git a/include/wine/svcctl.idl b/include/wine/svcctl.idl index b7d1e92..7c5df7d 100644 --- a/include/wine/svcctl.idl +++ b/include/wine/svcctl.idl @@ -218,6 +218,13 @@ struct enum_service_status SERVICE_STATUS service_status; }; +struct enum_service_status_process +{ + DWORD service_name; + DWORD display_name; + SERVICE_STATUS_PROCESS service_status_process; +}; + typedef struct _SERVICE_RPC_REQUIRED_PRIVILEGES_INFO { DWORD cbRequiredPrivileges; [size_is(cbRequiredPrivileges)] BYTE *pRequiredPrivileges; diff --git a/programs/services/rpc.c b/programs/services/rpc.c index 7215504..a1d3c9e 100644 --- a/programs/services/rpc.c +++ b/programs/services/rpc.c @@ -1461,7 +1461,7 @@ DWORD __cdecl svcctl_EnumServicesStatusExW( DWORD_PTR offset; struct sc_manager_handle *manager; struct service_entry *service; - ENUM_SERVICE_STATUS_PROCESSW *s; + struct enum_service_status_process *s; WINE_TRACE("(%p, 0x%x, 0x%x, %p, %u, %p, %p, %s)\n", hmngr, type, state, buffer, size, needed, returned, wine_dbgstr_w(group)); @@ -1489,7 +1489,7 @@ DWORD __cdecl svcctl_EnumServicesStatusExW( if ((service->status.dwServiceType & type) && map_state(service->status.dwCurrentState, state) && match_group(service->config.lpLoadOrderGroup, group)) { - total_size += sizeof(ENUM_SERVICE_STATUS_PROCESSW); + total_size += sizeof(*s); total_size += (strlenW(service->name) + 1) * sizeof(WCHAR); if (service->config.lpDisplayName) { @@ -1505,8 +1505,8 @@ DWORD __cdecl svcctl_EnumServicesStatusExW( scmdatabase_unlock(manager->db); return ERROR_MORE_DATA; } - s = (ENUM_SERVICE_STATUS_PROCESSW *)buffer; - offset = num_services * sizeof(ENUM_SERVICE_STATUS_PROCESSW); + s = (struct enum_service_status_process *)buffer; + offset = num_services * sizeof(*s); LIST_FOR_EACH_ENTRY(service, &manager->db->services, struct service_entry, entry) { if ((service->status.dwServiceType & type) && map_state(service->status.dwCurrentState, state) @@ -1514,18 +1514,18 @@ DWORD __cdecl svcctl_EnumServicesStatusExW( { sz = (strlenW(service->name) + 1) * sizeof(WCHAR); memcpy(buffer + offset, service->name, sz); - s->lpServiceName = (WCHAR *)offset; /* store a buffer offset instead of a pointer */ + s->service_name = offset; offset += sz; - if (!service->config.lpDisplayName) s->lpDisplayName = NULL; + if (!service->config.lpDisplayName) s->display_name = 0; else { sz = (strlenW(service->config.lpDisplayName) + 1) * sizeof(WCHAR); memcpy(buffer + offset, service->config.lpDisplayName, sz); - s->lpDisplayName = (WCHAR *)offset; + s->display_name = offset; offset += sz; } - fill_status_process(&s->ServiceStatusProcess, service); + fill_status_process(&s->service_status_process, service); s++; } }

1 0

Hans Leidekker : advapi32: Fix EnumServicesStatus on Wow64.
by Alexandre Julliard Nov. 8, 2017

Nov. 8, 2017

Module: wine Branch: master Commit: ac0744d4505a583de2cbdc6082f2726393c797df URL: http://source.winehq.org/git/wine.git/?a=commit;h=ac0744d4505a583de2cbdc608… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Tue Nov 7 14:10:39 2017 +0100 advapi32: Fix EnumServicesStatus on Wow64. The structures returned by this function contain pointers, which breaks on Wow64 if the client is 32-bit (the service manager always runs in a 64-bit process). This patch introduces a variant of ENUM_SERVICE_STATUS with offsets instead of pointers and converts the structures on the client side. The downside is that we need to buffer the data, but in return we can get rid of the dummy buffer pointer. Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/advapi32/service.c | 89 +++++++++++++++++++++++++++++++++++++++++++------ include/wine/svcctl.idl | 8 +++++ programs/services/rpc.c | 19 +++++------ 3 files changed, 95 insertions(+), 21 deletions(-) diff --git a/dlls/advapi32/service.c b/dlls/advapi32/service.c index fa6ebfe..79d0693 100644 --- a/dlls/advapi32/service.c +++ b/dlls/advapi32/service.c @@ -1654,6 +1654,17 @@ EnumServicesStatusA( SC_HANDLE hmngr, DWORD type, DWORD state, LPENUM_SERVICE_ST TRACE("%p 0x%x 0x%x %p %u %p %p %p\n", hmngr, type, state, services, size, needed, returned, resume_handle); + if (!hmngr) + { + SetLastError( ERROR_INVALID_HANDLE ); + return FALSE; + } + if (!needed || !returned) + { + SetLastError( ERROR_INVALID_ADDRESS ); + return FALSE; + } + sz = max( 2 * size, sizeof(*servicesW) ); if (!(servicesW = heap_alloc( sz ))) { @@ -1701,8 +1712,10 @@ EnumServicesStatusW( SC_HANDLE hmngr, DWORD type, DWORD state, LPENUM_SERVICE_ST services, DWORD size, LPDWORD needed, LPDWORD returned, LPDWORD resume_handle ) { - DWORD err, i; - ENUM_SERVICE_STATUSW dummy_status; + DWORD err, i, offset, buflen, count, total_size = 0; + struct enum_service_status *entry; + const WCHAR *str; + BYTE *buf; TRACE("%p 0x%x 0x%x %p %u %p %p %p\n", hmngr, type, state, services, size, needed, returned, resume_handle); @@ -1712,17 +1725,23 @@ EnumServicesStatusW( SC_HANDLE hmngr, DWORD type, DWORD state, LPENUM_SERVICE_ST SetLastError( ERROR_INVALID_HANDLE ); return FALSE; } + if (!needed || !returned) + { + SetLastError( ERROR_INVALID_ADDRESS ); + return FALSE; + } /* make sure we pass a valid pointer */ - if (!services || size < sizeof(*services)) + buflen = max( size, sizeof(*services) ); + if (!(buf = heap_alloc( buflen ))) { - services = &dummy_status; - size = sizeof(dummy_status); + SetLastError( ERROR_NOT_ENOUGH_MEMORY ); + return FALSE; } __TRY { - err = svcctl_EnumServicesStatusW( hmngr, type, state, (BYTE *)services, size, needed, returned, resume_handle ); + err = svcctl_EnumServicesStatusW( hmngr, type, state, buf, buflen, needed, &count, resume_handle ); } __EXCEPT(rpc_filter) { @@ -1730,20 +1749,68 @@ EnumServicesStatusW( SC_HANDLE hmngr, DWORD type, DWORD state, LPENUM_SERVICE_ST } __ENDTRY + *returned = 0; if (err != ERROR_SUCCESS) { + /* double the needed size to fit the potentially larger ENUM_SERVICE_STATUSW */ + if (err == ERROR_MORE_DATA) *needed *= 2; + heap_free( buf ); SetLastError( err ); return FALSE; } - for (i = 0; i < *returned; i++) + entry = (struct enum_service_status *)buf; + for (i = 0; i < count; i++) { - /* convert buffer offsets into pointers */ - services[i].lpServiceName = (WCHAR *)((char *)services + (DWORD_PTR)services[i].lpServiceName); - if (services[i].lpDisplayName) - services[i].lpDisplayName = (WCHAR *)((char *)services + (DWORD_PTR)services[i].lpDisplayName); + total_size += sizeof(*services); + if (entry->service_name) + { + str = (const WCHAR *)(buf + entry->service_name); + total_size += (strlenW( str ) + 1) * sizeof(WCHAR); + } + if (entry->display_name) + { + str = (const WCHAR *)(buf + entry->display_name); + total_size += (strlenW( str ) + 1) * sizeof(WCHAR); + } + entry++; + } + + if (total_size > size) + { + heap_free( buf ); + *needed = total_size; + SetLastError( ERROR_MORE_DATA ); + return FALSE; + } + + offset = count * sizeof(*services); + entry = (struct enum_service_status *)buf; + for (i = 0; i < count; i++) + { + DWORD str_size; + str = (const WCHAR *)(buf + entry->service_name); + str_size = (strlenW( str ) + 1) * sizeof(WCHAR); + services[i].lpServiceName = (WCHAR *)((char *)services + offset); + memcpy( services[i].lpServiceName, str, str_size ); + offset += str_size; + + if (!entry->display_name) services[i].lpDisplayName = NULL; + else + { + str = (const WCHAR *)(buf + entry->display_name); + str_size = (strlenW( str ) + 1) * sizeof(WCHAR); + services[i].lpDisplayName = (WCHAR *)((char *)services + offset); + memcpy( services[i].lpDisplayName, str, str_size ); + offset += str_size; + } + services[i].ServiceStatus = entry->service_status; + entry++; } + heap_free( buf ); + *needed = 0; + *returned = count; return TRUE; } diff --git a/include/wine/svcctl.idl b/include/wine/svcctl.idl index 9fd5ca4..b7d1e92 100644 --- a/include/wine/svcctl.idl +++ b/include/wine/svcctl.idl @@ -210,6 +210,14 @@ typedef enum _SC_ENUM_TYPE { cpp_quote("#endif") +/* internal version of ENUM_SERVICE_STATUSA/W that doesn't depend on pointer size */ +struct enum_service_status +{ + DWORD service_name; + DWORD display_name; + SERVICE_STATUS service_status; +}; + typedef struct _SERVICE_RPC_REQUIRED_PRIVILEGES_INFO { DWORD cbRequiredPrivileges; [size_is(cbRequiredPrivileges)] BYTE *pRequiredPrivileges; diff --git a/programs/services/rpc.c b/programs/services/rpc.c index 4435af9..7215504 100644 --- a/programs/services/rpc.c +++ b/programs/services/rpc.c @@ -1342,11 +1342,10 @@ DWORD __cdecl svcctl_EnumServicesStatusW( LPDWORD returned, LPDWORD resume) { - DWORD err, sz, total_size, num_services; - DWORD_PTR offset; + DWORD err, sz, total_size, num_services, offset; struct sc_manager_handle *manager; struct service_entry *service; - ENUM_SERVICE_STATUSW *s; + struct enum_service_status *s; WINE_TRACE("(%p, 0x%x, 0x%x, %p, %u, %p, %p, %p)\n", hmngr, type, state, buffer, size, needed, returned, resume); @@ -1366,7 +1365,7 @@ DWORD __cdecl svcctl_EnumServicesStatusW( { if ((service->status.dwServiceType & type) && map_state(service->status.dwCurrentState, state)) { - total_size += sizeof(ENUM_SERVICE_STATUSW); + total_size += sizeof(*s); total_size += (strlenW(service->name) + 1) * sizeof(WCHAR); if (service->config.lpDisplayName) { @@ -1382,26 +1381,26 @@ DWORD __cdecl svcctl_EnumServicesStatusW( scmdatabase_unlock(manager->db); return ERROR_MORE_DATA; } - s = (ENUM_SERVICE_STATUSW *)buffer; - offset = num_services * sizeof(ENUM_SERVICE_STATUSW); + s = (struct enum_service_status *)buffer; + offset = num_services * sizeof(struct enum_service_status); LIST_FOR_EACH_ENTRY(service, &manager->db->services, struct service_entry, entry) { if ((service->status.dwServiceType & type) && map_state(service->status.dwCurrentState, state)) { sz = (strlenW(service->name) + 1) * sizeof(WCHAR); memcpy(buffer + offset, service->name, sz); - s->lpServiceName = (WCHAR *)offset; /* store a buffer offset instead of a pointer */ + s->service_name = offset; offset += sz; - if (!service->config.lpDisplayName) s->lpDisplayName = NULL; + if (!service->config.lpDisplayName) s->display_name = 0; else { sz = (strlenW(service->config.lpDisplayName) + 1) * sizeof(WCHAR); memcpy(buffer + offset, service->config.lpDisplayName, sz); - s->lpDisplayName = (WCHAR *)offset; + s->display_name = offset; offset += sz; } - s->ServiceStatus = service->status; + s->service_status = service->status; s++; } }

1 0

Piotr Caban : vbscript: Add support for "for each" on arrays.
by Alexandre Julliard Nov. 8, 2017

Nov. 8, 2017

Module: wine Branch: master Commit: a85d12af447057d40882c58e2bb9b51f389abecb URL: http://source.winehq.org/git/wine.git/?a=commit;h=a85d12af447057d40882c58e2… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Wed Nov 8 15:05:01 2017 +0100 vbscript: Add support for "for each" on arrays. Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/vbscript/Makefile.in | 1 + dlls/vbscript/interp.c | 12 +++ dlls/vbscript/utils.c | 193 ++++++++++++++++++++++++++++++++++++++++++++++ dlls/vbscript/vbscript.h | 2 + 4 files changed, 208 insertions(+) diff --git a/dlls/vbscript/Makefile.in b/dlls/vbscript/Makefile.in index 5ad0600..5c613f0 100644 --- a/dlls/vbscript/Makefile.in +++ b/dlls/vbscript/Makefile.in @@ -7,6 +7,7 @@ C_SRCS = \ interp.c \ lex.c \ regexp.c \ + utils.c \ vbdisp.c \ vbregexp.c \ vbscript.c \ diff --git a/dlls/vbscript/interp.c b/dlls/vbscript/interp.c index feb8119..2f414be 100644 --- a/dlls/vbscript/interp.c +++ b/dlls/vbscript/interp.c @@ -1148,6 +1148,18 @@ static HRESULT interp_newenum(exec_ctx_t *ctx) V_UNKNOWN(r) = (IUnknown*)iter; break; } + case VT_VARIANT|VT_ARRAY: + case VT_VARIANT|VT_ARRAY|VT_BYREF: { + IEnumVARIANT *iter; + + hres = create_safearray_iter(V_ISBYREF(v.v) ? *V_ARRAYREF(v.v) : V_ARRAY(v.v), &iter); + if(FAILED(hres)) + return hres; + + V_VT(r) = VT_UNKNOWN; + V_UNKNOWN(r) = (IUnknown*)iter; + break; + } default: FIXME("Unsupported for %s\n", debugstr_variant(v.v)); release_val(&v); diff --git a/dlls/vbscript/utils.c b/dlls/vbscript/utils.c new file mode 100644 index 0000000..d30842c --- /dev/null +++ b/dlls/vbscript/utils.c @@ -0,0 +1,193 @@ +/* + * Copyright 2017 Piotr Caban for CodeWeavers + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA + */ + +#include "vbscript.h" + +#include "wine/debug.h" + +WINE_DEFAULT_DEBUG_CHANNEL(vbscript); + +typedef struct { + IEnumVARIANT IEnumVARIANT_iface; + + LONG ref; + + SAFEARRAY *sa; + ULONG i, size; +} safearray_iter; + +static inline safearray_iter *impl_from_IEnumVARIANT(IEnumVARIANT *iface) +{ + return CONTAINING_RECORD(iface, safearray_iter, IEnumVARIANT_iface); +} + +static HRESULT WINAPI safearray_iter_IEnumVARIANT_QueryInterface( + IEnumVARIANT *iface, REFIID riid, void **ppv) +{ + safearray_iter *This = impl_from_IEnumVARIANT(iface); + + if(IsEqualGUID(riid, &IID_IUnknown)) { + TRACE("(%p)->(IID_IUnknown %p)\n", This, ppv); + *ppv = &This->IEnumVARIANT_iface; + }else if(IsEqualGUID(riid, &IID_IEnumVARIANT)) { + TRACE("(%p)->(IID_IEnumVARIANT %p)\n", This, ppv); + *ppv = &This->IEnumVARIANT_iface; + }else { + FIXME("(%p)->(%s %p)\n", This, debugstr_guid(riid), ppv); + *ppv = NULL; + return E_NOINTERFACE; + } + + IUnknown_AddRef((IUnknown*)*ppv); + return S_OK; +} + +static ULONG WINAPI safearray_iter_IEnumVARIANT_AddRef(IEnumVARIANT *iface) +{ + safearray_iter *This = impl_from_IEnumVARIANT(iface); + LONG ref = InterlockedIncrement(&This->ref); + + TRACE("(%p) ref=%d\n", This, ref); + + return ref; +} + +static ULONG WINAPI safearray_iter_IEnumVARIANT_Release(IEnumVARIANT *iface) +{ + safearray_iter *This = impl_from_IEnumVARIANT(iface); + LONG ref = InterlockedDecrement(&This->ref); + + TRACE("(%p) ref=%d\n", iface, ref); + + if(!ref) { + if(This->sa) + SafeArrayUnlock(This->sa); + heap_free(This); + } + + return ref; +} + +static HRESULT WINAPI safearray_iter_IEnumVARIANT_Next(IEnumVARIANT *iface, + ULONG celt, VARIANT *rgVar, ULONG *pCeltFetched) +{ + safearray_iter *This = impl_from_IEnumVARIANT(iface); + HRESULT hres; + VARIANT *v; + + TRACE("(%p)->(%u %p %p)\n", This, celt, rgVar, pCeltFetched); + + if(celt != 1) { + FIXME("celt != 1\n"); + return E_NOTIMPL; + } + + if(This->i >= This->size) { + if(pCeltFetched) + *pCeltFetched = 0; + return S_FALSE; + } + + if(!This->sa->cLocks) + ERR("SAFEARRAY not locked\n"); + + v = (VARIANT*)(((BYTE*)This->sa->pvData) + This->i * This->sa->cbElements); + V_VT(rgVar) = VT_EMPTY; + hres = VariantCopy(rgVar, v); + if(FAILED(hres)) + return hres; + + This->i++; + if(pCeltFetched) + *pCeltFetched = 1; + return S_OK; +} + +static HRESULT WINAPI safearray_iter_IEnumVARIANT_Skip(IEnumVARIANT *iface, ULONG celt) +{ + FIXME("\n"); + return E_NOTIMPL; +} + +static HRESULT WINAPI safearray_iter_IEnumVARIANT_Reset(IEnumVARIANT *iface) +{ + FIXME("\n"); + return E_NOTIMPL; +} + +static HRESULT WINAPI safearray_iter_IEnumVARIANT_Clone( + IEnumVARIANT *iface, IEnumVARIANT **ppEnum) +{ + FIXME("\n"); + return E_NOTIMPL; +} + +static const IEnumVARIANTVtbl safearray_iter_EnumVARIANTVtbl = { + safearray_iter_IEnumVARIANT_QueryInterface, + safearray_iter_IEnumVARIANT_AddRef, + safearray_iter_IEnumVARIANT_Release, + safearray_iter_IEnumVARIANT_Next, + safearray_iter_IEnumVARIANT_Skip, + safearray_iter_IEnumVARIANT_Reset, + safearray_iter_IEnumVARIANT_Clone +}; + +static ULONG get_safearray_size(SAFEARRAY *sa) +{ + ULONG ret = 1; + USHORT i; + + if(!sa) + return 0; + + for(i=0; i<sa->cDims && ret; i++) + ret *= sa->rgsabound[i].cElements; + return ret; +} + +HRESULT create_safearray_iter(SAFEARRAY *sa, IEnumVARIANT **ev) +{ + safearray_iter *iter; + HRESULT hres; + + if(sa && !(sa->fFeatures & FADF_VARIANT)) { + FIXME("enumeration not supported: %x\n", sa->fFeatures); + return E_NOTIMPL; + } + + iter = heap_alloc(sizeof(*iter)); + if(!iter) + return E_OUTOFMEMORY; + + if(sa) { + hres = SafeArrayLock(sa); + if(FAILED(hres)) { + heap_free(iter); + return hres; + } + } + + iter->IEnumVARIANT_iface.lpVtbl = &safearray_iter_EnumVARIANTVtbl; + iter->ref = 1; + iter->sa = sa; + iter->i = 0; + iter->size = get_safearray_size(sa); + + *ev = &iter->IEnumVARIANT_iface; + return S_OK; +} diff --git a/dlls/vbscript/vbscript.h b/dlls/vbscript/vbscript.h index d3be4f0..ec41737 100644 --- a/dlls/vbscript/vbscript.h +++ b/dlls/vbscript/vbscript.h @@ -391,6 +391,8 @@ HRESULT create_regexp(IDispatch**) DECLSPEC_HIDDEN; HRESULT map_hres(HRESULT) DECLSPEC_HIDDEN; +HRESULT create_safearray_iter(SAFEARRAY *sa, IEnumVARIANT **ev) DECLSPEC_HIDDEN; + #define FACILITY_VBS 0xa #define MAKE_VBSERROR(code) MAKE_HRESULT(SEVERITY_ERROR, FACILITY_VBS, code)

1 0