June 2017 - Wine-Commits - list.winehq.org

Owen Rudge : ws2_32: Extract IPv6 address from brackets in getaddrinfo.
by Alexandre Julliard June 13, 2017

June 13, 2017

Module: wine Branch: master Commit: accf5ef5947591ce6e18f64eebb9dacb9bbfdf3a URL: http://source.winehq.org/git/wine.git/?a=commit;h=accf5ef5947591ce6e18f64ee… Author: Owen Rudge <orudge(a)codeweavers.com> Date: Tue Jun 13 02:07:49 2017 -0300 ws2_32: Extract IPv6 address from brackets in getaddrinfo. Signed-off-by: Bruno Jesus <bjesus(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ws2_32/socket.c | 24 +++++++++++++++++++++++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/dlls/ws2_32/socket.c b/dlls/ws2_32/socket.c index 1524192..7a768ac 100644 --- a/dlls/ws2_32/socket.c +++ b/dlls/ws2_32/socket.c @@ -6557,7 +6557,7 @@ int WINAPI WS_getaddrinfo(LPCSTR nodename, LPCSTR servname, const struct WS_addr struct addrinfo *unixaires = NULL; int result; struct addrinfo unixhints, *punixhints = NULL; - char *hostname; + char *hostname, *nodeV6 = NULL; const char *node; *res = NULL; @@ -6575,8 +6575,28 @@ int WINAPI WS_getaddrinfo(LPCSTR nodename, LPCSTR servname, const struct WS_addr else if (!nodename[0]) node = hostname; else + { node = nodename; + /* Check for [ipv6] or [ipv6]:portnumber, which are supported by Windows */ + if (!hints || hints->ai_family == WS_AF_UNSPEC || hints->ai_family == WS_AF_INET6) + { + char *close_bracket; + + if (node[0] == '[' && (close_bracket = strchr(node + 1, ']'))) + { + nodeV6 = HeapAlloc(GetProcessHeap(), 0, close_bracket - node); + if (!nodeV6) + { + HeapFree(GetProcessHeap(), 0, hostname); + return WSA_NOT_ENOUGH_MEMORY; + } + lstrcpynA(nodeV6, node + 1, close_bracket - node); + node = nodeV6; + } + } + } + /* servname tweak required by OSX and BSD kernels */ if (servname && !servname[0]) servname = "0"; @@ -6598,6 +6618,7 @@ int WINAPI WS_getaddrinfo(LPCSTR nodename, LPCSTR servname, const struct WS_addr { SetLastError(WSAESOCKTNOSUPPORT); HeapFree(GetProcessHeap(), 0, hostname); + HeapFree(GetProcessHeap(), 0, nodeV6); return SOCKET_ERROR; } @@ -6630,6 +6651,7 @@ int WINAPI WS_getaddrinfo(LPCSTR nodename, LPCSTR servname, const struct WS_addr } TRACE("%s, %s %p -> %p %d\n", debugstr_a(nodename), debugstr_a(servname), hints, res, result); HeapFree(GetProcessHeap(), 0, hostname); + HeapFree(GetProcessHeap(), 0, nodeV6); if (!result) { struct addrinfo *xuai = unixaires;

1 0

Frédéric Delanoy : French translation for release 2.8
by Jeremy Newman June 13, 2017

June 13, 2017

Module: website Branch: master Commit: ed00e7e01a8a3af3a95abb96a471da104897b152 URL: http://source.winehq.org/git/website.git/?a=commit;h=ed00e7e01a8a3af3a95abb… Author: Frédéric Delanoy <frederic.delanoy(a)gmail.com> Date: Tue Jun 13 21:13:23 2017 +0200 French translation for release 2.8 Signed-off-by: Frédéric Delanoy <frederic.delanoy(a)gmail.com> Signed-off-by: Jeremy Newman <jnewman(a)codeweavers.com> --- news/fr/2017051201.xml | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/news/fr/2017051201.xml b/news/fr/2017051201.xml new file mode 100644 index 0000000..03a174a --- /dev/null +++ b/news/fr/2017051201.xml @@ -0,0 +1,15 @@ +<news> +<date>12 mai 2017</date> +<title>Sortie de Wine 2.8</title> +<body> +La version de développement 2.8 de Wine est disponible. +<a href="{$root}/announce/2.8">Nouveautés</a> de cette version : +<ul> + <li>Le flux de commandes Direct3D tourne de façon asynchrone.</li> + <li>Meilleure autodétection des ports série et parallèle.</li> + <li>Correctifs additionnels pour les réglages points par pouce (PPP) élevés.</li> + <li>Notifications dans la zone de notification système sous macOS.</li> + <li>Diverses corrections de bugs.</li> +</ul> +Le <a href="//dl.winehq.org/wine/source/2.x/wine-2.8.tar.xz">code source</a> est disponible dès à présent. Les paquets binaires sont en cours de construction, et apparaîtront sous peu sur leurs <a href="{$root}/download">sites de téléchargement</a> respectifs. +</body></news>

1 0

Frédéric Delanoy : French translation for release 2.7
by Jeremy Newman June 13, 2017

June 13, 2017

Module: website Branch: master Commit: 51f819ecc37b1e471177384d3750fe2cc3fb9849 URL: http://source.winehq.org/git/website.git/?a=commit;h=51f819ecc37b1e47117738… Author: Frédéric Delanoy <frederic.delanoy(a)gmail.com> Date: Tue Jun 13 21:13:22 2017 +0200 French translation for release 2.7 Signed-off-by: Frédéric Delanoy <frederic.delanoy(a)gmail.com> Signed-off-by: Jeremy Newman <jnewman(a)codeweavers.com> --- news/fr/2017042801.xml | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/news/fr/2017042801.xml b/news/fr/2017042801.xml new file mode 100644 index 0000000..1afce2c --- /dev/null +++ b/news/fr/2017042801.xml @@ -0,0 +1,17 @@ +<news> +<date>28 avril 2017</date> +<title>Sortie de Wine 2.7</title> +<body> +La version de développement 2.7 de Wine est disponible. +<a href="{$root}/announce/2.7">Nouveautés</a> de cette version : +<ul> + <li>Prise en charge des connections TCP et UDP dans WebServices.</li> + <li>Diverses améliorations des shaders pour Direct3D 11.</li> + <li>Meilleure prise en charge des réglages points par pouce (PPP) élevés.</li> + <li>Réimplémentation partielle de la bibliothèque GLU.</li> + <li>Prise en charge des versions récentes de OSMesa.</li> + <li>Améliorations dans la gestion des fenêtres sous macOS.</li> + <li>Diverses corrections de bugs.</li> +</ul> +Le <a href="//dl.winehq.org/wine/source/2.x/wine-2.7.tar.xz">code source</a> est disponible dès à présent. Les paquets binaires sont en cours de construction, et apparaîtront sous peu sur leurs <a href="{$root}/download">sites de téléchargement</a> respectifs. +</body></news>

1 0

Frédéric Delanoy : French translation for release 2.10
by Jeremy Newman June 13, 2017

June 13, 2017

Module: website Branch: master Commit: 156c17c660d6fe2d34fe107c6f41d885d1725a35 URL: http://source.winehq.org/git/website.git/?a=commit;h=156c17c660d6fe2d34fe10… Author: Frédéric Delanoy <frederic.delanoy(a)gmail.com> Date: Tue Jun 13 21:13:25 2017 +0200 French translation for release 2.10 Signed-off-by: Frédéric Delanoy <frederic.delanoy(a)gmail.com> Signed-off-by: Jeremy Newman <jnewman(a)codeweavers.com> --- news/fr/2017060901.xml | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/news/fr/2017060901.xml b/news/fr/2017060901.xml new file mode 100644 index 0000000..207a8c6 --- /dev/null +++ b/news/fr/2017060901.xml @@ -0,0 +1,16 @@ +<news> +<date>9 juin 2017</date> +<title>Sortie de Wine 2.10</title> +<body> +La version de développement 2.10 de Wine est disponible. +<a href="{$root}/announce/2.10">Nouveautés</a> de cette version : +<ul> + <li>Version initiale du pilote graphique Android.</li> + <li>Prise en charge des dictionnaires dans WebServices.</li> + <li>Quelques correctifs Direct2D.</li> + <li>Améliorations dans l'interface utilisateur de RegEdit.</li> + <li>Correctifs pour le cache du presse-papiers OLE.</li> + <li>Diverses corrections de bugs.</li> +</ul> +Le <a href="//dl.winehq.org/wine/source/2.x/wine-2.10.tar.xz">code source</a> est disponible dès à présent. Les paquets binaires sont en cours de construction, et apparaîtront sous peu sur leurs <a href="{$root}/download">sites de téléchargement</a> respectifs. +</body></news>

1 0

Frédéric Delanoy : French translation for release 2.9
by Jeremy Newman June 13, 2017

June 13, 2017

Module: website Branch: master Commit: 3732957f000231ba519426c1ec66b99f848cb050 URL: http://source.winehq.org/git/website.git/?a=commit;h=3732957f000231ba519426… Author: Frédéric Delanoy <frederic.delanoy(a)gmail.com> Date: Tue Jun 13 21:13:24 2017 +0200 French translation for release 2.9 Signed-off-by: Frédéric Delanoy <frederic.delanoy(a)gmail.com> Signed-off-by: Jeremy Newman <jnewman(a)codeweavers.com> --- news/fr/2017052601.xml | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/news/fr/2017052601.xml b/news/fr/2017052601.xml new file mode 100644 index 0000000..6bf177b --- /dev/null +++ b/news/fr/2017052601.xml @@ -0,0 +1,15 @@ +<news> +<date>26 mai 2017</date> +<title>Sortie de Wine 2.9</title> +<body> +La version de développement 2.9 de Wine est disponible. +<a href="{$root}/announce/2.9">Nouveautés</a> de cette version : +<ul> + <li>Prise en charge des shaders de tesselation dans Direct3D.</li> + <li>Prise en charge du mode binaire dans WebServices.</li> + <li>Modifications du presse-papiers détectés via Xfixes.</li> + <li>Améliorations dans l'interface utilisateur de RegEdit.</li> + <li>Diverses corrections de bugs.</li> +</ul> +Le <a href="//dl.winehq.org/wine/source/2.x/wine-2.9.tar.xz">code source</a> est disponible dès à présent. Les paquets binaires sont en cours de construction, et apparaîtront sous peu sur leurs <a href="{$root}/download">sites de téléchargement</a> respectifs. +</body></news>

1 0

Francois Gouget : winetest: Let dissect detect and report crashes.
by Alexandre Julliard June 13, 2017

June 13, 2017

Module: tools Branch: master Commit: ee648b52fea5d4d94cb46ffcffd73003cd9525d4 URL: http://source.winehq.org/git/tools.git/?a=commit;h=ee648b52fea5d4d94cb46ffc… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Tue Jun 13 10:36:49 2017 +0200 winetest: Let dissect detect and report crashes. A 'failed crash' line in the summary.txt file now identifies tests that crashed. This way gather does not have to duplicate the dissect code to correctly identify crashed tests (except temporarily for backward compatibility with old summary.txt files). Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- winetest/dissect | 2 +- winetest/gather | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/winetest/dissect b/winetest/dissect index 4901e97..1ecbd94 100755 --- a/winetest/dissect +++ b/winetest/dissect @@ -465,7 +465,7 @@ while (<IN>) { } elsif (/$dll:$unit(?::[0-9a-f]+)? done $(-?\d+)$(?:\r?$| in)/) { chomp; # current test ended if ($lines==0 || $1 < 0) { - $result = "failed $1 - -"; + $result = "failed ". ($1 < 0 ? "crash" : $1) ." - -"; my $reason = "test failed: error $1"; if ($1 == 258) { $reason = "test failed: timed out"; } elsif ($1 < 0) { $reason = "test failed: crash"; } diff --git a/winetest/gather b/winetest/gather index 907b205..fbf0397 100755 --- a/winetest/gather +++ b/winetest/gather @@ -324,7 +324,9 @@ foreach my $file (glob "$builddir/*/summary.txt") { $alltests{$testname} = $source; if ($count eq "failed") { - if ($todos eq "filelimit") { + if ($todos eq "crash") { + $report->{$testname} = { status => "crash" }; + } elsif ($todos eq "filelimit") { $report->{$testname} = { status => "file limit" }; $report->{filelimit} = $testname; } else {

1 0

Francois Gouget : testbot/WineRunTask: Better deal with single test unit executables.
by Alexandre Julliard June 13, 2017

June 13, 2017

Module: tools Branch: master Commit: 440f41dad071bf8007311429e68a980cb0d82245 URL: http://source.winehq.org/git/tools.git/?a=commit;h=440f41dad071bf8007311429… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Tue Jun 13 10:14:55 2017 +0200 testbot/WineRunTask: Better deal with single test unit executables. If a Wine test executable has a single test unit, then one can upload and run it without a parameter. In that case TestLauncher does not the test unit name and thus does not print it on the start line. So WineRunTask ends up with $CurrentUnit="" and must account for it when it compares it to the test unit of skip lines. This should also be factored when determining whether the test output follows the Wine test standards. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- testbot/bin/WineRunTask.pl | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/testbot/bin/WineRunTask.pl b/testbot/bin/WineRunTask.pl index 7122c57..cd74119 100755 --- a/testbot/bin/WineRunTask.pl +++ b/testbot/bin/WineRunTask.pl @@ -477,7 +477,7 @@ if ($TA->GetFile($RptFileName, $FullLogFileName)) sub CheckUnit($$) { my ($Unit, $Type) = @_; - if ($Unit eq $CurrentUnit) + if ($Unit eq $CurrentUnit or $CurrentUnit eq "") { $IsWineTest = 1; } @@ -600,10 +600,14 @@ if ($TA->GetFile($RptFileName, $FullLogFileName)) ($CurrentUnit ne "" and $Line =~ /($CurrentUnit)(?:\.c)?:\d+:? Tests? skipped: /)) { + my $Unit = $1; # Don't complain and don't count misplaced skips. Only complain if they # are misreported (see CloseTestUnit). Also TestLauncher uses the wrong # name in its skip message when skipping tests. - $LineSkips++ if ($1 eq $CurrentUnit or $1 eq $CurrentDll); + if ($Unit eq $CurrentUnit or $CurrentUnit eq "" or $Unit eq $CurrentDll) + { + $LineSkips++; + } } elsif ($Line =~ /^Fatal: test '([_a-z0-9]+)' does not exist/) {

1 0

Francois Gouget : testbot/TestLauncher: Tweak the formats to fix MinGW warnings.
by Alexandre Julliard June 13, 2017

June 13, 2017

Module: tools Branch: master Commit: b71ad564a5cce053cd26ce193b5a4e272e31fa89 URL: http://source.winehq.org/git/tools.git/?a=commit;h=b71ad564a5cce053cd26ce19… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Tue Jun 13 10:23:21 2017 +0200 testbot/TestLauncher: Tweak the formats to fix MinGW warnings. DWORD equates to an unsigned long. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- testbot/src/TestLauncher/TestLauncher.c | 42 ++++++++++++++++----------------- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/testbot/src/TestLauncher/TestLauncher.c b/testbot/src/TestLauncher/TestLauncher.c index a790470..ed7fffb 100644 --- a/testbot/src/TestLauncher/TestLauncher.c +++ b/testbot/src/TestLauncher/TestLauncher.c @@ -114,14 +114,14 @@ static BOOL AllImportedDllsPresent(char *TestExeName) TestExe = CreateFileA(TestExeName, GENERIC_READ, FILE_SHARE_READ, NULL, OPEN_EXISTING, 0, NULL); if (TestExe == INVALID_HANDLE_VALUE) { - ReportError("Can't open test executable %s, error %u\n", TestExeName, GetLastError()); + ReportError("Can't open test executable %s, error %lu\n", TestExeName, GetLastError()); return FALSE; } if (! ReadFile(TestExe, &DosHeader, sizeof(IMAGE_DOS_HEADER), &NR, NULL) || NR != sizeof(IMAGE_DOS_HEADER)) { CloseHandle(TestExe); - ReportError("Can't read DOS header from %s, error %u\n", TestExeName, GetLastError()); + ReportError("Can't read DOS header from %s, error %lu\n", TestExeName, GetLastError()); return FALSE; } if (DosHeader.e_magic != IMAGE_DOS_SIGNATURE) @@ -135,20 +135,20 @@ static BOOL AllImportedDllsPresent(char *TestExeName) if (NewPos == INVALID_SET_FILE_POINTER && GetLastError() != ERROR_SUCCESS) { CloseHandle(TestExe); - ReportError("Can't move to NT headers in %s, error %u\n", TestExeName, GetLastError()); + ReportError("Can't move to NT headers in %s, error %lu\n", TestExeName, GetLastError()); return FALSE; } if (! ReadFile(TestExe, &NTHeaders, sizeof(IMAGE_NT_HEADERS), &NR, NULL) || NR != sizeof(IMAGE_NT_HEADERS)) { CloseHandle(TestExe); - ReportError("Can't read NT headers from %s, error %u\n", TestExeName, GetLastError()); + ReportError("Can't read NT headers from %s, error %lu\n", TestExeName, GetLastError()); return FALSE; } if (NTHeaders.Signature != IMAGE_NT_SIGNATURE || NTHeaders.OptionalHeader.Magic != IMAGE_NT_OPTIONAL_HDR_MAGIC) { CloseHandle(TestExe); - ReportError("%s does not contain valid NT headers expected 0x%08x/0x%04x found 0x%08x/0x%04x\n", TestExeName, + ReportError("%s does not contain valid NT headers expected 0x%08x/0x%04x found 0x%08lx/0x%04x\n", TestExeName, IMAGE_NT_SIGNATURE, IMAGE_NT_OPTIONAL_HDR_MAGIC, NTHeaders.Signature, NTHeaders.OptionalHeader.Magic); return FALSE; } @@ -156,7 +156,7 @@ static BOOL AllImportedDllsPresent(char *TestExeName) if (DataDirectoryImportTable->VirtualAddress == 0 || DataDirectoryImportTable->Size == 0) { CloseHandle(TestExe); - ReportError("%s does not contain valid a valid import table (RVA 0x%x size 0x%x)\n", TestExeName, + ReportError("%s does not contain valid a valid import table (RVA 0x%lx size 0x%lx)\n", TestExeName, DataDirectoryImportTable->VirtualAddress, DataDirectoryImportTable->Size); return FALSE; } @@ -173,7 +173,7 @@ static BOOL AllImportedDllsPresent(char *TestExeName) { free(SectionHeaders); CloseHandle(TestExe); - ReportError("Can't read section headers from %s, error %u\n", TestExeName, GetLastError()); + ReportError("Can't read section headers from %s, error %lu\n", TestExeName, GetLastError()); return FALSE; } @@ -201,7 +201,7 @@ static BOOL AllImportedDllsPresent(char *TestExeName) free(ImportDescriptors); free(SectionHeaders); CloseHandle(TestExe); - ReportError("Can't move to import directory in %s, error %u\n", TestExeName, GetLastError()); + ReportError("Can't move to import directory in %s, error %lu\n", TestExeName, GetLastError()); return FALSE; } @@ -210,7 +210,7 @@ static BOOL AllImportedDllsPresent(char *TestExeName) free(ImportDescriptors); free(SectionHeaders); CloseHandle(TestExe); - ReportError("Can't read import directory from %s, error %u\n", TestExeName, GetLastError()); + ReportError("Can't read import directory from %s, error %lu\n", TestExeName, GetLastError()); return FALSE; } @@ -234,7 +234,7 @@ static BOOL AllImportedDllsPresent(char *TestExeName) free(ImportDescriptors); free(SectionHeaders); CloseHandle(TestExe); - ReportError("Can't move to import module name in %s, error %u\n", TestExeName, GetLastError()); + ReportError("Can't move to import module name in %s, error %lu\n", TestExeName, GetLastError()); return FALSE; } @@ -243,7 +243,7 @@ static BOOL AllImportedDllsPresent(char *TestExeName) free(ImportDescriptors); free(SectionHeaders); CloseHandle(TestExe); - ReportError("Can't read import directory from %s, error %u\n", TestExeName, GetLastError()); + ReportError("Can't read import directory from %s, error %lu\n", TestExeName, GetLastError()); return FALSE; } @@ -329,7 +329,7 @@ int main(int argc, char *argv[]) { if (GetFullPathNameA(argv[Arg], countof(TestExeFullName), TestExeFullName, &TestExeFileName) == 0) { - fprintf(stderr, "Can't determine full path of test executable %s, error %u\n", + fprintf(stderr, "Can't determine full path of test executable %s, error %lu\n", argv[Arg], GetLastError()); exit(1); } @@ -396,7 +396,7 @@ int main(int argc, char *argv[]) if (! CreateProcessA(NULL, CommandLine, NULL, NULL, TRUE, CREATE_DEFAULT_ERROR_MODE, NULL, NULL, &StartupInfo, &ProcessInformation)) { - fprintf(stderr, "CreateProcess failed with error %u\n", GetLastError()); + fprintf(stderr, "CreateProcess failed with error %lu\n", GetLastError()); exit(1); } @@ -407,20 +407,20 @@ int main(int argc, char *argv[]) switch(WaitStatus) { case WAIT_FAILED: - fprintf(stderr, "Wait for child failed, error %u\n", GetLastError()); + fprintf(stderr, "Wait for child failed, error %lu\n", GetLastError()); break; case WAIT_TIMEOUT: break; default: - fprintf(stderr, "Unexpected return value %u from wait for child\n", WaitStatus); + fprintf(stderr, "Unexpected return value %lu from wait for child\n", WaitStatus); break; } ExitCode = WaitStatus; if (! TerminateProcess(ProcessInformation.hProcess, 257)) - fprintf(stderr, "TerminateProcess failed with error %u\n", GetLastError()); + fprintf(stderr, "TerminateProcess failed with error %lu\n", GetLastError()); switch (WaitForSingleObject(ProcessInformation.hProcess, 5000)) { @@ -428,7 +428,7 @@ int main(int argc, char *argv[]) break; case WAIT_FAILED: - fprintf(stderr, "Wait for terminate failed, error %u\n", GetLastError()); + fprintf(stderr, "Wait for terminate failed, error %lu\n", GetLastError()); break; case WAIT_TIMEOUT: @@ -436,7 +436,7 @@ int main(int argc, char *argv[]) break; default: - fprintf(stderr, "Unexpected return value %u from wait for terminate\n", WaitStatus); + fprintf(stderr, "Unexpected return value %lu from wait for terminate\n", WaitStatus); break; } } @@ -445,12 +445,12 @@ int main(int argc, char *argv[]) if (! GetExitCodeProcess(ProcessInformation.hProcess, &ExitCode)) { ExitCode = 259; - fprintf(stderr, "Can't get child exit code, error %u\n", GetLastError()); + fprintf(stderr, "Can't get child exit code, error %lu\n", GetLastError()); } } CloseHandle(ProcessInformation.hProcess); - printf("%s:%s done (%u)\n", TestName, Subtest, ExitCode); + printf("%s:%s done (%lu)\n", TestName, Subtest, ExitCode); - return 0; + return 0; }

1 0

Henri Verbeet : wined3d: Also check for "Mesa" in GL_VERSION in wined3d_guess_gl_vendor().
by Alexandre Julliard June 12, 2017

June 12, 2017

Module: wine Branch: master Commit: 1d3a8a5ded30674681c335714bb019a561e88e39 URL: http://source.winehq.org/git/wine.git/?a=commit;h=1d3a8a5ded30674681c335714… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Mon Jun 12 14:01:43 2017 +0200 wined3d: Also check for "Mesa" in GL_VERSION in wined3d_guess_gl_vendor(). The existing checks should be sufficient, but the GL_VERSION one is potentially more reliable. Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wined3d/directx.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/dlls/wined3d/directx.c b/dlls/wined3d/directx.c index 7ad944f..9707f81 100644 --- a/dlls/wined3d/directx.c +++ b/dlls/wined3d/directx.c @@ -1761,7 +1761,7 @@ static DWORD wined3d_parse_gl_version(const char *gl_version) } static enum wined3d_gl_vendor wined3d_guess_gl_vendor(const struct wined3d_gl_info *gl_info, - const char *gl_vendor_string, const char *gl_renderer) + const char *gl_vendor_string, const char *gl_renderer, const char *gl_version) { /* MacOS has various specialities in the extensions it advertises. Some have to be loaded from * the opengl 1.2+ core, while other extensions are advertised, but software emulated. So try to @@ -1792,7 +1792,8 @@ static enum wined3d_gl_vendor wined3d_guess_gl_vendor(const struct wined3d_gl_in || strstr(gl_vendor_string, "Intel") || strstr(gl_renderer, "Mesa") || strstr(gl_renderer, "Gallium") - || strstr(gl_renderer, "Intel")) + || strstr(gl_renderer, "Intel") + || strstr(gl_version, "Mesa")) return GL_VENDOR_MESA; FIXME("Received unrecognized GL_VENDOR %s. Returning GL_VENDOR_UNKNOWN.\n", @@ -4350,7 +4351,7 @@ static BOOL wined3d_adapter_init_gl_caps(struct wined3d_adapter *adapter, checkGLcall("creating VAO"); } - gl_vendor = wined3d_guess_gl_vendor(gl_info, gl_vendor_str, gl_renderer_str); + gl_vendor = wined3d_guess_gl_vendor(gl_info, gl_vendor_str, gl_renderer_str, gl_version_str); TRACE("Guessed GL vendor %#x.\n", gl_vendor); if (!(gpu_description = query_gpu_description(gl_info, &vram_bytes)))

1 0

Matteo Bruni : d3dx9/tests: Add a comment about the negation in boolean constant checks.
by Alexandre Julliard June 12, 2017

June 12, 2017

Module: wine Branch: master Commit: 82029cba2fcc49c39902f4ba3247c6216fdb9304 URL: http://source.winehq.org/git/wine.git/?a=commit;h=82029cba2fcc49c39902f4ba3… Author: Matteo Bruni <mbruni(a)codeweavers.com> Date: Fri Jun 9 21:19:38 2017 +0200 d3dx9/tests: Add a comment about the negation in boolean constant checks. Signed-off-by: Matteo Bruni <mbruni(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/d3dx9_36/tests/effect.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/dlls/d3dx9_36/tests/effect.c b/dlls/d3dx9_36/tests/effect.c index 20da3c6..d75c5ce 100644 --- a/dlls/d3dx9_36/tests/effect.c +++ b/dlls/d3dx9_36/tests/effect.c @@ -4350,6 +4350,8 @@ static void test_effect_preshader_compare_pbool_consts_(unsigned int line, IDire { for (i = 0; i < ARRAY_SIZE(test_effect_preshader_bconsts); ++i) { + /* The negation on both sides is actually needed, sometimes you + * get 0xffffffff instead of 1 on native. */ ok_(__FILE__, line)(!bdata[i] == !test_effect_preshader_bconsts[i], "Pixel shader boolean constants do not match, expected %#x, got %#x, i %u.\n", test_effect_preshader_bconsts[i], bdata[i], i); @@ -4362,6 +4364,8 @@ static void test_effect_preshader_compare_pbool_consts_(unsigned int line, IDire if (const_updated_mask[i / TEST_EFFECT_BITMASK_BLOCK_SIZE] & (1u << (i % TEST_EFFECT_BITMASK_BLOCK_SIZE))) { + /* The negation on both sides is actually needed, sometimes + * you get 0xffffffff instead of 1 on native. */ ok_(__FILE__, line)(!bdata[i] == !test_effect_preshader_bconsts[i], "Pixel shader boolean constants do not match, expected %#x, got %#x, i %u, parameter %s.\n", test_effect_preshader_bconsts[i], bdata[i], i, updated_param);

1 0