January 2018 - Wine-Commits

Stefan Dösinger : ddraw/tests: Mark WARP negative rectangle handling broken.
by Alexandre Julliard Jan. 10, 2018

Jan. 10, 2018

Module: wine Branch: master Commit: dcb0d32bfa0e90ec273d51797f415051992bd6ae URL: https://source.winehq.org/git/wine.git/?a=commit;h=dcb0d32bfa0e90ec273d5179… Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Wed Jan 10 21:06:03 2018 +0100 ddraw/tests: Mark WARP negative rectangle handling broken. Signed-off-by: Stefan Dösinger <stefan(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ddraw/tests/ddraw1.c | 32 ++++++++++++++++++++++++++------ dlls/ddraw/tests/ddraw2.c | 32 ++++++++++++++++++++++++++------ dlls/ddraw/tests/ddraw4.c | 39 +++++++++++++++++++++++++++++++++------ dlls/ddraw/tests/ddraw7.c | 39 +++++++++++++++++++++++++++++++++------ 4 files changed, 118 insertions(+), 24 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=dcb0d32bfa0e90ec273d…

1 0

Jacek Caban : mshtml/tests: Skip test_listener_order tests on IE7.
by Alexandre Julliard Jan. 10, 2018

Jan. 10, 2018

Module: wine Branch: master Commit: 5dbf2726fe984e821ef29febd4a7c6c02c2b02cf URL: https://source.winehq.org/git/wine.git/?a=commit;h=5dbf2726fe984e821ef29feb… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Jan 10 22:59:55 2018 +0100 mshtml/tests: Skip test_listener_order tests on IE7. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mshtml/tests/events.html | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/dlls/mshtml/tests/events.html b/dlls/mshtml/tests/events.html index 39860ff..8bf2c50 100644 --- a/dlls/mshtml/tests/events.html +++ b/dlls/mshtml/tests/events.html @@ -235,6 +235,11 @@ function test_attach_event() { } function test_listener_order() { + if(!("documentMode" in document)) { + win_skip("Skipping test_listener_order on too old IE"); + return; + } + var div = document.createElement("div"); document.body.appendChild(div);

1 0

Alex Henrie : msvcrt: Don' t include MSVC 8.0+ function _CRT_RTC_INITW in SOs for older DLLs.
by Alexandre Julliard Jan. 10, 2018

Jan. 10, 2018

Module: wine Branch: master Commit: 6defbd1b503ed450943bbe3623c058a0b0ada8a5 URL: https://source.winehq.org/git/wine.git/?a=commit;h=6defbd1b503ed450943bbe36… Author: Alex Henrie <alexhenrie24(a)gmail.com> Date: Tue Jan 9 23:21:45 2018 -0700 msvcrt: Don't include MSVC 8.0+ function _CRT_RTC_INITW in SOs for older DLLs. Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/msvcrt/misc.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/dlls/msvcrt/misc.c b/dlls/msvcrt/misc.c index d784dec..8f18aa4 100644 --- a/dlls/msvcrt/misc.c +++ b/dlls/msvcrt/misc.c @@ -457,7 +457,6 @@ void * CDECL _encoded_null(void) #endif /* _MSVCR_VER>=80 */ #if _MSVCR_VER>=70 - /********************************************************************* * _CRT_RTC_INIT (MSVCR70.@) */ @@ -466,9 +465,12 @@ void* CDECL _CRT_RTC_INIT(void *unk1, void *unk2, int unk3, int unk4, int unk5) TRACE("%p %p %x %x %x\n", unk1, unk2, unk3, unk4, unk5); return NULL; } +#endif + +#if _MSVCR_VER>=80 /********************************************************************* - * _CRT_RTC_INITW (MSVCR70.@) + * _CRT_RTC_INITW (MSVCR80.@) */ void* CDECL _CRT_RTC_INITW(void *unk1, void *unk2, int unk3, int unk4, int unk5) { @@ -476,10 +478,6 @@ void* CDECL _CRT_RTC_INITW(void *unk1, void *unk2, int unk3, int unk4, int unk5) return NULL; } -#endif /* _MSVCR_VER>=70 */ - -#if _MSVCR_VER>=80 - /********************************************************************* * _byteswap_ushort (MSVCR80.@) */

1 0

Józef Kucia : d3d11: Handle 3D textures in wined3d_resource_from_d3d10_resource().
by Alexandre Julliard Jan. 10, 2018

Jan. 10, 2018

Module: wine Branch: master Commit: 4a6d3c7eac0ef5941030998a0ad6bba9223b33e7 URL: https://source.winehq.org/git/wine.git/?a=commit;h=4a6d3c7eac0ef5941030998a… Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Wed Jan 10 17:26:33 2018 +0100 d3d11: Handle 3D textures in wined3d_resource_from_d3d10_resource(). Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/d3d11/d3d11_private.h | 1 + dlls/d3d11/texture.c | 8 ++++++++ dlls/d3d11/utils.c | 4 ++++ 3 files changed, 13 insertions(+) diff --git a/dlls/d3d11/d3d11_private.h b/dlls/d3d11/d3d11_private.h index 4d9f34e..e7fd3a7 100644 --- a/dlls/d3d11/d3d11_private.h +++ b/dlls/d3d11/d3d11_private.h @@ -152,6 +152,7 @@ struct d3d_texture3d HRESULT d3d_texture3d_create(struct d3d_device *device, const D3D11_TEXTURE3D_DESC *desc, const D3D11_SUBRESOURCE_DATA *data, struct d3d_texture3d **texture) DECLSPEC_HIDDEN; struct d3d_texture3d *unsafe_impl_from_ID3D11Texture3D(ID3D11Texture3D *iface) DECLSPEC_HIDDEN; +struct d3d_texture3d *unsafe_impl_from_ID3D10Texture3D(ID3D10Texture3D *iface) DECLSPEC_HIDDEN; /* ID3D11Buffer, ID3D10Buffer */ struct d3d_buffer diff --git a/dlls/d3d11/texture.c b/dlls/d3d11/texture.c index 177c0cc..17fb4b1 100644 --- a/dlls/d3d11/texture.c +++ b/dlls/d3d11/texture.c @@ -924,6 +924,14 @@ static const struct ID3D10Texture3DVtbl d3d10_texture3d_vtbl = d3d10_texture3d_GetDesc, }; +struct d3d_texture3d *unsafe_impl_from_ID3D10Texture3D(ID3D10Texture3D *iface) +{ + if (!iface) + return NULL; + assert(iface->lpVtbl == &d3d10_texture3d_vtbl); + return CONTAINING_RECORD(iface, struct d3d_texture3d, ID3D10Texture3D_iface); +} + struct d3d_texture3d *unsafe_impl_from_ID3D11Texture3D(ID3D11Texture3D *iface) { if (!iface) diff --git a/dlls/d3d11/utils.c b/dlls/d3d11/utils.c index e919c58..c9e137c 100644 --- a/dlls/d3d11/utils.c +++ b/dlls/d3d11/utils.c @@ -637,6 +637,10 @@ struct wined3d_resource *wined3d_resource_from_d3d10_resource(ID3D10Resource *re return wined3d_texture_get_resource(unsafe_impl_from_ID3D10Texture2D( (ID3D10Texture2D *)resource)->wined3d_texture); + case D3D10_RESOURCE_DIMENSION_TEXTURE3D: + return wined3d_texture_get_resource(unsafe_impl_from_ID3D10Texture3D( + (ID3D10Texture3D *)resource)->wined3d_texture); + default: FIXME("Unhandled resource dimension %#x.\n", dimension); return NULL;

1 0

Alex Henrie : msvcrt: Don' t include MSVC 7.0+ exception functions in SOs for older DLLs.
by Alexandre Julliard Jan. 10, 2018

Jan. 10, 2018

Module: wine Branch: master Commit: 9be95285c38a4ffada8136a1fe25807d640db68b URL: https://source.winehq.org/git/wine.git/?a=commit;h=9be95285c38a4ffada8136a1… Author: Alex Henrie <alexhenrie24(a)gmail.com> Date: Tue Jan 9 23:21:42 2018 -0700 msvcrt: Don't include MSVC 7.0+ exception functions in SOs for older DLLs. Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/msvcrt/except.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/dlls/msvcrt/except.c b/dlls/msvcrt/except.c index 8d13e7f..13698f8 100644 --- a/dlls/msvcrt/except.c +++ b/dlls/msvcrt/except.c @@ -41,7 +41,9 @@ WINE_DEFAULT_DEBUG_CHANNEL(seh); +#if _MSVCR_VER>=70 && _MSVCR_VER<=71 static MSVCRT_security_error_handler security_error_handler; +#endif static MSVCRT___sighandler_t sighandlers[MSVCRT_NSIG] = { MSVCRT_SIG_DFL }; @@ -294,6 +296,8 @@ BOOL CDECL MSVCRT___uncaught_exception(void) return FALSE; } +#if _MSVCR_VER>=70 && _MSVCR_VER<=71 + /********************************************************************* * _set_security_error_handler (MSVCR70.@) */ @@ -321,6 +325,8 @@ void CDECL __security_error_handler(int code, void *data) MSVCRT__exit(3); } +#endif /* _MSVCR_VER>=70 && _MSVCR_VER<=71 */ + #if _MSVCR_VER>=110 /********************************************************************* * __crtSetUnhandledExceptionFilter (MSVCR110.@) @@ -470,8 +476,10 @@ struct __std_exception_data { MSVCRT_bool dofree; }; +#if _MSVCR_VER>=140 + /********************************************************************* - * __std_exception_copy (MSVCRT.@) + * __std_exception_copy (UCRTBASE.@) */ void CDECL MSVCRT___std_exception_copy(const struct __std_exception_data *src, struct __std_exception_data *dst) @@ -488,7 +496,7 @@ void CDECL MSVCRT___std_exception_copy(const struct __std_exception_data *src, } /********************************************************************* - * __std_exception_destroy (MSVCRT.@) + * __std_exception_destroy (UCRTBASE.@) */ void CDECL MSVCRT___std_exception_destroy(struct __std_exception_data *data) { @@ -499,3 +507,5 @@ void CDECL MSVCRT___std_exception_destroy(struct __std_exception_data *data) data->what = NULL; data->dofree = 0; } + +#endif /* _MSVCR_VER>=140 */

1 0

Alex Henrie : msxml3/tests: Add missing return value checks to domdoc tests (Coverity).
by Alexandre Julliard Jan. 10, 2018

Jan. 10, 2018

Module: wine Branch: master Commit: b8711196b14b5240962a1191affc0700a464507e URL: https://source.winehq.org/git/wine.git/?a=commit;h=b8711196b14b5240962a1191… Author: Alex Henrie <alexhenrie24(a)gmail.com> Date: Mon Jan 8 21:19:47 2018 -0700 msxml3/tests: Add missing return value checks to domdoc tests (Coverity). Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/msxml3/tests/domdoc.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/dlls/msxml3/tests/domdoc.c b/dlls/msxml3/tests/domdoc.c index 87a885d..26555d2 100644 --- a/dlls/msxml3/tests/domdoc.c +++ b/dlls/msxml3/tests/domdoc.c @@ -6460,7 +6460,8 @@ static void test_save(void) hr = IXMLDOMDocument_loadXML(doc, _bstr_(win1252xml), &b); EXPECT_HR(hr, S_OK); - CreateStreamOnHGlobal(NULL, TRUE, &stream); + hr = CreateStreamOnHGlobal(NULL, TRUE, &stream); + ok(hr == S_OK, "got 0x%08x\n", hr); V_VT(&dest) = VT_UNKNOWN; V_UNKNOWN(&dest) = (IUnknown*)stream; hr = IXMLDOMDocument_save(doc, dest); @@ -10950,7 +10951,8 @@ static void test_dispex(void) /* IXMLDOMNodeList */ hr = IXMLDOMDocument_getElementsByTagName(doc, _bstr_("*"), &node_list); EXPECT_HR(hr, S_OK); - IXMLDOMNodeList_QueryInterface(node_list, &IID_IUnknown, (void**)&unk); + hr = IXMLDOMNodeList_QueryInterface(node_list, &IID_IUnknown, (void**)&unk); + ok(hr == S_OK, "got 0x%08x\n", hr); test_domobj_dispex(unk); IUnknown_Release(unk); IXMLDOMNodeList_Release(node_list);

1 0

Józef Kucia : include: Add EnableMouseInPointer() declaration.
by Alexandre Julliard Jan. 10, 2018

Jan. 10, 2018

Module: wine Branch: master Commit: 45ea40a14a6584ec60333af14a0ed6aef31be85f URL: https://source.winehq.org/git/wine.git/?a=commit;h=45ea40a14a6584ec60333af1… Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Tue Jan 9 15:57:54 2018 +0100 include: Add EnableMouseInPointer() declaration. Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- include/winuser.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/winuser.h b/include/winuser.h index 75bfe2b..05bf590 100644 --- a/include/winuser.h +++ b/include/winuser.h @@ -3576,6 +3576,7 @@ WINUSERAPI INT WINAPI DrawTextExW(HDC,LPWSTR,INT,LPRECT,UINT,LPDRAWTEXTP #define DrawTextEx WINELIB_NAME_AW(DrawTextEx) WINUSERAPI BOOL WINAPI EmptyClipboard(void); WINUSERAPI BOOL WINAPI EnableMenuItem(HMENU,UINT,UINT); +WINUSERAPI BOOL WINAPI EnableMouseInPointer(BOOL); WINUSERAPI BOOL WINAPI EnableScrollBar(HWND,UINT,UINT); WINUSERAPI BOOL WINAPI EnableWindow(HWND,BOOL); WINUSERAPI BOOL WINAPI EndDeferWindowPos(HDWP);

1 0

Józef Kucia : wined3d: Fix linestrips output for geometry shaders.
by Alexandre Julliard Jan. 10, 2018

Jan. 10, 2018

Module: wine Branch: master Commit: b0415bbc22e9f682ca6496f09af9a0131b9a13eb URL: https://source.winehq.org/git/wine.git/?a=commit;h=b0415bbc22e9f682ca6496f0… Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Wed Jan 10 17:30:56 2018 +0100 wined3d: Fix linestrips output for geometry shaders. Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wined3d/shader_sm4.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/wined3d/shader_sm4.c b/dlls/wined3d/shader_sm4.c index 7c3e8b8..3963cbc 100644 --- a/dlls/wined3d/shader_sm4.c +++ b/dlls/wined3d/shader_sm4.c @@ -341,7 +341,7 @@ enum wined3d_sm4_register_type enum wined3d_sm4_output_primitive_type { WINED3D_SM4_OUTPUT_PT_POINTLIST = 0x1, - WINED3D_SM4_OUTPUT_PT_LINELIST = 0x3, + WINED3D_SM4_OUTPUT_PT_LINESTRIP = 0x3, WINED3D_SM4_OUTPUT_PT_TRIANGLESTRIP = 0x5, }; @@ -470,7 +470,7 @@ static const enum wined3d_primitive_type output_primitive_type_table[] = /* UNKNOWN */ WINED3D_PT_UNDEFINED, /* WINED3D_SM4_OUTPUT_PT_POINTLIST */ WINED3D_PT_POINTLIST, /* UNKNOWN */ WINED3D_PT_UNDEFINED, - /* WINED3D_SM4_OUTPUT_PT_LINELIST */ WINED3D_PT_LINELIST, + /* WINED3D_SM4_OUTPUT_PT_LINESTRIP */ WINED3D_PT_LINESTRIP, /* UNKNOWN */ WINED3D_PT_UNDEFINED, /* WINED3D_SM4_OUTPUT_PT_TRIANGLESTRIP */ WINED3D_PT_TRIANGLESTRIP, };

1 0

Alex Henrie : msvcrt: Don' t include MSVC 11.0+ function _wcreate_locale in SOs for older DLLs.
by Alexandre Julliard Jan. 10, 2018

Jan. 10, 2018

Module: wine Branch: master Commit: 6a76d027f2a144ac7321db8fa3fcb6bf95414c90 URL: https://source.winehq.org/git/wine.git/?a=commit;h=6a76d027f2a144ac7321db8f… Author: Alex Henrie <alexhenrie24(a)gmail.com> Date: Tue Jan 9 23:21:44 2018 -0700 msvcrt: Don't include MSVC 11.0+ function _wcreate_locale in SOs for older DLLs. Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/msvcrt/locale.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/dlls/msvcrt/locale.c b/dlls/msvcrt/locale.c index 6d5ceb5..c37989d 100644 --- a/dlls/msvcrt/locale.c +++ b/dlls/msvcrt/locale.c @@ -1641,8 +1641,9 @@ MSVCRT__locale_t CDECL MSVCRT__create_locale(int category, const char *locale) return loc; } +#if _MSVCR_VER >= 110 /********************************************************************* - * _wcreate_locale (MSVCRT.@) + * _wcreate_locale (MSVCR110.@) */ MSVCRT__locale_t CDECL MSVCRT__wcreate_locale(int category, const MSVCRT_wchar_t *locale) { @@ -1665,6 +1666,7 @@ MSVCRT__locale_t CDECL MSVCRT__wcreate_locale(int category, const MSVCRT_wchar_t MSVCRT_free(str); return loc; } +#endif /********************************************************************* * setlocale (MSVCRT.@)

1 0

Alex Henrie : msvcrt: Don' t include MSVC 8.0+ exit functions in SOs for older DLLs.
by Alexandre Julliard Jan. 10, 2018

Jan. 10, 2018

Module: wine Branch: master Commit: b6ec8980c57c8278ceb57f659693246212566ae4 URL: https://source.winehq.org/git/wine.git/?a=commit;h=b6ec8980c57c8278ceb57f65… Author: Alex Henrie <alexhenrie24(a)gmail.com> Date: Tue Jan 9 23:21:43 2018 -0700 msvcrt: Don't include MSVC 8.0+ exit functions in SOs for older DLLs. Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/msvcrt/exit.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/dlls/msvcrt/exit.c b/dlls/msvcrt/exit.c index d0e93d7..7e18055 100644 --- a/dlls/msvcrt/exit.c +++ b/dlls/msvcrt/exit.c @@ -204,6 +204,7 @@ void CDECL MSVCRT_abort(void) MSVCRT__exit(3); } +#if _MSVCR_VER>=80 /********************************************************************* * _set_abort_behavior (MSVCR80.@) */ @@ -218,6 +219,7 @@ unsigned int CDECL MSVCRT__set_abort_behavior(unsigned int flags, unsigned int m MSVCRT_abort_behavior = (MSVCRT_abort_behavior & ~mask) | (flags & mask); return old; } +#endif /********************************************************************* * _wassert (MSVCRT.@) @@ -346,6 +348,8 @@ int CDECL MSVCRT_atexit(void (*func)(void)) return MSVCRT__onexit((MSVCRT__onexit_t)func) == (MSVCRT__onexit_t)func ? 0 : -1; } +#if _MSVCR_VER>=140 + /********************************************************************* * _crt_atexit (UCRTBASE.@) */ @@ -462,6 +466,8 @@ void CDECL _register_thread_local_exe_atexit_callback(_tls_callback_type callbac tls_atexit_callback = callback; } +#endif /* _MSVCR_VER>=140 */ + #if _MSVCR_VER>=71 /********************************************************************* * _set_purecall_handler (MSVCR71.@)

1 0