November 2018 - Wine-Commits

Józef Kucia : wined3d: Propagate HRESULTs in wined3d_swapchain_resize_target().
by Alexandre Julliard Nov. 23, 2018

Nov. 23, 2018

Module: wine Branch: master Commit: 74351205ace530870f39d024b06f287ebcbf0a6a URL: https://source.winehq.org/git/wine.git/?a=commit;h=74351205ace530870f39d024… Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Fri Nov 23 14:41:16 2018 +0100 wined3d: Propagate HRESULTs in wined3d_swapchain_resize_target(). Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wined3d/swapchain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/wined3d/swapchain.c b/dlls/wined3d/swapchain.c index b95623b..43582ce 100644 --- a/dlls/wined3d/swapchain.c +++ b/dlls/wined3d/swapchain.c @@ -1358,7 +1358,7 @@ HRESULT CDECL wined3d_swapchain_resize_target(struct wined3d_swapchain *swapchai &actual_mode, NULL))) { ERR("Failed to get display mode, hr %#x.\n", hr); - return WINED3DERR_INVALIDCALL; + return hr; } SetRect(&window_rect, 0, 0, actual_mode.width, actual_mode.height);

1 0

Hans Leidekker : winhttp: Propagate errors from refill_buffer.
by Alexandre Julliard Nov. 23, 2018

Nov. 23, 2018

Module: wine Branch: master Commit: c6251cbb12431a9788be0e56699d1363386ae602 URL: https://source.winehq.org/git/wine.git/?a=commit;h=c6251cbb12431a9788be0e56… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Fri Nov 23 11:35:27 2018 +0100 winhttp: Propagate errors from refill_buffer. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=38228 Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/winhttp/request.c | 49 +++++++++++++++++++++++++++++++++++-------------- 1 file changed, 35 insertions(+), 14 deletions(-) diff --git a/dlls/winhttp/request.c b/dlls/winhttp/request.c index 9817287..61af6ea 100644 --- a/dlls/winhttp/request.c +++ b/dlls/winhttp/request.c @@ -1949,6 +1949,7 @@ static BOOL end_of_read_data( struct request *request ) static BOOL read_data( struct request *request, void *buffer, DWORD size, DWORD *read, BOOL async ) { int count, bytes_read = 0; + BOOL ret = TRUE; if (end_of_read_data( request )) goto done; @@ -1956,7 +1957,7 @@ static BOOL read_data( struct request *request, void *buffer, DWORD size, DWORD { if (!(count = get_available_data( request ))) { - if (!refill_buffer( request, async )) goto done; + if (!(ret = refill_buffer( request, async ))) goto done; if (!(count = get_available_data( request ))) goto done; } count = min( count, size ); @@ -1968,15 +1969,25 @@ static BOOL read_data( struct request *request, void *buffer, DWORD size, DWORD request->content_read += count; if (end_of_read_data( request )) goto done; } - if (request->read_chunked && !request->read_chunked_size) refill_buffer( request, async ); + if (request->read_chunked && !request->read_chunked_size) ret = refill_buffer( request, async ); done: TRACE( "retrieved %u bytes (%u/%u)\n", bytes_read, request->content_read, request->content_length ); + if (async) + { + if (ret) send_callback( &request->hdr, WINHTTP_CALLBACK_STATUS_READ_COMPLETE, buffer, bytes_read ); + else + { + WINHTTP_ASYNC_RESULT result; + result.dwResult = API_READ_DATA; + result.dwError = GetLastError(); + send_callback( &request->hdr, WINHTTP_CALLBACK_STATUS_REQUEST_ERROR, &result, sizeof(result) ); + } + } - if (async) send_callback( &request->hdr, WINHTTP_CALLBACK_STATUS_READ_COMPLETE, buffer, bytes_read ); - if (read) *read = bytes_read; + if (ret && read) *read = bytes_read; if (end_of_read_data( request )) finished_reading( request ); - return TRUE; + return ret; } /* read any content returned by the server so that the connection can be reused */ @@ -2781,7 +2792,7 @@ static BOOL receive_response( struct request *request, BOOL async ) } netconn_set_timeout( request->netconn, FALSE, request->receive_timeout ); - if (request->content_length) refill_buffer( request, FALSE ); + if (request->content_length) ret = refill_buffer( request, FALSE ); if (async) { @@ -2847,25 +2858,35 @@ BOOL WINAPI WinHttpReceiveResponse( HINTERNET hrequest, LPVOID reserved ) static BOOL query_data_available( struct request *request, DWORD *available, BOOL async ) { DWORD count = 0; + BOOL ret = TRUE; if (end_of_read_data( request )) goto done; count = get_available_data( request ); - if (!request->read_chunked && request->netconn) - count += netconn_query_data_available( request->netconn ); + if (!request->read_chunked && request->netconn) count += netconn_query_data_available( request->netconn ); if (!count) { - refill_buffer( request, async ); + if (!(ret = refill_buffer( request, async ))) goto done; count = get_available_data( request ); - if (!request->read_chunked && request->netconn) - count += netconn_query_data_available( request->netconn ); + if (!request->read_chunked && request->netconn) count += netconn_query_data_available( request->netconn ); } done: - if (async) send_callback( &request->hdr, WINHTTP_CALLBACK_STATUS_DATA_AVAILABLE, &count, sizeof(count) ); TRACE("%u bytes available\n", count); - if (available) *available = count; - return TRUE; + if (async) + { + if (ret) send_callback( &request->hdr, WINHTTP_CALLBACK_STATUS_DATA_AVAILABLE, &count, sizeof(count) ); + else + { + WINHTTP_ASYNC_RESULT result; + result.dwResult = API_QUERY_DATA_AVAILABLE; + result.dwError = GetLastError(); + send_callback( &request->hdr, WINHTTP_CALLBACK_STATUS_REQUEST_ERROR, &result, sizeof(result) ); + } + } + + if (ret && available) *available = count; + return ret; } static void task_query_data_available( struct task_header *task )

1 0

Piotr Caban : msvcp90: Add '_char' suffix to time_get<char> helper functions.
by Alexandre Julliard Nov. 23, 2018

Nov. 23, 2018

Module: wine Branch: master Commit: 9eff1e0682c24131cb9a9326cc13c880a241a7b5 URL: https://source.winehq.org/git/wine.git/?a=commit;h=9eff1e0682c24131cb9a9326… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Fri Nov 23 15:10:02 2018 +0100 msvcp90: Add '_char' suffix to time_get<char> helper functions. Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/msvcp90/locale.c | 40 ++++++++++++++++++++-------------------- 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/dlls/msvcp90/locale.c b/dlls/msvcp90/locale.c index 7755ddf..e2e081a 100644 --- a/dlls/msvcp90/locale.c +++ b/dlls/msvcp90/locale.c @@ -10019,7 +10019,7 @@ dateorder __thiscall time_get_char_date_order(const time_get_char *this) return call_time_get_char_do_date_order(this); } -static int find_longest_match(istreambuf_iterator_char *iter, const char *str) +static int find_longest_match_char(istreambuf_iterator_char *iter, const char *str) { int i, len = 0, last_match = -1, match = -1; const char *p, *end; @@ -10085,7 +10085,7 @@ istreambuf_iterator_char* __thiscall time_get_char_do_get_monthname(const time_g TRACE("(%p %p %p %p %p)\n", this, ret, base, err, t); - if ((match = find_longest_match(&s, this->months)) != -1) + if ((match = find_longest_match_char(&s, this->months)) != -1) t->tm_mon = match / 2; else *err |= IOSTATE_failbit; @@ -10174,7 +10174,7 @@ istreambuf_iterator_char* __thiscall time_get_char_do_get_weekday(const time_get TRACE("(%p %p %p %p %p)\n", this, ret, base, err, t); - if ((match = find_longest_match(&s, this->days)) != -1) + if ((match = find_longest_match_char(&s, this->days)) != -1) t->tm_wday = match / 2; else *err |= IOSTATE_failbit; @@ -10239,19 +10239,19 @@ istreambuf_iterator_char* __thiscall time_get_char_get_year(const time_get_char return call_time_get_char_do_get_year(this, ret, s, e, base, err, t); } -static void skip_ws(ctype_char *ctype, istreambuf_iterator_char *iter) +static void skip_ws_char(ctype_char *ctype, istreambuf_iterator_char *iter) { istreambuf_iterator_char_val(iter); while(iter->strbuf && ctype_char_is_ch(ctype, _SPACE, iter->val)) istreambuf_iterator_char_inc(iter); } -static void skip_date_delim(ctype_char *ctype, istreambuf_iterator_char *iter) +static void skip_date_delim_char(ctype_char *ctype, istreambuf_iterator_char *iter) { - skip_ws(ctype, iter); + skip_ws_char(ctype, iter); if(iter->strbuf && (iter->val == '/' || iter->val == ':')) istreambuf_iterator_char_inc(iter); - skip_ws(ctype, iter); + skip_ws_char(ctype, iter); } /* ?do_get_date@?$time_get(a)DV?$istreambuf_iterator(a)DU?$char_traits(a)D@std@@@std@@@std@@MBE?AV?$istreambuf_iterator(a)DU?$char_traits(a)D@std@@@2(a)V32@0AAVios_base(a)2@AAHPAUtm@@@Z */ @@ -10284,7 +10284,7 @@ istreambuf_iterator_char* __thiscall time_get_char_do_get_date(const time_get_ch switch(order) { case DATEORDER_dmy: *err |= time_get_char__Getint(this, &s, &e, 1, 31, &t->tm_mday); - skip_date_delim(ctype, &s); + skip_date_delim_char(ctype, &s); if(!s.strbuf) { *err |= IOSTATE_failbit; break; @@ -10295,7 +10295,7 @@ istreambuf_iterator_char* __thiscall time_get_char_do_get_date(const time_get_ch } else { time_get_char_get_monthname(this, &s, s, e, base, err, t); } - skip_date_delim(ctype, &s); + skip_date_delim_char(ctype, &s); if(!s.strbuf) { *err |= IOSTATE_failbit; break; @@ -10310,13 +10310,13 @@ istreambuf_iterator_char* __thiscall time_get_char_do_get_date(const time_get_ch } else { time_get_char_get_monthname(this, &s, s, e, base, err, t); } - skip_date_delim(ctype, &s); + skip_date_delim_char(ctype, &s); if(!s.strbuf) { *err |= IOSTATE_failbit; break; } *err |= time_get_char__Getint(this, &s, &e, 1, 31, &t->tm_mday); - skip_date_delim(ctype, &s); + skip_date_delim_char(ctype, &s); if(!s.strbuf) { *err |= IOSTATE_failbit; break; @@ -10325,7 +10325,7 @@ istreambuf_iterator_char* __thiscall time_get_char_do_get_date(const time_get_ch break; case DATEORDER_ymd: time_get_char_get_year(this, &s, s, e, base, err, t); - skip_date_delim(ctype, &s); + skip_date_delim_char(ctype, &s); if(!s.strbuf) { *err |= IOSTATE_failbit; break; @@ -10336,7 +10336,7 @@ istreambuf_iterator_char* __thiscall time_get_char_do_get_date(const time_get_ch } else { time_get_char_get_monthname(this, &s, s, e, base, err, t); } - skip_date_delim(ctype, &s); + skip_date_delim_char(ctype, &s); if(!s.strbuf) { *err |= IOSTATE_failbit; break; @@ -10345,13 +10345,13 @@ istreambuf_iterator_char* __thiscall time_get_char_do_get_date(const time_get_ch break; case DATEORDER_ydm: time_get_char_get_year(this, &s, s, e, base, err, t); - skip_date_delim(ctype, &s); + skip_date_delim_char(ctype, &s); if(!s.strbuf) { *err |= IOSTATE_failbit; break; } *err |= time_get_char__Getint(this, &s, &e, 1, 31, &t->tm_mday); - skip_date_delim(ctype, &s); + skip_date_delim_char(ctype, &s); if(!s.strbuf) { *err |= IOSTATE_failbit; break; @@ -10404,7 +10404,7 @@ istreambuf_iterator_char* __thiscall time_get_char__Getfmt(const time_get_char * while(*fmt) { if(ctype_char_is_ch(ctype, _SPACE, *fmt)) { - skip_ws(ctype, &s); + skip_ws_char(ctype, &s); fmt++; continue; } @@ -10477,7 +10477,7 @@ istreambuf_iterator_char* __thiscall time_get_char_do_get(const time_get_char *t break; case 'd': case 'e': - if(fmt == 'e') skip_ws(ctype, &s); + if(fmt == 'e') skip_ws_char(ctype, &s); *err |= time_get_char__Getint(this, &s, &e, 1, 31, &t->tm_mday); break; case 'D': @@ -10505,7 +10505,7 @@ istreambuf_iterator_char* __thiscall time_get_char_do_get(const time_get_char *t break; case 'n': case 't': - skip_ws(ctype, &s); + skip_ws_char(ctype, &s); case 'p': { BOOL pm = FALSE; @@ -10580,6 +10580,7 @@ istreambuf_iterator_char* __thiscall time_get_char_get(const time_get_char *this return call_time_get_char_do_get(this, ret, s, e, base, err, t, fmt, mod); } +/* ?get@?$time_get(a)DV?$istreambuf_iterator(a)DU?$char_traits(a)D@std@@@std@@@std@@QBE?AV?$istreambuf_iterator(a)DU?$char_traits(a)D@std@@@2(a)V32@0AAVios_base(a)2@AAHPAUtm@@PBD4(a)Z */ /* ?get@?$time_get(a)DV?$istreambuf_iterator(a)DU?$char_traits(a)D@std@@@std@@@std@@QEBA?AV?$istreambuf_iterator(a)DU?$char_traits(a)D@std@@@2(a)V32@0AEAVios_base(a)2@AEAHPEAUtm@@PEBD4(a)Z */ DEFINE_THISCALL_WRAPPER(time_get_char_get_fmt, 44) istreambuf_iterator_char* __thiscall time_get_char_get_fmt(const time_get_char *this, @@ -10595,7 +10596,7 @@ istreambuf_iterator_char* __thiscall time_get_char_get_fmt(const time_get_char * while(fmtstart < fmtend) { if(ctype_char_is_ch(ctype, _SPACE, *fmtstart)) { - skip_ws(ctype, &s); + skip_ws_char(ctype, &s); fmtstart++; continue; } @@ -10628,7 +10629,6 @@ istreambuf_iterator_char* __thiscall time_get_char_get_fmt(const time_get_char * return ret; } -/* ?get@?$time_get(a)DV?$istreambuf_iterator(a)DU?$char_traits(a)D@std@@@std@@@std@@QBE?AV?$istreambuf_iterator(a)DU?$char_traits(a)D@std@@@2(a)V32@0AAVios_base(a)2@AAHPAUtm@@PBD4(a)Z */ /* ??_7_Locimp(a)locale@std@@6B@ */ extern const vtable_ptr MSVCP_locale__Locimp_vtable;

1 0

Andrew Eikum : winebus: Don't override real VID/PID for controllers.
by Alexandre Julliard Nov. 23, 2018

Nov. 23, 2018

Module: wine Branch: master Commit: ccb06c6b6f74d61b2d89b6d02afee4f589e3f4a5 URL: https://source.winehq.org/git/wine.git/?a=commit;h=ccb06c6b6f74d61b2d89b6d0… Author: Andrew Eikum <aeikum(a)codeweavers.com> Date: Thu Nov 22 10:56:01 2018 +1100 winebus: Don't override real VID/PID for controllers. It's unclear what this was useful for, possibly native xinput requires it. Our built-in xinput is good enough now, though, so let's keep the real VID/PID. Signed-off-by: Brendan McGrath <brendan(a)redmandi.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/winebus.sys/bus_sdl.c | 42 ++++++++---------------------------------- 1 file changed, 8 insertions(+), 34 deletions(-) diff --git a/dlls/winebus.sys/bus_sdl.c b/dlls/winebus.sys/bus_sdl.c index 4f0f685..5cf5ddd 100644 --- a/dlls/winebus.sys/bus_sdl.c +++ b/dlls/winebus.sys/bus_sdl.c @@ -59,24 +59,6 @@ WINE_DEFAULT_DEBUG_CHANNEL(plugplay); #ifdef SONAME_LIBSDL2 -#define VID_MICROSOFT 0x045e - -static const WORD PID_XBOX_CONTROLLERS[] = { - 0x0202, /* Xbox Controller */ - 0x0285, /* Xbox Controller S */ - 0x0289, /* Xbox Controller S */ - 0x028e, /* Xbox360 Controller */ - 0x028f, /* Xbox360 Wireless Controller */ - 0x02d1, /* Xbox One Controller */ - 0x02dd, /* Xbox One Controller (Covert Forces/Firmware 2015) */ - 0x02e0, /* Xbox One X Controller */ - 0x02e3, /* Xbox One Elite Controller */ - 0x02e6, /* Wireless XBox Controller Dongle */ - 0x02ea, /* Xbox One S Controller */ - 0x02fd, /* Xbox One S Controller (Firmware 2017) */ - 0x0719, /* Xbox 360 Wireless Adapter */ -}; - WINE_DECLARE_DEBUG_CHANNEL(hid_report); static DRIVER_OBJECT *sdl_driver_obj = NULL; @@ -818,25 +800,17 @@ static void try_add_device(SDL_JoystickID index) controller = pSDL_GameControllerOpen(index); id = pSDL_JoystickInstanceID(joystick); - if (controller) - { - vid = VID_MICROSOFT; - pid = PID_XBOX_CONTROLLERS[3]; - version = 0x01; + + if (pSDL_JoystickGetProductVersion != NULL) { + vid = pSDL_JoystickGetVendor(joystick); + pid = pSDL_JoystickGetProduct(joystick); + version = pSDL_JoystickGetProductVersion(joystick); } else { - if (pSDL_JoystickGetProductVersion != NULL) { - vid = pSDL_JoystickGetVendor(joystick); - pid = pSDL_JoystickGetProduct(joystick); - version = pSDL_JoystickGetProductVersion(joystick); - } - else - { - vid = 0x01; - pid = pSDL_JoystickInstanceID(joystick) + 1; - version = 0; - } + vid = 0x01; + pid = pSDL_JoystickInstanceID(joystick) + 1; + version = 0; } guid = pSDL_JoystickGetGUID(joystick);

1 0

Hans Leidekker : winhttp: Use the thread pool for asynchronous hostname resolution.
by Alexandre Julliard Nov. 23, 2018

Nov. 23, 2018

Module: wine Branch: master Commit: 539f2f15308cfef5edb936948aa1988cb1d3519d URL: https://source.winehq.org/git/wine.git/?a=commit;h=539f2f15308cfef5edb93694… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Fri Nov 23 11:35:28 2018 +0100 winhttp: Use the thread pool for asynchronous hostname resolution. Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/winhttp/net.c | 46 ++++++++++++++++++++++++---------------------- 1 file changed, 24 insertions(+), 22 deletions(-) diff --git a/dlls/winhttp/net.c b/dlls/winhttp/net.c index af1d19d..a1ad046 100644 --- a/dlls/winhttp/net.c +++ b/dlls/winhttp/net.c @@ -651,42 +651,44 @@ static DWORD resolve_hostname( const WCHAR *name, INTERNET_PORT port, struct soc return ERROR_SUCCESS; } -struct resolve_args +struct async_resolve { const WCHAR *hostname; INTERNET_PORT port; - struct sockaddr_storage *sa; + struct sockaddr_storage *addr; + DWORD result; + HANDLE done; }; -static DWORD CALLBACK resolve_proc( LPVOID arg ) +static void CALLBACK resolve_proc( TP_CALLBACK_INSTANCE *instance, void *ctx ) { - struct resolve_args *ra = arg; - return resolve_hostname( ra->hostname, ra->port, ra->sa ); + struct async_resolve *async = ctx; + async->result = resolve_hostname( async->hostname, async->port, async->addr ); + SetEvent( async->done ); } -BOOL netconn_resolve( WCHAR *hostname, INTERNET_PORT port, struct sockaddr_storage *sa, int timeout ) +BOOL netconn_resolve( WCHAR *hostname, INTERNET_PORT port, struct sockaddr_storage *addr, int timeout ) { DWORD ret; - if (timeout) + if (!timeout) ret = resolve_hostname( hostname, port, addr ); + else { - DWORD status; - HANDLE thread; - struct resolve_args ra; - - ra.hostname = hostname; - ra.port = port; - ra.sa = sa; - - thread = CreateThread( NULL, 0, resolve_proc, &ra, 0, NULL ); - if (!thread) return FALSE; + struct async_resolve async; - status = WaitForSingleObject( thread, timeout ); - if (status == WAIT_OBJECT_0) GetExitCodeThread( thread, &ret ); - else ret = ERROR_WINHTTP_TIMEOUT; - CloseHandle( thread ); + async.hostname = hostname; + async.port = port; + async.addr = addr; + if (!(async.done = CreateEventW( NULL, FALSE, FALSE, NULL ))) return FALSE; + if (!TrySubmitThreadpoolCallback( resolve_proc, &async, NULL )) + { + CloseHandle( async.done ); + return FALSE; + } + if (WaitForSingleObject( async.done, timeout ) != WAIT_OBJECT_0) ret = ERROR_WINHTTP_TIMEOUT; + else ret = async.result; + CloseHandle( async.done ); } - else ret = resolve_hostname( hostname, port, sa ); if (ret) {

1 0

Zebediah Figura : setupapi/tests: Remove workarounds in testRegisterAndGetDetail().
by Alexandre Julliard Nov. 23, 2018

Nov. 23, 2018

Module: wine Branch: master Commit: af1362c8c8c3860145a291768b3cc800dedabeb3 URL: https://source.winehq.org/git/wine.git/?a=commit;h=af1362c8c8c3860145a29176… Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Thu Nov 22 23:39:27 2018 -0600 setupapi/tests: Remove workarounds in testRegisterAndGetDetail(). Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/setupapi/tests/devinst.c | 113 ++++++++---------------------------------- 1 file changed, 22 insertions(+), 91 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=af1362c8c8c3860145a2…

1 0

Gabriel Ivăncescu : comctl32/listbox: Use a helper function to check the selection state of an item.
by Alexandre Julliard Nov. 23, 2018

Nov. 23, 2018

Module: wine Branch: master Commit: 54ee4db69a48a7d8b9ff327d3d1b8694b7966034 URL: https://source.winehq.org/git/wine.git/?a=commit;h=54ee4db69a48a7d8b9ff327d… Author: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> Date: Fri Nov 23 10:16:12 2018 +0300 comctl32/listbox: Use a helper function to check the selection state of an item. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/comctl32/listbox.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/dlls/comctl32/listbox.c b/dlls/comctl32/listbox.c index dbc7b4a..a2085ed 100644 --- a/dlls/comctl32/listbox.c +++ b/dlls/comctl32/listbox.c @@ -125,6 +125,11 @@ static TIMER_DIRECTION LISTBOX_Timer = LB_TIMER_NONE; static LRESULT LISTBOX_GetItemRect( const LB_DESCR *descr, INT index, RECT *rect ); +static BOOL is_item_selected( const LB_DESCR *descr, UINT index ) +{ + return descr->items[index].selected; +} + /*********************************************************************** * LISTBOX_GetCurrentPageSize * @@ -2763,7 +2768,7 @@ static LRESULT CALLBACK LISTBOX_WindowProc( HWND hwnd, UINT msg, WPARAM wParam, case LB_GETSEL: if (((INT)wParam < 0) || ((INT)wParam >= descr->nb_items)) return LB_ERR; - return descr->items[wParam].selected; + return is_item_selected(descr, wParam); case LB_SETSEL: ret = LISTBOX_SetSelection( descr, lParam, wParam, FALSE );

1 0

Zebediah Figura : setupapi/tests: Remove workarounds in testDeviceRegistryPropertyA().
by Alexandre Julliard Nov. 23, 2018

Nov. 23, 2018

Module: wine Branch: master Commit: 1b032c2b127a048d61477a4b34af991336ff9d06 URL: https://source.winehq.org/git/wine.git/?a=commit;h=1b032c2b127a048d61477a4b… Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Thu Nov 22 23:39:28 2018 -0600 setupapi/tests: Remove workarounds in testDeviceRegistryPropertyA(). Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/setupapi/tests/devinst.c | 160 ++++++++++++++++++++---------------------- 1 file changed, 77 insertions(+), 83 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=1b032c2b127a048d6147…

1 0

Zebediah Figura : setupapi/tests: Remove workarounds in testDeviceRegistryPropertyW().
by Alexandre Julliard Nov. 23, 2018

Nov. 23, 2018

Module: wine Branch: master Commit: ca2cd9833435bf67b7f3613760bc937cd0400845 URL: https://source.winehq.org/git/wine.git/?a=commit;h=ca2cd9833435bf67b7f36137… Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Thu Nov 22 23:39:29 2018 -0600 setupapi/tests: Remove workarounds in testDeviceRegistryPropertyW(). Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/setupapi/tests/devinst.c | 178 +++++++++++++++++++----------------------- 1 file changed, 81 insertions(+), 97 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=ca2cd9833435bf67b7f3…

1 0

Zebediah Figura : setupapi/tests: Remove workarounds in testDevRegKey().
by Alexandre Julliard Nov. 23, 2018

Nov. 23, 2018

Module: wine Branch: master Commit: c471e4cff491f98f9914ab64e1abed5ea339cc35 URL: https://source.winehq.org/git/wine.git/?a=commit;h=c471e4cff491f98f9914ab64… Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Thu Nov 22 23:39:26 2018 -0600 setupapi/tests: Remove workarounds in testDevRegKey(). Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/setupapi/tests/devinst.c | 204 ++++++++++++++++++------------------------ 1 file changed, 87 insertions(+), 117 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=c471e4cff491f98f9914…

1 0