July 2018 - Wine-Commits - list.winehq.org

Daniel Lehman : msvcr110/tests: Add GetNumberOfVirtualProcessors tests.
by Alexandre Julliard July 18, 2018

July 18, 2018

Module: wine Branch: master Commit: 8ae5352a72508eddb01a7f0b62503981942a6e01 URL: https://source.winehq.org/git/wine.git/?a=commit;h=8ae5352a72508eddb01a7f0b… Author: Daniel Lehman <dlehman(a)esri.com> Date: Tue Jul 17 16:23:37 2018 -0700 msvcr110/tests: Add GetNumberOfVirtualProcessors tests. Signed-off-by: Daniel Lehman <dlehman(a)esri.com> Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/msvcr110/tests/msvcr110.c | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/dlls/msvcr110/tests/msvcr110.c b/dlls/msvcr110/tests/msvcr110.c index c0a182f..423b5d2 100644 --- a/dlls/msvcr110/tests/msvcr110.c +++ b/dlls/msvcr110/tests/msvcr110.c @@ -33,6 +33,9 @@ static char* (CDECL *p_setlocale)(int category, const char* locale); +static unsigned int (CDECL *p_CurrentScheduler_GetNumberOfVirtualProcessors)(void); +static unsigned int (CDECL *p__CurrentScheduler__GetNumberOfVirtualProcessors)(void); + static BOOL init(void) { HMODULE module; @@ -45,9 +48,30 @@ static BOOL init(void) } p_setlocale = (void*)GetProcAddress(module, "setlocale"); + p_CurrentScheduler_GetNumberOfVirtualProcessors = (void*)GetProcAddress(module, "?GetNumberOfVirtualProcessors(a)CurrentScheduler@Concurrency@@SAIXZ"); + p__CurrentScheduler__GetNumberOfVirtualProcessors = (void*)GetProcAddress(module, "?_GetNumberOfVirtualProcessors(a)_CurrentScheduler@details(a)Concurrency@@SAIXZ"); + return TRUE; } +static void test_CurrentScheduler(void) +{ + unsigned int ncpus; + unsigned int expect; + SYSTEM_INFO si; + + expect = ~0; + ncpus = p_CurrentScheduler_GetNumberOfVirtualProcessors(); + ok(ncpus == expect, "expected %x, got %x\n", expect, ncpus); + + GetSystemInfo(&si); + expect = si.dwNumberOfProcessors; + ncpus = p__CurrentScheduler__GetNumberOfVirtualProcessors(); + todo_wine ok(ncpus == expect, "expected %u, got %u\n", expect, ncpus); + ncpus = p_CurrentScheduler_GetNumberOfVirtualProcessors(); + todo_wine ok(ncpus == expect, "expected %u, got %u\n", expect, ncpus); +} + static void test_setlocale(void) { int i; @@ -76,5 +100,6 @@ static void test_setlocale(void) START_TEST(msvcr110) { if (!init()) return; + test_CurrentScheduler(); /* MUST be first (at least among Concurrency tests) */ test_setlocale(); }

1 0

Alexandre Julliard : user32: Fetch client and window rectangles in a single call.
by Alexandre Julliard July 18, 2018

July 18, 2018

Module: wine Branch: master Commit: 3735f36dc94ca68a9344520ac28b2f7d548b0b82 URL: https://source.winehq.org/git/wine.git/?a=commit;h=3735f36dc94ca68a9344520a… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Wed Jul 18 10:09:55 2018 +0200 user32: Fetch client and window rectangles in a single call. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/user32/painting.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/dlls/user32/painting.c b/dlls/user32/painting.c index 665e1c0..66e69f4 100644 --- a/dlls/user32/painting.c +++ b/dlls/user32/painting.c @@ -652,12 +652,12 @@ static HRGN send_ncpaint( HWND hwnd, HWND *child, UINT *flags ) if (whole_rgn) { - RECT client, update; + RECT client, window, update; INT type; /* check if update rgn overlaps with nonclient area */ type = GetRgnBox( whole_rgn, &update ); - WIN_GetRectangles( hwnd, COORDS_SCREEN, 0, &client ); + WIN_GetRectangles( hwnd, COORDS_SCREEN, &window, &client ); if ((*flags & UPDATE_NONCLIENT) || update.left < client.left || update.top < client.top || @@ -667,15 +667,10 @@ static HRGN send_ncpaint( HWND hwnd, HWND *child, UINT *flags ) CombineRgn( client_rgn, client_rgn, whole_rgn, RGN_AND ); /* check if update rgn contains complete nonclient area */ - if (type == SIMPLEREGION) + if (type == SIMPLEREGION && EqualRect( &window, &update )) { - RECT window; - GetWindowRect( hwnd, &window ); - if (EqualRect( &window, &update )) - { - DeleteObject( whole_rgn ); - whole_rgn = (HRGN)1; - } + DeleteObject( whole_rgn ); + whole_rgn = (HRGN)1; } } else

1 0

Józef Kucia : d3d10core/tests: Add more tests for multisample resolve.
by Alexandre Julliard July 18, 2018

July 18, 2018

Module: wine Branch: master Commit: 158fa85b8f13d90ac05e675643eb79119671a2e5 URL: https://source.winehq.org/git/wine.git/?a=commit;h=158fa85b8f13d90ac05e6756… Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Tue Jul 17 11:02:38 2018 +0200 d3d10core/tests: Add more tests for multisample resolve. Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/d3d10core/tests/device.c | 41 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 41 insertions(+) diff --git a/dlls/d3d10core/tests/device.c b/dlls/d3d10core/tests/device.c index 8fba7a3..f3c3d86 100644 --- a/dlls/d3d10core/tests/device.c +++ b/dlls/d3d10core/tests/device.c @@ -16899,6 +16899,47 @@ static void test_multisample_resolve(void) DXGI_FORMAT_R8G8B8A8_UNORM, DXGI_FORMAT_R8G8B8A8_UNORM, &color, 0xffbf7f40, TRUE}, + + {DXGI_FORMAT_R8G8B8A8_TYPELESS, + DXGI_FORMAT_R8G8B8A8_TYPELESS, + DXGI_FORMAT_R8G8B8A8_UNORM, + DXGI_FORMAT_R8G8B8A8_UNORM, + &green, 0xff00ff00, TRUE}, + {DXGI_FORMAT_R8G8B8A8_TYPELESS, + DXGI_FORMAT_R8G8B8A8_TYPELESS, + DXGI_FORMAT_R8G8B8A8_UNORM, + DXGI_FORMAT_R8G8B8A8_UNORM, + &color, 0xffbf7f40, TRUE}, + {DXGI_FORMAT_R8G8B8A8_TYPELESS, + DXGI_FORMAT_R8G8B8A8_TYPELESS, + DXGI_FORMAT_R8G8B8A8_UNORM_SRGB, + DXGI_FORMAT_R8G8B8A8_UNORM_SRGB, + &green, 0xff00ff00, TRUE}, + {DXGI_FORMAT_R8G8B8A8_TYPELESS, + DXGI_FORMAT_R8G8B8A8_TYPELESS, + DXGI_FORMAT_R8G8B8A8_UNORM_SRGB, + DXGI_FORMAT_R8G8B8A8_UNORM_SRGB, + &color, 0xffe1bc89, TRUE}, + {DXGI_FORMAT_R8G8B8A8_TYPELESS, + DXGI_FORMAT_R8G8B8A8_TYPELESS, + DXGI_FORMAT_R8G8B8A8_UNORM, + DXGI_FORMAT_R8G8B8A8_UNORM_SRGB, + &green, 0xff00ff00, TRUE}, + {DXGI_FORMAT_R8G8B8A8_TYPELESS, + DXGI_FORMAT_R8G8B8A8_TYPELESS, + DXGI_FORMAT_R8G8B8A8_UNORM, + DXGI_FORMAT_R8G8B8A8_UNORM_SRGB, + &color, 0xffe1bc89, TRUE}, + {DXGI_FORMAT_R8G8B8A8_TYPELESS, + DXGI_FORMAT_R8G8B8A8_TYPELESS, + DXGI_FORMAT_R8G8B8A8_UNORM_SRGB, + DXGI_FORMAT_R8G8B8A8_UNORM, + &green, 0xff00ff00, TRUE}, + {DXGI_FORMAT_R8G8B8A8_TYPELESS, + DXGI_FORMAT_R8G8B8A8_TYPELESS, + DXGI_FORMAT_R8G8B8A8_UNORM_SRGB, + DXGI_FORMAT_R8G8B8A8_UNORM, + &color, 0xffbf7f40, TRUE}, }; if (!init_test_context(&test_context))

1 0

Alexandre Julliard : user32: Make the MonitorFromRect() argument const.
by Alexandre Julliard July 18, 2018

July 18, 2018

Module: wine Branch: master Commit: a36abda77377aba16b0039e1738f4155aa5e9d07 URL: https://source.winehq.org/git/wine.git/?a=commit;h=a36abda77377aba16b0039e1… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Wed Jul 18 14:11:32 2018 +0200 user32: Make the MonitorFromRect() argument const. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/user32/sysparams.c | 2 +- include/winuser.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/user32/sysparams.c b/dlls/user32/sysparams.c index c92d9af..149b483 100644 --- a/dlls/user32/sysparams.c +++ b/dlls/user32/sysparams.c @@ -3481,7 +3481,7 @@ static BOOL CALLBACK monitor_enum( HMONITOR monitor, HDC hdc, LPRECT rect, LPARA /*********************************************************************** * MonitorFromRect (USER32.@) */ -HMONITOR WINAPI MonitorFromRect( LPRECT rect, DWORD flags ) +HMONITOR WINAPI MonitorFromRect( const RECT *rect, DWORD flags ) { struct monitor_enum_info info; diff --git a/include/winuser.h b/include/winuser.h index a653ef4..8489d05 100644 --- a/include/winuser.h +++ b/include/winuser.h @@ -3981,7 +3981,7 @@ WINUSERAPI BOOL WINAPI ModifyMenuA(HMENU,UINT,UINT,UINT_PTR,LPCSTR); WINUSERAPI BOOL WINAPI ModifyMenuW(HMENU,UINT,UINT,UINT_PTR,LPCWSTR); #define ModifyMenu WINELIB_NAME_AW(ModifyMenu) WINUSERAPI HMONITOR WINAPI MonitorFromPoint(POINT,DWORD); -WINUSERAPI HMONITOR WINAPI MonitorFromRect(LPRECT,DWORD); +WINUSERAPI HMONITOR WINAPI MonitorFromRect(const RECT*,DWORD); WINUSERAPI HMONITOR WINAPI MonitorFromWindow(HWND,DWORD); WINUSERAPI BOOL WINAPI MoveWindow(HWND,INT,INT,INT,INT,BOOL); WINUSERAPI DWORD WINAPI MsgWaitForMultipleObjects(DWORD,const HANDLE*,BOOL,DWORD,DWORD);

1 0

Daniel Lehman : gdi32: Update edgetable limits with top and bottom.
by Alexandre Julliard July 18, 2018

July 18, 2018

Module: wine Branch: master Commit: e976e179ae07d5c6c4d6854a939844d32f6255dc URL: https://source.winehq.org/git/wine.git/?a=commit;h=e976e179ae07d5c6c4d6854a… Author: Daniel Lehman <dlehman(a)esri.com> Date: Fri Jul 13 09:45:39 2018 -0700 gdi32: Update edgetable limits with top and bottom. Signed-off-by: Daniel Lehman <dlehman(a)esri.com> Signed-off-by: Huw Davies <huw(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/gdi32/region.c | 4 ++-- dlls/gdi32/tests/path.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/dlls/gdi32/region.c b/dlls/gdi32/region.c index 4899d43..cad6428 100644 --- a/dlls/gdi32/region.c +++ b/dlls/gdi32/region.c @@ -2457,8 +2457,8 @@ static unsigned int REGION_CreateEdgeTable(const INT *Count, INT nbpolygons, REGION_InsertEdgeInET(ET, pETEs, top->y, &pSLLBlock, &iSLLBlock); - if (PrevPt->y > ET->ymax) ET->ymax = PrevPt->y; - if (PrevPt->y < ET->ymin) ET->ymin = PrevPt->y; + if (top->y < ET->ymin) ET->ymin = top->y; + if (bottom->y > ET->ymax) ET->ymax = bottom->y; pETEs++; } } diff --git a/dlls/gdi32/tests/path.c b/dlls/gdi32/tests/path.c index 2356b96..f4a9d18 100644 --- a/dlls/gdi32/tests/path.c +++ b/dlls/gdi32/tests/path.c @@ -1910,7 +1910,7 @@ static void test_clipped_polygon_fill(void) oldbmp = SelectObject( memdc, bmp ); Polygon( memdc, pts, ARRAY_SIZE(pts) ); col = GetPixel( memdc, 1, 1 ); - todo_wine ok( col == RGB( 0x11, 0x22, 0x33 ), "got %06x\n", col ); + ok( col == RGB( 0x11, 0x22, 0x33 ), "got %06x\n", col ); SelectObject( memdc, oldbrush ); SelectObject( memdc, oldbmp ); DeleteObject( brush );

1 0

Jeremy Newman : update generate_passwd to be stronger
by Jeremy Newman July 18, 2018

July 18, 2018

Module: appdb Branch: master Commit: ca2c14ebead2840510103198f53216a5e3616208 URL: https://source.winehq.org/git/appdb.git/?a=commit;h=ca2c14ebead284051010319… Author: Jeremy Newman <jnewman(a)codeweavers.com> Date: Wed Jul 18 13:12:38 2018 -0500 update generate_passwd to be stronger mt_rand in PHP is not considered to be cryptographically stong use openssl_random_pseudo_bytes instead --- include/user.php | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/include/user.php b/include/user.php index 5a4b428..6626b0e 100644 --- a/include/user.php +++ b/include/user.php @@ -417,16 +417,16 @@ class User { /** * Creates a new random password. */ - public static function generate_passwd($pass_len = 10) + public static function generate_passwd($pass_len = 20) { - $nps = ""; - mt_srand ((double) microtime() * 1000000); - while (strlen($nps)<$pass_len) - { - $c = chr(mt_rand (0,255)); - if (preg_match("/[a-zA-Z0-9]/", $c)) $nps = $nps.$c; + $alphanum = 'ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789'; + $alphanum_length = strlen($alphanum); + $random = openssl_random_pseudo_bytes($pass_len); + $passwd = ''; + for ($i = 0; $i < $pass_len; ++$i) { + $passwd .= $alphanum[ord($random[$i]) % $alphanum_length]; } - return ($nps); + return $passwd; } /**

1 0

Francois Gouget : testbot/Janitor: Only compute the latest file ages when needed.
by Alexandre Julliard July 18, 2018

July 18, 2018

Module: tools Branch: master Commit: 381d88c6b01512b40dc04400d9fc475adc955732 URL: https://source.winehq.org/git/tools.git/?a=commit;h=381d88c6b01512b40dc0440… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Wed Jul 18 17:32:25 2018 +0200 testbot/Janitor: Only compute the latest file ages when needed. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- testbot/bin/Janitor.pl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/testbot/bin/Janitor.pl b/testbot/bin/Janitor.pl index a9cdd52..18bbc3d 100755 --- a/testbot/bin/Janitor.pl +++ b/testbot/bin/Janitor.pl @@ -310,9 +310,6 @@ if (opendir(my $dh, "$DataDir/latest")) foreach my $Entry (@Entries) { next if ($Entry eq "." or $Entry eq ".."); - $Entry =~ m%^([^/]+)$%; - my $FileName = "$DataDir/latest/$1"; - my $Age = int((-M $FileName) + 0.5); if ($Entry =~ /^(.*)_[a-z0-9]+\.(?:err|log)$/) { @@ -329,6 +326,9 @@ if (opendir(my $dh, "$DataDir/latest")) Trace "Found a suspicious latest file: $Entry\n"; if ($JobPurgeDays != 0) { + $Entry =~ m%^([^/]+)$%; # untaint + my $FileName = "$DataDir/latest/$1"; + my $Age = int((-M $FileName) + 0.5); if ($Age >= $JobPurgeDays + 7) { DeletePath($FileName);

1 0

Francois Gouget : testbot/WineSendLog: Remove a couple of redundant lines.
by Alexandre Julliard July 18, 2018

July 18, 2018

Module: tools Branch: master Commit: eb2dfc6b26d4895a35315fbc500aea46a9a3479b URL: https://source.winehq.org/git/tools.git/?a=commit;h=eb2dfc6b26d4895a35315fb… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Wed Jul 18 17:32:09 2018 +0200 testbot/WineSendLog: Remove a couple of redundant lines. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- testbot/bin/WineSendLog.pl | 2 -- 1 file changed, 2 deletions(-) diff --git a/testbot/bin/WineSendLog.pl b/testbot/bin/WineSendLog.pl index 51830ad..f1cb74e 100755 --- a/testbot/bin/WineSendLog.pl +++ b/testbot/bin/WineSendLog.pl @@ -475,8 +475,6 @@ EOF # Filter out failures that happened in the full test suite: # the test suite is run against code which is already in Wine # so any failure it reported is not caused by this patch. - my $LogFiles = GetLogFileNames($TaskDir); - my $LogName = $LogFiles->[0] || "log"; $MessagesFromLog = CompareLogs("$LatestName.log", "$TaskDir/$LogName", $BaseName, $StepTask->CmdLineArg); }

1 0

Józef Kucia : libs/vkd3d: Process shader stages according to pipeline order.
by Alexandre Julliard July 18, 2018

July 18, 2018

Module: vkd3d Branch: master Commit: d266a5f7d05c9ddf6983e64d3f4d1a2bffcf19c5 URL: https://source.winehq.org/git/vkd3d.git/?a=commit;h=d266a5f7d05c9ddf6983e64… Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Wed Jul 18 12:05:44 2018 +0200 libs/vkd3d: Process shader stages according to pipeline order. Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- libs/vkd3d/state.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libs/vkd3d/state.c b/libs/vkd3d/state.c index 19e6549..1c550e2 100644 --- a/libs/vkd3d/state.c +++ b/libs/vkd3d/state.c @@ -1829,10 +1829,10 @@ static HRESULT d3d12_pipeline_state_init_graphics(struct d3d12_pipeline_state *s shader_stages[] = { {VK_SHADER_STAGE_VERTEX_BIT, offsetof(D3D12_GRAPHICS_PIPELINE_STATE_DESC, VS)}, - {VK_SHADER_STAGE_FRAGMENT_BIT, offsetof(D3D12_GRAPHICS_PIPELINE_STATE_DESC, PS)}, - {VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT, offsetof(D3D12_GRAPHICS_PIPELINE_STATE_DESC, DS)}, {VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT, offsetof(D3D12_GRAPHICS_PIPELINE_STATE_DESC, HS)}, + {VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT, offsetof(D3D12_GRAPHICS_PIPELINE_STATE_DESC, DS)}, {VK_SHADER_STAGE_GEOMETRY_BIT, offsetof(D3D12_GRAPHICS_PIPELINE_STATE_DESC, GS)}, + {VK_SHADER_STAGE_FRAGMENT_BIT, offsetof(D3D12_GRAPHICS_PIPELINE_STATE_DESC, PS)}, }; state->ID3D12PipelineState_iface.lpVtbl = &d3d12_pipeline_state_vtbl;

1 0

Józef Kucia : libs/vkd3d: Return E_INVALIDARG for invalid pipeline state desc.
by Alexandre Julliard July 18, 2018

July 18, 2018

Module: vkd3d Branch: master Commit: 7892a1e938463cce4a5591c5d79ffe17c540f961 URL: https://source.winehq.org/git/vkd3d.git/?a=commit;h=7892a1e938463cce4a5591c… Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Wed Jul 18 12:05:45 2018 +0200 libs/vkd3d: Return E_INVALIDARG for invalid pipeline state desc. Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- libs/vkd3d/state.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libs/vkd3d/state.c b/libs/vkd3d/state.c index 1c550e2..861f5bb 100644 --- a/libs/vkd3d/state.c +++ b/libs/vkd3d/state.c @@ -1866,7 +1866,7 @@ static HRESULT d3d12_pipeline_state_init_graphics(struct d3d12_pipeline_state *s if (!(format = vkd3d_get_format(desc->DSVFormat, true))) { WARN("Invalid DXGI format %#x.\n", desc->DSVFormat); - hr = E_FAIL; + hr = E_INVALIDARG; goto fail; } @@ -1915,7 +1915,7 @@ static HRESULT d3d12_pipeline_state_init_graphics(struct d3d12_pipeline_state *s if (!(format = vkd3d_get_format(desc->RTVFormats[i], false))) { WARN("Invalid DXGI format %#x.\n", desc->RTVFormats[i]); - hr = E_FAIL; + hr = E_INVALIDARG; goto fail; } @@ -2007,14 +2007,14 @@ static HRESULT d3d12_pipeline_state_init_graphics(struct d3d12_pipeline_state *s if (!(format = vkd3d_get_format(e->Format, false))) { WARN("Invalid DXGI format %#x.\n", e->Format); - hr = E_FAIL; + hr = E_INVALIDARG; goto fail; } if (e->InputSlot >= ARRAY_SIZE(graphics->input_rates)) { WARN("Invalid input slot %#x.\n", e->InputSlot); - hr = E_FAIL; + hr = E_INVALIDARG; goto fail; } @@ -2048,7 +2048,7 @@ static HRESULT d3d12_pipeline_state_init_graphics(struct d3d12_pipeline_state *s default: FIXME("Unhandled input slot class %#x on input element %u.\n", e->InputSlotClass, i); - hr = E_FAIL; + hr = E_INVALIDARG; goto fail; } @@ -2056,7 +2056,7 @@ static HRESULT d3d12_pipeline_state_init_graphics(struct d3d12_pipeline_state *s { FIXME("Input slot class %#x on input element %u conflicts with earlier input slot class %#x.\n", e->InputSlotClass, e->InputSlot, graphics->input_rates[e->InputSlot]); - hr = E_FAIL; + hr = E_INVALIDARG; goto fail; } graphics->input_rates[e->InputSlot] = input_rate;

1 0