November 2019 - Wine-Commits

Alexandre Julliard : ntdll: Remove trailing \n in fatal_perror() calls.
by Alexandre Julliard Nov. 29, 2019

Nov. 29, 2019

Module: wine Branch: master Commit: dd732232890f176a9ae618b63fe63a2b62dbf93e URL: https://source.winehq.org/git/wine.git/?a=commit;h=dd732232890f176a9ae618b6… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Nov 29 17:14:14 2019 +0100 ntdll: Remove trailing \n in fatal_perror() calls. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ntdll/server.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/dlls/ntdll/server.c b/dlls/ntdll/server.c index 204370a1b7..089eb3b89a 100644 --- a/dlls/ntdll/server.c +++ b/dlls/ntdll/server.c @@ -1139,7 +1139,7 @@ static int setup_config_dir(void) if (chdir( config_dir ) == -1) { - if (errno != ENOENT) fatal_perror( "chdir to %s\n", config_dir ); + if (errno != ENOENT) fatal_perror( "chdir to %s", config_dir ); if ((p = strrchr( config_dir, '/' )) && p != config_dir) { @@ -1156,7 +1156,7 @@ static int setup_config_dir(void) } mkdir( config_dir, 0777 ); - if (chdir( config_dir ) == -1) fatal_perror( "chdir to %s\n", config_dir ); + if (chdir( config_dir ) == -1) fatal_perror( "chdir to %s", config_dir ); MESSAGE( "wine: created the configuration directory '%s'\n", config_dir ); } @@ -1164,7 +1164,7 @@ static int setup_config_dir(void) if (mkdir( "dosdevices", 0777 ) == -1) { if (errno == EEXIST) goto done; - fatal_perror( "cannot create %s/dosdevices\n", config_dir ); + fatal_perror( "cannot create %s/dosdevices", config_dir ); } /* create the drive symlinks */

1 0

Alexandre Julliard : msxml3/tests: Avoid winetest_strcmpW.
by Alexandre Julliard Nov. 29, 2019

Nov. 29, 2019

Module: wine Branch: master Commit: f077f8b08dae39046485725682a140f54c3b9327 URL: https://source.winehq.org/git/wine.git/?a=commit;h=f077f8b08dae390464857256… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Nov 29 13:57:51 2019 +0100 msxml3/tests: Avoid winetest_strcmpW. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/msxml3/tests/schema.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/msxml3/tests/schema.c b/dlls/msxml3/tests/schema.c index f1f3e4206b..0fcaf757b2 100644 --- a/dlls/msxml3/tests/schema.c +++ b/dlls/msxml3/tests/schema.c @@ -983,7 +983,7 @@ static void test_collection_content(void) content[i] = bstr; for (j = 0; j < i; ++j) - ok(winetest_strcmpW(content[j], bstr), "got duplicate entry\n"); + ok(wcscmp(content[j], bstr), "got duplicate entry\n"); } for (i = 0; i < 3; ++i) @@ -1001,7 +1001,7 @@ static void test_collection_content(void) ok(bstr != NULL && *bstr, "expected non-empty string\n"); for (j = 0; j < i; ++j) - ok(winetest_strcmpW(content[j], bstr), "got duplicate entry\n"); + ok(wcscmp(content[j], bstr), "got duplicate entry\n"); content[i] = bstr; }

1 0

Akihiro Sagawa : po: Update Japanese translation.
by Alexandre Julliard Nov. 29, 2019

Nov. 29, 2019

Module: wine Branch: master Commit: 14e7064e870c2c3fdcc0f12913af0a47ebacfb45 URL: https://source.winehq.org/git/wine.git/?a=commit;h=14e7064e870c2c3fdcc0f129… Author: Akihiro Sagawa <sagawa.aki(a)gmail.com> Date: Fri Nov 29 22:31:33 2019 +0900 po: Update Japanese translation. Signed-off-by: Akihiro Sagawa <sagawa.aki(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- po/ja.po | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/po/ja.po b/po/ja.po index 05be4a948f..5aa4b0b42d 100644 --- a/po/ja.po +++ b/po/ja.po @@ -5,7 +5,7 @@ msgstr "" "Project-Id-Version: Wine\n" "Report-Msgid-Bugs-To: https://bugs.winehq.org\n" "POT-Creation-Date: N/A\n" -"PO-Revision-Date: 2019-10-27 21:38+0900\n" +"PO-Revision-Date: 2019-11-29 22:03+0900\n" "Last-Translator: Akihiro Sagawa <sagawa.aki(a)gmail.com>\n" "Language-Team: Japanese\n" "Language: ja\n" @@ -615,7 +615,7 @@ msgstr "文字セット(&I):" #: comdlg32.rc:283 comdlg32.rc:288 msgid "Color" -msgstr "色の設定" +msgstr "色" #: comdlg32.rc:286 msgid "&Basic Colors:" @@ -627,7 +627,7 @@ msgstr "作成した色(&C):" #: comdlg32.rc:289 msgid "|S&olid" -msgstr "" +msgstr "|純色(&O)" #: comdlg32.rc:290 msgid "&Red:" @@ -664,11 +664,9 @@ msgid "&Define Custom Colors >>" msgstr "色の作成(&D) >>" #: comdlg32.rc:312 -#, fuzzy -#| msgid "&No" msgctxt "Solid" msgid "&o" -msgstr "いいえ(&N)" +msgstr "&o" #: comdlg32.rc:318 regedit.rc:275 regedit.rc:285 msgid "Find"

1 0

Alexandre Julliard : Release 4.21.
by Alexandre Julliard Nov. 29, 2019

Nov. 29, 2019

Module: wine Branch: master Commit: 2935bab96569dcd734a8e855ec9a20ae27c18973 URL: https://source.winehq.org/git/wine.git/?a=commit;h=2935bab96569dcd734a8e855… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Nov 29 20:15:57 2019 +0100 Release 4.21. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- ANNOUNCE | 908 ++++++++++++++++++++++++++++++++------------------------------ AUTHORS | 3 + VERSION | 2 +- configure | 18 +- 4 files changed, 475 insertions(+), 456 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=2935bab96569dcd734a8…

1 0

Alexandre Julliard : shell32/tests: Avoid winetest_strcmpW.
by Alexandre Julliard Nov. 29, 2019

Nov. 29, 2019

Module: wine Branch: master Commit: 8310d7c4172ccae3233a843f3b8c37255dfef1ff URL: https://source.winehq.org/git/wine.git/?a=commit;h=8310d7c4172ccae3233a843f… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Nov 29 13:57:56 2019 +0100 shell32/tests: Avoid winetest_strcmpW. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/shell32/tests/shelllink.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/dlls/shell32/tests/shelllink.c b/dlls/shell32/tests/shelllink.c index 3bfd9cbe38..db839200d5 100644 --- a/dlls/shell32/tests/shelllink.c +++ b/dlls/shell32/tests/shelllink.c @@ -496,9 +496,7 @@ void create_lnk_(int line, const WCHAR* path, lnk_desc_t* desc, int save_fails) { IMalloc *pmalloc; - lok(!winetest_strcmpW(path, str), "Expected %s, got %s\n", - wine_dbgstr_w(path), wine_dbgstr_w(str)); - + lok(!wcscmp(path, str), "Expected %s, got %s\n", wine_dbgstr_w(path), wine_dbgstr_w(str)); SHGetMalloc(&pmalloc); IMalloc_Free(pmalloc, str); } @@ -554,9 +552,7 @@ static void check_lnk_(int line, const WCHAR* path, lnk_desc_t* desc, int todo) { IMalloc *pmalloc; - lok(!winetest_strcmpW(path, str), "Expected %s, got %s\n", - wine_dbgstr_w(path), wine_dbgstr_w(str)); - + lok(!wcscmp(path, str), "Expected %s, got %s\n", wine_dbgstr_w(path), wine_dbgstr_w(str)); SHGetMalloc(&pmalloc); IMalloc_Free(pmalloc, str); }

1 0

Zebediah Figura : ddraw: Track some more render states in the primary stateblock.
by Alexandre Julliard Nov. 29, 2019

Nov. 29, 2019

Module: wine Branch: master Commit: b29c7da5f06f9650c316106abc71cd59e2b83026 URL: https://source.winehq.org/git/wine.git/?a=commit;h=b29c7da5f06f9650c316106a… Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Wed Nov 27 23:53:37 2019 -0600 ddraw: Track some more render states in the primary stateblock. Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ddraw/device.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/dlls/ddraw/device.c b/dlls/ddraw/device.c index 51576c81e2..def3e7c2a4 100644 --- a/dlls/ddraw/device.c +++ b/dlls/ddraw/device.c @@ -3555,6 +3555,7 @@ static void setup_lighting(const struct d3d_device *device, DWORD fvf, DWORD fla if (!device->material || !(fvf & D3DFVF_NORMAL) || (flags & D3DDP_DONOTLIGHT)) enable = FALSE; + wined3d_stateblock_set_render_state(device->state, WINED3D_RS_LIGHTING, enable); wined3d_device_set_render_state(device->wined3d_device, WINED3D_RS_LIGHTING, enable); } @@ -7033,11 +7034,18 @@ static HRESULT d3d_device_init(struct d3d_device *device, struct ddraw *ddraw, wined3d_device_set_render_state(ddraw->wined3d_device, WINED3D_RS_ZENABLE, d3d_device_update_depth_stencil(device)); if (version == 1) /* Color keying is initially enabled for version 1 devices. */ + { + wined3d_stateblock_set_render_state(ddraw->state, WINED3D_RS_COLORKEYENABLE, TRUE); wined3d_device_set_render_state(ddraw->wined3d_device, WINED3D_RS_COLORKEYENABLE, TRUE); + } else if (version == 2) + { + wined3d_stateblock_set_render_state(ddraw->state, WINED3D_RS_SPECULARENABLE, TRUE); wined3d_device_set_render_state(ddraw->wined3d_device, WINED3D_RS_SPECULARENABLE, TRUE); + } if (version < 7) { + wined3d_stateblock_set_render_state(ddraw->state, WINED3D_RS_NORMALIZENORMALS, TRUE); wined3d_device_set_render_state(ddraw->wined3d_device, WINED3D_RS_NORMALIZENORMALS, TRUE); IDirect3DDevice3_SetRenderState(&device->IDirect3DDevice3_iface, D3DRENDERSTATE_TEXTUREMAPBLEND, D3DTBLEND_MODULATE);

1 0

Zebediah Figura : strmbase: Swap the lock order in IPin::EndFlush().
by Alexandre Julliard Nov. 29, 2019

Nov. 29, 2019

Module: wine Branch: master Commit: a4131ca625cf7b1c76ba8f230dda7c6b9d682bc3 URL: https://source.winehq.org/git/wine.git/?a=commit;h=a4131ca625cf7b1c76ba8f23… Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Thu Nov 28 17:35:41 2019 -0600 strmbase: Swap the lock order in IPin::EndFlush(). This more closely resembles the threading model prescribed by the DirectX SDK documentation. In particular, the page "Flushing Data" recommends that IPin::BeginFlush() do the following steps in order: 1. take the filter lock 2. signal the streaming thread to complete 3. take the streaming lock, if necessary Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/strmbase/renderer.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/strmbase/renderer.c b/dlls/strmbase/renderer.c index 0ef9c5b225..cacbb90e59 100644 --- a/dlls/strmbase/renderer.c +++ b/dlls/strmbase/renderer.c @@ -133,8 +133,8 @@ static HRESULT WINAPI BaseRenderer_InputPin_EndFlush(IPin * iface) TRACE("iface %p.\n", iface); - EnterCriticalSection(&pFilter->csRenderLock); EnterCriticalSection(&pFilter->filter.csFilter); + EnterCriticalSection(&pFilter->csRenderLock); pFilter->eos = FALSE; hr = BaseInputPinImpl_EndFlush(iface); if (SUCCEEDED(hr)) @@ -146,8 +146,8 @@ static HRESULT WINAPI BaseRenderer_InputPin_EndFlush(IPin * iface) if (pFilter->pFuncsTable->pfnEndFlush) hr = pFilter->pFuncsTable->pfnEndFlush(pFilter); } - LeaveCriticalSection(&pFilter->filter.csFilter); LeaveCriticalSection(&pFilter->csRenderLock); + LeaveCriticalSection(&pFilter->filter.csFilter); return hr; }

1 0

Zebediah Figura : quartz/systemclock: Support COM aggregation.
by Alexandre Julliard Nov. 29, 2019

Nov. 29, 2019

Module: wine Branch: master Commit: d21dbf960b840f2af33f7e43df799817ded5097f URL: https://source.winehq.org/git/wine.git/?a=commit;h=d21dbf960b840f2af33f7e43… Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Thu Nov 28 17:35:38 2019 -0600 quartz/systemclock: Support COM aggregation. Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/quartz/systemclock.c | 121 +++++++++++++++++++++++++++------------- dlls/quartz/tests/systemclock.c | 108 ++++++++++++++++++++++++++++++++++- 2 files changed, 186 insertions(+), 43 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=d21dbf960b840f2af33f…

1 0

Zebediah Figura : quartz/dsoundrender: Move DSoundRender_create() to avoid forward declarations.
by Alexandre Julliard Nov. 29, 2019

Nov. 29, 2019

Module: wine Branch: master Commit: 3f2b813da6bc5f810abdc90bee1c6000c03872e6 URL: https://source.winehq.org/git/wine.git/?a=commit;h=3f2b813da6bc5f810abdc90b… Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Thu Nov 28 17:35:39 2019 -0600 quartz/dsoundrender: Move DSoundRender_create() to avoid forward declarations. Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/quartz/dsoundrender.c | 115 +++++++++++++++++++++---------------------- dlls/quartz/main.c | 4 +- dlls/quartz/quartz_private.h | 2 +- 3 files changed, 58 insertions(+), 63 deletions(-) diff --git a/dlls/quartz/dsoundrender.c b/dlls/quartz/dsoundrender.c index b6757fa76a..3171f99f7e 100644 --- a/dlls/quartz/dsoundrender.c +++ b/dlls/quartz/dsoundrender.c @@ -39,10 +39,6 @@ WINE_DEFAULT_DEBUG_CHANNEL(quartz); */ static const REFERENCE_TIME DSoundRenderer_Max_Fill = 150 * 10000; -static const IBasicAudioVtbl IBasicAudio_Vtbl; -static const IReferenceClockVtbl IReferenceClock_Vtbl; -static const IAMDirectSoundVtbl IAMDirectSound_Vtbl; - typedef struct DSoundRenderImpl { struct strmbase_renderer renderer; @@ -577,62 +573,6 @@ static const struct strmbase_renderer_ops renderer_ops = .renderer_query_interface = dsound_render_query_interface, }; -HRESULT DSoundRender_create(IUnknown *outer, void **out) -{ - static const WCHAR sink_name[] = {'A','u','d','i','o',' ','I','n','p','u','t',' ','p','i','n',' ','(','r','e','n','d','e','r','e','d',')',0}; - - HRESULT hr; - DSoundRenderImpl * pDSoundRender; - - *out = NULL; - - pDSoundRender = CoTaskMemAlloc(sizeof(DSoundRenderImpl)); - if (!pDSoundRender) - return E_OUTOFMEMORY; - ZeroMemory(pDSoundRender, sizeof(DSoundRenderImpl)); - - hr = strmbase_renderer_init(&pDSoundRender->renderer, - outer, &CLSID_DSoundRender, sink_name, &renderer_ops); - - pDSoundRender->IBasicAudio_iface.lpVtbl = &IBasicAudio_Vtbl; - pDSoundRender->IReferenceClock_iface.lpVtbl = &IReferenceClock_Vtbl; - pDSoundRender->IAMDirectSound_iface.lpVtbl = &IAMDirectSound_Vtbl; - - if (SUCCEEDED(hr)) - { - hr = DirectSoundCreate8(NULL, &pDSoundRender->dsound, NULL); - if (FAILED(hr)) - ERR("Cannot create Direct Sound object (%x)\n", hr); - else - hr = IDirectSound8_SetCooperativeLevel(pDSoundRender->dsound, GetDesktopWindow(), DSSCL_PRIORITY); - if (SUCCEEDED(hr)) { - IDirectSoundBuffer *buf; - DSBUFFERDESC buf_desc; - memset(&buf_desc,0,sizeof(DSBUFFERDESC)); - buf_desc.dwSize = sizeof(DSBUFFERDESC); - buf_desc.dwFlags = DSBCAPS_PRIMARYBUFFER; - hr = IDirectSound8_CreateSoundBuffer(pDSoundRender->dsound, &buf_desc, &buf, NULL); - if (SUCCEEDED(hr)) { - IDirectSoundBuffer_Play(buf, 0, 0, DSBPLAY_LOOPING); - IDirectSoundBuffer_Release(buf); - } - hr = S_OK; - } - } - - if (SUCCEEDED(hr)) - { - *out = &pDSoundRender->renderer.filter.IUnknown_inner; - } - else - { - strmbase_renderer_cleanup(&pDSoundRender->renderer); - CoTaskMemFree(pDSoundRender); - } - - return hr; -} - /*** IUnknown methods ***/ static HRESULT WINAPI Basicaudio_QueryInterface(IBasicAudio *iface, REFIID riid, @@ -1158,3 +1098,58 @@ static const IAMDirectSoundVtbl IAMDirectSound_Vtbl = AMDirectSound_SetFocusWindow, AMDirectSound_GetFocusWindow }; + +HRESULT dsound_render_create(IUnknown *outer, void **out) +{ + static const DSBUFFERDESC buffer_desc = { + .dwSize = sizeof(DSBUFFERDESC), + .dwFlags = DSBCAPS_PRIMARYBUFFER, + }; + + IDirectSoundBuffer *buffer; + DSoundRenderImpl *object; + HRESULT hr; + + if (!(object = CoTaskMemAlloc(sizeof(*object)))) + return E_OUTOFMEMORY; + memset(object, 0, sizeof(*object)); + + if (FAILED(hr = strmbase_renderer_init(&object->renderer, outer, + &CLSID_DSoundRender, L"Audio Input pin (rendered)", &renderer_ops))) + { + CoTaskMemFree(object); + return hr; + } + + object->IBasicAudio_iface.lpVtbl = &IBasicAudio_Vtbl; + object->IReferenceClock_iface.lpVtbl = &IReferenceClock_Vtbl; + object->IAMDirectSound_iface.lpVtbl = &IAMDirectSound_Vtbl; + + if (FAILED(hr = DirectSoundCreate8(NULL, &object->dsound, NULL))) + { + strmbase_renderer_cleanup(&object->renderer); + CoTaskMemFree(object); + return hr; + } + + if (FAILED(hr = IDirectSound8_SetCooperativeLevel(object->dsound, + GetDesktopWindow(), DSSCL_PRIORITY))) + { + IDirectSound8_Release(object->dsound); + strmbase_renderer_cleanup(&object->renderer); + CoTaskMemFree(object); + return hr; + } + + if (SUCCEEDED(hr = IDirectSound8_CreateSoundBuffer(object->dsound, + &buffer_desc, &buffer, NULL))) + { + IDirectSoundBuffer_Play(buffer, 0, 0, DSBPLAY_LOOPING); + IDirectSoundBuffer_Release(buffer); + } + + TRACE("Created DirectSound renderer %p.\n", object); + *out = &object->renderer.filter.IUnknown_inner; + + return S_OK; +} diff --git a/dlls/quartz/main.c b/dlls/quartz/main.c index 9540fa9293..33c70d7592 100644 --- a/dlls/quartz/main.c +++ b/dlls/quartz/main.c @@ -73,8 +73,8 @@ static const struct object_creation_info object_creation[] = { &CLSID_VideoMixingRenderer, VMR7Impl_create }, { &CLSID_VideoMixingRenderer9, VMR9Impl_create }, { &CLSID_VideoRendererDefault, VideoRendererDefault_create }, - { &CLSID_DSoundRender, DSoundRender_create }, - { &CLSID_AudioRender, DSoundRender_create }, + { &CLSID_DSoundRender, dsound_render_create }, + { &CLSID_AudioRender, dsound_render_create }, { &CLSID_AVIDec, AVIDec_create }, { &CLSID_SystemClock, QUARTZ_CreateSystemClock }, { &CLSID_ACMWrapper, ACMWrapper_create }, diff --git a/dlls/quartz/quartz_private.h b/dlls/quartz/quartz_private.h index f3ba39fba9..791bec7db6 100644 --- a/dlls/quartz/quartz_private.h +++ b/dlls/quartz/quartz_private.h @@ -40,6 +40,7 @@ #define MEDIATIME_FROM_BYTES(x) ((LONGLONG)(x) * 10000000) #define BYTES_FROM_MEDIATIME(time) ((time) / 10000000) +HRESULT dsound_render_create(IUnknown *outer, void **out) DECLSPEC_HIDDEN; HRESULT filter_graph_create(IUnknown *outer, void **out) DECLSPEC_HIDDEN; HRESULT filter_graph_no_thread_create(IUnknown *outer, void **out) DECLSPEC_HIDDEN; HRESULT FilterMapper2_create(IUnknown *pUnkOuter, LPVOID *ppObj) DECLSPEC_HIDDEN; @@ -47,7 +48,6 @@ HRESULT FilterMapper_create(IUnknown *pUnkOuter, LPVOID *ppObj) DECLSPEC_HIDDEN; HRESULT AsyncReader_create(IUnknown * pUnkOuter, LPVOID * ppv) DECLSPEC_HIDDEN; HRESULT StdMemAllocator_create(IUnknown * pUnkOuter, LPVOID * ppv) DECLSPEC_HIDDEN; HRESULT AVIDec_create(IUnknown * pUnkOuter, LPVOID * ppv) DECLSPEC_HIDDEN; -HRESULT DSoundRender_create(IUnknown * pUnkOuter, LPVOID * ppv) DECLSPEC_HIDDEN; HRESULT VideoRenderer_create(IUnknown * pUnkOuter, LPVOID * ppv) DECLSPEC_HIDDEN; HRESULT VideoRendererDefault_create(IUnknown * pUnkOuter, LPVOID * ppv) DECLSPEC_HIDDEN; HRESULT QUARTZ_CreateSystemClock(IUnknown * pUnkOuter, LPVOID * ppv) DECLSPEC_HIDDEN;

1 0

Zebediah Figura : quartz/dsoundrender: Delegate IReferenceClock to the system clock.
by Alexandre Julliard Nov. 29, 2019

Nov. 29, 2019

Module: wine Branch: master Commit: 63a6b308e91232dd55dd107595a6181c70180dd4 URL: https://source.winehq.org/git/wine.git/?a=commit;h=63a6b308e91232dd55dd1075… Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Thu Nov 28 17:35:40 2019 -0600 quartz/dsoundrender: Delegate IReferenceClock to the system clock. For several reasons. Firstly, the reference clock should still function when the filter is not running. Secondly, IDirectSoundBuffer::GetPositions() in practice returns very coarse positions, both on Windows and on Wine. On my hardware, the resolution is about 10ms, which, while suitable for the DirectSound renderer and probably also any video renderers, is nevertheless actually coarser than GetTickCount(). Thirdly, testing supports that the native DirectSound renderer returns a timestamp from IReferenceClock::GetTime() that is more accurate than IDirectSoundBuffer::GetPositions(). In fact, after dumping a large number of different clock sources, I came to the conclusion that it is probably using timeGetTime() as a source. On Wine that's identical to GetTickCount(), so we may as well just delegate directly to the system clock. Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/quartz/dsoundrender.c | 301 +++------------------------------------------ 1 file changed, 14 insertions(+), 287 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=63a6b308e91232dd55dd…

1 0