March 2019 - Wine-Commits - list.winehq.org

Nikolay Sivov : mfplat: Take a shortcut when comparing attribute with mismatching type.
by Alexandre Julliard March 18, 2019

March 18, 2019

Module: wine Branch: master Commit: 98500d8dbbc86fc06adbea2460423a5b30df9617 URL: https://source.winehq.org/git/wine.git/?a=commit;h=98500d8dbbc86fc06adbea24… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Mon Mar 18 13:00:58 2019 +0300 mfplat: Take a shortcut when comparing attribute with mismatching type. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mfplat/main.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/dlls/mfplat/main.c b/dlls/mfplat/main.c index 7481b77..0024531 100644 --- a/dlls/mfplat/main.c +++ b/dlls/mfplat/main.c @@ -757,7 +757,10 @@ static HRESULT WINAPI mfattributes_CompareItem(IMFAttributes *iface, REFGUID key EnterCriticalSection(&attributes->cs); if ((attribute = attributes_find_item(attributes, key, NULL))) - *result = !PropVariantCompareEx(&attribute->value, value, PVCU_DEFAULT, PVCF_DEFAULT); + { + *result = attribute->value.vt == value->vt && + !PropVariantCompareEx(&attribute->value, value, PVCU_DEFAULT, PVCF_DEFAULT); + } LeaveCriticalSection(&attributes->cs);

1 0

Nikolay Sivov : mfplat: Add some sample attributes guids.
by Alexandre Julliard March 18, 2019

March 18, 2019

Module: wine Branch: master Commit: 1fb58907c086650726228ed8becc0df1124b862f URL: https://source.winehq.org/git/wine.git/?a=commit;h=1fb58907c086650726228ed8… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Mon Mar 18 13:01:00 2019 +0300 mfplat: Add some sample attributes guids. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mfplat/main.c | 3 +++ include/mfapi.h | 4 ++++ 2 files changed, 7 insertions(+) diff --git a/dlls/mfplat/main.c b/dlls/mfplat/main.c index 0024531..ccd0a03 100644 --- a/dlls/mfplat/main.c +++ b/dlls/mfplat/main.c @@ -575,6 +575,7 @@ static const char *debugstr_attr(const GUID *guid) X(MF_MT_FRAME_RATE_RANGE_MAX), X(MF_MT_USER_DATA), X(MF_READWRITE_DISABLE_CONVERTERS), + X(MFSampleExtension_Token), X(MF_PD_SAMI_STYLELIST), X(MF_SD_LANGUAGE), X(MF_SD_PROTECTED), @@ -589,12 +590,14 @@ static const char *debugstr_attr(const GUID *guid) X(MF_BYTESTREAM_DLNA_PROFILE_ID), X(MF_MT_MAJOR_TYPE), X(MF_PD_ADAPTIVE_STREAMING), + X(MFSampleExtension_Timestamp), X(MF_MT_SUBTYPE), X(MF_SD_MUTUALLY_EXCLUSIVE), X(MF_SD_STREAM_NAME), X(MF_SINK_WRITER_D3D_MANAGER), X(MF_MT_INTERLACE_MODE), X(MF_READWRITE_MMCSS_PRIORITY), + X(MFSampleExtension_DecodeTimestamp), X(MF_SINK_WRITER_DISABLE_THROTTLING), X(MF_READWRITE_D3D_OPTIONAL), X(MF_READWRITE_MMCSS_CLASS_AUDIO), diff --git a/include/mfapi.h b/include/mfapi.h index 21876fe..a586991 100644 --- a/include/mfapi.h +++ b/include/mfapi.h @@ -118,6 +118,10 @@ DEFINE_GUID(MFMediaType_Stream, 0xe436eb83, 0x524f, 0x11ce, 0x9f, 0x5 DEFINE_GUID(MFMediaType_Subtitle, 0xa6d13581, 0xed50, 0x4e65, 0xae, 0x08, 0x26, 0x06, 0x55, 0x76, 0xaa, 0xcc); DEFINE_GUID(MFMediaType_Video, 0x73646976, 0x0000, 0x0010, 0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71); +DEFINE_GUID(MFSampleExtension_DecodeTimestamp, 0x73a954d4, 0x09e2, 0x4861, 0xbe, 0xfc, 0x94, 0xbd, 0x97, 0xc0, 0x8e, 0x6e); +DEFINE_GUID(MFSampleExtension_Timestamp, 0x1e436999, 0x69be, 0x4c7a, 0x93, 0x69, 0x70, 0x06, 0x8c, 0x02, 0x60, 0xcb); +DEFINE_GUID(MFSampleExtension_Token, 0x8294da66, 0xf328, 0x4805, 0xb5, 0x51, 0x00, 0xde, 0xb4, 0xc5, 0x7a, 0x61); + typedef unsigned __int64 MFWORKITEM_KEY; typedef enum

1 0

Nikolay Sivov : mferror: Add error messages dll.
by Alexandre Julliard March 18, 2019

March 18, 2019

Module: wine Branch: master Commit: 722c436338d1173406a4d3088404f445942ab608 URL: https://source.winehq.org/git/wine.git/?a=commit;h=722c436338d1173406a4d308… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Fri Mar 15 15:20:43 2019 +0300 mferror: Add error messages dll. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- configure | 2 + configure.ac | 1 + dlls/mferror/Makefile.in | 4 + dlls/mferror/mferror.mc | 542 ++++++++++++++++++++++++++++++++++++++++++++++ dlls/mferror/mferror.spec | 1 + include/mferror.h | 2 + po/ar.po | 404 +++++++++++++++++++++++++++++++++- po/bg.po | 326 +++++++++++++++++++++++++++- po/ca.po | 404 +++++++++++++++++++++++++++++++++- po/cs.po | 402 +++++++++++++++++++++++++++++++++- po/da.po | 404 +++++++++++++++++++++++++++++++++- po/de.po | 404 +++++++++++++++++++++++++++++++++- po/el.po | 324 ++++++++++++++++++++++++++- po/en.po | 288 +++++++++++++++++++++++- po/en_US.po | 288 +++++++++++++++++++++++- po/eo.po | 360 +++++++++++++++++++++++++++++- po/es.po | 404 +++++++++++++++++++++++++++++++++- po/fa.po | 300 ++++++++++++++++++++++++- po/fi.po | 404 +++++++++++++++++++++++++++++++++- po/fr.po | 404 +++++++++++++++++++++++++++++++++- po/he.po | 337 +++++++++++++++++++++++++++- po/hi.po | 290 ++++++++++++++++++++++++- po/hr.po | 404 +++++++++++++++++++++++++++++++++- po/hu.po | 404 +++++++++++++++++++++++++++++++++- po/it.po | 404 +++++++++++++++++++++++++++++++++- po/ja.po | 404 +++++++++++++++++++++++++++++++++- po/ko.po | 404 +++++++++++++++++++++++++++++++++- po/lt.po | 404 +++++++++++++++++++++++++++++++++- po/ml.po | 292 ++++++++++++++++++++++++- po/nb_NO.po | 404 +++++++++++++++++++++++++++++++++- po/nl.po | 404 +++++++++++++++++++++++++++++++++- po/or.po | 290 ++++++++++++++++++++++++- po/pa.po | 290 ++++++++++++++++++++++++- po/pl.po | 404 +++++++++++++++++++++++++++++++++- po/pt_BR.po | 404 +++++++++++++++++++++++++++++++++- po/pt_PT.po | 404 +++++++++++++++++++++++++++++++++- po/rm.po | 293 ++++++++++++++++++++++++- po/ro.po | 384 +++++++++++++++++++++++++++++++- po/ru.po | 404 +++++++++++++++++++++++++++++++++- po/si.po | 354 +++++++++++++++++++++++++++++- po/sk.po | 367 ++++++++++++++++++++++++++++++- po/sl.po | 404 +++++++++++++++++++++++++++++++++- po/sr_RS(a)cyrillic.po | 337 +++++++++++++++++++++++++++- po/sr_RS(a)latin.po | 337 +++++++++++++++++++++++++++- po/sv.po | 404 +++++++++++++++++++++++++++++++++- po/ta.po | 288 +++++++++++++++++++++++- po/te.po | 290 ++++++++++++++++++++++++- po/th.po | 311 +++++++++++++++++++++++++- po/tr.po | 404 +++++++++++++++++++++++++++++++++- po/uk.po | 398 +++++++++++++++++++++++++++++++++- po/wa.po | 297 ++++++++++++++++++++++++- po/wine.pot | 288 +++++++++++++++++++++++- po/zh_CN.po | 404 +++++++++++++++++++++++++++++++++- po/zh_TW.po | 404 +++++++++++++++++++++++++++++++++- 54 files changed, 17883 insertions(+), 96 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=722c436338d1173406a4…

1 0

Józef Kucia : wined3d: Set 3D device caps in adapter_gl_get_wined3d_caps().
by Alexandre Julliard March 18, 2019

March 18, 2019

Module: wine Branch: master Commit: 362134b69ef7bc16863d4f630d50ab6ea7ff299d URL: https://source.winehq.org/git/wine.git/?a=commit;h=362134b69ef7bc16863d4f63… Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Sun Mar 17 18:51:06 2019 +0100 wined3d: Set 3D device caps in adapter_gl_get_wined3d_caps(). Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wined3d/adapter_gl.c | 7 +++++++ dlls/wined3d/directx.c | 10 ---------- 2 files changed, 7 insertions(+), 10 deletions(-) diff --git a/dlls/wined3d/adapter_gl.c b/dlls/wined3d/adapter_gl.c index 4b54455..b02241b 100644 --- a/dlls/wined3d/adapter_gl.c +++ b/dlls/wined3d/adapter_gl.c @@ -4251,6 +4251,13 @@ static void adapter_gl_get_wined3d_caps(const struct wined3d_adapter *adapter, s const struct wined3d_d3d_info *d3d_info = &adapter->d3d_info; const struct wined3d_gl_info *gl_info = &adapter->gl_info; + caps->ddraw_caps.dds_caps |= WINEDDSCAPS_3DDEVICE + | WINEDDSCAPS_MIPMAP + | WINEDDSCAPS_TEXTURE + | WINEDDSCAPS_VIDEOMEMORY + | WINEDDSCAPS_ZBUFFER; + caps->ddraw_caps.caps |= WINEDDCAPS_3D; + if (gl_info->supported[ARB_FRAMEBUFFER_OBJECT] || gl_info->supported[EXT_FRAMEBUFFER_OBJECT]) caps->Caps2 |= WINED3DCAPS2_CANGENMIPMAP; diff --git a/dlls/wined3d/directx.c b/dlls/wined3d/directx.c index d2e44f4..debc4e5 100644 --- a/dlls/wined3d/directx.c +++ b/dlls/wined3d/directx.c @@ -2291,16 +2291,6 @@ HRESULT CDECL wined3d_get_device_caps(const struct wined3d *wined3d, unsigned in | WINEDDSCAPS_SYSTEMMEMORY | WINEDDSCAPS_VISIBLE; - if (!(wined3d->flags & WINED3D_NO3D)) - { - caps->ddraw_caps.dds_caps |= WINEDDSCAPS_3DDEVICE - | WINEDDSCAPS_MIPMAP - | WINEDDSCAPS_TEXTURE - | WINEDDSCAPS_VIDEOMEMORY - | WINEDDSCAPS_ZBUFFER; - caps->ddraw_caps.caps |= WINEDDCAPS_3D; - } - caps->shader_double_precision = d3d_info->shader_double_precision; caps->viewport_array_index_any_shader = d3d_info->viewport_array_index_any_shader;

1 0

Józef Kucia : wined3d: Make adapter partially responsible for filling wined3d caps.
by Alexandre Julliard March 18, 2019

March 18, 2019

Module: wine Branch: master Commit: f9fe72536100b4beb8544e870cb8f17fbc663ed8 URL: https://source.winehq.org/git/wine.git/?a=commit;h=f9fe72536100b4beb8544e87… Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Sun Mar 17 18:51:05 2019 +0100 wined3d: Make adapter partially responsible for filling wined3d caps. Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wined3d/adapter_gl.c | 146 +++++++++++++++++++++++++++++++++++++ dlls/wined3d/directx.c | 159 ++++------------------------------------- dlls/wined3d/wined3d_private.h | 2 + include/wine/wined3d.h | 2 +- 4 files changed, 162 insertions(+), 147 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=f9fe72536100b4beb854…

1 0

Sebastian Lackner : winex11: Forward all clipping requests to the right thread.
by Alexandre Julliard March 18, 2019

March 18, 2019

Module: wine Branch: master Commit: e2389c015c69a036aab183eaf16a2dd1e7341330 URL: https://source.winehq.org/git/wine.git/?a=commit;h=e2389c015c69a036aab183ea… Author: Sebastian Lackner <sebastian(a)fds-team.de> Date: Mon Mar 18 13:39:57 2019 +0100 winex11: Forward all clipping requests to the right thread. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=38087 Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/winex11.drv/mouse.c | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/dlls/winex11.drv/mouse.c b/dlls/winex11.drv/mouse.c index d678706..f737a30 100644 --- a/dlls/winex11.drv/mouse.c +++ b/dlls/winex11.drv/mouse.c @@ -464,6 +464,8 @@ void reset_clipping_window(void) ClipCursor( NULL ); /* make sure the clip rectangle is reset too */ } +BOOL CDECL X11DRV_ClipCursor( const RECT *clip ); + /*********************************************************************** * clip_cursor_notify * @@ -492,12 +494,10 @@ LRESULT clip_cursor_notify( HWND hwnd, HWND new_clip_hwnd ) } else if (hwnd == GetForegroundWindow()) /* request to clip */ { - RECT clip, virtual_rect = get_virtual_screen_rect(); + RECT clip; GetClipCursor( &clip ); - if (clip.left > virtual_rect.left || clip.right < virtual_rect.right || - clip.top > virtual_rect.top || clip.bottom < virtual_rect.bottom) - return grab_clipping_window( &clip ); + X11DRV_ClipCursor( &clip ); } return 0; } @@ -1471,22 +1471,22 @@ BOOL CDECL X11DRV_ClipCursor( LPCRECT clip ) if (grab_pointer) { HWND foreground = GetForegroundWindow(); + DWORD tid, pid; + + /* forward request to the foreground window if it's in a different thread */ + tid = GetWindowThreadProcessId( foreground, &pid ); + if (tid && tid != GetCurrentThreadId() && pid == GetCurrentProcessId()) + { + TRACE( "forwarding clip request to %p\n", foreground ); + SendNotifyMessageW( foreground, WM_X11DRV_CLIP_CURSOR, 0, 0 ); + return TRUE; + } /* we are clipping if the clip rectangle is smaller than the screen */ if (clip->left > virtual_rect.left || clip->right < virtual_rect.right || clip->top > virtual_rect.top || clip->bottom < virtual_rect.bottom) { - DWORD tid, pid; - - /* forward request to the foreground window if it's in a different thread */ - tid = GetWindowThreadProcessId( foreground, &pid ); - if (tid && tid != GetCurrentThreadId() && pid == GetCurrentProcessId()) - { - TRACE( "forwarding clip request to %p\n", foreground ); - SendNotifyMessageW( foreground, WM_X11DRV_CLIP_CURSOR, 0, 0 ); - return TRUE; - } - else if (grab_clipping_window( clip )) return TRUE; + if (grab_clipping_window( clip )) return TRUE; } else /* if currently clipping, check if we should switch to fullscreen clipping */ {

1 0

Nikolay Sivov : mfplat/tests: Skip more tests on older systems.
by Alexandre Julliard March 18, 2019

March 18, 2019

Module: wine Branch: master Commit: dd67345ea4de70cc8357c3e971abb18a7ac771d1 URL: https://source.winehq.org/git/wine.git/?a=commit;h=dd67345ea4de70cc8357c3e9… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Mon Mar 18 14:58:31 2019 +0300 mfplat/tests: Skip more tests on older systems. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mfplat/tests/mfplat.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/dlls/mfplat/tests/mfplat.c b/dlls/mfplat/tests/mfplat.c index ba9e8c3..4c878c9 100644 --- a/dlls/mfplat/tests/mfplat.c +++ b/dlls/mfplat/tests/mfplat.c @@ -1449,16 +1449,19 @@ static HRESULT WINAPI testcallback_Invoke(IMFAsyncCallback *iface, IMFAsyncResul hr = IMFMediaEventQueue_GetEvent(queue, 0, &event); ok(hr == MF_E_MULTIPLE_SUBSCRIBERS, "Failed to get event, hr %#x.\n", hr); - } - hr = IMFMediaEventQueue_EndGetEvent(queue, result, &event); - ok(hr == S_OK, "Failed to finalize GetEvent, hr %#x.\n", hr); + hr = IMFMediaEventQueue_EndGetEvent(queue, result, &event); + ok(hr == S_OK, "Failed to finalize GetEvent, hr %#x.\n", hr); + + hr = IMFMediaEventQueue_EndGetEvent(queue, result, &event); + ok(hr == E_FAIL, "Unexpected result, hr %#x.\n", hr); + + IMFMediaEvent_Release(event); + } hr = IMFAsyncResult_GetObject(result, &obj); ok(hr == E_POINTER, "Unexpected hr %#x.\n", hr); - IMFMediaEvent_Release(event); - IMFMediaEventQueue_Release(queue); SetEvent(callback->event);

1 0

Nikolay Sivov : mfreadwrite: Query presentation descriptor on reader creation.
by Alexandre Julliard March 18, 2019

March 18, 2019

Module: wine Branch: master Commit: fcae0bc7550850a0b2800017045ba5121eb708c6 URL: https://source.winehq.org/git/wine.git/?a=commit;h=fcae0bc7550850a0b2800017… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Mon Mar 18 13:01:01 2019 +0300 mfreadwrite: Query presentation descriptor on reader creation. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mfreadwrite/main.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/dlls/mfreadwrite/main.c b/dlls/mfreadwrite/main.c index 034d5f8..df8f89a 100644 --- a/dlls/mfreadwrite/main.c +++ b/dlls/mfreadwrite/main.c @@ -76,6 +76,7 @@ typedef struct source_reader IMFSourceReader IMFSourceReader_iface; LONG refcount; IMFMediaSource *source; + IMFPresentationDescriptor *descriptor; } srcreader; struct sink_writer @@ -135,6 +136,8 @@ static ULONG WINAPI src_reader_Release(IMFSourceReader *iface) if (!refcount) { + if (reader->descriptor) + IMFPresentationDescriptor_Release(reader->descriptor); IMFMediaSource_Release(reader->source); heap_free(reader); } @@ -279,7 +282,12 @@ static HRESULT create_source_reader_from_source(IMFMediaSource *source, IMFAttri object->source = source; IMFMediaSource_AddRef(object->source); + if (FAILED(hr = IMFMediaSource_CreatePresentationDescriptor(object->source, &object->descriptor))) + goto failed; + hr = IMFSourceReader_QueryInterface(&object->IMFSourceReader_iface, riid, out); + +failed: IMFSourceReader_Release(&object->IMFSourceReader_iface); return hr; }

1 0

Nikolay Sivov : mfplat: Implement Compare() for attributes.
by Alexandre Julliard March 18, 2019

March 18, 2019

Module: wine Branch: master Commit: 780378b20327b8876dce40f2834b4f08f3e71857 URL: https://source.winehq.org/git/wine.git/?a=commit;h=780378b20327b8876dce40f2… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Mon Mar 18 13:00:56 2019 +0300 mfplat: Implement Compare() for attributes. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mfplat/main.c | 101 ++++++++++++++++++-- dlls/mfplat/tests/mfplat.c | 223 ++++++++++++++++++++++++++++++++++++++++++++- 2 files changed, 315 insertions(+), 9 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=780378b20327b8876dce…

1 0

Nikolay Sivov : mfplat: Get rid of variant coercion calls.
by Alexandre Julliard March 18, 2019

March 18, 2019

Module: wine Branch: master Commit: ced0a1de7e016a4bf10a188c4ebe10365cd8e220 URL: https://source.winehq.org/git/wine.git/?a=commit;h=ced0a1de7e016a4bf10a188c… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Mon Mar 18 13:00:57 2019 +0300 mfplat: Get rid of variant coercion calls. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mfplat/main.c | 72 ++++++++++++++++++++++++++++++++-------------- dlls/mfplat/tests/mfplat.c | 4 ++- 2 files changed, 53 insertions(+), 23 deletions(-) diff --git a/dlls/mfplat/main.c b/dlls/mfplat/main.c index 4589840..7481b77 100644 --- a/dlls/mfplat/main.c +++ b/dlls/mfplat/main.c @@ -37,6 +37,7 @@ #include "mfplat_private.h" #include "mfreadwrite.h" #include "propvarutil.h" +#include "strsafe.h" WINE_DEFAULT_DEBUG_CHANNEL(mfplat); @@ -857,7 +858,8 @@ static HRESULT WINAPI mfattributes_GetUINT32(IMFAttributes *iface, REFGUID key, attrval.vt = VT_UI4; hr = attributes_get_item(attributes, key, &attrval); if (SUCCEEDED(hr)) - hr = PropVariantToUInt32(&attrval, value); + *value = attrval.u.ulVal; + return hr; } @@ -873,7 +875,8 @@ static HRESULT WINAPI mfattributes_GetUINT64(IMFAttributes *iface, REFGUID key, attrval.vt = VT_UI8; hr = attributes_get_item(attributes, key, &attrval); if (SUCCEEDED(hr)) - hr = PropVariantToUInt64(&attrval, value); + *value = attrval.u.uhVal.QuadPart; + return hr; } @@ -889,7 +892,8 @@ static HRESULT WINAPI mfattributes_GetDouble(IMFAttributes *iface, REFGUID key, attrval.vt = VT_R8; hr = attributes_get_item(attributes, key, &attrval); if (SUCCEEDED(hr)) - hr = PropVariantToDouble(&attrval, value); + *value = attrval.u.dblVal; + return hr; } @@ -905,7 +909,7 @@ static HRESULT WINAPI mfattributes_GetGUID(IMFAttributes *iface, REFGUID key, GU attrval.vt = VT_CLSID; hr = attributes_get_item(attributes, key, &attrval); if (SUCCEEDED(hr)) - hr = PropVariantToGUID(&attrval, value); + *value = *attrval.u.puuid; return hr; } @@ -913,17 +917,25 @@ static HRESULT WINAPI mfattributes_GetGUID(IMFAttributes *iface, REFGUID key, GU static HRESULT WINAPI mfattributes_GetStringLength(IMFAttributes *iface, REFGUID key, UINT32 *length) { struct attributes *attributes = impl_from_IMFAttributes(iface); - PROPVARIANT attrval; - HRESULT hr; + struct attribute *attribute; + HRESULT hr = S_OK; TRACE("%p, %s, %p.\n", iface, debugstr_attr(key), length); - PropVariantInit(&attrval); - attrval.vt = VT_LPWSTR; - hr = attributes_get_item(attributes, key, &attrval); - if (SUCCEEDED(hr) && length) - *length = lstrlenW(attrval.u.pwszVal); - PropVariantClear(&attrval); + EnterCriticalSection(&attributes->cs); + + attribute = attributes_find_item(attributes, key, NULL); + if (attribute) + { + if (attribute->value.vt == MF_ATTRIBUTE_STRING) + *length = strlenW(attribute->value.u.pwszVal); + else + hr = MF_E_INVALIDTYPE; + } + else + hr = MF_E_ATTRIBUTENOTFOUND; + + LeaveCriticalSection(&attributes->cs); return hr; } @@ -932,19 +944,35 @@ static HRESULT WINAPI mfattributes_GetString(IMFAttributes *iface, REFGUID key, UINT32 size, UINT32 *length) { struct attributes *attributes = impl_from_IMFAttributes(iface); - PROPVARIANT attrval; - HRESULT hr; + struct attribute *attribute; + HRESULT hr = S_OK; TRACE("%p, %s, %p, %d, %p.\n", iface, debugstr_attr(key), value, size, length); - PropVariantInit(&attrval); - attrval.vt = VT_LPWSTR; - hr = attributes_get_item(attributes, key, &attrval); - if (SUCCEEDED(hr)) - hr = PropVariantToString(&attrval, value, size); - if (SUCCEEDED(hr) && length) - *length = lstrlenW(value); - PropVariantClear(&attrval); + EnterCriticalSection(&attributes->cs); + + attribute = attributes_find_item(attributes, key, NULL); + if (attribute) + { + if (attribute->value.vt == MF_ATTRIBUTE_STRING) + { + int len = strlenW(attribute->value.u.pwszVal); + + if (length) + *length = len; + + if (size <= len) + return STRSAFE_E_INSUFFICIENT_BUFFER; + + memcpy(value, attribute->value.u.pwszVal, (len + 1) * sizeof(WCHAR)); + } + else + hr = MF_E_INVALIDTYPE; + } + else + hr = MF_E_ATTRIBUTENOTFOUND; + + LeaveCriticalSection(&attributes->cs); return hr; } diff --git a/dlls/mfplat/tests/mfplat.c b/dlls/mfplat/tests/mfplat.c index 7c36210..31b6ba1 100644 --- a/dlls/mfplat/tests/mfplat.c +++ b/dlls/mfplat/tests/mfplat.c @@ -708,9 +708,11 @@ static void test_attributes(void) ok(!lstrcmpW(bufferW, stringW), "Unexpected string %s.\n", wine_dbgstr_w(bufferW)); memset(bufferW, 0, sizeof(bufferW)); - hr = IMFAttributes_GetString(attributes, &DUMMY_GUID1, bufferW, 1, NULL); + string_length = 0; + hr = IMFAttributes_GetString(attributes, &DUMMY_GUID1, bufferW, 1, &string_length); ok(hr == STRSAFE_E_INSUFFICIENT_BUFFER, "Unexpected hr %#x.\n", hr); ok(!bufferW[0], "Unexpected string %s.\n", wine_dbgstr_w(bufferW)); + ok(string_length, "Unexpected length.\n"); string_length = 0xdeadbeef; hr = IMFAttributes_GetStringLength(attributes, &GUID_NULL, &string_length);

1 0