March 2019 - Wine-Commits - list.winehq.org

Michael Stefaniuc : gdi32: Remove unused return value of init_system_links ().
by Alexandre Julliard March 14, 2019

March 14, 2019

Module: wine Branch: master Commit: fe7dcc29089f20efd25d02781e5b61c4bdf47414 URL: https://source.winehq.org/git/wine.git/?a=commit;h=fe7dcc29089f20efd25d0278… Author: Michael Stefaniuc <mstefani(a)winehq.org> Date: Tue Mar 12 21:19:19 2019 +0100 gdi32: Remove unused return value of init_system_links(). Signed-off-by: Michael Stefaniuc <mstefani(a)winehq.org> Signed-off-by: Huw Davies <huw(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/gdi32/freetype.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/dlls/gdi32/freetype.c b/dlls/gdi32/freetype.c index 68d232e..333856e 100644 --- a/dlls/gdi32/freetype.c +++ b/dlls/gdi32/freetype.c @@ -2568,10 +2568,9 @@ static void populate_system_links(const WCHAR *name, const WCHAR *const *values) /************************************************************* * init_system_links */ -static BOOL init_system_links(void) +static void init_system_links(void) { HKEY hkey; - BOOL ret = FALSE; DWORD type, max_val, max_data, val_len, data_len, index; WCHAR *value, *data; WCHAR *entry, *next; @@ -2717,7 +2716,6 @@ skip_internal: } } list_add_tail(&system_links, &system_font_link->entry); - return ret; } static BOOL ReadFontDir(const char *dirname, BOOL external_fonts)

1 0

Józef Kucia : d3dxof: Change "value" size to 512.
by Alexandre Julliard March 14, 2019

March 14, 2019

Module: wine Branch: master Commit: 360df6a520a90c2e4991739da3bdcd63619f5c9e URL: https://source.winehq.org/git/wine.git/?a=commit;h=360df6a520a90c2e4991739d… Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Wed Mar 13 00:11:06 2019 +0100 d3dxof: Change "value" size to 512. is_name() may write up to 512 bytes to the "value". Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Matteo Bruni <mbruni(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/d3dxof/d3dxof_private.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/d3dxof/d3dxof_private.h b/dlls/d3dxof/d3dxof_private.h index cf33ed2..ff29261 100644 --- a/dlls/d3dxof/d3dxof_private.h +++ b/dlls/d3dxof/d3dxof_private.h @@ -130,7 +130,7 @@ typedef struct { BOOL list_separator; ULONG cur_pos_data; LPBYTE cur_pstrings; - BYTE value[100]; + BYTE value[512]; xobject** pxo_globals; ULONG nb_pxo_globals; xobject* pxo_tab;

1 0

Jacek Caban : jscript: Add Array.prototype.map implementation.
by Alexandre Julliard March 14, 2019

March 14, 2019

Module: wine Branch: master Commit: 60816b9f8adf1b70c1d1427440c4a9888caf33c5 URL: https://source.winehq.org/git/wine.git/?a=commit;h=60816b9f8adf1b70c1d14274… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Thu Mar 14 14:30:57 2019 +0100 jscript: Add Array.prototype.map implementation. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/jscript/array.c | 63 +++++++++++++++++++++++++++++++++++++++ dlls/mshtml/tests/documentmode.js | 1 + dlls/mshtml/tests/es5.js | 45 ++++++++++++++++++++++++++++ 3 files changed, 109 insertions(+) diff --git a/dlls/jscript/array.c b/dlls/jscript/array.c index 28289cb..a7b1f02 100644 --- a/dlls/jscript/array.c +++ b/dlls/jscript/array.c @@ -49,6 +49,7 @@ static const WCHAR toStringW[] = {'t','o','S','t','r','i','n','g',0}; static const WCHAR toLocaleStringW[] = {'t','o','L','o','c','a','l','e','S','t','r','i','n','g',0}; static const WCHAR unshiftW[] = {'u','n','s','h','i','f','t',0}; static const WCHAR indexOfW[] = {'i','n','d','e','x','O','f',0}; +static const WCHAR mapW[] = {'m','a','p',0}; static const WCHAR default_separatorW[] = {',',0}; @@ -1044,6 +1045,67 @@ static HRESULT Array_indexOf(script_ctx_t *ctx, vdisp_t *vthis, WORD flags, unsi return S_OK; } +static HRESULT Array_map(script_ctx_t *ctx, vdisp_t *vthis, WORD flags, unsigned argc, jsval_t *argv, jsval_t *r) +{ + IDispatch *context_this = NULL, *callback; + jsval_t callback_args[3], mapped_value; + jsdisp_t *jsthis, *array; + DWORD length, k; + HRESULT hres; + + TRACE("\n"); + + hres = get_length(ctx, vthis, &jsthis, &length); + if(FAILED(hres)) { + FIXME("Could not get length\n"); + return hres; + } + + /* Fixme check IsCallable */ + if(!argc || !is_object_instance(argv[0]) || !get_object(argv[0])) { + FIXME("Invalid arg %s\n", debugstr_jsval(argc ? argv[0] : jsval_undefined())); + return E_INVALIDARG; + } + callback = get_object(argv[0]); + + if(argc > 1) { + if(!is_object_instance(argv[1]) || !get_object(argv[1])) { + FIXME("Unsupported context this %s\n", debugstr_jsval(argv[1])); + return E_NOTIMPL; + } + context_this = get_object(argv[1]); + } + + hres = create_array(ctx, length, &array); + if(FAILED(hres)) + return hres; + + for(k = 0; k < length; k++) { + hres = jsdisp_get_idx(jsthis, k, &callback_args[0]); + if(hres == DISP_E_UNKNOWNNAME) + continue; + if(FAILED(hres)) + break; + + callback_args[1] = jsval_number(k); + callback_args[2] = jsval_obj(jsthis); + hres = disp_call_value(ctx, callback, context_this, DISPATCH_METHOD, 3, callback_args, &mapped_value); + jsval_release(callback_args[0]); + if(FAILED(hres)) + break; + + hres = jsdisp_propput_idx(array, k, mapped_value); + if(FAILED(hres)) + break; + } + + if(SUCCEEDED(hres) && r) + *r = jsval_obj(array); + else + jsdisp_release(array); + return hres; +} + /* ECMA-262 3rd Edition 15.4.4.13 */ static HRESULT Array_unshift(script_ctx_t *ctx, vdisp_t *vthis, WORD flags, unsigned argc, jsval_t *argv, jsval_t *r) @@ -1146,6 +1208,7 @@ static const builtin_prop_t Array_props[] = { {indexOfW, Array_indexOf, PROPF_METHOD|PROPF_ES5|1}, {joinW, Array_join, PROPF_METHOD|1}, {lengthW, NULL,0, Array_get_length, Array_set_length}, + {mapW, Array_map, PROPF_METHOD|PROPF_ES5|1}, {popW, Array_pop, PROPF_METHOD}, {pushW, Array_push, PROPF_METHOD|1}, {reverseW, Array_reverse, PROPF_METHOD}, diff --git a/dlls/mshtml/tests/documentmode.js b/dlls/mshtml/tests/documentmode.js index 1e8fabd..1cbf13e 100644 --- a/dlls/mshtml/tests/documentmode.js +++ b/dlls/mshtml/tests/documentmode.js @@ -190,6 +190,7 @@ function test_javascript() { test_exposed("forEach", Array.prototype, v >= 9); test_exposed("indexOf", Array.prototype, v >= 9); test_exposed("trim", String.prototype, v >= 9); + test_exposed("map", Array.prototype, v >= 9); /* FIXME: IE8 implements weird semi-functional property descriptors. */ if(v != 8) { diff --git a/dlls/mshtml/tests/es5.js b/dlls/mshtml/tests/es5.js index 69fe0fe..6cfee81 100644 --- a/dlls/mshtml/tests/es5.js +++ b/dlls/mshtml/tests/es5.js @@ -130,6 +130,50 @@ function test_isArray() { next_test(); } +function test_array_map() { + var calls, m, arr, ctx; + + /* basic map call with context */ + calls = ""; + arr = [1,2,3]; + ctx = {}; + m = arr.map(function(x, i, a) { + ok(this === ctx, "this != ctx"); + ok(i === x - 1, "i = " + i); + ok(a === arr, "a != arr"); + calls += x + ","; + return x * 2; + }, ctx); + ok(calls === "1,2,3,", "calls = " + calls); + ok(m.join() === "2,4,6", "m = " + m); + + /* non-array object as this argument */ + calls = ""; + arr = { 1: "one", 2: "two", 3: "three", length: 3 }; + m = Array.prototype.map.call(arr, function(x, i) { + calls += i + ":" + x + ","; + return x + "!"; + }); + ok(calls === "1:one,2:two,", "calls = " + calls); + ok(m.join() === ",one!,two!", "m = " + m); + ok(!("0" in m), "0 is in m"); + + /* mutate array in callback */ + calls = ""; + arr = [1,2,3]; + m = Array.prototype.map.call(arr, function(x, i) { + calls += i + ":" + x + ","; + for(var j = i; j < arr.length; j++) + arr[j]++; + arr.push(i * i); + return x - 1; + }); + ok(calls === "0:1,1:3,2:5,", "calls = " + calls); + ok(m.join() === "0,2,4", "m = " + m); + + next_test(); +} + function test_identifier_keywords() { var o = { if: 1, @@ -625,6 +669,7 @@ var tests = [ test_indexOf, test_array_forEach, test_isArray, + test_array_map, test_identifier_keywords, test_getOwnPropertyDescriptor, test_defineProperty,

1 0

Jacek Caban : mshtml: Access document object via browser object in super_navigate.
by Alexandre Julliard March 14, 2019

March 14, 2019

Module: wine Branch: master Commit: 26d3e0c5dbb1d2343a86bfd980313e5873635d25 URL: https://source.winehq.org/git/wine.git/?a=commit;h=26d3e0c5dbb1d2343a86bfd9… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Thu Mar 14 14:14:08 2019 +0100 mshtml: Access document object via browser object in super_navigate. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mshtml/navigate.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/dlls/mshtml/navigate.c b/dlls/mshtml/navigate.c index 3792fd8..19dda29 100644 --- a/dlls/mshtml/navigate.c +++ b/dlls/mshtml/navigate.c @@ -2139,10 +2139,10 @@ HRESULT super_navigate(HTMLOuterWindow *window, IUri *uri, DWORD flags, const WC if(!uri_nofrag) return E_FAIL; - if(window->doc_obj->client && !(flags & BINDING_REFRESH)) { + if(window->browser->doc->client && !(flags & BINDING_REFRESH)) { IOleCommandTarget *cmdtrg; - hres = IOleClientSite_QueryInterface(window->doc_obj->client, &IID_IOleCommandTarget, (void**)&cmdtrg); + hres = IOleClientSite_QueryInterface(window->browser->doc->client, &IID_IOleCommandTarget, (void**)&cmdtrg); if(SUCCEEDED(hres)) { VARIANT in, out; BSTR url_str; @@ -2187,7 +2187,7 @@ HRESULT super_navigate(HTMLOuterWindow *window, IUri *uri, DWORD flags, const WC return hres; } - prepare_for_binding(&window->doc_obj->basedoc, mon, flags); + prepare_for_binding(&window->browser->doc->basedoc, mon, flags); hres = IUri_GetScheme(uri, &scheme); if(SUCCEEDED(hres) && scheme == URL_SCHEME_JAVASCRIPT) { @@ -2203,7 +2203,7 @@ HRESULT super_navigate(HTMLOuterWindow *window, IUri *uri, DWORD flags, const WC /* Why silently? */ window->readystate = READYSTATE_COMPLETE; if(!(flags & BINDING_FROMHIST)) - call_docview_84(window->doc_obj); + call_docview_84(window->browser->doc); IUri_AddRef(uri); task->window = window; @@ -2228,7 +2228,7 @@ HRESULT super_navigate(HTMLOuterWindow *window, IUri *uri, DWORD flags, const WC /* Silently and repeated when real loading starts? */ window->readystate = READYSTATE_LOADING; if(!(flags & (BINDING_FROMHIST|BINDING_REFRESH))) - call_docview_84(window->doc_obj); + call_docview_84(window->browser->doc); task->window = window; task->bscallback = bsc;

1 0

Jacek Caban : mshtml: Access document object via browser object in navigate_javascript_proc and navigate_fragment.
by Alexandre Julliard March 14, 2019

March 14, 2019

Module: wine Branch: master Commit: 54323080d7b75290aa56624325d7524b0d153a42 URL: https://source.winehq.org/git/wine.git/?a=commit;h=54323080d7b75290aa566243… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Thu Mar 14 14:14:00 2019 +0100 mshtml: Access document object via browser object in navigate_javascript_proc and navigate_fragment. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mshtml/navigate.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/dlls/mshtml/navigate.c b/dlls/mshtml/navigate.c index be83c81..3792fd8 100644 --- a/dlls/mshtml/navigate.c +++ b/dlls/mshtml/navigate.c @@ -2002,7 +2002,7 @@ static void navigate_javascript_proc(task_t *_task) return; } - set_download_state(window->doc_obj, 1); + set_download_state(window->browser->doc, 1); V_VT(&v) = VT_EMPTY; hres = exec_script(window->base.inner_window, code, jscriptW, &v); @@ -2012,10 +2012,10 @@ static void navigate_javascript_proc(task_t *_task) VariantClear(&v); } - if(window->doc_obj->view_sink) - IAdviseSink_OnViewChange(window->doc_obj->view_sink, DVASPECT_CONTENT, -1); + if(window->browser->doc->view_sink) + IAdviseSink_OnViewChange(window->browser->doc->view_sink, DVASPECT_CONTENT, -1); - set_download_state(window->doc_obj, 0); + set_download_state(window->browser->doc, 0); } static void navigate_javascript_task_destr(task_t *_task) @@ -2118,9 +2118,9 @@ static HRESULT navigate_fragment(HTMLOuterWindow *window, IUri *uri) SysFreeString(frag); - if(window->doc_obj->doc_object_service) { - IDocObjectService_FireNavigateComplete2(window->doc_obj->doc_object_service, &window->base.IHTMLWindow2_iface, 0x10); - IDocObjectService_FireDocumentComplete(window->doc_obj->doc_object_service, &window->base.IHTMLWindow2_iface, 0); + if(window->browser->doc->doc_object_service) { + IDocObjectService_FireNavigateComplete2(window->browser->doc->doc_object_service, &window->base.IHTMLWindow2_iface, 0x10); + IDocObjectService_FireDocumentComplete(window->browser->doc->doc_object_service, &window->base.IHTMLWindow2_iface, 0); }

1 0

Francois Gouget : windowscodecs/tests: Add a trailing '\n' to an ok() call.
by Alexandre Julliard March 14, 2019

March 14, 2019

Module: wine Branch: master Commit: 17276a8e40f27ca0a97dec437a7ca8af195367d4 URL: https://source.winehq.org/git/wine.git/?a=commit;h=17276a8e40f27ca0a97dec43… Author: Francois Gouget <fgouget(a)free.fr> Date: Thu Mar 14 02:40:42 2019 +0100 windowscodecs/tests: Add a trailing '\n' to an ok() call. Signed-off-by: Francois Gouget <fgouget(a)free.fr> Signed-off-by: Vincent Povirk <vincent(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/windowscodecs/tests/stream.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/windowscodecs/tests/stream.c b/dlls/windowscodecs/tests/stream.c index 3750c32..048f132 100644 --- a/dlls/windowscodecs/tests/stream.c +++ b/dlls/windowscodecs/tests/stream.c @@ -765,7 +765,7 @@ static void test_StreamOnIStream(void) ok(hr == S_OK, "Failed to create a stream, hr %#x.\n", hr); hr = IWICStream_InitializeFromMemory(stream, memory, sizeof(memory)); - ok(hr == S_OK, "Failed to initialize stream, hr %#x.", hr); + ok(hr == S_OK, "Failed to initialize stream, hr %#x.\n", hr); hr = IWICImagingFactory_CreateStream(factory, &substream); ok(hr == S_OK, "Failed to create a stream, hr %#x.\n", hr);

1 0

Francois Gouget : vssapi: A spelling fix in a variable name.
by Alexandre Julliard March 14, 2019

March 14, 2019

Module: wine Branch: master Commit: 213b415fa9a327054053e044e3838be720aef481 URL: https://source.winehq.org/git/wine.git/?a=commit;h=213b415fa9a327054053e044… Author: Francois Gouget <fgouget(a)free.fr> Date: Thu Mar 14 02:40:15 2019 +0100 vssapi: A spelling fix in a variable name. Signed-off-by: Francois Gouget <fgouget(a)free.fr> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- include/vsbackup.idl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/vsbackup.idl b/include/vsbackup.idl index b2dca11..d2d8795 100644 --- a/include/vsbackup.idl +++ b/include/vsbackup.idl @@ -63,7 +63,7 @@ interface IVssBackupComponents : IUnknown HRESULT GetWriterStatus([in] UINT index, [out] VSS_ID *instance, [out] VSS_ID *id, [out] BSTR *writer, [out] VSS_WRITER_STATE *status, [out] HRESULT *failure); HRESULT SetBackupSucceeded([in] VSS_ID instance, [in] VSS_ID id, [in] VSS_COMPONENT_TYPE ct, - [in] LPCWSTR path, [in] LPCWSTR name, [in] BOOL succeded); + [in] LPCWSTR path, [in] LPCWSTR name, [in] BOOL succeeded); HRESULT SetBackupOptions([in] VSS_ID id, [in] VSS_COMPONENT_TYPE ct, [in] LPCWSTR path, [in] LPCWSTR name, [in] LPCWSTR options); HRESULT SetSelectedForRestore([in] VSS_ID id, [in] VSS_COMPONENT_TYPE ct, [in] LPCWSTR path,

1 0

Francois Gouget : vbscript/tests: A spelling fix in a comment.
by Alexandre Julliard March 14, 2019

March 14, 2019

Module: wine Branch: master Commit: c05a2ae4a753e5f408b473bf5bf076fa743af5e0 URL: https://source.winehq.org/git/wine.git/?a=commit;h=c05a2ae4a753e5f408b473bf… Author: Francois Gouget <fgouget(a)free.fr> Date: Thu Mar 14 02:40:30 2019 +0100 vbscript/tests: A spelling fix in a comment. Signed-off-by: Francois Gouget <fgouget(a)free.fr> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/vbscript/tests/lang.vbs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/vbscript/tests/lang.vbs b/dlls/vbscript/tests/lang.vbs index 9f1d24c..afd7c24 100644 --- a/dlls/vbscript/tests/lang.vbs +++ b/dlls/vbscript/tests/lang.vbs @@ -1366,7 +1366,7 @@ end sub call test_identifiers() sub test_dotIdentifiers - ' test keywords that can also be an indentifier after a dot + ' test keywords that can also be an identifier after a dot ' Call ok(testObj.rem = 10, "testObj.rem = " & testObj.rem & " expected 10") Call ok(testObj.true = 10, "testObj.true = " & testObj.true & " expected 10") Call ok(testObj.false = 10, "testObj.false = " & testObj.false & " expected 10")

1 0

Francois Gouget : dbghelp: Spelling fixes in a couple of comments.
by Alexandre Julliard March 14, 2019

March 14, 2019

Module: wine Branch: master Commit: ab71398eb09d24f9f99b6266cb3005faea7a448f URL: https://source.winehq.org/git/wine.git/?a=commit;h=ab71398eb09d24f9f99b6266… Author: Francois Gouget <fgouget(a)free.fr> Date: Thu Mar 14 02:40:53 2019 +0100 dbghelp: Spelling fixes in a couple of comments. Signed-off-by: Francois Gouget <fgouget(a)free.fr> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/dbghelp/symbol.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/dbghelp/symbol.c b/dlls/dbghelp/symbol.c index 96a1f87..f59e322 100644 --- a/dlls/dbghelp/symbol.c +++ b/dlls/dbghelp/symbol.c @@ -850,7 +850,7 @@ static void symt_get_length(struct module* module, const struct symt* symt, ULON *size = 0x1000; /* arbitrary value */ } -/* neede by symt_find_nearest */ +/* needed by symt_find_nearest */ static int symt_get_best_at(struct module* module, int idx_sorttab) { ULONG64 ref_addr; @@ -870,7 +870,7 @@ static int symt_get_best_at(struct module* module, int idx_sorttab) !cmp_sorttab_addr(module, idx_sorttab + 1, ref_addr)) idx_sorttab++; } - /* if no better symbol fond restore original */ + /* if no better symbol was found restore the original */ if (module->addr_sorttab[idx_sorttab]->symt.tag == SymTagPublicSymbol) idx_sorttab = idx_sorttab_orig; }

1 0

Jactry Zeng : mfplat: Implement IMFAttributes::DeleteAllItems().
by Alexandre Julliard March 14, 2019

March 14, 2019

Module: wine Branch: master Commit: 20ab5230f6835a66f9ae004b6f22f368dbb41f4b URL: https://source.winehq.org/git/wine.git/?a=commit;h=20ab5230f6835a66f9ae004b… Author: Jactry Zeng <jzeng(a)codeweavers.com> Date: Thu Mar 14 11:03:16 2019 +0300 mfplat: Implement IMFAttributes::DeleteAllItems(). Signed-off-by: Jactry Zeng <jzeng(a)codeweavers.com> Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mfplat/main.c | 18 +++++++++++++++--- dlls/mfplat/tests/mfplat.c | 4 ++++ 2 files changed, 19 insertions(+), 3 deletions(-) diff --git a/dlls/mfplat/main.c b/dlls/mfplat/main.c index 31bed33..5a37eba 100644 --- a/dlls/mfplat/main.c +++ b/dlls/mfplat/main.c @@ -962,11 +962,23 @@ static HRESULT WINAPI mfattributes_DeleteItem(IMFAttributes *iface, REFGUID key) static HRESULT WINAPI mfattributes_DeleteAllItems(IMFAttributes *iface) { - mfattributes *This = impl_from_IMFAttributes(iface); + struct attributes *attributes = impl_from_IMFAttributes(iface); - FIXME("%p\n", This); + TRACE("%p.\n", iface); - return E_NOTIMPL; + EnterCriticalSection(&attributes->cs); + + while (attributes->count) + { + PropVariantClear(&attributes->attributes[--attributes->count].value); + } + heap_free(attributes->attributes); + attributes->attributes = NULL; + attributes->capacity = 0; + + LeaveCriticalSection(&attributes->cs); + + return S_OK; } static HRESULT WINAPI mfattributes_SetUINT32(IMFAttributes *iface, REFGUID key, UINT32 value) diff --git a/dlls/mfplat/tests/mfplat.c b/dlls/mfplat/tests/mfplat.c index 5579e02..a999b9b 100644 --- a/dlls/mfplat/tests/mfplat.c +++ b/dlls/mfplat/tests/mfplat.c @@ -714,6 +714,10 @@ static void test_MFCreateAttributes(void) hr = IMFAttributes_GetUnknown(attributes, &DUMMY_CLSID, &IID_IUnknown, (void **)&unk_value); ok(hr == MF_E_INVALIDTYPE, "Unexpected hr %#x.\n", hr); + hr = IMFAttributes_DeleteAllItems(attributes); + ok(hr == S_OK, "Failed to delete items, hr %#x.\n", hr); + CHECK_ATTR_COUNT(attributes, 0); + IMFAttributes_Release(attributes); }

1 0