September 2019 - Wine-Commits

Zebediah Figura : winegstreamer: Reimplement the MPEG splitter on top of the mpegaudioparse plugin.
by Alexandre Julliard Sept. 23, 2019

Sept. 23, 2019

Module: wine Branch: master Commit: 40a4c782b7f77534535dfa7bb2a97049026fef47 URL: https://source.winehq.org/git/wine.git/?a=commit;h=40a4c782b7f77534535dfa7b… Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Fri Sep 20 17:35:05 2019 -0500 winegstreamer: Reimplement the MPEG splitter on top of the mpegaudioparse plugin. Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/quartz/Makefile.in | 1 - dlls/quartz/main.c | 1 - dlls/quartz/mpegsplit.c | 890 --------------------------------------- dlls/quartz/quartz_private.h | 1 - dlls/quartz/quartz_strmif.idl | 7 - dlls/quartz/regsvr.c | 27 -- dlls/quartz/tests/mpegsplit.c | 14 +- dlls/winegstreamer/gst_private.h | 1 + dlls/winegstreamer/gstdemux.c | 292 ++++++++++++- dlls/winegstreamer/main.c | 66 +++ 10 files changed, 359 insertions(+), 941 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=40a4c782b7f77534535d…

1 0

Henri Verbeet : wined3d: Move the "buffer_object" field from struct wined3d_buffer_gl to struct wined3d_buffer.
by Alexandre Julliard Sept. 23, 2019

Sept. 23, 2019

Module: wine Branch: master Commit: 179c8cc86faab506bc7589a74f92e033869ddc40 URL: https://source.winehq.org/git/wine.git/?a=commit;h=179c8cc86faab506bc7589a7… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Mon Sep 23 15:12:17 2019 +0330 wined3d: Move the "buffer_object" field from struct wined3d_buffer_gl to struct wined3d_buffer. We'll want to use this for Vulkan buffers as well. Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wined3d/adapter_gl.c | 2 +- dlls/wined3d/buffer.c | 24 ++++++++++++++---------- dlls/wined3d/context.c | 6 +++--- dlls/wined3d/state.c | 14 ++++---------- dlls/wined3d/view.c | 7 +++---- dlls/wined3d/wined3d_private.h | 2 +- 6 files changed, 26 insertions(+), 29 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=179c8cc86faab506bc75…

1 0

Henri Verbeet : wined3d: Use explicit flushing in wined3d_context_gl_unmap_bo_address().
by Alexandre Julliard Sept. 23, 2019

Sept. 23, 2019

Module: wine Branch: master Commit: c2f0ae50b4dd70aa9d364ec6a7dd728e65370d8b URL: https://source.winehq.org/git/wine.git/?a=commit;h=c2f0ae50b4dd70aa9d364ec6… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Mon Sep 23 15:12:16 2019 +0330 wined3d: Use explicit flushing in wined3d_context_gl_unmap_bo_address(). Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wined3d/adapter_gl.c | 6 +++--- dlls/wined3d/adapter_vk.c | 4 ++-- dlls/wined3d/context.c | 25 +++++++++++++++++++------ dlls/wined3d/directx.c | 4 ++-- dlls/wined3d/surface.c | 19 ++++++++++++++----- dlls/wined3d/texture.c | 15 +++++++++++---- dlls/wined3d/wined3d_private.h | 26 ++++++++++++++------------ 7 files changed, 65 insertions(+), 34 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=c2f0ae50b4dd70aa9d36…

1 0

Francois Gouget : dxerr9: Fix the spelling of some error messages.
by Alexandre Julliard Sept. 23, 2019

Sept. 23, 2019

Module: wine Branch: master Commit: d5996ec1bee1a631c1cb8bfebf1a3fd7359ea445 URL: https://source.winehq.org/git/wine.git/?a=commit;h=d5996ec1bee1a631c1cb8bfe… Author: Francois Gouget <fgouget(a)free.fr> Date: Sun Sep 22 23:24:31 2019 +0200 dxerr9: Fix the spelling of some error messages. Signed-off-by: Francois Gouget <fgouget(a)free.fr> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/dxerr9/errors.dat | 4 ++-- dlls/dxerr9/errors.h | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/dlls/dxerr9/errors.dat b/dlls/dxerr9/errors.dat index f8c6a95ce8..fcea0da47a 100644 --- a/dlls/dxerr9/errors.dat +++ b/dlls/dxerr9/errors.dat @@ -281,7 +281,7 @@ DDERR_INVALIDPIXELFORMAT pixel format was invalid as specified DDERR_INVALIDRECT Rectangle provided was invalid. DDERR_LOCKEDSURFACES Operation could not be carried out because one or more surfaces are locked DDERR_NO3D There is no 3D present. -DDERR_NOALPHAHW Operation could not be carried out because there is no alpha accleration hardware present or available. +DDERR_NOALPHAHW Operation could not be carried out because there is no alpha acceleration hardware present or available. DDERR_NOSTEREOHARDWARE Operation could not be carried out because there is no stereo hardware present or available. DDERR_NOSURFACELEFT Operation could not be carried out because there is no hardware present which supports stereo surfaces DDERR_NOCLIPLIST no clip list available @@ -348,7 +348,7 @@ DDERR_NOBLTHW No blter. DDERR_NODDROPSHW No DirectDraw ROP hardware. DDERR_OVERLAYNOTVISIBLE returned when GetOverlayPosition is called on a hidden overlay DDERR_NOOVERLAYDEST returned when GetOverlayPosition is called on an overlay that UpdateOverlay has never been called on to establish a destination. -DDERR_INVALIDPOSITION returned when the position of the overlay on the destination is no longer legal for that destionation. +DDERR_INVALIDPOSITION returned when the position of the overlay on the destination is no longer legal for that destination. DDERR_NOTAOVERLAYSURFACE returned when an overlay member is called for a non-overlay surface DDERR_EXCLUSIVEMODEALREADYSET An attempt was made to set the cooperative level when it was already set to exclusive. DDERR_NOTFLIPPABLE An attempt has been made to flip a surface that is not flippable. diff --git a/dlls/dxerr9/errors.h b/dlls/dxerr9/errors.h index 1c52be9219..84e1d8611a 100644 --- a/dlls/dxerr9/errors.h +++ b/dlls/dxerr9/errors.h @@ -850,8 +850,8 @@ static const WCHAR name283W[] = { 'D','D','E','R','R','_','N','O','3','D',0 }; static const CHAR description283A[] = "There is no 3D present."; static const WCHAR description283W[] = { 'T','h','e','r','e',' ','i','s',' ','n','o',' ','3','D',' ','p','r','e','s','e','n','t','.',0 }; static const WCHAR name284W[] = { 'D','D','E','R','R','_','N','O','A','L','P','H','A','H','W',0 }; -static const CHAR description284A[] = "Operation could not be carried out because there is no alpha accleration hardware present or available."; -static const WCHAR description284W[] = { 'O','p','e','r','a','t','i','o','n',' ','c','o','u','l','d',' ','n','o','t',' ','b','e',' ','c','a','r','r','i','e','d',' ','o','u','t',' ','b','e','c','a','u','s','e',' ','t','h','e','r','e',' ','i','s',' ','n','o',' ','a','l','p','h','a',' ','a','c','c','l','e','r','a','t','i','o','n',' ','h','a','r','d','w','a','r','e',' ','p','r','e','s','e','n','t',' ','o','r',' ','a','v','a','i','l','a','b','l','e','.',0 }; +static const CHAR description284A[] = "Operation could not be carried out because there is no alpha acceleration hardware present or available."; +static const WCHAR description284W[] = { 'O','p','e','r','a','t','i','o','n',' ','c','o','u','l','d',' ','n','o','t',' ','b','e',' ','c','a','r','r','i','e','d',' ','o','u','t',' ','b','e','c','a','u','s','e',' ','t','h','e','r','e',' ','i','s',' ','n','o',' ','a','l','p','h','a',' ','a','c','c','e','l','e','r','a','t','i','o','n',' ','h','a','r','d','w','a','r','e',' ','p','r','e','s','e','n','t',' ','o','r',' ','a','v','a','i','l','a','b','l','e','.',0 }; static const WCHAR name285W[] = { 'D','D','E','R','R','_','N','O','S','T','E','R','E','O','H','A','R','D','W','A','R','E',0 }; static const CHAR description285A[] = "Operation could not be carried out because there is no stereo hardware present or available."; static const WCHAR description285W[] = { 'O','p','e','r','a','t','i','o','n',' ','c','o','u','l','d',' ','n','o','t',' ','b','e',' ','c','a','r','r','i','e','d',' ','o','u','t',' ','b','e','c','a','u','s','e',' ','t','h','e','r','e',' ','i','s',' ','n','o',' ','s','t','e','r','e','o',' ','h','a','r','d','w','a','r','e',' ','p','r','e','s','e','n','t',' ','o','r',' ','a','v','a','i','l','a','b','l','e','.',0 }; @@ -1049,10 +1049,10 @@ static const CHAR description349A[] = "returned when GetOverlayPosition is calle static const WCHAR description349W[] = { 'r','e','t','u','r','n','e','d',' ','w','h','e','n',' ','G','e','t','O','v','e','r','l','a','y','P','o','s','i','t','i','o','n',' ','i','s',' ','c','a','l','l','e','d',' ','o','n',' ','a',' ','h','i','d','d','e','n',' ','o','v','e','r','l','a','y',0 }; static const WCHAR name350W[] = { 'D','D','E','R','R','_','N','O','O','V','E','R','L','A','Y','D','E','S','T',0 }; static const CHAR description350A[] = "returned when GetOverlayPosition is called on an overlay that UpdateOverlay has never been called on to establish a destination."; -static const WCHAR description350W[] = { 'r','e','t','u','r','n','e','d',' ','w','h','e','n',' ','G','e','t','O','v','e','r','l','a','y','P','o','s','i','t','i','o','n',' ','i','s',' ','c','a','l','l','e','d',' ','o','n',' ','a',' ','o','v','e','r','l','a','y',' ','t','h','a','t',' ','U','p','d','a','t','e','O','v','e','r','l','a','y',' ','h','a','s',' ','n','e','v','e','r',' ','b','e','e','n',' ','c','a','l','l','e','d',' ','o','n',' ','t','o',' ','e','s','t','a','b','l','i','s','h',' ','a',' ','d','e','s','t','i','o','n','a','t','i','o','n','.',0 }; +static const WCHAR description350W[] = { 'r','e','t','u','r','n','e','d',' ','w','h','e','n',' ','G','e','t','O','v','e','r','l','a','y','P','o','s','i','t','i','o','n',' ','i','s',' ','c','a','l','l','e','d',' ','o','n',' ','a',' ','o','v','e','r','l','a','y',' ','t','h','a','t',' ','U','p','d','a','t','e','O','v','e','r','l','a','y',' ','h','a','s',' ','n','e','v','e','r',' ','b','e','e','n',' ','c','a','l','l','e','d',' ','o','n',' ','t','o',' ','e','s','t','a','b','l','i','s','h',' ','a',' ','d','e','s','t','i','n','a','t','i','o','n','.',0 }; static const WCHAR name351W[] = { 'D','D','E','R','R','_','I','N','V','A','L','I','D','P','O','S','I','T','I','O','N',0 }; static const CHAR description351A[] = "returned when the position of the overlay on the destination is no longer legal for that destination."; -static const WCHAR description351W[] = { 'r','e','t','u','r','n','e','d',' ','w','h','e','n',' ','t','h','e',' ','p','o','s','i','t','i','o','n',' ','o','f',' ','t','h','e',' ','o','v','e','r','l','a','y',' ','o','n',' ','t','h','e',' ','d','e','s','t','i','o','n','a','t','i','o','n',' ','i','s',' ','n','o',' ','l','o','n','g','e','r',' ','l','e','g','a','l',' ','f','o','r',' ','t','h','a','t',' ','d','e','s','t','i','n','a','t','i','o','n','.',0 }; +static const WCHAR description351W[] = { 'r','e','t','u','r','n','e','d',' ','w','h','e','n',' ','t','h','e',' ','p','o','s','i','t','i','o','n',' ','o','f',' ','t','h','e',' ','o','v','e','r','l','a','y',' ','o','n',' ','t','h','e',' ','d','e','s','t','i','n','a','t','i','o','n',' ','i','s',' ','n','o',' ','l','o','n','g','e','r',' ','l','e','g','a','l',' ','f','o','r',' ','t','h','a','t',' ','d','e','s','t','i','n','a','t','i','o','n','.',0 }; static const WCHAR name352W[] = { 'D','D','E','R','R','_','N','O','T','A','O','V','E','R','L','A','Y','S','U','R','F','A','C','E',0 }; static const CHAR description352A[] = "returned when an overlay member is called for a non-overlay surface"; static const WCHAR description352W[] = { 'r','e','t','u','r','n','e','d',' ','w','h','e','n',' ','a','n',' ','o','v','e','r','l','a','y',' ','m','e','m','b','e','r',' ','i','s',' ','c','a','l','l','e','d',' ','f','o','r',' ','a',' ','n','o','n','-','o','v','e','r','l','a','y',' ','s','u','r','f','a','c','e',0 };

1 0

Francois Gouget : jscript/tests: Fix the spelling and slightly reword an ok() message.
by Alexandre Julliard Sept. 23, 2019

Sept. 23, 2019

Module: wine Branch: master Commit: a4a1ba5a2263858ed0dbb5a713b371a80a978726 URL: https://source.winehq.org/git/wine.git/?a=commit;h=a4a1ba5a2263858ed0dbb5a7… Author: Francois Gouget <fgouget(a)free.fr> Date: Sun Sep 22 23:21:19 2019 +0200 jscript/tests: Fix the spelling and slightly reword an ok() message. Signed-off-by: Francois Gouget <fgouget(a)free.fr> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/jscript/tests/lang.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/jscript/tests/lang.js b/dlls/jscript/tests/lang.js index 0fb63f4682..4812a066d1 100644 --- a/dlls/jscript/tests/lang.js +++ b/dlls/jscript/tests/lang.js @@ -1526,7 +1526,7 @@ deleteTest = 1; delete deleteTest; try { tmp = deleteTest; - ok(false, "deleteTest not throwed exception?"); + ok(false, "deleteTest did not throw an exception?"); }catch(ex) {} (function() {

1 0

Francois Gouget : testbot: Fix the VM::RecordResult() documentation.
by Alexandre Julliard Sept. 23, 2019

Sept. 23, 2019

Module: tools Branch: master Commit: f1ffd15cab379f632ce3c02e0b0d7b2e14b86638 URL: https://source.winehq.org/git/tools.git/?a=commit;h=f1ffd15cab379f632ce3c02… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Mon Sep 23 17:01:54 2019 +0200 testbot: Fix the VM::RecordResult() documentation. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- testbot/lib/WineTestBot/VMs.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/testbot/lib/WineTestBot/VMs.pm b/testbot/lib/WineTestBot/VMs.pm index d240fb9..37ebf9a 100644 --- a/testbot/lib/WineTestBot/VMs.pm +++ b/testbot/lib/WineTestBot/VMs.pm @@ -652,7 +652,7 @@ sub RecordStatus($$;$) =pod =over 12 -=item C<RecordStatus()> +=item C<RecordResult()> Adds a Record of the specified VM process result.

1 0

Francois Gouget : testbot: Requeue the task if the VM is not ready for it.
by Alexandre Julliard Sept. 23, 2019

Sept. 23, 2019

Module: tools Branch: master Commit: 89f32e99c754122a4075528803b6369ea4d82489 URL: https://source.winehq.org/git/tools.git/?a=commit;h=89f32e99c754122a4075528… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Mon Sep 23 16:59:31 2019 +0200 testbot: Requeue the task if the VM is not ready for it. In order to run a task a VM should be in the 'running' state and powered on. If either check fails that's not the fault of the task and a second attempt may succeed. So don't end the task with a boterror. Instead requeue it and put the VM offline so its true state is evaluated (and notify the administrator of course). This implies only resetting the VM error count after successfully running a task otherwise we could get into an infinite loop putting it offline at the start of every task. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- testbot/bin/LibvirtTool.pl | 1 - testbot/bin/WineRunBuild.pl | 32 ++++++++++++++++++++++--- testbot/bin/WineRunReconfig.pl | 37 ++++++++++++++++++++++++---- testbot/bin/WineRunTask.pl | 37 ++++++++++++++++++++++++---- testbot/bin/WineRunWineTest.pl | 41 +++++++++++++++++++++++++++----- testbot/lib/WineTestBot/LibvirtDomain.pm | 13 ++++++++++ 6 files changed, 143 insertions(+), 18 deletions(-) Diff: https://source.winehq.org/git/tools.git/?a=commitdiff;h=89f32e99c754122a407…

1 0

Francois Gouget : testbot/Engine: Let the caller trace VM::Run() errors.
by Alexandre Julliard Sept. 23, 2019

Sept. 23, 2019

Module: tools Branch: master Commit: c52a230ef658608dd68562a466bcc670caa6a241 URL: https://source.winehq.org/git/tools.git/?a=commit;h=c52a230ef658608dd68562a… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Mon Sep 23 19:21:57 2019 +0200 testbot/Engine: Let the caller trace VM::Run() errors. Libraries are not supposed to spam the log and most callers already trace VM::Run() errors. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- testbot/lib/WineTestBot/Engine/Scheduler.pm | 3 ++- testbot/lib/WineTestBot/VMs.pm | 5 +---- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/testbot/lib/WineTestBot/Engine/Scheduler.pm b/testbot/lib/WineTestBot/Engine/Scheduler.pm index 7375337..4128e9e 100644 --- a/testbot/lib/WineTestBot/Engine/Scheduler.pm +++ b/testbot/lib/WineTestBot/Engine/Scheduler.pm @@ -766,7 +766,8 @@ sub _SacrificeVM($$$) $Host->{dirty}++; $Victim->RecordStatus($Sched->{records}, $Victim->Status eq "dirty" ? "dirty poweroff" : "dirty sacrifice"); $Victim->KillChild(); - $Victim->RunPowerOff(); + my $ErrMessage = $Victim->RunPowerOff(); + LogMsg "$ErrMessage\n" if (defined $ErrMessage); return 1; } diff --git a/testbot/lib/WineTestBot/VMs.pm b/testbot/lib/WineTestBot/VMs.pm index d85df1d..d240fb9 100644 --- a/testbot/lib/WineTestBot/VMs.pm +++ b/testbot/lib/WineTestBot/VMs.pm @@ -379,10 +379,7 @@ sub Run($$$$$$) if (defined $self->ChildPid) { - my $ErrMessage = "Cannot run ". ShArgv2Cmd(@$Args) ." because the ". $self->ChildPid ." process is already using the ". $self->Name ." VM"; - require WineTestBot::Log; - WineTestBot::Log::LogMsg("$ErrMessage\n"); - return $ErrMessage; + return "Cannot run ". ShArgv2Cmd(@$Args) ." because process ". $self->ChildPid ." is already using the ". $self->Name ." VM"; } # There are two $VM->ChildPid race conditions to avoid:

1 0

Francois Gouget : testbot/Engine: Fix recording the new sacrificed VM status.
by Alexandre Julliard Sept. 23, 2019

Sept. 23, 2019

Module: tools Branch: master Commit: d1075ec8f78e9e4e928b4f7cceb15ead53b3a9ed URL: https://source.winehq.org/git/tools.git/?a=commit;h=d1075ec8f78e9e4e928b4f7… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Mon Sep 23 19:22:00 2019 +0200 testbot/Engine: Fix recording the new sacrificed VM status. The status will not be 'dirty' if VM::RunPowerOff() failed. Recording the right status is important otherwise ScheduleJobs() will attempt to record de VM's current status in its catch-all loop, resulting in a fatal 'Could not change key' error. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- testbot/lib/WineTestBot/Engine/Scheduler.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/testbot/lib/WineTestBot/Engine/Scheduler.pm b/testbot/lib/WineTestBot/Engine/Scheduler.pm index 4128e9e..530a2ee 100644 --- a/testbot/lib/WineTestBot/Engine/Scheduler.pm +++ b/testbot/lib/WineTestBot/Engine/Scheduler.pm @@ -764,10 +764,10 @@ sub _SacrificeVM($$$) $Sched->{busyvms}->{$VictimKey} = 1; $Host->{$Victim->Status}--; $Host->{dirty}++; - $Victim->RecordStatus($Sched->{records}, $Victim->Status eq "dirty" ? "dirty poweroff" : "dirty sacrifice"); $Victim->KillChild(); my $ErrMessage = $Victim->RunPowerOff(); LogMsg "$ErrMessage\n" if (defined $ErrMessage); + $Victim->RecordStatus($Sched->{records}, $Victim->Status eq "dirty" ? "dirty poweroff" : $VM->Status ." sacrifice"); return 1; }

1 0

Francois Gouget : testbot/LibvirtTool: Remove _GetStateName(), it is not used anymore.
by Alexandre Julliard Sept. 23, 2019

Sept. 23, 2019

Module: tools Branch: master Commit: 509752b6e6f5eed17eb72b45076dd8427c84ceb8 URL: https://source.winehq.org/git/tools.git/?a=commit;h=509752b6e6f5eed17eb72b4… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Mon Sep 23 16:59:20 2019 +0200 testbot/LibvirtTool: Remove _GetStateName(), it is not used anymore. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- testbot/lib/WineTestBot/LibvirtDomain.pm | 17 ----------------- 1 file changed, 17 deletions(-) diff --git a/testbot/lib/WineTestBot/LibvirtDomain.pm b/testbot/lib/WineTestBot/LibvirtDomain.pm index bb68bd0..7f462ea 100644 --- a/testbot/lib/WineTestBot/LibvirtDomain.pm +++ b/testbot/lib/WineTestBot/LibvirtDomain.pm @@ -393,23 +393,6 @@ sub IsReady($) ); } -sub _GetStateName($) -{ - my ($State) = @_; - - my %StateNames = ( - Sys::Virt::Domain::STATE_NOSTATE => "no state", - Sys::Virt::Domain::STATE_RUNNING => "running", - Sys::Virt::Domain::STATE_BLOCKED => "blocked", - Sys::Virt::Domain::STATE_PAUSED => "paused", - Sys::Virt::Domain::STATE_SHUTDOWN => "shutdown", - Sys::Virt::Domain::STATE_SHUTOFF => "shutoff", - Sys::Virt::Domain::STATE_CRASHED => "crashed", - Sys::Virt::Domain::STATE_PMSUSPENDED => "pmsuspended", - ); - return $StateNames{$State} || "unknown"; -} - sub PowerOff($) { my ($self) = @_;

1 0