September 2019 - Wine-Commits

Francois Gouget : testbot/VMs: Make sure only one process uses a VM at a time.
by Alexandre Julliard Sept. 12, 2019

Sept. 12, 2019

Module: tools Branch: master Commit: c0c486a133f12a95af29a759692a38988ed123b7 URL: https://source.winehq.org/git/tools.git/?a=commit;h=c0c486a133f12a95af29a75… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Wed Sep 11 17:02:37 2019 +0200 testbot/VMs: Make sure only one process uses a VM at a time. The TestBot should already be respecting that rule. But starting a process to operate on a VM always goes through VM::Run() so enforce this rule by checking that the VM's ChildPid field is not already set before starting a new process. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- testbot/lib/WineTestBot/VMs.pm | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/testbot/lib/WineTestBot/VMs.pm b/testbot/lib/WineTestBot/VMs.pm index 78e066f..2bf3504 100644 --- a/testbot/lib/WineTestBot/VMs.pm +++ b/testbot/lib/WineTestBot/VMs.pm @@ -154,6 +154,7 @@ use WineTestBot::LibvirtDomain; use WineTestBot::Missions; use WineTestBot::RecordGroups; use WineTestBot::TestAgent; +use WineTestBot::Utils; sub _initialize($$) @@ -374,9 +375,16 @@ sub OnSaved($) sub Run($$$$$$) { my ($self, $NewStatus, $Args, $ChildTimeout, $ChildSetup, $SetupData) = @_; - my $Tool = basename($Args->[0]); + if (defined $self->ChildPid) + { + my $ErrMessage = "Cannot run ". ShArgv2Cmd(@$Args) ." because the ". $self->ChildPid ." process is already using the ". $self->Name ." VM"; + require WineTestBot::Log; + WineTestBot::Log::LogMsg("$ErrMessage\n"); + return $ErrMessage; + } + # There are two $VM->ChildPid race conditions to avoid: # - Between the child process and new calls to ScheduleJobs(). # We cannot leave setting ChildPid to the child process because then it

1 0

Francois Gouget : testbot/reporttest: Add coverage for subtests.
by Alexandre Julliard Sept. 12, 2019

Sept. 12, 2019

Module: tools Branch: master Commit: bc12f450f633625b58b9fd7b4c79a1acdba132ac URL: https://source.winehq.org/git/tools.git/?a=commit;h=bc12f450f633625b58b9fd7… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Thu Sep 12 11:18:05 2019 +0200 testbot/reporttest: Add coverage for subtests. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- testbot/src/reporttest/report.template | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/testbot/src/reporttest/report.template b/testbot/src/reporttest/report.template index 2d074f9..00b6c2b 100644 --- a/testbot/src/reporttest/report.template +++ b/testbot/src/reporttest/report.template @@ -557,7 +557,17 @@ comctl32:tooltips start dlls/comctl32/tests/toolbar.c - ----- Expected assessement: crashed comctl32:tooltips done (3221225477) in 0s -stub comctl32:trackbar +comctl32:trackbar start dlls/comctl32/tests/trackbar.c - +----- A unit test with a subtest +trackbar.c:496: Subtest driver +driver.c:40: Test failed: Something wrong +driver.c:41: Test succeeded inside todo block: Something right! +driver.c:42: Test marked todo: Hello Wine! +driver.c:43: Tests skipped: Another time +----- Expected assessement: 2 failures, 1 todo, 1 skip +07b1:trackbar: 3 tests executed (1 marked as todo, 2 failures), 1 skipped. +comctl32:trackbar:07b1 done (2) in 0s + stub comctl32:treeview stub comctl32:updown stub comdlg32:filedlg

1 0

Alexandre Julliard : Update Józef's picture.
by Alexandre Julliard Sept. 12, 2019

Sept. 12, 2019

Module: website Branch: master Commit: 5ebb89ee8402e10664dbe60d4011c21d4ba89211 URL: https://source.winehq.org/git/website.git/?a=commit;h=5ebb89ee8402e10664dbe… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Thu Sep 12 19:05:50 2019 +0200 Update Józef's picture. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- "images/Jo\314\201zef-Kucia.png" | Bin 478739 -> 982965 bytes 1 file changed, 0 insertions(+), 0 deletions(-) diff --git "a/images/Jo\314\201zef-Kucia.png" "b/images/Jo\314\201zef-Kucia.png" index 749e07a7..ba402a7a 100644 Binary files "a/images/Jo\314\201zef-Kucia.png" and "b/images/Jo\314\201zef-Kucia.png" differ

1 0

Alistair Leslie-Hughes : include: Correct DSFX_I3DL2REVERB_ROOM_MIN value.
by Alexandre Julliard Sept. 11, 2019

Sept. 11, 2019

Module: wine Branch: master Commit: 332dc23f36f4b5f61f7f177a07619570af1bb0b5 URL: https://source.winehq.org/git/wine.git/?a=commit;h=332dc23f36f4b5f61f7f177a… Author: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Date: Wed Sep 11 00:42:42 2019 +0000 include: Correct DSFX_I3DL2REVERB_ROOM_MIN value. Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- include/dsound.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/dsound.h b/include/dsound.h index 74b4bcdb4a..b4a2509e89 100644 --- a/include/dsound.h +++ b/include/dsound.h @@ -491,7 +491,7 @@ typedef struct _DSFXI3DL2Reverb #define DSFX_I3DL2REVERB_REVERBDELAY_MAX 0.1f #define DSFX_I3DL2REVERB_REVERBDELAY_DEFAULT 0.011f #define DSFX_I3DL2REVERB_ROOM_DEFAULT (-1000) -#define DSFX_I3DL2REVERB_ROOM_MIN 10000 +#define DSFX_I3DL2REVERB_ROOM_MIN (-10000) #define DSFX_I3DL2REVERB_ROOM_MAX 0 #define DSFX_I3DL2REVERB_ROOMHF_MIN (-10000) #define DSFX_I3DL2REVERB_ROOMHF_MAX 0

1 0

Sven Baars : winex11.drv: Fix a memory leak (Coverity).
by Alexandre Julliard Sept. 11, 2019

Sept. 11, 2019

Module: wine Branch: master Commit: 6033b3a7fbc29bc911b0173499b288ce7f226a4a URL: https://source.winehq.org/git/wine.git/?a=commit;h=6033b3a7fbc29bc911b01734… Author: Sven Baars <sven.wine(a)gmail.com> Date: Fri Sep 6 22:24:11 2019 +0200 winex11.drv: Fix a memory leak (Coverity). Signed-off-by: Sven Baars <sven.wine(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/winex11.drv/clipboard.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/dlls/winex11.drv/clipboard.c b/dlls/winex11.drv/clipboard.c index a37530fdbf..c51954f1bf 100644 --- a/dlls/winex11.drv/clipboard.c +++ b/dlls/winex11.drv/clipboard.c @@ -1849,13 +1849,12 @@ static BOOL request_selection_contents( Display *display, BOOL changed ) last_size != size || memcmp( last_data, data, size )); - if (!changed) + if (!changed || !OpenClipboard( clipboard_hwnd )) { HeapFree( GetProcessHeap(), 0, data ); return FALSE; } - if (!OpenClipboard( clipboard_hwnd )) return FALSE; TRACE( "selection changed, importing\n" ); EmptyClipboard(); is_clipboard_owner = TRUE;

1 0

Zhiyi Zhang : user32/tests: Fix some msg test failures.
by Alexandre Julliard Sept. 11, 2019

Sept. 11, 2019

Module: wine Branch: master Commit: a3948047dde36ca6250557119e468a8b662b73e6 URL: https://source.winehq.org/git/wine.git/?a=commit;h=a3948047dde36ca625055711… Author: Zhiyi Zhang <zzhang(a)codeweavers.com> Date: Wed Sep 11 20:54:36 2019 +0800 user32/tests: Fix some msg test failures. These test failures sometimes happen on some TestBots. Signed-off-by: Zhiyi Zhang <zzhang(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/user32/tests/msg.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/dlls/user32/tests/msg.c b/dlls/user32/tests/msg.c index a5bc1c5518..73beb4d771 100644 --- a/dlls/user32/tests/msg.c +++ b/dlls/user32/tests/msg.c @@ -567,6 +567,7 @@ static const struct message WmShowRestoreMaxOverlappedSeq[] = { { WM_GETTITLEBARINFOEX, sent|optional }, { WM_NCPAINT, sent|beginpaint|optional }, { WM_ERASEBKGND, sent|beginpaint|optional }, + { WM_SYNCPAINT, sent|optional }, { 0 } }; /* ShowWindow(SW_RESTORE) for a not visible minimized overlapped window */ @@ -837,6 +838,7 @@ static const struct message WmShowMaxPopupSeq[] = { { WM_ERASEBKGND, sent|defwinproc|optional }, { WM_WINDOWPOSCHANGED, sent|wparam, SWP_NOCLIENTSIZE|SWP_NOCLIENTMOVE|SWP_SHOWWINDOW|SWP_FRAMECHANGED|SWP_NOMOVE|SWP_NOSIZE }, { EVENT_OBJECT_LOCATIONCHANGE, winevent_hook|wparam|lparam, 0, 0 }, + { WM_SIZE, sent|defwinproc|optional }, { 0 } }; /* CreateWindow(WS_VISIBLE) for popup window */ @@ -3477,6 +3479,7 @@ static const struct message WmMaximizeMDIchildInvisibleSeq2[] = { { WM_MDIACTIVATE, sent|defwinproc|optional }, { WM_WINDOWPOSCHANGED, sent|wparam, SWP_SHOWWINDOW|SWP_FRAMECHANGED|SWP_NOSIZE|SWP_NOMOVE|SWP_NOCLIENTSIZE|SWP_NOCLIENTMOVE }, { EVENT_OBJECT_LOCATIONCHANGE, winevent_hook|wparam|lparam, 0, 0 }, /* MDI child */ + { WM_SIZE, sent|defwinproc|optional }, { 0 } }; /* WM_MDIMAXIMIZE for an MDI child window with invisible parent */ @@ -13613,6 +13616,8 @@ static const struct message WmCreateDialogParamSeq_3[] = { { WM_QUERYNEWPALETTE, sent|parent|optional }, /* TODO: this message should not be sent */ { WM_WINDOWPOSCHANGING, sent|parent|wparam|optional, SWP_NOSIZE|SWP_NOMOVE }, { WM_WINDOWPOSCHANGING, sent|parent|wparam|optional, SWP_NOSIZE|SWP_NOMOVE }, + { WM_WINDOWPOSCHANGED, sent|parent|wparam|optional, SWP_NOREDRAW|SWP_NOSIZE|SWP_NOMOVE|SWP_NOCLIENTSIZE|SWP_NOCLIENTMOVE }, + { WM_WINDOWPOSCHANGED, sent|parent|wparam|optional, SWP_NOREDRAW|SWP_NOSIZE|SWP_NOMOVE|SWP_NOCLIENTSIZE|SWP_NOCLIENTMOVE }, { WM_ACTIVATEAPP, sent|parent|wparam, 1 }, { WM_NCACTIVATE, sent|parent }, { WM_ACTIVATE, sent|parent|wparam, 1 }, @@ -16541,16 +16546,16 @@ static void test_hotkey(void) SetLastError(0xdeadbeef); ret = UnregisterHotKey(NULL, 0); - ok(ret == FALSE, "expected FALSE, got %i\n", ret); - ok(GetLastError() == ERROR_HOTKEY_NOT_REGISTERED || broken(GetLastError() == 0xdeadbeef), - "unexpected error %d\n", GetLastError()); - if (ret == TRUE) { skip("hotkeys not supported\n"); return; } + ok(ret == FALSE, "expected FALSE, got %i\n", ret); + ok(GetLastError() == ERROR_HOTKEY_NOT_REGISTERED || broken(GetLastError() == 0xdeadbeef), + "unexpected error %d\n", GetLastError()); + test_window = CreateWindowExA(0, "HotkeyWindowClass", NULL, WS_OVERLAPPEDWINDOW | WS_VISIBLE, 100, 100, 200, 200, 0, 0, 0, NULL);

1 0

Andrew Eikum : winebus.sys: Don't WARN about backends we didn't build.
by Alexandre Julliard Sept. 11, 2019

Sept. 11, 2019

Module: wine Branch: master Commit: 439b80e4c43393fdab71cd5826c7c59bbe038529 URL: https://source.winehq.org/git/wine.git/?a=commit;h=439b80e4c43393fdab71cd58… Author: Andrew Eikum <aeikum(a)codeweavers.com> Date: Wed Sep 11 09:25:38 2019 -0500 winebus.sys: Don't WARN about backends we didn't build. Signed-off-by: Andrew Eikum <aeikum(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/winebus.sys/bus_iohid.c | 2 +- dlls/winebus.sys/bus_sdl.c | 5 ++++- dlls/winebus.sys/bus_udev.c | 1 - 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/dlls/winebus.sys/bus_iohid.c b/dlls/winebus.sys/bus_iohid.c index 7933374007..cda77e3011 100644 --- a/dlls/winebus.sys/bus_iohid.c +++ b/dlls/winebus.sys/bus_iohid.c @@ -409,6 +409,7 @@ NTSTATUS iohid_driver_init(void) return STATUS_UNSUCCESSFUL; } + TRACE("Initialization successful\n"); return STATUS_SUCCESS; } @@ -429,7 +430,6 @@ void iohid_driver_unload( void ) NTSTATUS iohid_driver_init(void) { - WARN("IOHID Support not compiled into Wine.\n"); return STATUS_NOT_IMPLEMENTED; } diff --git a/dlls/winebus.sys/bus_sdl.c b/dlls/winebus.sys/bus_sdl.c index d24e21cff8..d3a1a19eeb 100644 --- a/dlls/winebus.sys/bus_sdl.c +++ b/dlls/winebus.sys/bus_sdl.c @@ -1145,9 +1145,13 @@ NTSTATUS sdl_driver_init(void) map_controllers = check_bus_option(&controller_mode, 1); if (!(events[0] = CreateEventW(NULL, TRUE, FALSE, NULL))) + { + WARN("CreateEvent failed\n"); return STATUS_UNSUCCESSFUL; + } if (!(events[1] = CreateThread(NULL, 0, deviceloop_thread, events[0], 0, NULL))) { + WARN("CreateThread failed\n"); CloseHandle(events[0]); return STATUS_UNSUCCESSFUL; } @@ -1171,7 +1175,6 @@ sym_not_found: NTSTATUS sdl_driver_init(void) { - WARN("compiled without SDL support\n"); return STATUS_NOT_IMPLEMENTED; } diff --git a/dlls/winebus.sys/bus_udev.c b/dlls/winebus.sys/bus_udev.c index d9311a9b03..20841b09ae 100644 --- a/dlls/winebus.sys/bus_udev.c +++ b/dlls/winebus.sys/bus_udev.c @@ -1529,7 +1529,6 @@ error: NTSTATUS udev_driver_init(void) { - WARN("Wine was compiled without UDEV support\n"); return STATUS_NOT_IMPLEMENTED; }

1 0

Michael Stefaniuc : Remembering Józef Kucia.
by Alexandre Julliard Sept. 11, 2019

Sept. 11, 2019

Module: website Branch: master Commit: 8c648483ed1e8ff8d8bc1e2adfb02b27182210c3 URL: https://source.winehq.org/git/website.git/?a=commit;h=8c648483ed1e8ff8d8bc1… Author: Michael Stefaniuc <mstefani(a)winehq.org> Date: Wed Sep 11 22:29:01 2019 +0200 Remembering Józef Kucia. Signed-off-by: Michael Stefaniuc <mstefani(a)winehq.org> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- "images/Jo\314\201zef-Kucia.png" | Bin 0 -> 478739 bytes news/en/2019091101.xml | 26 ++++++++++++++++++++++++++ 2 files changed, 26 insertions(+) diff --git "a/images/Jo\314\201zef-Kucia.png" "b/images/Jo\314\201zef-Kucia.png" new file mode 100644 index 00000000..749e07a7 Binary files /dev/null and "b/images/Jo\314\201zef-Kucia.png" differ diff --git a/news/en/2019091101.xml b/news/en/2019091101.xml new file mode 100644 index 00000000..71861001 --- /dev/null +++ b/news/en/2019091101.xml @@ -0,0 +1,26 @@ +<news> +<date>September 11, 2019</date> +<title>Remembering Józef Kucia</title> +<body> +<a href="{$root}/images/Józef-Kucia.png"><img src="{$root}/images/Józef-Kucia.png" + style="margin: 0 20px 20px 0;"/></a> + With great sadness we are announcing the passing of our friend, Józef Kucia. + Józef was a major Wine contributor with over 2500 patches since his first +contribution in 2012. He was a highly talented programmer with a focus on Wine's +Direct3D subsystem. Józef founded and led the vkd3d project and provided insight +and guidance to the Vulkan working group. He also contributed to other open +source projects including Mesa and Debian. + Józef was a regular attendee at the yearly WineConf. A man of few +words, he was helpful and displayed a quiet kindness. His skills +attracted the interest of CodeWeavers and Józef <a +href="https://www.codeweavers.com/about/blogs/jwhite/2019/09/08/a-tragic-loss">joined +their team</a> in 2015. That allowed him to dedicate more of his time +to Wine. + Józef died last month at the young age of 28 in an accident in the Jaskinia +Wielka Śnieżna ("great snowy cave") in the Tatra Mountains in Poland. Caving was +his passion. + + Józef will be remembered with warm memories by those who worked with him. +Our thoughts and condolences go out to Józef's family, friends, loved ones, and +everyone else who grieves his passing. +</body></news>

1 0

Hans Leidekker : wbemprox: Add support for evaluating ASSOCIATORS OF queries.
by Alexandre Julliard Sept. 10, 2019

Sept. 10, 2019

Module: wine Branch: master Commit: 8487265f81a2824ae26485db3b7525c3984efca6 URL: https://source.winehq.org/git/wine.git/?a=commit;h=8487265f81a2824ae26485db… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Tue Sep 10 17:09:14 2019 +0200 wbemprox: Add support for evaluating ASSOCIATORS OF queries. Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wbemprox/builtin.c | 40 ++- dlls/wbemprox/class.c | 36 +-- dlls/wbemprox/query.c | 509 +++++++++++++++++++++++++++++++-------- dlls/wbemprox/services.c | 21 +- dlls/wbemprox/wbemprox_private.h | 36 ++- dlls/wbemprox/wql.y | 10 +- 6 files changed, 496 insertions(+), 156 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=8487265f81a2824ae264…

1 0

Kevin Puetz : objbase.h: Fix StringFromIID declaration.
by Alexandre Julliard Sept. 10, 2019

Sept. 10, 2019

Module: wine Branch: master Commit: ca455c53765a360b66e8cc079af69f0e709c8655 URL: https://source.winehq.org/git/wine.git/?a=commit;h=ca455c53765a360b66e8cc07… Author: Kevin Puetz <PuetzKevinA(a)JohnDeere.com> Date: Tue Sep 10 13:50:45 2019 +0200 objbase.h: Fix StringFromIID declaration. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- include/objbase.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/objbase.h b/include/objbase.h index 8af7a80b78..a241b71199 100644 --- a/include/objbase.h +++ b/include/objbase.h @@ -402,7 +402,7 @@ HRESULT WINAPI CLSIDFromProgID(LPCOLESTR progid, LPCLSID riid); HRESULT WINAPI ProgIDFromCLSID(REFCLSID clsid, LPOLESTR *lplpszProgID); INT WINAPI StringFromGUID2(REFGUID id, LPOLESTR str, INT cmax); HRESULT WINAPI IIDFromString(LPCOLESTR str, IID *iid); -HRESULT WINAPI StringFromIID(REFIID riid, LPOLESTR str); +HRESULT WINAPI StringFromIID(REFIID riid, LPOLESTR*); /***************************************************************************** * COM Server dll - exports

1 0