November 2020 - Wine-Commits

Huw Davies : riched20: Pass paragraph ptrs to the para marking function.
by Alexandre Julliard Nov. 4, 2020

Nov. 4, 2020

Module: wine Branch: master Commit: eb6b188a94054dbe5aaacde35d175c6ef26653cb URL: https://source.winehq.org/git/wine.git/?a=commit;h=eb6b188a94054dbe5aaacde3… Author: Huw Davies <huw(a)codeweavers.com> Date: Wed Nov 4 06:56:26 2020 +0000 riched20: Pass paragraph ptrs to the para marking function. Signed-off-by: Huw Davies <huw(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/riched20/editor.c | 4 ++-- dlls/riched20/editor.h | 2 +- dlls/riched20/paint.c | 2 +- dlls/riched20/para.c | 16 ++++++++-------- dlls/riched20/style.c | 2 +- 5 files changed, 13 insertions(+), 13 deletions(-) diff --git a/dlls/riched20/editor.c b/dlls/riched20/editor.c index 41906d28e4c..b27bab48738 100644 --- a/dlls/riched20/editor.c +++ b/dlls/riched20/editor.c @@ -4126,7 +4126,7 @@ LRESULT ME_HandleMessage(ME_TextEditor *editor, UINT msg, WPARAM wParam, ME_SetDefaultCharFormat(editor, &fmt); ME_CommitUndo(editor); - ME_MarkAllForWrapping(editor); + editor_mark_rewrap_all( editor ); ME_WrapMarkedParagraphs(editor); ME_UpdateScrollBar(editor); if (bRepaint) @@ -4771,7 +4771,7 @@ LRESULT ME_HandleMessage(ME_TextEditor *editor, UINT msg, WPARAM wParam, ME_SetDefaultFormatRect(editor); editor->bDefaultFormatRect = TRUE; } - ME_MarkAllForWrapping(editor); + editor_mark_rewrap_all( editor ); ME_WrapMarkedParagraphs(editor); ME_UpdateScrollBar(editor); if (msg != EM_SETRECTNP) diff --git a/dlls/riched20/editor.h b/dlls/riched20/editor.h index 05a6a7ee37f..24e750be1de 100644 --- a/dlls/riched20/editor.h +++ b/dlls/riched20/editor.h @@ -204,13 +204,13 @@ void ME_SendRequestResize(ME_TextEditor *editor, BOOL force) DECLSPEC_HIDDEN; /* para.c */ void editor_get_selection_paras(ME_TextEditor *editor, ME_Paragraph **para, ME_Paragraph **para_end ) DECLSPEC_HIDDEN; void editor_get_selection_para_fmt( ME_TextEditor *editor, PARAFORMAT2 *fmt ) DECLSPEC_HIDDEN; +void editor_mark_rewrap_all( ME_TextEditor *editor ) DECLSPEC_HIDDEN; void editor_set_default_para_fmt(ME_TextEditor *editor, PARAFORMAT2 *pFmt) DECLSPEC_HIDDEN; BOOL editor_set_selection_para_fmt( ME_TextEditor *editor, const PARAFORMAT2 *fmt ) DECLSPEC_HIDDEN; ME_DisplayItem *ME_GetParagraph(ME_DisplayItem *run) DECLSPEC_HIDDEN; void ME_MakeFirstParagraph(ME_TextEditor *editor) DECLSPEC_HIDDEN; void ME_DumpParaStyle(ME_Paragraph *s) DECLSPEC_HIDDEN; void ME_DumpParaStyleToBuf(const PARAFORMAT2 *pFmt, char buf[2048]) DECLSPEC_HIDDEN; -void ME_MarkAllForWrapping(ME_TextEditor *editor) DECLSPEC_HIDDEN; int get_total_width(ME_TextEditor *editor) DECLSPEC_HIDDEN; ME_Cell *para_cell( ME_Paragraph *para ) DECLSPEC_HIDDEN; void para_destroy( ME_TextEditor *editor, ME_Paragraph *item ) DECLSPEC_HIDDEN; diff --git a/dlls/riched20/paint.c b/dlls/riched20/paint.c index d15c47b72aa..6228c760295 100644 --- a/dlls/riched20/paint.c +++ b/dlls/riched20/paint.c @@ -138,7 +138,7 @@ ME_RewrapRepaint(ME_TextEditor *editor) /* RewrapRepaint should be called whenever the control has changed in * looks, but not content. Like resizing. */ - ME_MarkAllForWrapping(editor); + editor_mark_rewrap_all( editor ); ME_WrapMarkedParagraphs(editor); ME_UpdateScrollBar(editor); ME_Repaint(editor); diff --git a/dlls/riched20/para.c b/dlls/riched20/para.c index 4348530bbdb..e7c3c6934b9 100644 --- a/dlls/riched20/para.c +++ b/dlls/riched20/para.c @@ -225,18 +225,18 @@ void ME_MakeFirstParagraph(ME_TextEditor *editor) ME_DestroyContext(&c); } -static void ME_MarkForWrapping(ME_TextEditor *editor, ME_DisplayItem *first, const ME_DisplayItem *last) +static void para_mark_rewrap_paras( ME_TextEditor *editor, ME_Paragraph *first, const ME_Paragraph *end ) { - while(first != last) - { - para_mark_rewrap( editor, &first->member.para ); - first = first->member.para.next_para; - } + while (first != end) + { + para_mark_rewrap( editor, first ); + first = para_next( first ); + } } -void ME_MarkAllForWrapping(ME_TextEditor *editor) +void editor_mark_rewrap_all( ME_TextEditor *editor ) { - ME_MarkForWrapping(editor, editor->pBuffer->pFirst->member.para.next_para, editor->pBuffer->pLast); + para_mark_rewrap_paras( editor, editor_first_para( editor ), editor_end_para( editor ) ); } static void table_update_flags( ME_Paragraph *para ) diff --git a/dlls/riched20/style.c b/dlls/riched20/style.c index fbbe29dce14..95d3d3b6b29 100644 --- a/dlls/riched20/style.c +++ b/dlls/riched20/style.c @@ -536,5 +536,5 @@ void ME_SetDefaultCharFormat(ME_TextEditor *editor, CHARFORMAT2W *mod) } ScriptFreeCache( &def->script_cache ); ME_ReleaseStyle( style ); - ME_MarkAllForWrapping( editor ); + editor_mark_rewrap_all( editor ); }

1 0

Michael Stefaniuc : svchost: Use wide-char string literals.
by Alexandre Julliard Nov. 4, 2020

Nov. 4, 2020

Module: wine Branch: master Commit: 7ceb23ef7c13326ee777ba3f19fc0313585103ce URL: https://source.winehq.org/git/wine.git/?a=commit;h=7ceb23ef7c13326ee777ba3f… Author: Michael Stefaniuc <mstefani(a)winehq.org> Date: Tue Nov 3 23:34:38 2020 +0100 svchost: Use wide-char string literals. Signed-off-by: Michael Stefaniuc <mstefani(a)winehq.org> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- programs/svchost/svchost.c | 46 +++++++++++----------------------------------- 1 file changed, 11 insertions(+), 35 deletions(-) diff --git a/programs/svchost/svchost.c b/programs/svchost/svchost.c index 30c35616990..0daaa6ebf47 100644 --- a/programs/svchost/svchost.c +++ b/programs/svchost/svchost.c @@ -34,30 +34,8 @@ WINE_DEFAULT_DEBUG_CHANNEL(svchost); -/* Static strings used throughout svchost */ -static const WCHAR kd[] = {'-','k',0}; - -static const WCHAR ks[] = {'/','k',0}; - -static const WCHAR reg_separator[] = {'\\',0}; - -static const WCHAR service_reg_path[] = { - 'S','y','s','t','e','m', - '\\','C','u','r','r','e','n','t','C','o','n','t','r','o','l','S','e','t', - '\\','S','e','r','v','i','c','e','s',0}; - -static const WCHAR parameters[] = { - 'P','a','r','a','m','e','t','e','r','s',0}; - -static const WCHAR service_dll[] = { - 'S','e','r','v','i','c','e','D','l','l',0}; - -static const WCHAR svchost_path[] = { - 'S','o','f','t','w','a','r','e', - '\\','M','i','c','r','o','s','o','f','t', - '\\','W','i','n','d','o','w','s',' ','N','T', - '\\','C','u','r','r','e','n','t','V','e','r','s','i','o','n', - '\\','S','v','c','h','o','s','t',0}; +static const WCHAR service_reg_path[] = L"System\\CurrentControlSet\\Services"; +static const WCHAR svchost_path[] = L"Software\\Microsoft\\Windows NT\\CurrentVersion\\Svchost"; static const CHAR service_main[] = "ServiceMain"; @@ -145,15 +123,14 @@ static BOOL AddServiceElem(LPWSTR service_name, WINE_TRACE("Adding element for %s\n", wine_dbgstr_w(service_name)); /* Construct registry path to the service's parameters key */ - size = (lstrlenW(service_reg_path) + lstrlenW(reg_separator) + - lstrlenW(service_name) + lstrlenW(reg_separator) + - lstrlenW(parameters) + 1); + size = lstrlenW(service_reg_path) + lstrlenW(L"\\") + lstrlenW(service_name) + lstrlenW(L"\\") + + lstrlenW(L"Parameters") + 1; service_param_key = HeapAlloc(GetProcessHeap(), 0, size * sizeof(WCHAR)); lstrcpyW(service_param_key, service_reg_path); - lstrcatW(service_param_key, reg_separator); + lstrcatW(service_param_key, L"\\"); lstrcatW(service_param_key, service_name); - lstrcatW(service_param_key, reg_separator); - lstrcatW(service_param_key, parameters); + lstrcatW(service_param_key, L"\\"); + lstrcatW(service_param_key, L"Parameters"); service_param_key[size - 1] = '\0'; ret = RegOpenKeyExW(HKEY_LOCAL_MACHINE, service_param_key, 0, KEY_READ, &service_hkey); @@ -165,11 +142,11 @@ static BOOL AddServiceElem(LPWSTR service_name, } /* Find DLL associate with service from key */ - dll_name_short = GetRegValue(service_hkey, service_dll); + dll_name_short = GetRegValue(service_hkey, L"ServiceDll"); if (!dll_name_short) { - WINE_ERR("cannot find registry value %s for service %s\n", - wine_dbgstr_w(service_dll), wine_dbgstr_w(service_name)); + WINE_ERR("cannot find registry value ServiceDll for service %s\n", + wine_dbgstr_w(service_name)); RegCloseKey(service_hkey); goto cleanup; } @@ -340,8 +317,7 @@ int __cdecl wmain(int argc, WCHAR *argv[]) for (option_index = 1; option_index < argc; option_index++) { - if (lstrcmpiW(argv[option_index], ks) == 0 || - lstrcmpiW(argv[option_index], kd) == 0) + if (lstrcmpiW(argv[option_index], L"/k") == 0 || lstrcmpiW(argv[option_index], L"-k") == 0) { ++option_index; if (option_index >= argc)

1 0

Michael Stefaniuc : winedevice: Don't make a variable const just to cast the const away.
by Alexandre Julliard Nov. 4, 2020

Nov. 4, 2020

Module: wine Branch: master Commit: d0361560a62eeebad1c3368fdf4f1e8dde6f51c2 URL: https://source.winehq.org/git/wine.git/?a=commit;h=d0361560a62eeebad1c3368f… Author: Michael Stefaniuc <mstefani(a)winehq.org> Date: Tue Nov 3 23:34:36 2020 +0100 winedevice: Don't make a variable const just to cast the const away. Signed-off-by: Michael Stefaniuc <mstefani(a)winehq.org> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- programs/winedevice/device.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/programs/winedevice/device.c b/programs/winedevice/device.c index 0755caaafb0..7bada000520 100644 --- a/programs/winedevice/device.c +++ b/programs/winedevice/device.c @@ -41,7 +41,7 @@ static const WCHAR servicesW[] = {'\\','R','e','g','i','s','t','r','y', extern NTSTATUS CDECL wine_ntoskrnl_main_loop( HANDLE stop_event ); -static const WCHAR winedeviceW[] = {'w','i','n','e','d','e','v','i','c','e',0}; +static WCHAR winedeviceW[] = L"winedevice"; static SERVICE_STATUS_HANDLE service_handle; static SC_HANDLE manager_handle; static HANDLE stop_event; @@ -145,7 +145,7 @@ int __cdecl wmain( int argc, WCHAR *argv[] ) { SERVICE_TABLE_ENTRYW service_table[2]; - service_table[0].lpServiceName = (void *)winedeviceW; + service_table[0].lpServiceName = winedeviceW; service_table[0].lpServiceProc = ServiceMain; service_table[1].lpServiceName = NULL; service_table[1].lpServiceProc = NULL;

1 0

Aurimas Fišeras : po: Update Lithuanian translation.
by Alexandre Julliard Nov. 4, 2020

Nov. 4, 2020

Module: wine Branch: master Commit: dd7109136c28ae56998f96bc22c519b5cdb9534c URL: https://source.winehq.org/git/wine.git/?a=commit;h=dd7109136c28ae56998f96bc… Author: Aurimas Fišeras <aurimas(a)members.fsf.org> Date: Wed Nov 4 09:28:13 2020 +0200 po: Update Lithuanian translation. Signed-off-by: Aurimas Fišeras <aurimas(a)members.fsf.org> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- po/lt.po | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/po/lt.po b/po/lt.po index 20e169acf25..6535c85c79f 100644 --- a/po/lt.po +++ b/po/lt.po @@ -5,7 +5,7 @@ msgstr "" "Project-Id-Version: Wine\n" "Report-Msgid-Bugs-To: https://bugs.winehq.org\n" "POT-Creation-Date: N/A\n" -"PO-Revision-Date: 2020-10-30 23:36+0200\n" +"PO-Revision-Date: 2020-11-04 09:28+0200\n" "Last-Translator: Aurimas Fišeras <aurimas(a)members.fsf.org>\n" "Language-Team: Lithuanian <komp_lt(a)konf.lt>\n" "Language: lt\n" @@ -6932,10 +6932,8 @@ msgid "Not implemented.\n" msgstr "Nerealizuota.\n" #: dlls/kernel32/winerror.mc:3788 -#, fuzzy -#| msgid "RPC call failed.\n" msgid "Call failed.\n" -msgstr "RPC kreipinys nepavyko.\n" +msgstr "Kreipinys nepavyko.\n" #: dlls/kernel32/winerror.mc:3760 msgid "No Signature found in file.\n"

1 0

Michael Stefaniuc : svchost: Inline a simple string.
by Alexandre Julliard Nov. 4, 2020

Nov. 4, 2020

Module: wine Branch: master Commit: f629166425b6d91aaaa5da58a20b8bc78479f984 URL: https://source.winehq.org/git/wine.git/?a=commit;h=f629166425b6d91aaaa5da58… Author: Michael Stefaniuc <mstefani(a)winehq.org> Date: Tue Nov 3 23:34:39 2020 +0100 svchost: Inline a simple string. Signed-off-by: Michael Stefaniuc <mstefani(a)winehq.org> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- programs/svchost/svchost.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/programs/svchost/svchost.c b/programs/svchost/svchost.c index 0daaa6ebf47..603deef1abd 100644 --- a/programs/svchost/svchost.c +++ b/programs/svchost/svchost.c @@ -37,8 +37,6 @@ WINE_DEFAULT_DEBUG_CHANNEL(svchost); static const WCHAR service_reg_path[] = L"System\\CurrentControlSet\\Services"; static const WCHAR svchost_path[] = L"Software\\Microsoft\\Windows NT\\CurrentVersion\\Svchost"; -static const CHAR service_main[] = "ServiceMain"; - /* Allocate and initialize a WSTR containing the queried value */ static LPWSTR GetRegValue(HKEY service_key, const WCHAR *value_name) { @@ -162,14 +160,14 @@ static BOOL AddServiceElem(LPWSTR service_name, } /* Look for alternate to default ServiceMain entry point */ - ret = RegQueryValueExA(service_hkey, service_main, NULL, NULL, NULL, &reg_size); + ret = RegQueryValueExA(service_hkey, "ServiceMain", NULL, NULL, NULL, &reg_size); if (ret == ERROR_SUCCESS) { /* Add space for potentially missing NULL terminator, allocate, and * fill with the registry value */ size = reg_size + 1; dll_service_main = HeapAlloc(GetProcessHeap(), 0, size); - ret = RegQueryValueExA(service_hkey, service_main, NULL, NULL, + ret = RegQueryValueExA(service_hkey, "ServiceMain", NULL, NULL, (LPBYTE)dll_service_main, &reg_size); if (ret != ERROR_SUCCESS) { @@ -196,7 +194,7 @@ static BOOL AddServiceElem(LPWSTR service_name, else { service_main_func = - (LPSERVICE_MAIN_FUNCTIONW) GetProcAddress(library, service_main); + (LPSERVICE_MAIN_FUNCTIONW) GetProcAddress(library, "ServiceMain"); } if (!service_main_func) {

1 0

Michael Stefaniuc : wscript: Use wide-char string literals.
by Alexandre Julliard Nov. 4, 2020

Nov. 4, 2020

Module: wine Branch: master Commit: 4e3c4d6f1d4bf7085581b63f124d137769785cca URL: https://source.winehq.org/git/wine.git/?a=commit;h=4e3c4d6f1d4bf7085581b63f… Author: Michael Stefaniuc <mstefani(a)winehq.org> Date: Tue Nov 3 23:34:33 2020 +0100 wscript: Use wide-char string literals. Signed-off-by: Michael Stefaniuc <mstefani(a)winehq.org> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- programs/wscript/host.c | 12 +++--------- programs/wscript/main.c | 30 +++++++++--------------------- 2 files changed, 12 insertions(+), 30 deletions(-) diff --git a/programs/wscript/host.c b/programs/wscript/host.c index 315b8ac7234..9541994d3b0 100644 --- a/programs/wscript/host.c +++ b/programs/wscript/host.c @@ -33,8 +33,6 @@ WINE_DEFAULT_DEBUG_CHANNEL(wscript); #define BUILDVERSION 16535 - -static const WCHAR wshNameW[] = {'W','i','n','d','o','w','s',' ','S','c','r','i','p','t',' ','H','o','s','t',0}; static const WCHAR wshVersionW[] = {'5','.','8'}; VARIANT_BOOL wshInteractive = @@ -49,10 +47,8 @@ static HRESULT to_string(VARIANT *src, BSTR *dst) VARIANT v; HRESULT hres; - static const WCHAR nullW[] = {'n','u','l','l',0}; - if(V_VT(src) == VT_NULL) { - *dst = SysAllocString(nullW); + *dst = SysAllocString(L"null"); return *dst ? S_OK : E_OUTOFMEMORY; } @@ -73,9 +69,7 @@ static void print_string(const WCHAR *string) char *buf; if(wshInteractive) { - static const WCHAR windows_script_hostW[] = - {'W','i','n','d','o','w','s',' ','S','c','r','i','p','t',' ','H','o','s','t',0}; - MessageBoxW(NULL, string, windows_script_hostW, MB_OK); + MessageBoxW(NULL, string, L"Windows Script Host", MB_OK); return; } @@ -163,7 +157,7 @@ static HRESULT WINAPI Host_get_Name(IHost *iface, BSTR *out_Name) { WINE_TRACE("(%p)\n", out_Name); - if(!(*out_Name = SysAllocString(wshNameW))) + if(!(*out_Name = SysAllocString(L"Windows Script Host"))) return E_OUTOFMEMORY; return S_OK; } diff --git a/programs/wscript/main.c b/programs/wscript/main.c index 8a8036073bd..a7005a9289c 100644 --- a/programs/wscript/main.c +++ b/programs/wscript/main.c @@ -47,9 +47,6 @@ #endif WINE_DEFAULT_DEBUG_CHANNEL(wscript); - -static const WCHAR wscriptW[] = {'W','S','c','r','i','p','t',0}; -static const WCHAR wshW[] = {'W','S','H',0}; WCHAR scriptFullName[MAX_PATH]; ITypeInfo *host_ti; @@ -86,7 +83,7 @@ static HRESULT WINAPI ActiveScriptSite_GetItemInfo(IActiveScriptSite *iface, { WINE_TRACE("(%s %x %p %p)\n", wine_dbgstr_w(pstrName), dwReturnMask, ppunkItem, ppti); - if(lstrcmpW(pstrName, wshW) && lstrcmpW(pstrName, wscriptW)) + if(lstrcmpW(pstrName, L"WSH") && lstrcmpW(pstrName, L"WScript")) return E_FAIL; if(dwReturnMask & SCRIPTINFO_ITYPEINFO) { @@ -223,9 +220,7 @@ static BOOL load_typelib(void) ITypeLib *typelib; HRESULT hres; - static const WCHAR wscript_exeW[] = {'w','s','c','r','i','p','t','.','e','x','e',0}; - - hres = LoadTypeLib(wscript_exeW, &typelib); + hres = LoadTypeLib(L"wscript.exe", &typelib); if(FAILED(hres)) return FALSE; @@ -245,9 +240,6 @@ static BOOL get_engine_clsid(const WCHAR *ext, CLSID *clsid) HKEY hkey; HRESULT hres; - static const WCHAR script_engineW[] = - {'\\','S','c','r','i','p','t','E','n','g','i','n','e',0}; - res = RegOpenKeyW(HKEY_CLASSES_ROOT, ext, &hkey); if(res != ERROR_SUCCESS) return FALSE; @@ -260,7 +252,7 @@ static BOOL get_engine_clsid(const WCHAR *ext, CLSID *clsid) WINE_TRACE("fileid is %s\n", wine_dbgstr_w(fileid)); - lstrcatW(fileid, script_engineW); + lstrcatW(fileid, L"\\ScriptEngine"); res = RegOpenKeyW(HKEY_CLASSES_ROOT, fileid, &hkey); if(res != ERROR_SUCCESS) return FALSE; @@ -319,11 +311,11 @@ static BOOL init_engine(IActiveScript *script, IActiveScriptParse *parser) if(FAILED(hres)) return FALSE; - hres = IActiveScript_AddNamedItem(script, wscriptW, SCRIPTITEM_ISVISIBLE); + hres = IActiveScript_AddNamedItem(script, L"WScript", SCRIPTITEM_ISVISIBLE); if(FAILED(hres)) return FALSE; - hres = IActiveScript_AddNamedItem(script, wshW, SCRIPTITEM_ISVISIBLE); + hres = IActiveScript_AddNamedItem(script, L"WSH", SCRIPTITEM_ISVISIBLE); if(FAILED(hres)) return FALSE; @@ -387,10 +379,6 @@ static void run_script(const WCHAR *filename, IActiveScript *script, IActiveScri static BOOL set_host_properties(const WCHAR *prop) { - static const WCHAR nologoW[] = {'n','o','l','o','g','o',0}; - static const WCHAR iactive[] = {'i',0}; - static const WCHAR batch[] = {'b',0}; - if(*prop == '/') { ++prop; if(*prop == '/') @@ -399,12 +387,12 @@ static BOOL set_host_properties(const WCHAR *prop) else ++prop; - if(wcsicmp(prop, iactive) == 0) + if(wcsicmp(prop, L"i") == 0) wshInteractive = VARIANT_TRUE; - else if(wcsicmp(prop, batch) == 0) + else if(wcsicmp(prop, L"b") == 0) wshInteractive = VARIANT_FALSE; - else if(wcsicmp(prop, nologoW) == 0) - WINE_FIXME("ignored %s switch\n", debugstr_w(nologoW)); + else if(wcsicmp(prop, L"nologo") == 0) + WINE_FIXME("ignored %s switch\n", debugstr_w(L"nologo")); else { WINE_FIXME("unsupported switch %s\n", debugstr_w(prop));

1 0

Michael Stefaniuc : winedevice: Use wide-char string literals.
by Alexandre Julliard Nov. 4, 2020

Nov. 4, 2020

Module: wine Branch: master Commit: 6f6cead416d23226c8f341c0842c46b62e0a4d75 URL: https://source.winehq.org/git/wine.git/?a=commit;h=6f6cead416d23226c8f341c0… Author: Michael Stefaniuc <mstefani(a)winehq.org> Date: Tue Nov 3 23:34:37 2020 +0100 winedevice: Use wide-char string literals. Signed-off-by: Michael Stefaniuc <mstefani(a)winehq.org> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- programs/winedevice/device.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/programs/winedevice/device.c b/programs/winedevice/device.c index 7bada000520..c591d743337 100644 --- a/programs/winedevice/device.c +++ b/programs/winedevice/device.c @@ -32,12 +32,7 @@ WINE_DEFAULT_DEBUG_CHANNEL(winedevice); -static const WCHAR servicesW[] = {'\\','R','e','g','i','s','t','r','y', - '\\','M','a','c','h','i','n','e', - '\\','S','y','s','t','e','m', - '\\','C','u','r','r','e','n','t','C','o','n','t','r','o','l','S','e','t', - '\\','S','e','r','v','i','c','e','s', - '\\',0}; +static const WCHAR servicesW[] = L"\\Registry\\Machine\\System\\CurrentControlSet\\Services\\"; extern NTSTATUS CDECL wine_ntoskrnl_main_loop( HANDLE stop_event );

1 0

Huw Davies : riched20: Use para_in_table() instead of IsInTable().
by Alexandre Julliard Nov. 4, 2020

Nov. 4, 2020

Module: wine Branch: master Commit: c8fef268846221fa161d920c10c2b8290b64b476 URL: https://source.winehq.org/git/wine.git/?a=commit;h=c8fef268846221fa161d920c… Author: Huw Davies <huw(a)codeweavers.com> Date: Wed Nov 4 06:56:25 2020 +0000 riched20: Use para_in_table() instead of IsInTable(). Signed-off-by: Huw Davies <huw(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/riched20/editor.h | 1 - dlls/riched20/table.c | 17 ++--------------- 2 files changed, 2 insertions(+), 16 deletions(-) diff --git a/dlls/riched20/editor.h b/dlls/riched20/editor.h index e884cbee2f3..05a6a7ee37f 100644 --- a/dlls/riched20/editor.h +++ b/dlls/riched20/editor.h @@ -289,7 +289,6 @@ ME_Paragraph *editor_end_para( ME_TextEditor *editor ) DECLSPEC_HIDDEN; ME_Paragraph *editor_first_para( ME_TextEditor *editor ) DECLSPEC_HIDDEN; /* table.c */ -BOOL ME_IsInTable(ME_DisplayItem *pItem) DECLSPEC_HIDDEN; ME_Paragraph *cell_end_para( ME_Cell *cell ) DECLSPEC_HIDDEN; ME_Paragraph *cell_first_para( ME_Cell *cell ) DECLSPEC_HIDDEN; ME_Cell *cell_next( ME_Cell *cell ) DECLSPEC_HIDDEN; diff --git a/dlls/riched20/table.c b/dlls/riched20/table.c index e08876d29bd..9d0d24fa1c3 100644 --- a/dlls/riched20/table.c +++ b/dlls/riched20/table.c @@ -212,19 +212,6 @@ ME_Paragraph *cell_end_para( ME_Cell *cell ) return &ME_FindItemBack( cell_get_di( next ), diParagraph )->member.para; } -BOOL ME_IsInTable(ME_DisplayItem *pItem) -{ - PARAFORMAT2 *pFmt; - if (!pItem) - return FALSE; - if (pItem->type == diRun) - pItem = ME_GetParagraph(pItem); - if (pItem->type != diParagraph) - return FALSE; - pFmt = &pItem->member.para.fmt; - return pFmt->dwMask & PFM_TABLE && pFmt->wEffects & PFE_TABLE; -} - /* Table rows should either be deleted completely or not at all. */ void table_protect_partial_deletion( ME_TextEditor *editor, ME_Cursor *c, int *num_chars ) { @@ -504,7 +491,7 @@ void table_handle_tab( ME_TextEditor *editor, BOOL selected_row ) } if (!editor->bEmulateVersion10) /* v4.1 */ { - if (!ME_IsInTable(toCursor.pRun)) + if (!para_in_table( &toCursor.pPara->member.para )) { editor->pCursors[0] = toCursor; editor->pCursors[1] = toCursor; @@ -513,7 +500,7 @@ void table_handle_tab( ME_TextEditor *editor, BOOL selected_row ) } else /* v1.0 - 3.0 */ { - if (!ME_IsInTable(fromCursor.pRun)) + if (!para_in_table( &fromCursor.pPara->member.para) ) { editor->pCursors[0] = fromCursor; editor->pCursors[1] = fromCursor;

1 0

Michael Stefaniuc : wscript: Zero terminate the host version string to avoid random garbage.
by Alexandre Julliard Nov. 4, 2020

Nov. 4, 2020

Module: wine Branch: master Commit: 7f955f289ac68ef49e73eaa4a8d8f12168f47785 URL: https://source.winehq.org/git/wine.git/?a=commit;h=7f955f289ac68ef49e73eaa4… Author: Michael Stefaniuc <mstefani(a)winehq.org> Date: Tue Nov 3 23:34:34 2020 +0100 wscript: Zero terminate the host version string to avoid random garbage. String is used only once and passed to SysAllocString() which assumes a zero terminated string. Signed-off-by: Michael Stefaniuc <mstefani(a)winehq.org> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- programs/wscript/host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/programs/wscript/host.c b/programs/wscript/host.c index 9541994d3b0..ba3a32a935d 100644 --- a/programs/wscript/host.c +++ b/programs/wscript/host.c @@ -33,7 +33,7 @@ WINE_DEFAULT_DEBUG_CHANNEL(wscript); #define BUILDVERSION 16535 -static const WCHAR wshVersionW[] = {'5','.','8'}; +static const WCHAR wshVersionW[] = L"5.8"; VARIANT_BOOL wshInteractive = #ifndef CSCRIPT_BUILD

1 0

Michael Stefaniuc : wscript: Use a zero terminated wchar string.
by Alexandre Julliard Nov. 4, 2020

Nov. 4, 2020

Module: wine Branch: master Commit: 453c461095d59600e646be483119bc83885c9c1d URL: https://source.winehq.org/git/wine.git/?a=commit;h=453c461095d59600e646be48… Author: Michael Stefaniuc <mstefani(a)winehq.org> Date: Tue Nov 3 23:34:35 2020 +0100 wscript: Use a zero terminated wchar string. Signed-off-by: Michael Stefaniuc <mstefani(a)winehq.org> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- programs/wscript/host.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/programs/wscript/host.c b/programs/wscript/host.c index ba3a32a935d..e20d3132f16 100644 --- a/programs/wscript/host.c +++ b/programs/wscript/host.c @@ -76,8 +76,7 @@ static void print_string(const WCHAR *string) len = lstrlenW(string); ret = WriteConsoleW(GetStdHandle(STD_OUTPUT_HANDLE), string, len, &count, NULL); if(ret) { - static const WCHAR crnlW[] = {'\r','\n'}; - WriteConsoleW(GetStdHandle(STD_OUTPUT_HANDLE), crnlW, ARRAY_SIZE(crnlW), &count, NULL); + WriteConsoleW(GetStdHandle(STD_OUTPUT_HANDLE), L"\r\n", lstrlenW(L"\r\n"), &count, NULL); return; }

1 0