March 2020 - Wine-Commits - list.winehq.org

Gabriel Ivăncescu : kernel32: Implement compatibility mode for VerifyVersionInfo.
by Alexandre Julliard March 19, 2020

March 19, 2020

Module: wine Branch: master Commit: 543209eb23ce7e113e610b5978dc229fc20bf92e URL: https://source.winehq.org/git/wine.git/?a=commit;h=543209eb23ce7e113e610b59… Author: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> Date: Wed Mar 18 18:31:55 2020 +0200 kernel32: Implement compatibility mode for VerifyVersionInfo. Signed-off-by: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/kernel32/tests/version.c | 5 -- dlls/kernel32/version.c | 143 +++++++++++++++++++++++++++++++++++++++--- 2 files changed, 136 insertions(+), 12 deletions(-) diff --git a/dlls/kernel32/tests/version.c b/dlls/kernel32/tests/version.c index c9e92a9c03..5fdc961542 100644 --- a/dlls/kernel32/tests/version.c +++ b/dlls/kernel32/tests/version.c @@ -193,8 +193,6 @@ static void test_VerifyVersionInfo(void) DWORD condition3; DWORD typemask4; DWORD condition4; - - BOOL todo; } verify_version_tests[] = { { @@ -665,13 +663,10 @@ static void test_VerifyVersionInfo(void) SetLastError(0xdeadbeef); ret = VerifyVersionInfoA(&info, test->verifymask, mask); - todo_wine_if(test->todo) - { ok(test->err ? !ret : ret, "%u: unexpected return value %d.\n", i, ret); if (!ret) ok(GetLastError() == test->err, "%u: unexpected error code %d, expected %d.\n", i, GetLastError(), test->err); } - } /* test handling of version numbers */ /* v3.10 is always less than v4.x even diff --git a/dlls/kernel32/version.c b/dlls/kernel32/version.c index 5f33847d60..cca59416eb 100644 --- a/dlls/kernel32/version.c +++ b/dlls/kernel32/version.c @@ -42,6 +42,61 @@ WINE_DEFAULT_DEBUG_CHANNEL(ver); +static inline UCHAR version_update_condition(UCHAR *last_condition, UCHAR condition) +{ + switch (*last_condition) + { + case 0: + *last_condition = condition; + break; + case VER_EQUAL: + if (condition >= VER_EQUAL && condition <= VER_LESS_EQUAL) + { + *last_condition = condition; + return condition; + } + break; + case VER_GREATER: + case VER_GREATER_EQUAL: + if (condition >= VER_EQUAL && condition <= VER_GREATER_EQUAL) + return condition; + break; + case VER_LESS: + case VER_LESS_EQUAL: + if (condition == VER_EQUAL || (condition >= VER_LESS && condition <= VER_LESS_EQUAL)) + return condition; + break; + } + if (!condition) *last_condition |= 0x10; + return *last_condition & 0xf; +} + +static inline BOOL version_compare_values(ULONG left, ULONG right, UCHAR condition) +{ + switch (condition) + { + case VER_EQUAL: + if (left != right) return FALSE; + break; + case VER_GREATER: + if (left <= right) return FALSE; + break; + case VER_GREATER_EQUAL: + if (left < right) return FALSE; + break; + case VER_LESS: + if (left >= right) return FALSE; + break; + case VER_LESS_EQUAL: + if (left > right) return FALSE; + break; + default: + return FALSE; + } + return TRUE; +} + + /****************************************************************************** * VerifyVersionInfoA (KERNEL32.@) */ @@ -68,19 +123,93 @@ BOOL WINAPI VerifyVersionInfoA( LPOSVERSIONINFOEXA lpVersionInfo, DWORD dwTypeMa /****************************************************************************** * VerifyVersionInfoW (KERNEL32.@) */ -BOOL WINAPI VerifyVersionInfoW( LPOSVERSIONINFOEXW lpVersionInfo, DWORD dwTypeMask, +BOOL WINAPI VerifyVersionInfoW( LPOSVERSIONINFOEXW info, DWORD dwTypeMask, DWORDLONG dwlConditionMask) { - switch(RtlVerifyVersionInfo( lpVersionInfo, dwTypeMask, dwlConditionMask )) + OSVERSIONINFOEXW ver; + + TRACE("(%p 0x%x 0x%s)\n", info, dwTypeMask, wine_dbgstr_longlong(dwlConditionMask)); + + ver.dwOSVersionInfoSize = sizeof(ver); + if (!GetVersionExW((OSVERSIONINFOW*)&ver)) return FALSE; + + if (!dwTypeMask || !dwlConditionMask) { - case STATUS_INVALID_PARAMETER: - SetLastError( ERROR_BAD_ARGUMENTS ); - return FALSE; - case STATUS_REVISION_MISMATCH: - SetLastError( ERROR_OLD_WIN_VERSION ); + SetLastError(ERROR_BAD_ARGUMENTS); return FALSE; } + + if (dwTypeMask & VER_PRODUCT_TYPE) + { + if (!version_compare_values(ver.wProductType, info->wProductType, dwlConditionMask >> 7*3 & 0x07)) + goto mismatch; + } + if (dwTypeMask & VER_SUITENAME) + switch (dwlConditionMask >> 6*3 & 0x07) + { + case VER_AND: + if ((info->wSuiteMask & ver.wSuiteMask) != info->wSuiteMask) + goto mismatch; + break; + case VER_OR: + if (!(info->wSuiteMask & ver.wSuiteMask) && info->wSuiteMask) + goto mismatch; + break; + default: + SetLastError(ERROR_BAD_ARGUMENTS); + return FALSE; + } + if (dwTypeMask & VER_PLATFORMID) + { + if (!version_compare_values(ver.dwPlatformId, info->dwPlatformId, dwlConditionMask >> 3*3 & 0x07)) + goto mismatch; + } + if (dwTypeMask & VER_BUILDNUMBER) + { + if (!version_compare_values(ver.dwBuildNumber, info->dwBuildNumber, dwlConditionMask >> 2*3 & 0x07)) + goto mismatch; + } + + if (dwTypeMask & (VER_MAJORVERSION | VER_MINORVERSION | VER_SERVICEPACKMAJOR | VER_SERVICEPACKMINOR)) + { + unsigned char condition, last_condition = 0; + BOOL succeeded = TRUE, do_next_check = TRUE; + + if (dwTypeMask & VER_MAJORVERSION) + { + condition = version_update_condition(&last_condition, dwlConditionMask >> 1*3 & 0x07); + succeeded = version_compare_values(ver.dwMajorVersion, info->dwMajorVersion, condition); + do_next_check = (ver.dwMajorVersion == info->dwMajorVersion) && + ((condition >= VER_EQUAL) && (condition <= VER_LESS_EQUAL)); + } + if ((dwTypeMask & VER_MINORVERSION) && do_next_check) + { + condition = version_update_condition(&last_condition, dwlConditionMask >> 0*3 & 0x07); + succeeded = version_compare_values(ver.dwMinorVersion, info->dwMinorVersion, condition); + do_next_check = (ver.dwMinorVersion == info->dwMinorVersion) && + ((condition >= VER_EQUAL) && (condition <= VER_LESS_EQUAL)); + } + if ((dwTypeMask & VER_SERVICEPACKMAJOR) && do_next_check) + { + condition = version_update_condition(&last_condition, dwlConditionMask >> 5*3 & 0x07); + succeeded = version_compare_values(ver.wServicePackMajor, info->wServicePackMajor, condition); + do_next_check = (ver.wServicePackMajor == info->wServicePackMajor) && + ((condition >= VER_EQUAL) && (condition <= VER_LESS_EQUAL)); + } + if ((dwTypeMask & VER_SERVICEPACKMINOR) && do_next_check) + { + condition = version_update_condition(&last_condition, dwlConditionMask >> 4*3 & 0x07); + succeeded = version_compare_values(ver.wServicePackMinor, info->wServicePackMinor, condition); + } + + if (!succeeded) goto mismatch; + } + return TRUE; + +mismatch: + SetLastError(ERROR_OLD_WIN_VERSION); + return FALSE; } /***********************************************************************

1 0

Gabriel Ivăncescu : kernelbase: Implement compatibility mode for GetVersion.
by Alexandre Julliard March 19, 2020

March 19, 2020

Module: wine Branch: master Commit: 563a8c0f98f89f8e2d4988a92a69976c73b5a5ca URL: https://source.winehq.org/git/wine.git/?a=commit;h=563a8c0f98f89f8e2d4988a9… Author: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> Date: Wed Mar 18 18:31:54 2020 +0200 kernelbase: Implement compatibility mode for GetVersion. Signed-off-by: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/kernelbase/version.c | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/dlls/kernelbase/version.c b/dlls/kernelbase/version.c index 3e1cef919b..8a0394da92 100644 --- a/dlls/kernelbase/version.c +++ b/dlls/kernelbase/version.c @@ -1420,11 +1420,17 @@ BOOL WINAPI DECLSPEC_HOTPATCH GetProductInfo( DWORD os_major, DWORD os_minor, */ DWORD WINAPI GetVersion(void) { - DWORD result = MAKELONG( MAKEWORD( NtCurrentTeb()->Peb->OSMajorVersion, - NtCurrentTeb()->Peb->OSMinorVersion ), - (NtCurrentTeb()->Peb->OSPlatformId ^ 2) << 14 ); - if (NtCurrentTeb()->Peb->OSPlatformId == VER_PLATFORM_WIN32_NT) - result |= LOWORD(NtCurrentTeb()->Peb->OSBuildNumber) << 16; + OSVERSIONINFOEXW info; + DWORD result; + + info.dwOSVersionInfoSize = sizeof(info); + if (!GetVersionExW( (OSVERSIONINFOW *)&info )) return 0; + + result = MAKELONG( MAKEWORD( info.dwMajorVersion, info.dwMinorVersion ), + (info.dwPlatformId ^ 2) << 14 ); + + if (info.dwPlatformId == VER_PLATFORM_WIN32_NT) + result |= LOWORD(info.dwBuildNumber) << 16; return result; }

1 0

Gabriel Ivăncescu : kernelbase: Implement compatibility mode for GetVersionEx.
by Alexandre Julliard March 19, 2020

March 19, 2020

Module: wine Branch: master Commit: 6719bf2e037b95b8338fae9e660c43e8fadafc7a URL: https://source.winehq.org/git/wine.git/?a=commit;h=6719bf2e037b95b8338fae9e… Author: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> Date: Wed Mar 18 18:31:53 2020 +0200 kernelbase: Implement compatibility mode for GetVersionEx. Since Windows 8.1, these functions have been deprecated and run in a sort of compatibility mode, reporting Windows 8 unless the application supplies a manifest that specifies compatibility with newer Windows versions explicitly (by listing their GUIDs). Some applications have bad non-forward-compatible checks based on GetVersionEx, and depend on this behavior (they do not supply a manifest). Currently, they break on Wine if we use a Windows 10 prefix for example, since we always report the real version. One example is the game Rock of Ages. Signed-off-by: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/kernel32/tests/version.c | 2 +- dlls/kernelbase/version.c | 142 +++++++++++++++++++++++++++++++++++++++++- 2 files changed, 140 insertions(+), 4 deletions(-) diff --git a/dlls/kernel32/tests/version.c b/dlls/kernel32/tests/version.c index 1bb3e20978..c9e92a9c03 100644 --- a/dlls/kernel32/tests/version.c +++ b/dlls/kernel32/tests/version.c @@ -610,7 +610,7 @@ static void test_VerifyVersionInfo(void) if (rtlinfo.dwMajorVersion != 6 || rtlinfo.dwMinorVersion != 2) { - win_skip("GetVersionEx and VerifyVersionInfo are faking values\n"); + skip("GetVersionEx and VerifyVersionInfo are faking values\n"); return; } } diff --git a/dlls/kernelbase/version.c b/dlls/kernelbase/version.c index cf46e9cc3a..3e1cef919b 100644 --- a/dlls/kernelbase/version.c +++ b/dlls/kernelbase/version.c @@ -28,6 +28,8 @@ #include <stdio.h> #include <sys/types.h> +#include "ntstatus.h" +#define WIN32_NO_STATUS #define NONAMELESSUNION #define NONAMELESSSTRUCT #include "windef.h" @@ -60,6 +62,13 @@ typedef struct DWORD resloader; } NE_TYPEINFO; +struct version_info +{ + DWORD major; + DWORD minor; + DWORD build; +}; + /*********************************************************************** * Version Info Structure */ @@ -116,6 +125,114 @@ typedef struct (VS_VERSION_INFO_STRUCT32 *)( (LPBYTE)ver + (((ver)->wLength + 3) & ~3) ) +/*********************************************************************** + * Win8 info, reported if app doesn't provide compat GUID in manifest. + */ +static const struct version_info windows8_version_info = { 6, 2, 0x23f0 }; + + +/*********************************************************************** + * Windows versions that need compatibility GUID specified in manifest + * in order to be reported by the APIs. + */ +static const struct +{ + struct version_info info; + GUID guid; +} version_data[] = +{ + /* Windows 8.1 */ + { + { 6, 3, 0x2580 }, + {0x1f676c76,0x80e1,0x4239,{0x95,0xbb,0x83,0xd0,0xf6,0xd0,0xda,0x78}} + }, + /* Windows 10 */ + { + { 10, 0, 0x42ee }, + {0x8e0f7a12,0xbfb3,0x4fe8,{0xb9,0xa5,0x48,0xfd,0x50,0xa1,0x5a,0x9a}} + } +}; + + +/****************************************************************************** + * init_current_version + * + * Initialize the current_version variable. + * + * For compatibility, Windows 8.1 and later report Win8 version unless the app + * has a manifest that confirms its compatibility with newer versions of Windows. + * + */ +static RTL_OSVERSIONINFOEXW current_version; + +static BOOL CALLBACK init_current_version(PINIT_ONCE init_once, PVOID parameter, PVOID *context) +{ + /*ACTIVATION_CONTEXT_COMPATIBILITY_INFORMATION*/DWORD *acci; + const struct version_info *ver; + SIZE_T req; + int idx; + + current_version.dwOSVersionInfoSize = sizeof(current_version); + if (!set_ntstatus( RtlGetVersion(&current_version) )) return FALSE; + + for (idx = ARRAY_SIZE(version_data); idx--;) + if ( current_version.dwMajorVersion > version_data[idx].info.major || + (current_version.dwMajorVersion == version_data[idx].info.major && + current_version.dwMinorVersion >= version_data[idx].info.minor)) + break; + + if (idx < 0) return TRUE; + ver = &windows8_version_info; + + if (RtlQueryInformationActivationContext(0, NtCurrentTeb()->Peb->ActivationContextData, NULL, + CompatibilityInformationInActivationContext, NULL, 0, &req) != STATUS_BUFFER_TOO_SMALL + || !req) + goto done; + + if (!(acci = HeapAlloc(GetProcessHeap(), 0, req))) + { + SetLastError(ERROR_NOT_ENOUGH_MEMORY); + return FALSE; + } + + if (RtlQueryInformationActivationContext(0, NtCurrentTeb()->Peb->ActivationContextData, NULL, + CompatibilityInformationInActivationContext, acci, req, &req) == STATUS_SUCCESS) + { + do + { + COMPATIBILITY_CONTEXT_ELEMENT *elements = (COMPATIBILITY_CONTEXT_ELEMENT*)(acci + 1); + DWORD i, count = *acci; + + for (i = 0; i < count; i++) + { + if (elements[i].Type == ACTCTX_COMPATIBILITY_ELEMENT_TYPE_OS && + IsEqualGUID(&elements[i].Id, &version_data[idx].guid)) + { + ver = &version_data[idx].info; + + if (ver->major == current_version.dwMajorVersion && + ver->minor == current_version.dwMinorVersion) + ver = NULL; + + idx = 0; /* break from outer loop */ + break; + } + } + } while (idx--); + } + HeapFree(GetProcessHeap(), 0, acci); + +done: + if (ver) + { + current_version.dwMajorVersion = ver->major; + current_version.dwMinorVersion = ver->minor; + current_version.dwBuildNumber = ver->build; + } + return TRUE; +} + + /********************************************************************** * find_entry_by_id * @@ -1317,7 +1434,7 @@ DWORD WINAPI GetVersion(void) */ BOOL WINAPI GetVersionExA( OSVERSIONINFOA *info ) { - RTL_OSVERSIONINFOEXW infoW; + OSVERSIONINFOEXW infoW; if (info->dwOSVersionInfoSize != sizeof(OSVERSIONINFOA) && info->dwOSVersionInfoSize != sizeof(OSVERSIONINFOEXA)) @@ -1328,7 +1445,7 @@ BOOL WINAPI GetVersionExA( OSVERSIONINFOA *info ) } infoW.dwOSVersionInfoSize = sizeof(infoW); - if (!set_ntstatus( RtlGetVersion( &infoW ))) return FALSE; + if (!GetVersionExW( (OSVERSIONINFOW *)&infoW )) return FALSE; info->dwMajorVersion = infoW.dwMajorVersion; info->dwMinorVersion = infoW.dwMinorVersion; @@ -1354,11 +1471,30 @@ BOOL WINAPI GetVersionExA( OSVERSIONINFOA *info ) */ BOOL WINAPI GetVersionExW( OSVERSIONINFOW *info ) { + static INIT_ONCE init_once = INIT_ONCE_STATIC_INIT; + if (info->dwOSVersionInfoSize != sizeof(OSVERSIONINFOW) && info->dwOSVersionInfoSize != sizeof(OSVERSIONINFOEXW)) { WARN( "wrong OSVERSIONINFO size from app (got: %d)\n", info->dwOSVersionInfoSize ); return FALSE; } - return set_ntstatus( RtlGetVersion( (RTL_OSVERSIONINFOEXW *)info )); + + if (!InitOnceExecuteOnce(&init_once, init_current_version, NULL, NULL)) return FALSE; + + info->dwMajorVersion = current_version.dwMajorVersion; + info->dwMinorVersion = current_version.dwMinorVersion; + info->dwBuildNumber = current_version.dwBuildNumber; + info->dwPlatformId = current_version.dwPlatformId; + wcscpy( info->szCSDVersion, current_version.szCSDVersion ); + + if (info->dwOSVersionInfoSize == sizeof(OSVERSIONINFOEXW)) + { + OSVERSIONINFOEXW *vex = (OSVERSIONINFOEXW *)info; + vex->wServicePackMajor = current_version.wServicePackMajor; + vex->wServicePackMinor = current_version.wServicePackMinor; + vex->wSuiteMask = current_version.wSuiteMask; + vex->wProductType = current_version.wProductType; + } + return TRUE; }

1 0

Gabriel Ivăncescu : ntdll: Store the default process activation context into the PEB.
by Alexandre Julliard March 19, 2020

March 19, 2020

Module: wine Branch: master Commit: e95d0813fdfcfcac2bb1761e62e1d54e6f73cd6d URL: https://source.winehq.org/git/wine.git/?a=commit;h=e95d0813fdfcfcac2bb1761e… Author: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> Date: Wed Mar 18 18:31:52 2020 +0200 ntdll: Store the default process activation context into the PEB. Signed-off-by: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ntdll/actctx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/dlls/ntdll/actctx.c b/dlls/ntdll/actctx.c index b88e6dea07..17f9cad084 100644 --- a/dlls/ntdll/actctx.c +++ b/dlls/ntdll/actctx.c @@ -4942,6 +4942,8 @@ void actctx_init(void) ctx.lpResourceName = (LPCWSTR)CREATEPROCESS_MANIFEST_RESOURCE_ID; if (!RtlCreateActivationContext( &handle, &ctx )) process_actctx = check_actctx(handle); + + NtCurrentTeb()->Peb->ActivationContextData = process_actctx; }

1 0

Serge Gautherie : include: Remove now useless forced WINVER defines.
by Alexandre Julliard March 19, 2020

March 19, 2020

Module: wine Branch: master Commit: d0fd12b90946865a92f3fd016ccac13e5c4fdf54 URL: https://source.winehq.org/git/wine.git/?a=commit;h=d0fd12b90946865a92f3fd01… Author: Serge Gautherie <winehq-git_serge_180711(a)gautherie.fr> Date: Wed Mar 18 23:41:24 2020 +0100 include: Remove now useless forced WINVER defines. Signed-off-by: Serge Gautherie <winehq-git_serge_180711(a)gautherie.fr> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/d3d8/tests/device.c | 1 - dlls/d3d9/tests/device.c | 1 - dlls/gdi32/tests/dc.c | 2 -- dlls/user32/tests/dialog.c | 2 -- dlls/user32/tests/msg.c | 3 --- dlls/user32/tests/sysparams.c | 4 ---- 6 files changed, 13 deletions(-) diff --git a/dlls/d3d8/tests/device.c b/dlls/d3d8/tests/device.c index 42eee28217..2e182e6192 100644 --- a/dlls/d3d8/tests/device.c +++ b/dlls/d3d8/tests/device.c @@ -21,7 +21,6 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA */ -#define WINVER 0x0602 /* for CURSOR_SUPPRESSED */ #include <stdlib.h> #define COBJMACROS #include <initguid.h> diff --git a/dlls/d3d9/tests/device.c b/dlls/d3d9/tests/device.c index 16f42216cf..afbd13a398 100644 --- a/dlls/d3d9/tests/device.c +++ b/dlls/d3d9/tests/device.c @@ -22,7 +22,6 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA */ -#define WINVER 0x0602 /* for CURSOR_SUPPRESSED */ #define COBJMACROS #include <d3d9.h> #include "utils.h" diff --git a/dlls/gdi32/tests/dc.c b/dlls/gdi32/tests/dc.c index c8a903e56b..6640134d1f 100644 --- a/dlls/gdi32/tests/dc.c +++ b/dlls/gdi32/tests/dc.c @@ -19,8 +19,6 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA */ - -#define WINVER 0x0501 /* request latest DEVMODE */ #define NONAMELESSSTRUCT #define NONAMELESSUNION diff --git a/dlls/user32/tests/dialog.c b/dlls/user32/tests/dialog.c index 2a7d71f67a..5a6a0bf5fb 100644 --- a/dlls/user32/tests/dialog.c +++ b/dlls/user32/tests/dialog.c @@ -29,8 +29,6 @@ * normally be met. */ -#define WINVER 0x0600 /* For NONCLIENTMETRICS with padding */ - #include <assert.h> #include <stdio.h> #include <stdarg.h> diff --git a/dlls/user32/tests/msg.c b/dlls/user32/tests/msg.c index 303a026cda..07f21607e8 100644 --- a/dlls/user32/tests/msg.c +++ b/dlls/user32/tests/msg.c @@ -20,9 +20,6 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA */ -#define _WIN32_WINNT 0x0600 /* For WM_CHANGEUISTATE,QS_RAWINPUT,WM_DWMxxxx */ -#define WINVER 0x0600 /* for WM_GETTITLEBARINFOEX */ - #include <assert.h> #include <limits.h> #include <stdarg.h> diff --git a/dlls/user32/tests/sysparams.c b/dlls/user32/tests/sysparams.c index cf12725a45..b37af4d420 100644 --- a/dlls/user32/tests/sysparams.c +++ b/dlls/user32/tests/sysparams.c @@ -17,10 +17,6 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA */ -#define _WIN32_WINNT 0x0600 /* For SPI_GETMOUSEHOVERWIDTH and more */ -#define _WIN32_IE 0x0700 -#define WINVER 0x0600 /* For COLOR_MENUBAR, NONCLIENTMETRICS with padding */ - #include <assert.h> #include <stdlib.h> #include <stdarg.h>

1 0

Nikolay Sivov : mfplat: Zero-initialize buffer memory.
by Alexandre Julliard March 19, 2020

March 19, 2020

Module: wine Branch: master Commit: a6a992d2fdde35aa20c2464c19e6826b8a053512 URL: https://source.winehq.org/git/wine.git/?a=commit;h=a6a992d2fdde35aa20c2464c… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Thu Mar 19 15:07:41 2020 +0300 mfplat: Zero-initialize buffer memory. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mfplat/buffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/mfplat/buffer.c b/dlls/mfplat/buffer.c index 65c23101e7..ea89bcb1f5 100644 --- a/dlls/mfplat/buffer.c +++ b/dlls/mfplat/buffer.c @@ -503,7 +503,7 @@ static const IMF2DBuffer2Vtbl memory_2d_buffer_vtbl = static HRESULT memory_buffer_init(struct memory_buffer *buffer, DWORD max_length, DWORD alignment, const IMFMediaBufferVtbl *vtbl) { - buffer->data = heap_alloc(ALIGN_SIZE(max_length, alignment)); + buffer->data = heap_alloc_zero(ALIGN_SIZE(max_length, alignment)); if (!buffer->data) return E_OUTOFMEMORY;

1 0

Nikolay Sivov : mfplat: Fix scanline for bottom-up case.
by Alexandre Julliard March 19, 2020

March 19, 2020

Module: wine Branch: master Commit: 5adb32f8b3a31c8fe889ca546e6cb49614219c01 URL: https://source.winehq.org/git/wine.git/?a=commit;h=5adb32f8b3a31c8fe889ca54… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Thu Mar 19 15:07:39 2020 +0300 mfplat: Fix scanline for bottom-up case. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mfplat/buffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/mfplat/buffer.c b/dlls/mfplat/buffer.c index 7206cf6d5a..7039f93f57 100644 --- a/dlls/mfplat/buffer.c +++ b/dlls/mfplat/buffer.c @@ -613,7 +613,7 @@ static HRESULT create_2d_buffer(DWORD width, DWORD height, DWORD fourcc, BOOL bo object->_2d.width = width * bpp; object->_2d.height = height; object->_2d.pitch = bottom_up ? -pitch : pitch; - object->_2d.scanline0 = bottom_up ? object->data + object->_2d.width * (object->_2d.height - 1) : object->data; + object->_2d.scanline0 = bottom_up ? object->data + pitch * (object->_2d.height - 1) : object->data; *buffer = &object->IMFMediaBuffer_iface;

1 0

Nikolay Sivov : mfplat: Fix bpp for RGB24 format.
by Alexandre Julliard March 19, 2020

March 19, 2020

Module: wine Branch: master Commit: 1d7c5308c6eb47380d96ae0160c3101f064d575b URL: https://source.winehq.org/git/wine.git/?a=commit;h=1d7c5308c6eb47380d96ae01… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Thu Mar 19 15:07:38 2020 +0300 mfplat: Fix bpp for RGB24 format. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mfplat/mediatype.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/mfplat/mediatype.c b/dlls/mfplat/mediatype.c index 77753cc499..5995454326 100644 --- a/dlls/mfplat/mediatype.c +++ b/dlls/mfplat/mediatype.c @@ -1782,7 +1782,7 @@ static int __cdecl uncompressed_video_format_compare(const void *a, const void * static const struct uncompressed_video_format video_formats[] = { - { &MFVideoFormat_RGB24, 3, 3, 1, 0 }, + { &MFVideoFormat_RGB24, 4, 3, 1, 0 }, { &MFVideoFormat_ARGB32, 4, 3, 1, 0 }, { &MFVideoFormat_RGB32, 4, 3, 1, 0 }, { &MFVideoFormat_RGB565, 2, 3, 1, 0 },

1 0

Nikolay Sivov : mfplat: Fix scanline pointer returned with Lock2D().
by Alexandre Julliard March 19, 2020

March 19, 2020

Module: wine Branch: master Commit: bd3f27abda15c7f169a53a63d61972053d0e4227 URL: https://source.winehq.org/git/wine.git/?a=commit;h=bd3f27abda15c7f169a53a63… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Thu Mar 19 15:07:37 2020 +0300 mfplat: Fix scanline pointer returned with Lock2D(). Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mfplat/buffer.c | 2 +- dlls/mfplat/tests/mfplat.c | 8 +++++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/dlls/mfplat/buffer.c b/dlls/mfplat/buffer.c index 71bae4c42f..7206cf6d5a 100644 --- a/dlls/mfplat/buffer.c +++ b/dlls/mfplat/buffer.c @@ -340,7 +340,7 @@ static HRESULT memory_2d_buffer_lock(struct memory_buffer *buffer, BYTE **scanli else { ++buffer->_2d.locks; - *scanline0 = buffer->data; + *scanline0 = buffer->_2d.scanline0; *pitch = buffer->_2d.pitch; if (buffer_start) *buffer_start = buffer->data; diff --git a/dlls/mfplat/tests/mfplat.c b/dlls/mfplat/tests/mfplat.c index 8e9bf8102a..497c451f72 100644 --- a/dlls/mfplat/tests/mfplat.c +++ b/dlls/mfplat/tests/mfplat.c @@ -4694,7 +4694,7 @@ static void test_MFCreate2DMediaBuffer(void) IMF2DBuffer2 *_2dbuffer2; IMF2DBuffer *_2dbuffer; IMFMediaBuffer *buffer; - int i, pitch; + int i, pitch, pitch2; HRESULT hr; BOOL ret; @@ -4898,6 +4898,12 @@ static void test_MFCreate2DMediaBuffer(void) hr = IMF2DBuffer_Lock2D(_2dbuffer, &data, &pitch); ok(hr == S_OK, "Failed to lock buffer, hr %#x.\n", hr); + + hr = IMF2DBuffer_GetScanline0AndPitch(_2dbuffer, &data2, &pitch2); + ok(hr == S_OK, "Failed to get scanline, hr %#x.\n", hr); + ok(data2 == data, "Unexpected data pointer.\n"); + ok(pitch == pitch2, "Unexpected pitch.\n"); + hr = IMF2DBuffer_Unlock2D(_2dbuffer); ok(hr == S_OK, "Failed to unlock buffer, hr %#x.\n", hr);

1 0

Matteo Bruni : d3d9: Fix RTV refcounting in d3d9_texture_cube_AddRef().
by Alexandre Julliard March 18, 2020

March 18, 2020

Module: wine Branch: master Commit: d7eba2a9cbcd7106a10018bb6e15b524ea0445b7 URL: https://source.winehq.org/git/wine.git/?a=commit;h=d7eba2a9cbcd7106a10018bb… Author: Matteo Bruni <mbruni(a)codeweavers.com> Date: Wed Mar 18 14:01:24 2020 +0100 d3d9: Fix RTV refcounting in d3d9_texture_cube_AddRef(). Signed-off-by: Matteo Bruni <mbruni(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/d3d9/texture.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/d3d9/texture.c b/dlls/d3d9/texture.c index 0d36c02aaa..9be9d450ba 100644 --- a/dlls/d3d9/texture.c +++ b/dlls/d3d9/texture.c @@ -543,7 +543,7 @@ static ULONG WINAPI d3d9_texture_cube_AddRef(IDirect3DCubeTexture9 *iface) wined3d_mutex_lock(); LIST_FOR_EACH_ENTRY(surface, &texture->rtv_list, struct d3d9_surface, rtv_entry) { - wined3d_rendertarget_view_decref(surface->wined3d_rtv); + wined3d_rendertarget_view_incref(surface->wined3d_rtv); } wined3d_texture_incref(texture->wined3d_texture); wined3d_mutex_unlock();

1 0