April 2020 - Wine-Commits - list.winehq.org

Alexandre Julliard : ntdll: Don't abort directory search in single entry mode when a file is ignored.
by Alexandre Julliard April 20, 2020

April 20, 2020

Module: wine Branch: master Commit: fecaa443b5c60f00cbac7116781a396807f416a0 URL: https://source.winehq.org/git/wine.git/?a=commit;h=fecaa443b5c60f00cbac7116… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Mon Apr 20 17:41:12 2020 +0200 ntdll: Don't abort directory search in single entry mode when a file is ignored. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=48960 Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ntdll/directory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/ntdll/directory.c b/dlls/ntdll/directory.c index be55a5a8c1..b8cfe507ed 100644 --- a/dlls/ntdll/directory.c +++ b/dlls/ntdll/directory.c @@ -2008,7 +2008,7 @@ NTSTATUS WINAPI DECLSPEC_HOTPATCH NtQueryDirectoryFile( HANDLE handle, HANDLE ev { status = get_dir_data_entry( data, buffer, io, length, info_class, &last_info ); if (!status || status == STATUS_BUFFER_OVERFLOW) data->pos++; - if (single_entry) break; + if (single_entry && last_info) break; } if (!last_info) status = STATUS_NO_MORE_FILES;

1 0

Roman Pišl : user32/edit: Avoid division by zero during initialization.
by Alexandre Julliard April 20, 2020

April 20, 2020

Module: wine Branch: master Commit: d5e591d3cb55530cab33e5f6114b1519ec286d15 URL: https://source.winehq.org/git/wine.git/?a=commit;h=d5e591d3cb55530cab33e5f6… Author: Roman Pišl <rpisl(a)seznam.cz> Date: Mon Apr 20 12:20:13 2020 +0200 user32/edit: Avoid division by zero during initialization. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=19239 Signed-off-by: Roman Pišl <rpisl(a)seznam.cz> Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/user32/edit.c | 4 +-- dlls/user32/tests/edit.c | 66 ++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 68 insertions(+), 2 deletions(-) diff --git a/dlls/user32/edit.c b/dlls/user32/edit.c index 557a091c0d..aba6a084a2 100644 --- a/dlls/user32/edit.c +++ b/dlls/user32/edit.c @@ -465,7 +465,7 @@ static SCRIPT_STRING_ANALYSIS EDIT_UpdateUniscribeData(EDITSTATE *es, HDC dc, IN static inline INT get_vertical_line_count(EDITSTATE *es) { - INT vlc = (es->format_rect.bottom - es->format_rect.top) / es->line_height; + INT vlc = es->line_height ? (es->format_rect.bottom - es->format_rect.top) / es->line_height : 0; return max(1,vlc); } @@ -1638,7 +1638,7 @@ static void EDIT_UpdateScrollInfo(EDITSTATE *es) si.fMask = SIF_PAGE | SIF_POS | SIF_RANGE | SIF_DISABLENOSCROLL; si.nMin = 0; si.nMax = es->line_count - 1; - si.nPage = (es->format_rect.bottom - es->format_rect.top) / es->line_height; + si.nPage = es->line_height ? (es->format_rect.bottom - es->format_rect.top) / es->line_height : 0; si.nPos = es->y_offset; TRACE("SB_VERT, nMin=%d, nMax=%d, nPage=%d, nPos=%d\n", si.nMin, si.nMax, si.nPage, si.nPos); diff --git a/dlls/user32/tests/edit.c b/dlls/user32/tests/edit.c index e3ed3341d6..2289bbf03f 100644 --- a/dlls/user32/tests/edit.c +++ b/dlls/user32/tests/edit.c @@ -1743,6 +1743,71 @@ static BOOL is_font_installed(const char*name) return ret; } +static WNDPROC orig_class_proc; + +static LRESULT CALLBACK test_class_proc(HWND hwnd, UINT message, WPARAM wParam, LPARAM lParam) +{ + RECT rect; + LRESULT result, r; + + switch (message) + { + case WM_NCCREATE: + result = CallWindowProcA(orig_class_proc, hwnd, message, wParam, lParam); + + memset(&rect, 0, sizeof(rect)); + SendMessageA(hwnd, EM_GETRECT, 0, (LPARAM)&rect); + ok(!rect.right && !rect.bottom, "Invalid size after NCCREATE: %d x %d\n", rect.right, rect.bottom); + + /* test that messages between WM_NCCREATE and WM_CREATE + don't crash or cause unexpected behavior */ + r = SendMessageA(hwnd, EM_SETSEL, 0, 0); + ok(r == 1, "Returned %ld, expected 1.\n", r); + r = SendMessageA(hwnd, WM_SIZE, 0, 0x00100010); + todo_wine ok(r == 1, "Returned %ld, expected 1.\n", r); + + return result; + + case WM_CREATE: + /* test that messages between WM_NCCREATE and WM_CREATE + don't crash or cause unexpected behavior */ + r = SendMessageA(hwnd, EM_SETSEL, 0, 0); + ok(r == 1, "Returned %ld, expected 1.\n", r); + r = SendMessageA(hwnd, WM_SIZE, 0, 0x00100010); + todo_wine ok(r == 1, "Returned %ld, expected 1.\n", r); + + break; + } + + return CallWindowProcA(orig_class_proc, hwnd, message, wParam, lParam); +} + +static void test_initialization(void) +{ + BOOL ret; + ATOM atom; + HWND hwEdit; + WNDCLASSA cls; + + ret = GetClassInfoA(NULL, "Edit", &cls); + ok(ret, "Failed to get class info.\n"); + + orig_class_proc = cls.lpfnWndProc; + cls.lpfnWndProc = test_class_proc; + cls.lpszClassName = "TestClassName"; + + atom = RegisterClassA(&cls); + ok(atom != 0, "Failed to register class.\n"); + + hwEdit = CreateWindowExA(0, (LPCSTR)MAKEINTATOM(atom), "Text Text", + ES_MULTILINE | WS_BORDER | ES_AUTOHSCROLL | ES_AUTOVSCROLL | WS_VSCROLL, + 10, 10, 300, 300, NULL, NULL, hinst, NULL); + ok(hwEdit != NULL, "Failed to create a window.\n"); + + DestroyWindow(hwEdit); + UnregisterClassA((LPCSTR)MAKEINTATOM(atom), hinst); +} + static void test_margins(void) { HWND hwEdit; @@ -3268,6 +3333,7 @@ START_TEST(edit) test_edit_control_6(); test_edit_control_limittext(); test_edit_control_scroll(); + test_initialization(); test_margins(); test_margins_font_change(); test_text_position();

1 0

Gerald Pfeifer : ntdll: Fix call_constructor build on FreeBSD.
by Alexandre Julliard April 20, 2020

April 20, 2020

Module: wine Branch: master Commit: 973138c06891b9ec36c0c6cd6ca593554bb69043 URL: https://source.winehq.org/git/wine.git/?a=commit;h=973138c06891b9ec36c0c6cd… Author: Gerald Pfeifer <gerald(a)pfeifer.com> Date: Sun Apr 19 10:43:44 2020 +0200 ntdll: Fix call_constructor build on FreeBSD. Signed-off-by: Gerald Pfeifer <gerald(a)pfeifer.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ntdll/loader.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/dlls/ntdll/loader.c b/dlls/ntdll/loader.c index c713a5d0a6..b0d5cf46a5 100644 --- a/dlls/ntdll/loader.c +++ b/dlls/ntdll/loader.c @@ -1324,17 +1324,21 @@ static void call_constructors( WINE_MODREF *wm ) void (*init_func)(int, char **, char **) = NULL; void (**init_array)(int, char **, char **) = NULL; ULONG_PTR i, init_arraysz = 0; +#ifdef _WIN64 + const Elf64_Dyn *dyn; +#else + const Elf32_Dyn *dyn; +#endif if (dlinfo( wm->so_handle, RTLD_DI_LINKMAP, &map ) == -1) return; - while (map->l_ld->d_tag) + for (dyn = map->l_ld; dyn->d_tag; dyn++) { - switch (map->l_ld->d_tag) + switch (dyn->d_tag) { - case 0x60009990: init_array = (void *)((char *)map->l_addr + map->l_ld->d_un.d_val); break; - case 0x60009991: init_arraysz = map->l_ld->d_un.d_val; break; - case 0x60009992: init_func = (void *)((char *)map->l_addr + map->l_ld->d_un.d_val); break; + case 0x60009990: init_array = (void *)((char *)map->l_addr + dyn->d_un.d_val); break; + case 0x60009991: init_arraysz = dyn->d_un.d_val; break; + case 0x60009992: init_func = (void *)((char *)map->l_addr + dyn->d_un.d_val); break; } - map->l_ld++; } TRACE( "%s: got init_func %p init_array %p %lu\n", debugstr_us( &wm->ldr.BaseDllName ),

1 0

Paul Gofman : quartz/filesource: Store file size on load.
by Alexandre Julliard April 20, 2020

April 20, 2020

Module: wine Branch: master Commit: e0049050445896a79e1e0a15b1ae6215535c8f2c URL: https://source.winehq.org/git/wine.git/?a=commit;h=e0049050445896a79e1e0a15… Author: Paul Gofman <pgofman(a)codeweavers.com> Date: Mon Apr 20 03:53:20 2020 +0300 quartz/filesource: Store file size on load. Signed-off-by: Paul Gofman <pgofman(a)codeweavers.com> Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/quartz/filesource.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/dlls/quartz/filesource.c b/dlls/quartz/filesource.c index 3b19d6e7df..8983f7317b 100644 --- a/dlls/quartz/filesource.c +++ b/dlls/quartz/filesource.c @@ -64,6 +64,7 @@ struct async_reader LPOLESTR pszFileName; AM_MEDIA_TYPE mt; HANDLE file, port, io_thread; + LARGE_INTEGER file_size; CRITICAL_SECTION sample_cs; BOOL flushing; struct request *requests; @@ -474,6 +475,12 @@ static HRESULT WINAPI FileSource_Load(IFileSourceFilter * iface, LPCOLESTR pszFi return HRESULT_FROM_WIN32(GetLastError()); } + if (!GetFileSizeEx(hFile, &This->file_size)) + { + WARN("Could not get file size.\n"); + return HRESULT_FROM_WIN32(GetLastError()); + } + if (This->pszFileName) { free(This->pszFileName); @@ -883,14 +890,10 @@ static HRESULT WINAPI FileAsyncReader_SyncRead(IAsyncReader *iface, static HRESULT WINAPI FileAsyncReader_Length(IAsyncReader *iface, LONGLONG *total, LONGLONG *available) { struct async_reader *filter = impl_from_IAsyncReader(iface); - DWORD low, high; TRACE("iface %p, total %p, available %p.\n", iface, total, available); - if ((low = GetFileSize(filter->file, &high)) == -1 && GetLastError() != NO_ERROR) - return HRESULT_FROM_WIN32(GetLastError()); - - *available = *total = (LONGLONG)low | (LONGLONG)high << (sizeof(DWORD) * 8); + *available = *total = filter->file_size.QuadPart; return S_OK; }

1 0

Jacek Caban : appwiz.cpl: Explicitly compare strcmp result to 0.
by Alexandre Julliard April 20, 2020

April 20, 2020

Module: wine Branch: master Commit: a2b08874cc2fc805558d416c3499d7cbe36a2170 URL: https://source.winehq.org/git/wine.git/?a=commit;h=a2b08874cc2fc805558d416c… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Mon Apr 20 14:40:11 2020 +0200 appwiz.cpl: Explicitly compare strcmp result to 0. Fixes clang warning: addons.c:318:29: warning: use of logical '&&' with constant operand [-Wconstant-logical-operand] Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/appwiz.cpl/addons.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/appwiz.cpl/addons.c b/dlls/appwiz.cpl/addons.c index c1405d5ec8..d73b72a773 100644 --- a/dlls/appwiz.cpl/addons.c +++ b/dlls/appwiz.cpl/addons.c @@ -321,7 +321,7 @@ static enum install_res install_from_default_dir(void) if (ret == INSTALL_NEXT) ret = install_from_unix_file(INSTALL_DATADIR "/wine/", addon->subdir_name, addon->file_name); - if (ret == INSTALL_NEXT && strcmp(INSTALL_DATADIR, "/usr/share")) + if (ret == INSTALL_NEXT && strcmp(INSTALL_DATADIR, "/usr/share") != 0) ret = install_from_unix_file("/usr/share/wine/", addon->subdir_name, addon->file_name); if (ret == INSTALL_NEXT) ret = install_from_unix_file("/opt/wine/", addon->subdir_name, addon->file_name);

1 0

Hans Leidekker : wbemprox: Implement Win32_VideoController.AdapterCompatibility.
by Alexandre Julliard April 20, 2020

April 20, 2020

Module: wine Branch: master Commit: 550d96b0bf0928ac4dc573f49d2ec2e0c0444fc5 URL: https://source.winehq.org/git/wine.git/?a=commit;h=550d96b0bf0928ac4dc573f4… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Mon Apr 20 10:38:11 2020 +0200 wbemprox: Implement Win32_VideoController.AdapterCompatibility. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=48973 Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wbemprox/builtin.c | 3 +++ dlls/wbemprox/tests/query.c | 1 + 2 files changed, 4 insertions(+) diff --git a/dlls/wbemprox/builtin.c b/dlls/wbemprox/builtin.c index 5035ca7b98..24badb7bf9 100644 --- a/dlls/wbemprox/builtin.c +++ b/dlls/wbemprox/builtin.c @@ -399,6 +399,7 @@ static const struct column col_systemsecurity[] = }; static const struct column col_videocontroller[] = { + { L"AdapterCompatibility", CIM_STRING }, { L"AdapterDACType", CIM_STRING }, { L"AdapterRAM", CIM_UINT32 }, { L"Availability", CIM_UINT16 }, @@ -783,6 +784,7 @@ struct record_systemenclosure }; struct record_videocontroller { + const WCHAR *adapter_compatibility; const WCHAR *adapter_dactype; UINT32 adapter_ram; UINT16 availability; @@ -3842,6 +3844,7 @@ static enum fill_status fill_videocontroller( struct table *table, const struct done: rec = (struct record_videocontroller *)table->data; + rec->adapter_compatibility = L"(Standard display types)"; rec->adapter_dactype = L"Integrated RAMDAC"; rec->adapter_ram = vidmem; rec->availability = 3; /* Running or Full Power */ diff --git a/dlls/wbemprox/tests/query.c b/dlls/wbemprox/tests/query.c index 77aa5ee882..a9b4910ebf 100644 --- a/dlls/wbemprox/tests/query.c +++ b/dlls/wbemprox/tests/query.c @@ -1282,6 +1282,7 @@ static void test_Win32_VideoController( IWbemServices *services ) hr = IEnumWbemClassObject_Next( result, 10000, 1, &obj, &count ); if (hr != S_OK) break; + check_property( obj, L"AdapterCompatibility", VT_BSTR, CIM_STRING ); check_property( obj, L"Availability", VT_I4, CIM_UINT16 ); check_property( obj, L"ConfigManagerErrorCode", VT_I4, CIM_UINT32 ); check_property( obj, L"DriverDate", VT_BSTR, CIM_DATETIME );

1 0

Ziqing Hui : comctl32/tests: Fix ImageList_DrawIndirect() test failures on winxp.
by Alexandre Julliard April 20, 2020

April 20, 2020

Module: wine Branch: master Commit: 47a5cd10907bd30e50e9ae3b8d8460c0c749058a URL: https://source.winehq.org/git/wine.git/?a=commit;h=47a5cd10907bd30e50e9ae3b… Author: Ziqing Hui <zhui(a)codeweavers.com> Date: Mon Apr 20 12:51:01 2020 +0800 comctl32/tests: Fix ImageList_DrawIndirect() test failures on winxp. GetDeviceCaps(BITSPIXEL) is always 32 in our test cases. So we can ignore it. Signed-off-by: Ziqing Hui <zhui(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/comctl32/tests/imagelist.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/dlls/comctl32/tests/imagelist.c b/dlls/comctl32/tests/imagelist.c index 7b22c1ece4..a580906054 100644 --- a/dlls/comctl32/tests/imagelist.c +++ b/dlls/comctl32/tests/imagelist.c @@ -1507,7 +1507,6 @@ static void test_ImageList_DrawIndirect(void) int iImage = -1, iAlphaImage = -1, iTransparentImage = -1; UINT32 *bits = 0; UINT32 maskBits = 0x00000000, inverseMaskBits = 0xFFFFFFFF; - int bpp, broken_value; IImageList *imgl; DWORD flags; HRESULT hr; @@ -1519,7 +1518,6 @@ static void test_ImageList_DrawIndirect(void) ok(hdcDst != 0, "CreateCompatibleDC(0) failed to return a valid DC\n"); if (!hdcDst) return; - bpp = GetDeviceCaps(hdcDst, BITSPIXEL); hbmMask = CreateBitmap(2, 1, 1, 1, &maskBits); ok(hbmMask != 0, "CreateBitmap failed\n"); @@ -1587,12 +1585,10 @@ static void test_ImageList_DrawIndirect(void) check_ImageList_DrawIndirect_fStyle(hdcDst, himl, bits, iAlphaImage, ILD_NORMAL, 0xFFD3E5F7, __LINE__); check_ImageList_DrawIndirect_fStyle(hdcDst, himl, bits, iAlphaImage, ILD_TRANSPARENT, 0xFFD3E5F7, __LINE__); - if (bpp == 16 || bpp == 24) broken_value = 0xFFD4D9DD; - else broken_value = 0xFF9DA8B1; - todo_wine check_ImageList_DrawIndirect_broken(hdcDst, himl, bits, iAlphaImage, ILD_BLEND25, ILS_NORMAL, 0, 0xFFE8F1FA, broken_value, __LINE__); - if (bpp == 16 || bpp == 24) broken_value = 0xFFD4D9DD; - else broken_value = 0xFF8C99A3; - todo_wine check_ImageList_DrawIndirect_broken(hdcDst, himl, bits, iAlphaImage, ILD_BLEND50, ILS_NORMAL, 0, 0xFFE8F1FA, broken_value, __LINE__); + /* broken on winxp */ + todo_wine check_ImageList_DrawIndirect_broken(hdcDst, himl, bits, iAlphaImage, ILD_BLEND25, ILS_NORMAL, 0, 0xFFE8F1FA, 0xFFD4D9DD, __LINE__); + todo_wine check_ImageList_DrawIndirect_broken(hdcDst, himl, bits, iAlphaImage, ILD_BLEND50, ILS_NORMAL, 0, 0xFFE8F1FA, 0xFFB4BDC4, __LINE__); + check_ImageList_DrawIndirect_fStyle(hdcDst, himl, bits, iAlphaImage, ILD_MASK, 0xFFD3E5F7, __LINE__); check_ImageList_DrawIndirect_fStyle(hdcDst, himl, bits, iAlphaImage, ILD_IMAGE, 0xFFD3E5F7, __LINE__);

1 0

Sven Baars : kernelbase: Fix a string leak in CreateProcessInternal (Valgrind).
by Alexandre Julliard April 20, 2020

April 20, 2020

Module: wine Branch: master Commit: a202ecd457d7b13a0534398ca0227e78ad77f7b0 URL: https://source.winehq.org/git/wine.git/?a=commit;h=a202ecd457d7b13a0534398c… Author: Sven Baars <sbaars(a)codeweavers.com> Date: Sat Apr 18 22:06:46 2020 +0200 kernelbase: Fix a string leak in CreateProcessInternal (Valgrind). Signed-off-by: Sven Baars <sbaars(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/kernelbase/process.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/dlls/kernelbase/process.c b/dlls/kernelbase/process.c index b125f100f6..3369180206 100644 --- a/dlls/kernelbase/process.c +++ b/dlls/kernelbase/process.c @@ -182,10 +182,12 @@ static RTL_USER_PROCESS_PARAMETERS *create_process_params( const WCHAR *filename &cmdlineW, envW, &titleW, &desktopW, NULL, &runtimeW, PROCESS_PARAMS_FLAG_NORMALIZED )) { + RtlFreeUnicodeString( &newdirW ); RtlReleasePath( load_path ); if (envW != env) RtlFreeHeap( GetProcessHeap(), 0, envW ); return NULL; } + RtlFreeUnicodeString( &newdirW ); RtlReleasePath( load_path ); if (flags & CREATE_NEW_PROCESS_GROUP) params->ConsoleFlags = 1;

1 0

Hans Leidekker : wbemprox: Use wide character string literals.
by Alexandre Julliard April 20, 2020

April 20, 2020

Module: wine Branch: master Commit: 78e9b02cebf4b107aba69aa9a845ab661a7daf10 URL: https://source.winehq.org/git/wine.git/?a=commit;h=78e9b02cebf4b107aba69aa9… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Mon Apr 20 10:38:10 2020 +0200 wbemprox: Use wide character string literals. Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wbemprox/builtin.c | 1661 ++++++++++++-------------------------- dlls/wbemprox/class.c | 40 +- dlls/wbemprox/process.c | 8 +- dlls/wbemprox/qualifier.c | 31 +- dlls/wbemprox/query.c | 78 +- dlls/wbemprox/reg.c | 42 +- dlls/wbemprox/security.c | 15 +- dlls/wbemprox/service.c | 24 +- dlls/wbemprox/services.c | 24 +- dlls/wbemprox/table.c | 21 +- dlls/wbemprox/wbemlocator.c | 11 +- dlls/wbemprox/wbemprox_private.h | 30 - 12 files changed, 614 insertions(+), 1371 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=78e9b02cebf4b107aba6…

1 0

Owen Rudge : winecfg: Return 0 on success when setting Windows version.
by Alexandre Julliard April 20, 2020

April 20, 2020

Module: wine Branch: master Commit: 7b485dbf68e2ace921a59dcb50ef82d741fb8949 URL: https://source.winehq.org/git/wine.git/?a=commit;h=7b485dbf68e2ace921a59dcb… Author: Owen Rudge <orudge(a)codeweavers.com> Date: Mon Apr 20 12:53:54 2020 +0100 winecfg: Return 0 on success when setting Windows version. The /V switch to winecfg was incorrectly passing the BOOL result through as the application exit code. Signed-off-by: Owen Rudge <orudge(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- programs/winecfg/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/programs/winecfg/main.c b/programs/winecfg/main.c index 735ac02299..74f73a9f23 100644 --- a/programs/winecfg/main.c +++ b/programs/winecfg/main.c @@ -189,7 +189,7 @@ ProcessCmdLine(LPSTR lpCmdLine) } if ((lpCmdLine[1] == 'V' || lpCmdLine[1] == 'v') && (lstrlenA(lpCmdLine) > 4)) { - return set_winver_from_string(&lpCmdLine[3]); + return set_winver_from_string(&lpCmdLine[3]) ? 0 : 1; } if (lpCmdLine[1] == '?')

1 0