June 2020 - Wine-Commits - list.winehq.org

Alexandre Julliard : ntdll: Move searching for builtin dlls to the Unix library.
by Alexandre Julliard June 23, 2020

June 23, 2020

Module: wine Branch: master Commit: 577b3924408cd1ffa7d2559999751a9ced597882 URL: https://source.winehq.org/git/wine.git/?a=commit;h=577b3924408cd1ffa7d25599… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Jun 23 12:32:43 2020 +0200 ntdll: Move searching for builtin dlls to the Unix library. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ntdll/loader.c | 182 +-------------------------------- dlls/ntdll/unix/loader.c | 256 ++++++++++++++++++++++++++++++++++++++++++++++- dlls/ntdll/unixlib.h | 5 +- 3 files changed, 259 insertions(+), 184 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=577b3924408cd1ffa7d2…

1 0

Rémi Bernon : ntdll: Refine NtSetInformationThread ThreadHideFromDebugger stubs.
by Alexandre Julliard June 23, 2020

June 23, 2020

Module: wine Branch: master Commit: 537bb7a8aee278d285cb77669fd9258dfaa3222f URL: https://source.winehq.org/git/wine.git/?a=commit;h=537bb7a8aee278d285cb7766… Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Mon Jun 22 23:27:47 2020 +0200 ntdll: Refine NtSetInformationThread ThreadHideFromDebugger stubs. CoD: Black Ops 3 and CoD: WWII do each one of these calls and terminate if they return unexpected results. Signed-off-by: Rémi Bernon <rbernon(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ntdll/tests/info.c | 27 +++++++++++++++++++++++++++ dlls/ntdll/unix/thread.c | 14 ++++++++++++++ 2 files changed, 41 insertions(+) diff --git a/dlls/ntdll/tests/info.c b/dlls/ntdll/tests/info.c index cf3f7b9f6f..eaf2f1a45b 100644 --- a/dlls/ntdll/tests/info.c +++ b/dlls/ntdll/tests/info.c @@ -2346,6 +2346,7 @@ static void test_affinity(void) DWORD_PTR proc_affinity, thread_affinity; THREAD_BASIC_INFORMATION tbi; SYSTEM_INFO si; + ULONG dummy; GetSystemInfo(&si); status = pNtQueryInformationProcess( GetCurrentProcess(), ProcessBasicInformation, &pbi, sizeof(pbi), NULL ); @@ -2450,6 +2451,32 @@ static void test_affinity(void) ok( status == STATUS_SUCCESS, "Expected STATUS_SUCCESS, got %08x\n", status); ok( tbi.AffinityMask == (1 << si.dwNumberOfProcessors) - 1, "Unexpected thread affinity\n" ); + + dummy = 0; + status = pNtSetInformationThread( GetCurrentThread(), ThreadHideFromDebugger, &dummy, sizeof(ULONG) ); + ok( status == STATUS_INFO_LENGTH_MISMATCH, "Expected STATUS_INFO_LENGTH_MISMATCH, got %08x\n", status ); + dummy = 0; + status = pNtSetInformationThread( GetCurrentThread(), ThreadHideFromDebugger, &dummy, 1 ); + ok( status == STATUS_INFO_LENGTH_MISMATCH, "Expected STATUS_INFO_LENGTH_MISMATCH, got %08x\n", status ); + status = pNtSetInformationThread( (HANDLE)0xdeadbeef, ThreadHideFromDebugger, NULL, 0 ); + ok( status == STATUS_INVALID_HANDLE, "Expected STATUS_INVALID_HANDLE, got %08x\n", status ); + status = pNtSetInformationThread( GetCurrentThread(), ThreadHideFromDebugger, NULL, 0 ); + ok( status == STATUS_SUCCESS, "Expected STATUS_SUCCESS, got %08x\n", status ); + dummy = 0; + status = NtQueryInformationThread( GetCurrentThread(), ThreadHideFromDebugger, &dummy, sizeof(ULONG), NULL ); + if (status == STATUS_INVALID_INFO_CLASS) + win_skip("ThreadHideFromDebugger not available\n"); + else + { + ok( status == STATUS_INFO_LENGTH_MISMATCH, "Expected STATUS_INFO_LENGTH_MISMATCH, got %08x\n", status ); + dummy = 0; + status = NtQueryInformationThread( (HANDLE)0xdeadbeef, ThreadHideFromDebugger, &dummy, sizeof(ULONG), NULL ); + ok( status == STATUS_INFO_LENGTH_MISMATCH, "Expected STATUS_INFO_LENGTH_MISMATCH, got %08x\n", status ); + dummy = 0; + status = NtQueryInformationThread( GetCurrentThread(), ThreadHideFromDebugger, &dummy, 1, NULL ); + ok( status == STATUS_SUCCESS, "Expected STATUS_SUCCESS, got %08x\n", status ); + if (status == STATUS_SUCCESS) ok( dummy == 1, "Expected dummy == 1, got %08x\n", dummy ); + } } static void test_NtGetCurrentProcessorNumber(void) diff --git a/dlls/ntdll/unix/thread.c b/dlls/ntdll/unix/thread.c index d26e0a98ca..2e2e5a3882 100644 --- a/dlls/ntdll/unix/thread.c +++ b/dlls/ntdll/unix/thread.c @@ -831,6 +831,8 @@ NTSTATUS WINAPI NtQueryInformationThread( HANDLE handle, THREADINFOCLASS class, { NTSTATUS status; + TRACE("(%p,%d,%p,%x,%p)\n", handle, class, data, length, ret_len); + switch (class) { case ThreadBasicInformation: @@ -1063,6 +1065,14 @@ NTSTATUS WINAPI NtQueryInformationThread( HANDLE handle, THREADINFOCLASS class, #endif } + case ThreadHideFromDebugger: + if (length != sizeof(BOOLEAN)) return STATUS_INFO_LENGTH_MISMATCH; + if (!data) return STATUS_ACCESS_VIOLATION; + if (handle != GetCurrentThread()) return STATUS_ACCESS_DENIED; + *(BOOLEAN*)data = TRUE; + if (ret_len) *ret_len = sizeof(BOOLEAN); + return STATUS_SUCCESS; + case ThreadPriority: case ThreadBasePriority: case ThreadImpersonationToken: @@ -1088,6 +1098,8 @@ NTSTATUS WINAPI NtSetInformationThread( HANDLE handle, THREADINFOCLASS class, { NTSTATUS status; + TRACE("(%p,%d,%p,%x)\n", handle, class, data, length); + switch (class) { case ThreadZeroTlsCell: @@ -1152,6 +1164,8 @@ NTSTATUS WINAPI NtSetInformationThread( HANDLE handle, THREADINFOCLASS class, } case ThreadHideFromDebugger: + if (length) return STATUS_INFO_LENGTH_MISMATCH; + if (handle != GetCurrentThread()) return STATUS_INVALID_HANDLE; /* pretend the call succeeded to satisfy some code protectors */ return STATUS_SUCCESS;

1 0

Paul Gofman : ntoskrnl/tests: Retry bind if address is in use in test_wsk_listen_socket().
by Alexandre Julliard June 23, 2020

June 23, 2020

Module: wine Branch: master Commit: 8f80ea670da76bca4b5f915d86b91575010e4979 URL: https://source.winehq.org/git/wine.git/?a=commit;h=8f80ea670da76bca4b5f915d… Author: Paul Gofman <pgofman(a)codeweavers.com> Date: Tue Jun 23 00:27:04 2020 +0300 ntoskrnl/tests: Retry bind if address is in use in test_wsk_listen_socket(). Fixes test failures occuring when the tests using the same ports run closely one after another. Signed-off-by: Paul Gofman <pgofman(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ntoskrnl.exe/tests/driver4.c | 30 ++++++++++++++++++------------ 1 file changed, 18 insertions(+), 12 deletions(-) diff --git a/dlls/ntoskrnl.exe/tests/driver4.c b/dlls/ntoskrnl.exe/tests/driver4.c index e11879e9e5..5307674de3 100644 --- a/dlls/ntoskrnl.exe/tests/driver4.c +++ b/dlls/ntoskrnl.exe/tests/driver4.c @@ -265,19 +265,25 @@ static void test_wsk_listen_socket(void) ok(status == STATUS_SUCCESS, "Got unexpected status %#x.\n", status); ok(wsk_irp->IoStatus.Status == STATUS_SUCCESS, "Got unexpected status %#x.\n", wsk_irp->IoStatus.Status); - IoReuseIrp(wsk_irp, STATUS_UNSUCCESSFUL); - IoSetCompletionRoutine(wsk_irp, irp_completion_routine, &irp_complete_event, TRUE, TRUE, TRUE); - wsk_irp->IoStatus.Status = 0xdeadbeef; - wsk_irp->IoStatus.Information = 0xdeadbeef; - status = tcp_dispatch->WskBind(tcp_socket, (SOCKADDR *)&addr, 0, wsk_irp); - ok(status == STATUS_PENDING, "Got unexpected status %#x.\n", status); - status = KeWaitForSingleObject(&irp_complete_event, Executive, KernelMode, FALSE, NULL); - ok(status == STATUS_SUCCESS, "Got unexpected status %#x.\n", status); - ok(wsk_irp->IoStatus.Status == STATUS_SUCCESS, "Got unexpected status %#x.\n", wsk_irp->IoStatus.Status); - ok(!wsk_irp->IoStatus.Information, "Got unexpected Information %#lx.\n", - wsk_irp->IoStatus.Information); + do + { + IoReuseIrp(wsk_irp, STATUS_UNSUCCESSFUL); + IoSetCompletionRoutine(wsk_irp, irp_completion_routine, &irp_complete_event, TRUE, TRUE, TRUE); + wsk_irp->IoStatus.Status = 0xdeadbeef; + wsk_irp->IoStatus.Information = 0xdeadbeef; + status = tcp_dispatch->WskBind(tcp_socket, (SOCKADDR *)&addr, 0, wsk_irp); + ok(status == STATUS_PENDING, "Got unexpected status %#x.\n", status); + status = KeWaitForSingleObject(&irp_complete_event, Executive, KernelMode, FALSE, NULL); + ok(status == STATUS_SUCCESS, "Got unexpected status %#x.\n", status); + ok(wsk_irp->IoStatus.Status == STATUS_SUCCESS + || wsk_irp->IoStatus.Status == STATUS_ADDRESS_ALREADY_ASSOCIATED, + "Got unexpected status %#x.\n", wsk_irp->IoStatus.Status); + ok(!wsk_irp->IoStatus.Information, "Got unexpected Information %#lx.\n", + wsk_irp->IoStatus.Information); + } + while (wsk_irp->IoStatus.Status == STATUS_ADDRESS_ALREADY_ASSOCIATED); - timeout.QuadPart = -1000 * 10000; + timeout.QuadPart = -2000 * 10000; IoReuseIrp(wsk_irp, STATUS_UNSUCCESSFUL); IoSetCompletionRoutine(wsk_irp, irp_completion_routine, &irp_complete_event, TRUE, TRUE, TRUE);

1 0

Paul Gofman : netio.sys: Implement wsk_connect() function.
by Alexandre Julliard June 23, 2020

June 23, 2020

Module: wine Branch: master Commit: af443d730e279a48ec6e37118dc95b51e369cc7a URL: https://source.winehq.org/git/wine.git/?a=commit;h=af443d730e279a48ec6e3711… Author: Paul Gofman <pgofman(a)codeweavers.com> Date: Tue Jun 23 00:27:06 2020 +0300 netio.sys: Implement wsk_connect() function. Signed-off-by: Paul Gofman <pgofman(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/netio.sys/netio.c | 92 ++++++++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 90 insertions(+), 2 deletions(-) diff --git a/dlls/netio.sys/netio.c b/dlls/netio.sys/netio.c index 64ea891087..09f09f1e98 100644 --- a/dlls/netio.sys/netio.c +++ b/dlls/netio.sys/netio.c @@ -53,6 +53,15 @@ struct listen_socket_callback_context SOCKET acceptor; }; +struct connect_socket_callback_context +{ + struct wsk_socket_internal *socket; + SOCKADDR *remote_address; + const void *client_dispatch; + void *client_context; + IRP *pending_irp; +}; + #define MAX_PENDING_IO 10 struct wsk_pending_io @@ -73,6 +82,7 @@ struct wsk_socket_internal ADDRESS_FAMILY address_family; USHORT socket_type; ULONG protocol; + BOOL bound; CRITICAL_SECTION cs_socket; @@ -86,6 +96,8 @@ struct wsk_socket_internal }; static LPFN_ACCEPTEX pAcceptEx; +static LPFN_CONNECTEX pConnectEx; + static const WSK_PROVIDER_CONNECTION_DISPATCH wsk_provider_connection_dispatch; static inline struct wsk_socket_internal *wsk_socket_internal_from_wsk_socket(WSK_SOCKET *wsk_socket) @@ -294,6 +306,9 @@ static NTSTATUS WINAPI wsk_bind(WSK_SOCKET *socket, SOCKADDR *local_address, ULO else status = STATUS_SUCCESS; + if (status == STATUS_SUCCESS) + s->bound = TRUE; + TRACE("status %#x.\n", status); irp->IoStatus.Information = 0; dispatch_irp(irp, status); @@ -468,11 +483,84 @@ static const WSK_PROVIDER_LISTEN_DISPATCH wsk_provider_listen_dispatch = wsk_get_local_address, }; +static void WINAPI connect_callback(TP_CALLBACK_INSTANCE *instance, void *socket_, TP_WAIT *wait, + TP_WAIT_RESULT wait_result) +{ + struct wsk_socket_internal *socket = socket_; + struct wsk_pending_io *io; + DWORD size; + + TRACE("instance %p, socket %p, wait %p, wait_result %#x.\n", instance, socket, wait, wait_result); + + lock_socket(socket); + io = find_pending_io(socket, wait); + + GetOverlappedResult((HANDLE)socket->s, &io->ovr, &size, FALSE); + dispatch_pending_io(io, io->ovr.Internal, 0); + unlock_socket(socket); +} + +static BOOL WINAPI init_connect_functions(INIT_ONCE *once, void *param, void **context) +{ + GUID connectex_guid = WSAID_CONNECTEX; + SOCKET s = (SOCKET)param; + DWORD size; + + if (WSAIoctl(s, SIO_GET_EXTENSION_FUNCTION_POINTER, &connectex_guid, sizeof(connectex_guid), + &pConnectEx, sizeof(pConnectEx), &size, NULL, NULL)) + { + ERR("Could not get AcceptEx address, error %u.\n", WSAGetLastError()); + return FALSE; + } + return TRUE; +} + static NTSTATUS WINAPI wsk_connect(WSK_SOCKET *socket, SOCKADDR *remote_address, ULONG flags, IRP *irp) { - FIXME("socket %p, remote_address %p, flags %#x, irp %p stub.\n", socket, remote_address, flags, irp); + struct wsk_socket_internal *s = wsk_socket_internal_from_wsk_socket(socket); + static INIT_ONCE init_once = INIT_ONCE_STATIC_INIT; + struct wsk_pending_io *io; + int error; - return STATUS_NOT_IMPLEMENTED; + TRACE("socket %p, remote_address %p, flags %#x, irp %p.\n", + socket, remote_address, flags, irp); + + if (!irp) + return STATUS_INVALID_PARAMETER; + + if (!InitOnceExecuteOnce(&init_once, init_connect_functions, (void *)s->s, NULL)) + { + dispatch_irp(irp, STATUS_UNSUCCESSFUL); + return STATUS_PENDING; + } + + lock_socket(s); + + if (!(io = allocate_pending_io(s, connect_callback, irp))) + { + irp->IoStatus.Information = 0; + dispatch_irp(irp, STATUS_UNSUCCESSFUL); + unlock_socket(s); + return STATUS_PENDING; + } + + if (!s->bound) + { + dispatch_pending_io(io, STATUS_INVALID_DEVICE_STATE, 0); + unlock_socket(s); + return STATUS_INVALID_DEVICE_STATE; + } + + if (pConnectEx(s->s, remote_address, sizeof(*remote_address), NULL, 0, NULL, &io->ovr)) + dispatch_pending_io(io, STATUS_SUCCESS, 0); + else if ((error = WSAGetLastError()) == ERROR_IO_PENDING) + SetThreadpoolWait(io->tp_wait, io->ovr.hEvent, NULL); + else + dispatch_pending_io(io, sock_error_to_ntstatus(error), 0); + + unlock_socket(s); + + return STATUS_PENDING; } static NTSTATUS WINAPI wsk_get_remote_address(WSK_SOCKET *socket, SOCKADDR *remote_address, IRP *irp)

1 0

Alexandre Julliard : ntdll: Add a common helper for building a modref.
by Alexandre Julliard June 23, 2020

June 23, 2020

Module: wine Branch: master Commit: 99649d78927bb911b8a9022c8f362e0a7d9c7ea9 URL: https://source.winehq.org/git/wine.git/?a=commit;h=99649d78927bb911b8a9022c… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Jun 23 12:29:19 2020 +0200 ntdll: Add a common helper for building a modref. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ntdll/loader.c | 296 ++++++++++++++++++++++------------------------------ 1 file changed, 127 insertions(+), 169 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=99649d78927bb911b8a9…

1 0

Alexandre Julliard : ntdll: Move the loading of .so dlls to the Unix library.
by Alexandre Julliard June 23, 2020

June 23, 2020

Module: wine Branch: master Commit: 31538a79a90653afb8bc7744506989c8811a800d URL: https://source.winehq.org/git/wine.git/?a=commit;h=31538a79a90653afb8bc7744… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Jun 23 19:39:12 2020 +0200 ntdll: Move the loading of .so dlls to the Unix library. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ntdll/loader.c | 300 ++++++----------------------------------- dlls/ntdll/ntdll_misc.h | 7 - dlls/ntdll/unix/env.c | 19 +-- dlls/ntdll/unix/loader.c | 277 +++++++++++++++++++++++++++++++++---- dlls/ntdll/unix/thread.c | 1 + dlls/ntdll/unix/unix_private.h | 7 +- dlls/ntdll/unix/virtual.c | 9 +- dlls/ntdll/unixlib.h | 11 +- dlls/ntdll/virtual.c | 33 ----- 9 files changed, 314 insertions(+), 350 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=31538a79a90653afb8bc…

1 0

Alistair Leslie-Hughes : directmanipulation: Implement IDirectManipulationPrimaryContent stub interface.
by Alexandre Julliard June 23, 2020

June 23, 2020

Module: wine Branch: master Commit: 302164c759dc42f25e1ed3501845ab86a899f714 URL: https://source.winehq.org/git/wine.git/?a=commit;h=302164c759dc42f25e1ed350… Author: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Date: Fri Aug 23 11:34:16 2019 +1000 directmanipulation: Implement IDirectManipulationPrimaryContent stub interface. Signed-off-by: Vijay Kiran Kamuju <infyquest(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/directmanipulation/directmanipulation.c | 155 ++++++++++++++++++++++++++- 1 file changed, 154 insertions(+), 1 deletion(-) diff --git a/dlls/directmanipulation/directmanipulation.c b/dlls/directmanipulation/directmanipulation.c index fac105a7cd..f901d58aa9 100644 --- a/dlls/directmanipulation/directmanipulation.c +++ b/dlls/directmanipulation/directmanipulation.c @@ -177,6 +177,142 @@ static HRESULT create_update_manager(IDirectManipulationUpdateManager **obj) return S_OK; } + +struct primarycontext +{ + IDirectManipulationPrimaryContent IDirectManipulationPrimaryContent_iface; + LONG ref; +}; + +static inline struct primarycontext *impl_from_IDirectManipulationPrimaryContent(IDirectManipulationPrimaryContent *iface) +{ + return CONTAINING_RECORD(iface, struct primarycontext, IDirectManipulationPrimaryContent_iface); +} + +static HRESULT WINAPI primary_QueryInterface(IDirectManipulationPrimaryContent *iface, REFIID riid, void **ppv) +{ + struct primarycontext *This = impl_from_IDirectManipulationPrimaryContent(iface); + TRACE("(%p)->(%s,%p)\n", This, debugstr_guid(riid), ppv); + + if (IsEqualGUID(riid, &IID_IUnknown) || + IsEqualGUID(riid, &IID_IDirectManipulationPrimaryContent)) + { + IDirectManipulationPrimaryContent_AddRef(&This->IDirectManipulationPrimaryContent_iface); + *ppv = &This->IDirectManipulationPrimaryContent_iface; + return S_OK; + } + + FIXME("(%p)->(%s,%p),not found\n", This, debugstr_guid(riid), ppv); + return E_NOINTERFACE; +} + +static ULONG WINAPI primary_AddRef(IDirectManipulationPrimaryContent *iface) +{ + struct primarycontext *This = impl_from_IDirectManipulationPrimaryContent(iface); + ULONG ref = InterlockedIncrement(&This->ref); + + TRACE("(%p) ref=%u\n", This, ref); + + return ref; +} + +static ULONG WINAPI primary_Release(IDirectManipulationPrimaryContent *iface) +{ + struct primarycontext *This = impl_from_IDirectManipulationPrimaryContent(iface); + ULONG ref = InterlockedDecrement(&This->ref); + + TRACE("(%p) ref=%u\n", This, ref); + + if (!ref) + { + heap_free(This); + } + return ref; +} + +static HRESULT WINAPI primary_SetSnapInterval(IDirectManipulationPrimaryContent *iface, DIRECTMANIPULATION_MOTION_TYPES motion, + float interval, float offset) +{ + struct primarycontext *This = impl_from_IDirectManipulationPrimaryContent(iface); + FIXME("%p, %d, %f, %f\n", This, motion, interval, offset); + return E_NOTIMPL; +} + +static HRESULT WINAPI primary_SetSnapPoints(IDirectManipulationPrimaryContent *iface, DIRECTMANIPULATION_MOTION_TYPES motion, + const float *points, DWORD count) +{ + struct primarycontext *This = impl_from_IDirectManipulationPrimaryContent(iface); + FIXME("%p, %d, %p, %d\n", This, motion, points, count); + return E_NOTIMPL; +} + +static HRESULT WINAPI primary_SetSnapType(IDirectManipulationPrimaryContent *iface, DIRECTMANIPULATION_MOTION_TYPES motion, + DIRECTMANIPULATION_SNAPPOINT_TYPE type) +{ + struct primarycontext *This = impl_from_IDirectManipulationPrimaryContent(iface); + FIXME("%p, %d, %d\n", This, motion, type); + return E_NOTIMPL; +} + +static HRESULT WINAPI primary_SetSnapCoordinate(IDirectManipulationPrimaryContent *iface, DIRECTMANIPULATION_MOTION_TYPES motion, + DIRECTMANIPULATION_SNAPPOINT_COORDINATE coordinate, float origin) +{ + struct primarycontext *This = impl_from_IDirectManipulationPrimaryContent(iface); + FIXME("%p, %d, %d, %f\n", This, motion, coordinate, origin); + return E_NOTIMPL; +} + +static HRESULT WINAPI primary_SetZoomBoundaries(IDirectManipulationPrimaryContent *iface, float minimum, float maximum) +{ + struct primarycontext *This = impl_from_IDirectManipulationPrimaryContent(iface); + FIXME("%p, %f, %f\n", This, minimum, maximum); + return E_NOTIMPL; +} + +static HRESULT WINAPI primary_SetHorizontalAlignment(IDirectManipulationPrimaryContent *iface, DIRECTMANIPULATION_HORIZONTALALIGNMENT alignment) +{ + struct primarycontext *This = impl_from_IDirectManipulationPrimaryContent(iface); + FIXME("%p, %d\n", This, alignment); + return E_NOTIMPL; +} + +static HRESULT WINAPI primary_SetVerticalAlignment(IDirectManipulationPrimaryContent *iface, DIRECTMANIPULATION_VERTICALALIGNMENT alignment) +{ + struct primarycontext *This = impl_from_IDirectManipulationPrimaryContent(iface); + FIXME("%p, %d\n", This, alignment); + return E_NOTIMPL; +} + +static HRESULT WINAPI primary_GetInertiaEndTransform(IDirectManipulationPrimaryContent *iface, float *matrix, DWORD count) +{ + struct primarycontext *This = impl_from_IDirectManipulationPrimaryContent(iface); + FIXME("%p, %p, %d\n", This, matrix, count); + return E_NOTIMPL; +} + +static HRESULT WINAPI primary_GetCenterPoint(IDirectManipulationPrimaryContent *iface, float *x, float *y) +{ + struct primarycontext *This = impl_from_IDirectManipulationPrimaryContent(iface); + FIXME("%p, %p, %p\n", This, x, y); + return E_NOTIMPL; +} + +static const IDirectManipulationPrimaryContentVtbl primaryVtbl = +{ + primary_QueryInterface, + primary_AddRef, + primary_Release, + primary_SetSnapInterval, + primary_SetSnapPoints, + primary_SetSnapType, + primary_SetSnapCoordinate, + primary_SetZoomBoundaries, + primary_SetHorizontalAlignment, + primary_SetVerticalAlignment, + primary_GetInertiaEndTransform, + primary_GetCenterPoint +}; + struct directviewport { IDirectManipulationViewport2 IDirectManipulationViewport2_iface; @@ -327,7 +463,24 @@ static HRESULT WINAPI viewport_SyncDisplayTransform(IDirectManipulationViewport2 static HRESULT WINAPI viewport_GetPrimaryContent(IDirectManipulationViewport2 *iface, REFIID riid, void **object) { struct directviewport *This = impl_from_IDirectManipulationViewport2(iface); - FIXME("%p, %s, %p\n", This, debugstr_guid(riid), object); + TRACE("%p, %s, %p\n", This, debugstr_guid(riid), object); + if(IsEqualGUID(riid, &IID_IDirectManipulationPrimaryContent)) + { + struct primarycontext *primary; + TRACE("IDirectManipulationPrimaryContent\n"); + primary = heap_alloc( sizeof(*primary)); + if(!primary) + return E_OUTOFMEMORY; + + primary->IDirectManipulationPrimaryContent_iface.lpVtbl = &primaryVtbl; + primary->ref = 1; + + *object = &primary->IDirectManipulationPrimaryContent_iface; + + return S_OK; + } + else + FIXME("Unsupported interface %s\n", debugstr_guid(riid)); return E_NOTIMPL; }

1 0

Alistair Leslie-Hughes : directmanipulation: Implement IDirectManipulationContent stub interface.
by Alexandre Julliard June 23, 2020

June 23, 2020

Module: wine Branch: master Commit: 7171a63f06c39b1ec5f5c2933290b8c78dd11745 URL: https://source.winehq.org/git/wine.git/?a=commit;h=7171a63f06c39b1ec5f5c293… Author: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Date: Sun Dec 22 19:35:25 2019 +1100 directmanipulation: Implement IDirectManipulationContent stub interface. Based on patch by Gijs Vermeulen. Signed-off-by: Vijay Kiran Kamuju <infyquest(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/directmanipulation/directmanipulation.c | 110 ++++++++++++++++++++++++++- 1 file changed, 109 insertions(+), 1 deletion(-) diff --git a/dlls/directmanipulation/directmanipulation.c b/dlls/directmanipulation/directmanipulation.c index f901d58aa9..dd2fdda69a 100644 --- a/dlls/directmanipulation/directmanipulation.c +++ b/dlls/directmanipulation/directmanipulation.c @@ -177,10 +177,10 @@ static HRESULT create_update_manager(IDirectManipulationUpdateManager **obj) return S_OK; } - struct primarycontext { IDirectManipulationPrimaryContent IDirectManipulationPrimaryContent_iface; + IDirectManipulationContent IDirectManipulationContent_iface; LONG ref; }; @@ -189,6 +189,11 @@ static inline struct primarycontext *impl_from_IDirectManipulationPrimaryContent return CONTAINING_RECORD(iface, struct primarycontext, IDirectManipulationPrimaryContent_iface); } +static inline struct primarycontext *impl_from_IDirectManipulationContent(IDirectManipulationContent *iface) +{ + return CONTAINING_RECORD(iface, struct primarycontext, IDirectManipulationContent_iface); +} + static HRESULT WINAPI primary_QueryInterface(IDirectManipulationPrimaryContent *iface, REFIID riid, void **ppv) { struct primarycontext *This = impl_from_IDirectManipulationPrimaryContent(iface); @@ -201,6 +206,12 @@ static HRESULT WINAPI primary_QueryInterface(IDirectManipulationPrimaryContent * *ppv = &This->IDirectManipulationPrimaryContent_iface; return S_OK; } + else if(IsEqualGUID(riid, &IID_IDirectManipulationContent)) + { + IUnknown_AddRef(iface); + *ppv = &This->IDirectManipulationContent_iface; + return S_OK; + } FIXME("(%p)->(%s,%p),not found\n", This, debugstr_guid(riid), ppv); return E_NOINTERFACE; @@ -313,6 +324,102 @@ static const IDirectManipulationPrimaryContentVtbl primaryVtbl = primary_GetCenterPoint }; + +static HRESULT WINAPI content_QueryInterface(IDirectManipulationContent *iface, REFIID riid, void **ppv) +{ + struct primarycontext *This = impl_from_IDirectManipulationContent(iface); + TRACE("(%p)->(%s,%p)\n", This, debugstr_guid(riid), ppv); + + return IDirectManipulationPrimaryContent_QueryInterface(&This->IDirectManipulationPrimaryContent_iface, + riid, ppv); +} + +static ULONG WINAPI content_AddRef(IDirectManipulationContent *iface) +{ + struct primarycontext *This = impl_from_IDirectManipulationContent(iface); + return IDirectManipulationPrimaryContent_AddRef(&This->IDirectManipulationPrimaryContent_iface); +} + +static ULONG WINAPI content_Release(IDirectManipulationContent *iface) +{ + struct primarycontext *This = impl_from_IDirectManipulationContent(iface); + return IDirectManipulationPrimaryContent_Release(&This->IDirectManipulationPrimaryContent_iface); +} + +static HRESULT WINAPI content_GetContentRect(IDirectManipulationContent *iface, RECT *size) +{ + struct primarycontext *This = impl_from_IDirectManipulationContent(iface); + FIXME("%p, %p\n", This, size); + return E_NOTIMPL; +} + +static HRESULT WINAPI content_SetContentRect(IDirectManipulationContent *iface, const RECT *size) +{ + struct primarycontext *This = impl_from_IDirectManipulationContent(iface); + FIXME("%p, %p\n", This, size); + return E_NOTIMPL; +} + +static HRESULT WINAPI content_GetViewport(IDirectManipulationContent *iface, REFIID riid, void **object) +{ + struct primarycontext *This = impl_from_IDirectManipulationContent(iface); + FIXME("%p, %p, %p\n", This, debugstr_guid(riid), object); + return E_NOTIMPL; +} + +static HRESULT WINAPI content_GetTag(IDirectManipulationContent *iface, REFIID riid, void **object, UINT32 *id) +{ + struct primarycontext *This = impl_from_IDirectManipulationContent(iface); + FIXME("%p, %p, %p, %p\n", This, debugstr_guid(riid), object, id); + return E_NOTIMPL; +} + +static HRESULT WINAPI content_SetTag(IDirectManipulationContent *iface, IUnknown *object, UINT32 id) +{ + struct primarycontext *This = impl_from_IDirectManipulationContent(iface); + FIXME("%p, %p, %d\n", This, object, id); + return E_NOTIMPL; +} + +static HRESULT WINAPI content_GetOutputTransform(IDirectManipulationContent *iface, + float *matrix, DWORD count) +{ + struct primarycontext *This = impl_from_IDirectManipulationContent(iface); + FIXME("%p, %p, %d\n", This, matrix, count); + return E_NOTIMPL; +} + +static HRESULT WINAPI content_GetContentTransform(IDirectManipulationContent *iface, + float *matrix, DWORD count) +{ + struct primarycontext *This = impl_from_IDirectManipulationContent(iface); + FIXME("%p, %p, %d\n", This, matrix, count); + return E_NOTIMPL; +} + +static HRESULT WINAPI content_SyncContentTransform(IDirectManipulationContent *iface, + const float *matrix, DWORD count) +{ + struct primarycontext *This = impl_from_IDirectManipulationContent(iface); + FIXME("%p, %p, %d\n", This, matrix, count); + return E_NOTIMPL; +} + +static const IDirectManipulationContentVtbl contentVtbl = +{ + content_QueryInterface, + content_AddRef, + content_Release, + content_GetContentRect, + content_SetContentRect, + content_GetViewport, + content_GetTag, + content_SetTag, + content_GetOutputTransform, + content_GetContentTransform, + content_SyncContentTransform +}; + struct directviewport { IDirectManipulationViewport2 IDirectManipulationViewport2_iface; @@ -473,6 +580,7 @@ static HRESULT WINAPI viewport_GetPrimaryContent(IDirectManipulationViewport2 *i return E_OUTOFMEMORY; primary->IDirectManipulationPrimaryContent_iface.lpVtbl = &primaryVtbl; + primary->IDirectManipulationContent_iface.lpVtbl = &contentVtbl; primary->ref = 1; *object = &primary->IDirectManipulationPrimaryContent_iface;

1 0

Nikolay Sivov : dxva2: Implement DXVA2CreateVideoService().
by Alexandre Julliard June 23, 2020

June 23, 2020

Module: wine Branch: master Commit: e0b5edf8964ed320fb628cd97bd1bf9b0aa90b0e URL: https://source.winehq.org/git/wine.git/?a=commit;h=e0b5edf8964ed320fb628cd9… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Tue Jun 23 14:31:17 2020 +0300 dxva2: Implement DXVA2CreateVideoService(). Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/dxva2/main.c | 38 ++++++++++++++++++++++++++------------ dlls/dxva2/tests/dxva2.c | 44 +++++++++++++++++++++++++++++++++++++++++++- 2 files changed, 69 insertions(+), 13 deletions(-) diff --git a/dlls/dxva2/main.c b/dlls/dxva2/main.c index 7ba8d9806b..bbee697674 100644 --- a/dlls/dxva2/main.c +++ b/dlls/dxva2/main.c @@ -101,6 +101,7 @@ static HRESULT WINAPI device_manager_processor_service_QueryInterface(IDirectXVi REFIID riid, void **obj) { if (IsEqualIID(riid, &IID_IDirectXVideoProcessorService) || + IsEqualIID(riid, &IID_IDirectXVideoAccelerationService) || IsEqualIID(riid, &IID_IUnknown)) { *obj = iface; @@ -401,16 +402,9 @@ static HRESULT WINAPI device_manager_GetVideoService(IDirect3DDeviceManager9 *if hr = DXVA2_E_NEW_VIDEO_DEVICE; else if (!(flags & HANDLE_FLAG_OPEN)) hr = E_HANDLE; - else if (IsEqualIID(riid, &IID_IDirectXVideoProcessorService)) - { - *obj = &manager->IDirectXVideoProcessorService_iface; - IUnknown_AddRef((IUnknown *)*obj); - } else - { - WARN("Unsupported service %s.\n", debugstr_guid(riid)); - hr = E_UNEXPECTED; - } + hr = IDirectXVideoProcessorService_QueryInterface(&manager->IDirectXVideoProcessorService_iface, + riid, obj); } LeaveCriticalSection(&manager->cs); @@ -462,11 +456,31 @@ HRESULT WINAPI DXVA2CreateDirect3DDeviceManager9(UINT *token, IDirect3DDeviceMan return S_OK; } -HRESULT WINAPI DXVA2CreateVideoService( IDirect3DDevice9 *device, REFIID riid, void **ppv ) +HRESULT WINAPI DXVA2CreateVideoService(IDirect3DDevice9 *device, REFIID riid, void **obj) { - FIXME("(%p, %s, %p): stub\n", device, debugstr_guid(riid), ppv); + IDirect3DDeviceManager9 *manager; + HANDLE handle; + HRESULT hr; + UINT token; - return E_NOTIMPL; + TRACE("%p, %s, %p.\n", device, debugstr_guid(riid), obj); + + if (FAILED(hr = DXVA2CreateDirect3DDeviceManager9(&token, &manager))) + return hr; + + if (FAILED(hr = IDirect3DDeviceManager9_ResetDevice(manager, device, token))) + goto done; + + if (FAILED(hr = IDirect3DDeviceManager9_OpenDeviceHandle(manager, &handle))) + goto done; + + hr = IDirect3DDeviceManager9_GetVideoService(manager, handle, riid, obj); + IDirect3DDeviceManager9_CloseDeviceHandle(manager, handle); + +done: + IDirect3DDeviceManager9_Release(manager); + + return hr; } BOOL WINAPI DegaussMonitor( HMONITOR monitor ) diff --git a/dlls/dxva2/tests/dxva2.c b/dlls/dxva2/tests/dxva2.c index 65771fb587..e3e8dd2e66 100644 --- a/dlls/dxva2/tests/dxva2.c +++ b/dlls/dxva2/tests/dxva2.c @@ -62,8 +62,10 @@ static IDirect3DDevice9 *create_device(IDirect3D9 *d3d9, HWND focus_window) static void test_device_manager(void) { IDirectXVideoProcessorService *processor_service; - IDirect3DDevice9 *device, *device2; + IDirectXVideoAccelerationService *accel_service; + IDirect3DDevice9 *device, *device2, *device3; IDirect3DDeviceManager9 *manager; + IDirect3DSurface9 *surface; int refcount, refcount2; HANDLE handle, handle1; IDirect3D9 *d3d; @@ -148,6 +150,46 @@ static void test_device_manager(void) hr = IDirect3DDeviceManager9_TestDevice(manager, handle); ok(hr == DXVA2_E_NEW_VIDEO_DEVICE, "Unexpected hr %#x.\n", hr); + /* Acceleration service. */ + hr = DXVA2CreateVideoService(device, &IID_IDirectXVideoAccelerationService, (void **)&accel_service); + ok(hr == S_OK, "Unexpected hr %#x.\n", hr); + + hr = IDirectXVideoAccelerationService_CreateSurface(accel_service, 64, 64, 1, D3DFMT_X8R8G8B8, + D3DPOOL_DEFAULT, 0, DXVA2_VideoProcessorRenderTarget, &surface, NULL); +todo_wine + ok(hr == S_OK, "Failed to create a surface, hr %#x.\n", hr); + if (SUCCEEDED(hr)) + IDirect3DSurface9_Release(surface); + + IDirectXVideoAccelerationService_Release(accel_service); + + hr = IDirect3DDeviceManager9_OpenDeviceHandle(manager, &handle); + ok(hr == S_OK, "Unexpected hr %#x.\n", hr); + + hr = IDirect3DDeviceManager9_GetVideoService(manager, handle, &IID_IDirectXVideoAccelerationService, + (void **)&accel_service); + ok(hr == S_OK, "Unexpected hr %#x.\n", hr); + + hr = IDirect3DDeviceManager9_CloseDeviceHandle(manager, handle); + ok(hr == S_OK, "Unexpected hr %#x.\n", hr); + + hr = IDirectXVideoAccelerationService_CreateSurface(accel_service, 64, 64, 1, D3DFMT_X8R8G8B8, + D3DPOOL_DEFAULT, 0, DXVA2_VideoProcessorRenderTarget, &surface, NULL); +todo_wine + ok(hr == S_OK, "Failed to create a surface, hr %#x.\n", hr); + + if (SUCCEEDED(hr)) + { + hr = IDirect3DSurface9_GetDevice(surface, &device3); + ok(hr == S_OK, "Unexpected hr %#x.\n", hr); + ok(device2 == device3, "Unexpected device.\n"); + IDirect3DDevice9_Release(device3); + + IDirect3DSurface9_Release(surface); + } + + IDirectXVideoAccelerationService_Release(accel_service); + IDirect3DDevice9_Release(device); IDirect3DDevice9_Release(device2);

1 0

Huw Davies : user32: Use a default name for winstations created or opened with no name.
by Alexandre Julliard June 23, 2020

June 23, 2020

Module: wine Branch: master Commit: 6e69e512d8bdca853adb6f58411ac7261dd7aaef URL: https://source.winehq.org/git/wine.git/?a=commit;h=6e69e512d8bdca853adb6f58… Author: Huw Davies <huw(a)codeweavers.com> Date: Tue Jun 23 12:56:39 2020 +0100 user32: Use a default name for winstations created or opened with no name. The default is of the form "Service-0x<luid high>-<luid low>$" where the luid in question is the logon session luid. Signed-off-by: Huw Davies <huw(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/user32/tests/winstation.c | 24 +++++++++++++++++++----- dlls/user32/winstation.c | 34 ++++++++++++++++++++++++++++++++++ 2 files changed, 53 insertions(+), 5 deletions(-) diff --git a/dlls/user32/tests/winstation.c b/dlls/user32/tests/winstation.c index 4aa5565b96..d239ead6e9 100644 --- a/dlls/user32/tests/winstation.c +++ b/dlls/user32/tests/winstation.c @@ -118,9 +118,10 @@ static void test_handles(void) HANDLE hthread; DWORD id, flags, le; ATOM atom; - char buffer[20]; + char buffer[29], default_name[29] = ""; DWORD size; BOOL ret; + TOKEN_STATISTICS token_stats; /* win stations */ @@ -215,7 +216,6 @@ static void test_handles(void) SetLastError( 0xdeadbeef ); w2 = OpenWindowStationA( "", TRUE, WINSTA_ALL_ACCESS ); ok( !w2, "open station succeeded\n" ); - todo_wine ok( GetLastError() == ERROR_FILE_NOT_FOUND, "wrong error %u\n", GetLastError() ); SetLastError( 0xdeadbeef ); @@ -225,16 +225,30 @@ static void test_handles(void) memset( buffer, 0, sizeof(buffer) ); ret = GetUserObjectInformationA( w2, UOI_NAME, buffer, sizeof(buffer), &size ); ok( ret, "GetUserObjectInformationA failed with error %u\n", GetLastError() ); - todo_wine ok( !memcmp(buffer, "Service-0x0-", 12), "unexpected window station name '%s'\n", buffer ); - todo_wine ok( buffer[strlen(buffer) - 1] == '$', "unexpected window station name '%s'\n", buffer ); + /* Get the logon session LUID */ + ret = GetTokenInformation( GetCurrentProcessToken(), TokenStatistics, &token_stats, sizeof(token_stats), NULL ); + if (ret) + sprintf( default_name, "Service-0x%x-%x$", token_stats.AuthenticationId.HighPart, + token_stats.AuthenticationId.LowPart ); + if (*default_name) + ok( !strcmp( buffer, default_name ), "unexpected window station name '%s' expected '%s'\n", buffer, default_name ); SetLastError( 0xdeadbeef ); w3 = OpenWindowStationA( "", TRUE, WINSTA_ALL_ACCESS ); - todo_wine ok( w3 != 0, "open station failed err %u\n", GetLastError() ); CloseWindowStation( w3 ); CloseWindowStation( w2 ); + w2 = CreateWindowStationA( NULL, 0, WINSTA_ALL_ACCESS, NULL ); + ok( w2 != 0, "create station failed err %u\n", GetLastError() ); + + memset( buffer, 0, sizeof(buffer) ); + ret = GetUserObjectInformationA( w2, UOI_NAME, buffer, sizeof(buffer), &size ); + ok( ret, "GetUserObjectInformationA failed with error %u\n", GetLastError() ); + if (*default_name) + ok( !strcmp( buffer, default_name ), "unexpected window station name '%s' expected '%s'\n", buffer, default_name ); + CloseWindowStation( w2 ); + SetLastError( 0xdeadbeef ); w2 = CreateWindowStationA( "foo\\bar", 0, WINSTA_ALL_ACCESS, NULL ); ok( !w2, "create station succeeded\n" ); diff --git a/dlls/user32/winstation.c b/dlls/user32/winstation.c index 4f53b43bd6..b5d5a372fa 100644 --- a/dlls/user32/winstation.c +++ b/dlls/user32/winstation.c @@ -80,6 +80,30 @@ static HANDLE get_winstations_dir_handle(void) return handle; } +static BOOL WINAPI winstation_default_name_once( INIT_ONCE *once, void *param, void **context ) +{ + static const WCHAR fmt[] = {'S','e','r','v','i','c','e','-','0','x','%','x','-','%','x','$',0}; + WCHAR *name = (WCHAR *)param; + TOKEN_STATISTICS stats; + BOOL ret; + + ret = GetTokenInformation( GetCurrentProcessToken(), TokenStatistics, &stats, sizeof(stats), NULL ); + if (ret) + sprintfW( name, fmt, stats.AuthenticationId.HighPart, stats.AuthenticationId.LowPart ); + + return ret; +} + +static const WCHAR *get_winstation_default_name( void ) +{ + static INIT_ONCE once = INIT_ONCE_STATIC_INIT; + static WCHAR name[29]; + BOOL ret; + + ret = InitOnceExecuteOnce( &once, winstation_default_name_once, name, NULL ); + return ret ? name : NULL; +} + /*********************************************************************** * CreateWindowStationA (USER32.@) */ @@ -113,6 +137,11 @@ HWINSTA WINAPI CreateWindowStationW( LPCWSTR name, DWORD flags, ACCESS_MASK acce SetLastError( ERROR_FILENAME_EXCED_RANGE ); return 0; } + if (!len) + { + name = get_winstation_default_name(); + len = strlenW( name ); + } SERVER_START_REQ( create_winstation ) { req->flags = 0; @@ -160,6 +189,11 @@ HWINSTA WINAPI OpenWindowStationW( LPCWSTR name, BOOL inherit, ACCESS_MASK acces SetLastError( ERROR_FILENAME_EXCED_RANGE ); return 0; } + if (!len) + { + name = get_winstation_default_name(); + len = strlenW( name ); + } SERVER_START_REQ( open_winstation ) { req->access = access;

1 0