July 2020 - Wine-Commits - list.winehq.org

Alexandre Julliard : ntdll: Use syscall thunks for keyed event functions.
by Alexandre Julliard July 17, 2020

July 17, 2020

Module: wine Branch: master Commit: eb45a75a2e76e9716d08ae35cc2512b02e3bf85d URL: https://source.winehq.org/git/wine.git/?a=commit;h=eb45a75a2e76e9716d08ae35… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Thu Jul 16 10:31:21 2020 +0200 ntdll: Use syscall thunks for keyed event functions. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ntdll/ntdll.spec | 16 ++++++++-------- dlls/ntdll/sync.c | 35 ----------------------------------- dlls/ntdll/unix/loader.c | 4 ---- dlls/ntdll/unixlib.h | 10 +--------- 4 files changed, 9 insertions(+), 56 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=eb45a75a2e76e9716d08…

1 0

Puetz Kevin A : include: Use unsigned int in InlineIsEqualGUID.
by Alexandre Julliard July 17, 2020

July 17, 2020

Module: wine Branch: master Commit: aa4f8daf999c31025c076c031dfffb7c3de5b473 URL: https://source.winehq.org/git/wine.git/?a=commit;h=aa4f8daf999c31025c076c03… Author: Puetz Kevin A <PuetzKevinA(a)JohnDeere.com> Date: Thu Jul 16 21:15:38 2020 +0200 include: Use unsigned int in InlineIsEqualGUID. This fixes stand-alone inclusion of <guiddef.h> (without first including <basetsd.h>). Signed-off-by: Kevin Puetz <PuetzKevinA(a)JohnDeere.com> Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- include/guiddef.h | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/include/guiddef.h b/include/guiddef.h index 664f74fac3..a25b3a7107 100644 --- a/include/guiddef.h +++ b/include/guiddef.h @@ -156,18 +156,18 @@ typedef GUID FMTID,*LPFMTID; #define IsEqualGUID(rguid1, rguid2) (!memcmp(&(rguid1), &(rguid2), sizeof(GUID))) inline int InlineIsEqualGUID(REFGUID rguid1, REFGUID rguid2) { - return (((ULONG *)&rguid1)[0] == ((ULONG *)&rguid2)[0] && - ((ULONG *)&rguid1)[1] == ((ULONG *)&rguid2)[1] && - ((ULONG *)&rguid1)[2] == ((ULONG *)&rguid2)[2] && - ((ULONG *)&rguid1)[3] == ((ULONG *)&rguid2)[3]); + return (((unsigned int *)&rguid1)[0] == ((unsigned int *)&rguid2)[0] && + ((unsigned int *)&rguid1)[1] == ((unsigned int *)&rguid2)[1] && + ((unsigned int *)&rguid1)[2] == ((unsigned int *)&rguid2)[2] && + ((unsigned int *)&rguid1)[3] == ((unsigned int *)&rguid2)[3]); } #else #define IsEqualGUID(rguid1, rguid2) (!memcmp(rguid1, rguid2, sizeof(GUID))) #define InlineIsEqualGUID(rguid1, rguid2) \ - (((ULONG *)rguid1)[0] == ((ULONG *)rguid2)[0] && \ - ((ULONG *)rguid1)[1] == ((ULONG *)rguid2)[1] && \ - ((ULONG *)rguid1)[2] == ((ULONG *)rguid2)[2] && \ - ((ULONG *)rguid1)[3] == ((ULONG *)rguid2)[3]) + (((unsigned int *)rguid1)[0] == ((unsigned int *)rguid2)[0] && \ + ((unsigned int *)rguid1)[1] == ((unsigned int *)rguid2)[1] && \ + ((unsigned int *)rguid1)[2] == ((unsigned int *)rguid2)[2] && \ + ((unsigned int *)rguid1)[3] == ((unsigned int *)rguid2)[3]) #endif #ifdef __cplusplus

1 0

Puetz Kevin A : include: Use __typeof__ so <guiddef.h> is compatible with -std=c++11.
by Alexandre Julliard July 17, 2020

July 17, 2020

Module: wine Branch: master Commit: ea90e1ce0d09620826611bde51b4c84212b93d88 URL: https://source.winehq.org/git/wine.git/?a=commit;h=ea90e1ce0d09620826611bde… Author: Puetz Kevin A <PuetzKevinA(a)JohnDeere.com> Date: Wed Jul 15 13:06:28 2020 +0000 include: Use __typeof__ so <guiddef.h> is compatible with -std=c++11. The typeof(...) extension is available in -std=gnu++11, but c++11 considers it replaced by decltype(...) and off-by-default __uuidof does need GNU __typeof__(), not decltype(), for c++03 support and because both __uuidof(typename) and __uuidof(expression) should work, but decltype(typename) is not accepted. Signed-off-by: Kevin Puetz <PuetzKevinA(a)JohnDeere.com> Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- include/guiddef.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/guiddef.h b/include/guiddef.h index 546c450043..664f74fac3 100644 --- a/include/guiddef.h +++ b/include/guiddef.h @@ -74,7 +74,7 @@ extern "C++" { __WINE_UUID_ATTR const GUID __wine_uuidof<type>::uuid = {l,w1,w2,{b1,b2,b3,b4,b5,b6,b7,b8}}; \ } -#define __uuidof(type) __wine_uuidof_type<typeof(type)>::inst::uuid +#define __uuidof(type) __wine_uuidof_type<__typeof__(type)>::inst::uuid #else /* __WINE_UUID_ATTR */

1 0

Zebediah Figura : quartz/tests: Add some tests for media types for the DirectSound renderer.
by Alexandre Julliard July 17, 2020

July 17, 2020

Module: wine Branch: master Commit: 1af01ac91717223adf09c4b61d7d0217ec0ccec5 URL: https://source.winehq.org/git/wine.git/?a=commit;h=1af01ac91717223adf09c4b6… Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Wed Jul 15 22:57:15 2020 -0500 quartz/tests: Add some tests for media types for the DirectSound renderer. Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/quartz/tests/Makefile.in | 2 +- dlls/quartz/tests/dsoundrender.c | 118 +++++++++++++++++++++++++++++++++++++++ 2 files changed, 119 insertions(+), 1 deletion(-) diff --git a/dlls/quartz/tests/Makefile.in b/dlls/quartz/tests/Makefile.in index 7652baf274..b4a372d4d3 100644 --- a/dlls/quartz/tests/Makefile.in +++ b/dlls/quartz/tests/Makefile.in @@ -1,5 +1,5 @@ TESTDLL = quartz.dll -IMPORTS = strmbase advapi32 d3d9 msdmo msvfw32 ole32 oleaut32 user32 uuid +IMPORTS = strmbase advapi32 d3d9 dsound msdmo msvfw32 ole32 oleaut32 user32 uuid C_SRCS = \ acmwrapper.c \ diff --git a/dlls/quartz/tests/dsoundrender.c b/dlls/quartz/tests/dsoundrender.c index ecff4b7c88..3add14d043 100644 --- a/dlls/quartz/tests/dsoundrender.c +++ b/dlls/quartz/tests/dsoundrender.c @@ -24,6 +24,7 @@ #include "initguid.h" #include "dsound.h" #include "amaudio.h" +#include "mmreg.h" #include "wine/test.h" static const WCHAR sink_id[] = L"Audio Input pin (rendered)"; @@ -685,6 +686,122 @@ static void test_unconnected_filter_state(void) ok(!ref, "Got outstanding refcount %d.\n", ref); } +static HRESULT does_dsound_support_format(WAVEFORMATEX *format) +{ + const DSBUFFERDESC desc = + { + .dwSize = sizeof(DSBUFFERDESC), + .dwBufferBytes = format->nAvgBytesPerSec, + .lpwfxFormat = format, + }; + IDirectSoundBuffer *buffer; + IDirectSound *dsound; + HRESULT hr; + + hr = DirectSoundCreate(NULL, &dsound, NULL); + ok(hr == S_OK, "Got hr %#x.\n", hr); + + hr = IDirectSound_CreateSoundBuffer(dsound, &desc, &buffer, NULL); + if (hr == S_OK) + IDirectSoundBuffer_Release(buffer); + IDirectSound_Release(dsound); + + return hr == S_OK ? S_OK : S_FALSE; +} + +static void test_media_types(void) +{ + IBaseFilter *filter = create_dsound_render(); + AM_MEDIA_TYPE *mt, req_mt = {{0}}; + IEnumMediaTypes *enummt; + WAVEFORMATEX wfx = {0}; + HRESULT hr, expect_hr; + unsigned int i, j; + WORD channels; + ULONG ref; + IPin *pin; + + static const DWORD sample_rates[] = {8000, 11025, 12000, 16000, 22050, 24000, 32000, 44100, 48000, 96000}; + + static const struct + { + WORD tag; + WORD depth; + } formats[] = + { + {WAVE_FORMAT_PCM, 8}, + {WAVE_FORMAT_PCM, 16}, + {WAVE_FORMAT_PCM, 24}, + {WAVE_FORMAT_PCM, 32}, + {WAVE_FORMAT_IEEE_FLOAT, 32}, + {WAVE_FORMAT_IEEE_FLOAT, 64}, + }; + + IBaseFilter_FindPin(filter, sink_id, &pin); + + hr = IPin_EnumMediaTypes(pin, &enummt); + ok(hr == S_OK, "Got hr %#x.\n", hr); + + hr = IEnumMediaTypes_Next(enummt, 1, &mt, NULL); + todo_wine ok(hr == S_OK, "Got hr %#x.\n", hr); + if (hr == S_OK) + { + ok(IsEqualGUID(&mt->majortype, &MEDIATYPE_Audio), "Got major type %s.\n", wine_dbgstr_guid(&mt->majortype)); + ok(IsEqualGUID(&mt->subtype, &GUID_NULL), "Got subtype %s.\n", wine_dbgstr_guid(&mt->subtype)); + ok(mt->bFixedSizeSamples == TRUE, "Got fixed size %d.\n", mt->bFixedSizeSamples); + ok(!mt->bTemporalCompression, "Got temporal compression %d.\n", mt->bTemporalCompression); + ok(mt->lSampleSize == 1, "Got sample size %u.\n", mt->lSampleSize); + ok(IsEqualGUID(&mt->formattype, &GUID_NULL), "Got format type %s.\n", wine_dbgstr_guid(&mt->formattype)); + ok(!mt->pUnk, "Got pUnk %p.\n", mt->pUnk); + ok(!mt->cbFormat, "Got format size %u.\n", mt->cbFormat); + ok(!mt->pbFormat, "Got unexpected format block.\n"); + + hr = IPin_QueryAccept(pin, mt); + ok(hr == S_FALSE, "Got hr %#x.\n", hr); + + CoTaskMemFree(mt); + } + + hr = IEnumMediaTypes_Next(enummt, 1, &mt, NULL); + ok(hr == S_FALSE, "Got hr %#x.\n", hr); + + req_mt.majortype = MEDIATYPE_Audio; + req_mt.formattype = FORMAT_WaveFormatEx; + req_mt.cbFormat = sizeof(WAVEFORMATEX); + req_mt.pbFormat = (BYTE *)&wfx; + + IEnumMediaTypes_Release(enummt); + + for (channels = 1; channels <= 2; ++channels) + { + wfx.nChannels = channels; + + for (i = 0; i < ARRAY_SIZE(formats); ++i) + { + wfx.wFormatTag = formats[i].tag; + wfx.wBitsPerSample = formats[i].depth; + wfx.nBlockAlign = wfx.nChannels * wfx.wBitsPerSample / 8; + for (j = 0; j < ARRAY_SIZE(sample_rates); ++j) + { + wfx.nSamplesPerSec = sample_rates[j]; + wfx.nAvgBytesPerSec = wfx.nSamplesPerSec * wfx.nBlockAlign; + + expect_hr = does_dsound_support_format(&wfx); + + hr = IPin_QueryAccept(pin, &req_mt); + todo_wine_if (expect_hr == S_OK) + ok(hr == expect_hr, "Expected hr %#x, got %#x, for %d channels, %d-bit %s, %d Hz.\n", + expect_hr, hr, channels, formats[i].depth, + formats[i].tag == WAVE_FORMAT_PCM ? "integer" : "float", sample_rates[j]); + } + } + } + + IPin_Release(pin); + ref = IBaseFilter_Release(filter); + ok(!ref, "Got outstanding refcount %d.\n", ref); +} + START_TEST(dsoundrender) { IBaseFilter *filter; @@ -712,6 +829,7 @@ START_TEST(dsoundrender) test_basic_audio(); test_enum_media_types(); test_unconnected_filter_state(); + test_media_types(); test_basefilter(); CoUninitialize();

1 0

Zebediah Figura : quartz/dsoundrender: Don't check the subtype in DSoundRender_CheckMediaType().
by Alexandre Julliard July 17, 2020

July 17, 2020

Module: wine Branch: master Commit: 3d54a77af8c7fbc1aefb3182fc6e3d902314a38a URL: https://source.winehq.org/git/wine.git/?a=commit;h=3d54a77af8c7fbc1aefb3182… Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Wed Jul 15 22:57:16 2020 -0500 quartz/dsoundrender: Don't check the subtype in DSoundRender_CheckMediaType(). Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/quartz/dsoundrender.c | 3 --- dlls/quartz/tests/dsoundrender.c | 7 +++---- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/dlls/quartz/dsoundrender.c b/dlls/quartz/dsoundrender.c index 8e6379da8c..225c1e07b9 100644 --- a/dlls/quartz/dsoundrender.c +++ b/dlls/quartz/dsoundrender.c @@ -384,9 +384,6 @@ static HRESULT WINAPI DSoundRender_CheckMediaType(struct strmbase_renderer *ifac if (!IsEqualIID(&pmt->majortype, &MEDIATYPE_Audio)) return S_FALSE; - if (!IsEqualIID(&pmt->subtype, &MEDIASUBTYPE_PCM)) - return S_FALSE; - return S_OK; } diff --git a/dlls/quartz/tests/dsoundrender.c b/dlls/quartz/tests/dsoundrender.c index 3add14d043..0b45d712dc 100644 --- a/dlls/quartz/tests/dsoundrender.c +++ b/dlls/quartz/tests/dsoundrender.c @@ -789,10 +789,9 @@ static void test_media_types(void) expect_hr = does_dsound_support_format(&wfx); hr = IPin_QueryAccept(pin, &req_mt); - todo_wine_if (expect_hr == S_OK) - ok(hr == expect_hr, "Expected hr %#x, got %#x, for %d channels, %d-bit %s, %d Hz.\n", - expect_hr, hr, channels, formats[i].depth, - formats[i].tag == WAVE_FORMAT_PCM ? "integer" : "float", sample_rates[j]); + ok(hr == expect_hr, "Expected hr %#x, got %#x, for %d channels, %d-bit %s, %d Hz.\n", + expect_hr, hr, channels, formats[i].depth, + formats[i].tag == WAVE_FORMAT_PCM ? "integer" : "float", sample_rates[j]); } } }

1 0

Zebediah Figura : quartz/tests: Add some tests for allocator negotiation on the DirectSound renderer.
by Alexandre Julliard July 17, 2020

July 17, 2020

Module: wine Branch: master Commit: aca967b8a5a6ce7a839990fcd85c7517f3a1e46c URL: https://source.winehq.org/git/wine.git/?a=commit;h=aca967b8a5a6ce7a839990fc… Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Wed Jul 15 22:57:18 2020 -0500 quartz/tests: Add some tests for allocator negotiation on the DirectSound renderer. Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/quartz/tests/dsoundrender.c | 49 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 49 insertions(+) diff --git a/dlls/quartz/tests/dsoundrender.c b/dlls/quartz/tests/dsoundrender.c index 22d5bf6282..d5c18d389a 100644 --- a/dlls/quartz/tests/dsoundrender.c +++ b/dlls/quartz/tests/dsoundrender.c @@ -631,6 +631,49 @@ static void testfilter_init(struct testfilter *filter) strmbase_source_init(&filter->source, &filter->filter, L"", &testsource_ops); } +static void test_allocator(IMemInputPin *input) +{ + IMemAllocator *req_allocator, *ret_allocator; + ALLOCATOR_PROPERTIES props; + HRESULT hr; + + hr = IMemInputPin_GetAllocatorRequirements(input, &props); + ok(hr == E_NOTIMPL, "Got hr %#x.\n", hr); + + hr = IMemInputPin_GetAllocator(input, &ret_allocator); + todo_wine ok(hr == S_OK, "Got hr %#x.\n", hr); + + if (hr == S_OK) + { + hr = IMemAllocator_GetProperties(ret_allocator, &props); + ok(hr == S_OK, "Got hr %#x.\n", hr); + ok(!props.cBuffers, "Got %d buffers.\n", props.cBuffers); + ok(!props.cbBuffer, "Got size %d.\n", props.cbBuffer); + ok(!props.cbAlign, "Got alignment %d.\n", props.cbAlign); + ok(!props.cbPrefix, "Got prefix %d.\n", props.cbPrefix); + + hr = IMemInputPin_NotifyAllocator(input, ret_allocator, TRUE); + ok(hr == S_OK, "Got hr %#x.\n", hr); + IMemAllocator_Release(ret_allocator); + } + + hr = IMemInputPin_NotifyAllocator(input, NULL, TRUE); + ok(hr == E_POINTER, "Got hr %#x.\n", hr); + + CoCreateInstance(&CLSID_MemoryAllocator, NULL, CLSCTX_INPROC_SERVER, + &IID_IMemAllocator, (void **)&req_allocator); + + hr = IMemInputPin_NotifyAllocator(input, req_allocator, TRUE); + ok(hr == S_OK, "Got hr %#x.\n", hr); + + hr = IMemInputPin_GetAllocator(input, &ret_allocator); + ok(hr == S_OK, "Got hr %#x.\n", hr); + ok(ret_allocator == req_allocator, "Allocators didn't match.\n"); + + IMemAllocator_Release(req_allocator); + IMemAllocator_Release(ret_allocator); +} + static void test_connect_pin(void) { WAVEFORMATEX wfx = @@ -653,6 +696,7 @@ static void test_connect_pin(void) IBaseFilter *filter = create_dsound_render(); struct testfilter source; IFilterGraph2 *graph; + IMemInputPin *input; AM_MEDIA_TYPE mt; IPin *pin, *peer; HRESULT hr; @@ -686,6 +730,10 @@ static void test_connect_pin(void) ok(hr == S_OK, "Got hr %#x.\n", hr); ok(compare_media_types(&mt, &req_mt), "Media types didn't match.\n"); + IPin_QueryInterface(pin, &IID_IMemInputPin, (void **)&input); + + test_allocator(input); + hr = IFilterGraph2_Disconnect(graph, pin); ok(hr == S_OK, "Got hr %#x.\n", hr); hr = IFilterGraph2_Disconnect(graph, pin); @@ -701,6 +749,7 @@ static void test_connect_pin(void) hr = IPin_ConnectionMediaType(pin, &mt); ok(hr == VFW_E_NOT_CONNECTED, "Got hr %#x.\n", hr); + IMemInputPin_Release(input); IPin_Release(pin); ref = IFilterGraph2_Release(graph); ok(!ref, "Got outstanding refcount %d.\n", ref);

1 0

Zebediah Figura : quartz/tests: Test previous filter states.
by Alexandre Julliard July 17, 2020

July 17, 2020

Module: wine Branch: master Commit: 88d2afb79cc416108179d5f44b52f158c8f882a0 URL: https://source.winehq.org/git/wine.git/?a=commit;h=88d2afb79cc416108179d5f4… Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Wed Jul 15 22:57:14 2020 -0500 quartz/tests: Test previous filter states. Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/quartz/tests/filtergraph.c | 22 +++++++++++++++++++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a/dlls/quartz/tests/filtergraph.c b/dlls/quartz/tests/filtergraph.c index 0c627aaeaf..bd6562b0ed 100644 --- a/dlls/quartz/tests/filtergraph.c +++ b/dlls/quartz/tests/filtergraph.c @@ -1166,14 +1166,15 @@ struct testfilter IFilterGraph *graph; WCHAR *name; IReferenceClock *clock; - FILTER_STATE state; - REFERENCE_TIME start_time; IEnumPins IEnumPins_iface; struct testpin *pins; unsigned int pin_count, enum_idx; + FILTER_STATE state; + REFERENCE_TIME start_time; HRESULT state_hr, GetState_hr, seek_hr; + FILTER_STATE expect_stop_prev, expect_run_prev; IAMFilterMiscFlags IAMFilterMiscFlags_iface; ULONG misc_flags; @@ -1358,6 +1359,10 @@ static HRESULT WINAPI testfilter_Stop(IBaseFilter *iface) struct testfilter *filter = impl_from_IBaseFilter(iface); if (winetest_debug > 1) trace("%p->Stop()\n", filter); + todo_wine_if (filter->expect_stop_prev == State_Running) + ok(filter->state == filter->expect_stop_prev, "Expected previous state %#x, got %#x.\n", + filter->expect_stop_prev, filter->state); + check_state_transition(filter, State_Stopped); filter->state = State_Stopped; @@ -1380,6 +1385,9 @@ static HRESULT WINAPI testfilter_Run(IBaseFilter *iface, REFERENCE_TIME start) struct testfilter *filter = impl_from_IBaseFilter(iface); if (winetest_debug > 1) trace("%p->Run(%s)\n", filter, wine_dbgstr_longlong(start)); + ok(filter->state == filter->expect_run_prev, "Expected previous state %#x, got %#x.\n", + filter->expect_run_prev, filter->state); + check_state_transition(filter, State_Running); filter->state = State_Running; @@ -1831,7 +1839,9 @@ static void testfilter_init(struct testfilter *filter, struct testpin *pins, int filter->pin_count = pin_count; for (i = 0; i < pin_count; i++) pins[i].filter = &filter->IBaseFilter_iface; + filter->state = State_Stopped; + filter->expect_stop_prev = filter->expect_run_prev = State_Paused; } static HRESULT WINAPI testfilter_cf_QueryInterface(IClassFactory *iface, REFIID iid, void **out) @@ -3383,6 +3393,7 @@ static void test_filter_state(void) ok(hr == S_OK, "Got hr %#x.\n", hr); check_filter_state(graph, State_Stopped); + source.expect_run_prev = sink.expect_run_prev = State_Stopped; hr = IReferenceClock_GetTime(clock, &start_time); ok(SUCCEEDED(hr), "Got hr %#x.\n", hr); hr = IMediaFilter_Run(filter, 0); @@ -3400,6 +3411,7 @@ static void test_filter_state(void) ok(hr == S_OK, "Got hr %#x.\n", hr); check_filter_state(graph, State_Paused); + source.expect_run_prev = sink.expect_run_prev = State_Paused; hr = IMediaFilter_Run(filter, 0); ok(hr == S_OK, "Got hr %#x.\n", hr); check_filter_state(graph, State_Running); @@ -3587,6 +3599,7 @@ todo_wine /* This logic doesn't apply when using IMediaFilter methods directly. */ + source.expect_run_prev = sink.expect_run_prev = State_Stopped; sink.state_hr = S_FALSE; sink.GetState_hr = VFW_S_STATE_INTERMEDIATE; hr = IMediaFilter_Run(filter, 0); @@ -3610,6 +3623,8 @@ todo_wine ok(sink.state == State_Stopped, "Got state %u.\n", sink.state); ok(source.state == State_Stopped, "Got state %u.\n", source.state); + source.expect_run_prev = sink.expect_run_prev = State_Paused; + /* Test VFW_S_CANT_CUE. */ sink.GetState_hr = VFW_S_CANT_CUE; @@ -3658,7 +3673,7 @@ todo_wine /* Destroying the graph while it's running stops all filters. */ - hr = IMediaFilter_Run(filter, 0); + hr = IMediaControl_Run(control); ok(hr == S_OK, "Got hr %#x.\n", hr); check_filter_state(graph, State_Running); todo_wine @@ -3667,6 +3682,7 @@ todo_wine ok(sink.start_time == source.start_time, "Expected time %s, got %s.\n", wine_dbgstr_longlong(source.start_time), wine_dbgstr_longlong(sink.start_time)); + source.expect_stop_prev = sink.expect_stop_prev = State_Running; IMediaFilter_Release(filter); IMediaControl_Release(control); ref = IFilterGraph2_Release(graph);

1 0

Alexandre Julliard : ntdll: Use syscall thunks for timer functions.
by Alexandre Julliard July 17, 2020

July 17, 2020

Module: wine Branch: master Commit: aa08e1541510357f3c3865cc959cc1d60a1b86cf URL: https://source.winehq.org/git/wine.git/?a=commit;h=aa08e1541510357f3c3865cc… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Thu Jul 16 10:29:25 2020 +0200 ntdll: Use syscall thunks for timer functions. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ntdll/ntdll.spec | 20 ++++++++++---------- dlls/ntdll/sync.c | 48 ------------------------------------------------ dlls/ntdll/unix/loader.c | 5 ----- dlls/ntdll/unixlib.h | 12 +----------- 4 files changed, 11 insertions(+), 74 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=aa08e1541510357f3c38…

1 0

Alexandre Julliard : ntdll: Use syscall thunks for mutex functions.
by Alexandre Julliard July 17, 2020

July 17, 2020

Module: wine Branch: master Commit: 3f51cb630497621042c0479d8a604d74a837ba3b URL: https://source.winehq.org/git/wine.git/?a=commit;h=3f51cb630497621042c0479d… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Thu Jul 16 10:26:27 2020 +0200 ntdll: Use syscall thunks for mutex functions. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ntdll/ntdll.spec | 16 ++++++++-------- dlls/ntdll/sync.c | 42 ------------------------------------------ dlls/ntdll/unix/loader.c | 4 ---- dlls/ntdll/unixlib.h | 9 +-------- 4 files changed, 9 insertions(+), 62 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=3f51cb630497621042c0…

1 0

Alexandre Julliard : ntdll: Avoid buffer underflow in find_dos_device().
by Alexandre Julliard July 17, 2020

July 17, 2020

Module: wine Branch: master Commit: 14994715e9337821aeac39c0f43b704bdc7ba200 URL: https://source.winehq.org/git/wine.git/?a=commit;h=14994715e9337821aeac39c0… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Thu Jul 16 09:14:43 2020 +0200 ntdll: Avoid buffer underflow in find_dos_device(). Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ntdll/unix/file.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/dlls/ntdll/unix/file.c b/dlls/ntdll/unix/file.c index b202864e66..08b58ba828 100644 --- a/dlls/ntdll/unix/file.c +++ b/dlls/ntdll/unix/file.c @@ -1924,7 +1924,6 @@ static int find_dos_device( const char *path ) { if ((info[drive].dev == st.st_dev) && (info[drive].ino == st.st_ino)) { - if (len == 1) len = 0; /* preserve root slash in returned path */ TRACE( "%s -> drive %c:, root=%s, name=%s\n", debugstr_a(path), 'A' + drive, debugstr_a(buffer), debugstr_a(path + len)); free( buffer ); @@ -1933,8 +1932,8 @@ static int find_dos_device( const char *path ) } } if (len <= 1) break; /* reached root */ - while (path[len - 1] != '/') len--; - while (path[len - 1] == '/') len--; + while (len > 1 && path[len - 1] != '/') len--; + while (len > 1 && path[len - 1] == '/') len--; buffer[len] = 0; } free( buffer ); @@ -1952,7 +1951,6 @@ static NTSTATUS get_mountmgr_fs_info( HANDLE handle, int fd, struct mountmgr_uni int letter; if ((status = server_get_unix_name( handle, &unix_name ))) return status; - letter = find_dos_device( unix_name ); free( unix_name );

1 0