August 2020 - Wine-Commits - list.winehq.org

Biswapriyo Nath : dxgi: Fix order of functions in IDXGIFactory2 interface.
by Alexandre Julliard Aug. 20, 2020

Aug. 20, 2020

Module: wine Branch: master Commit: 249697c76d02c7dabafc52fb44ffd96b275f4974 URL: https://source.winehq.org/git/wine.git/?a=commit;h=249697c76d02c7dabafc52fb… Author: Biswapriyo Nath <nathbappai(a)gmail.com> Date: Fri Aug 14 11:06:43 2020 +0530 dxgi: Fix order of functions in IDXGIFactory2 interface. Swap between RegisterStereoStatusWindow and RegisterOcclusionStatusWindow methods. Signed-off-by: Biswapriyo Nath <nathbappai(a)gmail.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/dxgi/factory.c | 4 ++-- include/dxgi1_2.idl | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/dlls/dxgi/factory.c b/dlls/dxgi/factory.c index 6acce516de..af18bdd2c3 100644 --- a/dlls/dxgi/factory.c +++ b/dlls/dxgi/factory.c @@ -522,10 +522,10 @@ static const struct IWineDXGIFactoryVtbl dxgi_factory_vtbl = dxgi_factory_CreateSwapChainForHwnd, dxgi_factory_CreateSwapChainForCoreWindow, dxgi_factory_GetSharedResourceAdapterLuid, - dxgi_factory_RegisterOcclusionStatusWindow, + dxgi_factory_RegisterStereoStatusWindow, dxgi_factory_RegisterStereoStatusEvent, dxgi_factory_UnregisterStereoStatus, - dxgi_factory_RegisterStereoStatusWindow, + dxgi_factory_RegisterOcclusionStatusWindow, dxgi_factory_RegisterOcclusionStatusEvent, dxgi_factory_UnregisterOcclusionStatus, dxgi_factory_CreateSwapChainForComposition, diff --git a/include/dxgi1_2.idl b/include/dxgi1_2.idl index ef256d4fd8..921a66e0c9 100644 --- a/include/dxgi1_2.idl +++ b/include/dxgi1_2.idl @@ -318,7 +318,7 @@ interface IDXGIFactory2 : IDXGIFactory1 [in] HANDLE hResource, [out] LUID *pLuid); - HRESULT RegisterOcclusionStatusWindow( + HRESULT RegisterStereoStatusWindow( [in] HWND WindowHandle, [in] UINT wMsg, [out] DWORD *pdwCookie); @@ -330,7 +330,7 @@ interface IDXGIFactory2 : IDXGIFactory1 void UnregisterStereoStatus( [in] DWORD dwCookie); - HRESULT RegisterStereoStatusWindow( + HRESULT RegisterOcclusionStatusWindow( [in] HWND WindowHandle, [in] UINT wMsg, [out] DWORD *pdwCookie);

1 0

Paul Gofman : include: Define extended context structures.
by Alexandre Julliard Aug. 20, 2020

Aug. 20, 2020

Module: wine Branch: master Commit: 22f4b6fcf5014b6d98188253636c116e50446c44 URL: https://source.winehq.org/git/wine.git/?a=commit;h=22f4b6fcf5014b6d98188253… Author: Paul Gofman <pgofman(a)codeweavers.com> Date: Thu Aug 20 00:22:57 2020 +0300 include: Define extended context structures. Signed-off-by: Paul Gofman <pgofman(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- include/winnt.h | 58 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 58 insertions(+) diff --git a/include/winnt.h b/include/winnt.h index 38f7983cbf..8c5f24aff8 100644 --- a/include/winnt.h +++ b/include/winnt.h @@ -1297,6 +1297,64 @@ NTSYSAPI PVOID WINAPI RtlVirtualUnwind(ULONG,ULONG64,ULONG64,RUNTIME_FUNCTION*,C #endif /* __x86_64__ */ +#define XSTATE_LEGACY_FLOATING_POINT 0 +#define XSTATE_LEGACY_SSE 1 +#define XSTATE_GSSE 2 +#define XSTATE_AVX XSTATE_GSSE +#define XSTATE_MPX_BNDREGS 3 +#define XSTATE_MPX_BNDCSR 4 +#define XSTATE_AVX512_KMASK 5 +#define XSTATE_AVX512_ZMM_H 6 +#define XSTATE_AVX512_ZMM 7 +#define XSTATE_IPT 8 +#define XSTATE_CET_U 11 +#define XSTATE_LWP 62 + +typedef struct _YMMCONTEXT +{ + M128A Ymm0; + M128A Ymm1; + M128A Ymm2; + M128A Ymm3; + M128A Ymm4; + M128A Ymm5; + M128A Ymm6; + M128A Ymm7; + M128A Ymm8; + M128A Ymm9; + M128A Ymm10; + M128A Ymm11; + M128A Ymm12; + M128A Ymm13; + M128A Ymm14; + M128A Ymm15; +} +YMMCONTEXT, *PYMMCONTEXT; + +typedef struct _XSTATE +{ + ULONG64 Mask; + ULONG64 CompactionMask; + ULONG64 Reserved[6]; + YMMCONTEXT YmmContext; +} XSTATE, *PXSTATE; + +typedef struct _CONTEXT_CHUNK +{ + LONG Offset; + ULONG Length; +} CONTEXT_CHUNK, *PCONTEXT_CHUNK; + +typedef struct _CONTEXT_EX +{ + CONTEXT_CHUNK All; + CONTEXT_CHUNK Legacy; + CONTEXT_CHUNK XState; +#ifdef _WIN64 + ULONG64 align; +#endif +} CONTEXT_EX, *PCONTEXT_EX; + /* IA64 context definitions */ #ifdef __ia64__

1 0

Paul Gofman : include: Implement __cpuidex() function.
by Alexandre Julliard Aug. 20, 2020

Aug. 20, 2020

Module: wine Branch: master Commit: 0e544824f507ee6efc6dac171cbf7b552c359eb7 URL: https://source.winehq.org/git/wine.git/?a=commit;h=0e544824f507ee6efc6dac17… Author: Paul Gofman <pgofman(a)codeweavers.com> Date: Thu Aug 20 00:22:58 2020 +0300 include: Implement __cpuidex() function. Signed-off-by: Paul Gofman <pgofman(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- include/msvcrt/intrin.h | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/include/msvcrt/intrin.h b/include/msvcrt/intrin.h index 5ad2776450..38496251d5 100644 --- a/include/msvcrt/intrin.h +++ b/include/msvcrt/intrin.h @@ -12,9 +12,13 @@ extern "C" { #endif #if defined(__i386__) || defined(__x86_64__) +static inline void __cpuidex(int info[4], int ax, int cx) +{ + __asm__ ("cpuid" : "=a"(info[0]), "=b" (info[1]), "=c"(info[2]), "=d"(info[3]) : "a"(ax), "c"(cx)); +} static inline void __cpuid(int info[4], int ax) { - __asm__ ("cpuid" : "=a"(info[0]), "=b" (info[1]), "=c"(info[2]), "=d"(info[3]) : "a"(ax), "c"(0)); + return __cpuidex(info, ax, 0); } #endif

1 0

Paul Gofman : include: Define _XSAVE_FORMAT structure.
by Alexandre Julliard Aug. 20, 2020

Aug. 20, 2020

Module: wine Branch: master Commit: de1cb029f6e9bd6b8959695f5d0ae55188d9b723 URL: https://source.winehq.org/git/wine.git/?a=commit;h=de1cb029f6e9bd6b8959695f… Author: Paul Gofman <pgofman(a)codeweavers.com> Date: Thu Aug 20 00:22:56 2020 +0300 include: Define _XSAVE_FORMAT structure. The structure is defined for both x86_64 and i386 (along with M128A) in (newer) Windows SDK. Signed-off-by: Paul Gofman <pgofman(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ntdll/signal_i386.c | 32 ++-------------------- dlls/ntdll/unix/signal_i386.c | 53 +++++++++-------------------------- dlls/ntdll/unix/system.c | 26 +----------------- include/winnt.h | 42 ++++++++++++++-------------- programs/winedbg/be_i386.c | 64 +++++++++++++------------------------------ 5 files changed, 57 insertions(+), 160 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=de1cb029f6e9bd6b8959…

1 0

Paul Gofman : wineboot: Initialize XState features in user_shared_data.
by Alexandre Julliard Aug. 20, 2020

Aug. 20, 2020

Module: wine Branch: master Commit: 97b5ad7597bf2add39251d7379fc607bf1578478 URL: https://source.winehq.org/git/wine.git/?a=commit;h=97b5ad7597bf2add39251d73… Author: Paul Gofman <pgofman(a)codeweavers.com> Date: Thu Aug 20 00:22:59 2020 +0300 wineboot: Initialize XState features in user_shared_data. Signed-off-by: Paul Gofman <pgofman(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ntdll/tests/virtual.c | 67 ++++++++++++++++++++++++++++++++++++++++++++ programs/wineboot/wineboot.c | 59 ++++++++++++++++++++++++++++++++++++++ 2 files changed, 126 insertions(+) diff --git a/dlls/ntdll/tests/virtual.c b/dlls/ntdll/tests/virtual.c index beab744178..4a0a4a6b8e 100644 --- a/dlls/ntdll/tests/virtual.c +++ b/dlls/ntdll/tests/virtual.c @@ -516,9 +516,34 @@ static void test_NtMapViewOfSection(void) CloseHandle(process); } +#define SUPPORTED_XSTATE_FEATURES ((1 << XSTATE_LEGACY_FLOATING_POINT) | (1 << XSTATE_LEGACY_SSE) | (1 << XSTATE_AVX)) + static void test_user_shared_data(void) { + struct old_xstate_configuration + { + ULONG64 EnabledFeatures; + ULONG Size; + ULONG OptimizedSave:1; + ULONG CompactionEnabled:1; + XSTATE_FEATURE Features[MAXIMUM_XSTATE_FEATURES]; + }; + + static const ULONG feature_offsets[] = + { + 0, + 160, /*offsetof(XMM_SAVE_AREA32, XmmRegisters)*/ + 512 /* sizeof(XMM_SAVE_AREA32) */ + offsetof(XSTATE, YmmContext), + }; + static const ULONG feature_sizes[] = + { + 160, + 256, /*sizeof(M128A) * 16 */ + sizeof(YMMCONTEXT), + }; const KSHARED_USER_DATA *user_shared_data = (void *)0x7ffe0000; + XSTATE_CONFIGURATION xstate = user_shared_data->XState; + unsigned int i; ok(user_shared_data->NumberOfPhysicalPages == sbi.MmNumberOfPhysicalPages, "Got number of physical pages %#x, expected %#x.\n", @@ -534,6 +559,48 @@ static void test_user_shared_data(void) ok(user_shared_data->ActiveGroupCount == 1 || broken(!user_shared_data->ActiveGroupCount) /* before Win7 */, "Got unexpected ActiveGroupCount %u.\n", user_shared_data->ActiveGroupCount); + + if (!xstate.EnabledFeatures) + { + struct old_xstate_configuration *xs_old + = (struct old_xstate_configuration *)((char *)user_shared_data + 0x3e0); + + if (!xs_old->EnabledFeatures) + { + skip("XState features are not supported.\n"); + return; + } + + memset(&xstate, 0, sizeof(xstate)); + xstate.EnabledFeatures = xstate.EnabledVolatileFeatures = xs_old->EnabledFeatures; + memcpy(&xstate.Size, &xs_old->Size, sizeof(*xs_old) - offsetof(struct old_xstate_configuration, Size)); + for (i = 0; i < 3; ++i) + xstate.AllFeatures[i] = xs_old->Features[i].Size; + xstate.AllFeatureSize = 512 + sizeof(XSTATE); + } + + trace("XState EnabledFeatures %s.\n", wine_dbgstr_longlong(xstate.EnabledFeatures)); + ok((xstate.EnabledFeatures & SUPPORTED_XSTATE_FEATURES) == SUPPORTED_XSTATE_FEATURES, + "Got unexpected EnabledFeatures %s.\n", wine_dbgstr_longlong(xstate.EnabledFeatures)); + ok((xstate.EnabledVolatileFeatures & SUPPORTED_XSTATE_FEATURES) == xstate.EnabledFeatures, + "Got unexpected EnabledVolatileFeatures %s.\n", wine_dbgstr_longlong(xstate.EnabledVolatileFeatures)); + ok(xstate.Size >= 512 + sizeof(XSTATE), "Got unexpected Size %u.\n", xstate.Size); + if (xstate.CompactionEnabled) + ok(xstate.OptimizedSave, "Got zero OptimizedSave with compaction enabled.\n"); + ok(!xstate.AlignedFeatures, "Got unexpected AlignedFeatures %s.\n", + wine_dbgstr_longlong(xstate.AlignedFeatures)); + ok(xstate.AllFeatureSize >= 512 + sizeof(XSTATE), "Got unexpected AllFeatureSize %u.\n", + xstate.AllFeatureSize); + + for (i = 0; i < ARRAY_SIZE(feature_sizes); ++i) + { + ok(xstate.AllFeatures[i] == feature_sizes[i], "Got unexpected AllFeatures[%u] %u, expected %u.\n", i, + xstate.AllFeatures[i], feature_sizes[i]); + ok(xstate.Features[i].Size == feature_sizes[i], "Got unexpected Features[%u].Size %u, expected %u.\n", i, + xstate.Features[i].Size, feature_sizes[i]); + ok(xstate.Features[i].Offset == feature_offsets[i], "Got unexpected Features[%u].Offset %u, expected %u.\n", + i, xstate.Features[i].Offset, feature_offsets[i]); + } } START_TEST(virtual) diff --git a/programs/wineboot/wineboot.c b/programs/wineboot/wineboot.c index 902f6af042..2f8b7169cf 100644 --- a/programs/wineboot/wineboot.c +++ b/programs/wineboot/wineboot.c @@ -191,6 +191,63 @@ static DWORD set_reg_value_dword( HKEY hkey, const WCHAR *name, DWORD value ) return RegSetValueExW( hkey, name, 0, REG_DWORD, (const BYTE *)&value, sizeof(value) ); } +#if defined(__i386__) || defined(__x86_64__) + +static void initialize_xstate_features(struct _KUSER_SHARED_DATA *data) +{ + XSTATE_CONFIGURATION *xstate = &data->XState; + unsigned int i; + int regs[4]; + + if (!data->ProcessorFeatures[PF_AVX_INSTRUCTIONS_AVAILABLE]) + return; + + __cpuidex(regs, 0, 0); + + TRACE("Max cpuid level %#x.\n", regs[0]); + if (regs[0] < 0xd) + return; + + __cpuidex(regs, 1, 0); + TRACE("CPU features %#x, %#x, %#x, %#x.\n", regs[0], regs[1], regs[2], regs[3]); + if (!(regs[2] & (0x1 << 27))) /* xsave OS enabled */ + return; + + __cpuidex(regs, 0xd, 0); + TRACE("XSAVE details %#x, %#x, %#x, %#x.\n", regs[0], regs[1], regs[2], regs[3]); + if (!(regs[0] & XSTATE_AVX)) + return; + + xstate->EnabledFeatures = (1 << XSTATE_LEGACY_FLOATING_POINT) | (1 << XSTATE_LEGACY_SSE) | (1 << XSTATE_AVX); + xstate->EnabledVolatileFeatures = xstate->EnabledFeatures; + xstate->Size = sizeof(XSAVE_FORMAT) + sizeof(XSTATE); + xstate->AllFeatureSize = regs[1]; + xstate->AllFeatures[0] = offsetof(XSAVE_FORMAT, XmmRegisters); + xstate->AllFeatures[1] = sizeof(M128A) * 16; + xstate->AllFeatures[2] = sizeof(YMMCONTEXT); + + for (i = 0; i < 3; ++i) + xstate->Features[i].Size = xstate->AllFeatures[i]; + + xstate->Features[1].Offset = xstate->Features[0].Size; + xstate->Features[2].Offset = sizeof(XSAVE_FORMAT) + offsetof(XSTATE, YmmContext); + + __cpuidex(regs, 0xd, 1); + xstate->OptimizedSave = regs[0] & 1; + xstate->CompactionEnabled = !!(regs[0] & 2); + + __cpuidex(regs, 0xd, 2); + TRACE("XSAVE feature 2 %#x, %#x, %#x, %#x.\n", regs[0], regs[1], regs[2], regs[3]); +} + +#else + +static void initialize_xstate_features(struct _KUSER_SHARED_DATA *data) +{ +} + +#endif + static void create_user_shared_data(void) { struct _KUSER_SHARED_DATA *data; @@ -276,6 +333,8 @@ static void create_user_shared_data(void) data->ActiveProcessorCount = NtCurrentTeb()->Peb->NumberOfProcessors; data->ActiveGroupCount = 1; + initialize_xstate_features( data ); + UnmapViewOfFile( data ); }

1 0

Paul Gofman : kernel32: Implement GetEnabledXStateFeatures().
by Alexandre Julliard Aug. 20, 2020

Aug. 20, 2020

Module: wine Branch: master Commit: a4af2b2b70db96309172b226dc6163e90d565420 URL: https://source.winehq.org/git/wine.git/?a=commit;h=a4af2b2b70db96309172b226… Author: Paul Gofman <pgofman(a)codeweavers.com> Date: Thu Aug 20 00:23:00 2020 +0300 kernel32: Implement GetEnabledXStateFeatures(). Signed-off-by: Paul Gofman <pgofman(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- .../api-ms-win-core-xstate-l1-1-0.spec | 2 +- dlls/kernel32/kernel32.spec | 2 +- dlls/kernel32/process.c | 9 ------ dlls/kernelbase/kernelbase.spec | 2 +- dlls/kernelbase/memory.c | 18 ++++++++++++ dlls/ntdll/exception.c | 10 +++++++ dlls/ntdll/ntdll.spec | 1 + dlls/ntdll/tests/virtual.c | 33 +++++++++++++++++----- dlls/ntoskrnl.exe/ntoskrnl.exe.spec | 1 + include/ddk/wdm.h | 1 + include/winbase.h | 1 + 11 files changed, 61 insertions(+), 19 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=a4af2b2b70db96309172…

1 0

Martin Storsjo : loader: Fix the generic case in get_self_exe().
by Alexandre Julliard Aug. 20, 2020

Aug. 20, 2020

Module: wine Branch: master Commit: a75596c94db26e9e86d6fb222ce4de5e939c2195 URL: https://source.winehq.org/git/wine.git/?a=commit;h=a75596c94db26e9e86d6fb22… Author: Martin Storsjo <martin(a)martin.st> Date: Wed Aug 19 23:57:06 2020 +0300 loader: Fix the generic case in get_self_exe(). Previously this just returned the matched directory, not the path to the executable itself. Signed-off-by: Martin Storsjo <martin(a)martin.st> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- loader/main.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/loader/main.c b/loader/main.c index 0e6b6f66b5..3c06728504 100644 --- a/loader/main.c +++ b/loader/main.c @@ -216,13 +216,15 @@ static const char *get_self_exe( char *argv0 ) for (p = strtok( path, ":" ); p; p = strtok( NULL, ":" )) { char *name = build_path( p, argv0 ); - int found = !access( name, X_OK ); + if (!access( name, X_OK )) + { + free( path ); + return name; + } free( name ); - if (found) break; } - if (p) p = strdup( p ); free( path ); - return p; + return NULL; } return argv0; #endif

1 0

Nikolay Sivov : combase: Move local proxy-stub registration functions.
by Alexandre Julliard Aug. 20, 2020

Aug. 20, 2020

Module: wine Branch: master Commit: e00ea31d09e451b524c93950ee0e3f92d5b371d1 URL: https://source.winehq.org/git/wine.git/?a=commit;h=e00ea31d09e451b524c93950… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Thu Aug 20 10:34:40 2020 +0300 combase: Move local proxy-stub registration functions. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Huw Davies <huw(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/combase/combase.c | 177 ++++++++++++++++++++++++++++++++++ dlls/combase/combase.spec | 5 +- dlls/ole32/compobj.c | 235 +++------------------------------------------- dlls/ole32/ole32.spec | 5 +- 4 files changed, 197 insertions(+), 225 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=e00ea31d09e451b524c9…

1 0

Gijs Vermeulen : quartz: Close hfile when GetFileSizeEx fails in IFileSourceFilter::Load() (Coverity).
by Alexandre Julliard Aug. 20, 2020

Aug. 20, 2020

Module: wine Branch: master Commit: 5e1753f04dd2d67edba2b62f1644cb30528376c8 URL: https://source.winehq.org/git/wine.git/?a=commit;h=5e1753f04dd2d67edba2b62f… Author: Gijs Vermeulen <gijsvrm(a)gmail.com> Date: Thu Aug 20 15:08:20 2020 +0200 quartz: Close hfile when GetFileSizeEx fails in IFileSourceFilter::Load() (Coverity). Signed-off-by: Gijs Vermeulen <gijsvrm(a)gmail.com> Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/quartz/filesource.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dlls/quartz/filesource.c b/dlls/quartz/filesource.c index a553b8517e..79df639ab4 100644 --- a/dlls/quartz/filesource.c +++ b/dlls/quartz/filesource.c @@ -478,6 +478,7 @@ static HRESULT WINAPI FileSource_Load(IFileSourceFilter * iface, LPCOLESTR pszFi if (!GetFileSizeEx(hFile, &This->file_size)) { WARN("Could not get file size.\n"); + CloseHandle(hFile); return HRESULT_FROM_WIN32(GetLastError()); }

1 0

Gijs Vermeulen : qcap/tests: Remove unused enumMediaTypes in test_smart_tee_filter() (Coverity).
by Alexandre Julliard Aug. 20, 2020

Aug. 20, 2020

Module: wine Branch: master Commit: e13f5a1b43e994d4f5457f763f422452e572d722 URL: https://source.winehq.org/git/wine.git/?a=commit;h=e13f5a1b43e994d4f5457f76… Author: Gijs Vermeulen <gijsvrm(a)gmail.com> Date: Thu Aug 20 15:07:54 2020 +0200 qcap/tests: Remove unused enumMediaTypes in test_smart_tee_filter() (Coverity). Signed-off-by: Gijs Vermeulen <gijsvrm(a)gmail.com> Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/qcap/tests/smartteefilter.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/dlls/qcap/tests/smartteefilter.c b/dlls/qcap/tests/smartteefilter.c index f3a44c67c1..1364beef16 100644 --- a/dlls/qcap/tests/smartteefilter.c +++ b/dlls/qcap/tests/smartteefilter.c @@ -2142,7 +2142,6 @@ static void test_smart_tee_filter(void) FILTER_INFO filterInfo; int pinNumber = 0; IMemInputPin *memInputPin = NULL; - IEnumMediaTypes *enumMediaTypes = NULL; hr = CoCreateInstance(&CLSID_SmartTee, NULL, CLSCTX_INPROC_SERVER, &IID_IBaseFilter, (void**)&smartTeeFilter); @@ -2213,8 +2212,6 @@ end: IEnumPins_Release(enumPins); if (memInputPin) IMemInputPin_Release(memInputPin); - if (enumMediaTypes) - IEnumMediaTypes_Release(enumMediaTypes); } static void test_unconnected_filter_state(void)

1 0