October 2021 - Wine-Commits

Simon McVittie : winebus.sys: Add code path to bypass udevd and use inotify.
by Alexandre Julliard Oct. 20, 2021

Oct. 20, 2021

Module: wine Branch: master Commit: ab3416c61fb17207e0831f7709da4d2911b07fb2 URL: https://source.winehq.org/git/wine.git/?a=commit;h=ab3416c61fb17207e0831f77… Author: Simon McVittie <smcv(a)collabora.com> Date: Wed Oct 20 11:07:27 2021 +0200 winebus.sys: Add code path to bypass udevd and use inotify. In a container with a non-trivial user namespace, we cannot rely on libudev communicating with udevd as a way to monitor device nodes, for the following reasons: * If uid 0 from the host is not mapped to uid 0 in the container, libudev cannot authenticate netlink messages from the host, because their sender uid appears to be the overflowuid. Resolving this by mapping uid 0 into the container is not allowed when creating user namespaces as an unprivileged user, and even when running as a privileged user, it might be desirable for the real uid 0 to not be mapped as a way to harden the security boundary between container and host. * Depending on the container configuration, initial enumeration might not be able to read /run/udev from the host system. If it can't, sysfs attributes will still work because those are read directly from the kernel via sysfs, but udev properties coming from user-space rules (in particular ID_INPUT_JOYSTICK and friends) will appear to be missing. * The protocols between udevd and libudev (netlink messages for monitoring, and /run/udev for initial enumeration) are considered to be private to a particular version of udev, and are not a stable API; but in a container, we cannot expect that our copy of libudev is at exactly the same version as udevd on the host system. Sidestep this by adding a code path that continues to use libudev for the parts that work regardless of whether udevd is running or can be communicated with. Signed-off-by: Rémi Bernon <rbernon(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/winebus.sys/bus_udev.c | 276 ++++++++++++++++++++++++++++++++++++++++++-- dlls/winebus.sys/main.c | 2 + dlls/winebus.sys/unixlib.h | 1 + 3 files changed, 268 insertions(+), 11 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=ab3416c61fb17207e083…

1 0

Alexandre Julliard : msxml3: Always set output length in encoding conversion.
by Alexandre Julliard Oct. 20, 2021

Oct. 20, 2021

Module: wine Branch: master Commit: 9a335d89d0cc9c8cca04d41a8cd43b09a9488a20 URL: https://source.winehq.org/git/wine.git/?a=commit;h=9a335d89d0cc9c8cca04d41a… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Wed Oct 20 11:31:58 2021 +0200 msxml3: Always set output length in encoding conversion. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/msxml3/main.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/dlls/msxml3/main.c b/dlls/msxml3/main.c index 25400b698ca..e9a43ab64b2 100644 --- a/dlls/msxml3/main.c +++ b/dlls/msxml3/main.c @@ -233,9 +233,9 @@ static void init_libxslt(void) static int to_utf8(int cp, unsigned char *out, int *outlen, const unsigned char *in, int *inlen) { WCHAR *tmp; - int len; + int len = 0; - if (!in || !inlen) return 0; + if (!in || !inlen) goto done; len = MultiByteToWideChar(cp, 0, (const char *)in, *inlen, NULL, 0); tmp = heap_alloc(len * sizeof(WCHAR)); @@ -245,7 +245,7 @@ static int to_utf8(int cp, unsigned char *out, int *outlen, const unsigned char len = WideCharToMultiByte(CP_UTF8, 0, tmp, len, (char *)out, *outlen, NULL, NULL); heap_free(tmp); if (!len) return -1; - +done: *outlen = len; return len; } @@ -253,9 +253,9 @@ static int to_utf8(int cp, unsigned char *out, int *outlen, const unsigned char static int from_utf8(int cp, unsigned char *out, int *outlen, const unsigned char *in, int *inlen) { WCHAR *tmp; - int len; + int len = 0; - if (!in || !inlen) return 0; + if (!in || !inlen) goto done; len = MultiByteToWideChar(CP_UTF8, 0, (const char *)in, *inlen, NULL, 0); tmp = heap_alloc(len * sizeof(WCHAR)); @@ -265,7 +265,7 @@ static int from_utf8(int cp, unsigned char *out, int *outlen, const unsigned cha len = WideCharToMultiByte(cp, 0, tmp, len, (char *)out, *outlen, NULL, NULL); heap_free(tmp); if (!len) return -1; - +done: *outlen = len; return len; }

1 0

Alexandre Julliard : libs: Import code from upstream libxslt 1.1.34.
by Alexandre Julliard Oct. 20, 2021

Oct. 20, 2021

Module: wine Branch: master Commit: c638618cbc5f6f26b0a0d1b32078b9ecca3af8df URL: https://source.winehq.org/git/wine.git/?a=commit;h=c638618cbc5f6f26b0a0d1b3… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Wed Oct 20 11:33:05 2021 +0200 libs: Import code from upstream libxslt 1.1.34. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- configure | 26 + configure.ac | 2 + libs/xslt/AUTHORS | 63 + libs/xslt/COPYING | 53 + libs/xslt/Makefile.in | 23 + libs/xslt/libxslt/attributes.c | 1248 ++++++ libs/xslt/libxslt/attributes.h | 38 + libs/xslt/libxslt/attrvt.c | 396 ++ libs/xslt/libxslt/documents.c | 436 +++ libs/xslt/libxslt/documents.h | 93 + libs/xslt/libxslt/extensions.c | 2380 ++++++++++++ libs/xslt/libxslt/extensions.h | 262 ++ libs/xslt/libxslt/extra.c | 199 + libs/xslt/libxslt/extra.h | 72 + libs/xslt/libxslt/functions.c | 1008 +++++ libs/xslt/libxslt/functions.h | 78 + libs/xslt/libxslt/imports.c | 414 ++ libs/xslt/libxslt/imports.h | 75 + libs/xslt/libxslt/keys.c | 947 +++++ libs/xslt/libxslt/keys.h | 53 + libs/xslt/libxslt/libxslt.h | 36 + libs/xslt/libxslt/namespaces.c | 853 ++++ libs/xslt/libxslt/namespaces.h | 68 + libs/xslt/libxslt/numbers.c | 1363 +++++++ libs/xslt/libxslt/numbersInternals.h | 73 + libs/xslt/libxslt/pattern.c | 2642 +++++++++++++ libs/xslt/libxslt/pattern.h | 84 + libs/xslt/libxslt/preproc.c | 2376 ++++++++++++ libs/xslt/libxslt/preproc.h | 43 + libs/xslt/libxslt/security.c | 482 +++ libs/xslt/libxslt/security.h | 104 + libs/xslt/libxslt/templates.c | 864 +++++ libs/xslt/libxslt/templates.h | 77 + libs/xslt/libxslt/transform.c | 6524 +++++++++++++++++++++++++++++++ libs/xslt/libxslt/transform.h | 207 + libs/xslt/libxslt/trio.h | 216 ++ libs/xslt/libxslt/triodef.h | 220 ++ libs/xslt/libxslt/variables.c | 2374 ++++++++++++ libs/xslt/libxslt/variables.h | 118 + libs/xslt/libxslt/win32config.h | 129 + libs/xslt/libxslt/xslt.c | 7047 ++++++++++++++++++++++++++++++++++ libs/xslt/libxslt/xslt.h | 110 + libs/xslt/libxslt/xsltInternals.h | 1978 ++++++++++ libs/xslt/libxslt/xsltconfig.h | 180 + libs/xslt/libxslt/xsltexports.h | 142 + libs/xslt/libxslt/xsltlocale.c | 520 +++ libs/xslt/libxslt/xsltlocale.h | 76 + libs/xslt/libxslt/xsltutils.c | 2477 ++++++++++++ libs/xslt/libxslt/xsltutils.h | 313 ++ 49 files changed, 39562 insertions(+) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=c638618cbc5f6f26b0a0…

1 0

Alexandre Julliard : libwine: Avoid including wine/port.h.
by Alexandre Julliard Oct. 20, 2021

Oct. 20, 2021

Module: wine Branch: master Commit: 06f6637363295b6ac9ddd1718358968d09db88d2 URL: https://source.winehq.org/git/wine.git/?a=commit;h=06f6637363295b6ac9ddd171… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Oct 19 18:58:36 2021 +0200 libwine: Avoid including wine/port.h. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- libs/wine/config.c | 7 +++---- libs/wine/debug.c | 7 +++---- libs/wine/ldt.c | 3 ++- libs/wine/loader.c | 6 ++---- libs/wine/mmap.c | 5 +---- libs/wine/port.c | 1 - 6 files changed, 11 insertions(+), 18 deletions(-) diff --git a/libs/wine/config.c b/libs/wine/config.c index b8f1bd5f86d..cb42421c168 100644 --- a/libs/wine/config.c +++ b/libs/wine/config.c @@ -19,7 +19,6 @@ */ #include "config.h" -#include "wine/port.h" #include "wine/asm.h" #ifdef __ASM_OBSOLETE @@ -29,10 +28,10 @@ #include <stdlib.h> #include <string.h> #include <errno.h> +#include <sys/types.h> #include <sys/stat.h> -#ifdef HAVE_UNISTD_H -# include <unistd.h> -#endif +#include <unistd.h> +#include <dlfcn.h> #ifdef HAVE_PWD_H #include <pwd.h> #endif diff --git a/libs/wine/debug.c b/libs/wine/debug.c index 95e6fe6e58c..9cb918d272d 100644 --- a/libs/wine/debug.c +++ b/libs/wine/debug.c @@ -19,7 +19,6 @@ */ #include "config.h" -#include "wine/port.h" #include "wine/asm.h" #ifdef __ASM_OBSOLETE @@ -29,9 +28,9 @@ #include <stdarg.h> #include <string.h> #include <ctype.h> -#ifdef HAVE_SYS_STAT_H -# include <sys/stat.h> -#endif +#include <sys/types.h> +#include <sys/stat.h> +#include <unistd.h> #include "wine/debug.h" diff --git a/libs/wine/ldt.c b/libs/wine/ldt.c index 18b0b9be9bf..3fc1c0cb3d8 100644 --- a/libs/wine/ldt.c +++ b/libs/wine/ldt.c @@ -20,14 +20,15 @@ */ #include "config.h" -#include "wine/port.h" #include <assert.h> #include <stdlib.h> #include <stdarg.h> #include <stdio.h> #include <string.h> +#include <sys/types.h> #include <errno.h> +#include <unistd.h> #include "windef.h" #include "winbase.h" diff --git a/libs/wine/loader.c b/libs/wine/loader.c index 4245beea94b..edb6e37061d 100644 --- a/libs/wine/loader.c +++ b/libs/wine/loader.c @@ -19,7 +19,6 @@ */ #include "config.h" -#include "wine/port.h" #include <assert.h> #include <ctype.h> @@ -35,9 +34,8 @@ #ifdef HAVE_SYS_RESOURCE_H # include <sys/resource.h> #endif -#ifdef HAVE_UNISTD_H -# include <unistd.h> -#endif +#include <unistd.h> +#include <dlfcn.h> #ifdef __APPLE__ #include <crt_externs.h> diff --git a/libs/wine/mmap.c b/libs/wine/mmap.c index b72d2af20d3..86b25b0a7ac 100644 --- a/libs/wine/mmap.c +++ b/libs/wine/mmap.c @@ -19,7 +19,6 @@ */ #include "config.h" -#include "wine/port.h" #include <assert.h> #include <ctype.h> @@ -35,9 +34,7 @@ #ifdef HAVE_SYS_MMAN_H #include <sys/mman.h> #endif -#ifdef HAVE_UNISTD_H -# include <unistd.h> -#endif +#include <unistd.h> #ifdef HAVE_STDINT_H # include <stdint.h> #endif diff --git a/libs/wine/port.c b/libs/wine/port.c index ee804f414a0..b019e1d2fd4 100644 --- a/libs/wine/port.c +++ b/libs/wine/port.c @@ -19,7 +19,6 @@ */ #include "config.h" -#include "wine/port.h" #include "wine/asm.h" #ifdef __ASM_OBSOLETE

1 0

Simon McVittie : winebus.sys: Treat udev actions other than "remove" as "add".
by Alexandre Julliard Oct. 20, 2021

Oct. 20, 2021

Module: wine Branch: master Commit: 22dae167d326036ef3b91eb1d5c45acdaa89eb0c URL: https://source.winehq.org/git/wine.git/?a=commit;h=22dae167d326036ef3b91eb1… Author: Simon McVittie <smcv(a)collabora.com> Date: Wed Oct 20 11:07:26 2021 +0200 winebus.sys: Treat udev actions other than "remove" as "add". As per https://github.com/systemd/systemd/blob/v247-rc1/NEWS#L5 there are more kernel uevent types than just "add" and "remove", and we should be treating everything other than "remove" as being potentially an "add". To cope with this, try_add_device() now checks whether the same device was already added. If so, we ignore it. Signed-off-by: Rémi Bernon <rbernon(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/winebus.sys/bus_udev.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/dlls/winebus.sys/bus_udev.c b/dlls/winebus.sys/bus_udev.c index 1dfce05e4bc..57e5a169a69 100644 --- a/dlls/winebus.sys/bus_udev.c +++ b/dlls/winebus.sys/bus_udev.c @@ -1404,16 +1404,14 @@ static void process_monitor_event(struct udev_monitor *monitor) if (!action) WARN("No action received\n"); - else if (strcmp(action, "add") == 0) + else if (strcmp(action, "remove")) udev_add_device(dev); - else if (strcmp(action, "remove") == 0) + else { impl = find_device_from_udev(dev); if (impl) bus_event_queue_device_removed(&event_queue, &impl->unix_device); else WARN("failed to find device for udev device %p\n", dev); } - else - WARN("Unhandled action %s\n", debugstr_a(action)); udev_device_unref(dev); }

1 0

Zhiyi Zhang : winemac.drv: Pass size in bytes to RegQueryValueExW().
by Alexandre Julliard Oct. 20, 2021

Oct. 20, 2021

Module: wine Branch: master Commit: bb5b1d75546ed16ce548f60facd0d09c81b5a20d URL: https://source.winehq.org/git/wine.git/?a=commit;h=bb5b1d75546ed16ce548f60f… Author: Zhiyi Zhang <zzhang(a)codeweavers.com> Date: Wed Oct 20 10:06:37 2021 +0800 winemac.drv: Pass size in bytes to RegQueryValueExW(). Signed-off-by: Zhiyi Zhang <zzhang(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/winemac.drv/display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/winemac.drv/display.c b/dlls/winemac.drv/display.c index 4a3b1ff39cb..99c852d7ffe 100644 --- a/dlls/winemac.drv/display.c +++ b/dlls/winemac.drv/display.c @@ -1475,7 +1475,7 @@ static BOOL link_device(const WCHAR *instance, const GUID *guid) if (lr) continue; - length = ARRAY_SIZE(device_instance); + length = sizeof(device_instance); lr = RegQueryValueExW(device_key, device_instanceW, NULL, NULL, (BYTE *)device_instance, &length); if (lr || lstrcmpiW(device_instance, instance)) {

1 0

Zhiyi Zhang : winefile: Set size before calling RegQueryValueExW().
by Alexandre Julliard Oct. 20, 2021

Oct. 20, 2021

Module: wine Branch: master Commit: e45d51fddabfa9e5f5d2a19bb8df2e12134dcf45 URL: https://source.winehq.org/git/wine.git/?a=commit;h=e45d51fddabfa9e5f5d2a19b… Author: Zhiyi Zhang <zzhang(a)codeweavers.com> Date: Wed Oct 20 10:07:14 2021 +0800 winefile: Set size before calling RegQueryValueExW(). The value in size may be invalid if previous RegQueryValueExW() calls failed. Signed-off-by: Zhiyi Zhang <zzhang(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- programs/winefile/winefile.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/programs/winefile/winefile.c b/programs/winefile/winefile.c index fa78237cccf..8ad785b924a 100644 --- a/programs/winefile/winefile.c +++ b/programs/winefile/winefile.c @@ -1220,20 +1220,22 @@ static windowOptions load_registry_settings(void) RegOpenKeyExW( HKEY_CURRENT_USER, registry_key, 0, KEY_QUERY_VALUE, &hKey ); - size = sizeof(DWORD); - + size = sizeof(opts.start_x); if( RegQueryValueExW( hKey, reg_start_x, NULL, &type, (LPBYTE) &opts.start_x, &size ) != ERROR_SUCCESS ) opts.start_x = CW_USEDEFAULT; + size = sizeof(opts.start_y); if( RegQueryValueExW( hKey, reg_start_y, NULL, &type, (LPBYTE) &opts.start_y, &size ) != ERROR_SUCCESS ) opts.start_y = CW_USEDEFAULT; + size = sizeof(opts.width); if( RegQueryValueExW( hKey, reg_width, NULL, &type, (LPBYTE) &opts.width, &size ) != ERROR_SUCCESS ) opts.width = CW_USEDEFAULT; + size = sizeof(opts.height); if( RegQueryValueExW( hKey, reg_height, NULL, &type, (LPBYTE) &opts.height, &size ) != ERROR_SUCCESS ) opts.height = CW_USEDEFAULT;

1 0

Zhiyi Zhang : winecfg: Pass size in bytes to RegQueryValueExW().
by Alexandre Julliard Oct. 20, 2021

Oct. 20, 2021

Module: wine Branch: master Commit: b2099bce9bf35697bbb522aede21faf39be21baa URL: https://source.winehq.org/git/wine.git/?a=commit;h=b2099bce9bf35697bbb522ae… Author: Zhiyi Zhang <zzhang(a)codeweavers.com> Date: Wed Oct 20 10:07:06 2021 +0800 winecfg: Pass size in bytes to RegQueryValueExW(). Signed-off-by: Zhiyi Zhang <zzhang(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- programs/winecfg/drive.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/programs/winecfg/drive.c b/programs/winecfg/drive.c index bee5be3af34..b4b4239c003 100644 --- a/programs/winecfg/drive.c +++ b/programs/winecfg/drive.c @@ -140,7 +140,7 @@ static DWORD get_drive_type( char letter ) else { WCHAR buffer[80]; - DWORD size = ARRAY_SIZE(buffer); + DWORD size = sizeof(buffer); if (!RegQueryValueExW( hKey, driveValue, NULL, NULL, (LPBYTE)buffer, &size )) {

1 0

Zhiyi Zhang : cmd: Pass size in bytes to RegQueryValueExW().
by Alexandre Julliard Oct. 20, 2021

Oct. 20, 2021

Module: wine Branch: master Commit: efd98caef1908a05a38201c666218171b5eed765 URL: https://source.winehq.org/git/wine.git/?a=commit;h=efd98caef1908a05a38201c6… Author: Zhiyi Zhang <zzhang(a)codeweavers.com> Date: Wed Oct 20 10:06:56 2021 +0800 cmd: Pass size in bytes to RegQueryValueExW(). Signed-off-by: Zhiyi Zhang <zzhang(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- programs/cmd/builtins.c | 5 +++-- programs/cmd/wcmdmain.c | 4 ++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/programs/cmd/builtins.c b/programs/cmd/builtins.c index a55ce6e0244..d0a954d90fa 100644 --- a/programs/cmd/builtins.c +++ b/programs/cmd/builtins.c @@ -4763,7 +4763,7 @@ void WCMD_assoc (const WCHAR *args, BOOL assoc) { WCHAR *newValue; LONG rc = ERROR_SUCCESS; WCHAR keyValue[MAXSTRING]; - DWORD valueLen = MAXSTRING; + DWORD valueLen; HKEY readKey; /* See if parameter includes '=' */ @@ -4803,7 +4803,7 @@ void WCMD_assoc (const WCHAR *args, BOOL assoc) { if (RegOpenKeyExW(key, subkey, 0, accessOptions, &readKey) == ERROR_SUCCESS) { - valueLen = ARRAY_SIZE(keyValue); + valueLen = sizeof(keyValue); rc = RegQueryValueExW(readKey, NULL, NULL, NULL, (LPBYTE)keyValue, &valueLen); WCMD_output_asis(keyName); WCMD_output_asis(L"="); @@ -4836,6 +4836,7 @@ void WCMD_assoc (const WCHAR *args, BOOL assoc) { if (RegOpenKeyExW(key, subkey, 0, accessOptions, &readKey) == ERROR_SUCCESS) { + valueLen = sizeof(keyValue); rc = RegQueryValueExW(readKey, NULL, NULL, NULL, (LPBYTE)keyValue, &valueLen); WCMD_output_asis(args); WCMD_output_asis(L"="); diff --git a/programs/cmd/wcmdmain.c b/programs/cmd/wcmdmain.c index 8c6ed1c057c..4ed1c96a9c2 100644 --- a/programs/cmd/wcmdmain.c +++ b/programs/cmd/wcmdmain.c @@ -2700,7 +2700,7 @@ int __cdecl wmain (int argc, WCHAR *argvW[]) size = sizeof(DWORD); RegQueryValueExW(key, L"DefaultColor", NULL, NULL, (BYTE *)&value, &size); } else if (type == REG_SZ) { - size = ARRAY_SIZE(strvalue); + size = sizeof(strvalue); RegQueryValueExW(key, L"DefaultColor", NULL, NULL, (BYTE *)strvalue, &size); value = wcstoul(strvalue, NULL, 10); } @@ -2719,7 +2719,7 @@ int __cdecl wmain (int argc, WCHAR *argvW[]) size = sizeof(DWORD); RegQueryValueExW(key, L"DefaultColor", NULL, NULL, (BYTE *)&value, &size); } else if (type == REG_SZ) { - size = ARRAY_SIZE(strvalue); + size = sizeof(strvalue); RegQueryValueExW(key, L"DefaultColor", NULL, NULL, (BYTE *)strvalue, &size); value = wcstoul(strvalue, NULL, 10); }

1 0

Zhiyi Zhang : winex11.drv: Pass size in bytes to RegQueryValueExW().
by Alexandre Julliard Oct. 20, 2021

Oct. 20, 2021

Module: wine Branch: master Commit: 2adf4376d86119b8a6f7cde51c9a972564575bac URL: https://source.winehq.org/git/wine.git/?a=commit;h=2adf4376d86119b8a6f7cde5… Author: Zhiyi Zhang <zzhang(a)codeweavers.com> Date: Wed Oct 20 10:06:47 2021 +0800 winex11.drv: Pass size in bytes to RegQueryValueExW(). Signed-off-by: Zhiyi Zhang <zzhang(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/winex11.drv/display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/winex11.drv/display.c b/dlls/winex11.drv/display.c index 57091522078..7f03f94db90 100644 --- a/dlls/winex11.drv/display.c +++ b/dlls/winex11.drv/display.c @@ -434,7 +434,7 @@ static BOOL link_device(const WCHAR *instance, const GUID *guid) if (lr) continue; - length = ARRAY_SIZE(device_instance); + length = sizeof(device_instance); lr = RegQueryValueExW(device_key, device_instanceW, NULL, NULL, (BYTE *)device_instance, &length); if (lr || lstrcmpiW(device_instance, instance)) {

1 0