May 2021 - Wine-Commits - list.winehq.org

Zebediah Figura : wtsapi32: Implement WTSEnumerateProcessesW().
by Alexandre Julliard May 26, 2021

May 26, 2021

Module: wine Branch: master Commit: 5f8c7c25632ec520d42d3c1cb4adeecbcaaa2f9f URL: https://source.winehq.org/git/wine.git/?a=commit;h=5f8c7c25632ec520d42d3c1c… Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Wed May 26 00:13:42 2021 -0500 wtsapi32: Implement WTSEnumerateProcessesW(). Based on a patch by Sebastian Lackner. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=29903 Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wtsapi32/tests/Makefile.in | 2 +- dlls/wtsapi32/tests/wtsapi.c | 133 ++++++++++++++++++++++++++++++++----- dlls/wtsapi32/wtsapi32.c | 143 ++++++++++++++++++++++++++++++++++++---- include/wtsapi32.h | 1 + 4 files changed, 248 insertions(+), 31 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=5f8c7c25632ec520d42d…

1 0

Alexandre Julliard : ntdll: Remove no longer used syswow64 directory string.
by Alexandre Julliard May 26, 2021

May 26, 2021

Module: wine Branch: master Commit: a71cb210f114ba6e29ae4b6fedf234c809111860 URL: https://source.winehq.org/git/wine.git/?a=commit;h=a71cb210f114ba6e29ae4b6f… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Wed May 26 11:57:42 2021 +0200 ntdll: Remove no longer used syswow64 directory string. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ntdll/loader.c | 1 - dlls/ntdll/ntdll_misc.h | 1 - 2 files changed, 2 deletions(-) diff --git a/dlls/ntdll/loader.c b/dlls/ntdll/loader.c index a0d6573a526..f3a37d4e8a6 100644 --- a/dlls/ntdll/loader.c +++ b/dlls/ntdll/loader.c @@ -78,7 +78,6 @@ const struct unix_funcs *unix_funcs = NULL; const WCHAR windows_dir[] = L"C:\\windows"; /* system directory with trailing backslash */ const WCHAR system_dir[] = L"C:\\windows\\system32\\"; -const WCHAR syswow64_dir[] = L"C:\\windows\\syswow64\\"; HMODULE kernel32_handle = 0; diff --git a/dlls/ntdll/ntdll_misc.h b/dlls/ntdll/ntdll_misc.h index 1e00dcda2ec..30640366f5b 100644 --- a/dlls/ntdll/ntdll_misc.h +++ b/dlls/ntdll/ntdll_misc.h @@ -74,7 +74,6 @@ extern void RELAY_SetupDLL( HMODULE hmod ) DECLSPEC_HIDDEN; extern void SNOOP_SetupDLL( HMODULE hmod ) DECLSPEC_HIDDEN; extern const WCHAR windows_dir[] DECLSPEC_HIDDEN; extern const WCHAR system_dir[] DECLSPEC_HIDDEN; -extern const WCHAR syswow64_dir[] DECLSPEC_HIDDEN; extern HMODULE kernel32_handle DECLSPEC_HIDDEN; extern void (FASTCALL *pBaseThreadInitThunk)(DWORD,LPTHREAD_START_ROUTINE,void *) DECLSPEC_HIDDEN;

1 0

Alistair Leslie-Hughes : wbemprox: Support using record in IWbemClassObject Next.
by Alexandre Julliard May 26, 2021

May 26, 2021

Module: wine Branch: master Commit: d7de82fda01848cd85bae781dda21b983332627a URL: https://source.winehq.org/git/wine.git/?a=commit;h=d7de82fda01848cd85bae781… Author: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Date: Wed May 26 15:59:27 2021 +1000 wbemprox: Support using record in IWbemClassObject Next. Makes the code the same as class_object_Get. Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wbemprox/class.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/dlls/wbemprox/class.c b/dlls/wbemprox/class.c index 2f7752e8671..3b7bc066aea 100644 --- a/dlls/wbemprox/class.c +++ b/dlls/wbemprox/class.c @@ -546,7 +546,17 @@ static HRESULT WINAPI class_object_Next( if (is_method( table, i )) continue; if (!is_result_prop( view, table->columns[i].name )) continue; if (!(prop = SysAllocString( table->columns[i].name ))) return E_OUTOFMEMORY; - if ((hr = get_propval( view, obj->index, prop, pVal, pType, plFlavor )) != S_OK) + if (obj->record) + { + UINT index; + + if ((hr = get_column_index( table, table->columns[i].name, &index )) == S_OK) + hr = record_get_value( obj->record, index, pVal, pType ); + } + else + hr = get_propval( view, obj->index, prop, pVal, pType, plFlavor ); + + if (FAILED(hr)) { SysFreeString( prop ); return hr;

1 0

Alistair Leslie-Hughes : wbemprox: Support only getting type in record_get_value.
by Alexandre Julliard May 26, 2021

May 26, 2021

Module: wine Branch: master Commit: 6daec612cf7effccb3d89bbad3d1ac1ea279bd68 URL: https://source.winehq.org/git/wine.git/?a=commit;h=6daec612cf7effccb3d89bba… Author: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Date: Wed May 26 15:59:26 2021 +1000 wbemprox: Support only getting type in record_get_value. Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wbemprox/class.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dlls/wbemprox/class.c b/dlls/wbemprox/class.c index 2f2d3ef2bfb..2f7752e8671 100644 --- a/dlls/wbemprox/class.c +++ b/dlls/wbemprox/class.c @@ -354,6 +354,7 @@ static HRESULT record_get_value( const struct record *record, UINT index, VARIAN VARTYPE vartype = to_vartype( record->fields[index].type & CIM_TYPE_MASK ); if (type) *type = record->fields[index].type; + if (!var) return S_OK; if (record->fields[index].type & CIM_FLAG_ARRAY) {

1 0

Alexandre Julliard : kernel32: Fix GetLogicalProcessorInformationEx() usage.
by Alexandre Julliard May 26, 2021

May 26, 2021

Module: wine Branch: master Commit: 171de0a7f6510a9fa1e2de4f601e31c3208254fd URL: https://source.winehq.org/git/wine.git/?a=commit;h=171de0a7f6510a9fa1e2de4f… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Wed May 26 21:19:42 2021 +0200 kernel32: Fix GetLogicalProcessorInformationEx() usage. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/kernel32/process.c | 57 ++++++++++++++++------------------------ dlls/ntoskrnl.exe/tests/driver.c | 2 +- 2 files changed, 24 insertions(+), 35 deletions(-) diff --git a/dlls/kernel32/process.c b/dlls/kernel32/process.c index aa0922f5164..17a23cca08d 100644 --- a/dlls/kernel32/process.c +++ b/dlls/kernel32/process.c @@ -604,24 +604,34 @@ HRESULT WINAPI RegisterApplicationRecoveryCallback(APPLICATION_RECOVERY_CALLBACK return S_OK; } +static SYSTEM_LOGICAL_PROCESSOR_INFORMATION_EX *get_logical_processor_info(void) +{ + DWORD size = 0; + SYSTEM_LOGICAL_PROCESSOR_INFORMATION_EX *info; + + GetLogicalProcessorInformationEx( RelationGroup, NULL, &size ); + if (GetLastError() != ERROR_INSUFFICIENT_BUFFER) return NULL; + if (!(info = HeapAlloc( GetProcessHeap(), 0, size ))) return NULL; + if (!GetLogicalProcessorInformationEx( RelationGroup, info, &size )) + { + HeapFree( GetProcessHeap(), 0, info ); + return NULL; + } + return info; +} + + /*********************************************************************** * GetActiveProcessorGroupCount (KERNEL32.@) */ WORD WINAPI GetActiveProcessorGroupCount(void) { WORD groups; - DWORD size = 0; SYSTEM_LOGICAL_PROCESSOR_INFORMATION_EX *info; TRACE("()\n"); - if (!GetLogicalProcessorInformationEx(RelationGroup, NULL, &size)) return 0; - if (!(info = HeapAlloc(GetProcessHeap(), 0, size))) return 0; - if (!GetLogicalProcessorInformationEx(RelationGroup, info, &size)) - { - HeapFree(GetProcessHeap(), 0, info); - return 0; - } + if (!(info = get_logical_processor_info())) return 0; groups = info->Group.ActiveGroupCount; @@ -635,18 +645,11 @@ WORD WINAPI GetActiveProcessorGroupCount(void) DWORD WINAPI GetActiveProcessorCount(WORD group) { DWORD cpus = 0; - DWORD size = 0; SYSTEM_LOGICAL_PROCESSOR_INFORMATION_EX *info; TRACE("(0x%x)\n", group); - if (!GetLogicalProcessorInformationEx(RelationGroup, NULL, &size)) return 0; - if (!(info = HeapAlloc(GetProcessHeap(), 0, size))) return 0; - if (!GetLogicalProcessorInformationEx(RelationGroup, info, &size)) - { - HeapFree(GetProcessHeap(), 0, info); - return 0; - } + if (!(info = get_logical_processor_info())) return 0; if (group == ALL_PROCESSOR_GROUPS) { @@ -669,27 +672,20 @@ DWORD WINAPI GetActiveProcessorCount(WORD group) DWORD WINAPI GetMaximumProcessorCount(WORD group) { DWORD cpus = 0; - DWORD size = 0; SYSTEM_LOGICAL_PROCESSOR_INFORMATION_EX *info; TRACE("(0x%x)\n", group); - if (!GetLogicalProcessorInformationEx(RelationGroup, NULL, &size)) return 0; - if (!(info = HeapAlloc(GetProcessHeap(), 0, size))) return 0; - if (!GetLogicalProcessorInformationEx(RelationGroup, info, &size)) - { - HeapFree(GetProcessHeap(), 0, info); - return 0; - } + if (!(info = get_logical_processor_info())) return 0; if (group == ALL_PROCESSOR_GROUPS) { - for (group = 0; group < info->Group.ActiveGroupCount; group++) + for (group = 0; group < info->Group.MaximumGroupCount; group++) cpus += info->Group.GroupInfo[group].MaximumProcessorCount; } else { - if (group < info->Group.ActiveGroupCount) + if (group < info->Group.MaximumGroupCount) cpus = info->Group.GroupInfo[group].MaximumProcessorCount; } @@ -703,18 +699,11 @@ DWORD WINAPI GetMaximumProcessorCount(WORD group) WORD WINAPI GetMaximumProcessorGroupCount(void) { WORD groups; - DWORD size = 0; SYSTEM_LOGICAL_PROCESSOR_INFORMATION_EX *info; TRACE("()\n"); - if (!GetLogicalProcessorInformationEx(RelationGroup, NULL, &size)) return 0; - if (!(info = HeapAlloc(GetProcessHeap(), 0, size))) return 0; - if (!GetLogicalProcessorInformationEx(RelationGroup, info, &size)) - { - HeapFree(GetProcessHeap(), 0, info); - return 0; - } + if (!(info = get_logical_processor_info())) return 0; groups = info->Group.MaximumGroupCount; diff --git a/dlls/ntoskrnl.exe/tests/driver.c b/dlls/ntoskrnl.exe/tests/driver.c index 0d991cd98d6..f1c72d8fdaf 100644 --- a/dlls/ntoskrnl.exe/tests/driver.c +++ b/dlls/ntoskrnl.exe/tests/driver.c @@ -1832,7 +1832,7 @@ static void test_affinity(void) ok(!!pKeRevertToUserAffinityThreadEx, "KeRevertToUserAffinityThreadEx is not available.\n"); count = pKeQueryActiveProcessorCountEx(1); - todo_wine ok(!count, "Got unexpected count %u.\n", count); + ok(!count, "Got unexpected count %u.\n", count); cpu_count = pKeQueryActiveProcessorCountEx(0); ok(cpu_count, "Got unexpected cpu_count %u.\n", cpu_count);

1 0

Jeremy Newman : switching IRC to irc.libera.chat
by Jeremy Newman May 26, 2021

May 26, 2021

Module: website Branch: master Commit: 2d01ffc96add684d4faace0a95ed8f0c4df1d1ef URL: https://source.winehq.org/git/website.git/?a=commit;h=2d01ffc96add684d4faac… Author: Jeremy Newman <jnewman(a)codeweavers.com> Date: Wed May 26 10:22:14 2021 -0500 switching IRC to irc.libera.chat --- templates/en/irc.template | 27 ++++++++++++++------------- templates/es/irc.template | 17 ++++++++--------- templates/fr/irc.template | 12 ++++++------ templates/ko/irc.template | 26 +++++++++++++------------- templates/nl/irc.template | 14 +++++++------- templates/pl/irc.template | 10 +++++----- templates/pt/irc.template | 10 +++++----- templates/tr/irc.template | 10 +++++----- templates/zh-cn/irc.template | 28 ++++++++++++++-------------- 9 files changed, 77 insertions(+), 77 deletions(-) Diff: https://source.winehq.org/git/website.git/?a=commitdiff;h=2d01ffc96add684d4…

1 0

Alex Henrie : kernel32: Reimplement GetMaximumProcessorCount on top of GetLogicalProcessorInformationEx.
by Alexandre Julliard May 25, 2021

May 25, 2021

Module: wine Branch: master Commit: 04114db90bf1abc5079417cfa948a3e9ab7a413d URL: https://source.winehq.org/git/wine.git/?a=commit;h=04114db90bf1abc5079417cf… Author: Alex Henrie <alexhenrie24(a)gmail.com> Date: Mon May 24 02:10:43 2021 -0600 kernel32: Reimplement GetMaximumProcessorCount on top of GetLogicalProcessorInformationEx. Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/kernel32/process.c | 27 +++++++++++++++++++++++++-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git a/dlls/kernel32/process.c b/dlls/kernel32/process.c index acdedd979f3..6de094950e3 100644 --- a/dlls/kernel32/process.c +++ b/dlls/kernel32/process.c @@ -668,9 +668,32 @@ DWORD WINAPI GetActiveProcessorCount(WORD group) */ DWORD WINAPI GetMaximumProcessorCount(WORD group) { - DWORD cpus = system_info.NumberOfProcessors; + DWORD cpus = 0; + DWORD size = 0; + SYSTEM_LOGICAL_PROCESSOR_INFORMATION_EX *info; - FIXME("(0x%x): semi-stub, returning %u\n", group, cpus); + TRACE("(0x%x)\n", group); + + if (!GetLogicalProcessorInformationEx(RelationGroup, NULL, &size)) return 0; + if (!(info = HeapAlloc(GetProcessHeap(), 0, size))) return 0; + if (!GetLogicalProcessorInformationEx(RelationGroup, info, &size)) + { + HeapFree(GetProcessHeap(), 0, info); + return 0; + } + + if (group == ALL_PROCESSOR_GROUPS) + { + for (group = 0; group < info->Group.ActiveGroupCount; group++) + cpus += info->Group.GroupInfo[group].MaximumProcessorCount; + } + else + { + if (group < info->Group.ActiveGroupCount) + cpus = info->Group.GroupInfo[group].MaximumProcessorCount; + } + + HeapFree(GetProcessHeap(), 0, info); return cpus; }

1 0

Alex Henrie : kernel32: Reimplement GetMaximumProcessorGroupCount on top of GetLogicalProcessorInformationEx.
by Alexandre Julliard May 25, 2021

May 25, 2021

Module: wine Branch: master Commit: 8ddff3f51faca2c0824e204a69f69e241fb93d15 URL: https://source.winehq.org/git/wine.git/?a=commit;h=8ddff3f51faca2c0824e204a… Author: Alex Henrie <alexhenrie24(a)gmail.com> Date: Mon May 24 02:10:44 2021 -0600 kernel32: Reimplement GetMaximumProcessorGroupCount on top of GetLogicalProcessorInformationEx. Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/kernel32/process.c | 20 ++++++++++++++++++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/dlls/kernel32/process.c b/dlls/kernel32/process.c index 6de094950e3..aa0922f5164 100644 --- a/dlls/kernel32/process.c +++ b/dlls/kernel32/process.c @@ -702,8 +702,24 @@ DWORD WINAPI GetMaximumProcessorCount(WORD group) */ WORD WINAPI GetMaximumProcessorGroupCount(void) { - FIXME("semi-stub, always returning 1\n"); - return 1; + WORD groups; + DWORD size = 0; + SYSTEM_LOGICAL_PROCESSOR_INFORMATION_EX *info; + + TRACE("()\n"); + + if (!GetLogicalProcessorInformationEx(RelationGroup, NULL, &size)) return 0; + if (!(info = HeapAlloc(GetProcessHeap(), 0, size))) return 0; + if (!GetLogicalProcessorInformationEx(RelationGroup, info, &size)) + { + HeapFree(GetProcessHeap(), 0, info); + return 0; + } + + groups = info->Group.MaximumGroupCount; + + HeapFree(GetProcessHeap(), 0, info); + return groups; } /***********************************************************************

1 0

Rémi Bernon : dinput/tests: Check IDirectInputDevice_EnumObjects error codes.
by Alexandre Julliard May 25, 2021

May 25, 2021

Module: wine Branch: master Commit: ab8e41678704196067de1f5618f4cea62717408a URL: https://source.winehq.org/git/wine.git/?a=commit;h=ab8e41678704196067de1f56… Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Tue May 25 18:48:56 2021 +0200 dinput/tests: Check IDirectInputDevice_EnumObjects error codes. Signed-off-by: Rémi Bernon <rbernon(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/dinput/device.c | 4 ++++ dlls/dinput/tests/device.c | 3 +++ 2 files changed, 7 insertions(+) diff --git a/dlls/dinput/device.c b/dlls/dinput/device.c index 972cfd604c7..c6385e6c025 100644 --- a/dlls/dinput/device.c +++ b/dlls/dinput/device.c @@ -1259,6 +1259,8 @@ HRESULT WINAPI IDirectInputDevice2AImpl_EnumObjects(LPDIRECTINPUTDEVICE8A iface, _dump_EnumObjects_flags(dwFlags); TRACE("\n"); + if (!lpCallback) return DIERR_INVALIDPARAM; + /* Only the fields till dwFFMaxForce are relevant */ memset(&ddoi, 0, sizeof(ddoi)); ddoi.dwSize = FIELD_OFFSET(DIDEVICEOBJECTINSTANCEA, dwFFMaxForce); @@ -1289,6 +1291,8 @@ HRESULT WINAPI IDirectInputDevice2WImpl_EnumObjects(LPDIRECTINPUTDEVICE8W iface, _dump_EnumObjects_flags(dwFlags); TRACE("\n"); + if (!lpCallback) return DIERR_INVALIDPARAM; + /* Only the fields till dwFFMaxForce are relevant */ memset(&ddoi, 0, sizeof(ddoi)); ddoi.dwSize = FIELD_OFFSET(DIDEVICEOBJECTINSTANCEW, dwFFMaxForce); diff --git a/dlls/dinput/tests/device.c b/dlls/dinput/tests/device.c index 071fc6de6bb..9be00a671fb 100644 --- a/dlls/dinput/tests/device.c +++ b/dlls/dinput/tests/device.c @@ -84,6 +84,9 @@ static void test_object_info(IDirectInputDeviceA *device, HWND hwnd) DWORD cnt = 0; DIDEVICEOBJECTDATA buffer[5]; + hr = IDirectInputDevice_EnumObjects(device, NULL, &cnt, DIDFT_ALL); + ok(hr == DIERR_INVALIDPARAM, "IDirectInputDevice_EnumObjects returned %08x, expected %08x\n", hr, DIERR_INVALIDPARAM); + hr = IDirectInputDevice_EnumObjects(device, enum_callback, &cnt, DIDFT_ALL); ok(SUCCEEDED(hr), "EnumObjects() failed: %08x\n", hr);

1 0

Alex Henrie : kernel32: Fix return type of GetMaximumProcessorGroupCount.
by Alexandre Julliard May 25, 2021

May 25, 2021

Module: wine Branch: master Commit: 0cd033a07e7e3896fa6d8733d34a69ddb54c75b9 URL: https://source.winehq.org/git/wine.git/?a=commit;h=0cd033a07e7e3896fa6d8733… Author: Alex Henrie <alexhenrie24(a)gmail.com> Date: Mon May 24 02:10:40 2021 -0600 kernel32: Fix return type of GetMaximumProcessorGroupCount. Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/kernel32/process.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/kernel32/process.c b/dlls/kernel32/process.c index b31d73bc5a5..9041b00d512 100644 --- a/dlls/kernel32/process.c +++ b/dlls/kernel32/process.c @@ -638,7 +638,7 @@ DWORD WINAPI GetMaximumProcessorCount(WORD group) /*********************************************************************** * GetMaximumProcessorGroupCount (KERNEL32.@) */ -DWORD WINAPI GetMaximumProcessorGroupCount(void) +WORD WINAPI GetMaximumProcessorGroupCount(void) { FIXME("semi-stub, always returning 1\n"); return 1;

1 0