September 2021 - Wine-Commits

Zhiyi Zhang : hh: Add system DPI awareness settings to the application manifest.
by Alexandre Julliard Sept. 6, 2021

Sept. 6, 2021

Module: wine Branch: master Commit: 3f95a56e59117f73ad456ddd59d615aaa93dbee3 URL: https://source.winehq.org/git/wine.git/?a=commit;h=3f95a56e59117f73ad456ddd… Author: Zhiyi Zhang <zzhang(a)codeweavers.com> Date: Mon Sep 6 16:55:01 2021 +0800 hh: Add system DPI awareness settings to the application manifest. Signed-off-by: Zhiyi Zhang <zzhang(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- programs/hh/hh.manifest | 9 +++++++++ programs/hh/hh.rc | 4 ++++ 2 files changed, 13 insertions(+) diff --git a/programs/hh/hh.manifest b/programs/hh/hh.manifest new file mode 100644 index 00000000000..be1e025a548 --- /dev/null +++ b/programs/hh/hh.manifest @@ -0,0 +1,9 @@ +<?xml version="1.0" encoding="UTF-8" standalone="yes"?> +<assembly xmlns="urn:schemas-microsoft-com:asm.v1" manifestVersion="1.0"> +<assemblyIdentity type="win32" name="Wine.HelpViewer" version="0.0.0.0"/> +<application xmlns="urn:schemas-microsoft-com:asm.v3"> + <windowsSettings> + <dpiAware xmlns="http://schemas.microsoft.com/SMI/2005/WindowsSettings">true</dpiAware> + </windowsSettings> +</application> +</assembly> diff --git a/programs/hh/hh.rc b/programs/hh/hh.rc index d397dc63ee4..36c142345b9 100644 --- a/programs/hh/hh.rc +++ b/programs/hh/hh.rc @@ -18,6 +18,10 @@ * License along with this library; if not, write to the Free Software * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA */ +#include <winuser.h> /* @makedep: winhelp.ico */ 101 ICON winhelp.ico + +/* @makedep: hh.manifest */ +1 RT_MANIFEST hh.manifest

1 0

Eric Pouech : dbghelp: SymLoadModule* should return the base address in case of success, and 0 otherwise.
by Alexandre Julliard Sept. 6, 2021

Sept. 6, 2021

Module: wine Branch: master Commit: f2f27b6b9589a31cf92600db1b3cc8a1610dbdca URL: https://source.winehq.org/git/wine.git/?a=commit;h=f2f27b6b9589a31cf92600db… Author: Eric Pouech <eric.pouech(a)gmail.com> Date: Mon Sep 6 10:39:49 2021 +0200 dbghelp: SymLoadModule* should return the base address in case of success, and 0 otherwise. Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/dbghelp/module.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/dlls/dbghelp/module.c b/dlls/dbghelp/module.c index 3bc2a9e143a..f2c0eca5df6 100644 --- a/dlls/dbghelp/module.c +++ b/dlls/dbghelp/module.c @@ -786,19 +786,19 @@ DWORD64 WINAPI SymLoadModuleExW(HANDLE hProcess, HANDLE hFile, PCWSTR wImageNam if (Data) FIXME("Unsupported load data parameter %p for %s\n", Data, debugstr_w(wImageName)); - if (!validate_addr64(BaseOfDll)) return FALSE; + if (!validate_addr64(BaseOfDll)) return 0; - if (!(pcs = process_find_by_handle(hProcess))) return FALSE; + if (!(pcs = process_find_by_handle(hProcess))) return 0; if (Flags & SLMFLAG_VIRTUAL) { - if (!wImageName) return FALSE; + if (!wImageName) return 0; module = module_new(pcs, wImageName, DMT_PE, TRUE, BaseOfDll, SizeOfDll, 0, 0); - if (!module) return FALSE; + if (!module) return 0; if (wModuleName) module_set_module(module, wModuleName); module->module.SymType = SymVirtual; - return TRUE; + return module->module.BaseOfImage; } if (Flags & ~(SLMFLAG_VIRTUAL)) FIXME("Unsupported Flags %08x for %s\n", Flags, debugstr_w(wImageName));

1 0

Dmitry Timoshkov : wininet: Fix some InternetErrorDlg() conditions returning ERROR_INVALID_PARAMETER.
by Alexandre Julliard Sept. 6, 2021

Sept. 6, 2021

Module: wine Branch: master Commit: dc48a9ac067490a90470c2f9b5cdfd268e12f8d5 URL: https://source.winehq.org/git/wine.git/?a=commit;h=dc48a9ac067490a90470c2f9… Author: Dmitry Timoshkov <dmitry(a)baikal.ru> Date: Mon Sep 6 15:26:28 2021 +0200 wininet: Fix some InternetErrorDlg() conditions returning ERROR_INVALID_PARAMETER. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wininet/dialogs.c | 5 +---- dlls/wininet/tests/internet.c | 3 +-- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/dlls/wininet/dialogs.c b/dlls/wininet/dialogs.c index 7af1bcd59f9..25ed1f2a651 100644 --- a/dlls/wininet/dialogs.c +++ b/dlls/wininet/dialogs.c @@ -498,7 +498,7 @@ DWORD WINAPI InternetErrorDlg(HWND hWnd, HINTERNET hRequest, if( !dwError && !(dwFlags & FLAGS_ERROR_UI_FILTER_FOR_ERRORS ) ) break; if(!req) - return ERROR_INVALID_HANDLE; + return ERROR_INVALID_PARAMETER; switch(req->status_code) { case HTTP_STATUS_PROXY_AUTH_REQ: @@ -523,9 +523,6 @@ DWORD WINAPI InternetErrorDlg(HWND hWnd, HINTERNET hRequest, res = ERROR_CANCELLED; break; } - if(!req) - return ERROR_INVALID_HANDLE; - if( dwFlags & ~FLAGS_ERROR_UI_FLAGS_CHANGE_OPTIONS ) FIXME("%08x contains unsupported flags.\n", dwFlags); diff --git a/dlls/wininet/tests/internet.c b/dlls/wininet/tests/internet.c index 7d4935dac01..e83b142e998 100644 --- a/dlls/wininet/tests/internet.c +++ b/dlls/wininet/tests/internet.c @@ -1599,7 +1599,6 @@ static void test_InternetErrorDlg(void) res = InternetErrorDlg(hwnd, NULL, i, FLAGS_ERROR_UI_FLAGS_NO_UI, NULL); todo_wine_if(i == ERROR_HTTP_COOKIE_NEEDS_CONFIRMATION || - i == ERROR_INTERNET_INCORRECT_PASSWORD || i == ERROR_INTERNET_INSERT_CDROM || i == ERROR_INTERNET_CLIENT_AUTH_CERT_NEEDED || i == ERROR_INTERNET_HTTPS_TO_HTTP_ON_REDIR || @@ -1611,7 +1610,7 @@ static void test_InternetErrorDlg(void) i != ERROR_INTERNET_SEC_CERT_CN_INVALID && i != ERROR_INTERNET_INVALID_CA && i != ERROR_INTERNET_SEC_CERT_ERRORS && i != ERROR_INTERNET_SEC_CERT_REV_FAILED && i != ERROR_INTERNET_MIXED_SECURITY && i != ERROR_INTERNET_POST_IS_NON_SECURE && - i != ERROR_INTERNET_HTTPS_HTTP_SUBMIT_REDIR && + i != ERROR_INTERNET_HTTPS_HTTP_SUBMIT_REDIR && i != ERROR_INTERNET_INCORRECT_PASSWORD && i != ERROR_INTERNET_SEC_CERT_WEAK_SIGNATURE && i != ERROR_INTERNET_BAD_AUTO_PROXY_SCRIPT && i != ERROR_INTERNET_UNABLE_TO_DOWNLOAD_SCRIPT && i != ERROR_HTTP_REDIRECT_NEEDS_CONFIRMATION)

1 0

Eric Pouech : include: Extend IMAGEHLP_MODULE*64 with new fields.
by Alexandre Julliard Sept. 6, 2021

Sept. 6, 2021

Module: wine Branch: master Commit: 55fda3a415a0280361e2e247084f5c89218b8c02 URL: https://source.winehq.org/git/wine.git/?a=commit;h=55fda3a415a0280361e2e247… Author: Eric Pouech <eric.pouech(a)gmail.com> Date: Mon Sep 6 10:40:20 2021 +0200 include: Extend IMAGEHLP_MODULE*64 with new fields. Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- include/imagehlp.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/include/imagehlp.h b/include/imagehlp.h index 8c8250d1f19..5ee978a3d4c 100644 --- a/include/imagehlp.h +++ b/include/imagehlp.h @@ -459,6 +459,8 @@ typedef struct _IMAGEHLP_MODULE64 BOOL TypeInfo; BOOL SourceIndexed; BOOL Publics; + DWORD MachineType; + DWORD Reserved; } IMAGEHLP_MODULE64, *PIMAGEHLP_MODULE64; typedef struct _IMAGEHLP_MODULEW64 @@ -486,6 +488,8 @@ typedef struct _IMAGEHLP_MODULEW64 BOOL TypeInfo; BOOL SourceIndexed; BOOL Publics; + DWORD MachineType; + DWORD Reserved; } IMAGEHLP_MODULEW64, *PIMAGEHLP_MODULEW64; typedef struct _IMAGEHLP_LINE {

1 0

Eric Pouech : dbghelp: Use the correct module name for lookups including module's name.
by Alexandre Julliard Sept. 6, 2021

Sept. 6, 2021

Module: wine Branch: master Commit: b882ab2b254d065f5a00e3d3af19fbd73fb8457b URL: https://source.winehq.org/git/wine.git/?a=commit;h=b882ab2b254d065f5a00e3d3… Author: Eric Pouech <eric.pouech(a)gmail.com> Date: Mon Sep 6 10:40:14 2021 +0200 dbghelp: Use the correct module name for lookups including module's name. (modulename is truncated at 64 chars, while module.ModuleName at 32 chars) Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/dbghelp/elf_module.c | 3 +-- dlls/dbghelp/module.c | 2 +- dlls/dbghelp/symbol.c | 4 ++-- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/dlls/dbghelp/elf_module.c b/dlls/dbghelp/elf_module.c index cc3fbcdb7ba..e23de1a8c63 100644 --- a/dlls/dbghelp/elf_module.c +++ b/dlls/dbghelp/elf_module.c @@ -1068,8 +1068,7 @@ static BOOL elf_load_debug_info_from_map(struct module* module, lret = dwarf2_parse(module, module->reloc_delta, thunks, fmap); ret = ret || lret; } - if (wcsstr(module->module.ModuleName, S_ElfW) || - !wcscmp(module->module.ModuleName, S_WineLoaderW)) + if (wcsstr(module->modulename, S_ElfW) || !wcscmp(module->modulename, S_WineLoaderW)) { /* add the thunks for native libraries */ if (!(dbghelp_options & SYMOPT_PUBLICS_ONLY)) diff --git a/dlls/dbghelp/module.c b/dlls/dbghelp/module.c index df341284d6a..01803b027d8 100644 --- a/dlls/dbghelp/module.c +++ b/dlls/dbghelp/module.c @@ -271,7 +271,7 @@ struct module* module_find_by_nameW(const struct process* pcs, const WCHAR* name for (module = pcs->lmodules; module; module = module->next) { - if (!wcsicmp(name, module->module.ModuleName)) return module; + if (!wcsicmp(name, module->modulename)) return module; } SetLastError(ERROR_INVALID_NAME); return NULL; diff --git a/dlls/dbghelp/symbol.c b/dlls/dbghelp/symbol.c index 7e79950906a..09407e04fc0 100644 --- a/dlls/dbghelp/symbol.c +++ b/dlls/dbghelp/symbol.c @@ -1089,7 +1089,7 @@ static BOOL sym_enum(HANDLE hProcess, ULONG64 BaseOfDll, PCWSTR Mask, { if (pair.requested->type == DMT_PE && module_get_debug(&pair)) { - if (SymMatchStringW(pair.requested->module.ModuleName, mod, FALSE) && + if (SymMatchStringW(pair.requested->modulename, mod, FALSE) && symt_enum_module(&pair, bang + 1, se)) break; } @@ -1104,7 +1104,7 @@ static BOOL sym_enum(HANDLE hProcess, ULONG64 BaseOfDll, PCWSTR Mask, !module_get_containee(pair.pcs, pair.requested) && module_get_debug(&pair)) { - if (SymMatchStringW(pair.requested->module.ModuleName, mod, FALSE) && + if (SymMatchStringW(pair.requested->modulename, mod, FALSE) && symt_enum_module(&pair, bang + 1, se)) break; }

1 0

Dmitry Timoshkov : wininet/tests: Add some tests for InternetErrorDlg(FLAGS_ERROR_UI_FILTER_FOR_ERRORS).
by Alexandre Julliard Sept. 6, 2021

Sept. 6, 2021

Module: wine Branch: master Commit: 3ffca86641df0366853d624b8ffeb8b54503cf0b URL: https://source.winehq.org/git/wine.git/?a=commit;h=3ffca86641df0366853d624b… Author: Dmitry Timoshkov <dmitry(a)baikal.ru> Date: Mon Sep 6 15:26:20 2021 +0200 wininet/tests: Add some tests for InternetErrorDlg(FLAGS_ERROR_UI_FILTER_FOR_ERRORS). Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wininet/tests/internet.c | 45 ++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 42 insertions(+), 3 deletions(-) diff --git a/dlls/wininet/tests/internet.c b/dlls/wininet/tests/internet.c index 9feafc4118e..7d4935dac01 100644 --- a/dlls/wininet/tests/internet.c +++ b/dlls/wininet/tests/internet.c @@ -1514,7 +1514,7 @@ static void test_InternetErrorDlg(void) for(i = INTERNET_ERROR_BASE; i < INTERNET_ERROR_LAST; i++) { - DWORD expected = ERROR_CANCELLED, test_flags = 0, j; + DWORD expected = ERROR_CANCELLED, expected2 = ERROR_SUCCESS, test_flags = 0, j; for (j = 0; j < ARRAY_SIZE(no_ui_res); ++j) { @@ -1522,6 +1522,7 @@ static void test_InternetErrorDlg(void) { test_flags = no_ui_res[j].test_flags; expected = no_ui_res[j].res; + expected2 = no_ui_res[j].res; } } @@ -1551,12 +1552,17 @@ static void test_InternetErrorDlg(void) { case ERROR_INTERNET_CHG_POST_IS_NON_SECURE: if (broken(res == ERROR_CANCELLED)) /* before win10 returns ERROR_CANCELLED */ + { expected = ERROR_CANCELLED; + expected2 = ERROR_CANCELLED; + } break; default: - if(broken((expected == ERROR_CANCELLED || i == ERROR_INTERNET_CHG_POST_IS_NON_SECURE) && - res == ERROR_NOT_SUPPORTED)) /* XP, Win7, Win8 */ + if(broken(expected == ERROR_CANCELLED && res == ERROR_NOT_SUPPORTED)) /* XP, Win7, Win8 */ + { expected = ERROR_NOT_SUPPORTED; + expected2 = ERROR_SUCCESS; + } break; } @@ -1572,10 +1578,24 @@ static void test_InternetErrorDlg(void) i == ERROR_INTERNET_CHG_POST_IS_NON_SECURE) ok(res == expected, "Got %d, expected %d (%d)\n", res, expected, i); + res = InternetErrorDlg(NULL, req, i, FLAGS_ERROR_UI_FILTER_FOR_ERRORS | FLAGS_ERROR_UI_FLAGS_NO_UI, NULL); + todo_wine_if(i != ERROR_INTERNET_INCORRECT_PASSWORD && i != ERROR_INTERNET_SEC_CERT_DATE_INVALID && + i != ERROR_INTERNET_SEC_CERT_CN_INVALID && i != ERROR_INTERNET_INVALID_CA && + i != ERROR_INTERNET_SEC_CERT_ERRORS && i != ERROR_INTERNET_SEC_CERT_REV_FAILED && + i != ERROR_INTERNET_HTTP_TO_HTTPS_ON_REDIR && i != ERROR_INTERNET_POST_IS_NON_SECURE && + i != ERROR_INTERNET_MIXED_SECURITY && + i != ERROR_INTERNET_POST_IS_NON_SECURE && i != ERROR_INTERNET_CLIENT_AUTH_CERT_NEEDED && + i != ERROR_INTERNET_HTTPS_HTTP_SUBMIT_REDIR && i != ERROR_INTERNET_INSERT_CDROM && + i != ERROR_INTERNET_SEC_CERT_WEAK_SIGNATURE && i != ERROR_INTERNET_BAD_AUTO_PROXY_SCRIPT && + i != ERROR_INTERNET_UNABLE_TO_DOWNLOAD_SCRIPT && i != ERROR_HTTP_REDIRECT_NEEDS_CONFIRMATION) + ok(res == expected2, "Got %d, expected %d (%d)\n", res, expected2, i); /* With a null req */ if(test_flags & FLAG_NEEDREQ) + { expected = ERROR_INVALID_PARAMETER; + expected2 = ERROR_INVALID_PARAMETER; + } res = InternetErrorDlg(hwnd, NULL, i, FLAGS_ERROR_UI_FLAGS_NO_UI, NULL); todo_wine_if(i == ERROR_HTTP_COOKIE_NEEDS_CONFIRMATION || @@ -1585,8 +1605,27 @@ static void test_InternetErrorDlg(void) i == ERROR_INTERNET_HTTPS_TO_HTTP_ON_REDIR || i == ERROR_INTERNET_CHG_POST_IS_NON_SECURE) ok(res == expected, "Got %d, expected %d (%d)\n", res, expected, i); + + res = InternetErrorDlg(NULL, NULL, i, FLAGS_ERROR_UI_FILTER_FOR_ERRORS | FLAGS_ERROR_UI_FLAGS_NO_UI, NULL); + todo_wine_if(i != ERROR_INTERNET_SEC_CERT_DATE_INVALID && i != ERROR_INTERNET_HTTP_TO_HTTPS_ON_REDIR && + i != ERROR_INTERNET_SEC_CERT_CN_INVALID && i != ERROR_INTERNET_INVALID_CA && + i != ERROR_INTERNET_SEC_CERT_ERRORS && i != ERROR_INTERNET_SEC_CERT_REV_FAILED && + i != ERROR_INTERNET_MIXED_SECURITY && i != ERROR_INTERNET_POST_IS_NON_SECURE && + i != ERROR_INTERNET_HTTPS_HTTP_SUBMIT_REDIR && + i != ERROR_INTERNET_SEC_CERT_WEAK_SIGNATURE && i != ERROR_INTERNET_BAD_AUTO_PROXY_SCRIPT && + i != ERROR_INTERNET_UNABLE_TO_DOWNLOAD_SCRIPT && + i != ERROR_HTTP_REDIRECT_NEEDS_CONFIRMATION) + ok(res == expected2, "Got %d, expected %d (%d)\n", res, expected2, i); } + res = InternetErrorDlg(NULL, req, 0xdeadbeef, FLAGS_ERROR_UI_FILTER_FOR_ERRORS | FLAGS_ERROR_UI_FLAGS_NO_UI, NULL); +todo_wine + ok(res == ERROR_SUCCESS, "Got %d, expected ERROR_SUCCESS\n", res); + + res = InternetErrorDlg(NULL, NULL, 0xdeadbeef, FLAGS_ERROR_UI_FILTER_FOR_ERRORS | FLAGS_ERROR_UI_FLAGS_NO_UI, NULL); +todo_wine + ok(res == ERROR_SUCCESS, "Got %d, expected ERROR_SUCCESS\n", res); + res = InternetCloseHandle(req); ok(res == TRUE, "InternetCloseHandle failed: 0x%08x\n", GetLastError()); res = InternetCloseHandle(con);

1 0

Alex Henrie : cmd: Fix capitalization of WCMD_ReadFile in comment.
by Alexandre Julliard Sept. 6, 2021

Sept. 6, 2021

Module: wine Branch: master Commit: 14bbccf756a5be3ce3029d0149e7b8d7e465fd4e URL: https://source.winehq.org/git/wine.git/?a=commit;h=14bbccf756a5be3ce3029d01… Author: Alex Henrie <alexhenrie24(a)gmail.com> Date: Sun Sep 5 14:55:41 2021 -0600 cmd: Fix capitalization of WCMD_ReadFile in comment. Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- programs/cmd/wcmdmain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/programs/cmd/wcmdmain.c b/programs/cmd/wcmdmain.c index acf8f63b1f1..8c6ed1c057c 100644 --- a/programs/cmd/wcmdmain.c +++ b/programs/cmd/wcmdmain.c @@ -212,7 +212,7 @@ void WCMD_leave_paged_mode(void) } /*************************************************************************** - * WCMD_Readfile + * WCMD_ReadFile * * Read characters in from a console/file, returning result in Unicode */

1 0

Alexandre Julliard : shell32: Pass the destination Windows path to _SHCreateSymbolicLink().
by Alexandre Julliard Sept. 6, 2021

Sept. 6, 2021

Module: wine Branch: master Commit: bf811fdcaf70883634691d2c7262c3d80fe32323 URL: https://source.winehq.org/git/wine.git/?a=commit;h=bf811fdcaf70883634691d2c… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Mon Sep 6 13:17:14 2021 +0200 shell32: Pass the destination Windows path to _SHCreateSymbolicLink(). Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/shell32/shellpath.c | 23 +++++++++++------------ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/dlls/shell32/shellpath.c b/dlls/shell32/shellpath.c index a35f42264ea..f0c692647af 100644 --- a/dlls/shell32/shellpath.c +++ b/dlls/shell32/shellpath.c @@ -4202,7 +4202,7 @@ static void _SHCreateMyDocumentsSubDirs(const UINT * aidsMyStuff, const UINT num * aidsMyStuff [I] Array of IDS_* resources to create sub dirs for. * aids_num [I] Number of elements in aidsMyStuff. */ -static void _SHCreateMyDocumentsSymbolicLink(const UINT * aidsMyStuff, const UINT aids_num) +static void _SHCreateMyDocumentsSymbolicLink(const UINT * aidsMyStuff, const UINT aids_num, const WCHAR *path) { static const char * const xdg_dirs[] = { "DOCUMENTS" }; static const unsigned int num = ARRAY_SIZE(xdg_dirs); @@ -4212,7 +4212,7 @@ static void _SHCreateMyDocumentsSymbolicLink(const UINT * aidsMyStuff, const UIN char ** xdg_results; /* Get the unix path of 'My Documents'. */ - pszPersonal = _SHGetFolderUnixPath(CSIDL_PERSONAL|CSIDL_FLAG_DONT_VERIFY); + pszPersonal = wine_get_unix_file_name( path ); if (!pszPersonal) return; _SHGetXDGUserDirs(xdg_dirs, num, &xdg_results); @@ -4284,7 +4284,7 @@ static void _SHCreateMyDocumentsSymbolicLink(const UINT * aidsMyStuff, const UIN * PARAMS * nFolder [I] CSIDL identifying the folder. */ -static void _SHCreateMyStuffSymbolicLink(int nFolder) +static void _SHCreateMyStuffSymbolicLink(int nFolder, const WCHAR *path) { static const UINT aidsMyStuff[] = { IDS_MYPICTURES, IDS_MYVIDEOS, IDS_MYMUSIC, IDS_DOWNLOADS, IDS_TEMPLATES @@ -4328,8 +4328,7 @@ static void _SHCreateMyStuffSymbolicLink(int nFolder) while (1) { - /* Get the current 'My Whatever' folder unix path. */ - pszMyStuff = _SHGetFolderUnixPath(acsidlMyStuff[i]|CSIDL_FLAG_DONT_VERIFY); + pszMyStuff = wine_get_unix_file_name( path ); if (!pszMyStuff) break; while (1) @@ -4375,7 +4374,7 @@ static void _SHCreateMyStuffSymbolicLink(int nFolder) * Sets up a symbolic link for the 'Desktop' shell folder to point into the * users home directory. */ -static void _SHCreateDesktopSymbolicLink(void) +static void _SHCreateDesktopSymbolicLink( const WCHAR *path ) { static const char * const xdg_dirs[] = { "DESKTOP" }; static const unsigned int num = ARRAY_SIZE(xdg_dirs); @@ -4405,7 +4404,7 @@ static void _SHCreateDesktopSymbolicLink(void) (_SHAppendToUnixPath(szDesktopTarget, DesktopW) && !stat(szDesktopTarget, &statFolder) && S_ISDIR(statFolder.st_mode))) { - pszDesktop = _SHGetFolderUnixPath(CSIDL_DESKTOPDIRECTORY|CSIDL_FLAG_DONT_VERIFY); + pszDesktop = wine_get_unix_file_name( path ); if (pszDesktop) { if (xdg_desktop_dir) @@ -4428,7 +4427,7 @@ static void _SHCreateDesktopSymbolicLink(void) * PARAMS * nFolder [I] CSIDL identifying the folder. */ -static void _SHCreateSymbolicLink(int nFolder) +static void _SHCreateSymbolicLink(int nFolder, const WCHAR *path) { static const UINT aidsMyStuff[] = { IDS_MYPICTURES, IDS_MYVIDEOS, IDS_MYMUSIC, IDS_DOWNLOADS, IDS_TEMPLATES @@ -4437,17 +4436,17 @@ static void _SHCreateSymbolicLink(int nFolder) switch (folder) { case CSIDL_PERSONAL: - _SHCreateMyDocumentsSymbolicLink(aidsMyStuff, ARRAY_SIZE(aidsMyStuff)); + _SHCreateMyDocumentsSymbolicLink(aidsMyStuff, ARRAY_SIZE(aidsMyStuff), path); break; case CSIDL_MYPICTURES: case CSIDL_MYVIDEO: case CSIDL_MYMUSIC: case CSIDL_DOWNLOADS: case CSIDL_TEMPLATES: - _SHCreateMyStuffSymbolicLink(folder); + _SHCreateMyStuffSymbolicLink(folder, path); break; case CSIDL_DESKTOPDIRECTORY: - _SHCreateDesktopSymbolicLink(); + _SHCreateDesktopSymbolicLink( path ); break; } } @@ -4642,7 +4641,7 @@ HRESULT WINAPI SHGetFolderPathAndSubDirW( /* create symbolic links rather than directories for specific * user shell folders */ - _SHCreateSymbolicLink(folder); + _SHCreateSymbolicLink(folder, szBuildPath); /* create directory/directories */ ret = SHCreateDirectoryExW(hwndOwner, szBuildPath, NULL);

1 0

Alexandre Julliard : shell32: Avoid some code duplication.
by Alexandre Julliard Sept. 6, 2021

Sept. 6, 2021

Module: wine Branch: master Commit: 0a71ea73810e6a5615d9eeb0eb3d55cc1984d28b URL: https://source.winehq.org/git/wine.git/?a=commit;h=0a71ea73810e6a5615d9eeb0… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Mon Sep 6 13:12:45 2021 +0200 shell32: Avoid some code duplication. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/shell32/shellpath.c | 136 +++-------------------------------------------- 1 file changed, 6 insertions(+), 130 deletions(-) diff --git a/dlls/shell32/shellpath.c b/dlls/shell32/shellpath.c index e438efb9e80..a35f42264ea 100644 --- a/dlls/shell32/shellpath.c +++ b/dlls/shell32/shellpath.c @@ -4452,40 +4452,6 @@ static void _SHCreateSymbolicLink(int nFolder) } } -/****************************************************************************** - * _SHCreateSymbolicLinks [Internal] - * - * Sets up symbol links for various shell folders to point into the user's home - * directory. We do an educated guess about what the user would probably want: - * - If there is a 'My Documents' directory in $HOME, the user probably wants - * wine's 'My Documents' to point there. Furthermore, we infer that the user - * is a Windows lover and has no problem with wine creating subfolders for - * 'My Pictures', 'My Music', 'My Videos' etc. under '$HOME/My Documents', if - * those do not already exist. We put appropriate symbolic links in place for - * those, too. - * - If there is no 'My Documents' directory in $HOME, we let 'My Documents' - * point directly to $HOME. We assume the user to be a unix hacker who does not - * want wine to create anything anywhere besides the .wine directory. So, if - * there already is a 'My Music' directory in $HOME, we symlink the 'My Music' - * shell folder to it. But if not, then we check XDG_MUSIC_DIR - "well known" - * directory, and try to link to that. If that fails, then we symlink to - * $HOME directly. The same holds for 'My Pictures', 'My Videos' etc. - * - The Desktop shell folder is symlinked to XDG_DESKTOP_DIR. If that does not - * exist, then we try '$HOME/Desktop'. If that does not exist, then we leave - * it alone. - * ('My Music',... above in fact means LoadString(IDS_MYMUSIC)) - */ -static void _SHCreateSymbolicLinks(void) -{ - static const int acsidlMyStuff[] = { - CSIDL_MYPICTURES, CSIDL_MYVIDEO, CSIDL_MYMUSIC, CSIDL_DOWNLOADS, CSIDL_TEMPLATES, CSIDL_PERSONAL, CSIDL_DESKTOPDIRECTORY - }; - UINT i; - - for (i=0; i < ARRAY_SIZE(acsidlMyStuff); i++) - _SHCreateSymbolicLink(acsidlMyStuff[i]); -} - /****************************************************************************** * SHGetFolderPathW [SHELL32.@] * @@ -5197,10 +5163,8 @@ HRESULT WINAPI SHGetSpecialFolderLocation( */ HRESULT WINAPI SHGetKnownFolderPath(REFKNOWNFOLDERID rfid, DWORD flags, HANDLE token, WCHAR **ret_path) { - WCHAR pathW[MAX_PATH], tempW[MAX_PATH]; + WCHAR pathW[MAX_PATH]; HRESULT hr; - CSIDL_Type type; - int ret; int folder = csidl_from_id(rfid), shgfp_flags; TRACE("%s, 0x%08x, %p, %p\n", debugstr_guid(rfid), flags, token, ret_path); @@ -5216,93 +5180,16 @@ HRESULT WINAPI SHGetKnownFolderPath(REFKNOWNFOLDERID rfid, DWORD flags, HANDLE t FIXME("flags 0x%08x not supported\n", flags); return E_INVALIDARG; } - + folder |= flags & CSIDL_FLAG_MASK; shgfp_flags = flags & KF_FLAG_DEFAULT_PATH ? SHGFP_TYPE_DEFAULT : SHGFP_TYPE_CURRENT; - type = CSIDL_Data[folder].type; - switch (type) - { - case CSIDL_Type_Disallowed: - hr = E_INVALIDARG; - break; - case CSIDL_Type_NonExistent: - *tempW = 0; - hr = S_FALSE; - break; - case CSIDL_Type_WindowsPath: - GetWindowsDirectoryW(tempW, MAX_PATH); - append_relative_path(folder, tempW); - hr = S_OK; - break; - case CSIDL_Type_SystemPath: - GetSystemDirectoryW(tempW, MAX_PATH); - append_relative_path(folder, tempW); - hr = S_OK; - break; - case CSIDL_Type_SystemX86Path: - if (!GetSystemWow64DirectoryW(tempW, MAX_PATH)) GetSystemDirectoryW(tempW, MAX_PATH); - append_relative_path(folder, tempW); - hr = S_OK; - break; - case CSIDL_Type_CurrVer: - hr = _SHGetCurrentVersionPath(shgfp_flags, folder, tempW); - break; - case CSIDL_Type_User: - hr = _SHGetUserProfilePath(token, shgfp_flags, folder, tempW); - break; - case CSIDL_Type_AllUsers: - case CSIDL_Type_ProgramData: - hr = _SHGetAllUsersProfilePath(shgfp_flags, folder, tempW); - break; - default: - FIXME("bogus type %d, please fix\n", type); - hr = E_INVALIDARG; - break; - } - - if (FAILED(hr)) - goto failed; - - /* Expand environment strings if necessary */ - if (*tempW == '%') + hr = SHGetFolderPathAndSubDirW( 0, folder, token, shgfp_flags, NULL, pathW ); + if (FAILED( hr )) { - hr = _SHExpandEnvironmentStrings(tempW, pathW); - if (FAILED(hr)) - goto failed; - } - else - strcpyW(pathW, tempW); - - /* if we don't care about existing directories we are ready */ - if (flags & KF_FLAG_DONT_VERIFY) goto done; - - if (PathFileExistsW(pathW)) goto done; - - /* Does not exist but we are not allowed to create it. The return value - * is verified against shell32 version 6.0. - */ - if (!(flags & KF_FLAG_CREATE)) - { - hr = HRESULT_FROM_WIN32(ERROR_PATH_NOT_FOUND); - goto failed; - } - - /* create symbolic links rather than directories for specific - * user shell folders */ - _SHCreateSymbolicLink(folder); - - /* create directory/directories */ - ret = SHCreateDirectoryExW(NULL, pathW, NULL); - if (ret && ret != ERROR_ALREADY_EXISTS) - { - ERR("Failed to create directory %s.\n", debugstr_w(pathW)); - hr = E_FAIL; - goto failed; + TRACE("Failed to get folder path, %#x.\n", hr); + return hr; } - TRACE("Created missing system directory %s\n", debugstr_w(pathW)); - -done: TRACE("Final path is %s, %#x\n", debugstr_w(pathW), hr); *ret_path = CoTaskMemAlloc((strlenW(pathW) + 1) * sizeof(WCHAR)); @@ -5310,11 +5197,6 @@ done: return E_OUTOFMEMORY; strcpyW(*ret_path, pathW); - return hr; - -failed: - TRACE("Failed to get folder path, %#x.\n", hr); - return hr; } @@ -6441,12 +6323,6 @@ HRESULT SHELL_RegisterShellFolders(void) { HRESULT hr; - /* Set up '$HOME' targeted symlinks for 'My Documents', 'My Pictures', - * 'My Videos', 'My Music', 'Desktop' etc. in advance, so that the - * _SHRegister*ShellFolders() functions will find everything nice and clean - * and thus will not attempt to create them in the profile directory. */ - _SHCreateSymbolicLinks(); - hr = _SHRegisterUserShellFolders(TRUE); if (SUCCEEDED(hr)) hr = _SHRegisterUserShellFolders(FALSE);

1 0

Alexandre Julliard : shell32: Don't put shell folders inside My Documents.
by Alexandre Julliard Sept. 6, 2021

Sept. 6, 2021

Module: wine Branch: master Commit: 5321428f6482aef00c71077a58275f282adad0a4 URL: https://source.winehq.org/git/wine.git/?a=commit;h=5321428f6482aef00c71077a… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Mon Sep 6 13:53:24 2021 +0200 shell32: Don't put shell folders inside My Documents. Put them all at the same level, like recent Windows versions do. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/shell32/shellpath.c | 332 +++++------------------------------------------ 1 file changed, 30 insertions(+), 302 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=5321428f6482aef00c71…

1 0