December 2022 - Wine-Commits

Rémi Bernon : opengl32/tests: Test wglChoosePixelFormatARB flags filters.
by Alexandre Julliard Dec. 21, 2022

Dec. 21, 2022

Module: wine Branch: master Commit: 87090965ff50a43e06fdc4fe91ee7566f566ea9a URL: https://gitlab.winehq.org/wine/wine/-/commit/87090965ff50a43e06fdc4fe91ee75… Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Wed Dec 21 19:59:01 2022 +0100 opengl32/tests: Test wglChoosePixelFormatARB flags filters. --- dlls/opengl32/tests/opengl.c | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/dlls/opengl32/tests/opengl.c b/dlls/opengl32/tests/opengl.c index 57be207b548..3b49f8d2149 100644 --- a/dlls/opengl32/tests/opengl.c +++ b/dlls/opengl32/tests/opengl.c @@ -1821,6 +1821,13 @@ static void test_wglChoosePixelFormatARB(HDC hdc) WGL_SUPPORT_OPENGL_ARB, 1, 0 }; + static int attrib_list_flags[] = + { + WGL_DRAW_TO_WINDOW_ARB, 1, + WGL_SUPPORT_OPENGL_ARB, 1, + WGL_SUPPORT_GDI_ARB, 1, + 0 + }; PIXELFORMATDESCRIPTOR fmt, last_fmt; BYTE depth, last_depth; @@ -1867,6 +1874,27 @@ static void test_wglChoosePixelFormatARB(HDC hdc) depth, last_depth, i, formats[i]); } } + + format_count = 0; + res = pwglChoosePixelFormatARB(hdc, attrib_list_flags, NULL, ARRAY_SIZE(formats), formats, &format_count); + ok(res, "Got unexpected result %d.\n", res); + + for (i = 0; i < format_count; ++i) + { + PIXELFORMATDESCRIPTOR format = {0}; + BOOL ret; + + winetest_push_context("%u", i); + + ret = DescribePixelFormat(hdc, formats[i], sizeof(format), &format); + ok(ret, "DescribePixelFormat failed, error %lu\n", GetLastError()); + + ok(format.dwFlags & PFD_DRAW_TO_WINDOW, "got dwFlags %#lx\n", format.dwFlags); + ok(format.dwFlags & PFD_SUPPORT_OPENGL, "got dwFlags %#lx\n", format.dwFlags); + todo_wine ok(format.dwFlags & PFD_SUPPORT_GDI, "got dwFlags %#lx\n", format.dwFlags); + + winetest_pop_context(); + } } static void test_copy_context(HDC hdc)

1 0

Rémi Bernon : winex11: Check pixel format flags in X11DRV_wglChoosePixelFormatARB.
by Alexandre Julliard Dec. 21, 2022

Dec. 21, 2022

Module: wine Branch: master Commit: 6dd2ed2c7dd6eb7c05e96f8373f639ea975cb9f0 URL: https://gitlab.winehq.org/wine/wine/-/commit/6dd2ed2c7dd6eb7c05e96f8373f639… Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Fri Dec 16 11:28:32 2022 +0100 winex11: Check pixel format flags in X11DRV_wglChoosePixelFormatARB. The check was dropped in e392e0ac2846edc25610723c19d6a796372017e1, leaving the dwFlags variable unused. --- dlls/opengl32/tests/opengl.c | 2 +- dlls/winex11.drv/opengl.c | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/dlls/opengl32/tests/opengl.c b/dlls/opengl32/tests/opengl.c index 3b49f8d2149..42c2626a2c2 100644 --- a/dlls/opengl32/tests/opengl.c +++ b/dlls/opengl32/tests/opengl.c @@ -1891,7 +1891,7 @@ static void test_wglChoosePixelFormatARB(HDC hdc) ok(format.dwFlags & PFD_DRAW_TO_WINDOW, "got dwFlags %#lx\n", format.dwFlags); ok(format.dwFlags & PFD_SUPPORT_OPENGL, "got dwFlags %#lx\n", format.dwFlags); - todo_wine ok(format.dwFlags & PFD_SUPPORT_GDI, "got dwFlags %#lx\n", format.dwFlags); + ok(format.dwFlags & PFD_SUPPORT_GDI, "got dwFlags %#lx\n", format.dwFlags); winetest_pop_context(); } diff --git a/dlls/winex11.drv/opengl.c b/dlls/winex11.drv/opengl.c index 52f363461e4..96a8526604b 100644 --- a/dlls/winex11.drv/opengl.c +++ b/dlls/winex11.drv/opengl.c @@ -2638,6 +2638,8 @@ static BOOL X11DRV_wglChoosePixelFormatARB( HDC hdc, const int *piAttribIList, c if (i == nb_pixel_formats) continue; + if ((pixel_formats[i].dwFlags & dwFlags) != dwFlags) + continue; format = &formats[format_count]; format->format = i + 1;

1 0

Rémi Bernon : Revert "qasf: Register ASF Reader filter media type."
by Alexandre Julliard Dec. 21, 2022

Dec. 21, 2022

Module: wine Branch: master Commit: 409d0f4247ea4815481489bb1934cadde9c30410 URL: https://gitlab.winehq.org/wine/wine/-/commit/409d0f4247ea4815481489bb1934ca… Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Wed Dec 21 11:45:59 2022 +0100 Revert "qasf: Register ASF Reader filter media type." This reverts commit 4608e1e1257a377cd554a0e885368e3feb7d286f. The ASF Reader filter suffers from defects which are difficult to solve, and will require a better implementation of wmvcore in order to work correctly. In the meantime, revert the class registration so that the File Source filter is preferred instead. This will break games that tried to use the filter directly and which may have started to work correctly, but they are less frequent than the ones simply playing wmv videos with quartz. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53640 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53748 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54191 --- dlls/qasf/qasf.rgs | 15 --------------- dlls/qasf/version.rc | 3 --- 2 files changed, 18 deletions(-) diff --git a/dlls/qasf/qasf.rgs b/dlls/qasf/qasf.rgs deleted file mode 100644 index de0d3e425ed..00000000000 --- a/dlls/qasf/qasf.rgs +++ /dev/null @@ -1,15 +0,0 @@ -HKCR -{ - NoRemove 'Media Type' - { - '{e436eb83-524f-11ce-9f53-0020af0ba770}' - { - '{6b6d0801-9ada-11d0-a520-00a0d10129c0}' - { - val '0' = s '0,4,,3026b275' - val '1' = s '0,4,,d129e2d6' - val 'Source Filter' = s '{187463a0-5bb7-11d3-acbe-0080c75e246e}' - } - } - } -} diff --git a/dlls/qasf/version.rc b/dlls/qasf/version.rc index 70ec03ad6b1..dab46194395 100644 --- a/dlls/qasf/version.rc +++ b/dlls/qasf/version.rc @@ -24,6 +24,3 @@ #define WINE_PRODUCTVERSION_STR "9.0.0.4503" #include "wine/wine_common_ver.rc" - -/* @makedep: qasf.rgs */ -1 WINE_REGISTRY qasf.rgs

1 0

Sven Baars : wined3d: Do not explicitly check 3D depth/stencil capabilities in wined3d_check_device_format().
by Alexandre Julliard Dec. 21, 2022

Dec. 21, 2022

Module: wine Branch: master Commit: 8e7c99f7ab2c687bc69d257cf1398e9531b4751d URL: https://gitlab.winehq.org/wine/wine/-/commit/8e7c99f7ab2c687bc69d257cf1398e… Author: Sven Baars <sbaars(a)codeweavers.com> Date: Fri Dec 16 11:19:13 2022 +0100 wined3d: Do not explicitly check 3D depth/stencil capabilities in wined3d_check_device_format(). This reapplies the change from 67d0038e49323523b745c4a728069d8195273d23 that was reverted in 06b19322187e5ef8ffc06504c322ce9bcdaaa6ee, causing a regression. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53785 --- dlls/wined3d/directx.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/dlls/wined3d/directx.c b/dlls/wined3d/directx.c index 9d7c4769cb8..9b6901d25c0 100644 --- a/dlls/wined3d/directx.c +++ b/dlls/wined3d/directx.c @@ -2109,13 +2109,6 @@ HRESULT CDECL wined3d_check_device_format(const struct wined3d *wined3d, if (gl_type == WINED3D_GL_RES_TYPE_TEX_2D && !(bind_flags & WINED3D_BIND_SHADER_RESOURCE)) caps |= format->caps[WINED3D_GL_RES_TYPE_RB]; - if ((caps & format_caps) != format_caps) - { - TRACE("Requested format caps %#x, but format %s only has %#x.\n", - format_caps, debug_d3dformat(check_format_id), caps); - return WINED3DERR_NOTAVAILABLE; - } - if ((bind_flags & WINED3D_BIND_RENDER_TARGET) && !adapter->adapter_ops->adapter_check_format(adapter, adapter_format, format, NULL)) { @@ -2143,6 +2136,13 @@ HRESULT CDECL wined3d_check_device_format(const struct wined3d *wined3d, return WINED3DERR_NOTAVAILABLE; } + if ((caps & format_caps) != format_caps) + { + TRACE("Requested format caps %#x, but format %s only has %#x.\n", + format_caps, debug_d3dformat(check_format_id), caps); + return WINED3DERR_NOTAVAILABLE; + } + if (!(caps & WINED3D_FORMAT_CAP_GEN_MIPMAP)) mipmap_gen_supported = FALSE; }

1 0

Eric Pouech : kernel32/tests: Skip some console tests on w1064v1909.
by Alexandre Julliard Dec. 21, 2022

Dec. 21, 2022

Module: wine Branch: master Commit: af215210f0c4d8b0cea945692cff1b13c2b47f3b URL: https://gitlab.winehq.org/wine/wine/-/commit/af215210f0c4d8b0cea945692cff1b… Author: Eric Pouech <eric.pouech(a)gmail.com> Date: Wed Dec 21 17:11:49 2022 +0100 kernel32/tests: Skip some console tests on w1064v1909. We get conhost.exe:tty failures on testbot: - not for version prior to w1064v1909 (these tests require pseudo-consoles, which are not implemented in these Windows version). - for w1064v1909 - not for W10 versions after w1064v1909. So, we assume that pseudo-console support is immature in this Windows version: skip all the remaining test at the first discrepancy point. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53465 Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> --- programs/conhost/tests/tty.c | 34 ++++++++++++++++++++++++++-------- 1 file changed, 26 insertions(+), 8 deletions(-) diff --git a/programs/conhost/tests/tty.c b/programs/conhost/tests/tty.c index 9371d0ce6f5..441bc17f04d 100644 --- a/programs/conhost/tests/tty.c +++ b/programs/conhost/tests/tty.c @@ -628,12 +628,22 @@ static void _test_cursor_pos(unsigned line, int expect_x, int expect_y) info.dwCursorPosition.Y, expect_y); } -static void test_write_console(void) +static BOOL test_write_console(void) { child_set_output_mode(ENABLE_PROCESSED_OUTPUT | ENABLE_WRAP_AT_EOL_OUTPUT | ENABLE_VIRTUAL_TERMINAL_PROCESSING); child_string_request(REQ_WRITE_CONSOLE, L"abc"); skip_hide_cursor(); + if (skip_sequence("\x1b[H \x1b[32m0\x1b[41m1\x1b[30m2")) + { + /* we get this on w1064v1909 (and more discrepancies afterwards). + * This is inconsistent with ulterior w10 versions. Assume it's + * immature result, and skip rest of tests. + */ + console_output_count = 0; + return FALSE; + } + expect_output_sequence("abc"); skip_sequence("\x1b[?25h"); /* show cursor */ @@ -961,9 +971,11 @@ static void test_write_console(void) skip_sequence("\x1b[?25h"); /* show cursor */ expect_empty_output(); test_cursor_pos(1, 23); + + return TRUE; } -static void test_tty_output(void) +static BOOL test_tty_output(void) { CHAR_INFO char_info_buf[2048], char_info; HANDLE sb, sb2; @@ -1197,7 +1209,7 @@ static void test_tty_output(void) expect_output_sequence("\x1b[?25h"); /* show cursor */ expect_empty_output(); - test_write_console(); + if (!test_write_console()) return FALSE; sb = child_create_screen_buffer(); child_set_active(sb); @@ -1244,6 +1256,8 @@ static void test_tty_output(void) expect_output_sequence("\x1b[H"); /* set cursor */ expect_output_sequence("\x1b[?25h"); /* show cursor */ expect_empty_output(); + + return TRUE; } static void write_console_pipe(const char *buf) @@ -1836,12 +1850,16 @@ static void test_pseudoconsole(void) if (!broken_version) { - test_tty_output(); - test_read_console_control(); - test_read_console(); - test_tty_input(); + if (test_tty_output()) + { + test_read_console_control(); + test_read_console(); + test_tty_input(); + } + else + win_skip("Partially supported windows version. Skipping rest of the tests\n"); } - else win_skip("Skipping tty output tests on broken Windows version\n"); + else win_skip("Skipping tty tests on broken Windows version\n"); CloseHandle(child_pipe); wait_child_process(child_process);

1 0

Zebediah Figura : d3d9: Upload the relevant texture in d3d9_texture_gen_auto_mipmap().
by Alexandre Julliard Dec. 21, 2022

Dec. 21, 2022

Module: wine Branch: master Commit: f3e381d1c9dd7bbb1a8aa4ccb22e5b2b992d4b86 URL: https://gitlab.winehq.org/wine/wine/-/commit/f3e381d1c9dd7bbb1a8aa4ccb22e5b… Author: Zebediah Figura <zfigura(a)codeweavers.com> Date: Mon Dec 19 18:09:45 2022 -0600 d3d9: Upload the relevant texture in d3d9_texture_gen_auto_mipmap(). Instead of uploading all currently bound textures. Besides being redundant, this would generate mipmaps for an uninitialized texture, and subsequently trying to render from nonzero mipmap levels would yield uninitialized data. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54170 --- dlls/d3d9/d3d9_private.h | 1 - dlls/d3d9/device.c | 2 +- dlls/d3d9/tests/visual.c | 2 +- dlls/d3d9/texture.c | 4 +++- 4 files changed, 5 insertions(+), 4 deletions(-) diff --git a/dlls/d3d9/d3d9_private.h b/dlls/d3d9/d3d9_private.h index fe13f679db4..7dc32e6c12f 100644 --- a/dlls/d3d9/d3d9_private.h +++ b/dlls/d3d9/d3d9_private.h @@ -125,7 +125,6 @@ struct d3d9_device HRESULT device_init(struct d3d9_device *device, struct d3d9 *parent, struct wined3d *wined3d, UINT adapter, D3DDEVTYPE device_type, HWND focus_window, DWORD flags, D3DPRESENT_PARAMETERS *parameters, D3DDISPLAYMODEEX *mode) DECLSPEC_HIDDEN; -void d3d9_device_upload_managed_textures(struct d3d9_device *device); struct d3d9_resource { diff --git a/dlls/d3d9/device.c b/dlls/d3d9/device.c index 55641670665..eddb2a0ebdd 100644 --- a/dlls/d3d9/device.c +++ b/dlls/d3d9/device.c @@ -3010,7 +3010,7 @@ static HRESULT d3d9_device_upload_sysmem_index_buffer(struct d3d9_device *device return S_OK; } -void d3d9_device_upload_managed_textures(struct d3d9_device *device) +static void d3d9_device_upload_managed_textures(struct d3d9_device *device) { const struct wined3d_stateblock_state *state = device->stateblock_state; unsigned int i; diff --git a/dlls/d3d9/tests/visual.c b/dlls/d3d9/tests/visual.c index e6c0458c69f..12105cfa0e0 100644 --- a/dlls/d3d9/tests/visual.c +++ b/dlls/d3d9/tests/visual.c @@ -27903,7 +27903,7 @@ static void test_managed_generate_mipmap(void) ok(hr == S_OK, "Got hr %#lx.\n", hr); draw_textured_quad(&context, texture); - check_rt_color_todo(context.backbuffer, 0x0000ff00); + check_rt_color(context.backbuffer, 0x0000ff00); IDirect3DTexture9_Release(texture); release_test_context(&context); diff --git a/dlls/d3d9/texture.c b/dlls/d3d9/texture.c index e5b52fdcc82..0a27941ac2b 100644 --- a/dlls/d3d9/texture.c +++ b/dlls/d3d9/texture.c @@ -138,7 +138,9 @@ void d3d9_texture_gen_auto_mipmap(struct d3d9_texture *texture) if (!(texture->flags & D3D9_TEXTURE_MIPMAP_DIRTY)) return; d3d9_texture_acquire_shader_resource_view(texture); - d3d9_device_upload_managed_textures(texture->parent_device); + if (texture->draw_texture) + wined3d_device_update_texture(texture->parent_device->wined3d_device, + texture->wined3d_texture, texture->draw_texture); wined3d_device_context_generate_mipmaps(texture->parent_device->immediate_context, texture->wined3d_srv); texture->flags &= ~D3D9_TEXTURE_MIPMAP_DIRTY; }

1 0

Zebediah Figura : d3d9/tests: Test GenerateMipSubLevels() on a managed texture.
by Alexandre Julliard Dec. 21, 2022

Dec. 21, 2022

Module: wine Branch: master Commit: c3ee85b606fb434436533c8e74a6a2307b38cfd1 URL: https://gitlab.winehq.org/wine/wine/-/commit/c3ee85b606fb434436533c8e74a6a2… Author: Zebediah Figura <zfigura(a)codeweavers.com> Date: Mon Dec 19 17:21:13 2022 -0600 d3d9/tests: Test GenerateMipSubLevels() on a managed texture. --- dlls/d3d9/tests/visual.c | 34 ++++++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+) diff --git a/dlls/d3d9/tests/visual.c b/dlls/d3d9/tests/visual.c index ccfa8ce5e3a..e6c0458c69f 100644 --- a/dlls/d3d9/tests/visual.c +++ b/dlls/d3d9/tests/visual.c @@ -27876,6 +27876,39 @@ static void test_managed_reset(void) release_test_context(&context); } +static void test_managed_generate_mipmap(void) +{ + struct d3d9_test_context context; + IDirect3DTexture9 *texture; + IDirect3DDevice9 *device; + HRESULT hr; + + if (!init_test_context(&context)) + return; + device = context.device; + + hr = IDirect3DDevice9_CreateTexture(device, 16, 16, 0, D3DUSAGE_AUTOGENMIPMAP, + D3DFMT_A8R8G8B8, D3DPOOL_MANAGED, &texture, NULL); + ok(hr == S_OK, "Got hr %#lx.\n", hr); + fill_texture(texture, 0x0000ff00, 0); + + IDirect3DTexture9_GenerateMipSubLevels(texture); + + hr = IDirect3DDevice9_Clear(device, 0, NULL, D3DCLEAR_TARGET, 0xffff0000, 0.0, 0); + ok(hr == S_OK, "Got hr %#lx.\n", hr); + + hr = IDirect3DDevice9_SetSamplerState(device, 0, D3DSAMP_MIPFILTER, D3DTEXF_POINT); + ok(hr == S_OK, "Got hr %#lx.\n", hr); + hr = IDirect3DDevice9_SetSamplerState(device, 0, D3DSAMP_MAXMIPLEVEL, 1); + ok(hr == S_OK, "Got hr %#lx.\n", hr); + + draw_textured_quad(&context, texture); + check_rt_color_todo(context.backbuffer, 0x0000ff00); + + IDirect3DTexture9_Release(texture); + release_test_context(&context); +} + START_TEST(visual) { D3DADAPTER_IDENTIFIER9 identifier; @@ -28028,4 +28061,5 @@ START_TEST(visual) test_dynamic_map_synchronization(); test_filling_convention(); test_managed_reset(); + test_managed_generate_mipmap(); }

1 0

Paul Gofman : ddraw/tests: Release ddraw after device in test_texture_wrong_caps().
by Alexandre Julliard Dec. 21, 2022

Dec. 21, 2022

Module: wine Branch: master Commit: 1a9c1d593b5ac5aee7450ba510f46c2a153741f7 URL: https://gitlab.winehq.org/wine/wine/-/commit/1a9c1d593b5ac5aee7450ba510f46c… Author: Paul Gofman <pgofman(a)codeweavers.com> Date: Mon Dec 19 13:49:15 2022 -0600 ddraw/tests: Release ddraw after device in test_texture_wrong_caps(). Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54049 --- dlls/ddraw/tests/ddraw2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/ddraw/tests/ddraw2.c b/dlls/ddraw/tests/ddraw2.c index 4bb6e71fc32..2880982ed33 100644 --- a/dlls/ddraw/tests/ddraw2.c +++ b/dlls/ddraw/tests/ddraw2.c @@ -15657,9 +15657,9 @@ static void test_texture_wrong_caps(const GUID *device_guid) IDirectDrawSurface_Release(rt); destroy_viewport(device, viewport); destroy_material(background); - IDirectDraw2_Release(ddraw); refcount = IDirect3DDevice2_Release(device); ok(!refcount, "Device has %lu references left.\n", refcount); + IDirectDraw2_Release(ddraw); DestroyWindow(window); }

1 0

Jacek Caban : shell32: Always set last error in Shell_NotifyIconW.
by Alexandre Julliard Dec. 21, 2022

Dec. 21, 2022

Module: wine Branch: master Commit: 9e351472dd5fc7a9ceb0aacaadfd431ea38a974e URL: https://gitlab.winehq.org/wine/wine/-/commit/9e351472dd5fc7a9ceb0aacaadfd43… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Dec 21 13:46:33 2022 +0100 shell32: Always set last error in Shell_NotifyIconW. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53101 --- dlls/shell32/systray.c | 8 +++++++- dlls/shell32/tests/systray.c | 12 ++++++++++++ 2 files changed, 19 insertions(+), 1 deletion(-) diff --git a/dlls/shell32/systray.c b/dlls/shell32/systray.c index 6916937c41b..7863c4de177 100644 --- a/dlls/shell32/systray.c +++ b/dlls/shell32/systray.c @@ -148,7 +148,11 @@ BOOL WINAPI Shell_NotifyIconW(DWORD dwMessage, PNOTIFYICONDATAW nid) } tray = FindWindowExW(0, NULL, L"Shell_TrayWnd", NULL); - if (!tray) return FALSE; + if (!tray) + { + SetLastError(E_FAIL); + return FALSE; + } cds.dwData = dwMessage; cds.cbData = sizeof(*data); @@ -185,6 +189,7 @@ BOOL WINAPI Shell_NotifyIconW(DWORD dwMessage, PNOTIFYICONDATAW nid) { DeleteObject(iconinfo.hbmMask); if (iconinfo.hbmColor) DeleteObject(iconinfo.hbmColor); + SetLastError(E_OUTOFMEMORY); return FALSE; } @@ -241,6 +246,7 @@ noicon: cds.lpData = data; ret = SendMessageW(tray, WM_COPYDATA, (WPARAM)nid->hWnd, (LPARAM)&cds); if (data != &data_buffer) heap_free( data ); + SetLastError(ret ? S_OK : E_FAIL); return ret; } diff --git a/dlls/shell32/tests/systray.c b/dlls/shell32/tests/systray.c index ba5832e51c7..80621761240 100644 --- a/dlls/shell32/tests/systray.c +++ b/dlls/shell32/tests/systray.c @@ -44,8 +44,11 @@ static void test_cbsize(void) nidW.uFlags = NIF_ICON|NIF_MESSAGE; nidW.hIcon = LoadIconA(NULL, (LPSTR)IDI_APPLICATION); nidW.uCallbackMessage = WM_USER+17; + SetLastError(0xdeadbeef); ret = pShell_NotifyIconW(NIM_ADD, &nidW); ok(ret, "NIM_ADD failed!\n"); + ok(GetLastError() == ERROR_SUCCESS || GetLastError() == ERROR_NO_TOKEN, + "GetLastError() = %lu\n", GetLastError()); /* using an invalid cbSize does work */ nidW.cbSize = 3; nidW.hWnd = hMainWnd; @@ -54,7 +57,10 @@ static void test_cbsize(void) ok( ret || broken(!ret), /* nt4 */ "NIM_DELETE failed!\n"); /* as icon doesn't exist anymore - now there will be an error */ nidW.cbSize = sizeof(nidW); + SetLastError(0xdeadbeef); ok(!pShell_NotifyIconW(NIM_DELETE, &nidW) != !ret, "The icon was not deleted\n"); + ok(GetLastError() == E_FAIL || GetLastError() == ERROR_TIMEOUT, + "GetLastError() = %lu\n", GetLastError()); } /* same for Shell_NotifyIconA */ @@ -65,7 +71,10 @@ static void test_cbsize(void) nidA.uFlags = NIF_ICON|NIF_MESSAGE; nidA.hIcon = LoadIconA(NULL, (LPSTR)IDI_APPLICATION); nidA.uCallbackMessage = WM_USER+17; + SetLastError(0xdeadbeef); ok(Shell_NotifyIconA(NIM_ADD, &nidA), "NIM_ADD failed!\n"); + ok(GetLastError() == ERROR_SUCCESS || GetLastError() == ERROR_NO_TOKEN, + "GetLastError() = %lu\n", GetLastError()); /* using an invalid cbSize does work */ nidA.cbSize = 3; @@ -75,7 +84,10 @@ static void test_cbsize(void) ok(ret, "NIM_DELETE failed!\n"); /* as icon doesn't exist anymore - now there will be an error */ nidA.cbSize = sizeof(nidA); + SetLastError(0xdeadbeef); ok(!Shell_NotifyIconA(NIM_DELETE, &nidA) != !ret, "The icon was not deleted\n"); + ok(GetLastError() == E_FAIL || GetLastError() == ERROR_TIMEOUT, + "GetLastError() = %lu\n", GetLastError()); } START_TEST(systray)

1 0

Jacek Caban : urlmon/tests: Use gitlab.winehq.org host in can_do_https.
by Alexandre Julliard Dec. 21, 2022

Dec. 21, 2022

Module: wine Branch: master Commit: 1cd47755763cb2a17a8e48b3cb4f7c838be96aa2 URL: https://gitlab.winehq.org/wine/wine/-/commit/1cd47755763cb2a17a8e48b3cb4f7c… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Dec 21 13:10:55 2022 +0100 urlmon/tests: Use gitlab.winehq.org host in can_do_https. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53680 --- dlls/urlmon/tests/url.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/urlmon/tests/url.c b/dlls/urlmon/tests/url.c index 9e1a6edcdfd..ef2a742b726 100644 --- a/dlls/urlmon/tests/url.c +++ b/dlls/urlmon/tests/url.c @@ -3977,11 +3977,11 @@ static BOOL can_do_https(void) ses = InternetOpenA("winetest", INTERNET_OPEN_TYPE_PRECONFIG, NULL, NULL, 0); ok(ses != NULL, "InternetOpen failed\n"); - con = InternetConnectA(ses, "test.winehq.org", INTERNET_DEFAULT_HTTPS_PORT, + con = InternetConnectA(ses, "gitlab.winehq.org", INTERNET_DEFAULT_HTTPS_PORT, NULL, NULL, INTERNET_SERVICE_HTTP, 0, 0); ok(con != NULL, "InternetConnect failed\n"); - req = HttpOpenRequestA(con, "GET", "/tests/hello.html", NULL, NULL, NULL, + req = HttpOpenRequestA(con, "GET", "/robots.txt", NULL, NULL, NULL, INTERNET_FLAG_SECURE, 0); ok(req != NULL, "HttpOpenRequest failed\n");

1 0