August 2022 - Wine-Commits - list.winehq.org

Nikolay Sivov : mfplat: Partially implement MFInitMediaTypeFromVideoInfoHeader().
by Alexandre Julliard Aug. 28, 2022

Aug. 28, 2022

Module: wine Branch: master Commit: 1e2f552428e18b72ceaac8d57d695bc9d4ccc39c URL: https://gitlab.winehq.org/wine/wine/-/commit/1e2f552428e18b72ceaac8d57d695b… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Thu Aug 25 20:08:27 2022 +0300 mfplat: Partially implement MFInitMediaTypeFromVideoInfoHeader(). Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> --- dlls/mfplat/mediatype.c | 47 +++++++++++++++++++++++++++++++++++++++++++++- dlls/mfplat/tests/mfplat.c | 6 ------ 2 files changed, 46 insertions(+), 7 deletions(-) diff --git a/dlls/mfplat/mediatype.c b/dlls/mfplat/mediatype.c index d8f7fbea504..84f6ef4f81d 100644 --- a/dlls/mfplat/mediatype.c +++ b/dlls/mfplat/mediatype.c @@ -24,6 +24,7 @@ #include "initguid.h" #include "ks.h" #include "ksmedia.h" +#include "amvideo.h" WINE_DEFAULT_DEBUG_CHANNEL(mfplat); @@ -2957,6 +2958,12 @@ static void mediatype_set_uint32(IMFMediaType *mediatype, const GUID *attr, unsi *hr = IMFMediaType_SetUINT32(mediatype, attr, value); } +static void mediatype_set_uint64(IMFMediaType *mediatype, const GUID *attr, unsigned int high, unsigned int low, HRESULT *hr) +{ + if (SUCCEEDED(*hr)) + *hr = IMFMediaType_SetUINT64(mediatype, attr, (UINT64)high << 32 | low); +} + static void mediatype_set_guid(IMFMediaType *mediatype, const GUID *attr, const GUID *value, HRESULT *hr) { if (SUCCEEDED(*hr)) @@ -3558,6 +3565,16 @@ HRESULT WINAPI MFInitVideoFormat_RGB(MFVIDEOFORMAT *format, DWORD width, DWORD h return S_OK; } +static HRESULT mf_get_stride_for_bitmap_info_header(DWORD fourcc, const BITMAPINFOHEADER *bih, LONG *stride) +{ + HRESULT hr; + + if (FAILED(hr = MFGetStrideForBitmapInfoHeader(fourcc, bih->biWidth, stride))) return hr; + if (bih->biHeight < 0) *stride *= -1; + + return hr; +} + /*********************************************************************** * MFCreateVideoMediaTypeFromVideoInfoHeader (mfplat.@) */ @@ -3577,9 +3594,37 @@ HRESULT WINAPI MFCreateVideoMediaTypeFromVideoInfoHeader(const KS_VIDEOINFOHEADE HRESULT WINAPI MFInitMediaTypeFromVideoInfoHeader(IMFMediaType *media_type, const VIDEOINFOHEADER *vih, UINT32 size, const GUID *subtype) { + HRESULT hr = S_OK; + DWORD height; + LONG stride; + FIXME("%p, %p, %u, %s.\n", media_type, vih, size, debugstr_guid(subtype)); - return E_NOTIMPL; + IMFMediaType_DeleteAllItems(media_type); + + if (!subtype) + { + FIXME("Implicit subtype is not supported.\n"); + return E_NOTIMPL; + } + + height = abs(vih->bmiHeader.biHeight); + + mediatype_set_guid(media_type, &MF_MT_MAJOR_TYPE, &MFMediaType_Video, &hr); + mediatype_set_guid(media_type, &MF_MT_SUBTYPE, subtype, &hr); + mediatype_set_uint64(media_type, &MF_MT_PIXEL_ASPECT_RATIO, 1, 1, &hr); + mediatype_set_uint32(media_type, &MF_MT_INTERLACE_MODE, MFVideoInterlace_Progressive, &hr); + mediatype_set_uint64(media_type, &MF_MT_FRAME_SIZE, vih->bmiHeader.biWidth, height, &hr); + + if (SUCCEEDED(mf_get_stride_for_bitmap_info_header(subtype->Data1, &vih->bmiHeader, &stride))) + { + mediatype_set_uint32(media_type, &MF_MT_DEFAULT_STRIDE, stride, &hr); + mediatype_set_uint32(media_type, &MF_MT_SAMPLE_SIZE, abs(stride) * height, &hr); + mediatype_set_uint32(media_type, &MF_MT_FIXED_SIZE_SAMPLES, 1, &hr); + mediatype_set_uint32(media_type, &MF_MT_ALL_SAMPLES_INDEPENDENT, 1, &hr); + } + + return hr; } /*********************************************************************** diff --git a/dlls/mfplat/tests/mfplat.c b/dlls/mfplat/tests/mfplat.c index 39cd6706551..44f3f9036cc 100644 --- a/dlls/mfplat/tests/mfplat.c +++ b/dlls/mfplat/tests/mfplat.c @@ -8263,13 +8263,7 @@ static void test_MFInitMediaTypeFromVideoInfoHeader(void) vih.bmiHeader.biBitCount = 32; hr = MFInitMediaTypeFromVideoInfoHeader(media_type, &vih, sizeof(vih), &GUID_NULL); - todo_wine ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); - if (FAILED(hr)) - { - IMFMediaType_Release(media_type); - return; - } hr = IMFMediaType_GetGUID(media_type, &MF_MT_MAJOR_TYPE, &guid); ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);

1 0

Nikolay Sivov : mfplat/tests: Add some tests for legacy media type conersion functions.
by Alexandre Julliard Aug. 28, 2022

Aug. 28, 2022

Module: wine Branch: master Commit: 43e70580f48c648e61e56dd88df66e93eda56452 URL: https://gitlab.winehq.org/wine/wine/-/commit/43e70580f48c648e61e56dd88df66e… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Thu Aug 25 20:02:14 2022 +0300 mfplat/tests: Add some tests for legacy media type conersion functions. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> --- dlls/evr/evr.spec | 2 +- dlls/mfplat/mediatype.c | 34 +++++ dlls/mfplat/mfplat.spec | 6 +- dlls/mfplat/tests/mfplat.c | 355 +++++++++++++++++++++++++++++++++++++++++++++ include/ksmedia.h | 25 ++++ include/mfapi.h | 20 +++ 6 files changed, 438 insertions(+), 4 deletions(-)

1 0

Floris Renaud : obs-sync: Change Signed-By path.
by Alexandre Julliard Aug. 28, 2022

Aug. 28, 2022

Module: tools Branch: master Commit: a04dba287be44fd00a8ed57cef6c0fdea23ed4a5 URL: https://gitlab.winehq.org/winehq/tools/-/commit/a04dba287be44fd00a8ed57cef6… Author: Floris Renaud <jkfloris(a)dds.nl> Date: Thu Aug 25 16:11:02 2022 +0000 obs-sync: Change Signed-By path. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53554 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53356 --- packaging/obs/obs-sync | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packaging/obs/obs-sync b/packaging/obs/obs-sync index 4167d1b8..54fff2ae 100755 --- a/packaging/obs/obs-sync +++ b/packaging/obs/obs-sync @@ -145,7 +145,7 @@ URIs: https://dl.winehq.org/wine-builds/$1 Suites: $2 Components: main Architectures: amd64 i386 -Signed-By: /usr/share/keyrings/winehq-archive.key +Signed-By: /etc/apt/keyrings/winehq-archive.key EOF }

1 0

Gijs Vermeulen : kernel32: Add SetProcessDefaultCpuSets stub.
by Alexandre Julliard Aug. 25, 2022

Aug. 25, 2022

Module: wine Branch: master Commit: a9ed113347eea3ad60f95b4c1fe16a9254192384 URL: https://gitlab.winehq.org/wine/wine/-/commit/a9ed113347eea3ad60f95b4c1fe16a… Author: Gijs Vermeulen <gijsvrm(a)gmail.com> Date: Thu Aug 25 14:45:13 2022 +0200 kernel32: Add SetProcessDefaultCpuSets stub. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53589 --- dlls/kernel32/kernel32.spec | 1 + dlls/kernelbase/kernelbase.spec | 2 +- dlls/kernelbase/memory.c | 11 +++++++++++ 3 files changed, 13 insertions(+), 1 deletion(-) diff --git a/dlls/kernel32/kernel32.spec b/dlls/kernel32/kernel32.spec index a5fa757da9f..7c5fb8ed74f 100644 --- a/dlls/kernel32/kernel32.spec +++ b/dlls/kernel32/kernel32.spec @@ -1444,6 +1444,7 @@ @ stdcall -import SetPriorityClass(long long) @ stdcall SetProcessAffinityMask(long long) @ stdcall -import SetProcessAffinityUpdateMode(long long) +@ stdcall -import SetProcessDefaultCpuSets(ptr ptr long) @ stdcall SetProcessDEPPolicy(long) @ stdcall -import SetProcessMitigationPolicy(long ptr long) @ stdcall -import SetProcessPreferredUILanguages(long ptr ptr) diff --git a/dlls/kernelbase/kernelbase.spec b/dlls/kernelbase/kernelbase.spec index 1296757b29a..feb1fce8f7a 100644 --- a/dlls/kernelbase/kernelbase.spec +++ b/dlls/kernelbase/kernelbase.spec @@ -1490,7 +1490,7 @@ @ stdcall SetPrivateObjectSecurity(long ptr ptr ptr long) @ stdcall SetPrivateObjectSecurityEx(long ptr ptr long ptr long) @ stdcall SetProcessAffinityUpdateMode(long long) -# @ stub SetProcessDefaultCpuSets +@ stdcall SetProcessDefaultCpuSets(ptr ptr long) @ stdcall SetProcessGroupAffinity(long ptr ptr) # @ stub SetProcessInformation @ stdcall SetProcessMitigationPolicy(long ptr long) diff --git a/dlls/kernelbase/memory.c b/dlls/kernelbase/memory.c index 2418c670557..14d8c4817a5 100644 --- a/dlls/kernelbase/memory.c +++ b/dlls/kernelbase/memory.c @@ -1336,6 +1336,17 @@ BOOL WINAPI SetThreadSelectedCpuSets(HANDLE thread, const ULONG *cpu_set_ids, UL } +/*********************************************************************** + * SetProcessDefaultCpuSets (kernelbase.@) + */ +BOOL WINAPI SetProcessDefaultCpuSets(HANDLE process, const ULONG *cpu_set_ids, ULONG count) +{ + FIXME( "process %p, cpu_set_ids %p, count %lu stub.\n", process, cpu_set_ids, count ); + + return TRUE; +} + + /********************************************************************** * GetNumaHighestNodeNumber (kernelbase.@) */

1 0

André Zwing : wow64: Fix the ARM32 machine type.
by Alexandre Julliard Aug. 25, 2022

Aug. 25, 2022

Module: wine Branch: master Commit: 9eaeebf0393927cfc54124054fc8653993a1712c URL: https://gitlab.winehq.org/wine/wine/-/commit/9eaeebf0393927cfc54124054fc865… Author: André Zwing <nerv(a)dawncrow.de> Date: Thu Aug 25 20:03:16 2022 +0200 wow64: Fix the ARM32 machine type. --- dlls/wow64/syscall.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/wow64/syscall.c b/dlls/wow64/syscall.c index 8cb5f92c245..0f9e64fd53b 100644 --- a/dlls/wow64/syscall.c +++ b/dlls/wow64/syscall.c @@ -552,7 +552,7 @@ static const WCHAR *get_cpu_dll_name(void) { case IMAGE_FILE_MACHINE_I386: return (native_machine == IMAGE_FILE_MACHINE_ARM64 ? L"xtajit.dll" : L"wow64cpu.dll"); - case IMAGE_FILE_MACHINE_ARM: + case IMAGE_FILE_MACHINE_ARMNT: return L"wowarmhw.dll"; default: ERR( "unsupported machine %04x\n", current_machine );

1 0

Loïc Rebmeister : wintypes: Add RoResolveNamespace stub.
by Alexandre Julliard Aug. 25, 2022

Aug. 25, 2022

Module: wine Branch: master Commit: ddb0339fa126379b0d6a39a38ce2aee6c52f5711 URL: https://gitlab.winehq.org/wine/wine/-/commit/ddb0339fa126379b0d6a39a38ce2ae… Author: Loïc Rebmeister <fox2code(a)gmail.com> Date: Thu Aug 25 18:08:47 2022 +0200 wintypes: Add RoResolveNamespace stub. Signed-off-by: Loïc Rebmeister <fox2code(a)gmail.com> --- dlls/wintypes/main.c | 15 +++++++++++++++ dlls/wintypes/wintypes.spec | 2 +- 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/dlls/wintypes/main.c b/dlls/wintypes/main.c index 1ca8d94cd67..74eda4af5ce 100644 --- a/dlls/wintypes/main.c +++ b/dlls/wintypes/main.c @@ -354,3 +354,18 @@ HRESULT WINAPI DllGetActivationFactory(HSTRING classid, IActivationFactory **fac IUnknown_AddRef(*factory); return S_OK; } + +HRESULT WINAPI RoResolveNamespace(HSTRING name, HSTRING windowsMetaDataDir, + DWORD packageGraphDirsCount, const HSTRING *packageGraphDirs, + DWORD *metaDataFilePathsCount, HSTRING **metaDataFilePaths, + DWORD *subNamespacesCount, HSTRING **subNamespaces) +{ + FIXME("name %s, windowsMetaDataDir %s, metaDataFilePaths %p, subNamespaces %p stub!\n", + debugstr_hstring(name), debugstr_hstring(windowsMetaDataDir), + metaDataFilePaths, subNamespaces); + + if (!metaDataFilePaths && !subNamespaces) + return E_INVALIDARG; + + return RO_E_METADATA_NAME_NOT_FOUND; +} diff --git a/dlls/wintypes/wintypes.spec b/dlls/wintypes/wintypes.spec index 7c3a8d402a7..305344fef42 100644 --- a/dlls/wintypes/wintypes.spec +++ b/dlls/wintypes/wintypes.spec @@ -8,4 +8,4 @@ @ stub RoIsApiContractMajorVersionPresent @ stub RoIsApiContractPresent @ stub RoParseTypeName -@ stub RoResolveNamespace +@ stdcall RoResolveNamespace(ptr ptr long ptr ptr ptr ptr ptr)

1 0

Brendan Shanks : shell32: Return NULL from ExtractIcon() for all error cases.
by Alexandre Julliard Aug. 25, 2022

Aug. 25, 2022

Module: wine Branch: master Commit: 42f9a8ef79aa8d793bd6ec8667dafc2cfa37cba5 URL: https://gitlab.winehq.org/wine/wine/-/commit/42f9a8ef79aa8d793bd6ec8667dafc… Author: Brendan Shanks <bshanks(a)codeweavers.com> Date: Wed Aug 24 15:26:03 2022 -0700 shell32: Return NULL from ExtractIcon() for all error cases. --- dlls/shell32/shell32_main.c | 11 ++++------- dlls/shell32/tests/shelllink.c | 7 ------- 2 files changed, 4 insertions(+), 14 deletions(-) diff --git a/dlls/shell32/shell32_main.c b/dlls/shell32/shell32_main.c index 212de7445a4..2aac022f9e4 100644 --- a/dlls/shell32/shell32_main.c +++ b/dlls/shell32/shell32_main.c @@ -606,16 +606,13 @@ HICON WINAPI ExtractIconW(HINSTANCE hInstance, LPCWSTR lpszFile, UINT nIconIndex ret = PrivateExtractIconsW(lpszFile, 0, cx, cy, NULL, NULL, 0, LR_DEFAULTCOLOR); if (ret != (UINT)-1 && ret) return (HICON)(UINT_PTR)ret; - return NULL; } else + { ret = PrivateExtractIconsW(lpszFile, nIconIndex, cx, cy, &hIcon, NULL, 1, LR_DEFAULTCOLOR); - - if (ret == (UINT)-1) - return (HICON)1; - else if (ret > 0 && hIcon) - return hIcon; - + if (ret > 0 && hIcon) + return hIcon; + } return NULL; } diff --git a/dlls/shell32/tests/shelllink.c b/dlls/shell32/tests/shelllink.c index 13dce3302c7..345484d9a5d 100644 --- a/dlls/shell32/tests/shelllink.c +++ b/dlls/shell32/tests/shelllink.c @@ -1185,7 +1185,6 @@ static void test_ExtractIcon(void) /* specified instance handle */ hicon = ExtractIconA(GetModuleHandleA("shell32.dll"), NULL, 0); - todo_wine ok(hicon == NULL, "Got icon %p\n", hicon); hicon2 = ExtractIconA(GetModuleHandleA("shell32.dll"), "shell32.dll", -1); ok(hicon2 != NULL, "Got icon %p\n", hicon2); @@ -1211,14 +1210,12 @@ static void test_ExtractIcon(void) CloseHandle(file); hicon = ExtractIconA(NULL, path, 0); - todo_wine ok(hicon == NULL, "Got icon %p\n", hicon); hicon = ExtractIconA(NULL, path, -1); ok(hicon == NULL, "Got icon %p\n", hicon); hicon = ExtractIconA(NULL, path, 1); - todo_wine ok(hicon == NULL, "Got icon %p\n", hicon); r = DeleteFileA(path); @@ -1229,7 +1226,6 @@ static void test_ExtractIcon(void) ok(hicon == NULL, "Got icon %p\n", hicon); hicon = ExtractIconA(NULL, "", 0); - todo_wine ok(hicon == NULL, "Got icon %p\n", hicon); /* same for W variant */ @@ -1267,14 +1263,12 @@ if (0) CloseHandle(file); hicon = ExtractIconW(NULL, pathW, 0); - todo_wine ok(hicon == NULL, "Got icon %p\n", hicon); hicon = ExtractIconW(NULL, pathW, -1); ok(hicon == NULL, "Got icon %p\n", hicon); hicon = ExtractIconW(NULL, pathW, 1); - todo_wine ok(hicon == NULL, "Got icon %p\n", hicon); r = DeleteFileW(pathW); @@ -1285,7 +1279,6 @@ if (0) ok(hicon == NULL, "Got icon %p\n", hicon); hicon = ExtractIconW(NULL, emptyW, 0); - todo_wine ok(hicon == NULL, "Got icon %p\n", hicon); }

1 0

Brendan Shanks : shell32/tests: Test ExtractIcon() with an empty/invalid path.
by Alexandre Julliard Aug. 25, 2022

Aug. 25, 2022

Module: wine Branch: master Commit: 584eb4e80423b3ac0c00dc2936f69dc6717c9590 URL: https://gitlab.winehq.org/wine/wine/-/commit/584eb4e80423b3ac0c00dc2936f69d… Author: Brendan Shanks <bshanks(a)codeweavers.com> Date: Wed Aug 24 15:22:14 2022 -0700 shell32/tests: Test ExtractIcon() with an empty/invalid path. --- dlls/shell32/tests/shelllink.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/dlls/shell32/tests/shelllink.c b/dlls/shell32/tests/shelllink.c index c8a0308a9cb..13dce3302c7 100644 --- a/dlls/shell32/tests/shelllink.c +++ b/dlls/shell32/tests/shelllink.c @@ -1174,6 +1174,7 @@ static void test_ExtractIcon(void) { static const WCHAR nameW[] = {'\\','e','x','t','r','a','c','t','i','c','o','n','_','t','e','s','t','.','t','x','t',0}; static const WCHAR shell32W[] = {'s','h','e','l','l','3','2','.','d','l','l',0}; + static const WCHAR emptyW[] = {0}; WCHAR pathW[MAX_PATH]; HICON hicon, hicon2; char path[MAX_PATH]; @@ -1223,6 +1224,14 @@ static void test_ExtractIcon(void) r = DeleteFileA(path); ok(r, "failed to delete file %s (%ld)\n", path, GetLastError()); + /* Empty file path */ + hicon = ExtractIconA(NULL, "", -1); + ok(hicon == NULL, "Got icon %p\n", hicon); + + hicon = ExtractIconA(NULL, "", 0); + todo_wine + ok(hicon == NULL, "Got icon %p\n", hicon); + /* same for W variant */ if (0) { @@ -1270,6 +1279,14 @@ if (0) r = DeleteFileW(pathW); ok(r, "failed to delete file %s (%ld)\n", path, GetLastError()); + + /* Empty file path */ + hicon = ExtractIconW(NULL, emptyW, -1); + ok(hicon == NULL, "Got icon %p\n", hicon); + + hicon = ExtractIconW(NULL, emptyW, 0); + todo_wine + ok(hicon == NULL, "Got icon %p\n", hicon); } static void test_ExtractAssociatedIcon(void)

1 0

Jacek Caban : user32: Pass resource ID as a string in DIALOG_CreateControls32.
by Alexandre Julliard Aug. 25, 2022

Aug. 25, 2022

Module: wine Branch: master Commit: 0739aa610cc073beb0cf32dbaf8c2a8a83aa1ecd URL: https://gitlab.winehq.org/wine/wine/-/commit/0739aa610cc073beb0cf32dbaf8c2a… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Fri Aug 19 20:50:41 2022 +0200 user32: Pass resource ID as a string in DIALOG_CreateControls32. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53566 --- dlls/user32/dialog.c | 23 ++++++++++++++++- dlls/user32/tests/dialog.c | 59 +++++++++++++++++++++++++++++++++++++++++++ dlls/user32/tests/resource.rc | 10 ++++++++ 3 files changed, 91 insertions(+), 1 deletion(-) diff --git a/dlls/user32/dialog.c b/dlls/user32/dialog.c index c8d1596a01b..fc7ddb303ff 100644 --- a/dlls/user32/dialog.c +++ b/dlls/user32/dialog.c @@ -220,8 +220,19 @@ static BOOL DIALOG_CreateControls32( HWND hwnd, LPCSTR template, const DLG_TEMPL } if (unicode) { + const WCHAR *caption = info.windowName; + WCHAR caption_buf[3]; + + if (IS_INTRESOURCE(caption) && caption) + { + caption_buf[0] = 0xffff; + caption_buf[1] = PtrToUlong( caption ); + caption_buf[2] = 0; + caption = caption_buf; + } + hwndCtrl = CreateWindowExW( info.exStyle | WS_EX_NOPARENTNOTIFY, - info.className, info.windowName, + info.className, caption, info.style | WS_CHILD, MulDiv(info.x, dlgInfo->xBaseUnit, 4), MulDiv(info.y, dlgInfo->yBaseUnit, 8), @@ -236,6 +247,7 @@ static BOOL DIALOG_CreateControls32( HWND hwnd, LPCSTR template, const DLG_TEMPL LPCSTR caption = (LPCSTR)info.windowName; LPSTR class_tmp = NULL; LPSTR caption_tmp = NULL; + char caption_buf[4]; if (!IS_INTRESOURCE(class)) { @@ -251,6 +263,15 @@ static BOOL DIALOG_CreateControls32( HWND hwnd, LPCSTR template, const DLG_TEMPL WideCharToMultiByte( CP_ACP, 0, info.windowName, -1, caption_tmp, len, NULL, NULL ); caption = caption_tmp; } + else if (caption) + { + caption_buf[0] = 0xff; + caption_buf[1] = PtrToUlong( caption ); + caption_buf[2] = PtrToUlong( caption ) >> 8; + caption_buf[3] = 0; + caption = caption_buf; + } + hwndCtrl = CreateWindowExA( info.exStyle | WS_EX_NOPARENTNOTIFY, class, caption, info.style | WS_CHILD, MulDiv(info.x, dlgInfo->xBaseUnit, 4), diff --git a/dlls/user32/tests/dialog.c b/dlls/user32/tests/dialog.c index 0ac1d48a375..3df1a0eab32 100644 --- a/dlls/user32/tests/dialog.c +++ b/dlls/user32/tests/dialog.c @@ -2260,6 +2260,64 @@ static void test_capture_release(void) DestroyWindow(window); } +static WNDPROC orig_static_proc; +static WCHAR cs_name_paramW[3]; +static char cs_name_paramA[4]; + +static LRESULT WINAPI test_static_create_procW(HWND hwnd, UINT msg, WPARAM wparam, LPARAM lparam) +{ + if (msg == WM_NCCREATE) + { + CREATESTRUCTW *cs = (CREATESTRUCTW *)lparam; + memcpy( cs_name_paramW, cs->lpszName, sizeof(cs_name_paramW) ); + } + + return orig_static_proc(hwnd, msg, wparam, lparam); +} + +static LRESULT WINAPI test_static_create_procA(HWND hwnd, UINT msg, WPARAM wparam, LPARAM lparam) +{ + if (msg == WM_NCCREATE) + { + CREATESTRUCTA *cs = (CREATESTRUCTA *)lparam; + memcpy( cs_name_paramA, cs->lpszName, sizeof(cs_name_paramA) ); + } + + return orig_static_proc(hwnd, msg, wparam, lparam); +} + +static void test_create_controls(void) +{ + HWND control; + INT_PTR ret; + + control = CreateWindowA("static", "", 0, 100, 200, 300, 400, NULL, NULL, NULL, NULL); + ok(control != 0, "failed to create control window\n"); + + orig_static_proc = (WNDPROC)SetClassLongPtrA(control, GCLP_WNDPROC, (ULONG_PTR)test_static_create_procA); + + cs_name_paramW[0] = 0; + ret = DialogBoxParamA(GetModuleHandleA(NULL), "IDD_SS_ICON_DIALOG", 0, DestroyOnCloseDlgWinProc, 0); + ok(0 == ret, "DialogBoxParamA returned %Id, expected 0\n", ret); + ok(!memcmp(cs_name_paramA, "\xff\0\x61", 3), "name param = %s\n", debugstr_an(cs_name_paramA, 3)); + + SetClassLongPtrA(control, GCLP_WNDPROC, (ULONG_PTR)orig_static_proc); + DestroyWindow(control); + + control = CreateWindowW(L"static", L"", 0, 100, 200, 300, 400, NULL, NULL, NULL, NULL); + ok(control != 0, "failed to create control window\n"); + + orig_static_proc = (WNDPROC)SetClassLongPtrW(control, GCLP_WNDPROC, (ULONG_PTR)test_static_create_procW); + + ret = DialogBoxParamW(GetModuleHandleW(NULL), L"IDD_SS_ICON_DIALOG", 0, DestroyOnCloseDlgWinProc, 0); + ok(0 == ret, "DialogBoxParamW returned %Id, expected 0\n", ret); + ok(!memcmp(cs_name_paramW, L"\xffff\x6100", 2 * sizeof(WCHAR)), + "name param = %s\n", debugstr_wn(cs_name_paramW, 2)); + + SetClassLongPtrW(control, GCLP_WNDPROC, (ULONG_PTR)orig_static_proc); + DestroyWindow(control); +} + START_TEST(dialog) { g_hinst = GetModuleHandleA (0); @@ -2273,6 +2331,7 @@ START_TEST(dialog) test_focus(); test_GetDlgItem(); test_GetDlgItemText(); + test_create_controls(); test_DialogBoxParam(); test_DisabledDialogTest(); test_MessageBoxFontTest(); diff --git a/dlls/user32/tests/resource.rc b/dlls/user32/tests/resource.rc index 89aaf5a61c5..a957e50689d 100644 --- a/dlls/user32/tests/resource.rc +++ b/dlls/user32/tests/resource.rc @@ -276,3 +276,13 @@ FONT 8, "MS Shell Dlg" } MENUITEM "&Quit", 300 } + +IDD_SS_ICON_DIALOG DIALOG 0, 0, 186, 95 +STYLE DS_MODALFRAME | WS_POPUP | WS_VISIBLE | WS_CAPTION | WS_SYSMENU +CAPTION "Dialog" +FONT 8, "MS Sans Serif" +BEGIN + CONTROL 0x6100, 1003, "STATIC", SS_ICON | WS_CHILD | WS_VISIBLE, 7, 57, 21, 20 + DEFPUSHBUTTON "OK",IDOK,129,7,50,14 + PUSHBUTTON "Cancel",IDCANCEL,129,24,50,14 +END

1 0

Jacek Caban : user32: Support passing bitmap and icon resource ID as a string when creating static control.
by Alexandre Julliard Aug. 25, 2022

Aug. 25, 2022

Module: wine Branch: master Commit: 2e9c40d50acbbbb915488fdc70e70c4cc1d205bb URL: https://gitlab.winehq.org/wine/wine/-/commit/2e9c40d50acbbbb915488fdc70e70c… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Mon Aug 22 13:45:10 2022 +0200 user32: Support passing bitmap and icon resource ID as a string when creating static control. --- dlls/user32/static.c | 38 ++++++++++++++++++++++++++++++++------ dlls/user32/tests/static.c | 18 ++++++++++++++++++ 2 files changed, 50 insertions(+), 6 deletions(-) diff --git a/dlls/user32/static.c b/dlls/user32/static.c index a88203f5716..f5cef12b12a 100644 --- a/dlls/user32/static.c +++ b/dlls/user32/static.c @@ -418,22 +418,48 @@ LRESULT StaticWndProc_common( HWND hwnd, UINT uMsg, WPARAM wParam, LPARAM lParam switch (style) { case SS_ICON: { + const WCHAR *name = cs->lpszName; HICON hIcon; - if (unicode || IS_INTRESOURCE(cs->lpszName)) - hIcon = STATIC_LoadIconW(cs->hInstance, cs->lpszName, full_style); + + if (!unicode) + { + const char *nameA = (const char *)name; + if (nameA && nameA[0] == '\xff') + name = MAKEINTRESOURCEW(MAKEWORD(nameA[1], nameA[2])); + } + else if (name && name[0] == 0xffff) + { + name = MAKEINTRESOURCEW(name[1]); + } + + if (unicode || IS_INTRESOURCE(name)) + hIcon = STATIC_LoadIconW(cs->hInstance, name, full_style); else - hIcon = STATIC_LoadIconA(cs->hInstance, (LPCSTR)cs->lpszName, full_style); + hIcon = STATIC_LoadIconA(cs->hInstance, (const char *)name, full_style); STATIC_SetIcon(hwnd, hIcon, full_style); } break; case SS_BITMAP: if ((ULONG_PTR)cs->hInstance >> 16) { + const WCHAR *name = cs->lpszName; HBITMAP hBitmap; - if (unicode || IS_INTRESOURCE(cs->lpszName)) - hBitmap = LoadBitmapW(cs->hInstance, cs->lpszName); + + if (!unicode) + { + const char *nameA = (const char *)name; + if (nameA && nameA[0] == '\xff') + name = MAKEINTRESOURCEW(MAKEWORD(nameA[1], nameA[2])); + } + else if (name && name[0] == 0xffff) + { + name = MAKEINTRESOURCEW(name[1]); + } + + if (unicode || IS_INTRESOURCE(name)) + hBitmap = LoadBitmapW(cs->hInstance, name); else - hBitmap = LoadBitmapA(cs->hInstance, (LPCSTR)cs->lpszName); + hBitmap = LoadBitmapA(cs->hInstance, (const char *)name); STATIC_SetBitmap(hwnd, hBitmap, full_style); } break; diff --git a/dlls/user32/tests/static.c b/dlls/user32/tests/static.c index 09e399990cd..a02cb249d49 100644 --- a/dlls/user32/tests/static.c +++ b/dlls/user32/tests/static.c @@ -197,6 +197,24 @@ static void test_set_image(void) DestroyWindow(hwnd); DeleteObject(image); + + hwnd = CreateWindowW(L"static", L"\uffff\x65", WS_VISIBLE|WS_CHILD|SS_BITMAP, 5, 5, 100, 100, + hMainWnd, (HMENU)CTRL_ID, GetModuleHandleW(NULL), 0); + + bmp = (HBITMAP)SendMessageW(hwnd, STM_GETIMAGE, IMAGE_BITMAP, 0); + ok(bmp != NULL, "got NULL\n"); + test_image(bmp); + + DestroyWindow(hwnd); + + hwnd = CreateWindowA("static", "\xff\x65\0", WS_VISIBLE|WS_CHILD|SS_BITMAP, 5, 5, 100, 100, + hMainWnd, (HMENU)CTRL_ID, GetModuleHandleW(NULL), 0); + + bmp = (HBITMAP)SendMessageW(hwnd, STM_GETIMAGE, IMAGE_BITMAP, 0); + ok(bmp != NULL, "got NULL\n"); + test_image(bmp); + + DestroyWindow(hwnd); } static void test_STM_SETIMAGE(void)

1 0