October 2023 - Wine-Commits

Connor McAdams : uiautomationcore: Only print FIXME messages for missing default clientside providers once.
by Alexandre Julliard Oct. 20, 2023

Oct. 20, 2023

Module: wine Branch: master Commit: b22a06281a2ccc431fa537e7c501ba9e923c3da8 URL: https://gitlab.winehq.org/wine/wine/-/commit/b22a06281a2ccc431fa537e7c501ba… Author: Connor McAdams <cmcadams(a)codeweavers.com> Date: Thu Oct 19 07:20:26 2023 -0400 uiautomationcore: Only print FIXME messages for missing default clientside providers once. Signed-off-by: Connor McAdams <cmcadams(a)codeweavers.com> --- dlls/uiautomationcore/uia_client.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/dlls/uiautomationcore/uia_client.c b/dlls/uiautomationcore/uia_client.c index baadecd56d0..df9b2b283e0 100644 --- a/dlls/uiautomationcore/uia_client.c +++ b/dlls/uiautomationcore/uia_client.c @@ -3131,6 +3131,7 @@ HRESULT WINAPI UiaHUiaNodeFromVariant(VARIANT *in_val, HUIANODE *huianode) static SAFEARRAY WINAPI *default_uia_provider_callback(HWND hwnd, enum ProviderType prov_type) { IRawElementProviderSimple *elprov = NULL; + static BOOL fixme_once; SAFEARRAY *sa = NULL; HRESULT hr; @@ -3153,7 +3154,8 @@ static SAFEARRAY WINAPI *default_uia_provider_callback(HWND hwnd, enum ProviderT } case ProviderType_NonClientArea: - FIXME("Default ProviderType_NonClientArea provider unimplemented.\n"); + if (!fixme_once++) + FIXME("Default ProviderType_NonClientArea provider unimplemented.\n"); break; case ProviderType_BaseHwnd: @@ -3238,6 +3240,7 @@ exit: static HRESULT uia_get_providers_for_hwnd(struct uia_node *node) { + static BOOL fixme_once; HRESULT hr; hr = uia_get_provider_from_hwnd(node); @@ -3251,7 +3254,7 @@ static HRESULT uia_get_providers_for_hwnd(struct uia_node *node) return hr; } - if (!node->prov[PROV_TYPE_OVERRIDE]) + if (!node->prov[PROV_TYPE_OVERRIDE] && !fixme_once++) FIXME("Override provider callback currently unimplemented.\n"); if (!node->prov[PROV_TYPE_NONCLIENT])

1 0

Rémi Bernon : dmime: Return S_OK from wave track SetParam GUID_UnloadFromAudioPath.
by Alexandre Julliard Oct. 20, 2023

Oct. 20, 2023

Module: wine Branch: master Commit: 0431c88a9dffce2bd9360fc412e26ef913f8f974 URL: https://gitlab.winehq.org/wine/wine/-/commit/0431c88a9dffce2bd9360fc412e26e… Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Tue Oct 17 11:28:42 2023 +0200 dmime: Return S_OK from wave track SetParam GUID_UnloadFromAudioPath. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55792 --- dlls/dmime/wavetrack.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/dlls/dmime/wavetrack.c b/dlls/dmime/wavetrack.c index def1e59fb23..79169a2a6fa 100644 --- a/dlls/dmime/wavetrack.c +++ b/dlls/dmime/wavetrack.c @@ -296,6 +296,8 @@ static HRESULT WINAPI wave_track_SetParam(IDirectMusicTrack8 *iface, REFGUID typ item->buffer = NULL; } } + + return S_OK; } return DMUS_E_TYPE_UNSUPPORTED;

1 0

Rémi Bernon : dmime: Return hr from wave track SetParam GUID_DownloadToAudioPath.
by Alexandre Julliard Oct. 20, 2023

Oct. 20, 2023

Module: wine Branch: master Commit: b1bfc52676cbb41e3fbc0f114588acc486028c7d URL: https://gitlab.winehq.org/wine/wine/-/commit/b1bfc52676cbb41e3fbc0f114588ac… Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Tue Oct 17 11:29:18 2023 +0200 dmime: Return hr from wave track SetParam GUID_DownloadToAudioPath. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55792 --- dlls/dmime/wavetrack.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/dlls/dmime/wavetrack.c b/dlls/dmime/wavetrack.c index 79169a2a6fa..fcf57c1148d 100644 --- a/dlls/dmime/wavetrack.c +++ b/dlls/dmime/wavetrack.c @@ -273,6 +273,8 @@ static HRESULT WINAPI wave_track_SetParam(IDirectMusicTrack8 *iface, REFGUID typ } } } + + return hr; } if (IsEqualGUID(type, &GUID_Enable_Auto_Download)) { FIXME("GUID_Enable_Auto_Download not handled yet\n");

1 0

Rémi Bernon : dmime: Avoid releasing the newly created graph twice.
by Alexandre Julliard Oct. 20, 2023

Oct. 20, 2023

Module: wine Branch: master Commit: 231dd330cf281a5f33eba25d1d562368bb176229 URL: https://gitlab.winehq.org/wine/wine/-/commit/231dd330cf281a5f33eba25d1d5623… Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Tue Oct 17 12:41:40 2023 +0200 dmime: Avoid releasing the newly created graph twice. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55790 --- dlls/dmime/audiopath.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/dlls/dmime/audiopath.c b/dlls/dmime/audiopath.c index 3310624eb00..65691f4705f 100644 --- a/dlls/dmime/audiopath.c +++ b/dlls/dmime/audiopath.c @@ -195,8 +195,6 @@ static HRESULT WINAPI IDirectMusicAudioPathImpl_GetObjectInPath (IDirectMusicAud if (FAILED(hr)) return hr; IDirectMusicPerformance8_SetGraph(This->pPerf, pGraph); - /* we need release as SetGraph do an AddRef */ - IDirectMusicGraph_Release(pGraph); pPerfoGraph = pGraph; } *ppObject = pPerfoGraph;

1 0

Jacek Caban : d2d1: Pass interpolation mode as D2D1_INTERPOLATION_MODE to d2d_device_context_draw_bitmap.
by Alexandre Julliard Oct. 20, 2023

Oct. 20, 2023

Module: wine Branch: master Commit: f319d4ce8edb1803f536858f745372c4bfb0788b URL: https://gitlab.winehq.org/wine/wine/-/commit/f319d4ce8edb1803f536858f745372… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Tue Oct 17 22:30:48 2023 +0200 d2d1: Pass interpolation mode as D2D1_INTERPOLATION_MODE to d2d_device_context_draw_bitmap. --- dlls/d2d1/device.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/dlls/d2d1/device.c b/dlls/d2d1/device.c index a8993e79d4d..e5548878ee9 100644 --- a/dlls/d2d1/device.c +++ b/dlls/d2d1/device.c @@ -2544,8 +2544,7 @@ static void STDMETHODCALLTYPE d2d_device_context_DrawImage(ID2D1DeviceContext1 * if (SUCCEEDED(ID2D1Image_QueryInterface(image, &IID_ID2D1Bitmap, (void **)&bitmap))) { - d2d_device_context_draw_bitmap(context, bitmap, NULL, 1.0f, d2d1_1_interp_mode_from_d2d1(interpolation_mode), - image_rect, target_offset, NULL); + d2d_device_context_draw_bitmap(context, bitmap, NULL, 1.0f, interpolation_mode, image_rect, target_offset, NULL); ID2D1Bitmap_Release(bitmap); return;

1 0

Jacek Caban : d2d1/tests: Use D2D1_INTERPOLATION_MODE constants in DrawImage calls.
by Alexandre Julliard Oct. 20, 2023

Oct. 20, 2023

Module: wine Branch: master Commit: a07fbb93072ff236ea3782f65a22dd76c765483b URL: https://gitlab.winehq.org/wine/wine/-/commit/a07fbb93072ff236ea3782f65a22dd… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Tue Oct 17 22:28:44 2023 +0200 d2d1/tests: Use D2D1_INTERPOLATION_MODE constants in DrawImage calls. --- dlls/d2d1/tests/d2d1.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/dlls/d2d1/tests/d2d1.c b/dlls/d2d1/tests/d2d1.c index 024886706c3..58f905ca1dc 100644 --- a/dlls/d2d1/tests/d2d1.c +++ b/dlls/d2d1/tests/d2d1.c @@ -2266,41 +2266,41 @@ static void test_bitmap_brush(BOOL d3d11) /* Crash on Windows 7+ */ if (0) { - ID2D1DeviceContext_DrawImage(context, NULL, NULL, NULL, D2D1_BITMAP_INTERPOLATION_MODE_NEAREST_NEIGHBOR, + ID2D1DeviceContext_DrawImage(context, NULL, NULL, NULL, D2D1_INTERPOLATION_MODE_NEAREST_NEIGHBOR, D2D1_COMPOSITE_MODE_SOURCE_OVER); } - ID2D1DeviceContext_DrawImage(context, image, NULL, NULL, D2D1_BITMAP_INTERPOLATION_MODE_NEAREST_NEIGHBOR, + ID2D1DeviceContext_DrawImage(context, image, NULL, NULL, D2D1_INTERPOLATION_MODE_NEAREST_NEIGHBOR, D2D1_COMPOSITE_MODE_SOURCE_OVER); set_rect(&src_rect, 0.0f, 0.0f, image_size.width, image_size.height); - ID2D1DeviceContext_DrawImage(context, image, NULL, &src_rect, D2D1_BITMAP_INTERPOLATION_MODE_NEAREST_NEIGHBOR, + ID2D1DeviceContext_DrawImage(context, image, NULL, &src_rect, D2D1_INTERPOLATION_MODE_NEAREST_NEIGHBOR, D2D1_COMPOSITE_MODE_SOURCE_OVER); offset.x = -1; offset.y = -1; - ID2D1DeviceContext_DrawImage(context, image, &offset, NULL, D2D1_BITMAP_INTERPOLATION_MODE_NEAREST_NEIGHBOR, + ID2D1DeviceContext_DrawImage(context, image, &offset, NULL, D2D1_INTERPOLATION_MODE_NEAREST_NEIGHBOR, D2D1_COMPOSITE_MODE_SOURCE_OVER); offset.x = image_size.width * 2; offset.y = image_size.height; - ID2D1DeviceContext_DrawImage(context, image, &offset, NULL, D2D1_BITMAP_INTERPOLATION_MODE_NEAREST_NEIGHBOR, + ID2D1DeviceContext_DrawImage(context, image, &offset, NULL, D2D1_INTERPOLATION_MODE_NEAREST_NEIGHBOR, D2D1_COMPOSITE_MODE_SOURCE_OVER); offset.x = image_size.width * 3; set_rect(&src_rect, image_size.width / 2, image_size.height / 2, image_size.width, image_size.height); - ID2D1DeviceContext_DrawImage(context, image, &offset, &src_rect, D2D1_BITMAP_INTERPOLATION_MODE_NEAREST_NEIGHBOR, + ID2D1DeviceContext_DrawImage(context, image, &offset, &src_rect, D2D1_INTERPOLATION_MODE_NEAREST_NEIGHBOR, D2D1_COMPOSITE_MODE_SOURCE_OVER); offset.x = image_size.width * 4; set_rect(&src_rect, 0.0f, 0.0f, image_size.width * 2, image_size.height * 2); - ID2D1DeviceContext_DrawImage(context, image, &offset, &src_rect, D2D1_BITMAP_INTERPOLATION_MODE_NEAREST_NEIGHBOR, + ID2D1DeviceContext_DrawImage(context, image, &offset, &src_rect, D2D1_INTERPOLATION_MODE_NEAREST_NEIGHBOR, D2D1_COMPOSITE_MODE_SOURCE_OVER); offset.x = image_size.width * 5; set_rect(&src_rect, image_size.width, image_size.height, 0.0f, 0.0f); - ID2D1DeviceContext_DrawImage(context, image, &offset, &src_rect, D2D1_BITMAP_INTERPOLATION_MODE_NEAREST_NEIGHBOR, + ID2D1DeviceContext_DrawImage(context, image, &offset, &src_rect, D2D1_INTERPOLATION_MODE_NEAREST_NEIGHBOR, D2D1_COMPOSITE_MODE_SOURCE_OVER); hr = ID2D1RenderTarget_EndDraw(rt, NULL, NULL); @@ -2312,7 +2312,7 @@ static void test_bitmap_brush(BOOL d3d11) offset.x = image_size.width * 6; set_rect(&src_rect, 1.0f, 0.0f, 1.0f, image_size.height); - ID2D1DeviceContext_DrawImage(context, image, &offset, &src_rect, D2D1_BITMAP_INTERPOLATION_MODE_NEAREST_NEIGHBOR, + ID2D1DeviceContext_DrawImage(context, image, &offset, &src_rect, D2D1_INTERPOLATION_MODE_NEAREST_NEIGHBOR, D2D1_COMPOSITE_MODE_SOURCE_OVER); hr = ID2D1RenderTarget_EndDraw(rt, NULL, NULL);

1 0

Jacek Caban : d2d1: Don't cast D2D1_THREADING_MODE to D2D1_FACTORY_TYPE in D2D1CreateDevice.
by Alexandre Julliard Oct. 20, 2023

Oct. 20, 2023

Module: wine Branch: master Commit: 6239db72ed4f00eb0c84105ed51fcea64b60bab3 URL: https://gitlab.winehq.org/wine/wine/-/commit/6239db72ed4f00eb0c84105ed51fce… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Oct 18 10:23:37 2023 +0200 d2d1: Don't cast D2D1_THREADING_MODE to D2D1_FACTORY_TYPE in D2D1CreateDevice. --- dlls/d2d1/factory.c | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/dlls/d2d1/factory.c b/dlls/d2d1/factory.c index fff9895e930..3b2b1f5e4ec 100644 --- a/dlls/d2d1/factory.c +++ b/dlls/d2d1/factory.c @@ -1308,6 +1308,7 @@ HRESULT WINAPI D2D1CreateDevice(IDXGIDevice *dxgi_device, { D2D1_CREATION_PROPERTIES default_properties = {0}; D2D1_FACTORY_OPTIONS factory_options; + D2D1_FACTORY_TYPE factory_type; ID3D11Device *d3d_device; ID2D1Factory1 *factory; HRESULT hr; @@ -1325,9 +1326,20 @@ HRESULT WINAPI D2D1CreateDevice(IDXGIDevice *dxgi_device, properties = &default_properties; } + switch (properties->threadingMode) + { + case D2D1_THREADING_MODE_SINGLE_THREADED: + factory_type = D2D1_FACTORY_TYPE_SINGLE_THREADED; + break; + case D2D1_THREADING_MODE_MULTI_THREADED: + factory_type = D2D1_FACTORY_TYPE_MULTI_THREADED; + break; + default: + return E_INVALIDARG; + } + factory_options.debugLevel = properties->debugLevel; - if (FAILED(hr = D2D1CreateFactory(properties->threadingMode, - &IID_ID2D1Factory1, &factory_options, (void **)&factory))) + if (FAILED(hr = D2D1CreateFactory(factory_type, &IID_ID2D1Factory1, &factory_options, (void **)&factory))) return hr; hr = ID2D1Factory1_CreateDevice(factory, dxgi_device, device);

1 0

Rémi Bernon : dmime: Avoid crashing when purging notification messages.
by Alexandre Julliard Oct. 20, 2023

Oct. 20, 2023

Module: wine Branch: master Commit: 4d0c3d89a46029697cbc5414fc882cae3136b3d4 URL: https://gitlab.winehq.org/wine/wine/-/commit/4d0c3d89a46029697cbc5414fc882c… Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Tue Oct 17 11:23:16 2023 +0200 dmime: Avoid crashing when purging notification messages. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55792 --- dlls/dmime/performance.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dlls/dmime/performance.c b/dlls/dmime/performance.c index a8fcd869331..a2e611523a6 100644 --- a/dlls/dmime/performance.c +++ b/dlls/dmime/performance.c @@ -1783,6 +1783,7 @@ static HRESULT WINAPI performance_tool_ProcessPMsg(IDirectMusicTool *iface, do { previous = LIST_ENTRY(list_head(&This->notifications), struct message, entry); + if (This->notification_timeout <= 0) break; /* negative values may be used to keep everything */ if (message->msg.rtTime - previous->msg.rtTime <= This->notification_timeout) break; list_remove(&previous->entry); list_init(&previous->entry);

1 0

Alexandre Julliard : shlwapi: Remove unneeded UNALIGNED attributes.
by Alexandre Julliard Oct. 20, 2023

Oct. 20, 2023

Module: wine Branch: master Commit: 6289a5848b4745a2f0a086fce51195ca08b81992 URL: https://gitlab.winehq.org/wine/wine/-/commit/6289a5848b4745a2f0a086fce51195… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Oct 20 12:44:51 2023 +0200 shlwapi: Remove unneeded UNALIGNED attributes. They are causing compiler warnings. --- dlls/shlwapi/ordinal.c | 4 ++-- dlls/shlwapi/tests/ordinal.c | 10 +++++----- include/shlwapi.h | 4 ++-- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/dlls/shlwapi/ordinal.c b/dlls/shlwapi/ordinal.c index bf43a17fba2..f99dbf795ff 100644 --- a/dlls/shlwapi/ordinal.c +++ b/dlls/shlwapi/ordinal.c @@ -4282,7 +4282,7 @@ HRESULT WINAPI SHCreatePropertyBagOnRegKey (HKEY hKey, LPCWSTR subkey, * failure: 0 * */ -INT WINAPI SHFormatDateTimeW(const FILETIME UNALIGNED *fileTime, DWORD *flags, +INT WINAPI SHFormatDateTimeW(const FILETIME *fileTime, DWORD *flags, LPWSTR buf, UINT size) { #define SHFORMATDT_UNSUPPORTED_FLAGS (FDTF_RELATIVE | FDTF_LTRDATE | FDTF_RTLDATE | FDTF_NOAUTOREADINGORDER) @@ -4346,7 +4346,7 @@ INT WINAPI SHFormatDateTimeW(const FILETIME UNALIGNED *fileTime, DWORD *flags, * See SHFormatDateTimeW. * */ -INT WINAPI SHFormatDateTimeA(const FILETIME UNALIGNED *fileTime, DWORD *flags, +INT WINAPI SHFormatDateTimeA(const FILETIME *fileTime, DWORD *flags, LPSTR buf, UINT size) { WCHAR *bufW; diff --git a/dlls/shlwapi/tests/ordinal.c b/dlls/shlwapi/tests/ordinal.c index 676a537744d..474c447686d 100644 --- a/dlls/shlwapi/tests/ordinal.c +++ b/dlls/shlwapi/tests/ordinal.c @@ -51,8 +51,8 @@ static HRESULT(WINAPI *pIConnectionPoint_InvokeWithCancel)(IConnectionPoint*,DIS static HRESULT(WINAPI *pConnectToConnectionPoint)(IUnknown*,REFIID,BOOL,IUnknown*, LPDWORD,IConnectionPoint **); static HRESULT(WINAPI *pSHPropertyBag_ReadLONG)(IPropertyBag *,LPCWSTR,LPLONG); static LONG (WINAPI *pSHSetWindowBits)(HWND, INT, UINT, UINT); -static INT (WINAPI *pSHFormatDateTimeA)(const FILETIME UNALIGNED*, DWORD*, LPSTR, UINT); -static INT (WINAPI *pSHFormatDateTimeW)(const FILETIME UNALIGNED*, DWORD*, LPWSTR, UINT); +static INT (WINAPI *pSHFormatDateTimeA)(const FILETIME*, DWORD*, LPSTR, UINT); +static INT (WINAPI *pSHFormatDateTimeW)(const FILETIME*, DWORD*, LPWSTR, UINT); static DWORD (WINAPI *pSHGetObjectCompatFlags)(IUnknown*, const CLSID*); static BOOL (WINAPI *pGUIDFromStringA)(LPSTR, CLSID *); static HRESULT (WINAPI *pIUnknown_QueryServiceExec)(IUnknown*, REFIID, const GUID*, DWORD, DWORD, VARIANT*, VARIANT*); @@ -1668,8 +1668,8 @@ static void test_SHSetWindowBits(void) static void test_SHFormatDateTimeA(const SYSTEMTIME *st) { - FILETIME UNALIGNED filetime; - FILETIME UNALIGNED filetimeCheck; + FILETIME filetime; + FILETIME filetimeCheck; SYSTEMTIME universalSystemTime; CHAR buff[100], buff2[100], buff3[100]; BOOL dstMatch; @@ -1837,7 +1837,7 @@ static void test_SHFormatDateTimeA(const SYSTEMTIME *st) static void test_SHFormatDateTimeW(void) { - FILETIME UNALIGNED filetime; + FILETIME filetime; SYSTEMTIME universalSystemTime; WCHAR buff[100], buff2[100], buff3[100], *p1, *p2; SYSTEMTIME st; diff --git a/include/shlwapi.h b/include/shlwapi.h index 15615786c4a..aafbdd3870b 100644 --- a/include/shlwapi.h +++ b/include/shlwapi.h @@ -1166,8 +1166,8 @@ WINSHLWAPI BOOL WINAPI IsOS(DWORD); #define FDTF_RTLDATE 0x00000200 #define FDTF_NOAUTOREADINGORDER 0x00000400 -WINSHLWAPI int WINAPI SHFormatDateTimeA(const FILETIME UNALIGNED *filetime, DWORD *flags, LPSTR buffer, UINT size); -WINSHLWAPI int WINAPI SHFormatDateTimeW(const FILETIME UNALIGNED *filetime, DWORD *flags, LPWSTR buffer, UINT size); +WINSHLWAPI int WINAPI SHFormatDateTimeA(const FILETIME *filetime, DWORD *flags, LPSTR buffer, UINT size); +WINSHLWAPI int WINAPI SHFormatDateTimeW(const FILETIME *filetime, DWORD *flags, LPWSTR buffer, UINT size); typedef struct {

1 0

Alexandre Julliard : winebuild: Always use .balign for alignment.
by Alexandre Julliard Oct. 20, 2023

Oct. 20, 2023

Module: wine Branch: master Commit: 9a4e41c45d30c5850d6f42b3c2e3ce6c9b3d8910 URL: https://gitlab.winehq.org/wine/wine/-/commit/9a4e41c45d30c5850d6f42b3c2e3ce… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Oct 20 11:59:26 2023 +0200 winebuild: Always use .balign for alignment. It seems to be portable enough nowadays. --- tools/winebuild/build.h | 1 - tools/winebuild/import.c | 22 +++++++++++----------- tools/winebuild/relay.c | 2 +- tools/winebuild/res32.c | 4 ++-- tools/winebuild/spec16.c | 10 +++++----- tools/winebuild/spec32.c | 24 ++++++++++++------------ tools/winebuild/utils.c | 49 +----------------------------------------------- 7 files changed, 32 insertions(+), 80 deletions(-)

1 0