October 2023 - Wine-Commits

Alex Henrie : loader: Translate wine.desktop to Catalan.
by Alexandre Julliard Oct. 17, 2023

Oct. 17, 2023

Module: wine Branch: master Commit: 7a22152ba11052eb8e26283af640d48f390a0570 URL: https://gitlab.winehq.org/wine/wine/-/commit/7a22152ba11052eb8e26283af640d4… Author: Alex Henrie <alexhenrie24(a)gmail.com> Date: Mon Oct 16 22:36:30 2023 -0600 loader: Translate wine.desktop to Catalan. --- loader/wine.desktop | 1 + 1 file changed, 1 insertion(+) diff --git a/loader/wine.desktop b/loader/wine.desktop index c839946c3a8..ce61e8769fd 100644 --- a/loader/wine.desktop +++ b/loader/wine.desktop @@ -2,6 +2,7 @@ Type=Application Name=Wine Windows Program Loader Name[ar]=منظومة واين لتشغيل برامج وندوز +Name[ca]=Wine - Carregador de programes de Windows Name[cs]=Zavaděč programů pro Wine Name[de]=Wine Windows-Programmstarter Name[es]=Wine Cargador de programas de Windows

1 0

Alex Henrie : d3dx9_36: Use debugstr_fourcc instead of debugstr_an.
by Alexandre Julliard Oct. 17, 2023

Oct. 17, 2023

Module: wine Branch: master Commit: c7d9c4a8b6c21427fb0dd4d1a31b4dcba28d3cb6 URL: https://gitlab.winehq.org/wine/wine/-/commit/c7d9c4a8b6c21427fb0dd4d1a31b4d… Author: Alex Henrie <alexhenrie24(a)gmail.com> Date: Mon Oct 16 23:29:15 2023 -0600 d3dx9_36: Use debugstr_fourcc instead of debugstr_an. --- dlls/d3dx9_36/util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/d3dx9_36/util.c b/dlls/d3dx9_36/util.c index 39afe6740c0..419bd92884a 100644 --- a/dlls/d3dx9_36/util.c +++ b/dlls/d3dx9_36/util.c @@ -214,7 +214,7 @@ const struct pixel_format_desc *get_format_info(D3DFORMAT format) unsigned int i = 0; while(formats[i].format != format && formats[i].format != D3DFMT_UNKNOWN) i++; if (formats[i].format == D3DFMT_UNKNOWN) - FIXME("Unknown format %#x (as FOURCC %s).\n", format, debugstr_an((const char *)&format, 4)); + FIXME("Unknown format %s.\n", debugstr_fourcc(format)); return &formats[i]; }

1 0

Jacek Caban : dwrite: Avoid implicit casts between DWRITE_RENDERING_MODE and DWRITE_RENDERING_MODE1.
by Alexandre Julliard Oct. 17, 2023

Oct. 17, 2023

Module: wine Branch: master Commit: 75635053fc810ecd2eaa12a6cd6418d04b301118 URL: https://gitlab.winehq.org/wine/wine/-/commit/75635053fc810ecd2eaa12a6cd6418… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Tue Oct 17 14:16:36 2023 +0200 dwrite: Avoid implicit casts between DWRITE_RENDERING_MODE and DWRITE_RENDERING_MODE1. --- dlls/dwrite/font.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/dlls/dwrite/font.c b/dlls/dwrite/font.c index a73f8239587..59ed2a99a5d 100644 --- a/dlls/dwrite/font.c +++ b/dlls/dwrite/font.c @@ -193,7 +193,7 @@ static unsigned int get_glyph_bitmap_pitch(DWRITE_RENDERING_MODE1 rendering_mode return rendering_mode == DWRITE_RENDERING_MODE1_ALIASED ? ((width + 31) >> 5) << 2 : (width + 3) / 4 * 4; } -static HRESULT dwrite_fontface_get_glyph_bitmap(struct dwrite_fontface *fontface, DWRITE_RENDERING_MODE rendering_mode, +static HRESULT dwrite_fontface_get_glyph_bitmap(struct dwrite_fontface *fontface, DWRITE_RENDERING_MODE1 rendering_mode, unsigned int *is_1bpp, struct dwrite_glyphbitmap *bitmap) { struct cache_key key = { .size = bitmap->emsize, .glyph = bitmap->glyph, .mode = DWRITE_MEASURING_MODE_NATURAL }; @@ -1798,7 +1798,7 @@ static HRESULT WINAPI dwritefontface3_GetRecommendedRenderingMode(IDWriteFontFac IDWriteRenderingParams *params, DWRITE_RENDERING_MODE1 *rendering_mode, DWRITE_GRID_FIT_MODE *gridfit_mode) { struct dwrite_fontface *fontface = impl_from_IDWriteFontFace5(iface); - unsigned int flags; + unsigned int flags, mode; FLOAT emthreshold; TRACE("%p, %.8e, %.8e, %.8e, %p, %d, %d, %d, %p, %p, %p.\n", iface, emSize, dpiX, dpiY, m, is_sideways, threshold, @@ -1821,11 +1821,12 @@ static HRESULT WINAPI dwritefontface3_GetRecommendedRenderingMode(IDWriteFontFac hr = IDWriteRenderingParams_QueryInterface(params, &IID_IDWriteRenderingParams3, (void**)&params3); if (hr == S_OK) { *rendering_mode = IDWriteRenderingParams3_GetRenderingMode1(params3); - *gridfit_mode = IDWriteRenderingParams3_GetGridFitMode(params3); + mode = IDWriteRenderingParams3_GetGridFitMode(params3); IDWriteRenderingParams3_Release(params3); } else - *rendering_mode = IDWriteRenderingParams_GetRenderingMode(params); + mode = IDWriteRenderingParams_GetRenderingMode(params); + *rendering_mode = mode; } emthreshold = threshold == DWRITE_OUTLINE_THRESHOLD_ANTIALIASED ? RECOMMENDED_OUTLINE_AA_THRESHOLD : RECOMMENDED_OUTLINE_A_THRESHOLD; @@ -1834,9 +1835,10 @@ static HRESULT WINAPI dwritefontface3_GetRecommendedRenderingMode(IDWriteFontFac if (*rendering_mode == DWRITE_RENDERING_MODE1_DEFAULT) { if (emSize >= emthreshold) - *rendering_mode = DWRITE_RENDERING_MODE1_OUTLINE; + mode = DWRITE_RENDERING_MODE1_OUTLINE; else - *rendering_mode = fontface_renderingmode_from_measuringmode(measuring_mode, emSize, flags); + mode = fontface_renderingmode_from_measuringmode(measuring_mode, emSize, flags); + *rendering_mode = mode; } if (*gridfit_mode == DWRITE_GRID_FIT_MODE_DEFAULT) {

1 0

Alex Henrie : d3d10: Use debugstr_fourcc instead of debugstr_an.
by Alexandre Julliard Oct. 17, 2023

Oct. 17, 2023

Module: wine Branch: master Commit: beb1805ca09ffa1daac5833a53b93f3cbd473588 URL: https://gitlab.winehq.org/wine/wine/-/commit/beb1805ca09ffa1daac5833a53b93f… Author: Alex Henrie <alexhenrie24(a)gmail.com> Date: Mon Oct 16 23:27:31 2023 -0600 d3d10: Use debugstr_fourcc instead of debugstr_an. --- dlls/d3d10/effect.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/dlls/d3d10/effect.c b/dlls/d3d10/effect.c index cc08f1ac1f9..6e2b67bb700 100644 --- a/dlls/d3d10/effect.c +++ b/dlls/d3d10/effect.c @@ -2853,7 +2853,7 @@ static HRESULT fxlvm_chunk_handler(const struct vkd3d_shader_dxbc_section_desc * size_t data_size = section->data.size; uint32_t tag = section->tag; - TRACE("Chunk tag: %s, size: %Iu.\n", debugstr_an((const char *)&tag, 4), data_size); + TRACE("Chunk tag: %s, size: %Iu.\n", debugstr_fourcc(tag), data_size); switch (tag) { @@ -2867,7 +2867,7 @@ static HRESULT fxlvm_chunk_handler(const struct vkd3d_shader_dxbc_section_desc * return parse_fx10_ctab(ctx, data, data_size); default: - FIXME("Unhandled chunk %s.\n", debugstr_an((const char *)&tag, 4)); + FIXME("Unhandled chunk %s.\n", debugstr_fourcc(tag)); return S_OK; } } @@ -4325,12 +4325,12 @@ HRESULT d3d10_effect_parse(struct d3d10_effect *effect, const void *data, SIZE_T section = &dxbc_desc.sections[i]; TRACE("Section %u: tag %s, data {%p, %#Ix}.\n", - i, debugstr_an((const char *)&section->tag, 4), + i, debugstr_fourcc(section->tag), section->data.code, section->data.size); if (section->tag != TAG_FX10) { - FIXME("Unhandled chunk %s.\n", debugstr_an((const char *)&section->tag, 4)); + FIXME("Unhandled chunk %s.\n", debugstr_fourcc(section->tag)); continue; }

1 0

Alex Henrie : iccvid: Use debugstr_fourcc instead of debugstr_an.
by Alexandre Julliard Oct. 17, 2023

Oct. 17, 2023

Module: wine Branch: master Commit: 53383beb3773c37cd47cc79d6bb3178e32e834af URL: https://gitlab.winehq.org/wine/wine/-/commit/53383beb3773c37cd47cc79d6bb317… Author: Alex Henrie <alexhenrie24(a)gmail.com> Date: Mon Oct 16 23:30:54 2023 -0600 iccvid: Use debugstr_fourcc instead of debugstr_an. --- dlls/iccvid/iccvid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/iccvid/iccvid.c b/dlls/iccvid/iccvid.c index 4dc418c590b..cffc75be58e 100644 --- a/dlls/iccvid/iccvid.c +++ b/dlls/iccvid/iccvid.c @@ -750,7 +750,7 @@ static void ICCVID_dump_BITMAPINFO(const BITMAPINFO * bmi) bmi->bmiHeader.biBitCount, bmi->bmiHeader.biHeight, bmi->bmiHeader.biWidth, - debugstr_an( (const char *)&bmi->bmiHeader.biCompression, 4 ) ); + debugstr_fourcc(bmi->bmiHeader.biCompression)); } static inline int ICCVID_CheckMask(RGBQUAD bmiColors[3], COLORREF redMask, COLORREF blueMask, COLORREF greenMask)

1 0

Alex Henrie : evr: Use debugstr_fourcc instead of debugstr_an.
by Alexandre Julliard Oct. 17, 2023

Oct. 17, 2023

Module: wine Branch: master Commit: 4fef7086602c5eec78104857da6029b133f1c73e URL: https://gitlab.winehq.org/wine/wine/-/commit/4fef7086602c5eec78104857da6029… Author: Alex Henrie <alexhenrie24(a)gmail.com> Date: Mon Oct 16 23:30:20 2023 -0600 evr: Use debugstr_fourcc instead of debugstr_an. --- dlls/evr/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/evr/main.c b/dlls/evr/main.c index 702e4640831..5c2049a61da 100644 --- a/dlls/evr/main.c +++ b/dlls/evr/main.c @@ -213,7 +213,7 @@ HRESULT WINAPI MFCreateVideoMixerAndPresenter(IUnknown *mixer_outer, IUnknown *p */ BOOL WINAPI MFIsFormatYUV(DWORD format) { - TRACE("%s.\n", debugstr_an((char *)&format, 4)); + TRACE("%s.\n", debugstr_fourcc(format)); switch (format) {

1 0

Eric Pouech : wbemprox: Use correct string id.
by Alexandre Julliard Oct. 17, 2023

Oct. 17, 2023

Module: wine Branch: master Commit: 828304dab301a733c7b1a6f53c8bd0681fbae6c4 URL: https://gitlab.winehq.org/wine/wine/-/commit/828304dab301a733c7b1a6f53c8bd0… Author: Eric Pouech <epouech(a)codeweavers.com> Date: Tue Oct 17 13:59:35 2023 +0200 wbemprox: Use correct string id. Don't use hard coded string indexes as one of the expected string can be absent, hence decreasing its index; nothing ensures that the strings are placed in the order of the fields in the smbios structure. So use, smbios structures' indexes instead. Wbemprox was also expecting one string too much. Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> --- dlls/wbemprox/builtin.c | 89 ++++++++++++------------------------------------- 1 file changed, 21 insertions(+), 68 deletions(-) diff --git a/dlls/wbemprox/builtin.c b/dlls/wbemprox/builtin.c index 038ce99539f..fe496bdde41 100644 --- a/dlls/wbemprox/builtin.c +++ b/dlls/wbemprox/builtin.c @@ -77,7 +77,7 @@ static const struct column col_bios[] = { L"Manufacturer", CIM_STRING|COL_FLAG_DYNAMIC }, { L"Name", CIM_STRING }, { L"ReleaseDate", CIM_DATETIME|COL_FLAG_DYNAMIC }, - { L"SerialNumber", CIM_STRING|COL_FLAG_DYNAMIC }, + { L"SerialNumber", CIM_STRING }, { L"SMBIOSBIOSVersion", CIM_STRING|COL_FLAG_DYNAMIC }, { L"SMBIOSMajorVersion", CIM_UINT16 }, { L"SMBIOSMinorVersion", CIM_UINT16 }, @@ -1245,7 +1245,7 @@ static const struct smbios_header *find_smbios_entry( enum smbios_type type, con return hdr; } -static WCHAR *get_smbios_string( BYTE id, const char *buf, UINT offset, UINT buflen ) +static WCHAR *get_smbios_string_by_id( BYTE id, const char *buf, UINT offset, UINT buflen ) { const char *ptr = buf + offset; UINT i = 0; @@ -1259,43 +1259,43 @@ static WCHAR *get_smbios_string( BYTE id, const char *buf, UINT offset, UINT buf return NULL; } -static WCHAR *get_baseboard_string( BYTE id, const char *buf, UINT len ) +static WCHAR *get_smbios_string( enum smbios_type type, size_t field_offset, const char *buf, UINT len ) { const struct smbios_header *hdr; - const struct smbios_baseboard *baseboard; UINT offset; - if (!(hdr = find_smbios_entry( SMBIOS_TYPE_BASEBOARD, buf, len ))) return NULL; + if (!(hdr = find_smbios_entry( type, buf, len ))) return NULL; - baseboard = (const struct smbios_baseboard *)hdr; - offset = (const char *)baseboard - buf + baseboard->hdr.length; - return get_smbios_string( id, buf, offset, len ); + if (field_offset + sizeof(BYTE) > hdr->length) return NULL; + + offset = (const char *)hdr - buf + hdr->length; + return get_smbios_string_by_id( ((const BYTE *)hdr)[field_offset], buf, offset, len ); } static WCHAR *get_baseboard_manufacturer( const char *buf, UINT len ) { - WCHAR *ret = get_baseboard_string( 1, buf, len ); + WCHAR *ret = get_smbios_string( SMBIOS_TYPE_BASEBOARD, offsetof(struct smbios_baseboard, vendor), buf, len ); if (!ret) return wcsdup( L"Intel Corporation" ); return ret; } static WCHAR *get_baseboard_product( const char *buf, UINT len ) { - WCHAR *ret = get_baseboard_string( 2, buf, len ); + WCHAR *ret = get_smbios_string( SMBIOS_TYPE_BASEBOARD, offsetof(struct smbios_baseboard, product), buf, len ); if (!ret) return wcsdup( L"Base Board" ); return ret; } static WCHAR *get_baseboard_serialnumber( const char *buf, UINT len ) { - WCHAR *ret = get_baseboard_string( 4, buf, len ); + WCHAR *ret = get_smbios_string( SMBIOS_TYPE_BASEBOARD, offsetof(struct smbios_baseboard, serial), buf, len ); if (!ret) return wcsdup( L"None" ); return ret; } static WCHAR *get_baseboard_version( const char *buf, UINT len ) { - WCHAR *ret = get_baseboard_string( 3, buf, len ); + WCHAR *ret = get_smbios_string( SMBIOS_TYPE_BASEBOARD, offsetof(struct smbios_baseboard, version), buf, len ); if (!ret) return wcsdup( L"1.0" ); return ret; } @@ -1344,23 +1344,9 @@ static UINT16 get_bios_smbiosminorversion( const char *buf, UINT len ) if (len < sizeof(*prologue)) return 0; return prologue->minor_version; } - -static WCHAR *get_bios_string( BYTE id, const char *buf, UINT len ) -{ - const struct smbios_header *hdr; - const struct smbios_bios *bios; - UINT offset; - - if (!(hdr = find_smbios_entry( SMBIOS_TYPE_BIOS, buf, len ))) return NULL; - - bios = (const struct smbios_bios *)hdr; - offset = (const char *)bios - buf + bios->hdr.length; - return get_smbios_string( id, buf, offset, len ); -} - static WCHAR *get_bios_manufacturer( const char *buf, UINT len ) { - WCHAR *ret = get_bios_string( 1, buf, len ); + WCHAR *ret = get_smbios_string( SMBIOS_TYPE_BIOS, offsetof(struct smbios_bios, vendor), buf, len ); if (!ret) return wcsdup( L"The Wine Project" ); return ret; } @@ -1398,22 +1384,15 @@ static WCHAR *convert_bios_date( const WCHAR *str ) static WCHAR *get_bios_releasedate( const char *buf, UINT len ) { - WCHAR *ret, *date = get_bios_string( 3, buf, len ); + WCHAR *ret, *date = get_smbios_string( SMBIOS_TYPE_BIOS, offsetof(struct smbios_bios, date), buf, len ); if (!date || !(ret = convert_bios_date( date ))) ret = wcsdup( L"20120608000000.000000+000" ); free( date ); return ret; } -static WCHAR *get_bios_serialnumber( const char *buf, UINT len ) -{ - WCHAR *ret = get_bios_string( 4, buf, len ); - if (!ret) return wcsdup( L"0" ); - return ret; -} - static WCHAR *get_bios_smbiosbiosversion( const char *buf, UINT len ) { - WCHAR *ret = get_bios_string( 2, buf, len ); + WCHAR *ret = get_smbios_string( SMBIOS_TYPE_BIOS, offsetof(struct smbios_bios, version), buf, len ); if (!ret) return wcsdup( L"Wine" ); return ret; } @@ -1488,7 +1467,7 @@ static enum fill_status fill_bios( struct table *table, const struct expr *cond rec->manufacturer = get_bios_manufacturer( buf, len ); rec->name = L"Default System BIOS"; rec->releasedate = get_bios_releasedate( buf, len ); - rec->serialnumber = get_bios_serialnumber( buf, len ); + rec->serialnumber = L"Serial number"; rec->smbiosbiosversion = get_bios_smbiosbiosversion( buf, len ); rec->smbiosmajorversion = get_bios_smbiosmajorversion( buf, len ); rec->smbiosminorversion = get_bios_smbiosminorversion( buf, len ); @@ -1669,29 +1648,16 @@ static WCHAR *get_username(void) return ret; } -static WCHAR *get_compsysproduct_string( BYTE id, const char *buf, UINT len ) -{ - const struct smbios_header *hdr; - const struct smbios_system *system; - UINT offset; - - if (!(hdr = find_smbios_entry( SMBIOS_TYPE_SYSTEM, buf, len ))) return NULL; - - system = (const struct smbios_system *)hdr; - offset = (const char *)system - buf + system->hdr.length; - return get_smbios_string( id, buf, offset, len ); -} - static WCHAR *get_compsysproduct_name( const char *buf, UINT len ) { - WCHAR *ret = get_compsysproduct_string( 2, buf, len ); + WCHAR *ret = get_smbios_string( SMBIOS_TYPE_SYSTEM, offsetof(struct smbios_system, product), buf, len ); if (!ret) return wcsdup( L"Wine" ); return ret; } static WCHAR *get_compsysproduct_vendor( const char *buf, UINT len ) { - WCHAR *ret = get_compsysproduct_string( 1, buf, len ); + WCHAR *ret = get_smbios_string( SMBIOS_TYPE_SYSTEM, offsetof(struct smbios_system, vendor), buf, len ); if (!ret) return wcsdup( L"The Wine Project" ); return ret; } @@ -1733,7 +1699,7 @@ static enum fill_status fill_compsys( struct table *table, const struct expr *co static WCHAR *get_compsysproduct_identifyingnumber( const char *buf, UINT len ) { - WCHAR *ret = get_compsysproduct_string( 4, buf, len ); + WCHAR *ret = get_smbios_string( SMBIOS_TYPE_SYSTEM, offsetof(struct smbios_system, serial), buf, len ); if (!ret) return wcsdup( L"0" ); return ret; } @@ -1761,7 +1727,7 @@ done: static WCHAR *get_compsysproduct_version( const char *buf, UINT len ) { - WCHAR *ret = get_compsysproduct_string( 3, buf, len ); + WCHAR *ret = get_smbios_string( SMBIOS_TYPE_SYSTEM, offsetof(struct smbios_system, version), buf, len ); if (!ret) return wcsdup( L"1.0" ); return ret; } @@ -4054,22 +4020,9 @@ static enum fill_status fill_sid( struct table *table, const struct expr *cond ) return FILL_STATUS_FILTERED; } -static WCHAR *get_systemenclosure_string( BYTE id, const char *buf, UINT len ) -{ - const struct smbios_header *hdr; - const struct smbios_chassis *chassis; - UINT offset; - - if (!(hdr = find_smbios_entry( SMBIOS_TYPE_CHASSIS, buf, len ))) return NULL; - - chassis = (const struct smbios_chassis *)hdr; - offset = (const char *)chassis - buf + chassis->hdr.length; - return get_smbios_string( id, buf, offset, len ); -} - static WCHAR *get_systemenclosure_manufacturer( const char *buf, UINT len ) { - WCHAR *ret = get_systemenclosure_string( 1, buf, len ); + WCHAR *ret = get_smbios_string( SMBIOS_TYPE_CHASSIS, offsetof(struct smbios_chassis, vendor), buf, len ); if (!ret) return wcsdup( L"Wine" ); return ret; }

1 0

Alex Henrie : dwrite: Use the debugstr_fourcc function instead of reimplementing it.
by Alexandre Julliard Oct. 17, 2023

Oct. 17, 2023

Module: wine Branch: master Commit: a23d21a902c5d870e12b1f2d173ad6b7af8a3bce URL: https://gitlab.winehq.org/wine/wine/-/commit/a23d21a902c5d870e12b1f2d173ad6… Author: Alex Henrie <alexhenrie24(a)gmail.com> Date: Mon Oct 16 23:29:57 2023 -0600 dwrite: Use the debugstr_fourcc function instead of reimplementing it. --- dlls/dwrite/analyzer.c | 6 +++--- dlls/dwrite/dwrite_private.h | 5 ----- dlls/dwrite/font.c | 4 ++-- dlls/dwrite/layout.c | 2 +- dlls/dwrite/opentype.c | 2 +- dlls/dwrite/shape.c | 4 ++-- 6 files changed, 9 insertions(+), 14 deletions(-) diff --git a/dlls/dwrite/analyzer.c b/dlls/dwrite/analyzer.c index 3c8e25d8efe..7e64131d4de 100644 --- a/dlls/dwrite/analyzer.c +++ b/dlls/dwrite/analyzer.c @@ -208,7 +208,7 @@ static const struct dwritescript_properties dwritescripts_properties[Script_Last const char *debugstr_sa_script(UINT16 script) { - return script < Script_LastId ? debugstr_tag(dwritescripts_properties[script].props.isoScriptCode) : "undefined"; + return script < Script_LastId ? debugstr_fourcc(dwritescripts_properties[script].props.isoScriptCode) : "undefined"; } static const struct fallback_description @@ -1508,7 +1508,7 @@ static void analyzer_dump_user_features(DWRITE_TYPOGRAPHIC_FEATURES const **feat for (i = 0, start = 0; i < feature_ranges; start += feature_range_lengths[i++]) { TRACE("feature range [%u,%u)\n", start, start + feature_range_lengths[i]); for (j = 0; j < features[i]->featureCount; j++) - TRACE("feature %s, parameter %u\n", debugstr_tag(features[i]->features[j].nameTag), + TRACE("feature %s, parameter %u\n", debugstr_fourcc(features[i]->features[j].nameTag), features[i]->features[j].parameter); } } @@ -2188,7 +2188,7 @@ static HRESULT WINAPI dwritetextanalyzer2_CheckTypographicFeature(IDWriteTextAna struct dwrite_fontface *font_obj; HRESULT hr; - TRACE("%p, %p, %u, %s, %s, %u, %p, %p.\n", iface, fontface, sa.script, debugstr_w(locale), debugstr_tag(feature), + TRACE("%p, %p, %u, %s, %s, %u, %p, %p.\n", iface, fontface, sa.script, debugstr_w(locale), debugstr_fourcc(feature), glyph_count, glyphs, feature_applies); if (sa.script > Script_LastId) diff --git a/dlls/dwrite/dwrite_private.h b/dlls/dwrite/dwrite_private.h index 7ad8e602cb0..7a819b03ec3 100644 --- a/dlls/dwrite/dwrite_private.h +++ b/dlls/dwrite/dwrite_private.h @@ -108,11 +108,6 @@ static inline BOOL dwrite_array_reserve(void **elements, size_t *capacity, size_ return TRUE; } -static inline const char *debugstr_tag(DWORD tag) -{ - return debugstr_an((char *)&tag, 4); -} - const char *debugstr_sa_script(UINT16) DECLSPEC_HIDDEN; static inline unsigned short get_table_entry_16(const unsigned short *table, WCHAR ch) diff --git a/dlls/dwrite/font.c b/dlls/dwrite/font.c index 59ed2a99a5d..6a3e49dcc58 100644 --- a/dlls/dwrite/font.c +++ b/dlls/dwrite/font.c @@ -674,7 +674,7 @@ const void* get_fontface_table(IDWriteFontFace5 *fontface, UINT32 tag, struct dw hr = IDWriteFontFace5_TryGetFontTable(fontface, tag, (const void **)&table->data, &table->size, &table->context, &table->exists); if (FAILED(hr) || !table->exists) { - TRACE("Font does not have %s table\n", debugstr_tag(tag)); + TRACE("Font does not have %s table\n", debugstr_fourcc(tag)); return NULL; } @@ -1050,7 +1050,7 @@ static HRESULT WINAPI dwritefontface_TryGetFontTable(IDWriteFontFace5 *iface, UI struct dwrite_fontface *fontface = impl_from_IDWriteFontFace5(iface); struct file_stream_desc stream_desc; - TRACE("%p, %s, %p, %p, %p, %p.\n", iface, debugstr_tag(table_tag), table_data, table_size, context, exists); + TRACE("%p, %s, %p, %p, %p, %p.\n", iface, debugstr_fourcc(table_tag), table_data, table_size, context, exists); stream_desc.stream = fontface->stream; stream_desc.face_type = fontface->type; diff --git a/dlls/dwrite/layout.c b/dlls/dwrite/layout.c index 0d08ba99de6..157fc886a46 100644 --- a/dlls/dwrite/layout.c +++ b/dlls/dwrite/layout.c @@ -5413,7 +5413,7 @@ static HRESULT WINAPI dwritetypography_AddFontFeature(IDWriteTypography *iface, { struct dwrite_typography *typography = impl_from_IDWriteTypography(iface); - TRACE("%p, %s, %u.\n", iface, debugstr_tag(feature.nameTag), feature.parameter); + TRACE("%p, %s, %u.\n", iface, debugstr_fourcc(feature.nameTag), feature.parameter); if (!dwrite_array_reserve((void **)&typography->features, &typography->capacity, typography->count + 1, sizeof(*typography->features))) diff --git a/dlls/dwrite/opentype.c b/dlls/dwrite/opentype.c index dfb410e2423..b32bfd8c5c3 100644 --- a/dlls/dwrite/opentype.c +++ b/dlls/dwrite/opentype.c @@ -3140,7 +3140,7 @@ static unsigned int opentype_get_sbix_formats(IDWriteFontFace5 *fontface) ret |= DWRITE_GLYPH_IMAGE_FORMATS_TIFF; break; default: - FIXME("unexpected bitmap format %s\n", debugstr_tag(GET_BE_DWORD(glyph_data->graphic_type))); + FIXME("unexpected bitmap format %s\n", debugstr_fourcc(GET_BE_DWORD(glyph_data->graphic_type))); } } } diff --git a/dlls/dwrite/shape.c b/dlls/dwrite/shape.c index 33f7fb78953..6dfd1b15176 100644 --- a/dlls/dwrite/shape.c +++ b/dlls/dwrite/shape.c @@ -272,8 +272,8 @@ HRESULT shape_get_positions(struct scriptshaping_context *context, const unsigne if ((language = shape_select_language(cache, MS_GPOS_TAG, script_index, language, &language_index))) { - TRACE("script %s, language %s.\n", debugstr_tag(script), language != ~0u ? - debugstr_tag(language) : "deflangsys"); + TRACE("script %s, language %s.\n", debugstr_fourcc(script), language != ~0u ? + debugstr_fourcc(language) : "deflangsys"); opentype_layout_apply_gpos_features(context, script_index, language_index, &features); } }

1 0

Gabriel Ivăncescu : jscript: Fix Array.reduce when last element doesn't exist.
by Alexandre Julliard Oct. 17, 2023

Oct. 17, 2023

Module: wine Branch: master Commit: ed674d63a4ec07e07a36e0bead84d7ac9bf6c9a7 URL: https://gitlab.winehq.org/wine/wine/-/commit/ed674d63a4ec07e07a36e0bead84d7… Author: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> Date: Tue Oct 17 16:18:54 2023 +0300 jscript: Fix Array.reduce when last element doesn't exist. Signed-off-by: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> --- dlls/jscript/array.c | 4 +++- dlls/mshtml/tests/es5.js | 3 +++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/dlls/jscript/array.c b/dlls/jscript/array.c index c673b82fed2..36f45120055 100644 --- a/dlls/jscript/array.c +++ b/dlls/jscript/array.c @@ -1422,8 +1422,10 @@ static HRESULT Array_reduce(script_ctx_t *ctx, jsval_t vthis, WORD flags, unsign for(k = 0; k < length; k++) { hres = jsdisp_get_idx(jsthis, k, &callback_args[1]); - if(hres == DISP_E_UNKNOWNNAME) + if(hres == DISP_E_UNKNOWNNAME) { + hres = S_OK; continue; + } if(FAILED(hres)) break; diff --git a/dlls/mshtml/tests/es5.js b/dlls/mshtml/tests/es5.js index fbcb1b42f3e..b6ce7be3c54 100644 --- a/dlls/mshtml/tests/es5.js +++ b/dlls/mshtml/tests/es5.js @@ -1336,6 +1336,9 @@ sync_test("reduce", function() { r = [1,2,3].reduce(function(a, value) { return a + value; }, "str"); ok(r === "str123", "reduce() returned " + r); + r = [1,2,].reduce(function(a, value) { return a + value; }, "str"); + ok(r === "str12", "reduce() returned " + r); + array = [1,2,3]; r = array.reduce(function(a, value, index, src) { ok(src === array, "src != array");

1 0

Gabriel Ivăncescu : jscript: Fix Array.map when last element doesn't exist.
by Alexandre Julliard Oct. 17, 2023

Oct. 17, 2023

Module: wine Branch: master Commit: 40b36d4208509d73c9cc3c91e6ba1b1104c524aa URL: https://gitlab.winehq.org/wine/wine/-/commit/40b36d4208509d73c9cc3c91e6ba1b… Author: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> Date: Tue Oct 17 16:18:53 2023 +0300 jscript: Fix Array.map when last element doesn't exist. Signed-off-by: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> --- dlls/jscript/array.c | 6 ++++-- dlls/mshtml/tests/es5.js | 7 +++++++ 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/dlls/jscript/array.c b/dlls/jscript/array.c index 48f665da576..c673b82fed2 100644 --- a/dlls/jscript/array.c +++ b/dlls/jscript/array.c @@ -1354,14 +1354,16 @@ static HRESULT Array_map(script_ctx_t *ctx, jsval_t vthis, WORD flags, unsigned if(argc > 1) context_this = argv[1]; - hres = create_array(ctx, length, &array); + hres = create_array(ctx, 0, &array); if(FAILED(hres)) goto done; for(k = 0; k < length; k++) { hres = jsdisp_get_idx(jsthis, k, &callback_args[0]); - if(hres == DISP_E_UNKNOWNNAME) + if(hres == DISP_E_UNKNOWNNAME) { + hres = S_OK; continue; + } if(FAILED(hres)) break; diff --git a/dlls/mshtml/tests/es5.js b/dlls/mshtml/tests/es5.js index 7e2f66daabf..fbcb1b42f3e 100644 --- a/dlls/mshtml/tests/es5.js +++ b/dlls/mshtml/tests/es5.js @@ -431,6 +431,13 @@ sync_test("array_map", function() { [1,2].map(function() { ok(this.valueOf() === 137, "this.valueOf() = " + this.valueOf()); }, 137); + + r = [1,,2,].map(function(x) { return "" + x; }); + ok(r.length === 3, "[1,,2,].map length = " + r.length); + ok(r[0] === "1", "[1,,2,].map[0] = " + r[0]); + ok(r[2] === "2", "[1,,2,].map[2] = " + r[2]); + ok(!("1" in r), "[1,,2,].map[1] exists"); + ok(!("3" in r), "[1,,2,].map[3] exists"); }); sync_test("array_sort", function() {

1 0