November 2023 - Wine-Commits

Alex Henrie : d3dx9_36/tests: Use CRT allocation functions.
by Alexandre Julliard Nov. 28, 2023

Nov. 28, 2023

Module: wine Branch: master Commit: bc13bda5ee4edaafa7ba9472d41acbad50c42112 URL: https://gitlab.winehq.org/wine/wine/-/commit/bc13bda5ee4edaafa7ba9472d41acb… Author: Alex Henrie <alexhenrie24(a)gmail.com> Date: Mon Nov 27 20:12:18 2023 -0700 d3dx9_36/tests: Use CRT allocation functions. --- dlls/d3dx9_36/tests/asm.c | 12 ++++++------ dlls/d3dx9_36/tests/effect.c | 38 ++++++++++++++++---------------------- dlls/d3dx9_36/tests/surface.c | 4 ++-- dlls/d3dx9_36/tests/xfile.c | 4 ++-- 4 files changed, 26 insertions(+), 32 deletions(-)

1 0

Alex Henrie : comdlg32/tests: Use CRT allocation functions.
by Alexandre Julliard Nov. 28, 2023

Nov. 28, 2023

Module: wine Branch: master Commit: 14158bb57fac6194e33a284aa094c9c947e1ada4 URL: https://gitlab.winehq.org/wine/wine/-/commit/14158bb57fac6194e33a284aa094c9… Author: Alex Henrie <alexhenrie24(a)gmail.com> Date: Mon Nov 27 20:17:32 2023 -0700 comdlg32/tests: Use CRT allocation functions. --- dlls/comdlg32/tests/fontdlg.c | 4 ++-- dlls/comdlg32/tests/itemdlg.c | 4 ++-- dlls/comdlg32/tests/printdlg.c | 21 ++++++++++----------- 3 files changed, 14 insertions(+), 15 deletions(-) diff --git a/dlls/comdlg32/tests/fontdlg.c b/dlls/comdlg32/tests/fontdlg.c index a96e6dc1590..cbcfd34a21f 100644 --- a/dlls/comdlg32/tests/fontdlg.c +++ b/dlls/comdlg32/tests/fontdlg.c @@ -57,14 +57,14 @@ static HDC get_printer_ic(void) if (info_size == 0) return NULL; - info = HeapAlloc(GetProcessHeap(), 0, info_size); + info = malloc(info_size); ret = EnumPrintersA(PRINTER_ENUM_LOCAL, NULL, 2, (LPBYTE)info, info_size, &info_size, &num_printers); if (ret) result = CreateICA(info->pDriverName, info->pPrinterName, NULL, NULL); - HeapFree(GetProcessHeap(), 0, info); + free(info); return result; } diff --git a/dlls/comdlg32/tests/itemdlg.c b/dlls/comdlg32/tests/itemdlg.c index 15c898adc50..573a267a37e 100644 --- a/dlls/comdlg32/tests/itemdlg.c +++ b/dlls/comdlg32/tests/itemdlg.c @@ -150,7 +150,7 @@ static ULONG WINAPI IFileDialogEvents_fnRelease(IFileDialogEvents *iface) LONG ref = InterlockedDecrement(&This->ref); if(!ref) - HeapFree(GetProcessHeap(), 0, This); + free(This); return ref; } @@ -325,7 +325,7 @@ static IFileDialogEvents *IFileDialogEvents_Constructor(void) { IFileDialogEventsImpl *This; - This = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(IFileDialogEventsImpl)); + This = calloc(1, sizeof(IFileDialogEventsImpl)); This->IFileDialogEvents_iface.lpVtbl = &vt_IFileDialogEvents; This->ref = 1; diff --git a/dlls/comdlg32/tests/printdlg.c b/dlls/comdlg32/tests/printdlg.c index ad8ddf0a7f7..7fd4567ba9e 100644 --- a/dlls/comdlg32/tests/printdlg.c +++ b/dlls/comdlg32/tests/printdlg.c @@ -59,7 +59,7 @@ static void test_PageSetupDlgA(void) LPPAGESETUPDLGA pDlg; DWORD res; - pDlg = HeapAlloc(GetProcessHeap(), 0, (sizeof(PAGESETUPDLGA)) * 2); + pDlg = malloc((sizeof(PAGESETUPDLGA)) * 2); if (!pDlg) return; SetLastError(0xdeadbeef); @@ -97,7 +97,7 @@ static void test_PageSetupDlgA(void) if (!res && (CommDlgExtendedError() == PDERR_NODEFAULTPRN)) { skip("No printer configured.\n"); - HeapFree(GetProcessHeap(), 0, pDlg); + free(pDlg); return; } @@ -108,8 +108,7 @@ static void test_PageSetupDlgA(void) GlobalFree(pDlg->hDevMode); GlobalFree(pDlg->hDevNames); - HeapFree(GetProcessHeap(), 0, pDlg); - + free(pDlg); } /* ########################### */ @@ -138,7 +137,7 @@ static void test_PrintDlgA(void) LPSTR ptr; DEVMODEA *dm; - pDlg = HeapAlloc(GetProcessHeap(), 0, (sizeof(PRINTDLGA)) * 2); + pDlg = malloc((sizeof(PRINTDLGA)) * 2); if (!pDlg) return; @@ -178,7 +177,7 @@ static void test_PrintDlgA(void) if (!res && (CommDlgExtendedError() == PDERR_NODEFAULTPRN)) { skip("No printer configured.\n"); - HeapFree(GetProcessHeap(), 0, pDlg); + free(pDlg); return; } @@ -269,7 +268,7 @@ static void test_PrintDlgA(void) GlobalFree(pDlg->hDevNames); } - HeapFree(GetProcessHeap(), 0, pDlg); + free(pDlg); } /* ########################### */ @@ -390,7 +389,7 @@ static void test_PrintDlgExW(void) res, GetLastError(), CommDlgExtendedError() ); } - pDlg = HeapAlloc(GetProcessHeap(), 0, (sizeof(PRINTDLGEXW)) + 8); + pDlg = malloc(sizeof(PRINTDLGEXW) + 8); if (!pDlg) return; /* lStructSize must be exact */ @@ -471,7 +470,7 @@ static void test_PrintDlgExW(void) if (res == E_FAIL) { skip("No printer configured.\n"); - HeapFree(GetProcessHeap(), 0, pDlg); + free(pDlg); return; } @@ -533,7 +532,7 @@ static void test_PrintDlgExW(void) if (!winetest_interactive) { skip("interactive PrintDlgEx tests (set WINETEST_INTERACTIVE=1)\n"); - HeapFree(GetProcessHeap(), 0, pDlg); + free(pDlg); return; } @@ -552,7 +551,7 @@ static void test_PrintDlgExW(void) GlobalFree(pDlg->hDevNames); DeleteDC(pDlg->hDC); - HeapFree(GetProcessHeap(), 0, pDlg); + free(pDlg); } static BOOL abort_proc_called = FALSE;

1 0

Jactry Zeng : ntdll: Initialize locale from Mac language identifiers with script name.
by Alexandre Julliard Nov. 28, 2023

Nov. 28, 2023

Module: wine Branch: master Commit: 730bdf6c5c0d35eabd2563cc65e3e4208e5a306f URL: https://gitlab.winehq.org/wine/wine/-/commit/730bdf6c5c0d35eabd2563cc65e3e4… Author: Jactry Zeng <jzeng(a)codeweavers.com> Date: Tue Nov 28 09:33:15 2023 +0100 ntdll: Initialize locale from Mac language identifiers with script name. --- dlls/ntdll/unix/env.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/dlls/ntdll/unix/env.c b/dlls/ntdll/unix/env.c index 6b249917cfe..1110acfd0fd 100644 --- a/dlls/ntdll/unix/env.c +++ b/dlls/ntdll/unix/env.c @@ -833,6 +833,7 @@ static void init_locale(void) { CFStringRef lang = CFDictionaryGetValue( components, kCFLocaleLanguageCode ); CFStringRef country = CFDictionaryGetValue( components, kCFLocaleCountryCode ); + CFStringRef script = CFDictionaryGetValue( components, kCFLocaleScriptCode ); CFLocaleRef mac_user_locale = NULL; CFStringRef locale_string; @@ -841,7 +842,11 @@ static void init_locale(void) mac_user_locale = CFLocaleCopyCurrent(); country = CFLocaleGetValue( mac_user_locale, kCFLocaleCountryCode ); } - if (country) + if (country && script) + locale_string = CFStringCreateWithFormat( NULL, NULL, CFSTR("%@-%@-%@"), lang, script, country ); + else if (script) + locale_string = CFStringCreateWithFormat( NULL, NULL, CFSTR("%@-%@"), lang, script ); + else if (country) locale_string = CFStringCreateWithFormat( NULL, NULL, CFSTR("%@-%@"), lang, country ); else locale_string = CFStringCreateCopy( NULL, lang );

1 0

Alexandre Julliard : opencl: Remove DECLSPEC_HIDDEN usage.
by Alexandre Julliard Nov. 28, 2023

Nov. 28, 2023

Module: wine Branch: master Commit: 9b2353c3b3d6d40ed0f4986ee8f1db99a20ee1d3 URL: https://gitlab.winehq.org/wine/wine/-/commit/9b2353c3b3d6d40ed0f4986ee8f1db… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Nov 28 21:53:07 2023 +0100 opencl: Remove DECLSPEC_HIDDEN usage. --- dlls/opencl/opencl_private.h | 2 +- dlls/opencl/unix_private.h | 16 ++++++++-------- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/dlls/opencl/opencl_private.h b/dlls/opencl/opencl_private.h index 28968296221..aabfe70cea3 100644 --- a/dlls/opencl/opencl_private.h +++ b/dlls/opencl/opencl_private.h @@ -31,7 +31,7 @@ #include "wine/unixlib.h" #include "wine/debug.h" -BOOL extension_is_supported( const char *name, size_t len ) DECLSPEC_HIDDEN; +BOOL extension_is_supported( const char *name, size_t len ); #define OPENCL_CALL( func, params ) WINE_UNIX_CALL( unix_ ## func, params ) diff --git a/dlls/opencl/unix_private.h b/dlls/opencl/unix_private.h index 4344c69f0b0..49ac2102dfc 100644 --- a/dlls/opencl/unix_private.h +++ b/dlls/opencl/unix_private.h @@ -44,13 +44,13 @@ #include "unixlib.h" -NTSTATUS wrap_clBuildProgram( void *args ) DECLSPEC_HIDDEN; -NTSTATUS wrap_clCreateContext( void *args ) DECLSPEC_HIDDEN; -NTSTATUS wrap_clCreateContextFromType( void *args ) DECLSPEC_HIDDEN; -NTSTATUS wrap_clEnqueueNativeKernel( void *args ) DECLSPEC_HIDDEN; -NTSTATUS wrap_clSetEventCallback( void *args ) DECLSPEC_HIDDEN; -NTSTATUS wrap_clSetMemObjectDestructorCallback( void *args ) DECLSPEC_HIDDEN; -NTSTATUS wrap_clCompileProgram( void *args ) DECLSPEC_HIDDEN; -NTSTATUS wrap_clLinkProgram( void *args ) DECLSPEC_HIDDEN; +NTSTATUS wrap_clBuildProgram( void *args ); +NTSTATUS wrap_clCreateContext( void *args ); +NTSTATUS wrap_clCreateContextFromType( void *args ); +NTSTATUS wrap_clEnqueueNativeKernel( void *args ); +NTSTATUS wrap_clSetEventCallback( void *args ); +NTSTATUS wrap_clSetMemObjectDestructorCallback( void *args ); +NTSTATUS wrap_clCompileProgram( void *args ); +NTSTATUS wrap_clLinkProgram( void *args ); #endif

1 0

Alexandre Julliard : mscoree: Remove DECLSPEC_HIDDEN usage.
by Alexandre Julliard Nov. 28, 2023

Nov. 28, 2023

Module: wine Branch: master Commit: 9a14c4a65b0cb19675e30c719500f1aefdf3c4a6 URL: https://gitlab.winehq.org/wine/wine/-/commit/9a14c4a65b0cb19675e30c719500f1… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Nov 28 21:52:56 2023 +0100 mscoree: Remove DECLSPEC_HIDDEN usage. --- dlls/mscoree/mscoree_private.h | 126 ++++++++++++++++++++--------------------- 1 file changed, 63 insertions(+), 63 deletions(-)

1 0

Marc-Aurel Zent : server: Add cross-platform get_path_from_fd function.
by Alexandre Julliard Nov. 28, 2023

Nov. 28, 2023

Module: wine Branch: master Commit: 7b1fe26bb0371b017600e24c201c6d047de5b451 URL: https://gitlab.winehq.org/wine/wine/-/commit/7b1fe26bb0371b017600e24c201c6d… Author: Marc-Aurel Zent <marc_aurel(a)me.com> Date: Thu Oct 5 14:03:54 2023 +0200 server: Add cross-platform get_path_from_fd function. --- server/change.c | 101 +++++++++++++++++++++++++++++++------------------------- 1 file changed, 56 insertions(+), 45 deletions(-) diff --git a/server/change.c b/server/change.c index 7a806abc017..00d286ede7a 100644 --- a/server/change.c +++ b/server/change.c @@ -721,6 +721,25 @@ static unsigned int filter_from_inode( struct inode *inode, int is_parent ) return filter; } +static char *get_path_from_fd( int fd, int sz ) +{ +#if defined(__APPLE__) || defined(__FreeBSD__) || defined(__OpenBSD__) || defined(__NetBSD__) + char *ret = malloc( PATH_MAX + sz ); + + if (!ret) return NULL; + if (!fcntl( fd, F_GETPATH, ret )) return ret; + free( ret ); + return NULL; +#elif defined(linux) + char *ret = malloc( 32 + sz ); + + if (ret) sprintf( ret, "/proc/self/fd/%u", fd ); + return ret; +#else + return NULL; +#endif +} + static char *inode_get_path( struct inode *inode, int sz ) { struct list *head; @@ -734,9 +753,8 @@ static char *inode_get_path( struct inode *inode, int sz ) if (head) { int unix_fd = get_unix_fd( LIST_ENTRY( head, struct dir, in_entry )->fd ); - path = malloc ( 32 + sz ); - if (path) - sprintf( path, "/proc/self/fd/%u/", unix_fd ); + if (!(path = get_path_from_fd( unix_fd, sz + 1 ))) return NULL; + strcat( path, "/" ); return path; } @@ -747,7 +765,7 @@ static char *inode_get_path( struct inode *inode, int sz ) path = inode_get_path( inode->parent, sz + len + 1 ); if (!path) return NULL; - + strcat( path, inode->name ); strcat( path, "/" ); @@ -964,7 +982,7 @@ static int inotify_adjust_changes( struct dir *dir ) unsigned int filter; struct inode *inode; struct stat st; - char path[32]; + char *path; int wd, unix_fd; if (!inotify_fd) @@ -990,8 +1008,9 @@ static int inotify_adjust_changes( struct dir *dir ) filter = filter_from_inode( inode, 0 ); - sprintf( path, "/proc/self/fd/%u", unix_fd ); + if (!(path = get_path_from_fd( unix_fd, 0 ))) return 0; wd = inotify_add_dir( path, filter ); + free( path ); if (wd == -1) return 0; inode_set_wd( inode, wd ); @@ -1037,30 +1056,29 @@ static char *get_basename( const char *link ) return name; } -static int dir_add_to_existing_notify( struct dir *dir ) +static void dir_add_to_existing_notify( struct dir *dir ) { struct inode *inode, *parent; unsigned int filter = 0; struct stat st, st_new; - char link[35], *name; - int wd, unix_fd; + char *link, *name; + int res, wd, unix_fd; if (!inotify_fd) - return 0; + return; unix_fd = get_unix_fd( dir->fd ); /* check if it's in the list of inodes we want to watch */ - if (-1 == fstat( unix_fd, &st_new )) - return 0; - inode = find_inode( st_new.st_dev, st_new.st_ino ); - if (inode) - return 0; + if (fstat( unix_fd, &st_new )) return; + if ((inode = find_inode( st_new.st_dev, st_new.st_ino ))) return; /* lookup the parent */ - sprintf( link, "/proc/self/fd/%u/..", unix_fd ); - if (-1 == stat( link, &st )) - return 0; + if (!(link = get_path_from_fd( unix_fd, 3 ))) return; + strcat( link, "/.." ); + res = stat( link, &st ); + free( link ); + if (res == -1) return; /* * If there's no parent, stop. We could keep going adding @@ -1068,34 +1086,28 @@ static int dir_add_to_existing_notify( struct dir *dir ) * find a recursively watched ancestor. * Assume it's too expensive to search up the tree for now. */ - parent = find_inode( st.st_dev, st.st_ino ); - if (!parent) - return 0; + if (!(parent = find_inode( st.st_dev, st.st_ino ))) return; + if (parent->wd == -1) return; - if (parent->wd == -1) - return 0; - - filter = filter_from_inode( parent, 1 ); - if (!filter) - return 0; - - sprintf( link, "/proc/self/fd/%u", unix_fd ); - name = get_basename( link ); - if (!name) - return 0; + if (!(filter = filter_from_inode( parent, 1 ))) return; + if (!(link = get_path_from_fd( unix_fd, 0 ))) return; + if (!(name = get_basename( link ))) + { + free( link ); + return; + } inode = inode_add( parent, st_new.st_dev, st_new.st_ino, name ); - free( name ); - if (!inode) - return 0; - - /* Couldn't find this inode at the start of the function, must be new */ - assert( inode->wd == -1 ); - - wd = inotify_add_dir( link, filter ); - if (wd != -1) - inode_set_wd( inode, wd ); + if (inode) + { + /* Couldn't find this inode at the start of the function, must be new */ + assert( inode->wd == -1 ); - return 1; + wd = inotify_add_dir( link, filter ); + if (wd != -1) + inode_set_wd( inode, wd ); + } + free( name ); + free( link ); } #else @@ -1115,9 +1127,8 @@ static void free_inode( struct inode *inode ) assert( 0 ); } -static int dir_add_to_existing_notify( struct dir *dir ) +static void dir_add_to_existing_notify( struct dir *dir ) { - return 0; } #endif /* HAVE_SYS_INOTIFY_H */

1 0

Louis Lenders : shell32: Add stub for SHCreateItemWithParent.
by Alexandre Julliard Nov. 28, 2023

Nov. 28, 2023

Module: wine Branch: master Commit: 44cbc8ef8462a4556c110b350b2d8e78d21181a4 URL: https://gitlab.winehq.org/wine/wine/-/commit/44cbc8ef8462a4556c110b350b2d8e… Author: Louis Lenders <xerox.xerox2000x(a)gmail.com> Date: Sun Nov 26 22:12:42 2023 +0100 shell32: Add stub for SHCreateItemWithParent. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55851 --- dlls/shell32/shell32.spec | 1 + dlls/shell32/shellitem.c | 8 ++++++++ 2 files changed, 9 insertions(+) diff --git a/dlls/shell32/shell32.spec b/dlls/shell32/shell32.spec index 2c969869722..60bd63ab7a8 100644 --- a/dlls/shell32/shell32.spec +++ b/dlls/shell32/shell32.spec @@ -349,6 +349,7 @@ @ stdcall SHCreateItemFromParsingName(wstr ptr ptr ptr) @ stdcall SHCreateItemInKnownFolder(ptr long wstr ptr ptr) @ stdcall SHCreateItemFromRelativeName(ptr wstr ptr ptr ptr) +@ stdcall SHCreateItemWithParent(ptr ptr ptr ptr ptr) @ stub SHCreateProcessAsUserW @ stdcall SHCreateQueryCancelAutoPlayMoniker(ptr) @ stdcall SHCreateShellItem(ptr ptr ptr ptr) diff --git a/dlls/shell32/shellitem.c b/dlls/shell32/shellitem.c index 6f8f52469fc..d8720734e22 100644 --- a/dlls/shell32/shellitem.c +++ b/dlls/shell32/shellitem.c @@ -769,6 +769,14 @@ HRESULT WINAPI SHCreateItemFromIDList(PCIDLIST_ABSOLUTE pidl, REFIID riid, void return ret; } +HRESULT WINAPI SHCreateItemWithParent(PCIDLIST_ABSOLUTE pidl_parent, IShellFolder *psf, + PCUITEMID_CHILD pidl, REFIID riid, void **ppv) +{ + FIXME("(%p, %p, %p, %s, %p)\n", pidl_parent, psf, pidl, debugstr_guid(riid), ppv); + + return E_NOTIMPL; +} + HRESULT WINAPI SHCreateItemInKnownFolder(REFKNOWNFOLDERID rfid, DWORD flags, PCWSTR filename, REFIID riid, void **ppv) {

1 0

Alexandre Julliard : winegstreamer: Remove DECLSPEC_HIDDEN usage.
by Alexandre Julliard Nov. 28, 2023

Nov. 28, 2023

Module: wine Branch: master Commit: 29a2a7effda928ff209b942337212aac99f7a23a URL: https://gitlab.winehq.org/wine/wine/-/commit/29a2a7effda928ff209b942337212a… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Nov 28 21:56:17 2023 +0100 winegstreamer: Remove DECLSPEC_HIDDEN usage. --- dlls/winegstreamer/unix_private.h | 68 +++++++++++++++++++-------------------- 1 file changed, 34 insertions(+), 34 deletions(-) diff --git a/dlls/winegstreamer/unix_private.h b/dlls/winegstreamer/unix_private.h index 5162c8d5863..f3c24311ac7 100644 --- a/dlls/winegstreamer/unix_private.h +++ b/dlls/winegstreamer/unix_private.h @@ -28,50 +28,50 @@ /* unixlib.c */ -GST_DEBUG_CATEGORY_EXTERN(wine) DECLSPEC_HIDDEN; +GST_DEBUG_CATEGORY_EXTERN(wine); #define GST_CAT_DEFAULT wine -extern NTSTATUS wg_init_gstreamer(void *args) DECLSPEC_HIDDEN; +extern NTSTATUS wg_init_gstreamer(void *args); -extern GstStreamType stream_type_from_caps(GstCaps *caps) DECLSPEC_HIDDEN; -extern GstElement *create_element(const char *name, const char *plugin_set) DECLSPEC_HIDDEN; -GstElement *factory_create_element(GstElementFactory *factory) DECLSPEC_HIDDEN; +extern GstStreamType stream_type_from_caps(GstCaps *caps); +extern GstElement *create_element(const char *name, const char *plugin_set); +GstElement *factory_create_element(GstElementFactory *factory); extern GList *find_element_factories(GstElementFactoryListType type, GstRank min_rank, - GstCaps *element_sink_caps, GstCaps *element_src_caps) DECLSPEC_HIDDEN; + GstCaps *element_sink_caps, GstCaps *element_src_caps); extern GstElement *find_element(GstElementFactoryListType type, - GstCaps *element_sink_caps, GstCaps *element_src_caps) DECLSPEC_HIDDEN; -extern bool append_element(GstElement *container, GstElement *element, GstElement **first, GstElement **last) DECLSPEC_HIDDEN; -extern bool link_src_to_sink(GstPad *src_pad, GstPad *sink_pad) DECLSPEC_HIDDEN; -extern bool link_src_to_element(GstPad *src_pad, GstElement *element) DECLSPEC_HIDDEN; -extern bool link_element_to_sink(GstElement *element, GstPad *sink_pad) DECLSPEC_HIDDEN; -extern bool push_event(GstPad *pad, GstEvent *event) DECLSPEC_HIDDEN; + GstCaps *element_sink_caps, GstCaps *element_src_caps); +extern bool append_element(GstElement *container, GstElement *element, GstElement **first, GstElement **last); +extern bool link_src_to_sink(GstPad *src_pad, GstPad *sink_pad); +extern bool link_src_to_element(GstPad *src_pad, GstElement *element); +extern bool link_element_to_sink(GstElement *element, GstPad *sink_pad); +extern bool push_event(GstPad *pad, GstEvent *event); /* wg_format.c */ -extern void wg_format_from_caps(struct wg_format *format, const GstCaps *caps) DECLSPEC_HIDDEN; -extern bool wg_format_compare(const struct wg_format *a, const struct wg_format *b) DECLSPEC_HIDDEN; -extern GstCaps *wg_format_to_caps(const struct wg_format *format) DECLSPEC_HIDDEN; +extern void wg_format_from_caps(struct wg_format *format, const GstCaps *caps); +extern bool wg_format_compare(const struct wg_format *a, const struct wg_format *b); +extern GstCaps *wg_format_to_caps(const struct wg_format *format); /* wg_transform.c */ -extern NTSTATUS wg_transform_create(void *args) DECLSPEC_HIDDEN; -extern NTSTATUS wg_transform_destroy(void *args) DECLSPEC_HIDDEN; -extern NTSTATUS wg_transform_set_output_format(void *args) DECLSPEC_HIDDEN; -extern NTSTATUS wg_transform_push_data(void *args) DECLSPEC_HIDDEN; -extern NTSTATUS wg_transform_read_data(void *args) DECLSPEC_HIDDEN; -extern NTSTATUS wg_transform_get_status(void *args) DECLSPEC_HIDDEN; -extern NTSTATUS wg_transform_drain(void *args) DECLSPEC_HIDDEN; -extern NTSTATUS wg_transform_flush(void *args) DECLSPEC_HIDDEN; +extern NTSTATUS wg_transform_create(void *args); +extern NTSTATUS wg_transform_destroy(void *args); +extern NTSTATUS wg_transform_set_output_format(void *args); +extern NTSTATUS wg_transform_push_data(void *args); +extern NTSTATUS wg_transform_read_data(void *args); +extern NTSTATUS wg_transform_get_status(void *args); +extern NTSTATUS wg_transform_drain(void *args); +extern NTSTATUS wg_transform_flush(void *args); /* wg_muxer.c */ -extern NTSTATUS wg_muxer_create(void *args) DECLSPEC_HIDDEN; -extern NTSTATUS wg_muxer_destroy(void *args) DECLSPEC_HIDDEN; -extern NTSTATUS wg_muxer_add_stream(void *args) DECLSPEC_HIDDEN; -extern NTSTATUS wg_muxer_start(void *args) DECLSPEC_HIDDEN; -extern NTSTATUS wg_muxer_push_sample(void *args) DECLSPEC_HIDDEN; -extern NTSTATUS wg_muxer_read_data(void *args) DECLSPEC_HIDDEN; -extern NTSTATUS wg_muxer_finalize(void *args) DECLSPEC_HIDDEN; +extern NTSTATUS wg_muxer_create(void *args); +extern NTSTATUS wg_muxer_destroy(void *args); +extern NTSTATUS wg_muxer_add_stream(void *args); +extern NTSTATUS wg_muxer_start(void *args); +extern NTSTATUS wg_muxer_push_sample(void *args); +extern NTSTATUS wg_muxer_read_data(void *args); +extern NTSTATUS wg_muxer_finalize(void *args); /* wg_allocator.c */ @@ -82,10 +82,10 @@ static inline BYTE *wg_sample_data(struct wg_sample *sample) /* wg_allocator_release_sample can be used to release any sample that was requested. */ typedef struct wg_sample *(*wg_allocator_request_sample_cb)(gsize size, void *context); -extern GstAllocator *wg_allocator_create(void) DECLSPEC_HIDDEN; -extern void wg_allocator_destroy(GstAllocator *allocator) DECLSPEC_HIDDEN; -extern void wg_allocator_provide_sample(GstAllocator *allocator, struct wg_sample *sample) DECLSPEC_HIDDEN; +extern GstAllocator *wg_allocator_create(void); +extern void wg_allocator_destroy(GstAllocator *allocator); +extern void wg_allocator_provide_sample(GstAllocator *allocator, struct wg_sample *sample); extern void wg_allocator_release_sample(GstAllocator *allocator, struct wg_sample *sample, - bool discard_data) DECLSPEC_HIDDEN; + bool discard_data); #endif /* __WINE_WINEGSTREAMER_UNIX_PRIVATE_H */

1 0

Alexandre Julliard : dwrite: Remove DECLSPEC_HIDDEN usage.
by Alexandre Julliard Nov. 28, 2023

Nov. 28, 2023

Module: wine Branch: master Commit: b70154a549b8c68dfce7255f3e81fffdcdb43b78 URL: https://gitlab.winehq.org/wine/wine/-/commit/b70154a549b8c68dfce7255f3e81ff… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Nov 28 21:52:37 2023 +0100 dwrite: Remove DECLSPEC_HIDDEN usage. --- dlls/dwrite/analyzer.c | 6 +- dlls/dwrite/bidi.c | 4 +- dlls/dwrite/dwrite_private.h | 240 +++++++++++++++++++++---------------------- dlls/dwrite/opentype.c | 2 +- dlls/dwrite/shapers/arabic.c | 2 +- 5 files changed, 127 insertions(+), 127 deletions(-)

1 0

Rémi Bernon : wineboot: Compute and write the TSC frequency to registry ~Mhz.
by Alexandre Julliard Nov. 28, 2023

Nov. 28, 2023

Module: wine Branch: master Commit: f2371a8b47cebdc497ec1c4e3d292c0de16df8cd URL: https://gitlab.winehq.org/wine/wine/-/commit/f2371a8b47cebdc497ec1c4e3d292c… Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Thu Nov 16 08:13:34 2023 +0100 wineboot: Compute and write the TSC frequency to registry ~Mhz. In HKEY_LOCAL_MACHINE\\HARDWARE\\DESCRIPTION\\System\\CentralProcessor Some games such as Horizon Zero Dawn use this registry value to correlate values from rtdsc to real time. Returning the nominal/maximum cpu frequency here causes the game to run in slow motion as it may not match the tsc frequency of the processor. Based on patches from Arkadiusz Hiler and Joshua Ashton. --- programs/wineboot/wineboot.c | 114 ++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 113 insertions(+), 1 deletion(-) diff --git a/programs/wineboot/wineboot.c b/programs/wineboot/wineboot.c index 728c41fffa9..58fa6939a9a 100644 --- a/programs/wineboot/wineboot.c +++ b/programs/wineboot/wineboot.c @@ -240,12 +240,120 @@ static void initialize_xstate_features(struct _KUSER_SHARED_DATA *data) TRACE("XSAVE feature 2 %#x, %#x, %#x, %#x.\n", regs[0], regs[1], regs[2], regs[3]); } +static BOOL is_tsc_trusted_by_the_kernel(void) +{ + char buf[4] = {0}; + DWORD num_read; + HANDLE handle; + BOOL ret = TRUE; + + /* Darwin for x86-64 uses the TSC internally for timekeeping, so it can always + * be trusted. + * For BSDs there seems to be no unified interface to query TSC quality. + * If there is a sysfs entry with clocksource information, use it to check though. */ + handle = CreateFileW( L"\\??\\unix\\sys\\bus\\clocksource\\devices\\clocksource0\\current_clocksource", + GENERIC_READ, FILE_SHARE_READ, NULL, OPEN_EXISTING, 0, 0 ); + if (handle == INVALID_HANDLE_VALUE) return TRUE; + + if (ReadFile( handle, buf, sizeof(buf) - 1, &num_read, NULL ) && strcmp( "tsc", buf )) + ret = FALSE; + + CloseHandle( handle ); + return ret; +} + +static UINT64 read_tsc_frequency(void) +{ + UINT64 freq = 0; + LONGLONG time0, time1, tsc0, tsc1, tsc2, tsc3, freq0, freq1, error; + BOOL has_rdtscp = FALSE; + unsigned int aux; + UINT retries = 50; + int regs[4]; + + if (!is_tsc_trusted_by_the_kernel()) + { + WARN( "Failed to compute TSC frequency, not trusted by the kernel.\n" ); + return 0; + } + + __cpuid(regs, 1); + if (!(regs[3] & (1 << 4))) + { + WARN( "Failed to compute TSC frequency, RDTSC instruction not supported.\n" ); + return 0; + } + + __cpuid( regs, 0x80000000 ); + if (regs[0] < 0x80000007) + { + WARN( "Failed to compute TSC frequency, unable to check invariant TSC.\n" ); + return 0; + } + + /* check for invariant tsc bit */ + __cpuid( regs, 0x80000007 ); + if (!(regs[3] & (1 << 8))) + { + WARN( "Failed to compute TSC frequency, no invariant TSC.\n" ); + return 0; + } + + /* check for rdtscp support bit */ + __cpuid( regs, 0x80000001 ); + if ((regs[3] & (1 << 27))) has_rdtscp = TRUE; + + do + { + if (has_rdtscp) + { + tsc0 = __rdtscp( &aux ); + time0 = RtlGetSystemTimePrecise(); + tsc1 = __rdtscp( &aux ); + Sleep( 1 ); + tsc2 = __rdtscp( &aux ); + time1 = RtlGetSystemTimePrecise(); + tsc3 = __rdtscp( &aux ); + } + else + { + tsc0 = __rdtsc(); __cpuid( regs, 0 ); + time0 = RtlGetSystemTimePrecise(); + tsc1 = __rdtsc(); __cpuid( regs, 0 ); + Sleep( 1 ); + tsc2 = __rdtsc(); __cpuid( regs, 0 ); + time1 = RtlGetSystemTimePrecise(); + tsc3 = __rdtsc(); __cpuid( regs, 0 ); + } + + freq0 = (tsc2 - tsc0) * 10000000 / (time1 - time0); + freq1 = (tsc3 - tsc1) * 10000000 / (time1 - time0); + error = llabs( (freq1 - freq0) * 1000000 / min( freq1, freq0 ) ); + } + while (error > 500 && --retries); + + if (!retries) WARN( "TSC frequency calibration failed, unstable TSC?\n" ); + else + { + freq = (freq0 + freq1) / 2; + TRACE( "TSC frequency calibration complete, found %I64u Hz\n", freq ); + } + + return freq; +} + #else static void initialize_xstate_features(struct _KUSER_SHARED_DATA *data) { } +static UINT64 read_tsc_frequency(void) +{ + FIXME( "TSC frequency calibration not implemented\n" ); + return 0; +} + #endif static void create_user_shared_data(void) @@ -666,6 +774,7 @@ static void create_hardware_registry_keys(void) SYSTEM_CPU_INFORMATION sci; PROCESSOR_POWER_INFORMATION* power_info; ULONG sizeof_power_info = sizeof(PROCESSOR_POWER_INFORMATION) * NtCurrentTeb()->Peb->NumberOfProcessors; + UINT64 tsc_frequency = read_tsc_frequency(); ULONG name_buffer[16]; WCHAR id[60], vendorid[13]; @@ -736,13 +845,16 @@ static void create_hardware_registry_keys(void) if (!RegCreateKeyExW( cpu_key, numW, 0, NULL, REG_OPTION_VOLATILE, KEY_ALL_ACCESS, NULL, &hkey, NULL )) { + DWORD tsc_freq_mhz = (DWORD)(tsc_frequency / 1000000ull); /* Hz -> Mhz */ + if (!tsc_freq_mhz) tsc_freq_mhz = power_info[i].MaxMhz; + RegSetValueExW( hkey, L"FeatureSet", 0, REG_DWORD, (BYTE *)&sci.ProcessorFeatureBits, sizeof(DWORD) ); set_reg_value( hkey, L"Identifier", id ); /* TODO: report ARM properly */ RegSetValueExA( hkey, "ProcessorNameString", 0, REG_SZ, (const BYTE *)name_buffer, strlen( (char *)name_buffer ) + 1 ); set_reg_value( hkey, L"VendorIdentifier", vendorid ); - RegSetValueExW( hkey, L"~MHz", 0, REG_DWORD, (BYTE *)&power_info[i].MaxMhz, sizeof(DWORD) ); + RegSetValueExW( hkey, L"~MHz", 0, REG_DWORD, (BYTE *)&tsc_freq_mhz, sizeof(DWORD) ); RegCloseKey( hkey ); } if (sci.ProcessorArchitecture != PROCESSOR_ARCHITECTURE_ARM &&

1 0