November 2023 - Wine-Commits

Zebediah Figura : http.sys: Keep connection sockets open after sending a 400 response.
by Alexandre Julliard Nov. 22, 2023

Nov. 22, 2023

Module: wine Branch: master Commit: 2bad8d9f63db0d1005b365a6c43247ba7a925218 URL: https://gitlab.winehq.org/wine/wine/-/commit/2bad8d9f63db0d1005b365a6c43247… Author: Zebediah Figura <zfigura(a)codeweavers.com> Date: Tue Aug 2 00:57:05 2022 -0500 http.sys: Keep connection sockets open after sending a 400 response. Tests show that the socket is shut down, but sending further data doesn't result in a TCP reset, so we need to keep the socket itself open until the TCP connection is closed. --- dlls/http.sys/http.c | 33 ++++++++++++++++++++++++++------- 1 file changed, 26 insertions(+), 7 deletions(-) diff --git a/dlls/http.sys/http.c b/dlls/http.sys/http.c index 52887259aa7..093a00f1b12 100644 --- a/dlls/http.sys/http.c +++ b/dlls/http.sys/http.c @@ -19,6 +19,7 @@ */ #include <assert.h> +#include <stdbool.h> #include "ntstatus.h" #define WIN32_NO_STATUS #include "wine/http.h" @@ -54,6 +55,7 @@ struct connection char *buffer; unsigned int len, size; + bool shutdown; /* If there is a request fully received and waiting to be read, the * "available" parameter will be TRUE. Either there is no queue matching @@ -111,7 +113,7 @@ static struct list request_queues = LIST_INIT(request_queues); static void accept_connection(SOCKET socket) { struct connection *conn; - ULONG true = 1; + ULONG one = 1; SOCKET peer; if ((peer = accept(socket, NULL, NULL)) == INVALID_SOCKET) @@ -134,15 +136,22 @@ static void accept_connection(SOCKET socket) } conn->size = 8192; WSAEventSelect(peer, request_event, FD_READ | FD_CLOSE); - ioctlsocket(peer, FIONBIO, &true); + ioctlsocket(peer, FIONBIO, &one); conn->socket = peer; list_add_head(&connections, &conn->entry); } -static void close_connection(struct connection *conn) +static void shutdown_connection(struct connection *conn) { free(conn->buffer); shutdown(conn->socket, SD_BOTH); + conn->shutdown = true; +} + +static void close_connection(struct connection *conn) +{ + if (!conn->shutdown) + shutdown_connection(conn); closesocket(conn->socket); list_remove(&conn->entry); free(conn); @@ -593,12 +602,24 @@ static void send_400(struct connection *conn) strcat(buffer, response_body); if (send(conn->socket, buffer, strlen(buffer), 0) < 0) ERR("Failed to send 400 response, error %u.\n", WSAGetLastError()); + shutdown_connection(conn); } static void receive_data(struct connection *conn) { int len, ret; + if (conn->shutdown) + { + WSANETWORKEVENTS events; + + if ((ret = WSAEnumNetworkEvents(conn->socket, NULL, &events)) < 0) + ERR("Failed to enumerate network events, error %u.\n", WSAGetLastError()); + if (events.lNetworkEvents & FD_CLOSE) + close_connection(conn); + return; + } + /* We might be waiting for an IRP, but always call recv() anyway, since we * might have been woken up by the socket closing. */ if ((len = recv(conn->socket, conn->buffer + conn->len, conn->size - conn->len, 0)) <= 0) @@ -653,7 +674,6 @@ static void receive_data(struct connection *conn) { WARN("Failed to parse request; shutting down connection.\n"); send_400(conn); - close_connection(conn); } } @@ -714,7 +734,7 @@ static NTSTATUS http_add_url(struct request_queue *queue, IRP *irp) struct listening_socket *listening_sock; char *url, *endptr; size_t queue_url_len, new_url_len; - ULONG true = 1, value; + ULONG one = 1, value; SOCKET s = INVALID_SOCKET; TRACE("host %s, context %s.\n", debugstr_a(params->url), wine_dbgstr_longlong(params->context)); @@ -823,7 +843,7 @@ static NTSTATUS http_add_url(struct request_queue *queue, IRP *irp) listening_sock->socket = s; list_add_head(&listening_sockets, &listening_sock->entry); - ioctlsocket(s, FIONBIO, &true); + ioctlsocket(s, FIONBIO, &one); WSAEventSelect(s, request_event, FD_ACCEPT); } @@ -1002,7 +1022,6 @@ static NTSTATUS http_send_response(struct request_queue *queue, IRP *irp) { WARN("Failed to parse request; shutting down connection.\n"); send_400(conn); - close_connection(conn); } } else

1 0

Zebediah Figura : server: Return ERROR_CONNECTION_RESET when trying to recv() on a reset socket.
by Alexandre Julliard Nov. 22, 2023

Nov. 22, 2023

Module: wine Branch: master Commit: a866d16ff8f737b864ceee10931aae06c51bed39 URL: https://gitlab.winehq.org/wine/wine/-/commit/a866d16ff8f737b864ceee10931aae… Author: Zebediah Figura <zfigura(a)codeweavers.com> Date: Fri Jul 15 20:03:02 2022 -0500 server: Return ERROR_CONNECTION_RESET when trying to recv() on a reset socket. --- dlls/ws2_32/tests/sock.c | 20 ++++++++++---------- server/sock.c | 5 ++++- 2 files changed, 14 insertions(+), 11 deletions(-) diff --git a/dlls/ws2_32/tests/sock.c b/dlls/ws2_32/tests/sock.c index 268b1e6d691..8530d80d3d9 100644 --- a/dlls/ws2_32/tests/sock.c +++ b/dlls/ws2_32/tests/sock.c @@ -10594,9 +10594,9 @@ static void test_completion_port(void) /* Somehow a hard shutdown doesn't work on my Linux box. It seems SO_LINGER is ignored. */ iret = WSARecv(dest, &bufs, 1, &num_bytes, &flags, &ov, NULL); - todo_wine ok(iret == SOCKET_ERROR, "WSARecv failed - %d\n", iret); - todo_wine ok(GetLastError() == WSAECONNRESET, "Last error was %ld\n", GetLastError()); - todo_wine ok(num_bytes == 0xdeadbeef, "Managed to read %ld\n", num_bytes); + ok(iret == SOCKET_ERROR, "WSARecv failed - %d\n", iret); + ok(GetLastError() == WSAECONNRESET, "Last error was %ld\n", GetLastError()); + ok(num_bytes == 0xdeadbeef, "Managed to read %ld\n", num_bytes); SetLastError(0xdeadbeef); key = 0xdeadbeef; @@ -10604,11 +10604,11 @@ static void test_completion_port(void) olp = (WSAOVERLAPPED *)0xdeadbeef; bret = GetQueuedCompletionStatus( io_port, &num_bytes, &key, &olp, 200 ); - todo_wine ok(bret == FALSE, "GetQueuedCompletionStatus returned %u\n", bret ); - todo_wine ok(GetLastError() == WAIT_TIMEOUT, "Last error was %ld\n", GetLastError()); - todo_wine ok(key == 0xdeadbeef, "Key is %Iu\n", key); - todo_wine ok(num_bytes == 0xdeadbeef, "Number of bytes transferred is %lu\n", num_bytes); - todo_wine ok(!olp, "Overlapped structure is at %p\n", olp); + ok(bret == FALSE, "GetQueuedCompletionStatus returned %u\n", bret ); + ok(GetLastError() == WAIT_TIMEOUT, "Last error was %ld\n", GetLastError()); + ok(key == 0xdeadbeef, "Key is %Iu\n", key); + ok(num_bytes == 0xdeadbeef, "Number of bytes transferred is %lu\n", num_bytes); + ok(!olp, "Overlapped structure is at %p\n", olp); closesocket(dest); @@ -13666,8 +13666,8 @@ static void test_tcp_reset(void) WSASetLastError(0xdeadbeef); size = 0xdeadbeef; ret = WSARecv(client, &wsabuf, 1, &size, &flags, &overlapped, NULL); - todo_wine ok(ret == -1, "got %d\n", ret); - todo_wine ok(WSAGetLastError() == WSAECONNRESET, "got error %u\n", WSAGetLastError()); + ok(ret == -1, "got %d\n", ret); + ok(WSAGetLastError() == WSAECONNRESET, "got error %u\n", WSAGetLastError()); WSASetLastError(0xdeadbeef); ret = send(client, "data", 5, 0); diff --git a/server/sock.c b/server/sock.c index f774cded733..f2d1dce8112 100644 --- a/server/sock.c +++ b/server/sock.c @@ -3830,7 +3830,10 @@ DECL_HANDLER(recv_socket) if (!req->force_async && !sock->nonblocking && is_fd_overlapped( fd )) timeout = (timeout_t)sock->rcvtimeo * -10000; - if (sock->rd_shutdown) status = STATUS_PIPE_DISCONNECTED; + if (sock->rd_shutdown) + status = STATUS_PIPE_DISCONNECTED; + else if (sock->reset) + status = STATUS_CONNECTION_RESET; else if (!async_queued( &sock->read_q )) { /* If read_q is not empty, we cannot really tell if the already queued

1 0

Zebediah Figura : ws2_32/tests: Work around a Linux bug.
by Alexandre Julliard Nov. 22, 2023

Nov. 22, 2023

Module: wine Branch: master Commit: 68cfc95ab6456e5c71f68cfb92cba268d47ee02b URL: https://gitlab.winehq.org/wine/wine/-/commit/68cfc95ab6456e5c71f68cfb92cba2… Author: Zebediah Figura <zfigura(a)codeweavers.com> Date: Fri Jul 15 19:52:50 2022 -0500 ws2_32/tests: Work around a Linux bug. This was reported upstream: https://bugzilla.kernel.org/show_bug.cgi?id=216259 --- dlls/ws2_32/tests/sock.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/dlls/ws2_32/tests/sock.c b/dlls/ws2_32/tests/sock.c index 9f1da1039c4..268b1e6d691 100644 --- a/dlls/ws2_32/tests/sock.c +++ b/dlls/ws2_32/tests/sock.c @@ -4422,6 +4422,7 @@ static void test_select(void) ret = getsockopt(fdWrite, SOL_SOCKET, SO_ERROR, (char*)&id, &len); ok(!ret, "getsockopt failed with %d\n", WSAGetLastError()); ok(id == 0, "expected 0, got %ld\n", id); + set_blocking(fdRead, FALSE); /* When data is received the receiver gets the read descriptor */ ret = send(fdWrite, "1234", 4, 0); @@ -4482,6 +4483,14 @@ static void test_select(void) ok(ret == 1, "expected 1, got %d\n", ret); ok(tmp_buf[0] == 'A', "expected 'A', got 0x%02X\n", tmp_buf[0]); + /* Linux has some odd behaviour (probably a bug) where receiving OOB, + * setting SO_OOBINLINE, and then calling recv() again will cause the same + * data to be received twice. Avoid that messing with further tests by + * calling recv() here. */ + ret = recv(fdRead, tmp_buf, sizeof(tmp_buf), 0); + todo_wine ok(ret == -1, "got %d\n", ret); + todo_wine ok(GetLastError() == WSAEWOULDBLOCK, "got error %u\n", WSAGetLastError()); + /* When the connection is closed the socket is set in the read descriptor */ ret = closesocket(fdRead); ok(ret == 0, "expected 0, got %d\n", ret);

1 0

Zebediah Figura : ws2_32/tests: Test send() after TCP reset.
by Alexandre Julliard Nov. 22, 2023

Nov. 22, 2023

Module: wine Branch: master Commit: a83c3736a96226aadbed0132fbd049111aa98875 URL: https://gitlab.winehq.org/wine/wine/-/commit/a83c3736a96226aadbed0132fbd049… Author: Zebediah Figura <zfigura(a)codeweavers.com> Date: Fri Jul 15 18:45:59 2022 -0500 ws2_32/tests: Test send() after TCP reset. --- dlls/ws2_32/tests/sock.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/dlls/ws2_32/tests/sock.c b/dlls/ws2_32/tests/sock.c index 951c4abee2e..9f1da1039c4 100644 --- a/dlls/ws2_32/tests/sock.c +++ b/dlls/ws2_32/tests/sock.c @@ -13660,6 +13660,11 @@ static void test_tcp_reset(void) todo_wine ok(ret == -1, "got %d\n", ret); todo_wine ok(WSAGetLastError() == WSAECONNRESET, "got error %u\n", WSAGetLastError()); + WSASetLastError(0xdeadbeef); + ret = send(client, "data", 5, 0); + ok(ret == -1, "got %d\n", ret); + ok(WSAGetLastError() == WSAECONNRESET, "got error %u\n", WSAGetLastError()); + check_poll(client, POLLERR | POLLHUP | POLLWRNORM); FD_ZERO(&readfds);

1 0

Zebediah Figura : ws2_32/tests: Test sending data to a peer which is closed.
by Alexandre Julliard Nov. 22, 2023

Nov. 22, 2023

Module: wine Branch: master Commit: 25bcb9d3630223def9668cccf48b68231a4d04d9 URL: https://gitlab.winehq.org/wine/wine/-/commit/25bcb9d3630223def9668cccf48b68… Author: Zebediah Figura <zfigura(a)codeweavers.com> Date: Tue Aug 2 00:55:06 2022 -0500 ws2_32/tests: Test sending data to a peer which is closed. --- dlls/ws2_32/tests/sock.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/dlls/ws2_32/tests/sock.c b/dlls/ws2_32/tests/sock.c index f9cc1482c41..951c4abee2e 100644 --- a/dlls/ws2_32/tests/sock.c +++ b/dlls/ws2_32/tests/sock.c @@ -9416,6 +9416,26 @@ static void test_shutdown(void) closesocket(client); closesocket(server); + /* Send data to a peer which is closed. */ + + tcp_socketpair(&client, &server); + + WSASetLastError(0xdeadbeef); + ret = shutdown(client, SD_SEND); + ok(!ret, "expected success\n"); + ok(!WSAGetLastError() || WSAGetLastError() == 0xdeadbeef /* < 7 */, "got error %u\n", WSAGetLastError()); + closesocket(client); + + ret = send(server, "test", 5, 0); + ok(ret == 5, "got %d\n", ret); + + WSASetLastError(0xdeadbeef); + ret = recv(server, buffer, sizeof(buffer), 0); + ok(ret == -1, "got %d\n", ret); + todo_wine ok(WSAGetLastError() == WSAECONNABORTED, "got error %u\n", WSAGetLastError()); + + closesocket(server); + /* Test shutting down with async I/O pending. */ client = socket(AF_INET, SOCK_STREAM, IPPROTO_TCP);

1 0

Alistair Leslie-Hughes : msdasql: Check rowset pointer before assignment in ICommandText::Execute.
by Alexandre Julliard Nov. 22, 2023

Nov. 22, 2023

Module: wine Branch: master Commit: 311cf13a1c72a4419f6a0214bf7fd8baf1179bc1 URL: https://gitlab.winehq.org/wine/wine/-/commit/311cf13a1c72a4419f6a0214bf7fd8… Author: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Date: Wed Nov 22 16:27:09 2023 +1100 msdasql: Check rowset pointer before assignment in ICommandText::Execute. --- dlls/msdasql/session.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dlls/msdasql/session.c b/dlls/msdasql/session.c index 7cec1523f4d..b42af7f6a02 100644 --- a/dlls/msdasql/session.c +++ b/dlls/msdasql/session.c @@ -1263,7 +1263,8 @@ static HRESULT WINAPI command_Execute(ICommandText *iface, IUnknown *outer, REFI return E_FAIL; } - *rowset = NULL; + if (rowset) + *rowset = NULL; if (!wcsnicmp( command->query, L"select ", 7 )) { msrowset = malloc(sizeof(*msrowset));

1 0

Zhiyi Zhang : msdasql/tests: Add more IDBProperties::GetProperties() tests.
by Alexandre Julliard Nov. 22, 2023

Nov. 22, 2023

Module: wine Branch: master Commit: fd2a2d3842ca05ef4ea0433b6f539461738fb38c URL: https://gitlab.winehq.org/wine/wine/-/commit/fd2a2d3842ca05ef4ea0433b6f5394… Author: Zhiyi Zhang <zzhang(a)codeweavers.com> Date: Mon Nov 20 17:54:13 2023 +0800 msdasql/tests: Add more IDBProperties::GetProperties() tests. --- dlls/msdasql/tests/provider.c | 38 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 38 insertions(+) diff --git a/dlls/msdasql/tests/provider.c b/dlls/msdasql/tests/provider.c index b6936be31b5..10517484c83 100644 --- a/dlls/msdasql/tests/provider.c +++ b/dlls/msdasql/tests/provider.c @@ -154,6 +154,7 @@ static void test_Properties(void) free_dbpropinfoset(infocount, propinfoset); CoTaskMemFree(desc); + /* Test specifying all supported properties */ hr = IDBProperties_GetProperties(props, 1, &propidlist, &propcnt, &propset); ok(hr == S_OK, "got 0x%08lx\n", hr); ok(propidlist.cPropertyIDs == 14, "got %lu\n", propidlist.cPropertyIDs); @@ -184,7 +185,44 @@ static void test_Properties(void) ok(V_VT(&propset->rgProperties[i].vValue) == vartype, "%lu wrong type %d\n", i, V_VT(&propset->rgProperties[i].vValue)); } + for (i = 0; i < propset->cProperties; i++) + ok(propset->rgProperties[i].dwPropertyID == properties[i], + "%ld %ld, got %ld\n", i, properties[i], propset->rgProperties[i].dwPropertyID); + + free_dbpropset(propcnt, propset); + + /* Test specifying only one supported properties */ + propidlist.cPropertyIDs = 1; + hr = IDBProperties_GetProperties(props, 1, &propidlist, &propcnt, &propset); + ok(hr == S_OK, "got 0x%08lx\n", hr); + ok(propset->cProperties == 1, "expected 1, got %lu\n", propset->cProperties); + free_dbpropset(propcnt, propset); + + /* Test when cPropertyIDSets is zero, all initialization properties should be returned */ + hr = IDBProperties_GetProperties(props, 0, &propidlist, &propcnt, &propset); + ok(hr == S_OK, "got 0x%08lx\n", hr); + todo_wine + ok(propset->cProperties == ARRAY_SIZE(properties), "got %lu\n", propset->cProperties); + for (i = 0; i < propset->cProperties; i++) + todo_wine_if(i > 0) + ok(propset->rgProperties[i].dwPropertyID == properties[i], + "%ld %ld, got %ld\n", i, properties[i], propset->rgProperties[i].dwPropertyID); + free_dbpropset(propcnt, propset); + + /* Test when propidlist.cPropertyIDs is zero, all initialization properties should be returned */ CoTaskMemFree(propidlist.rgPropertyIDs); + propidlist.guidPropertySet = DBPROPSET_DBINIT; + propidlist.cPropertyIDs = 0; + propidlist.rgPropertyIDs = NULL; + + hr = IDBProperties_GetProperties(props, 1, &propidlist, &propcnt, &propset); + ok(hr == S_OK, "got 0x%08lx\n", hr); + todo_wine + ok(propset->cProperties == ARRAY_SIZE(properties), "got %lu\n", propset->cProperties); + todo_wine + for (i = 0; i < propset->cProperties; i++) + ok(propset->rgProperties[i].dwPropertyID == properties[i], + "%ld %ld, got %ld\n", i, properties[i], propset->rgProperties[i].dwPropertyID); free_dbpropset(propcnt, propset); }

1 0

Zhiyi Zhang : msdasql/tests: Fix memory leaks.
by Alexandre Julliard Nov. 22, 2023

Nov. 22, 2023

Module: wine Branch: master Commit: b54e1ec604419326356a733c3884dbee1d4ee0c9 URL: https://gitlab.winehq.org/wine/wine/-/commit/b54e1ec604419326356a733c3884db… Author: Zhiyi Zhang <zzhang(a)codeweavers.com> Date: Tue Nov 21 10:50:42 2023 +0800 msdasql/tests: Fix memory leaks. --- dlls/msdasql/tests/provider.c | 42 ++++++++++++++++++++++++++++++++---------- 1 file changed, 32 insertions(+), 10 deletions(-) diff --git a/dlls/msdasql/tests/provider.c b/dlls/msdasql/tests/provider.c index bb549bb2262..b6936be31b5 100644 --- a/dlls/msdasql/tests/provider.c +++ b/dlls/msdasql/tests/provider.c @@ -43,6 +43,32 @@ static char mdbpath[MAX_PATH]; static const VARTYPE intptr_vartype = (sizeof(void *) == 8 ? VT_I8 : VT_I4); +static void free_dbpropset(ULONG count, DBPROPSET *propset) +{ + ULONG i, j; + + for (i = 0; i < count; i++) + { + for (j = 0; j < propset[i].cProperties; j++) + VariantClear(&propset[i].rgProperties[j].vValue); + CoTaskMemFree(propset[i].rgProperties); + } + CoTaskMemFree(propset); +} + +static void free_dbpropinfoset(ULONG count, DBPROPINFOSET *propinfoset) +{ + ULONG i, j; + + for (i = 0; i < count; i++) + { + for (j = 0; j < propinfoset[i].cPropertyInfos; j++) + VariantClear(&propinfoset[i].rgPropertyInfos[j].vValues); + CoTaskMemFree(propinfoset[i].rgPropertyInfos); + } + CoTaskMemFree(propinfoset); +} + static void test_msdasql(void) { HRESULT hr; @@ -125,11 +151,8 @@ static void test_Properties(void) propidlist.rgPropertyIDs[i] = propinfoset->rgPropertyInfos[i].dwPropertyID; } - for (i = 0; i < propinfoset->cPropertyInfos; i++) - VariantClear(&propinfoset->rgPropertyInfos[i].vValues); - - CoTaskMemFree(propinfoset->rgPropertyInfos); - CoTaskMemFree(propinfoset); + free_dbpropinfoset(infocount, propinfoset); + CoTaskMemFree(desc); hr = IDBProperties_GetProperties(props, 1, &propidlist, &propcnt, &propset); ok(hr == S_OK, "got 0x%08lx\n", hr); @@ -162,7 +185,7 @@ static void test_Properties(void) } CoTaskMemFree(propidlist.rgPropertyIDs); - CoTaskMemFree(propset); + free_dbpropset(propcnt, propset); } propid = DBPROP_MULTIPLERESULTS; @@ -179,7 +202,7 @@ static void test_Properties(void) ok(propset->rgProperties[0].dwPropertyID == DBPROP_MULTIPLERESULTS, "got %ld\n", propset->rgProperties[0].dwPropertyID); ok(propset->rgProperties[0].dwStatus == DBPROPSTATUS_NOTSUPPORTED, "got %ld\n", propset->rgProperties[0].dwStatus); - CoTaskMemFree(propset); + free_dbpropset(propcnt, propset); IDBProperties_Release(props); } @@ -324,7 +347,7 @@ static void test_command_properties(ICommandProperties *props) } } - CoTaskMemFree(propset); + free_dbpropset(count, propset); } static void test_command_interfaces(IUnknown *cmd) @@ -528,8 +551,7 @@ static void test_rowset_info(IRowset *rowset) propset->rgProperties[i].dwPropertyID, row_props[i]); } - CoTaskMemFree(propset); - + free_dbpropset(propcnt, propset); IRowsetInfo_Release(info); }

1 0

Zhiyi Zhang : oledb32/tests: Remove test_odbc_provider().
by Alexandre Julliard Nov. 22, 2023

Nov. 22, 2023

Module: wine Branch: master Commit: 31707758037b04a07ed3be77bce3ebb1fd6f2027 URL: https://gitlab.winehq.org/wine/wine/-/commit/31707758037b04a07ed3be77bce3eb… Author: Zhiyi Zhang <zzhang(a)codeweavers.com> Date: Mon Nov 20 17:56:57 2023 +0800 oledb32/tests: Remove test_odbc_provider(). All these tests are already covered by test_Properties() in msdasql/tests/provider.c. --- dlls/oledb32/tests/database.c | 78 ------------------------------------------- 1 file changed, 78 deletions(-) diff --git a/dlls/oledb32/tests/database.c b/dlls/oledb32/tests/database.c index 4a3d7c8c907..67b45737ba8 100644 --- a/dlls/oledb32/tests/database.c +++ b/dlls/oledb32/tests/database.c @@ -984,83 +984,6 @@ static void test_dslocator(void) } } -static void test_odbc_provider(void) -{ - HRESULT hr; - IDBProperties *props; - DBPROPIDSET propidset; - ULONG infocount; - DBPROPINFOSET *propinfoset; - WCHAR *desc; - DBPROPID properties[14] = - { - DBPROP_AUTH_PASSWORD, DBPROP_AUTH_PERSIST_SENSITIVE_AUTHINFO, DBPROP_AUTH_USERID, - DBPROP_INIT_DATASOURCE, DBPROP_INIT_HWND, DBPROP_INIT_LOCATION, - DBPROP_INIT_MODE, DBPROP_INIT_PROMPT, DBPROP_INIT_TIMEOUT, - DBPROP_INIT_PROVIDERSTRING, DBPROP_INIT_LCID, DBPROP_INIT_CATALOG, - DBPROP_INIT_OLEDBSERVICES, DBPROP_INIT_GENERALTIMEOUT - }; - - hr = CoCreateInstance( &CLSID_MSDASQL, NULL, CLSCTX_ALL, &IID_IDBProperties, (void **)&props); - ok(hr == S_OK, "Failed to create object 0x%08lx\n", hr); - if (FAILED(hr)) - { - return; - } - - propidset.rgPropertyIDs = NULL; - propidset.cPropertyIDs = 0; - propidset.guidPropertySet = DBPROPSET_DBINITALL; - - infocount = 0; - hr = IDBProperties_GetPropertyInfo(props, 1, &propidset, &infocount, &propinfoset, &desc); - ok(hr == S_OK, "got 0x%08lx\n", hr); - if (hr == S_OK) - { - ULONG i; - DBPROPIDSET propidlist; - ULONG propcnt; - DBPROPSET *propset; - - ok(IsEqualGUID(&propinfoset->guidPropertySet, &DBPROPSET_DBINIT), "got %s\n", - debugstr_guid(&propinfoset->guidPropertySet)); - ok(propinfoset->cPropertyInfos == 14, "got %ld\n", propinfoset->cPropertyInfos); - - propidlist.guidPropertySet = DBPROPSET_DBINIT; - propidlist.cPropertyIDs = propinfoset->cPropertyInfos; - propidlist.rgPropertyIDs = CoTaskMemAlloc(propinfoset->cPropertyInfos * sizeof(DBPROP)); - - for (i = 0; i < propinfoset->cPropertyInfos; i++) - { - ok(properties[i] == propinfoset->rgPropertyInfos[i].dwPropertyID, "%ld, got %ld\n", i, - propinfoset->rgPropertyInfos[i].dwPropertyID); - ok(propinfoset->rgPropertyInfos[i].vtType != VT_EMPTY, "%ld, got %d\n", i, - propinfoset->rgPropertyInfos[i].vtType); - - propidlist.rgPropertyIDs[i] = propinfoset->rgPropertyInfos[i].dwPropertyID; - } - - for (i = 0; i < propinfoset->cPropertyInfos; i++) - VariantClear(&propinfoset->rgPropertyInfos[i].vValues); - - CoTaskMemFree(propinfoset->rgPropertyInfos); - CoTaskMemFree(propinfoset); - - hr = IDBProperties_GetProperties(props, 1, &propidlist, &propcnt, &propset); - ok(hr == S_OK, "got 0x%08lx\n", hr); - ok(propidlist.cPropertyIDs == 14, "got %ld\n", propinfoset->cPropertyInfos); - - for (i = 0; i < propidlist.cPropertyIDs; i++) - ok(properties[i] == propidlist.rgPropertyIDs[i], "%ld, got %ld\n", i, - propidlist.rgPropertyIDs[i]); - - CoTaskMemFree(propidlist.rgPropertyIDs); - CoTaskMemFree(propset); - } - - IDBProperties_Release(props); -} - static void test_odbc_enumerator(void) { HRESULT hr; @@ -1105,7 +1028,6 @@ START_TEST(database) test_errorinfo(); test_initializationstring(); test_dslocator(); - test_odbc_provider(); test_odbc_enumerator(); /* row position */

1 0

Zhiyi Zhang : oledb32/tests: Fix memory leaks.
by Alexandre Julliard Nov. 22, 2023

Nov. 22, 2023

Module: wine Branch: master Commit: 6b966a888a851459e1a0c241629cf88b64b200f6 URL: https://gitlab.winehq.org/wine/wine/-/commit/6b966a888a851459e1a0c241629cf8… Author: Zhiyi Zhang <zzhang(a)codeweavers.com> Date: Tue Nov 21 10:55:59 2023 +0800 oledb32/tests: Fix memory leaks. --- dlls/oledb32/tests/database.c | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/dlls/oledb32/tests/database.c b/dlls/oledb32/tests/database.c index 67b45737ba8..ebd3cb2fadf 100644 --- a/dlls/oledb32/tests/database.c +++ b/dlls/oledb32/tests/database.c @@ -47,6 +47,19 @@ static void _expect_ref(IUnknown* obj, ULONG ref, int line) ok_(__FILE__, line)(rc == ref, "expected refcount %ld, got %ld\n", ref, rc); } +static void free_dbpropinfoset(ULONG count, DBPROPINFOSET *propinfoset) +{ + ULONG i, j; + + for (i = 0; i < count; i++) + { + for (j = 0; j < propinfoset[i].cPropertyInfos; j++) + VariantClear(&propinfoset[i].rgPropertyInfos[j].vValues); + CoTaskMemFree(propinfoset[i].rgPropertyInfos); + } + CoTaskMemFree(propinfoset); +} + static void test_GetDataSource(const WCHAR *initstring) { IDataInitialize *datainit = NULL; @@ -90,7 +103,7 @@ static void test_GetDataSource(const WCHAR *initstring) pInfoset->rgPropertyInfos[i].vtType); } - CoTaskMemFree(pInfoset); + free_dbpropinfoset(cnt, pInfoset); CoTaskMemFree(ary); }

1 0