June 2023 - Wine-Commits - list.winehq.org

Alexandre Julliard : ipconfig: Use nameless union/structs.
by Alexandre Julliard June 16, 2023

June 16, 2023

Module: wine Branch: master Commit: e3664fa8ad24d6dc47f0563810b0780a809c283e URL: https://gitlab.winehq.org/wine/wine/-/commit/e3664fa8ad24d6dc47f0563810b078… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Jun 16 17:57:24 2023 +0200 ipconfig: Use nameless union/structs. --- programs/ipconfig/ipconfig.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/programs/ipconfig/ipconfig.c b/programs/ipconfig/ipconfig.c index 40324a0a493..f59c3ab7182 100644 --- a/programs/ipconfig/ipconfig.c +++ b/programs/ipconfig/ipconfig.c @@ -19,8 +19,6 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA */ -#define NONAMELESSUNION - #include <stdio.h> #include <winsock2.h> #include <windows.h> @@ -317,7 +315,7 @@ static void print_full_information(void) print_field(STRING_CONN_DNS_SUFFIX, p->DnsSuffix); print_field(STRING_DESCRIPTION, p->Description); print_field(STRING_PHYS_ADDR, physaddr_to_string(physaddr_buf, p->PhysicalAddress, p->PhysicalAddressLength)); - print_field(STRING_DHCP_ENABLED, boolean_to_string(p->u1.Flags & IP_ADAPTER_DHCP_ENABLED)); + print_field(STRING_DHCP_ENABLED, boolean_to_string(p->Flags & IP_ADAPTER_DHCP_ENABLED)); /* FIXME: Output autoconfiguration status. */

1 0

Georg Lehmann : winevulkan: Update to VK spec version 1.3.254.
by Alexandre Julliard June 16, 2023

June 16, 2023

Module: wine Branch: master Commit: 7eb75124e74804f56813ef371193d0db97e12e9c URL: https://gitlab.winehq.org/wine/wine/-/commit/7eb75124e74804f56813ef371193d0… Author: Georg Lehmann <dadschoorse(a)gmail.com> Date: Fri Jun 16 17:48:29 2023 +0200 winevulkan: Update to VK spec version 1.3.254. --- dlls/winevulkan/loader_thunks.c | 9 ++ dlls/winevulkan/loader_thunks.h | 7 + dlls/winevulkan/make_vulkan | 2 +- dlls/winevulkan/vulkan_thunks.c | 276 ++++++++++++++++++++++++++++++++++++++-- dlls/winevulkan/vulkan_thunks.h | 2 + dlls/winevulkan/winevulkan.json | 2 +- include/wine/vulkan.h | 58 ++++++++- 7 files changed, 345 insertions(+), 11 deletions(-)

1 0

Alexandre Julliard : explorer: Use nameless union/structs.
by Alexandre Julliard June 16, 2023

June 16, 2023

Module: wine Branch: master Commit: 14518662d6a2e99b63f54b70d5e913081dcbf368 URL: https://gitlab.winehq.org/wine/wine/-/commit/14518662d6a2e99b63f54b70d5e913… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Jun 16 17:57:11 2023 +0200 explorer: Use nameless union/structs. --- programs/explorer/desktop.c | 5 +---- programs/explorer/systray.c | 7 +++---- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/programs/explorer/desktop.c b/programs/explorer/desktop.c index 341aff89056..1610814048e 100644 --- a/programs/explorer/desktop.c +++ b/programs/explorer/desktop.c @@ -22,8 +22,6 @@ #include <stdio.h> #define COBJMACROS -#define NONAMELESSUNION -#define NONAMELESSSTRUCT #define OEMRESOURCE #include <windows.h> #include <rpc.h> @@ -973,8 +971,7 @@ static void initialize_display_settings(void) WINE_TRACE( "Device %s current display mode %lux%lu %luBits %luHz at %ld,%ld.\n", wine_dbgstr_w( ddW.DeviceName ), dmW.dmPelsWidth, dmW.dmPelsHeight, - dmW.dmBitsPerPel, dmW.dmDisplayFrequency, dmW.u1.s2.dmPosition.x, - dmW.u1.s2.dmPosition.y ); + dmW.dmBitsPerPel, dmW.dmDisplayFrequency, dmW.dmPosition.x, dmW.dmPosition.y ); if (ChangeDisplaySettingsExW( ddW.DeviceName, &dmW, 0, CDS_GLOBAL | CDS_NORESET | CDS_UPDATEREGISTRY, 0 )) diff --git a/programs/explorer/systray.c b/programs/explorer/systray.c index 7790648d021..5070e123829 100644 --- a/programs/explorer/systray.c +++ b/programs/explorer/systray.c @@ -20,7 +20,6 @@ #include <assert.h> -#define NONAMELESSUNION #include <windows.h> #include <commctrl.h> #include <shellapi.h> @@ -412,7 +411,7 @@ static BOOL modify_icon( struct icon *icon, NOTIFYICONDATAW *nid ) lstrcpynW( icon->info_text, nid->szInfo, ARRAY_SIZE( icon->info_text )); lstrcpynW( icon->info_title, nid->szInfoTitle, ARRAY_SIZE( icon->info_title )); icon->info_flags = nid->dwInfoFlags; - icon->info_timeout = max(min(nid->u.uTimeout, BALLOON_SHOW_MAX_TIMEOUT), BALLOON_SHOW_MIN_TIMEOUT); + icon->info_timeout = max(min(nid->uTimeout, BALLOON_SHOW_MAX_TIMEOUT), BALLOON_SHOW_MIN_TIMEOUT); icon->info_icon = nid->hBalloonIcon; update_balloon( icon ); } @@ -536,7 +535,7 @@ static BOOL handle_incoming(HWND hwndSource, COPYDATASTRUCT *cds) nid.hIcon = 0; nid.dwState = data->dwState; nid.dwStateMask = data->dwStateMask; - nid.u.uTimeout = data->u.uTimeout; + nid.uTimeout = data->u.uTimeout; nid.dwInfoFlags = data->dwInfoFlags; nid.guidItem = data->guidItem; lstrcpyW( nid.szTip, data->szTip ); @@ -589,7 +588,7 @@ static BOOL handle_incoming(HWND hwndSource, COPYDATASTRUCT *cds) case NIM_SETVERSION: if (icon) { - icon->version = nid.u.uVersion; + icon->version = nid.uVersion; ret = TRUE; } break;

1 0

Alexandre Julliard : conhost: Use nameless union/structs.
by Alexandre Julliard June 16, 2023

June 16, 2023

Module: wine Branch: master Commit: 2e58c9e0605b3846d50c6bb09f4274f9324746ac URL: https://gitlab.winehq.org/wine/wine/-/commit/2e58c9e0605b3846d50c6bb09f4274… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Jun 16 17:56:55 2023 +0200 conhost: Use nameless union/structs. --- programs/conhost/window.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/programs/conhost/window.c b/programs/conhost/window.c index 0d6036f07d7..043ecd5510f 100644 --- a/programs/conhost/window.c +++ b/programs/conhost/window.c @@ -17,7 +17,6 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA */ -#define NONAMELESSUNION #include <stdlib.h> #include "conhost.h" @@ -1924,15 +1923,15 @@ static BOOL config_dialog( struct console *console, BOOL current ) psp.hInstance = wndclass.hInstance; psp.lParam = (LPARAM)&di; - psp.u.pszTemplate = MAKEINTRESOURCEW(IDD_OPTION); + psp.pszTemplate = MAKEINTRESOURCEW(IDD_OPTION); psp.pfnDlgProc = option_dialog_proc; pages[0] = CreatePropertySheetPageW( &psp ); - psp.u.pszTemplate = MAKEINTRESOURCEW(IDD_FONT); + psp.pszTemplate = MAKEINTRESOURCEW(IDD_FONT); psp.pfnDlgProc = font_dialog_proc; pages[1] = CreatePropertySheetPageW( &psp ); - psp.u.pszTemplate = MAKEINTRESOURCEW(IDD_CONFIG); + psp.pszTemplate = MAKEINTRESOURCEW(IDD_CONFIG); psp.pfnDlgProc = config_dialog_proc; pages[2] = CreatePropertySheetPageW( &psp ); @@ -1947,7 +1946,7 @@ static BOOL config_dialog( struct console *console, BOOL current ) header.pszCaption = buff; header.nPages = 3; header.hwndParent = console->win; - header.u3.phpage = pages; + header.phpage = pages; header.dwFlags = PSH_NOAPPLYNOW; if (PropertySheetW( &header ) < 1) return TRUE;

1 0

Rémi Bernon : winegstreamer: Pass the stream descriptor to media_stream_create.
by Alexandre Julliard June 16, 2023

June 16, 2023

Module: wine Branch: master Commit: 330827a0112e15dbde92096e072ab3a090605d40 URL: https://gitlab.winehq.org/wine/wine/-/commit/330827a0112e15dbde92096e072ab3… Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Tue Jun 6 09:23:54 2023 +0200 winegstreamer: Pass the stream descriptor to media_stream_create. --- dlls/winegstreamer/media_source.c | 117 ++++++++++++++++++-------------------- 1 file changed, 55 insertions(+), 62 deletions(-) diff --git a/dlls/winegstreamer/media_source.c b/dlls/winegstreamer/media_source.c index de7094781f2..d404662e5bb 100644 --- a/dlls/winegstreamer/media_source.c +++ b/dlls/winegstreamer/media_source.c @@ -396,6 +396,49 @@ static HRESULT init_audio_media_types(struct wg_format *format, IMFMediaType *ty return S_OK; } +static HRESULT stream_descriptor_create(UINT32 id, struct wg_format *format, IMFStreamDescriptor **out) +{ + IMFStreamDescriptor *descriptor; + IMFMediaTypeHandler *handler; + IMFMediaType *types[6]; + DWORD count = 0; + HRESULT hr; + + if (!(types[0] = mf_media_type_from_wg_format(format))) + return MF_E_INVALIDMEDIATYPE; + count = 1; + + if (format->major_type == WG_MAJOR_TYPE_VIDEO) + { + if (FAILED(hr = init_video_media_types(format, types, &count))) + goto done; + } + else if (format->major_type == WG_MAJOR_TYPE_AUDIO) + { + if (FAILED(hr = init_audio_media_types(format, types, &count))) + goto done; + } + + assert(count <= ARRAY_SIZE(types)); + + if (FAILED(hr = MFCreateStreamDescriptor(id, count, types, &descriptor))) + goto done; + + if (FAILED(hr = IMFStreamDescriptor_GetMediaTypeHandler(descriptor, &handler))) + IMFStreamDescriptor_Release(descriptor); + else + { + hr = IMFMediaTypeHandler_SetCurrentMediaType(handler, types[0]); + IMFMediaTypeHandler_Release(handler); + } + +done: + while (count--) + IMFMediaType_Release(types[count]); + *out = SUCCEEDED(hr) ? descriptor : NULL; + return hr; +} + static BOOL enqueue_token(struct media_stream *stream, IUnknown *token) { if (stream->token_queue_count == stream->token_queue_cap) @@ -957,13 +1000,13 @@ static const IMFMediaStreamVtbl media_stream_vtbl = media_stream_RequestSample }; -static HRESULT media_stream_create(IMFMediaSource *source, DWORD id, +static HRESULT media_stream_create(IMFMediaSource *source, IMFStreamDescriptor *descriptor, struct wg_parser_stream *wg_stream, struct media_stream **out) { struct media_stream *object; HRESULT hr; - TRACE("source %p, id %lu, wg_stream %p.\n", source, id, wg_stream); + TRACE("source %p, descriptor %p, wg_stream %p.\n", source, descriptor, wg_stream); if (!(object = calloc(1, sizeof(*object)))) return E_OUTOFMEMORY; @@ -979,7 +1022,8 @@ static HRESULT media_stream_create(IMFMediaSource *source, DWORD id, IMFMediaSource_AddRef(source); object->media_source = source; - object->stream_id = id; + IMFStreamDescriptor_AddRef(descriptor); + object->descriptor = descriptor; object->active = TRUE; object->eos = FALSE; @@ -991,57 +1035,6 @@ static HRESULT media_stream_create(IMFMediaSource *source, DWORD id, return S_OK; } -static HRESULT media_stream_init_desc(struct media_stream *stream) -{ - IMFMediaTypeHandler *type_handler = NULL; - IMFMediaType *stream_types[6]; - struct wg_format format; - DWORD type_count = 0; - unsigned int i; - HRESULT hr; - - wg_parser_stream_get_preferred_format(stream->wg_stream, &format); - - if (!(stream_types[0] = mf_media_type_from_wg_format(&format))) - return MF_E_INVALIDMEDIATYPE; - type_count = 1; - - if (format.major_type == WG_MAJOR_TYPE_VIDEO) - { - if (FAILED(hr = init_video_media_types(&format, stream_types, &type_count))) - goto done; - } - else if (format.major_type == WG_MAJOR_TYPE_AUDIO) - { - if (FAILED(hr = init_audio_media_types(&format, stream_types, &type_count))) - goto done; - } - - assert(type_count <= ARRAY_SIZE(stream_types)); - - if (FAILED(hr = MFCreateStreamDescriptor(stream->stream_id, type_count, stream_types, &stream->descriptor))) - goto done; - - if (FAILED(hr = IMFStreamDescriptor_GetMediaTypeHandler(stream->descriptor, &type_handler))) - { - IMFStreamDescriptor_Release(stream->descriptor); - goto done; - } - - if (FAILED(hr = IMFMediaTypeHandler_SetCurrentMediaType(type_handler, stream_types[0]))) - { - IMFStreamDescriptor_Release(stream->descriptor); - goto done; - } - -done: - if (type_handler) - IMFMediaTypeHandler_Release(type_handler); - for (i = 0; i < type_count; i++) - IMFMediaType_Release(stream_types[i]); - return hr; -} - static HRESULT WINAPI media_source_get_service_QueryInterface(IMFGetService *iface, REFIID riid, void **obj) { struct media_source *source = impl_from_IMFGetService(iface); @@ -1600,22 +1593,22 @@ static HRESULT media_source_constructor(IMFByteStream *bytestream, struct media_ for (i = 0; i < stream_count; ++i) { struct wg_parser_stream *wg_stream = wg_parser_get_stream(object->wg_parser, i); + IMFStreamDescriptor *descriptor; struct media_stream *stream; + struct wg_format format; - if (FAILED(hr = media_stream_create(&object->IMFMediaSource_iface, i, wg_stream, &stream))) + wg_parser_stream_get_preferred_format(wg_stream, &format); + if (FAILED(hr = stream_descriptor_create(i, &format, &descriptor))) goto fail; - if (FAILED(hr = media_stream_init_desc(stream))) + if (FAILED(hr = media_stream_create(&object->IMFMediaSource_iface, descriptor, wg_stream, &stream))) { - ERR("Failed to finish initialization of media stream %p, hr %#lx.\n", stream, hr); - IMFMediaSource_Release(stream->media_source); - IMFMediaEventQueue_Release(stream->event_queue); - free(stream); + IMFStreamDescriptor_Release(descriptor); goto fail; } object->duration = max(object->duration, wg_parser_stream_get_duration(wg_stream)); - IMFStreamDescriptor_AddRef(stream->descriptor); - object->descriptors[i] = stream->descriptor; + IMFStreamDescriptor_AddRef(descriptor); + object->descriptors[i] = descriptor; object->streams[i] = stream; object->stream_count++; }

1 0

Rémi Bernon : winegstreamer: Pass a struct wg_parser_stream to media_stream_create.
by Alexandre Julliard June 16, 2023

June 16, 2023

Module: wine Branch: master Commit: 82b1cc3cbe61dd9ff7afacd1a3a2f74245ec3d3e URL: https://gitlab.winehq.org/wine/wine/-/commit/82b1cc3cbe61dd9ff7afacd1a3a2f7… Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Thu Jun 1 08:32:50 2023 +0200 winegstreamer: Pass a struct wg_parser_stream to media_stream_create. --- dlls/winegstreamer/media_source.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/dlls/winegstreamer/media_source.c b/dlls/winegstreamer/media_source.c index 9a061a43e3c..d4a08b84787 100644 --- a/dlls/winegstreamer/media_source.c +++ b/dlls/winegstreamer/media_source.c @@ -881,13 +881,12 @@ static const IMFMediaStreamVtbl media_stream_vtbl = }; static HRESULT media_stream_create(IMFMediaSource *source, DWORD id, - struct media_stream **out) + struct wg_parser_stream *wg_stream, struct media_stream **out) { - struct wg_parser *wg_parser = impl_from_IMFMediaSource(source)->wg_parser; struct media_stream *object; HRESULT hr; - TRACE("source %p, id %lu.\n", source, id); + TRACE("source %p, id %lu, wg_stream %p.\n", source, id, wg_stream); if (!(object = calloc(1, sizeof(*object)))) return E_OUTOFMEMORY; @@ -907,7 +906,7 @@ static HRESULT media_stream_create(IMFMediaSource *source, DWORD id, object->active = TRUE; object->eos = FALSE; - object->wg_stream = wg_parser_get_stream(wg_parser, id); + object->wg_stream = wg_stream; TRACE("Created stream object %p.\n", object); @@ -1599,9 +1598,10 @@ static HRESULT media_source_constructor(IMFByteStream *bytestream, struct media_ for (i = 0; i < stream_count; ++i) { + struct wg_parser_stream *wg_stream = wg_parser_get_stream(object->wg_parser, i); struct media_stream *stream; - if (FAILED(hr = media_stream_create(&object->IMFMediaSource_iface, i, &stream))) + if (FAILED(hr = media_stream_create(&object->IMFMediaSource_iface, i, wg_stream, &stream))) goto fail; if (FAILED(hr = media_stream_init_desc(stream))) { @@ -1612,7 +1612,7 @@ static HRESULT media_source_constructor(IMFByteStream *bytestream, struct media_ goto fail; } - object->duration = max(object->duration, wg_parser_stream_get_duration(stream->wg_stream)); + object->duration = max(object->duration, wg_parser_stream_get_duration(wg_stream)); IMFStreamDescriptor_AddRef(stream->descriptor); object->descriptors[i] = stream->descriptor; object->streams[i] = stream;

1 0

Alex Henrie : msi: Fix memory leaks in HANDLE_CustomType23 (scan-build).
by Alexandre Julliard June 16, 2023

June 16, 2023

Module: wine Branch: master Commit: 993f4d48d23477e70e92256890c77687a1c4ba08 URL: https://gitlab.winehq.org/wine/wine/-/commit/993f4d48d23477e70e92256890c776… Author: Alex Henrie <alexhenrie24(a)gmail.com> Date: Tue Jun 13 00:17:14 2023 -0600 msi: Fix memory leaks in HANDLE_CustomType23 (scan-build). --- dlls/msi/custom.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/dlls/msi/custom.c b/dlls/msi/custom.c index 8b020db260d..d1e064f5b65 100644 --- a/dlls/msi/custom.c +++ b/dlls/msi/custom.c @@ -1021,6 +1021,7 @@ static UINT HANDLE_CustomType23( MSIPACKAGE *package, const WCHAR *source, const if (!(args = build_msiexec_args( filename, target ))) { free( dir ); + free( filename ); return ERROR_OUTOFMEMORY; } @@ -1028,6 +1029,7 @@ static UINT HANDLE_CustomType23( MSIPACKAGE *package, const WCHAR *source, const handle = execute_command( L"msiexec", args, dir ); free( dir ); + free( filename ); free( args ); if (handle == INVALID_HANDLE_VALUE) return ERROR_SUCCESS; return wait_process_handle( package, type, handle, action );

1 0

Rémi Bernon : winegstreamer: Introduce new init_audio_media_types helper.
by Alexandre Julliard June 16, 2023

June 16, 2023

Module: wine Branch: master Commit: 43ea59fdf92b440178f61503664a21f63ac0b2f6 URL: https://gitlab.winehq.org/wine/wine/-/commit/43ea59fdf92b440178f61503664a21… Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Thu Jun 1 09:04:34 2023 +0200 winegstreamer: Introduce new init_audio_media_types helper. --- dlls/winegstreamer/media_source.c | 45 +++++++++++++++++++++++---------------- 1 file changed, 27 insertions(+), 18 deletions(-) diff --git a/dlls/winegstreamer/media_source.c b/dlls/winegstreamer/media_source.c index ea34eb22fcf..de7094781f2 100644 --- a/dlls/winegstreamer/media_source.c +++ b/dlls/winegstreamer/media_source.c @@ -371,6 +371,31 @@ done: return hr; } +static HRESULT init_audio_media_types(struct wg_format *format, IMFMediaType *types[6], DWORD *types_count) +{ + /* Expose at least one PCM and one floating point type for the + consumer to pick from. */ + static const enum wg_audio_format audio_types[] = + { + WG_AUDIO_FORMAT_S16LE, + WG_AUDIO_FORMAT_F32LE, + }; + UINT count = *types_count, i; + + for (i = 0; i < ARRAY_SIZE(audio_types); i++) + { + struct wg_format new_format = *format; + if (new_format.u.audio.format == audio_types[i]) + continue; + new_format.u.audio.format = audio_types[i]; + if ((types[count] = mf_media_type_from_wg_format(&new_format))) + count++; + } + + *types_count = count; + return S_OK; +} + static BOOL enqueue_token(struct media_stream *stream, IUnknown *token) { if (stream->token_queue_count == stream->token_queue_cap) @@ -988,24 +1013,8 @@ static HRESULT media_stream_init_desc(struct media_stream *stream) } else if (format.major_type == WG_MAJOR_TYPE_AUDIO) { - /* Expose at least one PCM and one floating point type for the - consumer to pick from. */ - static const enum wg_audio_format audio_types[] = - { - WG_AUDIO_FORMAT_S16LE, - WG_AUDIO_FORMAT_F32LE, - }; - - for (i = 0; i < ARRAY_SIZE(audio_types); i++) - { - struct wg_format new_format; - if (format.u.audio.format == audio_types[i]) - continue; - new_format = format; - new_format.u.audio.format = audio_types[i]; - if ((stream_types[type_count] = mf_media_type_from_wg_format(&new_format))) - type_count++; - } + if (FAILED(hr = init_audio_media_types(&format, stream_types, &type_count))) + goto done; } assert(type_count <= ARRAY_SIZE(stream_types));

1 0

Rémi Bernon : winegstreamer: Factor the creation of the first stream media type.
by Alexandre Julliard June 16, 2023

June 16, 2023

Module: wine Branch: master Commit: b0ecfc96df7488d401e9e0a115ff03f8ff83e740 URL: https://gitlab.winehq.org/wine/wine/-/commit/b0ecfc96df7488d401e9e0a115ff03… Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Thu Jun 1 08:58:45 2023 +0200 winegstreamer: Factor the creation of the first stream media type. --- dlls/winegstreamer/media_source.c | 31 +++++-------------------------- 1 file changed, 5 insertions(+), 26 deletions(-) diff --git a/dlls/winegstreamer/media_source.c b/dlls/winegstreamer/media_source.c index d4a08b84787..97c1599b7ca 100644 --- a/dlls/winegstreamer/media_source.c +++ b/dlls/winegstreamer/media_source.c @@ -925,6 +925,10 @@ static HRESULT media_stream_init_desc(struct media_stream *stream) wg_parser_stream_get_preferred_format(stream->wg_stream, &format); + if (!(stream_types[0] = mf_media_type_from_wg_format(&format))) + return MF_E_INVALIDMEDIATYPE; + type_count = 1; + if (format.major_type == WG_MAJOR_TYPE_VIDEO) { /* Try to prefer YUV formats over RGB ones. Most decoders output in the @@ -937,20 +941,9 @@ static HRESULT media_stream_init_desc(struct media_stream *stream) WG_VIDEO_FORMAT_YUY2, WG_VIDEO_FORMAT_I420, }; - - IMFMediaType *base_type = mf_media_type_from_wg_format(&format); GUID base_subtype; - if (!base_type) - { - hr = MF_E_INVALIDMEDIATYPE; - goto done; - } - - IMFMediaType_GetGUID(base_type, &MF_MT_SUBTYPE, &base_subtype); - - stream_types[0] = base_type; - type_count = 1; + IMFMediaType_GetGUID(stream_types[0], &MF_MT_SUBTYPE, &base_subtype); for (i = 0; i < ARRAY_SIZE(video_formats); ++i) { @@ -990,9 +983,6 @@ static HRESULT media_stream_init_desc(struct media_stream *stream) WG_AUDIO_FORMAT_F32LE, }; - if ((stream_types[0] = mf_media_type_from_wg_format(&format))) - type_count = 1; - for (i = 0; i < ARRAY_SIZE(audio_types); i++) { struct wg_format new_format; @@ -1004,20 +994,9 @@ static HRESULT media_stream_init_desc(struct media_stream *stream) type_count++; } } - else - { - if ((stream_types[0] = mf_media_type_from_wg_format(&format))) - type_count = 1; - } assert(type_count <= ARRAY_SIZE(stream_types)); - if (!type_count) - { - ERR("Failed to establish an IMFMediaType from any of the possible stream caps!\n"); - return E_FAIL; - } - if (FAILED(hr = MFCreateStreamDescriptor(stream->stream_id, type_count, stream_types, &stream->descriptor))) goto done;

1 0

Rémi Bernon : winegstreamer: Introduce new init_video_media_types helper.
by Alexandre Julliard June 16, 2023

June 16, 2023

Module: wine Branch: master Commit: 3a603357bcc83908ef22f0bed8f5990b1527fcd3 URL: https://gitlab.winehq.org/wine/wine/-/commit/3a603357bcc83908ef22f0bed8f599… Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Thu Jun 1 09:04:12 2023 +0200 winegstreamer: Introduce new init_video_media_types helper. --- dlls/winegstreamer/media_source.c | 95 ++++++++++++++++++++++----------------- 1 file changed, 54 insertions(+), 41 deletions(-) diff --git a/dlls/winegstreamer/media_source.c b/dlls/winegstreamer/media_source.c index 97c1599b7ca..ea34eb22fcf 100644 --- a/dlls/winegstreamer/media_source.c +++ b/dlls/winegstreamer/media_source.c @@ -319,6 +319,58 @@ static HRESULT stream_descriptor_set_tag(IMFStreamDescriptor *descriptor, struct return hr; } +static HRESULT init_video_media_types(struct wg_format *format, IMFMediaType *types[6], DWORD *types_count) +{ + /* Try to prefer YUV formats over RGB ones. Most decoders output in the + * YUV color space, and it's generally much less expensive for + * videoconvert to do YUV -> YUV transformations. */ + static const enum wg_video_format video_formats[] = + { + WG_VIDEO_FORMAT_NV12, + WG_VIDEO_FORMAT_YV12, + WG_VIDEO_FORMAT_YUY2, + WG_VIDEO_FORMAT_I420, + }; + UINT count = *types_count, i; + GUID base_subtype; + HRESULT hr; + + if (FAILED(hr = IMFMediaType_GetGUID(types[0], &MF_MT_SUBTYPE, &base_subtype))) + return hr; + + for (i = 0; i < ARRAY_SIZE(video_formats); ++i) + { + struct wg_format new_format = *format; + IMFMediaType *new_type; + + new_format.u.video.format = video_formats[i]; + + if (!(new_type = mf_media_type_from_wg_format(&new_format))) + { + hr = E_OUTOFMEMORY; + goto done; + } + types[count++] = new_type; + + if (video_formats[i] == WG_VIDEO_FORMAT_I420) + { + IMFMediaType *iyuv_type; + + if (FAILED(hr = MFCreateMediaType(&iyuv_type))) + goto done; + if (FAILED(hr = IMFMediaType_CopyAllItems(new_type, (IMFAttributes *)iyuv_type))) + goto done; + if (FAILED(hr = IMFMediaType_SetGUID(iyuv_type, &MF_MT_SUBTYPE, &MFVideoFormat_IYUV))) + goto done; + types[count++] = iyuv_type; + } + } + +done: + *types_count = count; + return hr; +} + static BOOL enqueue_token(struct media_stream *stream, IUnknown *token) { if (stream->token_queue_count == stream->token_queue_cap) @@ -931,47 +983,8 @@ static HRESULT media_stream_init_desc(struct media_stream *stream) if (format.major_type == WG_MAJOR_TYPE_VIDEO) { - /* Try to prefer YUV formats over RGB ones. Most decoders output in the - * YUV color space, and it's generally much less expensive for - * videoconvert to do YUV -> YUV transformations. */ - static const enum wg_video_format video_formats[] = - { - WG_VIDEO_FORMAT_NV12, - WG_VIDEO_FORMAT_YV12, - WG_VIDEO_FORMAT_YUY2, - WG_VIDEO_FORMAT_I420, - }; - GUID base_subtype; - - IMFMediaType_GetGUID(stream_types[0], &MF_MT_SUBTYPE, &base_subtype); - - for (i = 0; i < ARRAY_SIZE(video_formats); ++i) - { - struct wg_format new_format = format; - IMFMediaType *new_type; - - new_format.u.video.format = video_formats[i]; - - if (!(new_type = mf_media_type_from_wg_format(&new_format))) - { - hr = E_OUTOFMEMORY; - goto done; - } - stream_types[type_count++] = new_type; - - if (video_formats[i] == WG_VIDEO_FORMAT_I420) - { - IMFMediaType *iyuv_type; - - if (FAILED(hr = MFCreateMediaType(&iyuv_type))) - goto done; - if (FAILED(hr = IMFMediaType_CopyAllItems(new_type, (IMFAttributes *)iyuv_type))) - goto done; - if (FAILED(hr = IMFMediaType_SetGUID(iyuv_type, &MF_MT_SUBTYPE, &MFVideoFormat_IYUV))) - goto done; - stream_types[type_count++] = iyuv_type; - } - } + if (FAILED(hr = init_video_media_types(&format, stream_types, &type_count))) + goto done; } else if (format.major_type == WG_MAJOR_TYPE_AUDIO) {

1 0