March 2024 - Wine-Commits - list.winehq.org

Rémi Bernon : winevulkan: Introduce a new get_host_surface_extension driver entry.
by Alexandre Julliard March 28, 2024

March 28, 2024

Module: wine Branch: master Commit: c7da2450c9d05a4957bf9f2d42990826f26dff6f URL: https://gitlab.winehq.org/wine/wine/-/commit/c7da2450c9d05a4957bf9f2d429908… Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Sat Feb 24 12:38:06 2024 +0100 winevulkan: Introduce a new get_host_surface_extension driver entry. --- dlls/winemac.drv/vulkan.c | 6 ++++++ dlls/winevulkan/vulkan.c | 28 ++++++++++++++++++---------- dlls/winewayland.drv/vulkan.c | 6 ++++++ dlls/winex11.drv/vulkan.c | 6 ++++++ include/wine/vulkan_driver.h | 1 + 5 files changed, 37 insertions(+), 10 deletions(-) diff --git a/dlls/winemac.drv/vulkan.c b/dlls/winemac.drv/vulkan.c index e76422280af..63c4896e54d 100644 --- a/dlls/winemac.drv/vulkan.c +++ b/dlls/winemac.drv/vulkan.c @@ -361,6 +361,11 @@ static VkResult macdrv_vkQueuePresentKHR(VkQueue queue, const VkPresentInfoKHR * return res; } +static const char *macdrv_get_host_surface_extension(void) +{ + return pvkCreateMetalSurfaceEXT ? "VK_EXT_metal_surface" : "VK_MVK_macos_surface"; +} + static VkSurfaceKHR macdrv_wine_get_host_surface(VkSurfaceKHR surface) { struct wine_vk_surface *mac_surface = surface_from_handle(surface); @@ -384,6 +389,7 @@ static const struct vulkan_funcs vulkan_funcs = macdrv_vkGetSwapchainImagesKHR, macdrv_vkQueuePresentKHR, + macdrv_get_host_surface_extension, macdrv_wine_get_host_surface, }; diff --git a/dlls/winevulkan/vulkan.c b/dlls/winevulkan/vulkan.c index fd1d2006318..8a022195ec2 100644 --- a/dlls/winevulkan/vulkan.c +++ b/dlls/winevulkan/vulkan.c @@ -571,6 +571,7 @@ static VkResult wine_vk_instance_convert_create_info(struct conversion_context * { VkDebugUtilsMessengerCreateInfoEXT *debug_utils_messenger; VkDebugReportCallbackCreateInfoEXT *debug_report_callback; + const char **new_extensions; VkBaseInStructure *header; unsigned int i; @@ -614,39 +615,46 @@ static VkResult wine_vk_instance_convert_create_info(struct conversion_context * return VK_ERROR_LAYER_NOT_PRESENT; } - TRACE("Enabled %u instance extensions.\n", dst->enabledExtensionCount); - for (i = 0; i < dst->enabledExtensionCount; i++) + for (i = 0; i < src->enabledExtensionCount; i++) { - const char *extension_name = dst->ppEnabledExtensionNames[i]; + const char *extension_name = src->ppEnabledExtensionNames[i]; TRACE("Extension %u: %s.\n", i, debugstr_a(extension_name)); if (!wine_vk_instance_extension_supported(extension_name)) { WARN("Extension %s is not supported.\n", debugstr_a(extension_name)); return VK_ERROR_EXTENSION_NOT_PRESENT; } + } + + new_extensions = conversion_context_alloc(ctx, (src->enabledExtensionCount + 2) * + sizeof(*src->ppEnabledExtensionNames)); + memcpy(new_extensions, src->ppEnabledExtensionNames, + dst->enabledExtensionCount * sizeof(*dst->ppEnabledExtensionNames)); + dst->ppEnabledExtensionNames = new_extensions; + dst->enabledExtensionCount = src->enabledExtensionCount; + + for (i = 0; i < dst->enabledExtensionCount; i++) + { + const char *extension_name = dst->ppEnabledExtensionNames[i]; if (!strcmp(extension_name, "VK_EXT_debug_utils") || !strcmp(extension_name, "VK_EXT_debug_report")) { object->enable_wrapper_list = VK_TRUE; } if (!strcmp(extension_name, "VK_KHR_win32_surface")) { + new_extensions[i] = vk_funcs->p_get_host_surface_extension(); object->enable_win32_surface = VK_TRUE; } } if (use_external_memory()) { - const char **new_extensions; - - new_extensions = conversion_context_alloc(ctx, (dst->enabledExtensionCount + 2) * - sizeof(*dst->ppEnabledExtensionNames)); - memcpy(new_extensions, src->ppEnabledExtensionNames, - dst->enabledExtensionCount * sizeof(*dst->ppEnabledExtensionNames)); new_extensions[dst->enabledExtensionCount++] = "VK_KHR_get_physical_device_properties2"; new_extensions[dst->enabledExtensionCount++] = "VK_KHR_external_memory_capabilities"; - dst->ppEnabledExtensionNames = new_extensions; } + TRACE("Enabled %u instance extensions.\n", dst->enabledExtensionCount); + return VK_SUCCESS; } diff --git a/dlls/winewayland.drv/vulkan.c b/dlls/winewayland.drv/vulkan.c index c7cbdc90e28..6bac804a118 100644 --- a/dlls/winewayland.drv/vulkan.c +++ b/dlls/winewayland.drv/vulkan.c @@ -469,6 +469,11 @@ static VkResult wayland_vkQueuePresentKHR(VkQueue queue, const VkPresentInfoKHR return check_queue_present(present_info, res); } +static const char *wayland_get_host_surface_extension(void) +{ + return "VK_KHR_wayland_surface"; +} + static VkSurfaceKHR wayland_wine_get_host_surface(VkSurfaceKHR surface) { return wine_vk_surface_from_handle(surface)->host_surface; @@ -485,6 +490,7 @@ static const struct vulkan_funcs vulkan_funcs = .p_vkGetPhysicalDeviceWin32PresentationSupportKHR = wayland_vkGetPhysicalDeviceWin32PresentationSupportKHR, .p_vkGetSwapchainImagesKHR = wayland_vkGetSwapchainImagesKHR, .p_vkQueuePresentKHR = wayland_vkQueuePresentKHR, + .p_get_host_surface_extension = wayland_get_host_surface_extension, .p_wine_get_host_surface = wayland_wine_get_host_surface, }; diff --git a/dlls/winex11.drv/vulkan.c b/dlls/winex11.drv/vulkan.c index 6216a7eb5e8..31bfdb98f86 100644 --- a/dlls/winex11.drv/vulkan.c +++ b/dlls/winex11.drv/vulkan.c @@ -396,6 +396,11 @@ static VkResult X11DRV_vkQueuePresentKHR(VkQueue queue, const VkPresentInfoKHR * return res; } +static const char *X11DRV_get_host_surface_extension(void) +{ + return "VK_KHR_xlib_surface"; +} + static VkSurfaceKHR X11DRV_wine_get_host_surface( VkSurfaceKHR surface ) { struct wine_vk_surface *x11_surface = surface_from_handle(surface); @@ -419,6 +424,7 @@ static const struct vulkan_funcs vulkan_funcs = X11DRV_vkGetSwapchainImagesKHR, X11DRV_vkQueuePresentKHR, + X11DRV_get_host_surface_extension, X11DRV_wine_get_host_surface, }; diff --git a/include/wine/vulkan_driver.h b/include/wine/vulkan_driver.h index 495331e397d..cd76dcbbcc2 100644 --- a/include/wine/vulkan_driver.h +++ b/include/wine/vulkan_driver.h @@ -42,6 +42,7 @@ struct vulkan_funcs VkResult (*p_vkQueuePresentKHR)(VkQueue, const VkPresentInfoKHR *); /* winevulkan specific functions */ + const char *(*p_get_host_surface_extension)(void); VkSurfaceKHR (*p_wine_get_host_surface)(VkSurfaceKHR); };

1 0

Rémi Bernon : winevulkan: Remove now unnecessary vkEnumerateInstanceExtensionProperties driver entry.
by Alexandre Julliard March 28, 2024

March 28, 2024

Module: wine Branch: master Commit: 5db24dbb326cf77aed3c42aff87c1a123447050a URL: https://gitlab.winehq.org/wine/wine/-/commit/5db24dbb326cf77aed3c42aff87c1a… Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Sat Feb 24 12:37:32 2024 +0100 winevulkan: Remove now unnecessary vkEnumerateInstanceExtensionProperties driver entry. --- dlls/win32u/vulkan.c | 1 - dlls/winemac.drv/vulkan.c | 56 ------------------------------------------- dlls/winevulkan/make_vulkan | 6 ----- dlls/winevulkan/vulkan.c | 14 ++++++----- dlls/winewayland.drv/vulkan.c | 45 ---------------------------------- dlls/winex11.drv/vulkan.c | 44 ---------------------------------- include/wine/vulkan_driver.h | 3 +-- 7 files changed, 9 insertions(+), 160 deletions(-)

1 0

Rémi Bernon : winevulkan: Strip surface extensions in vkEnumerateInstanceExtensionProperties.
by Alexandre Julliard March 28, 2024

March 28, 2024

Module: wine Branch: master Commit: e4e0ce2bc69f49dd9d08f6a412ae941f0e3fd35d URL: https://gitlab.winehq.org/wine/wine/-/commit/e4e0ce2bc69f49dd9d08f6a412ae94… Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Sat Feb 24 08:11:38 2024 +0100 winevulkan: Strip surface extensions in vkEnumerateInstanceExtensionProperties. --- dlls/winevulkan/make_vulkan | 28 ++++++++++++++++++++++++++++ dlls/winevulkan/vulkan.c | 15 +++++++++++---- dlls/winevulkan/vulkan_private.h | 1 + dlls/winevulkan/vulkan_thunks.c | 28 ++++++++++++++++++++++++++++ 4 files changed, 68 insertions(+), 4 deletions(-) diff --git a/dlls/winevulkan/make_vulkan b/dlls/winevulkan/make_vulkan index 809591b3c97..1455247870f 100755 --- a/dlls/winevulkan/make_vulkan +++ b/dlls/winevulkan/make_vulkan @@ -144,6 +144,12 @@ CORE_EXTENSIONS = [ "VK_KHR_win32_surface", ] +# List of surface extensions that can be exposed directly to the PE side +WIN_SURFACE_EXTENSIONS = [ + "VK_KHR_win32_surface", + "VK_EXT_headless_surface", +] + # Some experimental extensions are used by shipping applications so their API is extremely unlikely # to change in a backwards-incompatible way. Allow translation of those extensions with WineVulkan. ALLOWED_X_EXTENSIONS = [ @@ -2771,6 +2777,13 @@ class VkGenerator(object): f.write(" \"{0}\",\n".format(ext["name"])) f.write("};\n\n") + # Create array of surface extensions. + f.write("static const char * const vk_host_surface_extensions[] =\n{\n") + for ext in self.registry.surface_extensions: + if ext["name"] not in WIN_SURFACE_EXTENSIONS: + f.write(" \"{0}\",\n".format(ext["name"])) + f.write("};\n\n") + f.write("BOOL wine_vk_device_extension_supported(const char *name)\n") f.write("{\n") f.write(" unsigned int i;\n") @@ -2793,6 +2806,17 @@ class VkGenerator(object): f.write(" return FALSE;\n") f.write("}\n\n") + f.write("BOOL wine_vk_is_host_surface_extension(const char *name)\n") + f.write("{\n") + f.write(" unsigned int i;\n") + f.write(" for (i = 0; i < ARRAY_SIZE(vk_host_surface_extensions); i++)\n") + f.write(" {\n") + f.write(" if (strcmp(vk_host_surface_extensions[i], name) == 0)\n") + f.write(" return TRUE;\n") + f.write(" }\n") + f.write(" return FALSE;\n") + f.write("}\n\n") + f.write("BOOL wine_vk_is_type_wrapped(VkObjectType type)\n") f.write("{\n") f.write(" return FALSE") @@ -3194,6 +3218,7 @@ class VkRegistry(object): # We aggregate all types in here for cross-referencing. self.funcs = {} self.types = {} + self.surface_extensions = [] self.version_regex = re.compile( r'^' @@ -3471,6 +3496,9 @@ class VkRegistry(object): def process_ext(ext, deferred=False): ext_name = ext.attrib["name"] + if ext_name.endswith('_surface') and ext.attrib.get('depends', None) == 'VK_KHR_surface': + self.surface_extensions.append({"name" : ext_name}) + # Set extension name on any functions calls part of this extension as we # were not aware of the name during initial parsing. commands = ext.findall("require/command") diff --git a/dlls/winevulkan/vulkan.c b/dlls/winevulkan/vulkan.c index 0846f2dfc73..7b91202b961 100644 --- a/dlls/winevulkan/vulkan.c +++ b/dlls/winevulkan/vulkan.c @@ -1003,7 +1003,7 @@ VkResult wine_vkEnumerateInstanceExtensionProperties(const char *name, uint32_t { uint32_t num_properties = 0, num_host_properties; VkExtensionProperties *host_properties; - unsigned int i, j; + unsigned int i, j, surface; VkResult res; res = vk_funcs->p_vkEnumerateInstanceExtensionProperties(NULL, &num_host_properties, NULL); @@ -1025,9 +1025,10 @@ VkResult wine_vkEnumerateInstanceExtensionProperties(const char *name, uint32_t * including extension fixup (e.g. VK_KHR_xlib_surface -> VK_KHR_win32_surface). It is * up to us here to filter the list down to extensions for which we have thunks. */ - for (i = 0; i < num_host_properties; i++) + for (i = 0, surface = 0; i < num_host_properties; i++) { - if (wine_vk_instance_extension_supported(host_properties[i].extensionName)) + if (wine_vk_instance_extension_supported(host_properties[i].extensionName) + || (wine_vk_is_host_surface_extension(host_properties[i].extensionName) && !surface++)) num_properties++; else TRACE("Instance extension '%s' is not supported.\n", host_properties[i].extensionName); @@ -1041,13 +1042,19 @@ VkResult wine_vkEnumerateInstanceExtensionProperties(const char *name, uint32_t return VK_SUCCESS; } - for (i = 0, j = 0; i < num_host_properties && j < *count; i++) + for (i = 0, j = 0, surface = 0; i < num_host_properties && j < *count; i++) { if (wine_vk_instance_extension_supported(host_properties[i].extensionName)) { TRACE("Enabling extension '%s'.\n", host_properties[i].extensionName); properties[j++] = host_properties[i]; } + else if (wine_vk_is_host_surface_extension(host_properties[i].extensionName) && !surface++) + { + VkExtensionProperties win32_surface = {VK_KHR_WIN32_SURFACE_EXTENSION_NAME, VK_KHR_WIN32_SURFACE_SPEC_VERSION}; + TRACE("Enabling VK_KHR_win32_surface.\n"); + properties[j++] = win32_surface; + } } *count = min(*count, num_properties); diff --git a/dlls/winevulkan/vulkan_private.h b/dlls/winevulkan/vulkan_private.h index b44285722a7..f5109aa6377 100644 --- a/dlls/winevulkan/vulkan_private.h +++ b/dlls/winevulkan/vulkan_private.h @@ -270,6 +270,7 @@ static inline VkSwapchainKHR wine_swapchain_to_handle(struct wine_swapchain *sur BOOL wine_vk_device_extension_supported(const char *name); BOOL wine_vk_instance_extension_supported(const char *name); +BOOL wine_vk_is_host_surface_extension(const char *name); BOOL wine_vk_is_type_wrapped(VkObjectType type); diff --git a/dlls/winevulkan/vulkan_thunks.c b/dlls/winevulkan/vulkan_thunks.c index 93e52b46a9d..9075b5ff11f 100644 --- a/dlls/winevulkan/vulkan_thunks.c +++ b/dlls/winevulkan/vulkan_thunks.c @@ -46749,6 +46749,23 @@ static const char * const vk_instance_extensions[] = "VK_KHR_win32_surface", }; +static const char * const vk_host_surface_extensions[] = +{ + "VK_KHR_xlib_surface", + "VK_KHR_xcb_surface", + "VK_KHR_wayland_surface", + "VK_KHR_mir_surface", + "VK_KHR_android_surface", + "VK_GGP_stream_descriptor_surface", + "VK_NN_vi_surface", + "VK_MVK_ios_surface", + "VK_MVK_macos_surface", + "VK_FUCHSIA_imagepipe_surface", + "VK_EXT_metal_surface", + "VK_EXT_directfb_surface", + "VK_QNX_screen_surface", +}; + BOOL wine_vk_device_extension_supported(const char *name) { unsigned int i; @@ -46771,6 +46788,17 @@ BOOL wine_vk_instance_extension_supported(const char *name) return FALSE; } +BOOL wine_vk_is_host_surface_extension(const char *name) +{ + unsigned int i; + for (i = 0; i < ARRAY_SIZE(vk_host_surface_extensions); i++) + { + if (strcmp(vk_host_surface_extensions[i], name) == 0) + return TRUE; + } + return FALSE; +} + BOOL wine_vk_is_type_wrapped(VkObjectType type) { return FALSE ||

1 0

Rémi Bernon : win32u: Use named adapters instead of struct gdi_adapter.
by Alexandre Julliard March 28, 2024

March 28, 2024

Module: wine Branch: master Commit: fecfb442405011f123d2458aac7c42d9f1a28330 URL: https://gitlab.winehq.org/wine/wine/-/commit/fecfb442405011f123d2458aac7c42… Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Wed Mar 27 08:57:10 2024 +0100 win32u: Use named adapters instead of struct gdi_adapter. --- dlls/win32u/sysparams.c | 39 +++++++++++++++------------------------ dlls/wineandroid.drv/init.c | 7 ++----- dlls/winemac.drv/display.c | 10 ++++------ dlls/winewayland.drv/display.c | 21 +++++++-------------- dlls/winex11.drv/display.c | 7 ++++--- dlls/winex11.drv/x11drv.h | 10 ++++++++-- dlls/winex11.drv/xinerama.c | 8 ++++---- dlls/winex11.drv/xrandr.c | 10 +++++----- include/wine/gdi_driver.h | 8 +------- 9 files changed, 50 insertions(+), 70 deletions(-)

1 0

Paul Gofman : ddraw: Don't demand WINED3D_BIND_SHADER_RESOURCE for making surface in vidmem.
by Alexandre Julliard March 28, 2024

March 28, 2024

Module: wine Branch: master Commit: 11949950509a8cc569f1c28e39d6bdcda52eb5d1 URL: https://gitlab.winehq.org/wine/wine/-/commit/11949950509a8cc569f1c28e39d6bd… Author: Paul Gofman <pgofman(a)codeweavers.com> Date: Thu Mar 21 17:45:47 2024 -0600 ddraw: Don't demand WINED3D_BIND_SHADER_RESOURCE for making surface in vidmem. --- dlls/ddraw/surface.c | 10 +++++++++- dlls/ddraw/tests/ddraw1.c | 40 ++++++++++++++++++++++++++++++++++++++++ dlls/ddraw/tests/ddraw2.c | 46 ++++++++++++++++++++++++++++++++++++++++++++++ dlls/ddraw/tests/ddraw4.c | 47 +++++++++++++++++++++++++++++++++++++++++++++++ dlls/ddraw/tests/ddraw7.c | 47 +++++++++++++++++++++++++++++++++++++++++++++++ dlls/quartz/tests/vmr7.c | 6 ++++-- 6 files changed, 193 insertions(+), 3 deletions(-)

1 0

Rémi Bernon : win32u: Rename struct adapter to struct source.
by Alexandre Julliard March 28, 2024

March 28, 2024

Module: wine Branch: master Commit: c635a25f216552034055d4f56aee0804c8d5f39f URL: https://gitlab.winehq.org/wine/wine/-/commit/c635a25f216552034055d4f56aee08… Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Tue Feb 27 17:45:29 2024 +0100 win32u: Rename struct adapter to struct source. To match the D3DKMT terminology and avoid confusion between the GPUs, which are called adapter there. --- dlls/win32u/sysparams.c | 476 ++++++++++++++++++++--------------------- dlls/wineandroid.drv/init.c | 2 +- dlls/winemac.drv/display.c | 2 +- dlls/winewayland.drv/display.c | 6 +- dlls/winex11.drv/display.c | 2 +- include/wine/gdi_driver.h | 2 +- 6 files changed, 244 insertions(+), 246 deletions(-)

1 0

Rémi Bernon : win32u: Use a symlink for the logically indexed adapter config key.
by Alexandre Julliard March 28, 2024

March 28, 2024

Module: wine Branch: master Commit: 00a0c97879e986616bacf79c99cb7b8b6dd7b007 URL: https://gitlab.winehq.org/wine/wine/-/commit/00a0c97879e986616bacf79c99cb7b… Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Tue Feb 27 17:20:12 2024 +0100 win32u: Use a symlink for the logically indexed adapter config key. Linking it to what will be a physically identified adapter config key. --- dlls/win32u/sysparams.c | 44 ++++++++++++++++++++++++-------------------- 1 file changed, 24 insertions(+), 20 deletions(-) diff --git a/dlls/win32u/sysparams.c b/dlls/win32u/sysparams.c index 66c68e23d10..15c4af1d07a 100644 --- a/dlls/win32u/sysparams.c +++ b/dlls/win32u/sysparams.c @@ -109,10 +109,10 @@ struct adapter { LONG refcount; struct list entry; + char path[MAX_PATH]; unsigned int id; struct gpu *gpu; UINT state_flags; - WCHAR config_key[MAX_PATH]; UINT monitor_count; UINT mode_count; DEVMODEW *modes; @@ -447,7 +447,7 @@ static BOOL adapter_get_registry_settings( const struct adapter *adapter, DEVMOD mutex = get_display_device_init_mutex(); - if (!(hkey = reg_open_key( config_key, adapter->config_key, lstrlenW( adapter->config_key ) * sizeof(WCHAR) ))) ret = FALSE; + if (!(hkey = reg_open_ascii_key( config_key, adapter->path ))) ret = FALSE; else { ret = read_adapter_mode( hkey, ENUM_REGISTRY_SETTINGS, mode ); @@ -466,7 +466,7 @@ static BOOL adapter_set_registry_settings( const struct adapter *adapter, const mutex = get_display_device_init_mutex(); - if (!(hkey = reg_open_key( config_key, adapter->config_key, lstrlenW( adapter->config_key ) * sizeof(WCHAR) ))) ret = FALSE; + if (!(hkey = reg_open_ascii_key( config_key, adapter->path ))) ret = FALSE; else { ret = write_adapter_mode( hkey, ENUM_REGISTRY_SETTINGS, mode ); @@ -499,7 +499,7 @@ static BOOL adapter_get_current_settings( const struct adapter *adapter, DEVMODE mutex = get_display_device_init_mutex(); - if (!(hkey = reg_open_key( config_key, adapter->config_key, lstrlenW( adapter->config_key ) * sizeof(WCHAR) ))) ret = FALSE; + if (!(hkey = reg_open_ascii_key( config_key, adapter->path ))) ret = FALSE; else { ret = read_adapter_mode( hkey, ENUM_CURRENT_SETTINGS, mode ); @@ -518,7 +518,7 @@ static BOOL adapter_set_current_settings( const struct adapter *adapter, const D mutex = get_display_device_init_mutex(); - if (!(hkey = reg_open_key( config_key, adapter->config_key, lstrlenW( adapter->config_key ) * sizeof(WCHAR) ))) ret = FALSE; + if (!(hkey = reg_open_ascii_key( config_key, adapter->path ))) ret = FALSE; else { ret = write_adapter_mode( hkey, ENUM_CURRENT_SETTINGS, mode ); @@ -618,17 +618,13 @@ static BOOL read_display_adapter_settings( unsigned int index, struct adapter *i /* Find adapter */ sprintf( buffer, "\\Device\\Video%d", index ); size = query_reg_ascii_value( video_key, buffer, value, sizeof(buffer) ); - if (!size || value->Type != REG_SZ || - value->DataLength <= sizeof("\\Registry\\Machine\\") * sizeof(WCHAR)) - return FALSE; + if (!size || value->Type != REG_SZ) return FALSE; /* DeviceKey */ - size = sizeof("\\Registry\\Machine\\") - 1; - memcpy( info->config_key, value_str + size, value->DataLength - size ); - - if (!(hkey = reg_open_key( config_key, info->config_key, - lstrlenW( info->config_key ) * sizeof(WCHAR) ))) - return FALSE; + size = sizeof("\\Registry\\Machine"); + if (value->DataLength / sizeof(WCHAR) <= size) return FALSE; + for (i = 0; i < value->DataLength / sizeof(WCHAR) - size; i++) info->path[i] = value_str[size + i]; + if (!(hkey = reg_open_ascii_key( config_key, info->path ))) return FALSE; /* StateFlags */ if (query_reg_ascii_value( hkey, "StateFlags", value, sizeof(buffer) ) && value->Type == REG_DWORD) @@ -1282,13 +1278,19 @@ static BOOL write_adapter_to_registry( const struct adapter *adapter, HKEY *adap NtClose( hkey ); /* Following information is Wine specific, it doesn't really exist on Windows. */ - sprintf( buffer, "System\\CurrentControlSet\\Control\\Video\\%s\\%04x", gpu->guid, adapter_index ); - *adapter_key = reg_create_ascii_key( config_key, buffer, REG_OPTION_VOLATILE, NULL ); - + *adapter_key = reg_create_ascii_key( NULL, adapter->path, REG_OPTION_VOLATILE, NULL ); set_reg_ascii_value( *adapter_key, "GPUID", gpu->path ); set_reg_value( *adapter_key, state_flagsW, REG_DWORD, &adapter->state_flags, sizeof(adapter->state_flags) ); + sprintf( buffer, "System\\CurrentControlSet\\Control\\Video\\%s\\%04x", gpu->guid, adapter_index ); + hkey = reg_create_ascii_key( config_key, buffer, REG_OPTION_VOLATILE | REG_OPTION_CREATE_LINK, NULL ); + if (!hkey) hkey = reg_create_ascii_key( config_key, buffer, REG_OPTION_VOLATILE | REG_OPTION_OPEN_LINK, NULL ); + + len = asciiz_to_unicode( bufferW, adapter->path ) - sizeof(WCHAR); + set_reg_value( hkey, symbolic_link_valueW, REG_LINK, bufferW, len ); + NtClose( hkey ); + return TRUE; } @@ -1309,6 +1311,10 @@ static void add_adapter( const struct gdi_adapter *adapter, void *param ) ctx->adapter.id = ctx->adapter_count; ctx->adapter.state_flags = adapter->state_flags; + /* Wine specific config key where adapter settings will be held, symlinked with the logically indexed config key */ + sprintf( ctx->adapter.path, "%s\\%s\\Video\\%s\\Adapters\\%04x", config_keyA, + control_keyA + strlen( "\\Registry\\Machine" ), ctx->gpu.guid, ctx->gpu.adapter_count ); + if (!write_adapter_to_registry( &ctx->adapter, &ctx->adapter_key )) WARN( "Failed to write adapter to registry\n" ); else @@ -1695,9 +1701,7 @@ static BOOL update_display_cache_from_registry(void) } list_add_tail( &adapters, &adapter->entry ); - - size = lstrlenW( adapter->config_key ) * sizeof(WCHAR); - if (!(hkey = reg_open_key( config_key, adapter->config_key, size ))) continue; + if (!(hkey = reg_open_ascii_key( config_key, adapter->path ))) continue; for (monitor_id = 0;; monitor_id++) {

1 0

Piotr Caban : gdi32: Implicitly call StartPage in ExtEscape on printer DC.
by Alexandre Julliard March 28, 2024

March 28, 2024

Module: wine Branch: master Commit: 2546468b4ce14a118fa1771bdc2d54db0668d07a URL: https://gitlab.winehq.org/wine/wine/-/commit/2546468b4ce14a118fa1771bdc2d54… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Wed Mar 27 13:22:02 2024 +0100 gdi32: Implicitly call StartPage in ExtEscape on printer DC. --- dlls/gdi32/dc.c | 23 +++++++++++++++++++---- 1 file changed, 19 insertions(+), 4 deletions(-) diff --git a/dlls/gdi32/dc.c b/dlls/gdi32/dc.c index 87335469b9b..0a57d74485e 100644 --- a/dlls/gdi32/dc.c +++ b/dlls/gdi32/dc.c @@ -743,16 +743,31 @@ INT WINAPI Escape( HDC hdc, INT escape, INT in_count, const char *in_data, void INT WINAPI ExtEscape( HDC hdc, INT escape, INT input_size, const char *input, INT output_size, char *output ) { - struct print *print; DC_ATTR *dc_attr; if (is_meta_dc( hdc )) return METADC_ExtEscape( hdc, escape, input_size, input, output_size, output ); if (!(dc_attr = get_dc_attr( hdc ))) return 0; - if ((print = get_dc_print( dc_attr )) && dc_attr->emf) + if (dc_attr->print) { - int ret = EMFDC_ExtEscape( dc_attr, escape, input_size, input, output_size, output ); - if (ret) return ret; + switch (escape) + { + case PASSTHROUGH: + case POSTSCRIPT_DATA: + case GETFACENAME: + case DOWNLOADFACE: + case BEGIN_PATH: + case CLIP_TO_PATH: + case END_PATH: + case DOWNLOADHEADER: + print_call_start_page( dc_attr ); + } + + if (dc_attr->emf) + { + int ret = EMFDC_ExtEscape( dc_attr, escape, input_size, input, output_size, output ); + if (ret) return ret; + } } return NtGdiExtEscape( hdc, NULL, 0, escape, input_size, input, output_size, output ); }

1 0

Rémi Bernon : win32u: Split writing adapter to registry to a separate helper.
by Alexandre Julliard March 28, 2024

March 28, 2024

Module: wine Branch: master Commit: c6e328c2d02ec4ec5a6f8e96de661589e7c5ee30 URL: https://gitlab.winehq.org/wine/wine/-/commit/c6e328c2d02ec4ec5a6f8e96de6615… Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Tue Feb 27 16:38:50 2024 +0100 win32u: Split writing adapter to registry to a separate helper. --- dlls/win32u/sysparams.c | 70 +++++++++++++++++++++++++++++-------------------- 1 file changed, 41 insertions(+), 29 deletions(-) diff --git a/dlls/win32u/sysparams.c b/dlls/win32u/sysparams.c index 0122c8b0b13..66c68e23d10 100644 --- a/dlls/win32u/sysparams.c +++ b/dlls/win32u/sysparams.c @@ -1257,14 +1257,45 @@ static void add_gpu( const struct gdi_gpu *gpu, void *param ) ctx->gpu_count++; } -static void add_adapter( const struct gdi_adapter *adapter, void *param ) +static BOOL write_adapter_to_registry( const struct adapter *adapter, HKEY *adapter_key ) { - struct device_manager_ctx *ctx = param; - unsigned int adapter_index, len; + struct gpu *gpu = adapter->gpu; + unsigned int len, adapter_index = gpu->adapter_count; char name[64], buffer[MAX_PATH]; WCHAR bufferW[MAX_PATH]; HKEY hkey; + sprintf( buffer, "%s\\Video\\%s\\%04x", control_keyA, gpu->guid, adapter_index ); + len = asciiz_to_unicode( bufferW, buffer ) - sizeof(WCHAR); + + hkey = reg_create_ascii_key( NULL, buffer, REG_OPTION_VOLATILE | REG_OPTION_CREATE_LINK, NULL ); + if (!hkey) hkey = reg_create_ascii_key( NULL, buffer, REG_OPTION_VOLATILE | REG_OPTION_OPEN_LINK, NULL ); + + sprintf( name, "\\Device\\Video%u", adapter->id ); + set_reg_ascii_value( video_key, name, buffer ); + + if (!hkey) return FALSE; + + sprintf( buffer, "%s\\Class\\%s\\%04X", control_keyA, guid_devclass_displayA, gpu->index ); + len = asciiz_to_unicode( bufferW, buffer ) - sizeof(WCHAR); + set_reg_value( hkey, symbolic_link_valueW, REG_LINK, bufferW, len ); + NtClose( hkey ); + + /* Following information is Wine specific, it doesn't really exist on Windows. */ + sprintf( buffer, "System\\CurrentControlSet\\Control\\Video\\%s\\%04x", gpu->guid, adapter_index ); + *adapter_key = reg_create_ascii_key( config_key, buffer, REG_OPTION_VOLATILE, NULL ); + + set_reg_ascii_value( *adapter_key, "GPUID", gpu->path ); + set_reg_value( *adapter_key, state_flagsW, REG_DWORD, &adapter->state_flags, + sizeof(adapter->state_flags) ); + + return TRUE; +} + +static void add_adapter( const struct gdi_adapter *adapter, void *param ) +{ + struct device_manager_ctx *ctx = param; + TRACE( "\n" ); if (ctx->adapter_key) @@ -1273,37 +1304,18 @@ static void add_adapter( const struct gdi_adapter *adapter, void *param ) ctx->adapter_key = NULL; } - adapter_index = ctx->gpu.adapter_count++; - memset( &ctx->adapter, 0, sizeof(ctx->adapter) ); ctx->adapter.gpu = &ctx->gpu; - ctx->adapter.id = ctx->adapter_count++; - - snprintf( buffer, ARRAY_SIZE(buffer), "%s\\Video\\%s\\%04x", control_keyA, ctx->gpu.guid, adapter_index ); - len = asciiz_to_unicode( bufferW, buffer ) - sizeof(WCHAR); + ctx->adapter.id = ctx->adapter_count; + ctx->adapter.state_flags = adapter->state_flags; - hkey = reg_create_ascii_key( NULL, buffer, REG_OPTION_VOLATILE | REG_OPTION_CREATE_LINK, NULL ); - if (!hkey) hkey = reg_create_ascii_key( NULL, buffer, REG_OPTION_VOLATILE | REG_OPTION_OPEN_LINK, NULL ); - - sprintf( name, "\\Device\\Video%u", ctx->adapter.id ); - set_reg_ascii_value( video_key, name, buffer ); - - if (hkey) + if (!write_adapter_to_registry( &ctx->adapter, &ctx->adapter_key )) + WARN( "Failed to write adapter to registry\n" ); + else { - sprintf( buffer, "%s\\Class\\%s\\%04X", control_keyA, guid_devclass_displayA, ctx->gpu.index ); - len = asciiz_to_unicode( bufferW, buffer ) - sizeof(WCHAR); - set_reg_value( hkey, symbolic_link_valueW, REG_LINK, bufferW, len ); - NtClose( hkey ); + ctx->gpu.adapter_count++; + ctx->adapter_count++; } - else ERR( "failed to create link key\n" ); - - /* Following information is Wine specific, it doesn't really exist on Windows. */ - snprintf( buffer, ARRAY_SIZE(buffer), "System\\CurrentControlSet\\Control\\Video\\%s\\%04x", ctx->gpu.guid, adapter_index ); - ctx->adapter_key = reg_create_ascii_key( config_key, buffer, REG_OPTION_VOLATILE, NULL ); - - set_reg_ascii_value( ctx->adapter_key, "GPUID", ctx->gpu.path ); - set_reg_value( ctx->adapter_key, state_flagsW, REG_DWORD, &adapter->state_flags, - sizeof(adapter->state_flags) ); } static BOOL write_monitor_to_registry( struct monitor *monitor, const BYTE *edid, UINT edid_len )

1 0

Alexandre Julliard : widl: Don't output the explicit handle argument.
by Alexandre Julliard March 28, 2024

March 28, 2024

Module: wine Branch: master Commit: 53bb4117acfec085c59ede50728fd8225987a06d URL: https://gitlab.winehq.org/wine/wine/-/commit/53bb4117acfec085c59ede50728fd8… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Thu Mar 28 09:55:33 2024 +0100 widl: Don't output the explicit handle argument. --- tools/widl/typegen.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/tools/widl/typegen.c b/tools/widl/typegen.c index 824ba5d4a89..2af08d87081 100644 --- a/tools/widl/typegen.c +++ b/tools/widl/typegen.c @@ -1044,11 +1044,7 @@ static unsigned char get_parameter_fc( const var_t *var, int is_return, unsigned case TGT_BASIC: *flags |= IsBasetype; fc = get_basic_fc_signed( var->declspec.type ); - if (fc == FC_BIND_PRIMITIVE) - { - buffer_size = 4; /* actually 0 but avoids setting MustSize */ - fc = FC_LONG; - } + if (fc == FC_BIND_PRIMITIVE) buffer_size = 4; /* actually 0 but avoids setting MustSize */ break; case TGT_ENUM: *flags |= IsBasetype; @@ -1420,6 +1416,7 @@ static void write_proc_func_interp( FILE *file, int indent, const type_t *iface, print_file( file, indent, "NdrFcShort(0x%hx),\t/* stack offset = %hu */\n", handle_stack_offset, handle_stack_offset ); *offset += 4; + nb_args--; break; case FC_BIND_GENERIC: handle_flags = type_memsize( handle_var->declspec.type ); @@ -1493,6 +1490,11 @@ static void write_proc_func_interp( FILE *file, int indent, const type_t *iface, /* emit argument data */ if (args) LIST_FOR_EACH_ENTRY( var, args, var_t, entry ) { + if (explicit_fc == FC_BIND_PRIMITIVE && var == handle_var) + { + stack_offset += pointer_size; + continue; + } print_file( file, 0, "/* %u (parameter %s) */\n", *offset, var->name ); *offset += write_new_procformatstring_type(file, indent, var, FALSE, &stack_offset); }

1 0