June 2024 - Wine-Commits - list.winehq.org

Torge Matthies : winegstreamer: Ignore an assert in wg_parser.
by Alexandre Julliard June 24, 2024

June 24, 2024

Module: wine Branch: master Commit: 62d8d3415cefc95b34afba7a52d32d730d3b7585 URL: https://gitlab.winehq.org/wine/wine/-/commit/62d8d3415cefc95b34afba7a52d32d… Author: Torge Matthies <openglfreak(a)googlemail.com> Date: Tue Mar 19 04:06:37 2024 +0100 winegstreamer: Ignore an assert in wg_parser. This gets hit when a wg_parser receives GST_EVENT_FLUSH_START between the wg_parser_stream_get_buffer function return and the wg_parser_stream_release_buffer call. In this case the NULL buffer can be ignored, it does no harm and there is no memory leak from this. --- dlls/winegstreamer/wg_parser.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/dlls/winegstreamer/wg_parser.c b/dlls/winegstreamer/wg_parser.c index b942273d02b..7253013b6a3 100644 --- a/dlls/winegstreamer/wg_parser.c +++ b/dlls/winegstreamer/wg_parser.c @@ -412,11 +412,12 @@ static NTSTATUS wg_parser_stream_release_buffer(void *args) pthread_mutex_lock(&parser->mutex); - assert(stream->buffer); - - gst_buffer_unmap(stream->buffer, &stream->map_info); - gst_buffer_unref(stream->buffer); - stream->buffer = NULL; + if (stream->buffer) + { + gst_buffer_unmap(stream->buffer, &stream->map_info); + gst_buffer_unref(stream->buffer); + stream->buffer = NULL; + } pthread_mutex_unlock(&parser->mutex); pthread_cond_signal(&stream->event_empty_cond);

1 0

Torge Matthies : winegstreamer: Don't only accept segment events when streams are enabled.
by Alexandre Julliard June 24, 2024

June 24, 2024

Module: wine Branch: master Commit: 215478fc4627792b1df8d42cf04e016d460c2106 URL: https://gitlab.winehq.org/wine/wine/-/commit/215478fc4627792b1df8d42cf04e01… Author: Torge Matthies <openglfreak(a)googlemail.com> Date: Tue Apr 23 19:30:17 2024 +0200 winegstreamer: Don't only accept segment events when streams are enabled. I don't know why this was done previously but this just creates a race condition, with no to me apparent benefit. --- dlls/winegstreamer/wg_parser.c | 24 ++++++++++-------------- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/dlls/winegstreamer/wg_parser.c b/dlls/winegstreamer/wg_parser.c index 021aa66ae12..b942273d02b 100644 --- a/dlls/winegstreamer/wg_parser.c +++ b/dlls/winegstreamer/wg_parser.c @@ -576,24 +576,20 @@ static gboolean sink_event_cb(GstPad *pad, GstObject *parent, GstEvent *event) switch (event->type) { case GST_EVENT_SEGMENT: - pthread_mutex_lock(&parser->mutex); - if (stream->enabled) - { - const GstSegment *segment; - - gst_event_parse_segment(event, &segment); - - if (segment->format != GST_FORMAT_TIME) - { - pthread_mutex_unlock(&parser->mutex); - GST_FIXME("Unhandled format \"%s\".", gst_format_get_name(segment->format)); - break; - } + { + const GstSegment *segment; - gst_segment_copy_into(segment, &stream->segment); + gst_event_parse_segment(event, &segment); + if (segment->format != GST_FORMAT_TIME) + { + GST_FIXME("Unhandled format \"%s\".", gst_format_get_name(segment->format)); + break; } + pthread_mutex_lock(&parser->mutex); + gst_segment_copy_into(segment, &stream->segment); pthread_mutex_unlock(&parser->mutex); break; + } case GST_EVENT_EOS: pthread_mutex_lock(&parser->mutex);

1 0

Alexandre Julliard : makefiles: Hardcode the dll directory.
by Alexandre Julliard June 24, 2024

June 24, 2024

Module: wine Branch: master Commit: 0fb9e616bcfb4ba25f29f96dfbfd9f88d90ddeb5 URL: https://gitlab.winehq.org/wine/wine/-/commit/0fb9e616bcfb4ba25f29f96dfbfd9f… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Mon Jun 24 13:57:34 2024 +0200 makefiles: Hardcode the dll directory. It's Wine-specific anyway. --- configure | 6 +----- configure.ac | 3 +-- dlls/ntdll/Makefile.in | 2 +- loader/Makefile.in | 2 +- tools/makedep.c | 10 +++++----- tools/widl/Makefile.in | 4 ++-- 6 files changed, 11 insertions(+), 16 deletions(-) diff --git a/configure b/configure index 460701f00ed..64afddd6a51 100755 --- a/configure +++ b/configure @@ -868,7 +868,6 @@ CFLAGS CC SET_MAKE srcdir -dlldir host_os host_vendor host_cpu @@ -4674,8 +4673,6 @@ case $host_os in *\ *) host_os=`echo "$host_os" | sed 's/ /-/g'`;; esac -dlldir=\${libdir}/wine - @@ -6470,7 +6467,7 @@ MAKEDEP=$wine_makedep RUNTESTFLAGS="-q -P wine" -SED_CMD="LC_ALL=C sed -e 's,@bindir@,\${bindir},g' -e 's,@dlldir@,\${dlldir},g' -e 's,@PACKAGE_STRING@,$PACKAGE_STRING,g' -e 's,@PACKAGE_VERSION@,$PACKAGE_VERSION,g'" +SED_CMD="LC_ALL=C sed -e 's,@bindir@,\${bindir},g' -e 's,@PACKAGE_STRING@,$PACKAGE_STRING,g' -e 's,@PACKAGE_VERSION@,$PACKAGE_VERSION,g'" if test -n "$host_alias" -a "$host_alias" != "$build_alias" @@ -23975,7 +23972,6 @@ host = $host host_cpu = $host_cpu host_vendor = $host_vendor host_os = $host_os -dlldir = $dlldir srcdir = $srcdir SET_MAKE = $SET_MAKE CC = $CC diff --git a/configure.ac b/configure.ac index 745f703709f..8c2f0f3e09b 100644 --- a/configure.ac +++ b/configure.ac @@ -91,7 +91,6 @@ AC_ARG_WITH(wine64, AS_HELP_STRING([--with-wine64=DIR],[use the 64-bit Wine i AC_CANONICAL_HOST -AC_SUBST(dlldir,[\${libdir}/wine]) AC_SUBST(srcdir) dnl **** Check for some programs **** @@ -196,7 +195,7 @@ fi AC_SUBST(toolsdir,[$wine_cv_toolsdir]) AC_SUBST(MAKEDEP,[$wine_makedep]) AC_SUBST(RUNTESTFLAGS,["-q -P wine"]) -AC_SUBST(SED_CMD,["LC_ALL=C sed -e 's,@bindir@,\${bindir},g' -e 's,@dlldir@,\${dlldir},g' -e 's,@PACKAGE_STRING@,$PACKAGE_STRING,g' -e 's,@PACKAGE_VERSION@,$PACKAGE_VERSION,g'"]) +AC_SUBST(SED_CMD,["LC_ALL=C sed -e 's,@bindir@,\${bindir},g' -e 's,@PACKAGE_STRING@,$PACKAGE_STRING,g' -e 's,@PACKAGE_VERSION@,$PACKAGE_VERSION,g'"]) if test -n "$host_alias" -a "$host_alias" != "$build_alias" then diff --git a/dlls/ntdll/Makefile.in b/dlls/ntdll/Makefile.in index b519bcd655f..e17e3f72b92 100644 --- a/dlls/ntdll/Makefile.in +++ b/dlls/ntdll/Makefile.in @@ -76,5 +76,5 @@ EXTRA_OBJS = unix/version.o unix_loader_EXTRADEFS = \ -DBINDIR=\"${bindir}\" \ -DSYSTEMDLLPATH=\"${system_dllpath}\" \ - -DDLL_TO_BINDIR=\"`${MAKEDEP} -R ${dlldir} ${bindir}`\" \ + -DDLL_TO_BINDIR=\"`${MAKEDEP} -R ${libdir}/wine ${bindir}`\" \ -DBIN_TO_DATADIR=\"`${MAKEDEP} -R ${bindir} ${datadir}/wine`\" diff --git a/loader/Makefile.in b/loader/Makefile.in index 30413fc8677..5a9fdabfd97 100644 --- a/loader/Makefile.in +++ b/loader/Makefile.in @@ -16,7 +16,7 @@ UNIX_CFLAGS = -fPIE preloader_EXTRADEFS = -fno-builtin -main_EXTRADEFS = -DDLLDIR=\"${dlldir}\" -DBIN_TO_DLLDIR=\"`${MAKEDEP} -R ${bindir} ${dlldir}`\" +main_EXTRADEFS = -DDLLDIR=\"${libdir}/wine\" -DBIN_TO_DLLDIR=\"`${MAKEDEP} -R ${bindir} ${libdir}/wine`\" wine_OBJS = main.o wine_DEPS = $(WINELOADER_DEPENDS) diff --git a/tools/makedep.c b/tools/makedep.c index 2b24c9584a3..cf22bc7bf07 100644 --- a/tools/makedep.c +++ b/tools/makedep.c @@ -2664,7 +2664,7 @@ static struct strarray get_removable_dirs( struct strarray files ) static void output_uninstall_rules( struct makefile *make ) { static const char *dirs_order[] = - { "$(includedir)", "$(mandir)", "$(datadir)", "$(dlldir)" }; + { "$(includedir)", "$(mandir)", "$(datadir)" }; struct strarray uninstall_dirs; unsigned int i, j; @@ -3383,7 +3383,7 @@ static void output_fake_module( struct makefile *make, const char *spec_file ) if (make->disabled[arch]) return; strarray_add( &make->all_targets[arch], name ); - add_install_rule( make, make->module, arch, name, strmake( "d$(dlldir)/%s", name )); + add_install_rule( make, make->module, arch, name, strmake( "d$(libdir)/wine/%s", name )); output( "%s:", obj_dir_path( make, name )); if (spec_file) output_filename( spec_file ); @@ -3460,7 +3460,7 @@ static void output_module( struct makefile *make, unsigned int arch ) strarray_add( &make->all_targets[link_arch], module_name ); if (make->data_only) add_install_rule( make, make->module, link_arch, module_name, - strmake( "d$(dlldir)/%s%s", arch_pe_dirs[arch], make->module )); + strmake( "d$(libdir)/wine/%s%s", arch_pe_dirs[arch], make->module )); else add_install_rule( make, make->module, link_arch, module_name, strmake( "%c%s%s%s", '0' + arch, arch_install_dirs[arch], make->module, @@ -4554,7 +4554,7 @@ int main( int argc, char *argv[] ) arch_dirs[0] = ""; arch_pe_dirs[0] = strmake( "%s-windows/", archs.str[0] ); - arch_install_dirs[0] = unix_lib_supported ? strmake( "$(dlldir)/%s-unix/", archs.str[0] ) : "$(dlldir)/"; + arch_install_dirs[0] = unix_lib_supported ? strmake( "$(libdir)/wine/%s-unix/", archs.str[0] ) : "$(libdir)/wine/"; strip_progs[0] = "\"$(STRIP)\""; for (arch = 1; arch < archs.count; arch++) @@ -4564,7 +4564,7 @@ int main( int argc, char *argv[] ) strarray_add( &target_flags[arch], target ); arch_dirs[arch] = strmake( "%s-windows/", archs.str[arch] ); arch_pe_dirs[arch] = arch_dirs[arch]; - arch_install_dirs[arch] = strmake( "$(dlldir)/%s", arch_dirs[arch] ); + arch_install_dirs[arch] = strmake( "$(libdir)/wine/%s", arch_dirs[arch] ); strip_progs[arch] = strmake( "%s-strip", target ); dll_ext[arch] = ""; } diff --git a/tools/widl/Makefile.in b/tools/widl/Makefile.in index da6d843b2a8..fee965d49db 100644 --- a/tools/widl/Makefile.in +++ b/tools/widl/Makefile.in @@ -26,8 +26,8 @@ SOURCES = \ widl_EXTRADEFS = \ -DINCLUDEDIR="\"${includedir}\"" \ - -DDLLDIR="\"${dlldir}\"" \ + -DDLLDIR="\"${libdir}/wine\"" \ -DBIN_TO_INCLUDEDIR=\"`${MAKEDEP} -R ${bindir} ${includedir}`\" \ - -DBIN_TO_DLLDIR=\"`${MAKEDEP} -R ${bindir} ${dlldir}`\" + -DBIN_TO_DLLDIR=\"`${MAKEDEP} -R ${bindir} ${libdir}/wine`\" INSTALL_DEV = $(PROGRAMS)

1 0

Alexandre Julliard : makefiles: Hardcode the nls directory.
by Alexandre Julliard June 24, 2024

June 24, 2024

Module: wine Branch: master Commit: f0ee51026b723d74b36626074f1860e80f54ad68 URL: https://gitlab.winehq.org/wine/wine/-/commit/f0ee51026b723d74b36626074f1860… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Mon Jun 24 13:47:08 2024 +0200 makefiles: Hardcode the nls directory. It's Wine-specific anyway. --- configure | 4 ---- configure.ac | 1 - server/Makefile.in | 2 +- tools/makedep.c | 4 ++-- tools/wmc/Makefile.in | 4 ++-- tools/wrc/Makefile.in | 4 ++-- 6 files changed, 7 insertions(+), 12 deletions(-) diff --git a/configure b/configure index 26b537c2088..460701f00ed 100755 --- a/configure +++ b/configure @@ -868,7 +868,6 @@ CFLAGS CC SET_MAKE srcdir -nlsdir dlldir host_os host_vendor @@ -4677,8 +4676,6 @@ case $host_os in *\ *) host_os=`echo "$host_os" | sed 's/ /-/g'`;; esac dlldir=\${libdir}/wine -nlsdir=\${datadir}/wine/nls - @@ -23979,7 +23976,6 @@ host_cpu = $host_cpu host_vendor = $host_vendor host_os = $host_os dlldir = $dlldir -nlsdir = $nlsdir srcdir = $srcdir SET_MAKE = $SET_MAKE CC = $CC diff --git a/configure.ac b/configure.ac index ac0f3ea051d..745f703709f 100644 --- a/configure.ac +++ b/configure.ac @@ -92,7 +92,6 @@ AC_ARG_WITH(wine64, AS_HELP_STRING([--with-wine64=DIR],[use the 64-bit Wine i AC_CANONICAL_HOST AC_SUBST(dlldir,[\${libdir}/wine]) -AC_SUBST(nlsdir,[\${datadir}/wine/nls]) AC_SUBST(srcdir) dnl **** Check for some programs **** diff --git a/server/Makefile.in b/server/Makefile.in index 7b46b924c46..8ba6baf0c30 100644 --- a/server/Makefile.in +++ b/server/Makefile.in @@ -49,4 +49,4 @@ SOURCES = \ UNIX_LIBS = $(LDEXECFLAGS) $(RT_LIBS) $(INOTIFY_LIBS) $(PROCSTAT_LIBS) -unicode_EXTRADEFS = -DNLSDIR="\"${nlsdir}\"" -DBIN_TO_NLSDIR=\"`${MAKEDEP} -R ${bindir} ${nlsdir}`\" +unicode_EXTRADEFS = -DNLSDIR="\"${datadir}/wine/nls\"" -DBIN_TO_NLSDIR=\"`${MAKEDEP} -R ${bindir} ${datadir}/wine/nls`\" diff --git a/tools/makedep.c b/tools/makedep.c index 61e30ed89a6..2b24c9584a3 100644 --- a/tools/makedep.c +++ b/tools/makedep.c @@ -2664,7 +2664,7 @@ static struct strarray get_removable_dirs( struct strarray files ) static void output_uninstall_rules( struct makefile *make ) { static const char *dirs_order[] = - { "$(includedir)", "$(mandir)", "$(nlsdir)", "$(datadir)", "$(dlldir)" }; + { "$(includedir)", "$(mandir)", "$(datadir)", "$(dlldir)" }; struct strarray uninstall_dirs; unsigned int i, j; @@ -3042,7 +3042,7 @@ static void output_source_svg( struct makefile *make, struct incl_file *source, static void output_source_nls( struct makefile *make, struct incl_file *source, const char *obj ) { add_install_rule( make, source->name, 0, source->name, - strmake( "D$(nlsdir)/%s", source->name )); + strmake( "D$(datadir)/wine/nls/%s", source->name )); output_srcdir_symlink( make, strmake( "%s.nls", obj )); } diff --git a/tools/wmc/Makefile.in b/tools/wmc/Makefile.in index 022315c8ce1..1c2c72360b7 100644 --- a/tools/wmc/Makefile.in +++ b/tools/wmc/Makefile.in @@ -12,7 +12,7 @@ SOURCES = \ write.c wmc_EXTRADEFS = \ - -DNLSDIR="\"${nlsdir}\"" \ - -DBIN_TO_NLSDIR=\"`${MAKEDEP} -R ${bindir} ${nlsdir}`\" + -DNLSDIR="\"${datadir}/wine/nls\"" \ + -DBIN_TO_NLSDIR=\"`${MAKEDEP} -R ${bindir} ${datadir}/wine/nls`\" INSTALL_DEV = $(PROGRAMS) diff --git a/tools/wrc/Makefile.in b/tools/wrc/Makefile.in index 06547d2b851..54cde2e98fd 100644 --- a/tools/wrc/Makefile.in +++ b/tools/wrc/Makefile.in @@ -15,9 +15,9 @@ SOURCES = \ wrc.man.in wrc_EXTRADEFS = \ - -DNLSDIR="\"${nlsdir}\"" \ + -DNLSDIR="\"${datadir}/wine/nls\"" \ -DINCLUDEDIR="\"${includedir}\"" \ - -DBIN_TO_NLSDIR=\"`${MAKEDEP} -R ${bindir} ${nlsdir}`\" \ + -DBIN_TO_NLSDIR=\"`${MAKEDEP} -R ${bindir} ${datadir}/wine/nls`\" \ -DBIN_TO_INCLUDEDIR=\"`${MAKEDEP} -R ${bindir} ${includedir}`\" INSTALL_DEV = $(PROGRAMS)

1 0

Alexandre Julliard : makefiles: Hardcode the fonts directory.
by Alexandre Julliard June 24, 2024

June 24, 2024

Module: wine Branch: master Commit: 13159b0767b8b5e3a9f9203f6e316738359cc7cf URL: https://gitlab.winehq.org/wine/wine/-/commit/13159b0767b8b5e3a9f9203f6e3167… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Mon Jun 24 13:44:54 2024 +0200 makefiles: Hardcode the fonts directory. It's Wine-specific anyway. --- configure | 4 ---- configure.ac | 1 - dlls/win32u/Makefile.in | 2 -- dlls/win32u/font.c | 20 ++++---------------- tools/makedep.c | 6 +++--- 5 files changed, 7 insertions(+), 26 deletions(-) diff --git a/configure b/configure index e77f0893dd8..26b537c2088 100755 --- a/configure +++ b/configure @@ -869,7 +869,6 @@ CC SET_MAKE srcdir nlsdir -fontdir dlldir host_os host_vendor @@ -4678,8 +4677,6 @@ case $host_os in *\ *) host_os=`echo "$host_os" | sed 's/ /-/g'`;; esac dlldir=\${libdir}/wine -fontdir=\${datadir}/wine/fonts - nlsdir=\${datadir}/wine/nls @@ -23982,7 +23979,6 @@ host_cpu = $host_cpu host_vendor = $host_vendor host_os = $host_os dlldir = $dlldir -fontdir = $fontdir nlsdir = $nlsdir srcdir = $srcdir SET_MAKE = $SET_MAKE diff --git a/configure.ac b/configure.ac index e828083fc91..ac0f3ea051d 100644 --- a/configure.ac +++ b/configure.ac @@ -92,7 +92,6 @@ AC_ARG_WITH(wine64, AS_HELP_STRING([--with-wine64=DIR],[use the 64-bit Wine i AC_CANONICAL_HOST AC_SUBST(dlldir,[\${libdir}/wine]) -AC_SUBST(fontdir,[\${datadir}/wine/fonts]) AC_SUBST(nlsdir,[\${datadir}/wine/nls]) AC_SUBST(srcdir) diff --git a/dlls/win32u/Makefile.in b/dlls/win32u/Makefile.in index 61c06e900a4..6326a3cd302 100644 --- a/dlls/win32u/Makefile.in +++ b/dlls/win32u/Makefile.in @@ -56,5 +56,3 @@ SOURCES = \ vulkan.c \ window.c \ winstation.c - -font_EXTRADEFS = -DWINE_FONT_DIR=\"`${MAKEDEP} -R ${datadir}/wine ${fontdir}`\" diff --git a/dlls/win32u/font.c b/dlls/win32u/font.c index 7e70cccf568..8fb3128f5e0 100644 --- a/dlls/win32u/font.c +++ b/dlls/win32u/font.c @@ -462,10 +462,6 @@ static const struct nls_update_font_list static pthread_mutex_t font_lock = PTHREAD_MUTEX_INITIALIZER; -#ifndef WINE_FONT_DIR -#define WINE_FONT_DIR "fonts" -#endif - #ifdef WORDS_BIGENDIAN #define GET_BE_WORD(x) (x) #define GET_BE_DWORD(x) (x) @@ -476,20 +472,12 @@ static pthread_mutex_t font_lock = PTHREAD_MUTEX_INITIALIZER; static void get_fonts_data_dir_path( const WCHAR *file, WCHAR *path ) { - const char *dir; + const char *dir = ntdll_get_build_dir(); ULONG len = MAX_PATH; - if ((dir = ntdll_get_data_dir())) - { - wine_unix_to_nt_file_name( dir, path, &len ); - asciiz_to_unicode( path + len - 1, "\\" WINE_FONT_DIR "\\" ); - } - else if ((dir = ntdll_get_build_dir())) - { - wine_unix_to_nt_file_name( dir, path, &len ); - asciiz_to_unicode( path + len - 1, "\\fonts\\" ); - } - + if (!dir) dir = ntdll_get_data_dir(); + wine_unix_to_nt_file_name( dir, path, &len ); + asciiz_to_unicode( path + len - 1, "\\fonts\\" ); if (file) lstrcatW( path, file ); } diff --git a/tools/makedep.c b/tools/makedep.c index 29c83e3f73f..61e30ed89a6 100644 --- a/tools/makedep.c +++ b/tools/makedep.c @@ -2664,7 +2664,7 @@ static struct strarray get_removable_dirs( struct strarray files ) static void output_uninstall_rules( struct makefile *make ) { static const char *dirs_order[] = - { "$(includedir)", "$(mandir)", "$(fontdir)", "$(nlsdir)", "$(datadir)", "$(dlldir)" }; + { "$(includedir)", "$(mandir)", "$(nlsdir)", "$(datadir)", "$(dlldir)" }; struct strarray uninstall_dirs; unsigned int i, j; @@ -2987,7 +2987,7 @@ static void output_source_sfd( struct makefile *make, struct incl_file *source, } if (source->file->flags & FLAG_INSTALL) { - add_install_rule( make, source->name, 0, ttf_obj, strmake( "D$(fontdir)/%s", ttf_obj )); + add_install_rule( make, source->name, 0, ttf_obj, strmake( "D$(datadir)/wine/fonts/%s", ttf_obj )); output_srcdir_symlink( make, ttf_obj ); } @@ -3005,7 +3005,7 @@ static void output_source_sfd( struct makefile *make, struct incl_file *source, tools_path( make, "sfnt2fon" ), ttf_file ); output( "\t%s%s -q -o $@ %s %s\n", cmd_prefix( "GEN" ), tools_path( make, "sfnt2fon" ), ttf_file, args ); - add_install_rule( make, source->name, 0, xstrdup(font), strmake( "d$(fontdir)/%s", font )); + add_install_rule( make, source->name, 0, xstrdup(font), strmake( "d$(datadir)/wine/fonts/%s", font )); } } }

1 0

Torge Matthies : winegstreamer: Fix race between wg_parser_stream_en/disable and GST_EVENT_FLUSH_START/STOP.
by Alexandre Julliard June 24, 2024

June 24, 2024

Module: wine Branch: master Commit: 490d8ed6635665a73c339fe9e906cdfa2726b4b1 URL: https://gitlab.winehq.org/wine/wine/-/commit/490d8ed6635665a73c339fe9e906cd… Author: Torge Matthies <openglfreak(a)googlemail.com> Date: Mon Jun 3 11:05:38 2024 +0200 winegstreamer: Fix race between wg_parser_stream_en/disable and GST_EVENT_FLUSH_START/STOP. --- dlls/winegstreamer/wg_parser.c | 20 ++++++++------------ 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/dlls/winegstreamer/wg_parser.c b/dlls/winegstreamer/wg_parser.c index f9b76b12f8f..021aa66ae12 100644 --- a/dlls/winegstreamer/wg_parser.c +++ b/dlls/winegstreamer/wg_parser.c @@ -608,17 +608,14 @@ static gboolean sink_event_cb(GstPad *pad, GstObject *parent, GstEvent *event) case GST_EVENT_FLUSH_START: pthread_mutex_lock(&parser->mutex); - if (stream->enabled) - { - stream->flushing = true; - pthread_cond_signal(&stream->event_empty_cond); + stream->flushing = true; + pthread_cond_signal(&stream->event_empty_cond); - if (stream->buffer) - { - gst_buffer_unmap(stream->buffer, &stream->map_info); - gst_buffer_unref(stream->buffer); - stream->buffer = NULL; - } + if (stream->buffer) + { + gst_buffer_unmap(stream->buffer, &stream->map_info); + gst_buffer_unref(stream->buffer); + stream->buffer = NULL; } pthread_mutex_unlock(&parser->mutex); @@ -636,8 +633,7 @@ static gboolean sink_event_cb(GstPad *pad, GstObject *parent, GstEvent *event) pthread_mutex_lock(&parser->mutex); stream->eos = false; - if (stream->enabled) - stream->flushing = false; + stream->flushing = false; pthread_mutex_unlock(&parser->mutex); break;

1 0

Alexandre Julliard : makefiles: Generate rules to build makedep.
by Alexandre Julliard June 24, 2024

June 24, 2024

Module: wine Branch: master Commit: 7c0aa6fd8c5ede0867b3b388d4695c7f016aac9f URL: https://gitlab.winehq.org/wine/wine/-/commit/7c0aa6fd8c5ede0867b3b388d4695c… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Mon Jun 24 17:12:52 2024 +0200 makefiles: Generate rules to build makedep. --- configure | 16 ++-------------- configure.ac | 16 ++-------------- tools/Makefile.in | 5 +++++ 3 files changed, 9 insertions(+), 28 deletions(-) diff --git a/configure b/configure index 64afddd6a51..a91ee8891e0 100755 --- a/configure +++ b/configure @@ -23100,7 +23100,6 @@ test "$wine_binary" = wine || as_fn_append CONFIGURE_TARGETS " loader/wine" if test "x$enable_tools" != xno then - as_fn_append CONFIGURE_TARGETS " tools/makedep$ac_exeext" ac_config_commands="$ac_config_commands tools/makedep" fi @@ -23142,18 +23141,6 @@ include/stamp-h.in: configure.ac aclocal.m4 @echo timestamp > \$@" fi -if test "x$enable_tools" != xno -then - as_fn_append wine_rules " -tools/makedep$ac_exeext: ${wine_srcdir}tools/makedep.c include/config.h config.status - @./config.status tools/makedep -Makefile: tools/makedep$ac_exeext" -else - as_fn_append wine_rules " -\$(MAKEDEP): - @echo \"You need to run make in $toolsdir first\" && false" -fi - if test -n "$with_wine64" then @@ -23905,7 +23892,8 @@ cat >>$CONFIG_STATUS <<_ACEOF || ac_write_fail=1 wine_fn_output_makedep () { as_dir=tools; as_fn_mkdir_p - $CC -I${wine_srcdir}tools -Iinclude -I${wine_srcdir}include -D__WINESRC__ -DWINE_UNIX_LIB $EXTRACFLAGS $CPPFLAGS $CFLAGS -o tools/makedep$ac_exeext ${wine_srcdir}tools/makedep.c $LDFLAGS + $CC -c -I${wine_srcdir}tools -Iinclude -I${wine_srcdir}include -D__WINESRC__ -DWINE_UNIX_LIB $EXTRACFLAGS $CPPFLAGS $CFLAGS -o tools/makedep.o ${wine_srcdir}tools/makedep.c + $CC -o tools/makedep$ac_exeext tools/makedep.o $LDFLAGS } wine_fn_output_makefile () { diff --git a/configure.ac b/configure.ac index 8c2f0f3e09b..2ff2e062973 100644 --- a/configure.ac +++ b/configure.ac @@ -3586,12 +3586,12 @@ test "$wine_binary" = wine || WINE_IGNORE_FILE(loader/wine) if test "x$enable_tools" != xno then - WINE_IGNORE_FILE(tools/makedep$ac_exeext) AC_CONFIG_COMMANDS([tools/makedep],[wine_fn_output_makedep || AS_EXIT], [wine_fn_output_makedep () { AS_MKDIR_P(tools) - $CC -I${wine_srcdir}tools -Iinclude -I${wine_srcdir}include -D__WINESRC__ -DWINE_UNIX_LIB $EXTRACFLAGS $CPPFLAGS $CFLAGS -o tools/makedep$ac_exeext ${wine_srcdir}tools/makedep.c $LDFLAGS + $CC -c -I${wine_srcdir}tools -Iinclude -I${wine_srcdir}include -D__WINESRC__ -DWINE_UNIX_LIB $EXTRACFLAGS $CPPFLAGS $CFLAGS -o tools/makedep.o ${wine_srcdir}tools/makedep.c + $CC -o tools/makedep$ac_exeext tools/makedep.o $LDFLAGS }]) fi @@ -3655,18 +3655,6 @@ include/stamp-h.in: configure.ac aclocal.m4 @echo timestamp > \$[@]]) fi -if test "x$enable_tools" != xno -then - WINE_APPEND_RULE( -[tools/makedep$ac_exeext: ${wine_srcdir}tools/makedep.c include/config.h config.status - @./config.status tools/makedep -Makefile: tools/makedep$ac_exeext]) -else - WINE_APPEND_RULE( -[\$(MAKEDEP): - @echo \"You need to run make in $toolsdir first\" && false]) -fi - dnl Rules for wineloader if test -n "$with_wine64" diff --git a/tools/Makefile.in b/tools/Makefile.in index cd643e7e90b..71bd896b8a0 100644 --- a/tools/Makefile.in +++ b/tools/Makefile.in @@ -1,6 +1,11 @@ PROGRAMS = \ + makedep \ make_xftmpl SOURCES = \ + makedep.c \ make_xftmpl.c \ wineapploader.in + +makedep_OBJS = makedep.o +make_xftmpl_OBJS = make_xftmpl.o

1 0

Rémi Bernon : winex11: Move window surface creation functions to bitblt.c.
by Alexandre Julliard June 24, 2024

June 24, 2024

Module: wine Branch: master Commit: e9ca13a6f736ff54d80805a050f174f2fce835a0 URL: https://gitlab.winehq.org/wine/wine/-/commit/e9ca13a6f736ff54d80805a050f174… Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Wed Jun 12 10:13:15 2024 +0200 winex11: Move window surface creation functions to bitblt.c. --- dlls/winex11.drv/bitblt.c | 100 +++++++++++++++++++++++++++++++++++++++++++++- dlls/winex11.drv/window.c | 96 -------------------------------------------- dlls/winex11.drv/x11drv.h | 3 +- 3 files changed, 99 insertions(+), 100 deletions(-)

1 0

Rémi Bernon : winemac: Move window surface creation functions to surface.c.
by Alexandre Julliard June 24, 2024

June 24, 2024

Module: wine Branch: master Commit: 834da273c1d3896dc4cf5b54e24253743a8412fa URL: https://gitlab.winehq.org/wine/wine/-/commit/834da273c1d3896dc4cf5b54e24253… Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Fri Jun 21 10:14:59 2024 +0200 winemac: Move window surface creation functions to surface.c. --- dlls/winemac.drv/macdrv.h | 3 -- dlls/winemac.drv/surface.c | 98 ++++++++++++++++++++++++++++++++++++++++++++-- dlls/winemac.drv/window.c | 91 ------------------------------------------ 3 files changed, 95 insertions(+), 97 deletions(-) diff --git a/dlls/winemac.drv/macdrv.h b/dlls/winemac.drv/macdrv.h index 31835164e71..811947f723c 100644 --- a/dlls/winemac.drv/macdrv.h +++ b/dlls/winemac.drv/macdrv.h @@ -207,10 +207,7 @@ extern void init_win_context(void); extern macdrv_window macdrv_get_cocoa_window(HWND hwnd, BOOL require_on_screen); extern RGNDATA *get_region_data(HRGN hrgn, HDC hdc_lptodp); extern void activate_on_following_focus(void); -extern struct window_surface *create_surface(HWND hwnd, macdrv_window window, const RECT *rect, - struct window_surface *old_surface, BOOL use_alpha); extern void set_surface_use_alpha(struct window_surface *window_surface, BOOL use_alpha); -extern void surface_clip_to_visible_rect(struct window_surface *window_surface, const RECT *visible_rect); extern void macdrv_handle_event(const macdrv_event *event); diff --git a/dlls/winemac.drv/surface.c b/dlls/winemac.drv/surface.c index 37e2c466926..bd40a2a2db2 100644 --- a/dlls/winemac.drv/surface.c +++ b/dlls/winemac.drv/surface.c @@ -127,8 +127,8 @@ static struct macdrv_window_surface *get_mac_surface(struct window_surface *surf /*********************************************************************** * create_surface */ -struct window_surface *create_surface(HWND hwnd, macdrv_window window, const RECT *rect, - struct window_surface *old_surface, BOOL use_alpha) +static struct window_surface *create_surface(HWND hwnd, macdrv_window window, const RECT *rect, + struct window_surface *old_surface, BOOL use_alpha) { struct macdrv_window_surface *surface; int width = rect->right - rect->left, height = rect->bottom - rect->top; @@ -265,7 +265,7 @@ done: * Intersect the accumulated drawn region with a new visible rect, * effectively discarding stale drawing in the surface slack area. */ -void surface_clip_to_visible_rect(struct window_surface *window_surface, const RECT *visible_rect) +static void surface_clip_to_visible_rect(struct window_surface *window_surface, const RECT *visible_rect) { struct macdrv_window_surface *surface = get_mac_surface(window_surface); RECT rect = *visible_rect; @@ -277,3 +277,95 @@ void surface_clip_to_visible_rect(struct window_surface *window_surface, const R intersect_rect(&window_surface->bounds, &window_surface->bounds, &rect); window_surface_unlock(window_surface); } + + +static inline RECT get_surface_rect(const RECT *visible_rect) +{ + RECT rect = *visible_rect; + + OffsetRect(&rect, -visible_rect->left, -visible_rect->top); + rect.left &= ~127; + rect.top &= ~127; + rect.right = max(rect.left + 128, (rect.right + 127) & ~127); + rect.bottom = max(rect.top + 128, (rect.bottom + 127) & ~127); + return rect; +} + + +/*********************************************************************** + * CreateWindowSurface (MACDRV.@) + */ +BOOL macdrv_CreateWindowSurface(HWND hwnd, UINT swp_flags, const RECT *visible_rect, struct window_surface **surface) +{ + struct macdrv_win_data *data; + DWORD style = NtUserGetWindowLongW(hwnd, GWL_STYLE); + RECT surface_rect; + + TRACE("hwnd %p, swp_flags %08x, visible %s, surface %p\n", hwnd, swp_flags, wine_dbgstr_rect(visible_rect), surface); + + if (!(data = get_win_data(hwnd))) return TRUE; /* use default surface */ + + if (*surface) window_surface_release(*surface); + *surface = NULL; + + surface_rect = get_surface_rect(visible_rect); + if (data->surface) + { + if (EqualRect(&data->surface->rect, &surface_rect)) + { + /* existing surface is good enough */ + surface_clip_to_visible_rect(data->surface, visible_rect); + window_surface_add_ref(data->surface); + *surface = data->surface; + goto done; + } + } + else if (!(swp_flags & SWP_SHOWWINDOW) && !(style & WS_VISIBLE)) goto done; + + *surface = create_surface(data->hwnd, data->cocoa_window, &surface_rect, data->surface, FALSE); + +done: + release_win_data(data); + return TRUE; +} + + +/*********************************************************************** + * CreateLayeredWindow (MACDRV.@) + */ +BOOL macdrv_CreateLayeredWindow(HWND hwnd, const RECT *window_rect, COLORREF color_key, + struct window_surface **window_surface) +{ + struct window_surface *surface; + struct macdrv_win_data *data; + RECT rect; + + if (!(data = get_win_data(hwnd))) return FALSE; + + data->layered = TRUE; + data->ulw_layered = TRUE; + + rect = *window_rect; + OffsetRect(&rect, -window_rect->left, -window_rect->top); + + surface = data->surface; + if (!surface || !EqualRect(&surface->rect, &rect)) + { + data->surface = create_surface(data->hwnd, data->cocoa_window, &rect, NULL, TRUE); + macdrv_set_window_surface(data->cocoa_window, data->surface); + if (surface) window_surface_release(surface); + surface = data->surface; + if (data->unminimized_surface) + { + window_surface_release(data->unminimized_surface); + data->unminimized_surface = NULL; + } + } + else set_surface_use_alpha(surface, TRUE); + + if ((*window_surface = surface)) window_surface_add_ref(surface); + + release_win_data(data); + + return TRUE; +} diff --git a/dlls/winemac.drv/window.c b/dlls/winemac.drv/window.c index 012189249a4..35198f45607 100644 --- a/dlls/winemac.drv/window.c +++ b/dlls/winemac.drv/window.c @@ -1890,46 +1890,6 @@ done: } -/*********************************************************************** - * CreateLayeredWindow (MACDRV.@) - */ -BOOL macdrv_CreateLayeredWindow(HWND hwnd, const RECT *window_rect, COLORREF color_key, - struct window_surface **window_surface) -{ - struct window_surface *surface; - struct macdrv_win_data *data; - RECT rect; - - if (!(data = get_win_data(hwnd))) return FALSE; - - data->layered = TRUE; - data->ulw_layered = TRUE; - - rect = *window_rect; - OffsetRect(&rect, -window_rect->left, -window_rect->top); - - surface = data->surface; - if (!surface || !EqualRect(&surface->rect, &rect)) - { - data->surface = create_surface(data->hwnd, data->cocoa_window, &rect, NULL, TRUE); - macdrv_set_window_surface(data->cocoa_window, data->surface); - if (surface) window_surface_release(surface); - surface = data->surface; - if (data->unminimized_surface) - { - window_surface_release(data->unminimized_surface); - data->unminimized_surface = NULL; - } - } - else set_surface_use_alpha(surface, TRUE); - - if ((*window_surface = surface)) window_surface_add_ref(surface); - - release_win_data(data); - - return TRUE; -} - /*********************************************************************** * UpdateLayeredWindow (MACDRV.@) */ @@ -1984,19 +1944,6 @@ LRESULT macdrv_WindowMessage(HWND hwnd, UINT msg, WPARAM wp, LPARAM lp) } -static inline RECT get_surface_rect(const RECT *visible_rect) -{ - RECT rect = *visible_rect; - - OffsetRect(&rect, -visible_rect->left, -visible_rect->top); - rect.left &= ~127; - rect.top &= ~127; - rect.right = max(rect.left + 128, (rect.right + 127) & ~127); - rect.bottom = max(rect.top + 128, (rect.bottom + 127) & ~127); - return rect; -} - - /*********************************************************************** * WindowPosChanging (MACDRV.@) */ @@ -2028,44 +1975,6 @@ done: } -/*********************************************************************** - * CreateWindowSurface (MACDRV.@) - */ -BOOL macdrv_CreateWindowSurface(HWND hwnd, UINT swp_flags, const RECT *visible_rect, struct window_surface **surface) -{ - struct macdrv_win_data *data; - DWORD style = NtUserGetWindowLongW(hwnd, GWL_STYLE); - RECT surface_rect; - - TRACE("hwnd %p, swp_flags %08x, visible %s, surface %p\n", hwnd, swp_flags, wine_dbgstr_rect(visible_rect), surface); - - if (!(data = get_win_data(hwnd))) return TRUE; /* use default surface */ - - if (*surface) window_surface_release(*surface); - *surface = NULL; - - surface_rect = get_surface_rect(visible_rect); - if (data->surface) - { - if (EqualRect(&data->surface->rect, &surface_rect)) - { - /* existing surface is good enough */ - surface_clip_to_visible_rect(data->surface, visible_rect); - window_surface_add_ref(data->surface); - *surface = data->surface; - goto done; - } - } - else if (!(swp_flags & SWP_SHOWWINDOW) && !(style & WS_VISIBLE)) goto done; - - *surface = create_surface(data->hwnd, data->cocoa_window, &surface_rect, data->surface, FALSE); - -done: - release_win_data(data); - return TRUE; -} - - /*********************************************************************** * WindowPosChanged (MACDRV.@) */

1 0

Rémi Bernon : winewayland: Move window surface creation functions to window_surface.c.
by Alexandre Julliard June 24, 2024

June 24, 2024

Module: wine Branch: master Commit: ef7f9fed607f0d8e922deeb6aaa1cc6289e63f2e URL: https://gitlab.winehq.org/wine/wine/-/commit/ef7f9fed607f0d8e922deeb6aaa1cc… Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Tue Jun 11 11:44:25 2024 +0200 winewayland: Move window surface creation functions to window_surface.c. --- dlls/winewayland.drv/waylanddrv.h | 25 ++++++++++++++- dlls/winewayland.drv/window.c | 57 ++--------------------------------- dlls/winewayland.drv/window_surface.c | 39 +++++++++++++++++++++++- 3 files changed, 64 insertions(+), 57 deletions(-) diff --git a/dlls/winewayland.drv/waylanddrv.h b/dlls/winewayland.drv/waylanddrv.h index 4b92c9bf1ba..d0a8977f887 100644 --- a/dlls/winewayland.drv/waylanddrv.h +++ b/dlls/winewayland.drv/waylanddrv.h @@ -272,11 +272,34 @@ void wayland_shm_buffer_unref(struct wayland_shm_buffer *shm_buffer); * Wayland window surface */ -struct window_surface *wayland_window_surface_create(HWND hwnd, const RECT *rect); void wayland_window_surface_update_wayland_surface(struct window_surface *surface, struct wayland_surface *wayland_surface); void wayland_window_flush(HWND hwnd); +/********************************************************************** + * Wayland Window + */ + +/* private window data */ +struct wayland_win_data +{ + struct rb_entry entry; + /* hwnd that this private data belongs to */ + HWND hwnd; + /* wayland surface (if any) for this window */ + struct wayland_surface *wayland_surface; + /* wine window_surface backing this window */ + struct window_surface *window_surface; + /* USER window rectangle relative to win32 parent window client area */ + RECT window_rect; + /* USER client rectangle relative to win32 parent window client area */ + RECT client_rect; + BOOL managed; +}; + +struct wayland_win_data *wayland_win_data_get(HWND hwnd); +void wayland_win_data_release(struct wayland_win_data *data); + /********************************************************************** * Wayland Keyboard */ diff --git a/dlls/winewayland.drv/window.c b/dlls/winewayland.drv/window.c index c006505bc90..060a25d50c6 100644 --- a/dlls/winewayland.drv/window.c +++ b/dlls/winewayland.drv/window.c @@ -56,23 +56,6 @@ static BOOL set_window_pos(HWND hwnd, HWND after, INT x, INT y, INT cx, INT cy, } -/* private window data */ -struct wayland_win_data -{ - struct rb_entry entry; - /* hwnd that this private data belongs to */ - HWND hwnd; - /* wayland surface (if any) for this window */ - struct wayland_surface *wayland_surface; - /* wine window_surface backing this window */ - struct window_surface *window_surface; - /* USER window rectangle relative to win32 parent window client area */ - RECT window_rect; - /* USER client rectangle relative to win32 parent window client area */ - RECT client_rect; - BOOL managed; -}; - static int wayland_win_data_cmp_rb(const void *key, const struct rb_entry *entry) { @@ -153,7 +136,7 @@ static void wayland_win_data_destroy(struct wayland_win_data *data) * * Lock and return the data structure associated with a window. */ -static struct wayland_win_data *wayland_win_data_get(HWND hwnd) +struct wayland_win_data *wayland_win_data_get(HWND hwnd) { struct rb_entry *rb_entry; @@ -172,7 +155,7 @@ static struct wayland_win_data *wayland_win_data_get(HWND hwnd) * * Release the data returned by wayland_win_data_get. */ -static void wayland_win_data_release(struct wayland_win_data *data) +void wayland_win_data_release(struct wayland_win_data *data) { assert(data); pthread_mutex_unlock(&win_data_mutex); @@ -471,42 +454,6 @@ done: } -/*********************************************************************** - * WAYLAND_CreateWindowSurface - */ -BOOL WAYLAND_CreateWindowSurface(HWND hwnd, UINT swp_flags, const RECT *visible_rect, struct window_surface **surface) -{ - struct wayland_win_data *data; - RECT surface_rect; - - TRACE("hwnd %p, swp_flags %08x, visible %s, surface %p\n", hwnd, swp_flags, wine_dbgstr_rect(visible_rect), surface); - - if (!(data = wayland_win_data_get(hwnd))) return TRUE; /* use default surface */ - - /* Release the dummy surface wine provides for toplevels. */ - if (*surface) window_surface_release(*surface); - *surface = NULL; - - surface_rect = *visible_rect; - OffsetRect(&surface_rect, -surface_rect.left, -surface_rect.top); - - /* Check if we can reuse our current window surface. */ - if (data->window_surface && - EqualRect(&data->window_surface->rect, &surface_rect)) - { - window_surface_add_ref(data->window_surface); - *surface = data->window_surface; - TRACE("reusing surface %p\n", *surface); - goto done; - } - - *surface = wayland_window_surface_create(data->hwnd, &surface_rect); - -done: - wayland_win_data_release(data); - return TRUE; -} - /*********************************************************************** * WAYLAND_WindowPosChanged */ diff --git a/dlls/winewayland.drv/window_surface.c b/dlls/winewayland.drv/window_surface.c index 888fa74c085..9377b05b4ce 100644 --- a/dlls/winewayland.drv/window_surface.c +++ b/dlls/winewayland.drv/window_surface.c @@ -449,7 +449,7 @@ static const struct window_surface_funcs wayland_window_surface_funcs = /*********************************************************************** * wayland_window_surface_create */ -struct window_surface *wayland_window_surface_create(HWND hwnd, const RECT *rect) +static struct window_surface *wayland_window_surface_create(HWND hwnd, const RECT *rect) { char buffer[FIELD_OFFSET(BITMAPINFO, bmiColors[256])]; BITMAPINFO *info = (BITMAPINFO *)buffer; @@ -516,3 +516,40 @@ void wayland_window_surface_update_wayland_surface(struct window_surface *window window_surface_unlock(window_surface); } + + +/*********************************************************************** + * WAYLAND_CreateWindowSurface + */ +BOOL WAYLAND_CreateWindowSurface(HWND hwnd, UINT swp_flags, const RECT *visible_rect, struct window_surface **surface) +{ + struct wayland_win_data *data; + RECT surface_rect; + + TRACE("hwnd %p, swp_flags %08x, visible %s, surface %p\n", hwnd, swp_flags, wine_dbgstr_rect(visible_rect), surface); + + if (!(data = wayland_win_data_get(hwnd))) return TRUE; /* use default surface */ + + /* Release the dummy surface wine provides for toplevels. */ + if (*surface) window_surface_release(*surface); + *surface = NULL; + + surface_rect = *visible_rect; + OffsetRect(&surface_rect, -surface_rect.left, -surface_rect.top); + + /* Check if we can reuse our current window surface. */ + if (data->window_surface && + EqualRect(&data->window_surface->rect, &surface_rect)) + { + window_surface_add_ref(data->window_surface); + *surface = data->window_surface; + TRACE("reusing surface %p\n", *surface); + goto done; + } + + *surface = wayland_window_surface_create(data->hwnd, &surface_rect); + +done: + wayland_win_data_release(data); + return TRUE; +}

1 0