- Wine-Commits - list.winehq.org

Jacek Caban : ntdll: Declare seh debug channel in signal_arm64ec.c.
by Alexandre Julliard Dec. 11, 2023

Dec. 11, 2023

Module: wine Branch: master Commit: 6ea417d33930e495679ad799d7ddb1b26b4452cb URL: https://gitlab.winehq.org/wine/wine/-/commit/6ea417d33930e495679ad799d7ddb1… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Sun Dec 10 20:40:36 2023 +0100 ntdll: Declare seh debug channel in signal_arm64ec.c. --- dlls/ntdll/signal_arm64ec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dlls/ntdll/signal_arm64ec.c b/dlls/ntdll/signal_arm64ec.c index 9422bdefc0f..3d6bc39468d 100644 --- a/dlls/ntdll/signal_arm64ec.c +++ b/dlls/ntdll/signal_arm64ec.c @@ -34,6 +34,7 @@ #include "ntsyscalls.h" WINE_DEFAULT_DEBUG_CHANNEL(unwind); +WINE_DECLARE_DEBUG_CHANNEL(seh); WINE_DECLARE_DEBUG_CHANNEL(relay);

1 0

Akihiro Sagawa : winex11: Do window search if IDropTarget::DragOver() returns DROPEFFECT_NONE.
by Alexandre Julliard Dec. 11, 2023

Dec. 11, 2023

Module: wine Branch: master Commit: c03c17277f4a2ffa49f97ea43f201abf09e25a78 URL: https://gitlab.winehq.org/wine/wine/-/commit/c03c17277f4a2ffa49f97ea43f201a… Author: Akihiro Sagawa <sagawa.aki(a)gmail.com> Date: Mon Dec 11 23:09:31 2023 +0900 winex11: Do window search if IDropTarget::DragOver() returns DROPEFFECT_NONE. Fixes a regression from 1d337249f16ed61163315019f5dbbe4db3386390. Prior to the commit, we were solving this case in a different way. If IDropTarget::DragOver() returned DROPEFFECT_NONE, X11DRV_XDND_DROPEFFECTToXdndAction() would convert it to XdndActionCopy. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55179 --- dlls/winex11.drv/xdnd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/dlls/winex11.drv/xdnd.c b/dlls/winex11.drv/xdnd.c index ce99941c021..0e1a747b604 100644 --- a/dlls/winex11.drv/xdnd.c +++ b/dlls/winex11.drv/xdnd.c @@ -233,7 +233,7 @@ NTSTATUS WINAPI x11drv_dnd_position_event( void *arg, ULONG size ) } } - if (XDNDAccepted) + if (XDNDAccepted && XDNDDropEffect != DROPEFFECT_NONE) accept = 1; else { @@ -246,7 +246,7 @@ NTSTATUS WINAPI x11drv_dnd_position_event( void *arg, ULONG size ) } } - return accept ? effect : 0; + return accept ? effect : DROPEFFECT_NONE; } NTSTATUS x11drv_dnd_drop_event( UINT arg ) @@ -319,7 +319,7 @@ NTSTATUS x11drv_dnd_drop_event( UINT arg ) TRACE("effectRequested(0x%lx) accept(%d) performed(0x%lx) at x(%ld),y(%ld)\n", XDNDDropEffect, accept, effect, XDNDxy.x, XDNDxy.y); - return accept ? effect : 0; + return accept ? effect : DROPEFFECT_NONE; } /**************************************************************************

1 0

Jacek Caban : dwrite: Explicitly cast DWRITE_FONT_STRETCH to float in init_font_prop_vec.
by Alexandre Julliard Dec. 11, 2023

Dec. 11, 2023

Module: wine Branch: master Commit: e4ee1ffeb9e5ef562de3883352c325e8cb2b0b1e URL: https://gitlab.winehq.org/wine/wine/-/commit/e4ee1ffeb9e5ef562de3883352c325… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Thu Dec 7 00:43:01 2023 +0100 dwrite: Explicitly cast DWRITE_FONT_STRETCH to float in init_font_prop_vec. --- dlls/dwrite/font.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/dwrite/font.c b/dlls/dwrite/font.c index 6a3e49dcc58..2028440ca8e 100644 --- a/dlls/dwrite/font.c +++ b/dlls/dwrite/font.c @@ -685,7 +685,7 @@ static void init_font_prop_vec(DWRITE_FONT_WEIGHT weight, DWRITE_FONT_STRETCH st struct dwrite_font_propvec *vec) { vec->stretch = ((INT32)stretch - DWRITE_FONT_STRETCH_NORMAL) * 11.0f; - vec->style = style * 7.0f; + vec->style = (float)style * 7.0f; vec->weight = ((INT32)weight - DWRITE_FONT_WEIGHT_NORMAL) / 100.0f * 5.0f; }

1 0

Bartosz Kosiorek : po: Update Polish translation.
by Alexandre Julliard Dec. 11, 2023

Dec. 11, 2023

Module: wine Branch: master Commit: a56954faf4094d20cf3f065151cae50e29b7701d URL: https://gitlab.winehq.org/wine/wine/-/commit/a56954faf4094d20cf3f065151cae5… Author: Bartosz Kosiorek <gang65(a)poczta.onet.pl> Date: Sat Dec 9 01:49:11 2023 +0100 po: Update Polish translation. --- po/pl.po | 521 +++++++++++++++++---------------------------------------------- 1 file changed, 140 insertions(+), 381 deletions(-)

1 0

Alexandros Frantzis : winewayland.drv: Avoid deadlock when determining whether a window is managed.
by Alexandre Julliard Dec. 11, 2023

Dec. 11, 2023

Module: wine Branch: master Commit: a71ec54df817ee721fd1026832d968ce234ced9d URL: https://gitlab.winehq.org/wine/wine/-/commit/a71ec54df817ee721fd1026832d968… Author: Alexandros Frantzis <alexandros.frantzis(a)collabora.com> Date: Mon Dec 11 08:55:07 2023 +0200 winewayland.drv: Avoid deadlock when determining whether a window is managed. The is_window_managed function may acquire the (non-recursive) win_data lock internally (is_window_managed->has_owned_popups->is_managed), so do not call it with the win_data lock held. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55995 --- dlls/winewayland.drv/window.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/dlls/winewayland.drv/window.c b/dlls/winewayland.drv/window.c index 4775b64fa76..bb7f6ad6707 100644 --- a/dlls/winewayland.drv/window.c +++ b/dlls/winewayland.drv/window.c @@ -463,17 +463,23 @@ void WAYLAND_WindowPosChanged(HWND hwnd, HWND insert_after, UINT swp_flags, const RECT *visible_rect, const RECT *valid_rects, struct window_surface *surface) { - struct wayland_win_data *data = wayland_win_data_get(hwnd); + struct wayland_win_data *data; + BOOL managed; TRACE("hwnd %p window %s client %s visible %s after %p flags %08x\n", hwnd, wine_dbgstr_rect(window_rect), wine_dbgstr_rect(client_rect), wine_dbgstr_rect(visible_rect), insert_after, swp_flags); - if (!data) return; + /* Get the managed state with win_data unlocked, as is_window_managed + * may need to query win_data information about other HWNDs and thus + * acquire the lock itself internally. */ + managed = is_window_managed(hwnd, swp_flags, window_rect); + + if (!(data = wayland_win_data_get(hwnd))) return; data->window_rect = *window_rect; data->client_rect = *client_rect; - data->managed = is_window_managed(hwnd, swp_flags, window_rect); + data->managed = managed; if (surface) window_surface_add_ref(surface); if (data->window_surface) window_surface_release(data->window_surface);

1 0

Floris Renaud : po: Update Dutch translation.
by Alexandre Julliard Dec. 11, 2023

Dec. 11, 2023

Module: wine Branch: master Commit: f43246a389424a3df056b13d5aa13bd00a0cbee0 URL: https://gitlab.winehq.org/wine/wine/-/commit/f43246a389424a3df056b13d5aa13b… Author: Floris Renaud <jkfloris(a)dds.nl> Date: Mon Dec 11 21:49:54 2023 +0100 po: Update Dutch translation. --- po/nl.po | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/po/nl.po b/po/nl.po index d9b8385978d..f35f6a7c201 100644 --- a/po/nl.po +++ b/po/nl.po @@ -5,7 +5,7 @@ msgstr "" "Project-Id-Version: Wine\n" "Report-Msgid-Bugs-To: https://bugs.winehq.org\n" "POT-Creation-Date: N/A\n" -"PO-Revision-Date: 2023-11-09 19:50+0100\n" +"PO-Revision-Date: 2023-12-11 19:30+0100\n" "Last-Translator: Floris Renaud <jkfloris(a)dds.nl>\n" "Language-Team: Dutch\n" "Language: nl\n" @@ -12647,10 +12647,8 @@ msgid "Duplex:" msgstr "Dubbelzijdig:" #: dlls/wineps.drv/wineps.rc:45 -#, fuzzy -#| msgid "&Tray:" msgid "Paper &Tray:" -msgstr "La&de:" +msgstr "Papierla&de:" #: dlls/wininet/wininet.rc:53 dlls/wininet/wininet.rc:73 msgid "Realm" @@ -14778,17 +14776,15 @@ msgid "&Run..." msgstr "&Uitvoeren..." #: programs/explorer/explorer.rc:36 -#, fuzzy -#| msgid "E&xit Windows" msgid "E&xit desktop" -msgstr "Windows &afsluiten" +msgstr "&Scherm sluiten" #: programs/explorer/explorer.rc:37 -#, fuzzy -#| msgid "Are you sure you want to delete these values?" msgid "" "Are you sure you want to close all programs and exit the virtual desktop?" -msgstr "Moeten deze waarden verwijderd worden?" +msgstr "" +"Alle programma's en het virtuele bureaublad worden afgesloten.\n" +"Doorgaan?" #: programs/findstr/findstr.rc:28 msgid "Usage: findstr /options string\n"

1 0

Conor McCarthy : vkd3d-shader/spirv: Bitcast if necessary in the spirv_compiler_emit_mov() general implementation.
by Alexandre Julliard Dec. 11, 2023

Dec. 11, 2023

Module: vkd3d Branch: master Commit: 2037daae3221de0713c0c049d3c6fbbe53216340 URL: https://gitlab.winehq.org/wine/vkd3d/-/commit/2037daae3221de0713c0c049d3c6f… Author: Conor McCarthy <cmccarthy(a)codeweavers.com> Date: Tue Dec 5 14:36:22 2023 +1000 vkd3d-shader/spirv: Bitcast if necessary in the spirv_compiler_emit_mov() general implementation. In SM 6, this is needed when storing an asfloat() or asuint() result in an indexable temp, because dxc performs the bitcast by casting the destination pointer. --- libs/vkd3d-shader/spirv.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/libs/vkd3d-shader/spirv.c b/libs/vkd3d-shader/spirv.c index 4624def6..a60246fd 100644 --- a/libs/vkd3d-shader/spirv.c +++ b/libs/vkd3d-shader/spirv.c @@ -6926,6 +6926,11 @@ static void spirv_compiler_emit_mov(struct spirv_compiler *compiler, general_implementation: val_id = spirv_compiler_emit_load_src(compiler, src, dst->write_mask); + if (dst->reg.data_type != src->reg.data_type) + { + val_id = vkd3d_spirv_build_op_bitcast(builder, vkd3d_spirv_get_type_id_for_data_type(builder, + dst->reg.data_type, vkd3d_write_mask_component_count(dst->write_mask)), val_id); + } spirv_compiler_emit_store_dst(compiler, dst, val_id); }

1 0

Fabian Maurer : vkd3d-shader/dxil: Check null pointer before it is dereferenced (Coverity).
by Alexandre Julliard Dec. 11, 2023

Dec. 11, 2023

Module: vkd3d Branch: master Commit: 9cb43723788994631ef322c6e43b14e0c79fec18 URL: https://gitlab.winehq.org/wine/vkd3d/-/commit/9cb43723788994631ef322c6e43b1… Author: Fabian Maurer <dark.shadow4(a)web.de> Date: Sun Dec 10 19:58:37 2023 +0100 vkd3d-shader/dxil: Check null pointer before it is dereferenced (Coverity). --- libs/vkd3d-shader/dxil.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/libs/vkd3d-shader/dxil.c b/libs/vkd3d-shader/dxil.c index 9d1c69f1..4175a1af 100644 --- a/libs/vkd3d-shader/dxil.c +++ b/libs/vkd3d-shader/dxil.c @@ -3202,8 +3202,10 @@ static void sm6_parser_emit_binop(struct sm6_parser *sm6, const struct dxil_reco unsigned int i = 0; a = sm6_parser_get_value_by_ref(sm6, record, NULL, &i); + if (!a) + return; b = sm6_parser_get_value_by_ref(sm6, record, a->type, &i); - if (!a || !b) + if (!b) return; if (!dxil_record_validate_operand_count(record, i + 1, i + 2, sm6)) @@ -3994,8 +3996,10 @@ static void sm6_parser_emit_cmp2(struct sm6_parser *sm6, const struct dxil_recor } a = sm6_parser_get_value_by_ref(sm6, record, NULL, &i); + if (!a) + return; b = sm6_parser_get_value_by_ref(sm6, record, a->type, &i); - if (!a || !b) + if (!b) return; if (!dxil_record_validate_operand_count(record, i + 1, i + 2, sm6))

1 0

Conor McCarthy : vkd3d-shader/dxil: Implement the DXIL ALLOCA instruction.
by Alexandre Julliard Dec. 11, 2023

Dec. 11, 2023

Module: vkd3d Branch: master Commit: 2d5f2bf7a4d3fce80171874585f08d2df4992e65 URL: https://gitlab.winehq.org/wine/vkd3d/-/commit/2d5f2bf7a4d3fce80171874585f08… Author: Conor McCarthy <cmccarthy(a)codeweavers.com> Date: Tue Nov 21 14:20:25 2023 +1000 vkd3d-shader/dxil: Implement the DXIL ALLOCA instruction. --- libs/vkd3d-shader/dxil.c | 92 +++++++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 88 insertions(+), 4 deletions(-) diff --git a/libs/vkd3d-shader/dxil.c b/libs/vkd3d-shader/dxil.c index 6752cd14..9d104561 100644 --- a/libs/vkd3d-shader/dxil.c +++ b/libs/vkd3d-shader/dxil.c @@ -29,6 +29,9 @@ static const uint64_t MAX_ALIGNMENT_EXPONENT = 29; static const uint64_t GLOBALVAR_FLAG_IS_CONSTANT = 1; static const uint64_t GLOBALVAR_FLAG_EXPLICIT_TYPE = 2; static const unsigned int GLOBALVAR_ADDRESS_SPACE_SHIFT = 2; +static const uint64_t ALLOCA_FLAG_IN_ALLOCA = 0x20; +static const uint64_t ALLOCA_FLAG_EXPLICIT_TYPE = 0x40; +static const uint64_t ALLOCA_ALIGNMENT_MASK = ALLOCA_FLAG_IN_ALLOCA - 1; static const unsigned int SHADER_DESCRIPTOR_TYPE_COUNT = 4; static const unsigned int dx_max_thread_group_size[3] = {1024, 1024, 64}; @@ -2688,12 +2691,15 @@ static void sm6_parser_declare_icb(struct sm6_parser *sm6, const struct sm6_type } static void sm6_parser_declare_indexable_temp(struct sm6_parser *sm6, const struct sm6_type *elem_type, - unsigned int count, unsigned int alignment, unsigned int init, struct sm6_value *dst) + unsigned int count, unsigned int alignment, unsigned int init, struct vkd3d_shader_instruction *ins, + struct sm6_value *dst) { enum vkd3d_data_type data_type = vkd3d_data_type_from_sm6_type(elem_type); - struct vkd3d_shader_instruction *ins; - ins = sm6_parser_add_instruction(sm6, VKD3DSIH_DCL_INDEXABLE_TEMP); + if (ins) + vsir_instruction_init(ins, &sm6->p.location, VKD3DSIH_DCL_INDEXABLE_TEMP); + else + ins = sm6_parser_add_instruction(sm6, VKD3DSIH_DCL_INDEXABLE_TEMP); ins->declaration.indexable_temp.register_idx = sm6->indexable_temp_count++; ins->declaration.indexable_temp.register_size = count; ins->declaration.indexable_temp.alignment = alignment; @@ -2826,7 +2832,7 @@ static bool sm6_parser_declare_global(struct sm6_parser *sm6, const struct dxil_ if (is_constant) sm6_parser_declare_icb(sm6, scalar_type, count, alignment, init, dst); else - sm6_parser_declare_indexable_temp(sm6, scalar_type, count, alignment, init, dst); + sm6_parser_declare_indexable_temp(sm6, scalar_type, count, alignment, init, NULL, dst); } else if (address_space == ADDRESS_SPACE_GROUPSHARED) { @@ -3019,6 +3025,81 @@ static struct sm6_block *sm6_block_create() return block; } +static void sm6_parser_emit_alloca(struct sm6_parser *sm6, const struct dxil_record *record, + struct vkd3d_shader_instruction *ins, struct sm6_value *dst) +{ + const struct sm6_type *type[2], *elem_type; + const struct sm6_value *size; + unsigned int i, alignment; + uint64_t packed_operands; + + if (!dxil_record_validate_operand_count(record, 4, 4, sm6)) + return; + + for (i = 0; i < 2; ++i) + { + if (!(type[i] = sm6_parser_get_type(sm6, record->operands[i]))) + return; + } + + packed_operands = record->operands[3]; + if (packed_operands & ALLOCA_FLAG_IN_ALLOCA) + WARN("Ignoring in_alloca flag.\n"); + if (!(packed_operands & ALLOCA_FLAG_EXPLICIT_TYPE)) + { + FIXME("Unhandled implicit type.\n"); + vkd3d_shader_parser_error(&sm6->p, VKD3D_SHADER_ERROR_DXIL_INVALID_OPERAND, + "Implicit result type for ALLOCA instructions is not supported."); + return; + } + packed_operands &= ~(ALLOCA_FLAG_IN_ALLOCA | ALLOCA_FLAG_EXPLICIT_TYPE); + + if (!sm6_type_is_array(type[0]) || !sm6_type_is_numeric(elem_type = type[0]->u.array.elem_type)) + { + WARN("Type is not a numeric array.\n"); + vkd3d_shader_parser_error(&sm6->p, VKD3D_SHADER_ERROR_DXIL_INVALID_OPERAND, + "Result type of an ALLOCA instruction is not a numeric array."); + return; + } + /* The second type operand is the type of the allocation size operand, in case it is a + * forward reference. We only support a constant size, so no forward ref support is needed. */ + if (!sm6_type_is_integer(type[1])) + { + WARN("Size operand type is not scalar integer.\n"); + vkd3d_shader_parser_error(&sm6->p, VKD3D_SHADER_ERROR_DXIL_INVALID_OPERAND, + "The type of the allocation size operand of an ALLOCA instruction is not scalar integer."); + return; + } + + if (!(dst->type = sm6_type_get_pointer_to_type(type[0], ADDRESS_SPACE_DEFAULT, sm6))) + { + WARN("Failed to get pointer type for type class %u.\n", type[0]->class); + vkd3d_shader_parser_error(&sm6->p, VKD3D_SHADER_ERROR_DXIL_INVALID_MODULE, + "Module does not define a pointer type for an ALLOCA instruction."); + return; + } + + if (!(size = sm6_parser_get_value_safe(sm6, record->operands[2]))) + return; + /* A size of 1 means one instance of type[0], i.e. one array. */ + if (sm6_value_get_constant_uint(size) != 1) + { + FIXME("Allocation size is not 1.\n"); + vkd3d_shader_parser_error(&sm6->p, VKD3D_SHADER_ERROR_DXIL_INVALID_OPERAND, + "ALLOCA instruction allocation sizes other than 1 are not supported."); + return; + } + + if (!bitcode_parse_alignment(packed_operands & ALLOCA_ALIGNMENT_MASK, &alignment)) + WARN("Invalid alignment %"PRIu64".\n", packed_operands); + packed_operands &= ~ALLOCA_ALIGNMENT_MASK; + + if (packed_operands) + WARN("Ignoring flags %#"PRIx64".\n", packed_operands); + + sm6_parser_declare_indexable_temp(sm6, elem_type, type[0]->u.array.count, alignment, 0, ins, dst); +} + static enum vkd3d_shader_opcode map_binary_op(uint64_t code, const struct sm6_type *type_a, const struct sm6_type *type_b, struct sm6_parser *sm6) { @@ -4578,6 +4659,9 @@ static enum vkd3d_result sm6_parser_function_init(struct sm6_parser *sm6, const record = block->records[i]; switch (record->code) { + case FUNC_CODE_INST_ALLOCA: + sm6_parser_emit_alloca(sm6, record, ins, dst); + break; case FUNC_CODE_INST_BINOP: sm6_parser_emit_binop(sm6, record, ins, dst); break;

1 0

Conor McCarthy : tests/shader-runner: Add a non-const-indexing test for asfloat() result storage.
by Alexandre Julliard Dec. 11, 2023

Dec. 11, 2023

Module: vkd3d Branch: master Commit: af86cdf713307879aa55a0addc26f4b44890812d URL: https://gitlab.winehq.org/wine/vkd3d/-/commit/af86cdf713307879aa55a0addc26f… Author: Conor McCarthy <cmccarthy(a)codeweavers.com> Date: Tue Dec 5 14:43:12 2023 +1000 tests/shader-runner: Add a non-const-indexing test for asfloat() result storage. --- tests/hlsl/non-const-indexing.shader_test | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/tests/hlsl/non-const-indexing.shader_test b/tests/hlsl/non-const-indexing.shader_test index e7b814d3..82a6e321 100644 --- a/tests/hlsl/non-const-indexing.shader_test +++ b/tests/hlsl/non-const-indexing.shader_test @@ -196,6 +196,26 @@ draw quad probe all rgba (1126, 3344, 5566, 3788) +[pixel shader] +uint i, j; + +float4 main() : sv_target +{ + float mut1[4] = {1, 2, 3, 4}; + + /* dxc emits a pointer bitcast, which results in a VSIR MOV with mismatched data types. */ + mut1[i] = asfloat(j); + + return float4(mut1[0], mut1[1], mut1[2], mut1[3]); +} + +[test] +uniform 0 uint 1 +uniform 1 uint 0x40a00000 +draw quad +probe all rgba (1, 5, 3, 4) + + [pixel shader] uniform float4 f[4]; uniform uint4 u;

1 0