Davide Beatrici : winepulse: Lock sessions in AudioClient's Start.

[Alexandre Julliard]

Module: wine
Branch: master
Commit: 71a6691978a1b56effbd45307c0e4d7ce1369fd7
URL:    https://gitlab.winehq.org/wine/wine/-/commit/71a6691978a1b56effbd45307c0e4d7...

Author: Davide Beatrici <git(a)davidebeatrici.dev>
Date:   Wed Jun  7 10:33:05 2023 +0200

winepulse: Lock sessions in AudioClient's Start.

---

 dlls/winepulse.drv/mmdevdrv.c | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/dlls/winepulse.drv/mmdevdrv.c b/dlls/winepulse.drv/mmdevdrv.c
index 64b399f2a2b..1b0966b9634 100644
--- a/dlls/winepulse.drv/mmdevdrv.c
+++ b/dlls/winepulse.drv/mmdevdrv.c
@@ -952,24 +952,28 @@ static HRESULT WINAPI AudioClient_Start(IAudioClient3 *iface)
 {
     ACImpl *This = impl_from_IAudioClient3(iface);
     struct start_params params;
-    HRESULT hr;
 
     TRACE("(%p)\n", This);
 
-    if (!This->stream)
+    sessions_lock();
+
+    if (!This->stream) {
+        sessions_unlock();
         return AUDCLNT_E_NOT_INITIALIZED;
+    }
 
     params.stream = This->stream;
+
     pulse_call(start, ¶ms);
-    if (FAILED(hr = params.result))
-        return hr;
 
-    if (!This->timer_thread) {
+    if (SUCCEEDED(params.result) && !This->timer_thread) {
         This->timer_thread = CreateThread(NULL, 0, pulse_timer_cb, This, 0, NULL);
         SetThreadPriority(This->timer_thread, THREAD_PRIORITY_TIME_CRITICAL);
     }
 
-    return S_OK;
+    sessions_unlock();
+
+    return params.result;
 }
 
 extern HRESULT WINAPI client_Stop(IAudioClient3 *iface);