Carlo Bramini : wininet: Use return value of sprintf() instead of calling strlen() and simplify code.

[Alexandre Julliard]

Module: wine
Branch: master
Commit: 47ff95429a143c1c1600e417e752f257dcb5f9e2
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=47ff95429a143c1c1600e417e7...

Author: Carlo Bramini <carlo.bramix(a)libero.it>
Date:   Sat Nov 12 10:36:20 2016 +0100

wininet: Use return value of sprintf() instead of calling strlen() and simplify code.

Signed-off-by: Carlo Bramini <carlo_bramini(a)users.sourceforge.net>
Signed-off-by: Jacek Caban <jacek(a)codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard(a)winehq.org>

---

 dlls/wininet/internet.c | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/dlls/wininet/internet.c b/dlls/wininet/internet.c
index 4e1f3b9..772e4c1 100644
--- a/dlls/wininet/internet.c
+++ b/dlls/wininet/internet.c
@@ -4112,8 +4112,7 @@ static BOOL calc_url_length(LPURL_COMPONENTSW lpUrlComponents,
         {
             char szPort[MAX_WORD_DIGITS+1];
 
-            sprintf(szPort, "%d", lpUrlComponents->nPort);
-            *lpdwUrlLength += strlen(szPort);
+            *lpdwUrlLength += sprintf(szPort, "%d", lpUrlComponents->nPort);
             *lpdwUrlLength += strlen(":");
         }
 
@@ -4356,14 +4355,9 @@ BOOL WINAPI InternetCreateUrlW(LPURL_COMPONENTSW lpUrlComponents, DWORD dwFlags,
 
         if (!url_uses_default_port(nScheme, lpUrlComponents->nPort))
         {
-            WCHAR szPort[MAX_WORD_DIGITS+1];
-
-            sprintfW(szPort, fmtW, lpUrlComponents->nPort);
             *lpszUrl = ':';
             lpszUrl++;
-            dwLen = strlenW(szPort);
-            memcpy(lpszUrl, szPort, dwLen * sizeof(WCHAR));
-            lpszUrl += dwLen;
+            lpszUrl += sprintfW(lpszUrl, fmtW, lpUrlComponents->nPort);
         }
 
         /* add slash between hostname and path if necessary */