Ziqing Hui : winegstreamer: Create wg_transform for WMV decoder.

[Alexandre Julliard]

Module: wine
Branch: master
Commit: e23f9e4dfd7eb8df3b64acb136f9da1742647d56
URL:    https://gitlab.winehq.org/wine/wine/-/commit/e23f9e4dfd7eb8df3b64acb136f9da1...

Author: Ziqing Hui <zhui(a)codeweavers.com>
Date:   Fri Feb  3 18:05:01 2023 +0800

winegstreamer: Create wg_transform for WMV decoder.

---

 dlls/mf/tests/transform.c         |  8 +++-
 dlls/winegstreamer/wg_transform.c |  4 +-
 dlls/winegstreamer/wmv_decoder.c  | 94 ++++++++++++++++++++++++++++++++-------
 3 files changed, 87 insertions(+), 19 deletions(-)

diff --git a/dlls/mf/tests/transform.c b/dlls/mf/tests/transform.c
index 17b59c46b97..914789db84a 100644
--- a/dlls/mf/tests/transform.c
+++ b/dlls/mf/tests/transform.c
@@ -5243,8 +5243,12 @@ static void test_wmv_decoder_media_object(void)
     hr = CoInitialize(NULL);
     ok(hr == S_OK, "CoInitialize failed, hr %#lx.\n", hr);
 
-    hr = CoCreateInstance(class_id, NULL, CLSCTX_INPROC_SERVER, &IID_IMediaObject, (void **)&media_object);
-    ok(hr == S_OK, "CoCreateInstance returned %#lx.\n", hr);
+    if (FAILED(hr = CoCreateInstance(class_id, NULL, CLSCTX_INPROC_SERVER, &IID_IMediaObject, (void **)&media_object)))
+    {
+        CoUninitialize();
+        winetest_pop_context();
+        return;
+    }
 
     /* Test GetStreamCount. */
     in_count = out_count = 0xdeadbeef;
diff --git a/dlls/winegstreamer/wg_transform.c b/dlls/winegstreamer/wg_transform.c
index 65a34511284..ccdd90361fc 100644
--- a/dlls/winegstreamer/wg_transform.c
+++ b/dlls/winegstreamer/wg_transform.c
@@ -428,6 +428,7 @@ NTSTATUS wg_transform_create(void *args)
         case WG_MAJOR_TYPE_AUDIO_WMA:
         case WG_MAJOR_TYPE_VIDEO_CINEPAK:
         case WG_MAJOR_TYPE_VIDEO_INDEO:
+        case WG_MAJOR_TYPE_VIDEO_WMV:
             if (!(element = transform_find_element(GST_ELEMENT_FACTORY_TYPE_DECODER, src_caps, raw_caps))
                     || !transform_append_element(transform, element, &first, &last))
             {
@@ -440,7 +441,6 @@ NTSTATUS wg_transform_create(void *args)
         case WG_MAJOR_TYPE_VIDEO:
             break;
         case WG_MAJOR_TYPE_UNKNOWN:
-        case WG_MAJOR_TYPE_VIDEO_WMV:
             GST_FIXME("Format %u not implemented!", input_format.major_type);
             gst_caps_unref(raw_caps);
             goto out;
@@ -469,6 +469,7 @@ NTSTATUS wg_transform_create(void *args)
             break;
 
         case WG_MAJOR_TYPE_VIDEO:
+        case WG_MAJOR_TYPE_VIDEO_WMV:
             if (!(element = create_element("videoconvert", "base"))
                     || !transform_append_element(transform, element, &first, &last))
                 goto out;
@@ -482,7 +483,6 @@ NTSTATUS wg_transform_create(void *args)
         case WG_MAJOR_TYPE_VIDEO_CINEPAK:
         case WG_MAJOR_TYPE_VIDEO_H264:
         case WG_MAJOR_TYPE_UNKNOWN:
-        case WG_MAJOR_TYPE_VIDEO_WMV:
         case WG_MAJOR_TYPE_VIDEO_INDEO:
             GST_FIXME("Format %u not implemented!", output_format.major_type);
             goto out;
diff --git a/dlls/winegstreamer/wmv_decoder.c b/dlls/winegstreamer/wmv_decoder.c
index ed61ee0e2e3..9011d2cf182 100644
--- a/dlls/winegstreamer/wmv_decoder.c
+++ b/dlls/winegstreamer/wmv_decoder.c
@@ -28,6 +28,7 @@
 #include "wine/debug.h"
 
 WINE_DEFAULT_DEBUG_CHANNEL(mfplat);
+WINE_DECLARE_DEBUG_CHANNEL(winediag);
 
 extern const GUID MEDIASUBTYPE_VC1S;
 
@@ -83,6 +84,9 @@ struct wmv_decoder
     struct wg_format input_format;
     struct wg_format output_format;
     GUID output_subtype;
+
+    struct wg_transform *wg_transform;
+    struct wg_sample_queue *wg_sample_queue;
 };
 
 static bool wg_format_is_set(struct wg_format *format)
@@ -140,7 +144,12 @@ static ULONG WINAPI unknown_Release(IUnknown *iface)
     TRACE("iface %p decreasing refcount to %lu.\n", iface, refcount);
 
     if (!refcount)
+    {
+        if (impl->wg_transform)
+            wg_transform_destroy(impl->wg_transform);
+        wg_sample_queue_destroy(impl->wg_sample_queue);
         free(impl);
+    }
 
     return refcount;
 }
@@ -489,6 +498,11 @@ static HRESULT WINAPI media_object_SetInputType(IMediaObject *iface, DWORD index
         if (flags & DMO_SET_TYPEF_CLEAR)
         {
             memset(&decoder->input_format, 0, sizeof(decoder->input_format));
+            if (decoder->wg_transform)
+            {
+                wg_transform_destroy(decoder->wg_transform);
+                decoder->wg_transform = NULL;
+            }
             return S_OK;
         }
         return DMO_E_TYPE_NOT_ACCEPTED;
@@ -509,8 +523,15 @@ static HRESULT WINAPI media_object_SetInputType(IMediaObject *iface, DWORD index
     wg_format.u.video_wmv.fps_n = 0;
     wg_format.u.video_wmv.fps_d = 0;
 
-    if (!(flags & DMO_SET_TYPEF_TEST_ONLY))
-        decoder->input_format = wg_format;
+    if (flags & DMO_SET_TYPEF_TEST_ONLY)
+        return S_OK;
+
+    decoder->input_format = wg_format;
+    if (decoder->wg_transform)
+    {
+        wg_transform_destroy(decoder->wg_transform);
+        decoder->wg_transform = NULL;
+    }
 
     return S_OK;
 }
@@ -532,6 +553,11 @@ static HRESULT WINAPI media_object_SetOutputType(IMediaObject *iface, DWORD inde
         if (flags & DMO_SET_TYPEF_CLEAR)
         {
             memset(&decoder->output_format, 0, sizeof(decoder->output_format));
+            if (decoder->wg_transform)
+            {
+                wg_transform_destroy(decoder->wg_transform);
+                decoder->wg_transform = NULL;
+            }
             return S_OK;
         }
         return E_POINTER;
@@ -555,11 +581,20 @@ static HRESULT WINAPI media_object_SetOutputType(IMediaObject *iface, DWORD inde
     wg_format.u.video.fps_n = 0;
     wg_format.u.video.fps_d = 0;
 
-    if (!(flags & DMO_SET_TYPEF_TEST_ONLY))
+    if (flags & DMO_SET_TYPEF_TEST_ONLY)
+        return S_OK;
+
+    decoder->output_subtype = type->subtype;
+    decoder->output_format = wg_format;
+
+    /* Set up wg_transform. */
+    if (decoder->wg_transform)
     {
-        decoder->output_subtype = type->subtype;
-        decoder->output_format = wg_format;
+        wg_transform_destroy(decoder->wg_transform);
+        decoder->wg_transform = NULL;
     }
+    if (!(decoder->wg_transform = wg_transform_create(&decoder->input_format, &decoder->output_format)))
+        return E_FAIL;
 
     return S_OK;
 }
@@ -804,22 +839,51 @@ static const IPropertyStoreVtbl property_store_vtbl =
 
 HRESULT wmv_decoder_create(IUnknown *outer, IUnknown **out)
 {
-    struct wmv_decoder *impl;
+    static const struct wg_format input_format =
+    {
+        .major_type = WG_MAJOR_TYPE_VIDEO_WMV,
+        .u.video_wmv.format = WG_WMV_VIDEO_FORMAT_WMV3,
+    };
+    static const struct wg_format output_format =
+    {
+        .major_type = WG_MAJOR_TYPE_VIDEO,
+        .u.video =
+        {
+            .format = WG_VIDEO_FORMAT_NV12,
+            .width = 1920,
+            .height = 1080,
+        },
+    };
+    struct wg_transform *transform;
+    struct wmv_decoder *decoder;
+    HRESULT hr;
 
     TRACE("outer %p, out %p.\n", outer, out);
 
-    if (!(impl = calloc(1, sizeof(*impl))))
+    if (!(transform = wg_transform_create(&input_format, &output_format)))
+    {
+        ERR_(winediag)("GStreamer doesn't support WMV decoding, please install appropriate plugins.\n");
+        return E_FAIL;
+    }
+    wg_transform_destroy(transform);
+
+    if (!(decoder = calloc(1, sizeof(*decoder))))
         return E_OUTOFMEMORY;
+    if (FAILED(hr = wg_sample_queue_create(&decoder->wg_sample_queue)))
+    {
+        free(decoder);
+        return hr;
+    }
 
-    impl->IUnknown_inner.lpVtbl = &unknown_vtbl;
-    impl->IMFTransform_iface.lpVtbl = &transform_vtbl;
-    impl->IMediaObject_iface.lpVtbl = &media_object_vtbl;
-    impl->IPropertyBag_iface.lpVtbl = &property_bag_vtbl;
-    impl->IPropertyStore_iface.lpVtbl = &property_store_vtbl;
-    impl->refcount = 1;
-    impl->outer = outer ? outer : &impl->IUnknown_inner;
+    decoder->IUnknown_inner.lpVtbl = &unknown_vtbl;
+    decoder->IMFTransform_iface.lpVtbl = &transform_vtbl;
+    decoder->IMediaObject_iface.lpVtbl = &media_object_vtbl;
+    decoder->IPropertyBag_iface.lpVtbl = &property_bag_vtbl;
+    decoder->IPropertyStore_iface.lpVtbl = &property_store_vtbl;
+    decoder->refcount = 1;
+    decoder->outer = outer ? outer : &decoder->IUnknown_inner;
 
-    *out = &impl->IUnknown_inner;
+    *out = &decoder->IUnknown_inner;
     TRACE("Created %p\n", *out);
     return S_OK;
 }