Alexandre Julliard : tests: Do not report flaky tests as failures by default.

[Alexandre Julliard]

Module: wine
Branch: master
Commit: c19f88646a594f2ca424b29a6b0dea3a30c8ac8a
URL:    https://gitlab.winehq.org/wine/wine/-/commit/c19f88646a594f2ca424b29a6b0dea3...

Author: Alexandre Julliard <julliard(a)winehq.org>
Date:   Mon Sep 26 10:43:46 2022 +0200

tests: Do not report flaky tests as failures by default.

---

 include/wine/test.h | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/include/wine/test.h b/include/wine/test.h
index e502c967d9b..94d92e19c57 100644
--- a/include/wine/test.h
+++ b/include/wine/test.h
@@ -44,8 +44,8 @@ extern int winetest_time;
 /* running in interactive mode? */
 extern int winetest_interactive;
 
-/* always count flaky tests as successful (BOOL) */
-extern int winetest_allow_flaky;
+/* report failed flaky tests as failures (BOOL) */
+extern int winetest_report_flaky;
 
 /* report successful tests (BOOL) */
 extern int winetest_report_success;
@@ -207,8 +207,8 @@ int winetest_interactive = 0;
 /* current platform */
 const char *winetest_platform = "windows";
 
-/* always count flaky tests as successful (BOOL) */
-int winetest_allow_flaky;
+/* report failed flaky tests as failures (BOOL) */
+int winetest_report_flaky = 0;
 
 /* report successful tests (BOOL) */
 int winetest_report_success = 0;
@@ -731,7 +731,7 @@ static int run_test( const char *name )
         winetest_print_unlock();
     }
     status = failures + todo_failures;
-    if (!winetest_allow_flaky) status += flaky_failures;
+    if (winetest_report_flaky) status += flaky_failures;
     if (status > 255) status = 255;
     return status;
 }
@@ -807,7 +807,7 @@ int main( int argc, char **argv )
     }
     if (GetEnvironmentVariableA( "WINETEST_DEBUG", p, sizeof(p) )) winetest_debug = atoi(p);
     if (GetEnvironmentVariableA( "WINETEST_INTERACTIVE", p, sizeof(p) )) winetest_interactive = atoi(p);
-    if (GetEnvironmentVariableA( "WINETEST_ALLOW_FLAKY", p, sizeof(p) )) winetest_allow_flaky = atoi(p);
+    if (GetEnvironmentVariableA( "WINETEST_REPORT_FLAKY", p, sizeof(p) )) winetest_report_flaky = atoi(p);
     if (GetEnvironmentVariableA( "WINETEST_REPORT_SUCCESS", p, sizeof(p) )) winetest_report_success = atoi(p);
     if (GetEnvironmentVariableA( "WINETEST_TIME", p, sizeof(p) )) winetest_time = atoi(p);
     winetest_last_time = winetest_start_time = GetTickCount();