Rémi Bernon : mfplat/mediatype: Implement MFCreateMediaTypeFromRepresentation.

[Alexandre Julliard]

Module: wine
Branch: master
Commit: 1e053810f3fec90bf20eb536d1e7dd063e3a581d
URL:    https://gitlab.winehq.org/wine/wine/-/commit/1e053810f3fec90bf20eb536d1e7dd0...

Author: Rémi Bernon <rbernon(a)codeweavers.com>
Date:   Tue Mar  5 23:03:31 2024 +0100

mfplat/mediatype: Implement MFCreateMediaTypeFromRepresentation.

---

 dlls/mfplat/mediatype.c    | 26 +++++++++++++++++++++++
 dlls/mfplat/mfplat.spec    |  2 +-
 dlls/mfplat/tests/mfplat.c | 51 ++++++++++++++++++++++++++++++++++++++++++++++
 include/mfapi.h            |  2 ++
 4 files changed, 80 insertions(+), 1 deletion(-)

diff --git a/dlls/mfplat/mediatype.c b/dlls/mfplat/mediatype.c
index 9c4b9877e02..f584e1aae26 100644
--- a/dlls/mfplat/mediatype.c
+++ b/dlls/mfplat/mediatype.c
@@ -4334,3 +4334,29 @@ HRESULT WINAPI MFInitMediaTypeFromAMMediaType(IMFMediaType *media_type, const AM
 
     return hr;
 }
+
+/***********************************************************************
+ *      MFCreateMediaTypeFromRepresentation (mfplat.@)
+ */
+HRESULT WINAPI MFCreateMediaTypeFromRepresentation(GUID guid_representation, void *representation,
+        IMFMediaType **media_type)
+{
+    HRESULT hr;
+
+    TRACE("%s, %p, %p\n", debugstr_guid(&guid_representation), representation, media_type);
+
+    if (!IsEqualGUID(&guid_representation, &AM_MEDIA_TYPE_REPRESENTATION))
+        return MF_E_UNSUPPORTED_REPRESENTATION;
+    if (!representation || !media_type)
+        return E_INVALIDARG;
+
+    if (FAILED(hr = MFCreateMediaType(media_type)))
+        return hr;
+    if (FAILED(hr = MFInitMediaTypeFromAMMediaType(*media_type, representation)))
+    {
+        IMFMediaType_Release(*media_type);
+        *media_type = NULL;
+    }
+
+    return hr;
+}
diff --git a/dlls/mfplat/mfplat.spec b/dlls/mfplat/mfplat.spec
index d8a6eb5ce83..57db3cdf9f6 100644
--- a/dlls/mfplat/mfplat.spec
+++ b/dlls/mfplat/mfplat.spec
@@ -59,7 +59,7 @@
 @ stub MFCreateMediaBufferWrapper
 @ stdcall MFCreateMediaEvent(long ptr long ptr ptr)
 @ stdcall MFCreateMediaType(ptr)
-@ stub MFCreateMediaTypeFromRepresentation
+@ stdcall MFCreateMediaTypeFromRepresentation(int128 ptr ptr)
 @ stdcall MFCreateMemoryBuffer(long ptr)
 @ stub MFCreateMemoryStream
 @ stdcall MFCreatePathFromURL(wstr ptr)
diff --git a/dlls/mfplat/tests/mfplat.c b/dlls/mfplat/tests/mfplat.c
index 0cfe296b260..2ff78a2b05a 100644
--- a/dlls/mfplat/tests/mfplat.c
+++ b/dlls/mfplat/tests/mfplat.c
@@ -8524,6 +8524,56 @@ static void test_IMFMediaType_GetRepresentation(void)
     IMFMediaType_Release(media_type);
 }
 
+static void test_MFCreateMediaTypeFromRepresentation(void)
+{
+    IMFMediaType *media_type;
+    AM_MEDIA_TYPE amt = {0};
+    WAVEFORMATEX wfx = {0};
+    HRESULT hr;
+    GUID guid;
+
+    hr = MFCreateMediaTypeFromRepresentation(GUID_NULL, &amt, &media_type);
+    ok(hr == MF_E_UNSUPPORTED_REPRESENTATION, "Unexpected hr %#lx.\n", hr);
+    hr = MFCreateMediaTypeFromRepresentation(AM_MEDIA_TYPE_REPRESENTATION, NULL, &media_type);
+    ok(hr == E_INVALIDARG, "Unexpected hr %#lx.\n", hr);
+    hr = MFCreateMediaTypeFromRepresentation(AM_MEDIA_TYPE_REPRESENTATION, &amt, NULL);
+    ok(hr == E_INVALIDARG, "Unexpected hr %#lx.\n", hr);
+
+    hr = MFCreateMediaTypeFromRepresentation(AM_MEDIA_TYPE_REPRESENTATION, &amt, &media_type);
+    todo_wine
+    ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
+    if (hr == S_OK)
+    {
+        memset(&guid, 0xcd, sizeof(guid));
+        hr = IMFMediaType_GetGUID(media_type, &MF_MT_MAJOR_TYPE, &guid);
+        ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
+        ok(IsEqualGUID(&guid, &GUID_NULL), "got %s.\n", debugstr_guid(&guid));
+        memset(&guid, 0xcd, sizeof(guid));
+        hr = IMFMediaType_GetGUID(media_type, &MF_MT_SUBTYPE, &guid);
+        ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
+        ok(IsEqualGUID(&guid, &GUID_NULL), "got %s.\n", debugstr_guid(&guid));
+        IMFMediaType_Release(media_type);
+    }
+
+    amt.formattype = FORMAT_WaveFormatEx;
+    amt.majortype = MFMediaType_Audio;
+    amt.subtype = MFAudioFormat_PCM;
+    amt.pbFormat = (BYTE *)&wfx;
+    amt.cbFormat = sizeof(wfx);
+    hr = MFCreateMediaTypeFromRepresentation(AM_MEDIA_TYPE_REPRESENTATION, &amt, &media_type);
+    ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
+    memset(&guid, 0xcd, sizeof(guid));
+    hr = IMFMediaType_GetGUID(media_type, &MF_MT_MAJOR_TYPE, &guid);
+    ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
+    ok(IsEqualGUID(&guid, &MFMediaType_Audio), "got %s.\n", debugstr_guid(&guid));
+    memset(&guid, 0xcd, sizeof(guid));
+    hr = IMFMediaType_GetGUID(media_type, &MF_MT_SUBTYPE, &guid);
+    ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
+    todo_wine
+    ok(IsEqualGUID(&guid, &MFAudioFormat_PCM), "got %s.\n", debugstr_guid(&guid));
+    IMFMediaType_Release(media_type);
+}
+
 static void test_MFCreateDXSurfaceBuffer(void)
 {
     IDirect3DSurface9 *backbuffer = NULL, *surface;
@@ -11798,6 +11848,7 @@ START_TEST(mfplat)
     test_MFCreateAMMediaTypeFromMFMediaType();
     test_MFInitMediaTypeFromMFVideoFormat();
     test_IMFMediaType_GetRepresentation();
+    test_MFCreateMediaTypeFromRepresentation();
     test_MFCreateDXSurfaceBuffer();
     test_MFCreateTrackedSample();
     test_MFFrameRateToAverageTimePerFrame();
diff --git a/include/mfapi.h b/include/mfapi.h
index f986edd0d5a..0a9f7c6f415 100644
--- a/include/mfapi.h
+++ b/include/mfapi.h
@@ -549,6 +549,8 @@ HRESULT WINAPI MFCreateMediaEvent(MediaEventType type, REFGUID extended_type, HR
 HRESULT WINAPI MFCreateMediaType(IMFMediaType **type);
 HRESULT WINAPI MFCreateAMMediaTypeFromMFMediaType(IMFMediaType *media_type, GUID format_type, AM_MEDIA_TYPE **am_type);
 HRESULT WINAPI MFCreateMFVideoFormatFromMFMediaType(IMFMediaType *media_type, MFVIDEOFORMAT **video_format, UINT32 *size);
+HRESULT WINAPI MFCreateMediaTypeFromRepresentation(GUID guid_representation, void *representation,
+        IMFMediaType **media_type);
 HRESULT WINAPI MFCreateSample(IMFSample **sample);
 HRESULT WINAPI MFCreateTempFile(MF_FILE_ACCESSMODE accessmode, MF_FILE_OPENMODE openmode, MF_FILE_FLAGS flags,
         IMFByteStream **bytestream);