Francois Gouget : testbot/web: Skip GetDisplayValue() for the JobDetails page.

[Alexandre Julliard]

Module: tools
Branch: master
Commit: 8de0125d8b61145721f7debd2238c2941742983b
URL:    https://source.winehq.org/git/tools.git/?a=commit;h=8de0125d8b61145721f7debd...

Author: Francois Gouget <fgouget(a)codeweavers.com>
Date:   Wed Apr  6 01:15:03 2022 +0200

testbot/web: Skip GetDisplayValue() for the JobDetails page.

The job details page knows which property it is accessing so there is no
need to go through the generic GetDisplayValue(). This makes the code
more readable.

Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard(a)winehq.org>

---

 testbot/web/JobDetails.pl | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/testbot/web/JobDetails.pl b/testbot/web/JobDetails.pl
index ae99b21..5a24204 100644
--- a/testbot/web/JobDetails.pl
+++ b/testbot/web/JobDetails.pl
@@ -96,7 +96,7 @@ sub GenerateDataCell($$$$)
   if ($PropertyName eq "VM")
   {
     print "<td><a href='#k", $self->escapeHTML($StepTask->GetKey()), "'>";
-    print $self->escapeHTML($self->GetDisplayValue($StepTask, $PropertyDescriptor));
+    print $self->escapeHTML($StepTask->VM->Name);
     print "</a></td>\n";
   }
   elsif ($PropertyName eq "FileName")
@@ -108,7 +108,7 @@ sub GenerateDataCell($$$$)
       my $URI = "/GetFile.pl?JobKey=" . uri_escape($JobId) .
                   "&StepKey=" . uri_escape($StepTask->StepNo);
       print "<td><a href='" . $self->escapeHTML($URI) . "'>";
-      print $self->escapeHTML($self->GetDisplayValue($StepTask, $PropertyDescriptor));
+      print $self->escapeHTML($StepTask->FileName);
       print "</a></td>\n";
     }
     else