Francisco Casas : vkd3d-shader/hlsl: Consider register() as manual packing for resource fields.

[Alexandre Julliard]

Module: vkd3d
Branch: master
Commit: f3e81327dc775e4e794618558696971ee1741fdc
URL:    https://gitlab.winehq.org/wine/vkd3d/-/commit/f3e81327dc775e4e79461855869697...

Author: Francisco Casas <fcasas(a)codeweavers.com>
Date:   Wed Mar  1 15:57:31 2023 -0300

vkd3d-shader/hlsl: Consider register() as manual packing for resource fields.

---

 libs/vkd3d-shader/hlsl_codegen.c | 5 +++--
 tests/cbuffer.shader_test        | 8 ++++----
 2 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/libs/vkd3d-shader/hlsl_codegen.c b/libs/vkd3d-shader/hlsl_codegen.c
index 610b576c..5d7e426f 100644
--- a/libs/vkd3d-shader/hlsl_codegen.c
+++ b/libs/vkd3d-shader/hlsl_codegen.c
@@ -2994,10 +2994,11 @@ static void validate_buffer_offsets(struct hlsl_ctx *ctx)
     LIST_FOR_EACH_ENTRY(var1, &ctx->extern_vars, struct hlsl_ir_var, extern_entry)
     {
         buffer = var1->buffer;
-        if (!buffer)
+        if (!buffer || buffer == ctx->globals_buffer)
             continue;
 
-        if (var1->reg_reservation.offset_type == 'c')
+        if (var1->reg_reservation.offset_type
+                || (var1->data_type->class == HLSL_CLASS_OBJECT && var1->reg_reservation.reg_type))
             buffer->manually_packed_elements = true;
         else
             buffer->automatically_packed_elements = true;
diff --git a/tests/cbuffer.shader_test b/tests/cbuffer.shader_test
index e95a5235..9cf42d9d 100644
--- a/tests/cbuffer.shader_test
+++ b/tests/cbuffer.shader_test
@@ -607,7 +607,7 @@ float4 main() : sv_target
 }
 
 % register() can be used instead of packoffset().
-[pixel shader todo]
+[pixel shader]
 cbuffer buffer
 {
     float4 foo : packoffset(c0);
@@ -619,7 +619,7 @@ float4 main() : sv_target
     return 0;
 }
 
-[pixel shader todo]
+[pixel shader]
 cbuffer buffer
 {
     float4 foo : packoffset(c0);
@@ -632,7 +632,7 @@ float4 main() : sv_target
 }
 
 % Using register() alone is considered manual packing for resources, so the other fields expect packoffset().
-[pixel shader fail todo]
+[pixel shader fail]
 cbuffer buffer
 {
     float4 foo;
@@ -644,7 +644,7 @@ float4 main() : sv_target
     return 0;
 }
 
-[pixel shader fail todo]
+[pixel shader fail]
 cbuffer buffer
 {
     float4 foo;