Hans Leidekker : secur32: Only return success from initialize_package() when initialization fully succeeds.

[Alexandre Julliard]

Module: wine
Branch: master
Commit: ed71abd1ccfdec44aa487ec6a14fdf4c54f52ad2
URL:    https://gitlab.winehq.org/wine/wine/-/commit/ed71abd1ccfdec44aa487ec6a14fdf4...

Author: Hans Leidekker <hans(a)codeweavers.com>
Date:   Thu Sep 28 12:07:09 2023 +0200

secur32: Only return success from initialize_package() when initialization fully succeeds.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55522

---

 dlls/secur32/lsa.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/dlls/secur32/lsa.c b/dlls/secur32/lsa.c
index 3b124c4da1f..7af9c285d86 100644
--- a/dlls/secur32/lsa.c
+++ b/dlls/secur32/lsa.c
@@ -907,10 +907,12 @@ static BOOL initialize_package(struct lsa_package *package,
             {
                 status = pSpUserModeInitialize(SECPKG_INTERFACE_VERSION, &package->user_api_version, &package->user_api, &package->user_table_count);
                 if (status == STATUS_SUCCESS)
+                {
                     package->user_api->InstanceInit(SECPKG_INTERFACE_VERSION, &lsa_dll_dispatch, NULL);
+                    return TRUE;
+                }
             }
         }
-        return TRUE;
     }
 
     return FALSE;