Francois Gouget : testbot/WineSendLog: Report TestBot errors to the mailing list too.

[Alexandre Julliard]

Module: tools
Branch: master
Commit: 3920a8357fa228c63f1ecfd0749cfe5e3ec9d6d0
URL:    https://source.winehq.org/git/tools.git/?a=commit;h=3920a8357fa228c63f1ecfd0...

Author: Francois Gouget <fgouget(a)codeweavers.com>
Date:   Thu Aug 30 01:59:53 2018 +0200

testbot/WineSendLog: Report TestBot errors to the mailing list too.

TestBot errors may or may not be caused by the patch but either way
they make it impossible to know if there are new errors. Thus the patch
requires extra scrutiny anyway.

Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard(a)winehq.org>

---

 testbot/bin/WineSendLog.pl | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/testbot/bin/WineSendLog.pl b/testbot/bin/WineSendLog.pl
index b0efa8c..a4b1c82 100755
--- a/testbot/bin/WineSendLog.pl
+++ b/testbot/bin/WineSendLog.pl
@@ -279,13 +279,10 @@ EOF
     my $StepTask = $StepsTasks->GetItem($Key);
     my $TaskDir = $StepTask->GetTaskDir();
 
-    if ($StepTask->Status eq "boterror")
-    {
-      # TestBot errors are not the developer's fault and prevent us from
-      # identifying new errors. So skip.
-      Error "A Task error was found in '$TaskDir/log.err'\n";
-      next;
-    }
+    # Note: We could check $StepTask->Status for TestBot errors. However,
+    # whether they are caused by the patch or not, they prevent the TestBot
+    # from checking for new errors which justifies sending an email to the
+    # mailing list so that the patch receives greater scrutiny.
 
     foreach my $LogName (@{$JobErrors->{$Key}->{LogNames}})
     {