Zebediah Figura : wined3d: Do not track dirty ranges for buffers without WINED3D_BUFFER_USE_BO.

[Alexandre Julliard]

Module: wine
Branch: master
Commit: 307b200363d78fbb00c3519a38b26a9f044e402e
URL:    https://gitlab.winehq.org/wine/wine/-/commit/307b200363d78fbb00c3519a38b26a9...

Author: Zebediah Figura <zfigura(a)codeweavers.com>
Date:   Sat Oct 14 12:57:11 2023 -0500

wined3d: Do not track dirty ranges for buffers without WINED3D_BUFFER_USE_BO.

Since we never upload the buffer, and may very well never invalidate the whole
thing, this just results in continually increasing memory consumption.

This is especially a problem for our internal push constant buffers, which are
sysmem buffers that usually are never wholly invalidated, but it could also
potentially be a problem for other buffers.

---

 dlls/wined3d/buffer.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/dlls/wined3d/buffer.c b/dlls/wined3d/buffer.c
index 2d5bbcf4d79..57c6085c10a 100644
--- a/dlls/wined3d/buffer.c
+++ b/dlls/wined3d/buffer.c
@@ -122,7 +122,7 @@ static void wined3d_buffer_invalidate_range(struct wined3d_buffer *buffer, DWORD
     TRACE("buffer %p, location %s, offset %u, size %u.\n",
             buffer, wined3d_debug_location(location), offset, size);
 
-    if (location & WINED3D_LOCATION_BUFFER)
+    if ((location & WINED3D_LOCATION_BUFFER) && (buffer->flags & WINED3D_BUFFER_USE_BO))
         buffer_invalidate_bo_range(buffer, offset, size);
 
     buffer->locations &= ~location;
@@ -1399,7 +1399,7 @@ static HRESULT wined3d_buffer_init(struct wined3d_buffer *buffer, struct wined3d
             return E_OUTOFMEMORY;
     }
 
-    if (!wined3d_array_reserve((void **)&buffer->dirty_ranges,
+    if ((buffer->flags & WINED3D_BUFFER_USE_BO) && !wined3d_array_reserve((void **)&buffer->dirty_ranges,
             &buffer->dirty_ranges_capacity, 1, sizeof(*buffer->dirty_ranges)))
     {
         ERR("Out of memory.\n");