Connor McAdams : combase: Use correct destination context in CoUnmarshalInterface when using the standard marshaler.

[Alexandre Julliard]

Module: wine
Branch: master
Commit: a42f5f197093f0942d1c1ee60f1cf0d8a7b610cd
URL:    https://gitlab.winehq.org/wine/wine/-/commit/a42f5f197093f0942d1c1ee60f1cf0d...

Author: Connor McAdams <cmcadams(a)codeweavers.com>
Date:   Thu Jun 29 08:36:25 2023 -0400

combase: Use correct destination context in CoUnmarshalInterface when using the standard marshaler.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54609
Signed-off-by: Connor McAdams <cmcadams(a)codeweavers.com>

---

 dlls/combase/combase_private.h |  1 +
 dlls/combase/marshal.c         |  8 +++++---
 dlls/combase/stubmanager.c     | 25 +++++++++++++++++++++++++
 dlls/ole32/tests/marshal.c     |  2 +-
 4 files changed, 32 insertions(+), 4 deletions(-)

diff --git a/dlls/combase/combase_private.h b/dlls/combase/combase_private.h
index f9c349c3e20..53932e9a357 100644
--- a/dlls/combase/combase_private.h
+++ b/dlls/combase/combase_private.h
@@ -256,4 +256,5 @@ struct ifstub * stub_manager_new_ifstub(struct stub_manager *m, IRpcStubBuffer *
 HRESULT ipid_get_dispatch_params(const IPID *ipid, struct apartment **stub_apt,
         struct stub_manager **manager, IRpcStubBuffer **stub, IRpcChannelBuffer **chan,
         IID *iid, IUnknown **iface);
+HRESULT ipid_get_dest_context(const IPID *ipid, MSHCTX *dest_context, void **dest_context_data);
 HRESULT start_apartment_remote_unknown(struct apartment *apt);
diff --git a/dlls/combase/marshal.c b/dlls/combase/marshal.c
index e2f6a57d8e1..84f57b8c1c8 100644
--- a/dlls/combase/marshal.c
+++ b/dlls/combase/marshal.c
@@ -698,7 +698,7 @@ HRESULT WINAPI CoReleaseMarshalData(IStream *stream)
 }
 
 static HRESULT std_unmarshal_interface(MSHCTX dest_context, void *dest_context_data,
-        IStream *stream, REFIID riid, void **ppv)
+        IStream *stream, REFIID riid, void **ppv, BOOL dest_context_known)
 {
     struct stub_manager *stubmgr = NULL;
     struct OR_STANDARD obj;
@@ -757,6 +757,8 @@ static HRESULT std_unmarshal_interface(MSHCTX dest_context, void *dest_context_d
         {
             if (!stub_manager_notify_unmarshal(stubmgr, &obj.std.ipid))
                 hres = CO_E_OBJNOTCONNECTED;
+            if (SUCCEEDED(hres) && !dest_context_known)
+                hres = ipid_get_dest_context(&obj.std.ipid, &dest_context, &dest_context_data);
         }
         else
         {
@@ -803,7 +805,7 @@ HRESULT WINAPI CoUnmarshalInterface(IStream *stream, REFIID riid, void **ppv)
     hr = get_unmarshaler_from_stream(stream, &marshal, &iid);
     if (hr == S_FALSE)
     {
-        hr = std_unmarshal_interface(0, NULL, stream, &iid, (void **)&object);
+        hr = std_unmarshal_interface(0, NULL, stream, &iid, (void **)&object, FALSE);
         if (hr != S_OK)
             ERR("StdMarshal UnmarshalInterface failed, hr %#lx\n", hr);
     }
@@ -2183,7 +2185,7 @@ static HRESULT WINAPI StdMarshalImpl_UnmarshalInterface(IMarshal *iface, IStream
         return E_NOTIMPL;
     }
 
-    return std_unmarshal_interface(marshal->dest_context, marshal->dest_context_data, stream, riid, ppv);
+    return std_unmarshal_interface(marshal->dest_context, marshal->dest_context_data, stream, riid, ppv, TRUE);
 }
 
 static HRESULT WINAPI StdMarshalImpl_ReleaseMarshalData(IMarshal *iface, IStream *stream)
diff --git a/dlls/combase/stubmanager.c b/dlls/combase/stubmanager.c
index ff8937d7bd7..1b079f22fef 100644
--- a/dlls/combase/stubmanager.c
+++ b/dlls/combase/stubmanager.c
@@ -554,6 +554,31 @@ HRESULT ipid_get_dispatch_params(const IPID *ipid, struct apartment **stub_apt,
     return S_OK;
 }
 
+HRESULT ipid_get_dest_context(const IPID *ipid, MSHCTX *dest_context, void **dest_context_data)
+{
+    struct stub_manager *stubmgr;
+    struct ifstub *ifstub;
+    struct apartment *apt;
+    void *data;
+    HRESULT hr;
+    DWORD ctx;
+
+    hr = ipid_to_ifstub(ipid, &apt, &stubmgr, &ifstub);
+    if (hr != S_OK) return RPC_E_DISCONNECTED;
+
+    hr = IRpcChannelBuffer_GetDestCtx(ifstub->chan, &ctx, &data);
+    if (SUCCEEDED(hr))
+    {
+        *dest_context = ctx;
+        *dest_context_data = data;
+    }
+
+    stub_manager_int_release(stubmgr);
+    apartment_release(apt);
+
+    return hr;
+}
+
 /* returns TRUE if it is possible to unmarshal, FALSE otherwise. */
 BOOL stub_manager_notify_unmarshal(struct stub_manager *m, const IPID *ipid)
 {
diff --git a/dlls/ole32/tests/marshal.c b/dlls/ole32/tests/marshal.c
index f76505ea1bf..cbad8c46117 100644
--- a/dlls/ole32/tests/marshal.c
+++ b/dlls/ole32/tests/marshal.c
@@ -589,7 +589,7 @@ static HRESULT WINAPI RpcProxyBuffer_Connect(IRpcProxyBuffer *iface, IRpcChannel
 
     hr = IRpcChannelBuffer_GetDestCtx(pRpcChannelBuffer, &dest_context, &dest_context_data);
     ok(hr == S_OK, "GetDestCtx failed: %08lx\n", hr);
-    todo_wine ok(dest_context == MSHCTX_INPROC, "desc_context = %lx\n", dest_context);
+    ok(dest_context == MSHCTX_INPROC, "desc_context = %lx\n", dest_context);
     ok(!dest_context_data, "desc_context_data = %p\n", dest_context_data);
 
     return IRpcProxyBuffer_Connect(This->buffer, pRpcChannelBuffer);