Connor McAdams : uiautomationcore: Implement IUIAutomationElement::get_CachedName.

[Alexandre Julliard]

Module: wine
Branch: master
Commit: f9f59d109fef46489abaf4f084133e7774ad28b6
URL:    https://gitlab.winehq.org/wine/wine/-/commit/f9f59d109fef46489abaf4f084133e7...

Author: Connor McAdams <cmcadams(a)codeweavers.com>
Date:   Thu Sep 21 10:56:55 2023 -0400

uiautomationcore: Implement IUIAutomationElement::get_CachedName.

Signed-off-by: Connor McAdams <cmcadams(a)codeweavers.com>

---

 dlls/uiautomationcore/tests/uiautomation.c | 14 ++++++--------
 dlls/uiautomationcore/uia_com_client.c     | 21 +++++++++++++++++++--
 2 files changed, 25 insertions(+), 10 deletions(-)

diff --git a/dlls/uiautomationcore/tests/uiautomation.c b/dlls/uiautomationcore/tests/uiautomation.c
index 6eb1f204dbb..2f2a5e1329c 100644
--- a/dlls/uiautomationcore/tests/uiautomation.c
+++ b/dlls/uiautomationcore/tests/uiautomation.c
@@ -13635,25 +13635,23 @@ static void test_Element_cache_methods(IUIAutomation *uia_iface)
 
     /* Cached UIA_NamePropertyId helper. */
     hr = IUIAutomationElement_get_CachedName(element, NULL);
-    todo_wine ok(hr == E_POINTER, "Unexpected hr %#lx.\n", hr);
+    ok(hr == E_POINTER, "Unexpected hr %#lx.\n", hr);
 
     tmp_bstr = (void *)0xdeadbeef;
     hr = IUIAutomationElement_get_CachedName(element, &tmp_bstr);
-    todo_wine ok(hr == E_INVALIDARG, "Unexpected hr %#lx.\n", hr);
+    ok(hr == E_INVALIDARG, "Unexpected hr %#lx.\n", hr);
     ok(tmp_bstr == (void *)0xdeadbeef, "Unexpected BSTR ptr %p\n", tmp_bstr);
 
     tmp_bstr = NULL;
     hr = IUIAutomationElement_get_CachedName(element2, &tmp_bstr);
-    todo_wine ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
-    if (SUCCEEDED(hr))
-        ok(!lstrcmpW(tmp_bstr, L""), "Unexpected BSTR %s\n", wine_dbgstr_w(tmp_bstr));
+    ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
+    ok(!lstrcmpW(tmp_bstr, L""), "Unexpected BSTR %s\n", wine_dbgstr_w(tmp_bstr));
     SysFreeString(tmp_bstr);
 
     tmp_bstr = NULL;
     hr = IUIAutomationElement_get_CachedName(element3, &tmp_bstr);
-    todo_wine ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
-    if (SUCCEEDED(hr))
-        ok(!lstrcmpW(tmp_bstr, uia_bstr_prop_str), "Unexpected BSTR %s\n", wine_dbgstr_w(tmp_bstr));
+    ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
+    ok(!lstrcmpW(tmp_bstr, uia_bstr_prop_str), "Unexpected BSTR %s\n", wine_dbgstr_w(tmp_bstr));
     SysFreeString(tmp_bstr);
 
     /* Cached UIA_ControlTypePropertyId. */
diff --git a/dlls/uiautomationcore/uia_com_client.c b/dlls/uiautomationcore/uia_com_client.c
index d517b680bdd..d383abe0d9b 100644
--- a/dlls/uiautomationcore/uia_com_client.c
+++ b/dlls/uiautomationcore/uia_com_client.c
@@ -2424,8 +2424,25 @@ static HRESULT WINAPI uia_element_get_CachedLocalizedControlType(IUIAutomationEl
 
 static HRESULT WINAPI uia_element_get_CachedName(IUIAutomationElement9 *iface, BSTR *ret_val)
 {
-    FIXME("%p: stub\n", iface);
-    return E_NOTIMPL;
+    struct uia_element *element = impl_from_IUIAutomationElement9(iface);
+    struct uia_cache_property *cache_prop = NULL;
+    const int prop_id = UIA_NamePropertyId;
+
+    TRACE("%p, %p\n", iface, ret_val);
+
+    if (!ret_val)
+        return E_POINTER;
+
+    if (!(cache_prop = bsearch(&prop_id, element->cached_props, element->cached_props_count, sizeof(*cache_prop),
+            uia_cached_property_id_compare)))
+        return E_INVALIDARG;
+
+    if ((V_VT(&cache_prop->prop_val) == VT_BSTR) && V_BSTR(&cache_prop->prop_val))
+        *ret_val = SysAllocString(V_BSTR(&cache_prop->prop_val));
+    else
+        *ret_val = SysAllocString(L"");
+
+    return S_OK;
 }
 
 static HRESULT WINAPI uia_element_get_CachedAcceleratorKey(IUIAutomationElement9 *iface, BSTR *ret_val)