November 2001 - Wine-Devel - list.winehq.org

What does user mean?
by Bill Medland Nov. 6, 2001

Nov. 6, 2001

I am working on the server code (adding the byte locking stuff) and down in the select/thread/object stuff I keep coming across the term "user" which seems to be synonymous with object. What is it supposed to mean? Why is an object a user? How does it relate to a physical person or a windows process or whatever? Bill

1 0

Re: queries on internals...
by Alexandre Julliard Nov. 6, 2001

Nov. 6, 2001

Francois Gouget <fgouget(a)free.fr> writes: > only returns one. I was also wondering how to best fix that. Since it is > a Winelib application and not a part of Wine I don't know if > implementing strsep in library/port.c is the best solution: shouldn't we > be able to compile regapi on Windows? In addition to that Wine itself > does not use strsep. I would like Alexandre's opinion on that :-) Just fix regapi so that it doesn't require strsep. There is no good reason to require it. -- Alexandre Julliard julliard(a)winehq.com

1 0

Extra info in scrollbar can be an handle.
by Marco Bizzarri Nov. 6, 2001

Nov. 6, 2001

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi all. We have an application which crashes when trying to access the Window Long info in a scrollbar. After some tracking, it looked like the issue was that in some cases the wExtra data can contain an handle rather than a pointer. The included patch solves the problem by making an explicit GlobalLock, and returning that value. I'm not sure this is the correct solution, so comments are welcome. wine is from the latest cvs - -- Marco Bizzarri - Responsabile Tecnico - Icube S.r.l. Sede: Via Ridolfi 15 - 56124 Pisa (PI), Italia E-mail: m.bizzarri(a)icube.it WWW: www.icube.it Tel: (+39) 050 97 02 07 Fax: (+39) 050 31 36 588 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (GNU/Linux) Comment: For info see http://quantumlab.net/pine_privacy_guard/ iD8DBQE759zoXhfyAQQVoaIRApoGAJwOhVqzWtvYCz1oHZTcYSCYeCDQ6wCePBE3 DJ/zoeclED29BCnaC+9Ya8E= =rU+H -----END PGP SIGNATURE-----

1 0

Re: RTS/CTS
by lawson_whitney＠juno.com Nov. 6, 2001

Nov. 6, 2001

On Tue, 6 Nov 2001, Mike McCormack wrote: > > Hi Lawson, > > good detective work! > > i don't think DSR/DTR flow control is supported by termios at all (at > least not in Linux), so here's a patch to ignore it. > > Mike > Okay, that passes the smoke test, and also looks right to me. Thanks. Did you forget a ChangeLog? Lawson Big fleas have little fleas upon their backs to bite 'em. And little fleas have smaller fleas and so on, infinitem.

1 0

Re: Winsock2 & overlapped IO
by Mike McCormack Nov. 6, 2001

Nov. 6, 2001

Hi Ove, >Hm, by the way, when are you going to implemented overlapped >ConnectNamedPipe? That might make my rpcrt4 wait-for-connection code a bit >cleaner, so I don't have to spawn a separate thread per named pipe, and >worse, use TerminateThread to cancel the wait... OK. i'll have a look at it. Having a full time job, a part time job and a girlfriend to take care of kind of eats into my time though :-) >The challenges for winsock2 should be pretty much the same as those for >implementing something like ReadFileEx (which you've probably already >done) and the above-mentioned overlapped ConnectNamedPipe. Yeah, ReadFileEx is pretty much complete. Perhaps i'll have a look into overlapped sockets too... don't hold your breath though ;-) Mike btw. nice work on OLE/InstallShield stuff ------------------------------------------ mailto:Mike_McCormack(a)start.com.au ph +82 16 430 0425 __________________________________________________________________ Get your free Australian email account at http://www.Looksmart.com.au

1 0

RTS/CTS
by lawson_whitney＠juno.com Nov. 6, 2001

Nov. 6, 2001

Good day! A couple of wine-users have said Wine doesn't work RTS/CTS right any more, so I did a +comm,+file trace of juno, and was rewarded with this: trace:comm:SetCommState handle 224, ptr 0x403f0578 trace:comm:SetCommState bytesize 8 baudrate 115200 fParity 0 Parity 0 stopbits 1 trace:comm:SetCommState ~IXON ~IXOFF trace:comm:SetCommState CRTSCTS trace:comm:SetCommState ~CRTSCTS Does something look wrong about that, or am I just seeing it crosseyed? In GetCommState we have this: if (port.c_cflag & CRTSCTS) { lpdcb->fDtrControl = DTR_CONTROL_ENABLE; lpdcb->fRtsControl = RTS_CONTROL_ENABLE; lpdcb->fOutxCtsFlow = 1; lpdcb->fOutxDsrFlow = 1; } else And in SetCommState this: if ( lpdcb->fOutxCtsFlow || lpdcb->fRtsControl == RTS_CONTROL_ENABLE ) { port.c_cflag |= CRTSCTS; TRACE("CRTSCTS\n"); } if (lpdcb->fDtrControl == DTR_CONTROL_ENABLE) { port.c_cflag &= ~CRTSCTS; TRACE("~CRTSCTS\n"); } So I guess if you want to turn off CRTSCTS, GetCommState(handle, lpdcb); SetCommState(handle, lpdcb); would about do it. I don't know what fDtrControl is 'spoze to do, but shutting off flow control entirely seems a bit extreme. Juno apparently asks for it by name, CRTSCTS was not on when it did GetCommState, but it asked for flow control, too. Lawson panic: detected rogue system administrator!! ---cut here

1 0

Re: SystemParametersInfo
by Andreas Mohr Nov. 5, 2001

Nov. 5, 2001

On Mon, Nov 05, 2001 at 06:20:24AM -0800, Andriy Palamarchuk wrote: > Please, review the new version of SystemParametersInfo > implementation. > > Is there any way to check: > 1) whether Wine process is the first process started > for current Wine server? Heh, I should really know ;-) CLIENT_IsBootThread(). > 2) whether Windows application runs under Wine or > Windows? Eh ? I don't quite understand the logic behind this. Could you elaborate ? -- Andreas Mohr Stauferstr. 6, D-71272 Renningen, Germany Tel. +49 7159 800604 http://home.nexgo.de/andi.mohr/

2 2

Re: Duplicated StrRetToStr functions in shell32
by Guy L. Albertelli Nov. 5, 2001

Nov. 5, 2001

Francois, The reason that these routines were duplicated is that the builtin shell32 cannot find StrRetToBuf{A|W} in some of the native versions of shlwapi.dll. This dependency prohibited testing with builtin vs. native shlwapi. The change was submitted to winehq about 8/28 and committed soon thereafter. Guy ----- Original Message ----- From: "Francois Gouget" <fgouget(a)free.fr> To: <wine-patches(a)winehq.com> Sent: Wednesday, October 31, 2001 11:46 PM Subject: Duplicated StrRetToStr functions in shell32 > > Shell32 contains StrRetToStrNA and StrRetToStrNW which are almost > identical to StrRetToBufA and StrRetToBufW. Since shell32 already > imports shlwapi it seems like we should just call the latter functions! > That way I won't have to fix the "0x%p" thing twice. > > > Changelog: > > * dlls/shell32/shellstring.c > > Implement StrRetToStrN{A,W} by calling shlwapi.StrRetToBuf{A,W} > instead of duplicating the code > > > > -- > Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ > I haven't lost my mind, it's backed up on tape around here somewhere... >

3 2

Winsock2 & overlapped IO
by Martin Wilck Nov. 5, 2001

Nov. 5, 2001

Hello, I have started porting a software product of our company from NT to Linux using Wine. Part of this software is an agent which implements a proprietary protocol implemented with Winsock 2. In particular, it uses the Winsock 2 feature of "Overlapped IO" on sockets, with user-supplied callbacks that are called when data is received on a socket etc. Browsing through the Wine Winsock code, I saw that this part of Winsock2 is obviously unimplemented. Q: Has anybody worked on this already? Is there existing code somewhere? Q: Can you give an estimate if implementation of these features would require substantial changes in core wine code (something I'd like to avoid)? Q: Can you give me guidance on what part of the functionality would live in the wine server and what in the client? Regards, Martin -- Martin Wilck Phone: +49 5251 8 15113 Fujitsu Siemens Computers Fax: +49 5251 8 20409 Heinz-Nixdorf-Ring 1 mailto:Martin.Wilck(a)Fujitsu-Siemens.com D-33106 Paderborn http://www.fujitsu-siemens.com/primergy

1 0

The Corel Wine LockFile code
by Medland, Bill Nov. 4, 2001

Nov. 4, 2001

Just enquiring. Why isn't the CorelWine locking code in the Wine tree? Is it merely because no-one has had the time, need or desire or is there something unacceptable about the way that they did it? (Also as a side issue it appears to me that it isn't going to work if the file is on a Windows machine because it looks to me like the fcntl stuff doesn't get handled by smbfs; any comments?) Bill

2 1

ImageList_Write stub
by j.m.maurer Nov. 4, 2001

Nov. 4, 2001

Hello Wine Developers! For a while now I want to use Delphi under Wine, which works for 99%. The one thing that is missing seems to be the implementation of ImageList::Write which prevents opening of Forms which contain an ImageList control. The output Wine gives is: -- fixme:imagelist:ImageList_Write empty stub! While searching through winehq.com I came across the URL http://www.winehq.com/WineAPI/ImageList_Write.html which describes that ImageList::Write is indeed not implemented due to the fact that IStream32::Write is not implemented.... Is implementing these functions a particular difficult task or has nobody had any spare time to do it yet? I have no knowlegde whatsoever of the structure of Wine or the Windows API, but I have some spare time and some code skills... Does anyone have any hints on this issue? Bye! Marc Maurer Please CC a reply to me, since I can't subscribe to this mailinglist, due to an unknown low level error reported by mailman :-)

2 1

Yet again: audio.c stuff
by Simon Britnell Nov. 2, 2001

Nov. 2, 2001

I've posted a substantial patch to audio.c which reorganises the code to make it a little easier to follow. It's been tested against HomeWorld and HalfLife. It works against homeworld with MIN_SLEEP_TIME 100, but not with MIN_SLEEP_TIME <=50. Feel free to set MIN_SLEEP_TIME to 0 to remove the minimum sleep time. The other thing the patch does is makes notifications dependant on bytes played rather than time elapsed. Should be a win overall. I'm still having no luck with tracking the actual race condition which causes HomeWorld to fail. I've not tried the patch you sent to fix the callback notification problem yet. I'll let you know when I do. __________________________________________________ Do You Yahoo!? Find a job, post your resume. http://careers.yahoo.com

1 0

minimise/maximise causes crash in 20011004
by mdew Nov. 2, 2001

Nov. 2, 2001

warn:heap:HEAP_ValidateInUseArena Heap 411d0000: invalid in-use arena magic for 411d08e7 warn:heap:HEAP_ValidateInUseArena Heap 411d0000: invalid in-use arena magic for 411d021b warn:heap:HEAP_ValidateInUseArena Heap 411d0000: invalid in-use arena magic for 411d0d97 warn:heap:HEAP_ValidateInUseArena Heap 411d0000: invalid in-use arena magic for 411d0d97 warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4071d3a7 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4071d3c0 is not inside heap warn:heap:HEAP_ValidateInUseArena Heap 411d0000: invalid in-use arena magic for 411d0d97 warn:gdi:GDI_GetObjPtr Invalid handle 0 warn:gdi:GDI_GetObjPtr Invalid handle 0 warn:heap:HEAP_ValidateInUseArena Heap 411d0000: invalid in-use arena magic for 411d04eb warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4071d3a7 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4071d3c0 is not inside heap warn:heap:HEAP_ValidateInUseArena Heap 411d0000: invalid in-use arena magic for 411d0d97 warn:gdi:GDI_GetObjPtr Invalid handle 0 warn:gdi:GDI_GetObjPtr Invalid handle 0 warn:gdi:GDI_GetObjPtr Invalid handle 0 warn:gdi:GDI_GetObjPtr Invalid handle 0 warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4c0b48 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4c0b61 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4c0b48 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4c0b61 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x40729933 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4072994c is not inside heap warn:heap:HEAP_ValidateInUseArena Heap 411d0000: invalid in-use arena magic for 411d08e7 warn:heap:HEAP_ValidateInUseArena Heap 411d0000: invalid in-use arena magic for 411d04eb warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4071d3a7 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4071d3c0 is not inside heap warn:heap:HEAP_ValidateInUseArena Heap 411d0000: invalid in-use arena magic for 411d0d97 warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x40710e43 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x40710e5c is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x40710e43 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x40710e5c is not inside heap warn:gdi:GDI_GetObjPtr Invalid handle 0 warn:gdi:GDI_GetObjPtr Invalid handle 0 warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4c0b48 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4c0b61 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4c0b48 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4c0b61 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x40729933 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4072994c is not inside heap warn:heap:HEAP_ValidateInUseArena Heap 411d0000: invalid in-use arena magic for 411d08e7 warn:heap:HEAP_ValidateInUseArena Heap 411d0000: invalid in-use arena magic for 411d00b3 warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4071d3a7 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4071d3c0 is not inside heap warn:heap:HEAP_ValidateInUseArena Heap 411d0000: invalid in-use arena magic for 411d0d97 warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x406f123f is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x406f1258 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x406f123f is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x406f1258 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x406f123f is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x406f1258 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x406f123f is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x406f1258 is not inside heapwarn:gdi:GDI_GetObjPtr Invalid handle 0 warn:gdi:GDI_GetObjPtr Invalid handle 0 warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4c0b48 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4c0b61 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4c0b48 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4c0b61 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x40729933 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4072994c is not inside heap warn:heap:HEAP_ValidateInUseArena Heap 411d0000: invalid in-use arena magic for 411d08e7 warn:heap:HEAP_ValidateInUseArena Heap 411d0000: invalid in-use arena magic for 411d00b3 warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4071d3a7 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4071d3c0 is not inside heap warn:heap:HEAP_ValidateInUseArena Heap 411d0000: invalid in-use arena magic for 411d0d97 warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x406f123f is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x406f1258 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x406f123f is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x406f1258 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x406f123f is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x406f1258 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x406f123f is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x406f1258 is not inside heap warn:gdi:GDI_GetObjPtr Invalid handle 0 warn:gdi:GDI_GetObjPtr Invalid handle 0 warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4c0b48 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4c0b61 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4c0b48 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4c0b61 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x40729933 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4072994c is not inside heap warn:heap:HEAP_ValidateInUseArena Heap 411d0000: invalid in-use arena magic for 411d08e7 warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4c0b48 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4c0b61 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4c0b48 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4c0b61 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x40729933 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4072994c is not inside heap warn:heap:HEAP_ValidateInUseArena Heap 411d0000: invalid in-use arena magic for 411d08e7 warn:heap:HEAP_ValidateInUseArena Heap 411d0000: invalid in-use arena magic for 411d030b warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4c0b48 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4c0b61 is not inside heap warn:gdi:GDI_GetObjPtr Invalid handle 20003e warn:gdi:GDI_GetObjPtr Invalid handle 20003e warn:gdi:GDI_GetObjPtr Invalid handle 20003e warn:gdi:GDI_GetObjPtr Invalid handle 20003e warn:gdi:GDI_GetObjPtr Invalid handle 20003e warn:gdi:GDI_GetObjPtr Invalid handle 20003e <wine crash> causing this crash was just the act of minimising/maximising channel windows in mirc.

1 0

RE: LockFile - any words of warning?
by Medland, Bill Nov. 1, 2001

Nov. 1, 2001

Thanks, but > -----Original Message----- > From: Rein Klazes [mailto:rklazes(a)xs4all.invalid] > Sent: Wednesday, October 31, 2001 9:32 AM > To: Bill Medland > Cc: wine-devel(a)winehq.com > Subject: Re: LockFile - any words of warning? > > > On Wed, 31 Oct 2001 08:31:11 -0800, you wrote: > > > I am going to have to implement the LockFile/UnlockFile > functions. Does > > anyone have any words of warning? (Like it ain't as easy > as calling fcntl) > > Have a look at Corel's wine tree, where it is implemented. Please excuse my ignorance; how do I get at the Corel tree?

3 3

change cdrom?
by Per Wigren Nov. 1, 2001

Nov. 1, 2001

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi! I have an annoying problem installing Grim Fandango. It comes on 2 cds. If I mount the cd and run "wine setup.exe" it starts to install until it asks for cd #2. But I can't unmount the CD to put in cd2 because it's busy... If I run "eject", it ejects but it still seems to be cached so it doesn't recognize that I've changed cd! Also: # wine D:\\setup.exe with the cdrom unmounted doesn't work either... :( Any solution to this problem? Regards Per Wigren -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (GNU/Linux) Comment: For info see http://www.gnupg.org iD8DBQE74YVNyjnjcyLO8HkRAuJmAKCbfxoGueuTnzVO4PZ2W1MQB7hIrgCgmhQt MembJfuT4wVuZyERmHMd+VM= =npbq -----END PGP SIGNATURE-----

2 2

Re: audio.c converted from WaitForSingleObject to poll
by Ove Kaaven Nov. 1, 2001

Nov. 1, 2001

On Wed, 31 Oct 2001, Simon Britnell wrote: > 2) Removes the need to calculate a sleep interval in > the wodPlayer main loop, as it loops only when dsp is > ready to be written or a command is ready to be > received. Well, it seems like a bad idea to make the player thread enter a busy loop when there isn't enough data to fill the device buffers, don't you think? (Well, though I'd like buffer complete notifications to happen more frequently than they do in Wine's current implementation, making the player thread use 100% CPU isn't the way...)

4 10

mmsystem.c callback thread patch.
by Simon Britnell Nov. 1, 2001

Nov. 1, 2001

The patch I wrote for mmsystem.c doesn't fix my problem with HomeWorld, so back to the drawing board on that one. The patch fixes a problem that I've only ever seen in HalfLife while I was messing with the innards of wodPlayer and assumes that wodPlayer_Notify can trigger a callback into the application. If that assumption is invalid, please ignore the patch and let me know so I can look into it further. Note that this also changes the semantics of the callbacks because wodPlayer is not halted waiting for the callback to complete, __________________________________________________ Do You Yahoo!? Make a great connection at Yahoo! Personals. http://personals.yahoo.com

1 0

Re: config.h reorg part 2: config.h includes
by François Gouget Nov. 1, 2001

Nov. 1, 2001

François Gouget wrote: [...] > Changelog: > > François Gouget <fgouget(a)codeweavers.com> > > * console/xterm.c, [...] > windows/x11drv/clipboard.c > > Fix the #include order for config.h > Add #include "config.h" directives where needed > Fixes the FILE_OFFSET_BITS redefinition warnings on Solaris (part 2) There was a #include config.h missing in dlls/ddraw/mesa.c in the above patch. The attached patch fixes that. It complements part 2 (p20011031-config.diff) and must thus be applied before part 3 (p20011031-config2.diff) -- François Gouget fgouget(a)codeweavers.com Index: dlls/ddraw/mesa.c =================================================================== RCS file: /home/wine/wine/dlls/ddraw/mesa.c,v retrieving revision 1.3 diff -u -r1.3 mesa.c --- dlls/ddraw/mesa.c 2000/11/27 23:54:26 1.3 +++ dlls/ddraw/mesa.c 2001/11/01 07:51:07 @@ -3,6 +3,8 @@ This file contains all MESA common code */ +#include "config.h" + #include "windef.h" #include "wine/obj_base.h" #include "ddraw.h"

1 0

Re: L"YES" is a NO NO!!!
by Dmitry Timoshkov Nov. 1, 2001

Nov. 1, 2001

"Francois Gouget" <fgouget(a)free.fr> wrote: > Wine cannot use Unicode strings literals. When you write L"YES" this > is a 32bit Unicode string, not a 16bit unicode string. This means that > when you pass it to lstrcmpiW, which expects 16bit Unicode strings like > all the APIs in Wine, what it sees is this: "Y\0E\0S\0\0\0". And this is > obviously different from "YES". > > > I guess it pays to check the warnings form time to time! Sure. Why not to change L'\0' to a simple 0 in your patch then? @@ -447,10 +451,10 @@ switch (type) { case REG_SZ: data[9] = L'\0'; /* set end of string */ ^^^^^^^^^^^^^^^ -- Dmitry.

2 1

Duplicate StrRetToStr function in commdlg
by Francois Gouget Nov. 1, 2001

Nov. 1, 2001

Yes, yet another duplicated StrRetToStr function: COMDLG32_StrRetToStrNW in dlls/commdlg/filedlgbrowser.c. At least this time it says that it's a copy. I guess it would be better if the implementations were pointing to each other. It would at least make it easier to maintain. But this case is not as easy as the shell32 case: * first the implementation is slightly different: the SHFree is not commented out in this one. I don't think the difference is intentional. So who is right? * commdlg is not supposed to import shell32. But it already imports a couple of other functions from shell32 so why not this one? It would be better than have another inconsisten implementation. * except that StrRetToStrNW is not exported. It is StrRetToStrN which is exported. So is it ok to call StrRetToStrN? Is StrRetToStrNW really more correct? Well, here is a proposed patch that imports StrRetToStrN from shell32 via the already-in-place GPA mechanism and removes COMDLG32_StrRetToStrNW. Comments? -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ La terre est une bêta...

1 0